DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

[Impeller] use correct blend mode for performance overlay (flutter/engine#45365)

Browse Source 
Man this is a sharp 🔪 

I literally pointed this out in the review and failed to notice the wrong parameter had the blend mode.
This commit is contained in:
Jonah Williams 2023-08-31 20:47:52 -07:00 committed by GitHub
parent 83ece1f3e3
commit bad97b052b
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
engine/src/flutter/flow/stopwatch_dl.cc
View File

@ -101,7 +101,11 @@ void DlStopwatchVisualizer::Visualize(DlCanvas* canvas,
}
// Actually draw.
// Note we use kSrcOver, because some of the colors above have opacity < 1.0.
// Use kSrcOver blend mode so that elements under the performance overlay are
// partially visible.
paint.setBlendMode(DlBlendMode::kSrcOver);
// The second blend mode does nothing since the paint has no additional color
// sources like a tiled image or gradient.
canvas->DrawVertices(painter.IntoVertices(), DlBlendMode::kSrcOver, paint);
}