Jonah Williams
c8d04e64dc
[Impeller] add support for specialization constants. ( flutter/engine#47432 )
...
Adds support for Specialization constants to Impeller for our usage in the engine. A motivating example has been added in the impeller markdown docs.
Fixes https://github.com/flutter/flutter/issues/136210
Fixes https://github.com/flutter/flutter/issues/119357
2023-11-02 17:32:08 +00:00
skia-flutter-autoroll
d6b5a87f11
Roll Skia from 8299245af8a8 to 70634da5c783 (1 revision) ( flutter/engine#47604 )
...
https://skia.googlesource.com/skia.git/+log/8299245af8a8..70634da5c783
2023-11-02 johnstiles@google.com Use WGSL select for trivial ternary expressions only.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-02 16:50:02 +00:00
Victoria Ashworth
88bfe1a6da
Fix race condition in Platform View Scenario tests ( flutter/engine#47575 )
...
Fixes race condition in Platform View Scenario tests, see https://github.com/flutter/flutter/issues/126627 for description of issue.
Fixes https://github.com/flutter/flutter/issues/137547 and https://github.com/flutter/flutter/issues/126627 .
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-11-02 15:16:46 +00:00
skia-flutter-autoroll
936eb5a66e
Roll Fuchsia Linux SDK from pvAbHwPJtOuEpHJN7... to YS7vrarYI-cHvhuBT... ( flutter/engine#47602 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-02 15:09:02 +00:00
Jason Simmons
cd32fb6c82
Update DisplayList tests to explicitly select the Roboto font ( flutter/engine#47493 )
...
Skia is removing the API for constructing a default typeface (see https://issues.skia.org/issues/305780908 )
Fixes https://github.com/flutter/flutter/issues/137565
2023-11-02 14:42:00 +00:00
skia-flutter-autoroll
2abeacb556
Roll Skia from 54be0f6f205b to 8299245af8a8 (2 revisions) ( flutter/engine#47601 )
...
https://skia.googlesource.com/skia.git/+log/54be0f6f205b..8299245af8a8
2023-11-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f2b199b522ce to c604e04c8136 (3 revisions)
2023-11-02 egdaniel@google.com [Graphite] Add query for resourceType to graphite Resources
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-02 14:34:56 +00:00
skia-flutter-autoroll
93f05eaa6a
Roll Skia from ff5e220c57e4 to 54be0f6f205b (1 revision) ( flutter/engine#47599 )
...
https://skia.googlesource.com/skia.git/+log/ff5e220c57e4..54be0f6f205b
2023-11-02 kjlubick@google.com Decouple SVG from SkFontMgr::RefDefault()
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-02 13:50:05 +00:00
skia-flutter-autoroll
a60a54aa48
Roll Skia from 86ce6e04fddf to ff5e220c57e4 (1 revision) ( flutter/engine#47593 )
...
https://skia.googlesource.com/skia.git/+log/86ce6e04fddf..ff5e220c57e4
2023-11-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 9d518424af37 to 8d5c79533765 (15 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-02 08:49:10 +00:00
skia-flutter-autoroll
b3595c9ac5
Roll Skia from 8a5e27e4607c to 86ce6e04fddf (1 revision) ( flutter/engine#47591 )
...
https://skia.googlesource.com/skia.git/+log/8a5e27e4607c..86ce6e04fddf
2023-11-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 563569acfcaf to 053aa9155a28 (7 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-02 07:39:05 +00:00
skia-flutter-autoroll
eecbabf75f
Roll Fuchsia Mac SDK from Lrg_lElxg0BmYp97-... to 32ukjtetQl4pbXfTw... ( flutter/engine#47590 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-02 05:57:31 +00:00
Jim Graham
049bac3249
Add some important comments to some of the FilteContents methods ( flutter/engine#47567 )
...
Fixes https://github.com/flutter/flutter/issues/137703
Also clarified and fixed indentation on docstring comment for the public method `FilterContents::GetSourceCoverage`
2023-11-02 05:30:51 +00:00
skia-flutter-autoroll
6dc921101d
Roll Skia from 66bbeb412a59 to 8a5e27e4607c (1 revision) ( flutter/engine#47589 )
...
https://skia.googlesource.com/skia.git/+log/66bbeb412a59..8a5e27e4607c
2023-11-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 42507df31d51 to a98afa276db2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-02 04:44:10 +00:00
skia-flutter-autoroll
3da43ec90d
Roll Skia from 39776c81d2b8 to 66bbeb412a59 (1 revision) ( flutter/engine#47588 )
...
https://skia.googlesource.com/skia.git/+log/39776c81d2b8..66bbeb412a59
2023-11-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from dacb7ead0e0b to 7096daca8739 (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-02 03:21:56 +00:00
skia-flutter-autoroll
48b23b3d79
Roll Skia from 65b5bcd6c365 to 39776c81d2b8 (2 revisions) ( flutter/engine#47587 )
...
https://skia.googlesource.com/skia.git/+log/65b5bcd6c365..39776c81d2b8
2023-11-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 54bfabb1adb0 to f2b199b522ce (6 revisions)
2023-11-02 nicolettep@google.com Add Graphite Vulkan build tasks to CQ
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-02 02:27:56 +00:00
skia-flutter-autoroll
c3e13cd88e
Roll Fuchsia Linux SDK from G6icdRMZm9dD9Oky1... to pvAbHwPJtOuEpHJN7... ( flutter/engine#47585 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-02 02:13:04 +00:00
Jim Graham
edba128d44
[Impeller] Move all remaining Rect construction to named factories ( flutter/engine#47582 )
...
The named factories provide better readability and do not imply an internal storage format (which will be changing soon).
2023-11-02 02:03:09 +00:00
skia-flutter-autoroll
3ead96c860
Roll Skia from 945284d57785 to 65b5bcd6c365 (12 revisions) ( flutter/engine#47581 )
...
https://skia.googlesource.com/skia.git/+log/945284d57785..65b5bcd6c365
2023-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from 95905c606f46 to 445a3a5c87f5
2023-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 36b938f4bd91 to f97385e8c26a
2023-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from d6a42e45bfea to 1747ffa9b114
2023-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from 1f541ad1b6bd to 8449ce1d6518
2023-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 10d18c9f187d to dacb7ead0e0b (1 revision)
2023-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from a536f59bdab0 to 95905c606f46
2023-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 18d9396e0e23 to 36b938f4bd91
2023-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from b842291db7bb to d6a42e45bfea
2023-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from b8b6ef8feccd to 1f541ad1b6bd
2023-11-01 jamesgk@google.com [graphite] Put render step uniforms in storage buffer
2023-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 59b3b32e331b to 10d18c9f187d (2 revisions)
2023-11-01 robertphillips@google.com [graphite] Add some Vulkan result checking
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-02 01:50:50 +00:00
auto-submit[bot]
03c46c6b49
Reverts "Expose more methods on ui.Paragraph: lines" ( flutter/engine#47584 )
...
Reverts flutter/engine#46125
Initiated by: LongCatIsLooong
This change reverts the following previous change:
Original Description:
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-11-02 01:12:20 +00:00
LongCatIsLooong
b263241336
Expose more methods on ui.Paragraph: lines ( flutter/engine#46125 )
...
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-11-02 00:39:36 +00:00
Gray Mackall
01700054b7
Change FTL test to high capacity device ( flutter/engine#47579 )
...
Changes the FTL tests to use a high capacity device
Similar PR from packages repo: https://github.com/flutter/packages/pull/5224
The list of devices (and their capacity) is visible through the [3rd option here "Google APIs Explorer"](https://firebase.google.com/docs/test-lab/android/available-testing-devices ), without a login to any project.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-11-02 00:18:12 +00:00
skia-flutter-autoroll
7eb0b18964
Roll Skia from 613abdf2c895 to 945284d57785 (1 revision) ( flutter/engine#47564 )
...
https://skia.googlesource.com/skia.git/+log/613abdf2c895..945284d57785
2023-11-01 kjlubick@google.com Remove modules/skplaintexteditor
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-01 19:39:22 +00:00
Brandon DeRosier
4f6c063a8e
Bump impeller-cmake to head ( flutter/engine#47563 )
...
https://github.com/bdero/impeller-cmake/pull/20
Fixes breakages from:
* https://github.com/flutter/engine/pull/47080
* https://github.com/flutter/engine/pull/47247
* https://github.com/flutter/engine/pull/47278
2023-11-01 12:32:13 -07:00
skia-flutter-autoroll
e62a89e9db
Roll Skia from 84e1dc3af49e to 613abdf2c895 (4 revisions) ( flutter/engine#47560 )
...
https://skia.googlesource.com/skia.git/+log/84e1dc3af49e..613abdf2c895
2023-11-01 jvanverth@google.com [graphite] PerEdgeAAQuadRenderStep: remove unused and unneeded vars.
2023-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from a55ce4970dfd to 18d9396e0e23
2023-11-01 johnstiles@google.com Add placeholder skcms_Transform.h to skcms.
2023-11-01 egdaniel@google.com [Graphite] Add uniqueID to all Resources.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-01 17:53:55 +00:00
skia-flutter-autoroll
256e982e21
Roll Skia from 4594e2ef3ee8 to 84e1dc3af49e (1 revision) ( flutter/engine#47558 )
...
https://skia.googlesource.com/skia.git/+log/4594e2ef3ee8..84e1dc3af49e
2023-11-01 jvanverth@google.com Reland "[graphite] Simplify vertex processing for PerEdgeAAQuadRenderStep."
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-01 17:07:05 +00:00
Jason Simmons
cce2f9ced2
Consolidate all the copies of the OpenFixtureAsSkData testing helper function ( flutter/engine#47491 )
2023-11-01 17:03:05 +00:00
skia-flutter-autoroll
6497399efb
Roll Dart SDK from 15558b6ae7d5 to e6df03a57636 (1 revision) ( flutter/engine#47556 )
...
https://dart.googlesource.com/sdk.git/+log/15558b6ae7d5..e6df03a57636
2023-11-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-87.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-01 16:25:12 +00:00
skia-flutter-autoroll
ad48f935db
Roll Skia from 816d41255105 to 4594e2ef3ee8 (1 revision) ( flutter/engine#47555 )
...
https://skia.googlesource.com/skia.git/+log/816d41255105..4594e2ef3ee8
2023-11-01 kjlubick@google.com Delete experimental/sktext
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-01 16:09:30 +00:00
skia-flutter-autoroll
6bff1ecbfb
Roll Skia from 8fabb1ce2065 to 816d41255105 (1 revision) ( flutter/engine#47553 )
...
https://skia.googlesource.com/skia.git/+log/8fabb1ce2065..816d41255105
2023-11-01 brianosman@google.com Remove ColorStopOptimizer
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-01 14:32:18 +00:00
skia-flutter-autoroll
378ba1156a
Roll Fuchsia Linux SDK from _TyF0etsONe5aqCbM... to G6icdRMZm9dD9Oky1... ( flutter/engine#47551 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-01 13:31:12 +00:00
skia-flutter-autoroll
667721baf1
Roll Skia from b7ac9da3e5ac to 8fabb1ce2065 (1 revision) ( flutter/engine#47550 )
...
https://skia.googlesource.com/skia.git/+log/b7ac9da3e5ac..8fabb1ce2065
2023-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from c7c1b6a6441e to 54bfabb1adb0 (7 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-01 12:54:36 +00:00
skia-flutter-autoroll
bd169dc790
Roll Dart SDK from 62aceb5e057d to 15558b6ae7d5 (1 revision) ( flutter/engine#47549 )
...
https://dart.googlesource.com/sdk.git/+log/62aceb5e057d..15558b6ae7d5
2023-11-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-86.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-01 12:35:40 +00:00
skia-flutter-autoroll
bf3d3d6816
Roll Skia from f1983b5af2ef to b7ac9da3e5ac (1 revision) ( flutter/engine#47548 )
...
https://skia.googlesource.com/skia.git/+log/f1983b5af2ef..b7ac9da3e5ac
2023-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 8e8b4dc940dc to 563569acfcaf (10 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-01 12:05:07 +00:00
skia-flutter-autoroll
34fcc23996
Roll Fuchsia Mac SDK from x2NzYMNhyodIwDl0I... to Lrg_lElxg0BmYp97-... ( flutter/engine#47547 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-01 11:48:04 +00:00
skia-flutter-autoroll
cb5a26c08c
Roll Skia from 83d6345dd3c2 to f1983b5af2ef (2 revisions) ( flutter/engine#47541 )
...
https://skia.googlesource.com/skia.git/+log/83d6345dd3c2..f1983b5af2ef
2023-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 2c27f85a1e61 to d8f2bd60cf90
2023-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 1f568ab4ba16 to 9d518424af37 (15 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-01 06:19:05 +00:00
skia-flutter-autoroll
0037dc1cba
Roll Dart SDK from 448293573e98 to 62aceb5e057d (1 revision) ( flutter/engine#47540 )
...
https://dart.googlesource.com/sdk.git/+log/448293573e98..62aceb5e057d
2023-11-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-85.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-01 06:11:09 +00:00
skia-flutter-autoroll
daf9ad02af
Roll Skia from 34ef20100acc to 83d6345dd3c2 (1 revision) ( flutter/engine#47538 )
...
https://skia.googlesource.com/skia.git/+log/34ef20100acc..83d6345dd3c2
2023-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 61b4a8b2976d to 2c27f85a1e61 (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-01 05:28:00 +00:00
skia-flutter-autoroll
4f0f03e58d
Roll Dart SDK from 99fa0283f9d7 to 448293573e98 (1 revision) ( flutter/engine#47534 )
...
https://dart.googlesource.com/sdk.git/+log/99fa0283f9d7..448293573e98
2023-11-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-84.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-01 02:19:18 +00:00
Brandon DeRosier
480a99ac7e
[Impeller] Include cstdint everywhere that uint32_t is used. ( flutter/engine#47533 )
...
Sprinkle cstdint everywhere that it's used. Unblocks the next impeller-cmake bump.
Ran into include issues during the build for the most recent impeller-cmake bump: https://github.com/bdero/impeller-cmake/pull/20
Going to add an optional libcxx STL build to help avoid stuff like this later (in the AAOS action items).
2023-11-01 01:42:14 +00:00
Brandon DeRosier
7cf7fc7d1c
[Impeller] Fix nullopt access and simplify coverage computation in GetSubpassCoverage. ( flutter/engine#47347 )
...
Follow up for comments in https://github.com/flutter/engine/pull/46130 .
This case shouldn't actually be possible today, but we should be able to
make this reasonably testable without goldens... added an issue to
follow-up here: https://github.com/flutter/flutter/issues/137356
This branch noise will also melt away with:
https://github.com/flutter/flutter/issues/137306
2023-10-31 18:15:56 -07:00
Brandon DeRosier
849bb11c9e
[Impeller] OpenGLES: Ensure frag/vert textures are bound with unique texture units. ( flutter/engine#47218 )
...
The fragment shader texture bindings will smash into the texture units
used for the vertex shader bindings if the vertex and fragment shaders
both have textures.
Entities doesn't use any pipelines that tickle this case.
2023-10-31 18:05:07 -07:00
skia-flutter-autoroll
61356479d0
Roll Fuchsia Linux SDK from LCfhx_lTRJI51G0zc... to _TyF0etsONe5aqCbM... ( flutter/engine#47532 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-01 00:44:58 +00:00
Jonah Williams
a0b00f5fe3
[Impeller] stencil buffer record/replay instead of MSAA storage. ( flutter/engine#47397 )
...
When restoring from a backdrop filter, replay the clip affecting cmds into a new stencil buffer instead of storing 4x MSAA stencil buffer.
Fixes https://github.com/flutter/flutter/issues/137561
Fixes https://github.com/flutter/flutter/issues/137448
Fixes https://github.com/flutter/flutter/issues/137302
Helps https://github.com/flutter/flutter/issues/137108
2023-11-01 00:23:37 +00:00
Chris Bracken
44c1e92369
[macOS] Delete FlutterCompositor tests ( flutter/engine#47527 )
...
The tests for FlutterCompositor are not useful. The current tests test two things:
1. That the mocks we set up behave the way we set them up to behave.
2. That the implementation of FlutterCompositor is the current implementation of FlutterCompositor.
As an example, consider FlutterCompositorTest.TestPresent: 70317028f2/shell/platform/darwin/macos/framework/Source/FlutterCompositorTest.mm (L107-L137)70317028f2/shell/platform/darwin/macos/framework/Source/FlutterCompositorTest.mm (L47-L85)https://github.com/flutter/flutter/issues/137648
Encountered these tests as part of deflaking and cleaning up memory allocations throughout the macOS desktop tests.
Issue: https://github.com/flutter/flutter/issues/137648
Issue: https://github.com/flutter/flutter/issues/104789
Issue: https://github.com/flutter/flutter/issues/127441
Issue: https://github.com/flutter/flutter/issues/124840
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-11-01 00:11:52 +00:00
Brandon DeRosier
483ca29940
[Impeller] Place Rect statics under the Rect template. ( flutter/engine#47529 )
...
`Rect::Intersection(a, b)` instead of `Intersection(a, b)`, etc.
Make them usable with other Rect variants, although `RoundOut` is not useful for integer rectangles, for example.
2023-10-31 23:57:58 +00:00
skia-flutter-autoroll
6398c13114
Roll Skia from aaa225e0cc6d to 34ef20100acc (1 revision) ( flutter/engine#47530 )
...
https://skia.googlesource.com/skia.git/+log/aaa225e0cc6d..34ef20100acc
2023-10-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 9700973b4f9a to c7c1b6a6441e (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-31 23:57:55 +00:00
skia-flutter-autoroll
caee11baf3
Roll Fuchsia Mac SDK from rg_Ici1tgAVF93cn9... to x2NzYMNhyodIwDl0I... ( flutter/engine#47528 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-31 23:03:19 +00:00
gaaclarke
b4647d2ef8
[Impeller] updated ios benchmark link ( flutter/engine#47515 )
...
This md references `new_gallery_impeller_ios__transition_perf` which is
no longer updated.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-10-31 15:35:48 -07:00
gaaclarke
52fcefb32a
Made clang tidy use arm64 if on an arm64 mac. ( flutter/engine#47494 )
...
fixes https://github.com/flutter/flutter/issues/137260
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
---------
Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
2023-10-31 15:35:36 -07:00
Brandon DeRosier
eb6c33cee1
[Impeller] Allow 3D scenes to render when MSAA is not supported. ( flutter/engine#47217 )
...
Before, Impeller Scene would render nothing on the GLES backend when used through Aiks.
2023-10-31 22:31:56 +00:00
Matan Lurey
63d44d17dc
Surgically remove .*dither.* from the Engine ( flutter/engine#46750 )
...
Closes https://github.com/flutter/flutter/issues/112498 .
We no longer support any user-visible configuration around dithering. It is unconditionally applied for gradients (in both the Skia and Impeller backends), and never applied elsewhere. After this change, I'll update https://docs.flutter.dev/release/breaking-changes/paint-enableDithering accordingly.
---
~~Requires https://github.com/flutter/engine/pull/46746 to land successfully~~ Done.
Alright, this appears ready to review!
2023-10-31 22:28:00 +00:00
