Chinmay Garde
c8a7439178
Rename Skia specific TUs. ( flutter/engine#52855 )
...
Fixes https://github.com/flutter/flutter/issues/148235
2024-05-24 18:40:18 +00:00
Harry Terkelsen
1f57178c37
[canvaskit] Fix overlay reorganization for edge case with only 1 overlay ( flutter/engine#53006 )
...
When there is only 1 overlay, move pictures in the reduced rendering to the last canvas instead of the second-to-last.
Fixes a bug in https://github.com/flutter/engine/pull/51397
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-05-24 18:00:06 +00:00
skia-flutter-autoroll
7615b27ee5
Roll Dart SDK from 49b226cecee7 to 4ef8ed68a8d4 (1 revision) ( flutter/engine#53024 )
...
https://dart.googlesource.com/sdk.git/+log/49b226cecee7..4ef8ed68a8d4
2024-05-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-190.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-24 17:58:23 +00:00
skia-flutter-autoroll
c5eda847c0
Roll Skia from f832549400ab to 97783ac3000d (1 revision) ( flutter/engine#53023 )
...
https://skia.googlesource.com/skia.git/+log/f832549400ab..97783ac3000d
2024-05-24 kjlubick@google.com Cleanup vulkan memory allocator and include in Bazel build (for now)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-24 17:49:59 +00:00
gaaclarke
e6b3c034ea
[Impeller] sped up the linear gradient by moving calculations to the cpu ( flutter/engine#53007 )
...
issue: https://github.com/flutter/flutter/issues/148496
The linked issue showed us as ALU bound with the linear gradient, this should relieve some of that pressure.
Tests: There is already existing golden tests for this, this just changed the performance, no new functionality.
## summary of math improvements:
- (num_colors - 1) * division -> multiplication
- (num_colors - 1) * subtractions removed
- removes 1 `dot()`
- 1 division -> multiplication
- 1 subtraction removed
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-05-24 17:40:53 +00:00
skia-flutter-autoroll
0d2067cbb6
Roll Skia from 956e77ac96fd to f832549400ab (1 revision) ( flutter/engine#53022 )
...
https://skia.googlesource.com/skia.git/+log/956e77ac96fd..f832549400ab
2024-05-24 michaelludwig@google.com [graphite] Fix synchronous readback on WebGPU
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-24 15:35:18 +00:00
skia-flutter-autoroll
6d1638946b
Roll Skia from 92f576fd2c52 to 956e77ac96fd (2 revisions) ( flutter/engine#53021 )
...
https://skia.googlesource.com/skia.git/+log/92f576fd2c52..956e77ac96fd
2024-05-24 eriksombroek@gmail.com Add asWinding, isEmpty and addReversePath to SKPath export
2024-05-24 ccameron@chromium.org Add SkDynamicMemoryEndianWStream
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-24 14:28:37 +00:00
skia-flutter-autoroll
2a72db9b37
Roll Dart SDK from fef7786d65f9 to 49b226cecee7 (1 revision) ( flutter/engine#53020 )
...
https://dart.googlesource.com/sdk.git/+log/fef7786d65f9..49b226cecee7
2024-05-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-189.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-24 13:54:12 +00:00
skia-flutter-autoroll
5d5fc7e394
Roll Skia from 8b8cf5b49988 to 92f576fd2c52 (1 revision) ( flutter/engine#53019 )
...
https://skia.googlesource.com/skia.git/+log/8b8cf5b49988..92f576fd2c52
2024-05-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 85e49a91a4ff to bbb437b80fa1 (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-24 13:28:21 +00:00
skia-flutter-autoroll
6d097a7581
Roll Skia from 33f0e2e61db9 to 8b8cf5b49988 (1 revision) ( flutter/engine#53017 )
...
https://skia.googlesource.com/skia.git/+log/33f0e2e61db9..8b8cf5b49988
2024-05-24 drott@chromium.org [Fontations-backend] Hint advances and support linear advances
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-24 09:25:24 +00:00
skia-flutter-autoroll
db7b476001
Roll Skia from fc250ec3157f to 33f0e2e61db9 (1 revision) ( flutter/engine#53016 )
...
https://skia.googlesource.com/skia.git/+log/fc250ec3157f..33f0e2e61db9
2024-05-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 602c0edfc1f2 to 066cde8b1259 (9 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-24 08:19:56 +00:00
skia-flutter-autoroll
dd507ffa6a
Roll Skia from 447b7a9db1a7 to fc250ec3157f (1 revision) ( flutter/engine#53015 )
...
https://skia.googlesource.com/skia.git/+log/447b7a9db1a7..fc250ec3157f
2024-05-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 20b2eb18a250 to a4f76cda0587 (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-24 06:54:23 +00:00
skia-flutter-autoroll
754d4382b9
Roll Skia from 0a5870c8a4b4 to 447b7a9db1a7 (1 revision) ( flutter/engine#53014 )
...
https://skia.googlesource.com/skia.git/+log/0a5870c8a4b4..447b7a9db1a7
2024-05-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from bf0c5d6b9d00 to 90519141a709 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-24 05:52:25 +00:00
skia-flutter-autoroll
965dd8c241
Roll Fuchsia Linux SDK from jQHA0UEiQtfQTuWzM... to 9PoD1BZXVglZ-EWu3... ( flutter/engine#53012 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-24 04:30:11 +00:00
skia-flutter-autoroll
7169f1d11c
Roll Dart SDK from 9d7324ea563a to fef7786d65f9 (1 revision) ( flutter/engine#53011 )
...
https://dart.googlesource.com/sdk.git/+log/9d7324ea563a..fef7786d65f9
2024-05-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-188.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-24 04:28:05 +00:00
skia-flutter-autoroll
0c348d235b
Roll Skia from f2053e772e6f to 0a5870c8a4b4 (1 revision) ( flutter/engine#53010 )
...
https://skia.googlesource.com/skia.git/+log/f2053e772e6f..0a5870c8a4b4
2024-05-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 20b2eb18a250 to a4f76cda0587
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-24 02:51:37 +00:00
skia-flutter-autoroll
a83437b7ed
Roll Skia from 2ef772706cda to f2053e772e6f (1 revision) ( flutter/engine#53009 )
...
https://skia.googlesource.com/skia.git/+log/2ef772706cda..f2053e772e6f
2024-05-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f8bd64f3d2c3 to 85e49a91a4ff (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-24 00:39:22 +00:00
skia-flutter-autoroll
4c98a6478c
Roll Dart SDK from 7809d6e332ff to 9d7324ea563a (7 revisions) ( flutter/engine#53008 )
...
https://dart.googlesource.com/sdk.git/+log/7809d6e332ff..9d7324ea563a
2024-05-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-187.0.dev
2024-05-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-186.0.dev
2024-05-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-185.0.dev
2024-05-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-184.0.dev
2024-05-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-183.0.dev
2024-05-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-182.0.dev
2024-05-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-181.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-24 00:19:53 +00:00
LongCatIsLooong
35ca2dd175
Allow unsetting TextStyle.height ( flutter/engine#52940 )
...
Introduces a sentinel value `kTextHeightNone` for `ui.TextStyle.height` which can be used to "unset" the current `TextStyle.height` (and for consistency, it applies to `StructStyle.height` and `ParagraphStyle.height` too). Documentation of `TextStyle.height` can be found [here](https://main-api.flutter.dev/flutter/painting/TextStyle/height.html ) (the one from `painting` library not `dart:ui`).
part of https://github.com/flutter/flutter/issues/58765 : currently `TextStyle.height` uses `null` as the sentinel value for "no height multiplier specified, use the font height", which has conflicting semantics: it means the height multiplier is not set (so the span height is determined by font metrics) but in reality it also means the height should inherit from its parent span (or in `copyWith` context, it means do not override the height).
The new sentinel value `kTextHeightNone` is currently set to `0.0`. This is because skparagraph internally uses 0 for "no height multiplier", so using 0 should minimize the behavior change:
62f369c759/modules/skparagraph/src/Run.cpp (L65-L67)https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-05-24 00:16:16 +00:00
Chinmay Garde
6b36f0f40b
Cleanup propagation of codecvt warning suppression in FML. ( flutter/engine#52966 )
...
Previously, because the suppression was local, every user of the the header had to manually add the flag. Now the flag will be propagated to the targets automatically. This linked issue still needs to be fixed but the fix can now be more isolated.
2024-05-23 21:03:52 +00:00
skia-flutter-autoroll
69cfdf325c
Roll Skia from 60ed6f47af08 to 2ef772706cda (3 revisions) ( flutter/engine#53003 )
...
https://skia.googlesource.com/skia.git/+log/60ed6f47af08..2ef772706cda
2024-05-23 bwils@google.com Additional specifiction conformance updates
2024-05-23 robertphillips@google.com [graphite] Add HighContrast and Overdraw colorFilters to Precompilation system
2024-05-23 bungeman@google.com Add /Zc:lambda to Skia's msvc build
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-23 21:03:49 +00:00
Harry Terkelsen
08b343b90d
Move pictures from deleted canvases to second-to-last canvas instead of last. ( flutter/engine#51397 )
...
Previously, when the number of display canvases exceeded the maximum amount, we would augment the rendering to reduce the number of canvases to the maximum amount, and move the pictures from the deleted canvases to the last canvas. However, this would cause ugly rendering in cases where pictures would render on top of the platform views they were supposed to be underneath.
This is especially noticeable when reproducing this bug: https://github.com/flutter/flutter/issues/144854
This changes things slightly so that the pictures are moved to the second-to-last remaining canvas, so that platform views always render over the pictures they are supposed to.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-05-23 18:36:05 +00:00
skia-flutter-autoroll
464f017be0
Roll Skia from 8af1d36fbccb to 60ed6f47af08 (2 revisions) ( flutter/engine#52999 )
...
https://skia.googlesource.com/skia.git/+log/8af1d36fbccb..60ed6f47af08
2024-05-23 robertphillips@google.com [graphite] Remove makeWithCTM from PrecompileShader
2024-05-23 robertphillips@google.com Update tolerances for ImageAsyncReadPixels/SurfaceContextWritePixels tests
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-23 17:10:06 +00:00
skia-flutter-autoroll
f3844fcb0e
Roll Skia from 7fcb4edbd9b7 to 8af1d36fbccb (1 revision) ( flutter/engine#52998 )
...
https://skia.googlesource.com/skia.git/+log/7fcb4edbd9b7..8af1d36fbccb
2024-05-23 michaelludwig@google.com [graphite] Disable D16 on qualcomm devices in protected contexts
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-23 16:01:08 +00:00
Brandon DeRosier
5b84b2c85b
[Impeller] Fix stroke curves. ( flutter/engine#52978 )
...
Resolves https://github.com/flutter/flutter/issues/147139 .
Added an explanation inline for why we need to use different direction values depending on whether or not we're capping off the last component of the contour.
Before:
<img width="640" alt="Screenshot 2024-05-21 at 11 18 51â¯PM" src="https://github.com/flutter/engine/assets/919017/22d9fee7-834f-4cb4-8ed4-578a7c17f7a2 ">
<img width="121" alt="Screenshot 2024-05-21 at 11 19 35â¯PM" src="https://github.com/flutter/engine/assets/919017/419029b1-9a5f-4a30-bbb0-83dafc79f7df ">
After:
<img width="640" alt="Screenshot 2024-05-21 at 11 17 25â¯PM" src="https://github.com/flutter/engine/assets/919017/629e30a5-d0c5-4b7a-a3e2-bf715aa4ba78 ">
<img width="115" alt="Screenshot 2024-05-21 at 11 16 38â¯PM" src="https://github.com/flutter/engine/assets/919017/12e51892-6009-47d0-a4e5-1f1b017c99e8 ">
2024-05-23 13:47:36 +00:00
skia-flutter-autoroll
9a392e9e07
Roll Skia from 371f52a008fa to 7fcb4edbd9b7 (1 revision) ( flutter/engine#52997 )
...
https://skia.googlesource.com/skia.git/+log/371f52a008fa..7fcb4edbd9b7
2024-05-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 322608986a23 to 602c0edfc1f2 (7 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-23 09:12:20 +00:00
skia-flutter-autoroll
eed82b656d
Roll Skia from 603607f7d249 to 371f52a008fa (1 revision) ( flutter/engine#52996 )
...
https://skia.googlesource.com/skia.git/+log/603607f7d249..371f52a008fa
2024-05-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 21666dacf743 to f8bd64f3d2c3 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-23 08:07:02 +00:00
skia-flutter-autoroll
754735b830
Roll Skia from 1b6281ae0816 to 603607f7d249 (1 revision) ( flutter/engine#52995 )
...
https://skia.googlesource.com/skia.git/+log/1b6281ae0816..603607f7d249
2024-05-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 56b6ffdc489a to 20b2eb18a250 (7 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-23 07:02:36 +00:00
skia-flutter-autoroll
fafade44ba
Roll Skia from 8cecdecc648e to 1b6281ae0816 (1 revision) ( flutter/engine#52994 )
...
https://skia.googlesource.com/skia.git/+log/8cecdecc648e..1b6281ae0816
2024-05-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from da334852e705 to bf0c5d6b9d00 (3 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-23 05:54:32 +00:00
skia-flutter-autoroll
d9e71c14e7
Roll Skia from 21c6fb26c14e to 8cecdecc648e (1 revision) ( flutter/engine#52993 )
...
https://skia.googlesource.com/skia.git/+log/21c6fb26c14e..8cecdecc648e
2024-05-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 56b6ffdc489a to 20b2eb18a250
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-23 04:17:27 +00:00
skia-flutter-autoroll
2f571cfb5f
Roll Fuchsia Linux SDK from gWBn6yPljFeQvPSYz... to jQHA0UEiQtfQTuWzM... ( flutter/engine#52992 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-23 03:27:11 +00:00
skia-flutter-autoroll
8bb5dc2a31
Roll Skia from 0ee149894a8d to 21c6fb26c14e (1 revision) ( flutter/engine#52991 )
...
https://skia.googlesource.com/skia.git/+log/0ee149894a8d..21c6fb26c14e
2024-05-22 michaelludwig@google.com [graphite] Use scratch textures for async readback
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-22 23:00:27 +00:00
skia-flutter-autoroll
d67684bd7a
Manual roll Dart SDK from fca7dd796e81 to 7809d6e332ff (2 revisions) ( flutter/engine#52986 )
...
Manual roll requested by kevinjchisholm@google.com
https://dart.googlesource.com/sdk.git/+log/fca7dd796e81..7809d6e332ff
2024-05-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-180.0.dev
2024-05-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-179.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jonahwilliams@google.com,kevinjchisholm@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-22 22:20:12 +00:00
skia-flutter-autoroll
a6e699d33b
Roll Skia from 380ae98608de to 0ee149894a8d (5 revisions) ( flutter/engine#52989 )
...
https://skia.googlesource.com/skia.git/+log/380ae98608de..0ee149894a8d
2024-05-22 jvanverth@google.com Add SDF version of surfaceprops GM.
2024-05-22 brianosman@google.com Disable the AAA "deferred" blitting
mode
2024-05-22 olv@google.com [Ganesh] Fix readPixels for planar textures on
Vulkan.
2024-05-22 robertphillips@google.com Deprecate SkShaderMaskFilters and
SkTableMaskFilters
2024-05-22 lehoangquyen@google.com Reland "GraphiteDawn: use dawn's
LoadResolveTexture extension." x2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
brianosman@google.com ,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-22 14:52:00 -07:00
skia-flutter-autoroll
f118c700d3
Roll Skia from 396c66076ab1 to 380ae98608de (4 revisions) ( flutter/engine#52983 )
...
https://skia.googlesource.com/skia.git/+log/396c66076ab1..380ae98608de
2024-05-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 2c797ac1064b to 21666dacf743 (3 revisions)
2024-05-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 66bc9cfa0014 to 322608986a23 (390 revisions)
2024-05-22 michaelludwig@google.com [graphite] Fix invalid assert condition in GraphiteResourceKey
2024-05-22 nicolettep@google.com [graphite] Add YCbCr info to Vulkan texture and sampler keys
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-22 18:37:01 +00:00
John McCutchan
88b596ca64
Reduce rebuild times when invoking 'et run' ( flutter/engine#52883 )
...
Android only for now but this avoids rebuilding a bunch of test targets that aren't necessary to do a `flutter run` with a custom engine.
I need to fill in some blanks for other platforms before landing.
2024-05-22 17:49:05 +00:00
Harry Terkelsen
3c9cdc8515
[canvaskit] Add dilate and erode imagefilters ( flutter/engine#48553 )
...
Adds `dilate` and `erode` ImageFilters.
Fixes https://github.com/flutter/flutter/issues/101085
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-05-22 10:42:20 -07:00
skia-flutter-autoroll
956c9dbc37
Roll Skia from 93ed643df6d1 to 396c66076ab1 (3 revisions) ( flutter/engine#52981 )
...
https://skia.googlesource.com/skia.git/+log/93ed643df6d1..396c66076ab1
2024-05-22 bungeman@google.com [shaper] Do nothing instead of crashing when no CTFont
2024-05-22 brianosman@google.com Remove unused pathops includes
2024-05-22 robertphillips@google.com Add testing of Runtime Shaders to PaintParamsKeyTest
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-22 17:37:02 +00:00
John McCutchan
c397bc6dc8
Fix another instance of platform view breakage on Android 14 ( flutter/engine#52980 )
...
When you background an activity via the back-gesture the onTrimMemory callback is not invoked but the buggy Android behaviour still occurs.
Workaround this by faking an onTrimMemory callback in the `Activity#onStop` callback.
Fixes #148662
Related #146499
Tested manually on a Pixel 7 Pro running Android 14.
2024-05-22 17:21:06 +00:00
skia-flutter-autoroll
b0a0f1269d
Roll Skia from f00ab116e24f to 93ed643df6d1 (1 revision) ( flutter/engine#52979 )
...
https://skia.googlesource.com/skia.git/+log/f00ab116e24f..93ed643df6d1
2024-05-22 michaelludwig@google.com [graphite] Prefer 16-bit depth buffers
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-22 16:31:26 +00:00
skia-flutter-autoroll
ca6fb517b8
Roll Skia from e0338616f368 to f00ab116e24f (2 revisions) ( flutter/engine#52977 )
...
https://skia.googlesource.com/skia.git/+log/e0338616f368..f00ab116e24f
2024-05-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 5bc1c10e55d1 to 56b6ffdc489a (7 revisions)
2024-05-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from bf00eb856e99 to 2c797ac1064b (3 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-22 06:31:24 +00:00
skia-flutter-autoroll
9948fd4489
Roll Skia from 78069713e02a to e0338616f368 (1 revision) ( flutter/engine#52976 )
...
https://skia.googlesource.com/skia.git/+log/78069713e02a..e0338616f368
2024-05-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 558a495933fa to 56b6ffdc489a
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-22 05:29:23 +00:00
skia-flutter-autoroll
d60c18d700
Roll Fuchsia Linux SDK from HHwlAJN5imwf3yX4i... to gWBn6yPljFeQvPSYz... ( flutter/engine#52975 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-22 02:16:21 +00:00
Brandon DeRosier
adc25beaf1
[Impeller] Round out subpass coverage. ( flutter/engine#52973 )
...
Resolves https://github.com/flutter/flutter/issues/146967
I added a detailed comment inline explaining why we need this. The visual issues in the reported issue were due to nearest sampling while straddling a half pixel offset.
Before:
After:
<img width="964" alt="image" src="https://github.com/flutter/engine/assets/919017/0be88453-1014-443b-bc80-6df459adb075 ">
2024-05-22 02:10:17 +00:00
skia-flutter-autoroll
bf12f56d92
Roll Skia from 968e971e438e to 78069713e02a (1 revision) ( flutter/engine#52974 )
...
https://skia.googlesource.com/skia.git/+log/968e971e438e..78069713e02a
2024-05-21 johnstiles@google.com Fix signedness of format string.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-22 00:12:02 +00:00
skia-flutter-autoroll
d6ab532076
Roll Dart SDK from f0ac30bbc63e to fca7dd796e81 (1 revision) ( flutter/engine#52972 )
...
https://dart.googlesource.com/sdk.git/+log/f0ac30bbc63e..fca7dd796e81
2024-05-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-178.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-21 22:35:09 +00:00
David Iglesias
63260fb965
[web] Adds Noto Serif Tibetan fallback font. ( flutter/engine#52971 )
...
This PR adds the "Noto Serif Tibetan" fallback font to Flutter Web, so it can render Dzongkha, and other languages in Tibetan script.
(In order to add this fallback font, an automated script is run which updates the versions and glyphs of other fallback fonts at the same time)
(Bundle uploaded to CIPD)
## Issues
* Fixes https://github.com/flutter/flutter/issues/148797
## Testing
* Added unit test for font resolution with sample text
* Manually, in localhost, using the sample Dzongkha test from the Noto site:
<img width="959" alt="Screenshot 2024-05-21 at 2 01 19â¯PM" src="https://github.com/flutter/engine/assets/1255594/3f2db34d-c004-4b90-9fda-62a9cff817f9 ">
```
à½à½ºà¼à½¡à½à¼ འà½à½à¼à½à¾³à½²à½à¼à½à½à¼à½à½²à¼à½à½²à¼à½à½à½ºà¼à½à½à¼à½à¾²à½à¼à½à¾²à½²à½à½¦à¼ à½à½ºà¼à½£à½¦à¼à½à½£à¼à½à½à½à¼à½à½´à¼à½à½²à¼à½à½à½²à¼à½ à½à¾±à½à¼à½à½à½¼à¼à½à½¼à¼à½à½ºà¼
```
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-05-21 22:22:26 +00:00
Jenn Magder
1ac1f8c5e3
Update file permissions for FlutterMacOS.framework bundle ( flutter/engine#52961 )
...
Fix typo from https://github.com/flutter/engine/pull/52930 . The entire framework bundle/directory needs 755 perms (not recursive), but that PR instead updated the binary within the framework bundle.
Once this rolls I'll rebase https://github.com/flutter/flutter/pull/148786 and merge that test.
Engine-side fix for https://github.com/flutter/flutter/issues/148354
2024-05-21 22:15:49 +00:00
Chinmay Garde
740b05b784
[Impeller] Remove check_licenses.py ( flutter/engine#52970 )
...
I could not find any users of this. As I understand, this was from a time [when Impeller wasn't a part of the
engine](https://github.com/flutter/flutter/issues/97686 ). Now the engine licenses checkers are sufficient.
2024-05-21 21:16:22 +00:00
Chinmay Garde
0c370f2f09
[Impeller] Delete impeller_trace_all_gl_calls. ( flutter/engine#52963 )
...
It's useless.
2024-05-21 21:16:20 +00:00
