DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
29,594 Commits 882 Branches 1,069 Tags
Commit Graph

22677 Commits

Author SHA1 Message Date
skia-flutter-autoroll
c87f7f691b Roll Skia from efc045c15fdd to a6412350122e (2 revisions) (flutter/engine#43036) 
https://skia.googlesource.com/skia.git/+log/efc045c15fdd..a6412350122e

2023-06-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from ae667fe96db9 to b8f1a3ad5f9e (2 revisions)
2023-06-21 kjlubick@google.com Move SkTestCanvas impl to its own cpp

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-21 05:58:59 +00:00
Bruno Leroux
8aff00a5d8 [Android] Return the keyboard pressed state (flutter/engine#42758) 
## Description

This PR updates the Android engine in order to answer to keyboard pressed state queries from the framework (as implemented in https://github.com/flutter/flutter/pull/122885).

This is a rework of https://github.com/flutter/engine/pull/41695 which was reverted in https://github.com/flutter/engine/pull/42346.

This issue with https://github.com/flutter/engine/pull/41695 was that the framework side did not get an answer when the channel was setup in the engine without registering a handler (on the engine side) to handle framework requests. The issue was reproducible when the engine initialization was managed by the app (see https://github.com/flutter/flutter/issues/122441#issuecomment-1582052616 for a repro).

This PR fixes this issue by changing `flutter/keyboard` lifecycle: the engine now creates the channel and registers a handler just after the channel creation.
In order to avoid regression, this PR also updates the channel implemenation (see `KeyboardChannel`) to return an empty `HashMap` when there is no handler registered.

## Related Issue

Android engine implementation for https://github.com/flutter/flutter/issues/87391
(see https://github.com/flutter/engine/pull/42346 for Linux implementation)
Fixes https://github.com/flutter/flutter/issues/122441

## Tests

Adds 3 tests.
 2023-06-21 05:49:06 +00:00
Jason Simmons
c4e22ba089 Implement the APNG_DISPOSE_OP_BACKGROUND disposal method in the animated PNG decoder (flutter/engine#42933) 2023-06-21 00:36:49 +00:00
skia-flutter-autoroll
81836d898a Roll Skia from 0b88d9031cd2 to 13d83a6912ce (4 revisions) (flutter/engine#43020) 
https://skia.googlesource.com/skia.git/+log/0b88d9031cd2..13d83a6912ce

2023-06-20 johnstiles@google.com Apply immutable-value optimization to compound constructors.
2023-06-20 fmalita@google.com Revert "De-SkScalar SkRect"
2023-06-20 kjlubick@google.com Add gl specific filegroup
2023-06-20 jvanverth@google.com [graphite] Add Windows Release Vulkan test job.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-20 22:58:43 +00:00
skia-flutter-autoroll
b02557351d Roll Skia from d56841344bbe to 0b88d9031cd2 (3 revisions) (flutter/engine#43018) 
https://skia.googlesource.com/skia.git/+log/d56841344bbe..0b88d9031cd2

2023-06-20 hitawala@chromium.org Graphite: Loosen TextureUsage validation to allow superset of usages
2023-06-20 herb@google.com De-SkScalar SkRect
2023-06-20 herb@google.com Add sk_float_midpoint

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-20 21:46:17 +00:00
skia-flutter-autoroll
15ffab06fc Roll Skia from 9f8b501ca68c to d56841344bbe (5 revisions) (flutter/engine#43016) 
https://skia.googlesource.com/skia.git/+log/9f8b501ca68c..d56841344bbe

2023-06-20 bungeman@google.com Add text and clusters to debugger text blobs
2023-06-20 brianosman@google.com Revert "Remove SkScalarToFloat and SkFloatToScalar calls"
2023-06-20 michaelludwig@google.com [skif] Remove legacy displacement implementation
2023-06-20 michaelludwig@google.com [skif] Delete legacy morphology implementations
2023-06-20 armansito@google.com [gm] Add GMs that apply a gradient to a path

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-20 20:27:24 +00:00
skia-flutter-autoroll
8934ab1603 Roll Skia from 0b26ffb4efe0 to 9f8b501ca68c (10 revisions) (flutter/engine#43012) 
https://skia.googlesource.com/skia.git/+log/0b26ffb4efe0..9f8b501ca68c

2023-06-20 brianosman@google.com Handle divide-by-zero in dashing code
2023-06-20 vollick@chromium.org Attempt to use fallback color type and backend format
2023-06-20 brianosman@google.com Remove SkScalarToFloat and SkFloatToScalar calls
2023-06-20 herb@google.com Reland "Quad intersections for glyph underlines"
2023-06-20 herb@google.com Change isfinite -> sk_float_isifinite in SkPoint
2023-06-20 brianosman@google.com Fix FuzzCanvas imageFilter selection
2023-06-20 brianosman@google.com Suppress divide-by-zero in hairline intersection code
2023-06-20 johnstiles@google.com Detect immutable variables regardless of the const modifier.
2023-06-20 johnstiles@google.com Add support for immutable data in SkRP.
2023-06-20 uioptt24@gmail.com [graphite] Fix the specified type does not match the argument type error

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-20 19:17:53 +00:00
Jason Simmons
91f507c27c A few minor cleanups of the MultiFrameCodec (flutter/engine#42935) 2023-06-20 17:57:17 +00:00
Jonah Williams
2b383d3b89 [Impeller] use pixel format in construction of initial PSO objects, set default sample count to 4. (flutter/engine#42972) 
Reland of https://github.com/flutter/engine/pull/42902

on iOS the default pixel format can change due to wide gamut + platform views introducing multiple surfaces. Cache the default options used to create all pipelines so that we can guarantee that one can be found.
 2023-06-20 17:45:47 +00:00
fzyzcjy
a0e9bfe3d4 Differentiate two EncodeCommandsInReactor with the same name (flutter/engine#42992) 
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-20 17:24:09 +00:00
Michael Goderbauer
12e586914e Reland "Add deprecations to PlatformMessage stuff" (#42580) (flutter/engine#42929) 
This reverts commit 2b5c1f8d95c9c54e51787f5ceaeb142c0666aa72.

This is a straight reland without any additional changes. The package that was still using the outdated API causing the original revert has been updated in https://github.com/flutter/packages/pull/4233. **Do not land this until that PR has rolled into the framework.**
 2023-06-20 16:42:25 +00:00
skia-flutter-autoroll
c94610c218 Roll Fuchsia Linux SDK from jzCJwD297aRZtdakZ... to 41wcREjd9roHDS1jM... (flutter/engine#43003) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-20 15:38:08 +00:00
skia-flutter-autoroll
7867b67c5c Roll Skia from 6823d03cf2b2 to 0b26ffb4efe0 (2 revisions) (flutter/engine#43002) 
https://skia.googlesource.com/skia.git/+log/6823d03cf2b2..0b26ffb4efe0

2023-06-20 johnstiles@google.com Disable struct-passing test on Tegra3.
2023-06-20 brianosman@google.com Make SkPathMeasure move-able

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-20 15:11:44 +00:00
skia-flutter-autoroll
8db025d6d2 Roll Skia from 60385192e512 to 1d6ca884ed77 (3 revisions) (flutter/engine#42995) 
https://skia.googlesource.com/skia.git/+log/60385192e512..1d6ca884ed77

2023-06-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 24f4007b93e0 to 84379a529407 (9 revisions)
2023-06-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from ab08126079d3 to 850bcdd8dfed
2023-06-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from b32ce543bca1 to ab08126079d3 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-20 07:45:27 +00:00
skia-flutter-autoroll
3c0336db57 Roll Skia from 41689ff01f97 to 9c2148cd1c82 (1 revision) (flutter/engine#42987) 
https://skia.googlesource.com/skia.git/+log/41689ff01f97..9c2148cd1c82

2023-06-19 johnstiles@google.com Fix fuzzer-discovered error with inlined arrays.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-19 20:08:15 +00:00
skia-flutter-autoroll
4fddeed704 Roll Skia from 455d7306b951 to 41689ff01f97 (1 revision) (flutter/engine#42983) 
https://skia.googlesource.com/skia.git/+log/455d7306b951..41689ff01f97

2023-06-19 johnstiles@google.com Fix fuzzer-discovered error with void variables.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-19 16:21:12 +00:00
skia-flutter-autoroll
36ccc5c664 Roll Fuchsia Linux SDK from fgS2avQGq4x_sbZHU... to lG2K667BLaS_haUZg... (flutter/engine#42981) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-19 11:00:25 +00:00
skia-flutter-autoroll
3a5a1386d8 Roll Skia from 24f2336d87f2 to d182b694a670 (2 revisions) (flutter/engine#42977) 
https://skia.googlesource.com/skia.git/+log/24f2336d87f2..d182b694a670

2023-06-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from b32ce543bca1 to 15fb7caa7aea
2023-06-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from d044984a01de to b32ce543bca1 (29 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-19 06:54:16 +00:00
Jonah Williams
6ddcc5c032 Fix prefer_final_in_foreach analysis errors (flutter/engine#42971) 
This is now failing the engine roll for some reason https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20analyze/58456/overview
 2023-06-18 23:49:28 +00:00
skia-flutter-autoroll
9474fbd337 Roll Fuchsia Linux SDK from xS5RzQLfpMEK1rNEd... to fgS2avQGq4x_sbZHU... (flutter/engine#42973) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-18 21:45:33 +00:00
skia-flutter-autoroll
a7d9ca22c1 Roll Fuchsia Linux SDK from -PsA0LDB2FdS_4_vK... to xS5RzQLfpMEK1rNEd... (flutter/engine#42966) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-18 08:35:29 +00:00
Brandon DeRosier
072ed208cf [Impeller] Use 32 bit for positional stuff in the rrect blur (flutter/engine#42797) 
Resolves https://github.com/flutter/flutter/issues/128410.

16 bit floats aren't precise enough for positional computations, like
computing SDFs in the case of the RRect blur.
 2023-06-17 22:57:14 -07:00
Jonah Williams
4114b30b01 Revert "[Impeller] correct default PSO pixel format and sample count." (flutter/engine#42962) 
Reverts flutter/engine#42902

This is breaking iOS builds:

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8778085761769326737/+/u/run_platform_views_scroll_perf_non_intersecting_impeller_ios__timeline_summary/test_stdout
 2023-06-18 04:39:22 +00:00
Jonah Williams
93351f1448 [Impeller] dont use concurrent runner to decode images on Android. (flutter/engine#42944) 
Even with separate allocators and queues, I think that using the concurrent runner is just overloading the phone.

On Android force it all onto the I/O thread.

https://github.com/flutter/flutter/issues/128919
 2023-06-18 03:54:04 +00:00
skia-flutter-autoroll
281d006dfe Roll Fuchsia Linux SDK from Au1gd3XLMuSt1Z4oh... to -PsA0LDB2FdS_4_vK... (flutter/engine#42959) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-17 19:23:14 +00:00
Brandon DeRosier
080271007d [Impeller] Print malioc errors on CI (flutter/engine#42906) 
Resolves https://github.com/flutter/flutter/issues/128989.

Also bumps the buildroot to head for:
https://github.com/flutter/buildroot/pull/744
 2023-06-16 21:37:37 -07:00
skia-flutter-autoroll
3675e9050d Roll Fuchsia Linux SDK from -NW1eatBbmjvLaIcV... to Au1gd3XLMuSt1Z4oh... (flutter/engine#42948) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-17 03:07:10 +00:00
Siva
2c57a3f9fa Fix analyzer warnings (prefer_final_in_for_each is now the default) (flutter/engine#42943) 
The analyzer option `prefer_final_in_for_each` has been made the default
and this has triggered new warnings.
 2023-06-16 17:33:59 -07:00
skia-flutter-autoroll
b00436f1bc Roll Skia from 64fa632d3b01 to dc11c7ddb33f (3 revisions) (flutter/engine#42939) 
https://skia.googlesource.com/skia.git/+log/64fa632d3b01..dc11c7ddb33f

2023-06-16 johnstiles@google.com Fix some outdated comments.
2023-06-16 brianosman@google.com Stop suppressing divide-by-zero errors in SkScalarInvert
2023-06-16 herb@google.com Move SkPoint to base

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-16 23:10:31 +00:00
skia-flutter-autoroll
dec05499a1 Roll Skia from 01f3be45e0d6 to 64fa632d3b01 (3 revisions) (flutter/engine#42937) 
https://skia.googlesource.com/skia.git/+log/01f3be45e0d6..64fa632d3b01

2023-06-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 58c6e1ea988a to 8ca65cb391f4 (6 revisions)
2023-06-16 johnstiles@google.com Factor apart Program::dump into a helper class.
2023-06-16 herb@google.com Use float for SkPoint's coordinates

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-16 22:00:19 +00:00
Hassan
5e05d8b967 [web] Fix for Safari autofill flickering bug (flutter/engine#42830) 
Safari web autofill has an issue where the autofill dialog flickers and doesn't completely render and allow users to fill any forms. 

This is caused by a collision between default browser behavior on the `pointerdown` event and the programatic focusing of our inputs. 

### Problem

When we click into an input, the element is created, placed, and (explicitly) focused.  However, all of this is done before the `pointerdown` event can finish.  Since all `pointerdown` elements target the `flutter-view` (formerly `flt-glass-pane`), default browser behavior is to trigger a `blur` event since the target doesn't match what's currently focused, which is the input element.  This doesn't manifest into most text editing issues because we listen for `blur` events on the `input` and call `focus()`.  However, in Safari, this near-instant focus/blur results in the disappearance of the autofill popup. 

The current chain of events looks like: 

`pointerdown` event starts -> input is created + focused -> `pointerdown` event ends, and triggers a `blur` -> input refocuses on `blur`

### Solution

This change ensures that we don't focus the input until after the `pointerdown` event concludes, thus preventing any rapid-fire `blur` event from being emitted.  We do this via wrapping the focus logic within a zero-duration Timer.  

The new chain of events looks like:

`pointerdown` event starts -> `pointerdown` event ends ->  input is created + focused

### Alternative approach

Note: Another option was to call `preventDefault()` on the `pointerdown` event to prevent the `blur` from occurring that way.  There may be unintended side effects from that approach, especially as it relates to platform views.  The surface area of the chosen approach is much more contained and should result in no side effects outside of Safari Desktop's text editing strategy. 

<img width="699" alt="Screenshot 2023-06-15 at 7 34 02 PM" src="https://github.com/flutter/engine/assets/110993981/3548d1ea-65f7-412f-b3c7-f94db2658127">

Fixes https://github.com/flutter/flutter/issues/127960
 2023-06-16 21:48:59 +00:00
Jonah Williams
68ce594530 [Impeller] correct default PSO pixel format and sample count. (flutter/engine#42902) 
Despite compiling an initial PSO variant for every shader, in practice these were completely useless as they had a sample count of 1 (instead of 4 for MSAA) and an invalid pixel format.

Correct the defaults so they may be usful.

Not enough to fix https://github.com/flutter/flutter/issues/128963 , because we still have far too much state for Vulkan to handle
 2023-06-16 20:53:02 +00:00
skia-flutter-autoroll
a6e9576963 Roll Skia from 90dae91b2242 to 01f3be45e0d6 (4 revisions) (flutter/engine#42934) 
https://skia.googlesource.com/skia.git/+log/90dae91b2242..01f3be45e0d6

2023-06-16 robertphillips@google.com Convert rest of affected GMs and tests over to new tiled image API
2023-06-16 robertphillips@google.com Move tiling utility methods to shareable location
2023-06-16 brianosman@google.com Fix return type of Benchmark::getSize
2023-06-16 jvanverth@google.com [graphite] Add onCopyTextureToTexture for the Vulkan backend.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-16 20:49:46 +00:00
skia-flutter-autoroll
e8a1d6b948 Roll Skia from 20e9cc928715 to 90dae91b2242 (5 revisions) (flutter/engine#42932) 
https://skia.googlesource.com/skia.git/+log/20e9cc928715..90dae91b2242

2023-06-16 brianosman@google.com Fix incorrect filename for WGSL ClampUInt
2023-06-16 johnstiles@google.com Add Type::slotType(n).
2023-06-16 johnstiles@google.com Add WGSL support for common-function intrinsics.
2023-06-16 jmbetancourt@google.com track Color and Opacity slots through new SlotManager
2023-06-16 lovisolo@google.com [gm] Make GPU backend dependency conditional on SK_GANESH constant.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-16 19:39:53 +00:00
skia-flutter-autoroll
10994cebdc Roll Skia from a4ad5b369313 to 20e9cc928715 (3 revisions) (flutter/engine#42926) 
https://skia.googlesource.com/skia.git/+log/a4ad5b369313..20e9cc928715

2023-06-16 jvanverth@google.com [graphite] Set Vulkan viewport and scissor
2023-06-16 johnstiles@google.com Reject first-class arrays on initializers in strict-ES2 mode.
2023-06-16 johnstiles@google.com Use IRHelpers class to assemble matrix-multiply workaround.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-16 18:28:55 +00:00
gaaclarke
2b5c1f8d95 Revert "Add deprecations to PlatformMessage stuff" (flutter/engine#42921) 
Reverts flutter/engine#42580
 2023-06-16 10:54:40 -07:00
Jacob MacDonald
660bdd6b03 add dart_internal override where necessary (flutter/engine#42920) 
A dependency to dart_internal was added in https://dart-review.googlesource.com/c/sdk/+/309460/6 and all transitive deps need to have overrides.
 2023-06-16 17:20:18 +00:00
skia-flutter-autoroll
694060f78f Roll Skia from 9ab04a53b7be to d43262e90f25 (5 revisions) (flutter/engine#42918) 
https://skia.googlesource.com/skia.git/+log/9ab04a53b7be..d43262e90f25

2023-06-16 johnstiles@google.com Disable SwitchWithFallthrough test on iOS + GLSL.
2023-06-16 kjlubick@google.com Remove Android GPU methods from SkCanvas
2023-06-16 kjlubick@google.com Introduce delegate for Atlas regeneration
2023-06-16 kjlubick@google.com Extract VertexFiller and add AtlasDrawDelegate as GPU abstraction
2023-06-16 kjlubick@google.com Extract SlugImpl.h and remove #ifdefs of slugs from Canvas

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-16 15:34:23 +00:00
Mouad Debbar
3dc65b209f [web] Move webOnlyAssetManager to dart:ui_web (flutter/engine#42642) 
Moving `webOnlyAssetManager` to `dart:ui_web` and renaming it to simply `assetManager`. This will make it easier for plugins and apps to get a hold of the asset manager without doing `dart:ui` shims or other shenanigans.

Part of https://github.com/flutter/flutter/issues/126831
 2023-06-16 14:54:09 +00:00
skia-flutter-autoroll
c1246d270e Roll Fuchsia Linux SDK from E5G7PwYbRA-u-ZJ9F... to -NW1eatBbmjvLaIcV... (flutter/engine#42915) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-16 13:57:14 +00:00
skia-flutter-autoroll
11e37d337b Roll Skia from f0410a265d2b to 504a26e85fc6 (1 revision) (flutter/engine#42907) 
https://skia.googlesource.com/skia.git/+log/f0410a265d2b..504a26e85fc6

2023-06-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 894306cf4c91 to d044984a01de (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-16 06:03:36 +00:00
godofredoc
79f7e23ebf Set xcode explicitly on mac builds with release_build. (flutter/engine#42898) 
Xcode version needs to be set explicitly for builds running on
dart-internal.

Bug: https://github.com/flutter/flutter/issues/128977

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I signed the [CLA].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-06-15 22:04:21 -07:00
Konstantin Scheglov
327e2a3d85 Fix prefer_final_in_for_each (flutter/engine#42899) 
Context: https://dart-review.googlesource.com/c/sdk/+/309821
 2023-06-15 20:57:43 -07:00
godofredoc
ad32caa1ab Remove release_build from clang_tidy build. (flutter/engine#42900) 
release_build property is used to flag that artifacts from the build need to also include provenance. Clang tidy build does not generate any artifacts and it is failing in dart internal.

Bug: https://github.com/flutter/flutter/issues/128981

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-16 02:24:07 +00:00
skia-flutter-autoroll
d2a19b52b6 Roll Fuchsia Linux SDK from 53EjCyuRu91oFTBf2... to E5G7PwYbRA-u-ZJ9F... (flutter/engine#42897) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-16 00:43:45 +00:00
skia-flutter-autoroll
7c1d7aedc8 Roll Skia from 2ab2678058a3 to abfa3505db23 (1 revision) (flutter/engine#42894) 
https://skia.googlesource.com/skia.git/+log/2ab2678058a3..abfa3505db23

2023-06-15 herb@google.com Harden quadratic solver

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-15 21:53:13 +00:00
skia-flutter-autoroll
24c04400b0 Roll Skia from 794b6f9240a8 to 2ab2678058a3 (6 revisions) (flutter/engine#42889) 
https://skia.googlesource.com/skia.git/+log/794b6f9240a8..2ab2678058a3

2023-06-15 robertphillips@google.com [graphite] New tiled image draw API
2023-06-15 kjlubick@google.com Add extra specification for some enums
2023-06-15 jvanverth@google.com [graphite] Temporarily disable draw pass commands in Vulkan to get dm running
2023-06-15 nicolettep@google.com [graphite] Fix dawn typo
2023-06-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4f33c22decdf to 6f8e5c2f4684 (3 revisions)
2023-06-15 robertphillips@google.com Minor refactoring of the Device drawImage code path

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-15 20:40:41 +00:00
Michael Goderbauer
57ffdedfc4 Add deprecations to PlatformMessage stuff (flutter/engine#42580) 
Fixes old TODOs originally added in https://github.com/flutter/engine/pull/22181.
The framework appears to be fully migrated off these.
 2023-06-15 19:53:13 +00:00
gaaclarke
c3105fa995 [Impeller] Joined obligatory vulkan swapchain submits (flutter/engine#42865) 
Every frame we submit to the queue a layout transition and a notify to the `acquire` fence.  This joins those together into one `vkQueueSubmit` call.  Thus eliminating a fence that was happening after the layout transition.

issue https://github.com/flutter/flutter/issues/128838

## testing results from the gallery driver test
```
Before:
  "average_frame_build_time_millis": 1.379130952380952,
  "90th_percentile_frame_build_time_millis": 1.965,
  "99th_percentile_frame_build_time_millis": 20.246,
  "worst_frame_build_time_millis": 29.578,
  "missed_frame_build_budget_count": 7,
  "average_frame_rasterizer_time_millis": 20.447408955223867,
  "90th_percentile_frame_rasterizer_time_millis": 25.398,
  "99th_percentile_frame_rasterizer_time_millis": 160.198,
  "worst_frame_rasterizer_time_millis": 178.042,
  "missed_frame_rasterizer_budget_count": 122,
  "frame_count": 336,
  "frame_rasterizer_count": 335,
  "new_gen_gc_count": 0,
  "old_gen_gc_count": 0,
  "frame_build_times": [
after:
  "average_frame_build_time_millis": 1.1907232876712324,
  "90th_percentile_frame_build_time_millis": 1.926,
  "99th_percentile_frame_build_time_millis": 16.666,
  "worst_frame_build_time_millis": 27.39,
  "missed_frame_build_budget_count": 5,
  "average_frame_rasterizer_time_millis": 15.525100817438704,
  "90th_percentile_frame_rasterizer_time_millis": 20.116,
  "99th_percentile_frame_rasterizer_time_millis": 33.835,
  "worst_frame_rasterizer_time_millis": 56.075,
  "missed_frame_rasterizer_budget_count": 156,
  "frame_count": 365,
  "frame_rasterizer_count": 367,
  "new_gen_gc_count": 0,
  "old_gen_gc_count": 0,
```

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-15 19:50:10 +00:00
skia-flutter-autoroll
be22b33d27 Roll Skia from 2d531d020c26 to 794b6f9240a8 (3 revisions) (flutter/engine#42888) 
https://skia.googlesource.com/skia.git/+log/2d531d020c26..794b6f9240a8

2023-06-15 robertphillips@google.com [graphite] Remove SkImageGenerator::makeTextureImage
2023-06-15 michaelludwig@google.com [skif] Fix morphology sksl to avoid switch fallthroughs
2023-06-15 nicolettep@google.com [graphite] Fix multisample state in Vulkan graphics pipeline

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-15 19:30:00 +00:00