DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
37,964 Commits 882 Branches 1,069 Tags
Commit Graph

37964 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Matan Lurey
c7df7b1cce Add timeout to local_engine. (flutter/engine#56271) 
See https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.prod/Linux%20local_engine_builds.
 2024-10-31 17:00:50 +00:00
Matan Lurey
f89c4fd346 Refactor ArgParser.usage tests for BuildPlan to reduce duplication. (flutter/engine#56254) 
Part of https://github.com/flutter/flutter/issues/157870.

I figured I'd tackle a theme of tests at a time - easier for me to do in little spurts between other tasks.
 2024-10-31 16:44:06 +00:00
auto-submit[bot]
38f7a81e37 Reverts "Skwasm single threaded (#56206)" (flutter/engine#56264) 
Reverts: flutter/engine#56206
Initiated by: jonahwilliams
Reason for reverting: failing to roll into framework: https://github.com/flutter/flutter/pull/157919 
Original PR Author: eyebrowsoffire

Reviewed By: {harryterkelsen}

This change reverts the following previous change:
This PR creates a single-threaded version of the skwasm renderer, appropriate for non-crossOriginIsolated browsing contexts.
* The single threaded renderer is essentially the same as the multi-threaded renderer, except instead of spawning a web worker and posting messages to it, it simply schedules microtasks on the main thread in their place.
* The new renderer is vended as `skwasm_st.js` and `skwasm_st.wasm` in the same location as multithreaded skwasm. In order to properly build and function, we needed some fixes I put into emscripten that landed in version 3.1.70. That version also changed some behavior that required a few fixes to the CanvasKit build files.
* The skwasm loader in flutter.js has been modified to use the skwasm_st variants when encountering a non-crossOriginIsolated context but a browser and configuration that otherwise would allow the use of skwasm. I also added a new `forceSingleThreadedSkwasm` option to the flutter configuration so that we can override this behavior, especially so that we can accurately benchmark the single threaded renderer in a crossOriginIsolated environment.
* I also consolidated a bunch of our shards that run tests to just have one per browser/platform combination, so four total. This will address https://github.com/flutter/flutter/issues/124682
 2024-10-31 14:12:47 +00:00
skia-flutter-autoroll
85cce650a0 Roll Skia from 4f8f2ecadfb6 to 3c628426f85f (1 revision) (flutter/engine#56261) 
https://skia.googlesource.com/skia.git/+log/4f8f2ecadfb6..3c628426f85f

2024-10-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 548705375403 to 65468f93b38c (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-31 10:47:12 +00:00
skia-flutter-autoroll
e119b973fb Roll Skia from 7e79a516284b to 4f8f2ecadfb6 (1 revision) (flutter/engine#56255) 
https://skia.googlesource.com/skia.git/+log/7e79a516284b..4f8f2ecadfb6

2024-10-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 35ba6e6c2f96 to a56fede2b5d7 (13 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-31 06:11:37 +00:00
skia-flutter-autoroll
ac26403b3e Roll Dart SDK from 6a8058eef22c to f3e3dc44b1dc (1 revision) (flutter/engine#56253) 
https://dart.googlesource.com/sdk.git/+log/6a8058eef22c..f3e3dc44b1dc

2024-10-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-86.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-31 03:41:31 +00:00
skia-flutter-autoroll
14fd453316 Roll Skia from 3c62d4a94d78 to 7e79a516284b (1 revision) (flutter/engine#56252) 
https://skia.googlesource.com/skia.git/+log/3c62d4a94d78..7e79a516284b

2024-10-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 0b52950e91ca to 1d891d46a65c (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-31 03:38:20 +00:00
Jonah Williams
8b0392d282 [Impeller] use primitive restart for faster tessellation: write directly into host buffer. (flutter/engine#56173) 
Using primitive restart we can avoid tracking even odd or inserting degenerate triangles. Instead a special index value `0xFFFF` is used to signal a break. This can be combined with triangle fan on vulkan for a dramatically simpler tessellation.

Additionally, switches to a two pass system where we first estimate the storage required by the path so tha the host buffer can be written to directly.
 2024-10-31 02:27:28 +00:00
Jackson Gardner
1a4f588e1f Skwasm single threaded (flutter/engine#56206) 
This PR creates a single-threaded version of the skwasm renderer, appropriate for non-crossOriginIsolated browsing contexts.
* The single threaded renderer is essentially the same as the multi-threaded renderer, except instead of spawning a web worker and posting messages to it, it simply schedules microtasks on the main thread in their place.
* The new renderer is vended as `skwasm_st.js` and `skwasm_st.wasm` in the same location as multithreaded skwasm. In order to properly build and function, we needed some fixes I put into emscripten that landed in version 3.1.70. That version also changed some behavior that required a few fixes to the CanvasKit build files.
* The skwasm loader in flutter.js has been modified to use the skwasm_st variants when encountering a non-crossOriginIsolated context but a browser and configuration that otherwise would allow the use of skwasm. I also added a new `forceSingleThreadedSkwasm` option to the flutter configuration so that we can override this behavior, especially so that we can accurately benchmark the single threaded renderer in a crossOriginIsolated environment.
* I also consolidated a bunch of our shards that run tests to just have one per browser/platform combination, so four total. This will address https://github.com/flutter/flutter/issues/124682
 2024-10-31 00:42:07 +00:00
Jonah Williams
693f99ae00 [Impeller] expose reference to tessellator instead of shared_ptr. (flutter/engine#56244) 
All geometries were incrementing the shared_ptr usage count which shows up in profiles. Instead expose a Tessellator reference like we do with HostBuffer.
 2024-10-31 00:40:18 +00:00
Chris Bracken
a4bb83e6e8 iOS: Eliminate strong retain loop in Scenario tests (flutter/engine#56249) 
`FlutterViewControllerTest testDrawLayer` created a callback which strongly referenced itself in its own body as part of an asynchronous recursive loop. The recursion was unnecessary and the test consistently passes, even if run on repeat > 100 times without it.

Now that there's only one call, eliminates the unnecessary local and inlines it into the `dispatch_after` call.

This was originally introduced in https://github.com/flutter/engine/pull/50072.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-10-31 00:37:26 +00:00
skia-flutter-autoroll
2bc2d9e328 Roll Skia from 85b77db25fa3 to 3c62d4a94d78 (1 revision) (flutter/engine#56248) 
https://skia.googlesource.com/skia.git/+log/85b77db25fa3..3c62d4a94d78

2024-10-30 fmalita@google.com Add verb measurement utils to SkContourMeasure

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-30 23:08:07 +00:00
skia-flutter-autoroll
3c6aaffb34 Roll Dart SDK from 4566845d8e30 to 6a8058eef22c (1 revision) (flutter/engine#56246) 
https://dart.googlesource.com/sdk.git/+log/4566845d8e30..6a8058eef22c

2024-10-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-85.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-30 23:04:05 +00:00
skia-flutter-autoroll
193c2511a9 Roll Skia from f334411b0a08 to 85b77db25fa3 (5 revisions) (flutter/engine#56245) 
https://skia.googlesource.com/skia.git/+log/f334411b0a08..85b77db25fa3

2024-10-30 jvanverth@google.com [graphite] Add round cap support to CircularArcRenderStep.
2024-10-30 jlavrova@google.com Reland "Reland "Reland "Adding Fontations to FontConfig manager"""
2024-10-30 bungeman@google.com [pdf] Emit correct tag for marked-content items
2024-10-30 drott@chromium.org [Fontations] Fix bounding box calculation under transforms
2024-10-30 vigneshv@google.com SkCrabbyAvifCodec: Add support for gainmaps

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-30 21:50:06 +00:00
Matan Lurey
eb42dc7b9d Add and use mergeGnArgs with --gn-args from et. (flutter/engine#56228) 
Closes https://github.com/flutter/flutter/issues/156909.

This PR adds (and implements) the `--gn-args` (extra command-line GN args) functionality by generalizing on the concept of "merged" GN args that @zanderso had special-cased for `--lto` and `--rbe`, and further testing it.

There is also a logical place for us to expand support of merged arguments at a future point in time.
 2024-10-30 21:44:35 +00:00
skia-flutter-autoroll
85bf745fbc Roll Skia from 77779dfed911 to f334411b0a08 (1 revision) (flutter/engine#56243) 
https://skia.googlesource.com/skia.git/+log/77779dfed911..f334411b0a08

2024-10-30 jvanverth@google.com [graphite] Remove legacy rrect clip

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-30 20:08:18 +00:00
Jonah Williams
b1b224f8e8 [engine] add back opt out for merged thread mode. (flutter/engine#56242) 
Leave an opt out in the engine for iOS as well. This will give developers an escape hatch in case there are problems we miss...
 2024-10-30 20:00:22 +00:00
Jason Simmons
d24eb30b3d [Impeller] Remove the use of a subpixel minimum stroke size for MSAA (flutter/engine#56223) 
Based on https://github.com/flutter/engine/pull/55230

Fixes https://github.com/flutter/flutter/issues/156438
 2024-10-30 18:45:45 +00:00
skia-flutter-autoroll
bbe385cf21 Roll Fuchsia Linux SDK from zuDYsDZHnJMZVvrc8... to dDWvmfG4AxSEs0BQA... (flutter/engine#56241) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-30 18:40:23 +00:00
skia-flutter-autoroll
05e65b6663 Roll Dart SDK from 36aed3607108 to 4566845d8e30 (1 revision) (flutter/engine#56240) 
https://dart.googlesource.com/sdk.git/+log/36aed3607108..4566845d8e30

2024-10-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-84.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-30 18:14:09 +00:00
skia-flutter-autoroll
788af1d0c1 Roll Skia from d022fe64116f to 77779dfed911 (1 revision) (flutter/engine#56239) 
https://skia.googlesource.com/skia.git/+log/d022fe64116f..77779dfed911

2024-10-30 jlavrova@google.com Revert "Reland "Reland "Adding Fontations to FontConfig manager"""

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-30 17:02:19 +00:00
skia-flutter-autoroll
ae6950d066 Roll Skia from 03600bc22ab8 to d022fe64116f (1 revision) (flutter/engine#56237) 
https://skia.googlesource.com/skia.git/+log/03600bc22ab8..d022fe64116f

2024-10-30 jlavrova@google.com Reland "Reland "Adding Fontations to FontConfig manager""

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-30 15:13:20 +00:00
skia-flutter-autoroll
30b116ffe4 Roll Skia from 948b01e28f48 to 03600bc22ab8 (1 revision) (flutter/engine#56236) 
https://skia.googlesource.com/skia.git/+log/948b01e28f48..03600bc22ab8

2024-10-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from b26c8c0409df to 0b52950e91ca (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-30 13:43:33 +00:00
skia-flutter-autoroll
4d7029a182 Roll Dart SDK from b319b2e53bfa to 36aed3607108 (2 revisions) (flutter/engine#56235) 
https://dart.googlesource.com/sdk.git/+log/b319b2e53bfa..36aed3607108

2024-10-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-83.0.dev
2024-10-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-82.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-30 13:39:36 +00:00
skia-flutter-autoroll
1a555cf0ce Roll Skia from 1a47627e627a to 948b01e28f48 (1 revision) (flutter/engine#56231) 
https://skia.googlesource.com/skia.git/+log/1a47627e627a..948b01e28f48

2024-10-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from e50eebfa6917 to 548705375403 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-30 08:18:24 +00:00
skia-flutter-autoroll
52a08f1911 Roll Skia from 5410f1c6f86c to 1a47627e627a (1 revision) (flutter/engine#56230) 
https://skia.googlesource.com/skia.git/+log/5410f1c6f86c..1a47627e627a

2024-10-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 9daf276e5f9a to 35ba6e6c2f96 (31 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-30 06:36:11 +00:00
skia-flutter-autoroll
90f0a83511 Roll Dart SDK from 70eca740f23f to b319b2e53bfa (1 revision) (flutter/engine#56229) 
https://dart.googlesource.com/sdk.git/+log/70eca740f23f..b319b2e53bfa

2024-10-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-81.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-30 05:20:21 +00:00
Chris Bracken
d6ad223584 iOS: make unopt debug builds unopt and debug (flutter/engine#56226) 
The following iOS builds were named "unopt" and "debug" but did not have
the `--unoptimized` flag passed to `gn`, resulting in them not being
unopt, and having the gn `is_debug` setting set to `false`:

* ios_debug_unopt_sim
* ios_debug_unopt_sim_arm64
* ios_debug_unopt_sim_arm64_extension_safe

No test changes because this is a compile config change.

Issue: https://github.com/flutter/flutter/issues/156166

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-10-30 04:15:18 +00:00
skia-flutter-autoroll
de5235547a Roll Skia from 7385b2d99fe9 to 5410f1c6f86c (1 revision) (flutter/engine#56227) 
https://skia.googlesource.com/skia.git/+log/7385b2d99fe9..5410f1c6f86c

2024-10-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from a5edfbb83552 to b26c8c0409df (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-30 01:48:33 +00:00
skia-flutter-autoroll
c732984e6b Roll Dart SDK from fcc2bc69db3e to 70eca740f23f (2 revisions) (flutter/engine#56225) 
https://dart.googlesource.com/sdk.git/+log/fcc2bc69db3e..70eca740f23f

2024-10-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-80.0.dev
2024-10-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-79.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-30 00:56:41 +00:00
skia-flutter-autoroll
6b989d0e0c Roll Skia from 6e0c0a255166 to 7385b2d99fe9 (5 revisions) (flutter/engine#56222) 
https://skia.googlesource.com/skia.git/+log/6e0c0a255166..7385b2d99fe9

2024-10-29 lukasza@chromium.org Reapply "[rust png] Add a few extra `BlendOp`, regions, and `num_plays` tests."
2024-10-29 lukasza@chromium.org [rust png] Don't retry `parse...FrameInfos` if input didn't change.
2024-10-29 michaelludwig@google.com Revert "Reland "Adding Fontations to FontConfig manager""
2024-10-29 lukasza@chromium.org [rust png] Don't look for more `fcTL` chunks during incremental decode.
2024-10-29 lukasza@chromium.org [rust png] Account for `fFrameAtCurrentStreamPosition` inaccuracies.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-30 00:20:06 +00:00
Alexander Aprelev
ff932605ae Roll buildroot to 3f1a1f0. (flutter/engine#56214) 
Changes since last roll:
```
3f1a1f0 Revert "For --time'd failed gn_run_binary.py runs repeat failed command (#910)" (#914)
e256f5c Remove github actions from buildroot (#913)
```
 2024-10-29 23:08:59 +00:00
David Iglesias
ba7deba7c5 [web] Prioritize split font fallbacks over monolythic ones. (flutter/engine#56187) 
Moves "split" font fallbacks (woff2) over "monolythic" ones (ttf) when resolving fonts.

Fixes https://github.com/flutter/flutter/issues/157763

It makes flutter web prefer "Noto Color Emoji" over "Noto Sans Symbols" when rendering emoji, for example.

This also changes the methods that process the font lists so they *return* the fonts they processed, instead of causing a side effect on an incoming array.

---

CIPD Upload log

```
398 sets covering 22287 ranges
Uploading fallback fonts to CIPD with hash 0570a0ea824083da79de07b131fc5df7f55dad4d6cba2ee704912ce7e4ce812a
Enumerating files to zip...
Instance: flutter/flutter_font_fallbacks:6jWhR90elvOjT1bwCe57CrNWbsGrvOzMONf9_bS8w5IC
Setting new fallback fonts deps version to 0570a0ea824083da79de07b131fc5df7f55dad4d6cba2ee704912ce7e4ce812a
```

Link to uploaded bundle:

* https://chrome-infra-packages.appspot.com/p/flutter/flutter_font_fallbacks/+/6jWhR90elvOjT1bwCe57CrNWbsGrvOzMONf9_bS8w5IC

---

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-10-29 23:01:22 +00:00
skia-flutter-autoroll
621f137ec6 Roll Skia from 5758d9c344e3 to 6e0c0a255166 (3 revisions) (flutter/engine#56215) 
https://skia.googlesource.com/skia.git/+log/5758d9c344e3..6e0c0a255166

2024-10-29 jlavrova@google.com Reland "Adding Fontations to FontConfig manager"
2024-10-29 bungeman@google.com [pdf] Expand content item scope
2024-10-29 jamesgk@google.com [graphite] Simplify ShaderInfo API

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-29 22:53:48 +00:00
Brandon DeRosier
3fed10bf0d [Flutter GPU] Fix MSAA sample size and HostBuffer alignment. (flutter/engine#56218) 
- Align HostBuffer emplacements properly (fix Metal validation failures).
- Correctly set the pipeline sample size.
- Throw an error when attempting to bind `deviceTransient` textures.
 2024-10-29 22:52:21 +00:00
Jim Graham
80d757ef56 Change default TileMode for blur ImageFilter objects to null (flutter/engine#55552) 
Fixes https://github.com/flutter/flutter/issues/154935

Historically ImageFilter.blur supported setting a TileMode and had a default mode of `clamp`, but few developers actually set the value and the default was not appropriate for some common uses like as a backdrop filter where the clamp mode produces flashing when scrolling high frequency pixel content underneath a blurred title bar.

This PR removes the default tile mode instead allowing a null value as the default which will allow the engine to use an appropriate context-dependent default tile mode depending on the action being performed. Typically:

- decal for rendering operations and saveLayers and ImageFilterLayer
- clamp for image operations
- mirror for backdrop filters
 2024-10-29 22:47:32 +00:00
auto-submit[bot]
728997cd8f Reverts "[Impeller] Reland: disable AHBs on devices that were upgraded to 29. (#56213)" (flutter/engine#56220) 
Reverts: flutter/engine#56213
Initiated by: jtmcdole
Reason for reverting: breaks the tree. :'(
Original PR Author: jonahwilliams

Reviewed By: {chinmaygarde, jtmcdole}

This change reverts the following previous change:
Uses ro.product.first_api_level to disable AHBs on devices that began life pre 29.

Fixes https://github.com/flutter/flutter/issues/157113
 2024-10-29 22:24:19 +00:00
gaaclarke
ae96943065 Made et compilation errors relative to the CWD (flutter/engine#56177) 
fixes https://github.com/flutter/flutter/issues/157735

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-10-29 19:25:04 +00:00
Jonah Williams
103b3b7cf5 [Impeller] Reland: disable AHBs on devices that were upgraded to 29. (flutter/engine#56213) 
Uses ro.product.first_api_level to disable AHBs on devices that began life pre 29.

Fixes https://github.com/flutter/flutter/issues/157113
 2024-10-29 19:12:16 +00:00
Jonah Williams
1f229c58cf [Impeller] disable Adreno 506. (flutter/engine#56210) 
Fixes https://github.com/flutter/flutter/issues/155185
 2024-10-29 18:43:22 +00:00
auto-submit[bot]
bc43093cdd Reverts "[Impeller] disable AHBs on devices that were upgraded to 29. (#56202)" (flutter/engine#56212) 
Reverts: flutter/engine#56202
Initiated by: jonahwilliams
Reason for reverting: tests didn't actually run.
Original PR Author: jonahwilliams

Reviewed By: {chinmaygarde, jtmcdole}

This change reverts the following previous change:
Uses `ro.product.first_api_level` to disable AHBs on devices that began life pre 29.

Fixes https://github.com/flutter/flutter/issues/157113
 2024-10-29 17:45:47 +00:00
Alexander Aprelev
d0141e3ee3 Remove --time run of gen_snapshot. (flutter/engine#56204) 
'--time'-runs were done to investigate https://github.com/flutter/flutter/issues/154437, which was fixed.
 2024-10-29 17:20:15 +00:00
Jason Simmons
ac991b9a6e [Impeller] Clip the DrawImageRect source rect to the bounds of the image (flutter/engine#56183) 
The destination rect will then be updated to a mapping of the clipped source rect.

This matches the behavior of Skia's SkCanvas::drawImageRect.

Fixes https://github.com/flutter/flutter/issues/157167
 2024-10-29 17:10:31 +00:00
Jonah Williams
f1300a6ce6 [Impeller] disable Maleoon GPU from using Vulkan. (flutter/engine#56203) 
Fixes https://github.com/flutter/flutter/issues/156623

using info from https://vulkan.gpuinfo.org/displayreport.php?id=23730 . I dont believe these vulkan drivers are working correctly.
 2024-10-29 17:09:14 +00:00
Jonah Williams
3e9f90a834 [Impeller] disable AHBs on devices that were upgraded to 29. (flutter/engine#56202) 
Uses `ro.product.first_api_level` to disable AHBs on devices that began life pre 29.

Fixes https://github.com/flutter/flutter/issues/157113
 2024-10-29 17:02:23 +00:00
skia-flutter-autoroll
74c637967e Roll Skia from 6d8a5ebeb76c to 5758d9c344e3 (7 revisions) (flutter/engine#56201) 
https://skia.googlesource.com/skia.git/+log/6d8a5ebeb76c..5758d9c344e3

2024-10-29 jamesgk@google.com Revert "[rust png] Add a few extra `BlendOp`, regions, and `num_plays` tests."
2024-10-29 briansalomon@gmail.com Reland "Update Ganesh GL interface to look for timer query functionality."
2024-10-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 098ec4c2bd02 to a5edfbb83552 (10 revisions)
2024-10-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from fe99836c8bb8 to 0e0e5eae7d22 (13 revisions)
2024-10-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 98a334bd44af to e50eebfa6917 (5 revisions)
2024-10-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 3aaa6784ca31 to 1495532f997f (2 revisions)
2024-10-29 lukasza@chromium.org [rust png] Add a few extra `BlendOp`, regions, and `num_plays` tests.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-29 16:14:59 +00:00
skia-flutter-autoroll
20a9d2e775 Roll Dart SDK from 52af705f878b to fcc2bc69db3e (1 revision) (flutter/engine#56199) 
https://dart.googlesource.com/sdk.git/+log/52af705f878b..fcc2bc69db3e

2024-10-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-78.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-29 14:06:28 +00:00
skia-flutter-autoroll
fc5d069156 Roll Fuchsia Linux SDK from RXUZ9eDc7cS4NpKoh... to zuDYsDZHnJMZVvrc8... (flutter/engine#56197) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-29 12:01:23 +00:00
skia-flutter-autoroll
3ae0ed5a7d Roll Dart SDK from 6e55dfe77483 to 52af705f878b (2 revisions) (flutter/engine#56195) 
https://dart.googlesource.com/sdk.git/+log/6e55dfe77483..52af705f878b

2024-10-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-77.0.dev
2024-10-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-76.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-29 09:00:18 +00:00
dependabot[bot]
68933d2e77 Bump actions/setup-python from 5.2.0 to 5.3.0 (flutter/engine#56192) 
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.2.0 to 5.3.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/setup-python/releases">actions/setup-python's releases</a>.</em></p>
<blockquote>
<h2>v5.3.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Add workflow file for publishing releases to immutable action package by <a href="https://github.com/Jcambass"><code>@​Jcambass</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/941">actions/setup-python#941</a></li>
<li>Upgrade IA publish by <a href="https://github.com/Jcambass"><code>@​Jcambass</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/943">actions/setup-python#943</a></li>
</ul>
<h3>Bug Fixes:</h3>
<ul>
<li>Normalise Line Endings to Ensure Cross-Platform Consistency by <a href="https://github.com/priya-kinthali"><code>@​priya-kinthali</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/938">actions/setup-python#938</a></li>
<li>Revise <code>isGhes</code> logic by <a href="https://github.com/jww3"><code>@​jww3</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/963">actions/setup-python#963</a></li>
<li>Bump pillow from 7.2 to 10.2.0 by <a href="https://github.com/aparnajyothi-y"><code>@​aparnajyothi-y</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/956">actions/setup-python#956</a></li>
</ul>
<h3>Enhancements:</h3>
<ul>
<li>Enhance workflows and documentation updates by <a href="https://github.com/priya-kinthali"><code>@​priya-kinthali</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/965">actions/setup-python#965</a></li>
<li>Bump default versions to latest by <a href="https://github.com/jeffwidman"><code>@​jeffwidman</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/905">actions/setup-python#905</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/Jcambass"><code>@​Jcambass</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/941">actions/setup-python#941</a></li>
<li><a href="https://github.com/jww3"><code>@​jww3</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/963">actions/setup-python#963</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/setup-python/compare/v5...v5.3.0">https://github.com/actions/setup-python/compare/v5...v5.3.0</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="0b93645e9f"><code>0b93645</code></a> Enhance workflows: Add macOS 13 support, upgrade publish-action, and update d...</li>
<li><a href="9c76e71650"><code>9c76e71</code></a> Bump pillow from 7.2 to 10.2.0 in /<strong>tests</strong>/data  (<a href="https://redirect.github.com/actions/setup-python/issues/956">#956</a>)</li>
<li><a href="f4c5a1183d"><code>f4c5a11</code></a> Revise <code>isGhes</code> logic (<a href="https://redirect.github.com/actions/setup-python/issues/963">#963</a>)</li>
<li><a href="19dfb7b659"><code>19dfb7b</code></a> Bump default versions to latest (<a href="https://redirect.github.com/actions/setup-python/issues/905">#905</a>)</li>
<li><a href="e9675cc634"><code>e9675cc</code></a> Merge pull request <a href="https://redirect.github.com/actions/setup-python/issues/943">#943</a> from actions/Jcambass-patch-1</li>
<li><a href="3226af69c0"><code>3226af6</code></a> Upgrade IA publish</li>
<li><a href="70dcb22d26"><code>70dcb22</code></a> Merge pull request <a href="https://redirect.github.com/actions/setup-python/issues/941">#941</a> from actions/Jcambass-patch-1</li>
<li><a href="65b48c7115"><code>65b48c7</code></a> Create publish-immutable-actions.yml</li>
<li><a href="29a37be0a3"><code>29a37be</code></a> initial commit (<a href="https://redirect.github.com/actions/setup-python/issues/938">#938</a>)</li>
<li>See full diff in <a href="f677139bbe...0b93645e9f">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/setup-python&package-manager=github_actions&previous-version=5.2.0&new-version=5.3.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
 2024-10-29 06:24:35 +00:00