Ahmed Mohamed Sameh
c5d2104166
Make sure that a TextSelectionToolbarTextButton doesn't crash in 0x0 … ( #178374 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the
TextSelectionToolbarTextButton widget.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
2025-11-21 00:01:49 +00:00
Ahmed Mohamed Sameh
63ef482845
Make sure that a CupertinoSpellCheckSuggestionsToolbar doesn't crash … ( #177978 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the
CupertinoSpellCheckSuggestionsToolbar widget.
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-11-21 00:00:42 +00:00
Ahmed Mohamed Sameh
c2e3f39ae8
Make sure that a TabBar doesn't crash in 0x0 environment ( #178201 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the TabBar widget.
---------
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
2025-11-21 00:00:42 +00:00
Ahmed Mohamed Sameh
27d62d07e7
Make sure that a ToggleButtons doesn't crash in 0x0 environment ( #178454 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the ToggleButtons
widget.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
2025-11-20 23:59:29 +00:00
engine-flutter-autoroll
8be69481dd
Roll Skia from d7b961c5f305 to b9eafe0fab0c (6 revisions) ( #178888 )
...
https://skia.googlesource.com/skia.git/+log/d7b961c5f305..b9eafe0fab0c
2025-11-20 michaelludwig@google.com [graphite] Disallow a value of 0 for
SampleCount
2025-11-20 kjlubick@google.com Minor cleanups to SkJpegCodec
2025-11-20 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
Dawn from d5803ab29495 to f16b1cf2bb95 (11 revisions)
2025-11-20 robertphillips@google.com Disable
PersistentPipelineStorageTest for some Win11 jobs
2025-11-20 bungeman@google.com [pdf] Dump attribute element ids
2025-11-20 kjlubick@google.com Delete leftover build_overrides for tint
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
codefu@google.com ,kjlubick@google.com,robertphillips@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-20 23:54:21 +00:00
b-luk
59945af629
Add macrobenchmark perf test for drawing arcs ( #178690 )
...
Adding a benchmark so the impact of #178269 can be measured.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-20 23:50:37 +00:00
engine-flutter-autoroll
b3298ebef4
Roll Dart SDK from 5b21f8a7d5d3 to 0894b46fff76 (1 revision) ( #178881 )
...
https://dart.googlesource.com/sdk.git/+log/5b21f8a7d5d3..0894b46fff76
2025-11-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-157.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-20 20:15:01 +00:00
engine-flutter-autoroll
cf13abbd85
Roll Skia from 6284b4f09e14 to d7b961c5f305 (1 revision) ( #178867 )
...
https://skia.googlesource.com/skia.git/+log/6284b4f09e14..d7b961c5f305
2025-11-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 9512ac41850e to b7b8946e9bdf (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
codefu@google.com ,kjlubick@google.com,robertphillips@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-20 16:09:12 +00:00
engine-flutter-autoroll
1254e165dd
Roll Fuchsia Linux SDK from 0z3qxzY6CWb8iVxEf... to Y-cMdgKy3d6EnibWR... ( #178865 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC codefu@google.com ,zra@google.com on the revert to ensure that
a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-20 15:57:34 +00:00
engine-flutter-autoroll
1ee3f59f62
Roll Packages from 8f72e4b9d66e to b1e2fb049013 (6 revisions) ( #178868 )
...
8f72e4b9d6...b1e2fb0490stuartmorgan@google.com [path_provider] Convert iOS/macOS to
FFI package (flutter/packages#9762 )
2025-11-19 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.squareup.okhttp3:okhttp from 5.3.0 to 5.3.1 in
/packages/espresso/android (flutter/packages#10446 )
2025-11-19 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump androidx.browser:browser from 1.8.0 to 1.9.0 in
/packages/url_launcher/url_launcher_android/android
(flutter/packages#10115 )
2025-11-19 47866232+chunhtai@users.noreply.github.com [ci] Adds github
action for creating batch release (flutter/packages#10298 )
2025-11-19 stuartmorgan@google.com [camera] Remove deprecated feature
from Windows example (flutter/packages#10380 )
2025-11-19 engine-flutter-autoroll@skia.org Roll Flutter from
cb7b7dfe86c7 to de4be4f3892d (20 revisions) (flutter/packages#10468 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-20 15:51:23 +00:00
engine-flutter-autoroll
9f383e0990
Roll Dart SDK from 331595776540 to 5b21f8a7d5d3 (1 revision) ( #178861 )
...
https://dart.googlesource.com/sdk.git/+log/331595776540..5b21f8a7d5d3
2025-11-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-156.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-20 15:22:44 +00:00
engine-flutter-autoroll
483505b825
Roll ICU from f27805b7d7d8 to a86a32e67b8d (1 revision) ( #178859 )
...
f27805b7d7..a86a32e67bftang@chromium.org Fix undefined behavior front() call Cherry
pick undefined behavior fix from ICU PR3752
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/icu-sdk-flutter
Please CC codefu@google.com ,fuchsia-ui-discuss@google.com on the revert
to ensure that a human
is aware of the problem.
To file a bug in ICU: https://github.com/unicode-org/icu
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-20 12:28:27 +00:00
engine-flutter-autoroll
d26244b2b3
Roll Dart SDK from d6f9477a2d9f to 331595776540 (1 revision) ( #178851 )
...
https://dart.googlesource.com/sdk.git/+log/d6f9477a2d9f..331595776540
2025-11-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-155.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-20 09:10:26 +00:00
engine-flutter-autoroll
13de9c88a8
Roll Skia from 5bdda9a41db9 to 6284b4f09e14 (3 revisions) ( #178849 )
...
https://skia.googlesource.com/skia.git/+log/5bdda9a41db9..6284b4f09e14
2025-11-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 7b89c0056fc1 to a0962979c751 (11 revisions)
2025-11-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from f90f8d916021 to 4c3f46be5e92 (8 revisions)
2025-11-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from d7523eb33930 to d5803ab29495 (6 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
codefu@google.com ,kjlubick@google.com,robertphillips@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-20 08:48:42 +00:00
engine-flutter-autoroll
5bc23becc0
Roll Skia from 24c28206d912 to 5bdda9a41db9 (2 revisions) ( #178845 )
...
https://skia.googlesource.com/skia.git/+log/24c28206d912..5bdda9a41db9
2025-11-20 michaelludwig@google.com [graphite] Minor cleanup in prep for
SampleCount migration
2025-11-20
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
codefu@google.com ,kjlubick@google.com,robertphillips@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-20 05:38:32 +00:00
engine-flutter-autoroll
3be0461499
Roll Dart SDK from 7506c64a5117 to d6f9477a2d9f (1 revision) ( #178844 )
...
https://dart.googlesource.com/sdk.git/+log/7506c64a5117..d6f9477a2d9f
2025-11-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-154.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-20 04:01:26 +00:00
engine-flutter-autoroll
2256707115
Roll Skia from fd41f3650729 to 24c28206d912 (2 revisions) ( #178841 )
...
https://skia.googlesource.com/skia.git/+log/fd41f3650729..24c28206d912
2025-11-20
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-11-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from c26927eb0c50 to 9512ac41850e (10 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
codefu@google.com ,kjlubick@google.com,robertphillips@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-20 03:39:27 +00:00
Matthew Kosarek
eea45ac3b2
Use WidgetsBinding.instance.platformDispatcher in windowing instead of PlatformDispatcher.instance ( #178799 )
...
This is the recommended way to do this as it allows us to override the
platform dispatcher when that is necessary
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-11-20 03:01:27 +00:00
gaaclarke
d8fc22e25c
[Impeller] Adds support for r32float textures ( #178418 )
...
fixes https://github.com/flutter/flutter/issues/178420
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-20 01:28:35 +00:00
engine-flutter-autoroll
f3415ecb66
Roll Skia from a283da7a6b6c to fd41f3650729 (2 revisions) ( #178838 )
...
https://skia.googlesource.com/skia.git/+log/a283da7a6b6c..fd41f3650729
2025-11-19
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-11-19 michaelludwig@google.com Add more Graphite jobs to waterfall
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
codefu@google.com ,kjlubick@google.com,robertphillips@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-20 01:20:33 +00:00
Chinmay Garde
5467431da9
[Impeller] Deny-list Adreno 640 and 650 for Vulkan eligibility. ( #178833 )
...
Fallback to OpenGL ES on these devices. See linked issues for rationale.
Fixes https://github.com/flutter/flutter/issues/178285
Fixes https://github.com/flutter/flutter/issues/178498
2025-11-20 00:24:26 +00:00
engine-flutter-autoroll
264eabd315
Roll Skia from b5dc8c3494ac to a283da7a6b6c (8 revisions) ( #178832 )
...
https://skia.googlesource.com/skia.git/+log/b5dc8c3494ac..a283da7a6b6c
2025-11-19
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-11-19
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-11-19 mike@reedtribe.org fix signed/unsigned warning
2025-11-19 michaelludwig@google.com Reland "[graphite] Use SampleCount
enum for sample count in TextureInfo"
2025-11-19 kjlubick@google.com Fix quoting of windows paths with spaces
2025-11-19 mike@reedtribe.org Adapt remaining callers to be compatible
with std::span
2025-11-19 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
Dawn from dac92db6ead5 to d7523eb33930 (7 revisions)
2025-11-19 kjlubick@google.com Disable legacy PNG encoding/decoding in
SkPicture
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
codefu@google.com ,kjlubick@google.com,robertphillips@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-19 23:00:11 +00:00
engine-flutter-autoroll
ecca0669e4
Roll Dart SDK from f7e9bd245fd9 to 7506c64a5117 (3 revisions) ( #178828 )
...
https://dart.googlesource.com/sdk.git/+log/f7e9bd245fd9..7506c64a5117
2025-11-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-153.0.dev
2025-11-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-152.0.dev
2025-11-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-151.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-19 22:57:55 +00:00
Valentin Vignal
caa84ba097
Allow the RawAutocomplete to display the options even when one is selected ( #177705 )
...
Fixes https://github.com/flutter/flutter/issues/177429
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
2025-11-19 22:26:12 +00:00
Mouad Debbar
ea23b986ae
[web] Skip flaky service worker test ( #178820 )
...
Fixes https://github.com/flutter/flutter/issues/178032
2025-11-19 22:04:57 +00:00
walley892
664da1fe8f
Only call glCheckFrameBufferStatus in the render pass in debug builds ( #178707 )
...
Rendering to an offscreen texture on platforms without implicit MSAA
resolve causes the creation of a framebuffer each frame and a subsequent
call to glCheckFramebufferStatus.
This call can cause a full [GPU round trip]
(https://developer.mozilla.org/en-US/docs/Web/API/WebGL_API/WebGL_best_practices#avoid_blocking_api_calls_in_production ).
This change creates a function in the proc table that only actually
makes the glCheckFramebufferStatus check in debug builds, and changes
the calls in render_pass_gles to use this function instead.
An alternate way of doing this would be to directly wrap the callsites
with `ifdef` checks, but this way was more easily testable and seemed
cleaner.
Also removes a redundant call to CheckFramebufferStatus.
Fixes https://github.com/flutter/flutter/issues/175522
## Pre-launch Checklist
- [ x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ x] I read and followed the [Flutter Style Guide], including
[Features we expect every widget to implement].
- [ x] I signed the [CLA].
- [ x] I listed at least one issue that this PR fixes in the description
above.
- [ x] I updated/added relevant documentation (doc comments with `///`).
- [ x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ x] All existing and new tests are passing.
2025-11-19 21:17:10 +00:00
Kate Lovett
b62b97fd06
Manual pub roll ( #178687 )
...
Fresh crack at https://github.com/flutter/flutter/pull/178558 after
changes in flutter/tests and flutter/packages
Fixes https://github.com/flutter/flutter/issues/178270
Replaces https://github.com/flutter/flutter/pull/178312
Following up on why the script is not generating lock files in
https://github.com/flutter/flutter/issues/178409
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-19 20:49:22 +00:00
Jonathan Gilbert
0b34640871
Document that error parameter must be initialized ( #177730 )
...
Flutter is built on top of GLib, and GLib's standard error mechanism
uses a structure `GError` and a function `g_set_error`. This function
takes a pointer to a pointer, setting it to a new `GError` for the outer
caller to receive. The model is designed to capture the first error that
occurs; as such, `g_set_error` checks if the supplied (by reference)
pointer is _already_ pointing at something. If it is, then it simply
emits a warning about this new error and discards it, assuming that
`error` already points at a presumably more-pertinent `GError`.
This semantic is sensible, but it isn't automatically obvious. It makes
sense when a function is calling multiple other functions, each of which
could return an error, ensuring that the error that gets returned is the
first one that happened. But, if you're only calling one function and
you don't have prior exposure to this design, it might not be
intuitively obvious that it has this intentional behaviour. Instead, the
`GError** error` parameter just looks like any old `out` parameter. That
can lead to code being written that doesn't bother to initialize the
error variable; after all, if no error occurs, it's irrelevant, and if
an error _does_ occur, then the function will overwrite it anyway,
right? (This latter being the incorrect assumption.)
```
// INCORRECT CODE
GError *error;
if (!fl_method_call_respond_success(method_call, result_value, &error)) {
g_warning("Failed to send Flutter Platform Channel response: %s", error->message);
g_error_free(error);
}
```
GLib handles the fact that this isn't automatically obvious to someone
with no prior experience with straightforward documentation:
> GLib ▶ set_error
>
> Does nothing if `err` is `NULL`; **if `err` is non-`NULL`, then `*err`
must be `NULL`**. A new `GError` is created and assigned to `*err`.
Since this is, ultimately, the function used internally by Flutter API
functions to return errors through this channel, Flutter effectively has
this same semantic. As such:
```
// CORRECT CODE
GError *error = nullptr;
if (!fl_method_call_respond_success(method_call, result_value, &error)) {
g_warning("Failed to send Flutter Platform Channel response: %s", error->message);
g_error_free(error);
}
```
(edited per @robert-ancell) In addition, `g_autoptr` can be used to make
a smart pointer that automatically ensures that the error, if any, is
not leaked.
```
// CORRECTER CODE
g_autoptr(GError) error = nullptr;
if (!fl_method_call_respond_success(method_call, result_value, &error)) {
g_warning("Failed to send Flutter Platform Channel response: %s", error->message);
}
```
Flutter should make a similar mention in its documentation so that
people who are just discovering the system don't make the same mistake I
did. 🙂
This PR updates the inline documentation comments for public functions
that take `GError** error` parameters to warn concisely about this
situation. Note that it is not required (at least by `g_set_error`) that
they poin at `NULL`, specifically, just that they not be
_uninitialized_.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
---------
Co-authored-by: Robert Ancell <robert.ancell@canonical.com>
2025-11-19 20:00:25 +00:00
Mohellebi abdessalem
c9c321b1f7
Update _CircularProgressIndicatorState to use transform directly ( #178569 )
...
`evaluate` use transform under the hood :
``` dart
T evaluate(Animation<double> animation) => transform(animation.value);
```
in that case , it is possible to use `transform` direclty:
```dart
transform(animation.value);
```
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-19 19:13:03 +00:00
Simon Binder
17e65b6f51
Fix layout for macOS frameworks for code assets ( #178625 )
...
To implement code assets, Flutter tooling converts `.dylib` files
emitted by hooks into Apple frameworks. The format of frameworks is
slightly different between macOS and other Apple platforms, and this
comment explains the correct format for macOS:
f954fb79dd/packages/flutter_tools/lib/src/isolated/native_assets/macos/native_assets.dart (L134-L142)https://github.com/flutter/flutter/issues/178623 .
2025-11-19 17:43:00 +00:00
engine-flutter-autoroll
74d44b7a12
Roll Packages from 34746bb64150 to 8f72e4b9d66e (7 revisions) ( #178800 )
...
34746bb641...8f72e4b9d6victoreronmosele@gmail.com [rfw] Update broken links in rfw's
README.md (flutter/packages#9796 )
2025-11-19 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump androidx.activity:activity from 1.10.1 to 1.11.0 in
/packages/image_picker/image_picker_android/android
(flutter/packages#10045 )
2025-11-19 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump androidx.core:core from 1.13.1 to 1.17.0 in
/packages/url_launcher/url_launcher_android/android
(flutter/packages#9855 )
2025-11-19 matt.boetger@gmail.com Upgrade AGP to 8.9.1
(flutter/packages#10458 )
2025-11-18 stuartmorgan@google.com [pigeon] Update analyzer range to 8-9
(flutter/packages#10466 )
2025-11-18 stuartmorgan@google.com [in_app_purchase] Rename Swift Pigeon
output file (flutter/packages#10465 )
2025-11-18 engine-flutter-autoroll@skia.org Roll Flutter from
cc14ef529014 to cb7b7dfe86c7 (20 revisions) (flutter/packages#10464 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-19 16:02:01 +00:00
engine-flutter-autoroll
de4be4f389
Roll Skia from 2054d87c6a85 to b5dc8c3494ac (1 revision) ( #178793 )
...
https://skia.googlesource.com/skia.git/+log/2054d87c6a85..b5dc8c3494ac
2025-11-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 9b6c16d9b2da to c26927eb0c50 (7 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
codefu@google.com ,kjlubick@google.com,robertphillips@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-19 13:19:11 +00:00
engine-flutter-autoroll
a32d497709
Roll Skia from a30b02d57637 to 2054d87c6a85 (2 revisions) ( #178787 )
...
https://skia.googlesource.com/skia.git/+log/a30b02d57637..2054d87c6a85
2025-11-19 ccameron@chromium.org AGTM: Add metadata parsing support
2025-11-19
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
codefu@google.com ,kjlubick@google.com,robertphillips@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-19 11:04:43 +00:00
engine-flutter-autoroll
13c3d0754f
Roll Skia from 547e3e5441b4 to a30b02d57637 (3 revisions) ( #178782 )
...
https://skia.googlesource.com/skia.git/+log/547e3e5441b4..a30b02d57637
2025-11-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 69d6d0792295 to 7b89c0056fc1 (6 revisions)
2025-11-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from a09406cc5e0c to dac92db6ead5 (8 revisions)
2025-11-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 0ff27a15480f to f90f8d916021 (14 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
codefu@google.com ,kjlubick@google.com,robertphillips@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-19 09:11:41 +00:00
Kostia Sokolovskyi
2fff488d60
Fix train hopping animation status listeners ( #178372 )
...
Fixes https://github.com/flutter/flutter/issues/178336
### Description
- Fixes `TrainHoppingAnimation` to notify status listeners when `status`
changes
- Adds tests
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-19 07:12:19 +00:00
Ahmed Mohamed Sameh
452314c7d2
Make sure that a ReorderableListView doesn't crash in 0x0 environment ( #177646 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the
ReorderableListView widget.
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
2025-11-19 06:50:12 +00:00
engine-flutter-autoroll
26106d17b4
Roll Skia from 9ce01a452f63 to 547e3e5441b4 (1 revision) ( #178775 )
...
https://skia.googlesource.com/skia.git/+log/9ce01a452f63..547e3e5441b4
2025-11-19
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
codefu@google.com ,kjlubick@google.com,robertphillips@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-19 06:14:28 +00:00
engine-flutter-autoroll
74d4669956
Roll Dart SDK from 1ed6b56bb323 to f7e9bd245fd9 (1 revision) ( #178774 )
...
https://dart.googlesource.com/sdk.git/+log/1ed6b56bb323..f7e9bd245fd9
2025-11-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-150.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-19 06:08:39 +00:00
engine-flutter-autoroll
be3e9af464
Roll Skia from f3ddc700abc7 to 9ce01a452f63 (8 revisions) ( #178769 )
...
https://skia.googlesource.com/skia.git/+log/f3ddc700abc7..9ce01a452f63
2025-11-19
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-11-19
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-11-18 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
ANGLE from d7712703ca0d to 69d6d0792295 (11 revisions)
2025-11-18 robertphillips@google.com Revert "[graphite] Use SampleCount
enum for sample count in TextureInfo"
2025-11-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from cae0863d65e2 to 9b6c16d9b2da (9 revisions)
2025-11-18 jlavrova@google.com Reland "A minimal change letting Fuchsia
to use Fontations"
2025-11-18 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
Dawn from 7df710dc8ae8 to a09406cc5e0c (10 revisions)
2025-11-18
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
codefu@google.com ,kjlubick@google.com,robertphillips@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-19 03:59:09 +00:00
Ahmed Mohamed Sameh
7a6d2faa58
Make sure that a TabPageSelector doesn't crash in 0x0 environment ( #178156 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the TabPageSelector
widget.
2025-11-19 03:55:20 +00:00
Mohellebi abdessalem
5e94425aef
Small cleanup in DeferredComponentManager.java ( #178585 )
...
this change :
- fixes the link in docs that is specified as a text
- removes `unnecessary` `public/abstract` modifiers in a `public
interface`
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Matt Boetger <matt.boetger@gmail.com>
Co-authored-by: Matt Boetger <boetger@google.com>
2025-11-19 01:32:49 +00:00
engine-flutter-autoroll
1e11a4ce0a
Roll Dart SDK from a33149cb6643 to 1ed6b56bb323 (1 revision) ( #178763 )
...
https://dart.googlesource.com/sdk.git/+log/a33149cb6643..1ed6b56bb323
2025-11-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-149.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-19 00:22:34 +00:00
engine-flutter-autoroll
3f6cf34f85
Roll Skia from 8557300f84c2 to f3ddc700abc7 (5 revisions) ( #178751 )
...
https://skia.googlesource.com/skia.git/+log/8557300f84c2..f3ddc700abc7
2025-11-18 bungeman@google.com Use SkIsPow2 to avoid parentheses warning
2025-11-18 michaelludwig@google.com [graphite] Use SampleCount enum for
sample count in TextureInfo
2025-11-18 thomsmit@google.com [graphite] Remove handling of recursive
flushTrackedDevices
2025-11-18 mike@reedtribe.org Prepare more call-sites for std::span
2025-11-18 kjlubick@google.com Fix Bazel style nits
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
codefu@google.com ,kjlubick@google.com,robertphillips@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-18 20:20:37 +00:00
Mohellebi abdessalem
c7ba5df62e
Remove unnecessary String.valueOf in TextInputChannel.java ( #178592 )
...
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-18 20:06:59 +00:00
Kevin Moore
b1f4694258
[tool] Further cleanup of proxy logic ( #178683 )
...
Move getFinalTargetUri to ProxyRule class
Fix doc comments
Pares URI immediately when creating RegexProxyRule
---------
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
2025-11-18 20:06:57 +00:00
Jason Simmons
88f960983f
Restore OpenGL state modified by fl_compositor_opengl_present_layers ( #178697 )
...
The OpenGL context used there may be shared with Skia, and Skia assumes
that other code has not changed its state.
See https://github.com/flutter/flutter/issues/178547
2025-11-18 20:06:57 +00:00
Mohellebi abdessalem
d3f3905dc5
Replace equals("") with isEmpty in SpellCheckPlugin.java ( #178596 )
...
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Reid Baker <1063596+reidbaker@users.noreply.github.com>
2025-11-18 20:05:35 +00:00
engine-flutter-autoroll
8f69a96c89
Roll Dart SDK from 312845b06afc to a33149cb6643 (2 revisions) ( #178738 )
...
https://dart.googlesource.com/sdk.git/+log/312845b06afc..a33149cb6643
2025-11-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-148.0.dev
2025-11-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-147.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-18 18:22:34 +00:00
engine-flutter-autoroll
d4f93b49c5
Roll Skia from ca906091e199 to 8557300f84c2 (2 revisions) ( #178739 )
...
https://skia.googlesource.com/skia.git/+log/ca906091e199..8557300f84c2
2025-11-18 thomsmit@google.com [graphite] cleanup draw geometry stroke
and fill
2025-11-18 sergiog@microsoft.com [rust png ] Add explicit dependency to
rust_cxx_core_bazel_build action
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
codefu@google.com ,kjlubick@google.com,robertphillips@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-18 18:14:21 +00:00
auto-submit[bot]
3421c03394
Reverts "Add framework-side hitTestBehavior support for Semantics widget and apply to ModalRoute ( #177570 )" ( #178744 )
...
<!-- start_original_pr_link -->
Reverts: flutter/flutter#177570
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: chingjun
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Broke internal tests.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: flutter-zl
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {chunhtai}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
Fix premature dialog dismissal on Flutter Web when semantics are enabled
by correctly propagating hitTestBehavior through the semantics pipeline
and declaring modal routes as opaque to pointer events.
Before change
https://dialog-dismiss-before.web.app/
Click on the "Show Dialog" button.
Click anywhere inside the dialog that is not a form field.
Observe the dialog being dismissed.
After change
https://dialog-dimiss-after.web.app/
Click on the "Show Dialog" button.
Click anywhere inside the dialog that is not a form field.
Observe the dialog not dismissed.
Fixes : #149001
Engine work: #176974
<!-- end_revert_body -->
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
2025-11-18 17:44:48 +00:00
