33888 Commits

Author SHA1 Message Date
skia-flutter-autoroll
c4beeacb6f Roll Dart SDK from 1f136c7b962d to 82936dcdaf4f (1 revision) (flutter/engine#50212)
https://dart.googlesource.com/sdk.git/+log/1f136c7b962d..82936dcdaf4f

2024-01-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-97.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-31 21:41:21 +00:00
gaaclarke
c35dbe26fc [Impeller] implemented golden image tests for opengles (flutter/engine#50146)
fixes https://github.com/flutter/flutter/issues/142354

This sets up impeller_golden_tests to run with ANGLE.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-01-31 20:49:40 +00:00
skia-flutter-autoroll
6ae0666bb7 Roll Skia from 647271c1b744 to 0ad5b2a9cebd (2 revisions) (flutter/engine#50208)
https://skia.googlesource.com/skia.git/+log/647271c1b744..0ad5b2a9cebd

2024-01-31 jvanverth@google.com MotionMarkSlide: make sure we enable AA for canvas tests.
2024-01-31 nicolettep@google.com [graphite] Create and store Vulkan pipelines for loading MSAA from resolve

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jmbetancourt@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-31 19:48:36 +00:00
skia-flutter-autoroll
63bcf7285e Roll Skia from 053848101c10 to 647271c1b744 (2 revisions) (flutter/engine#50206)
https://skia.googlesource.com/skia.git/+log/053848101c10..647271c1b744

2024-01-31 borenet@google.com [infra] Update dimensions for IntelIrisXe on Windows
2024-01-31 fmalita@chromium.org Update internal links

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jmbetancourt@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-31 18:57:18 +00:00
skia-flutter-autoroll
05024f6bcf Roll Dart SDK from fbf1d8ebceb4 to 1f136c7b962d (1 revision) (flutter/engine#50203)
https://dart.googlesource.com/sdk.git/+log/fbf1d8ebceb4..1f136c7b962d

2024-01-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-96.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-31 17:55:22 +00:00
Jenn Magder
12dc7ef814 Log FlutterJSONMessageCodec decode errors before asserting (flutter/engine#50163)
Logging JSON decode errors on assertion will help track down bugs.
https://github.com/flutter/flutter/issues/100891#issuecomment-1915946340

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-01-31 17:31:00 +00:00
Mouad Debbar
266c32239f [web] Final nail in FlutterViewEmbedder's coffin (flutter/engine#49769)
- Extracted `ResourceManager` out of `FlutterViewEmbedder`.
- Extracted `GlobalHtmlAttributes` out of `FlutterViewEmbedder`.
- Removed usages of:
    - `FlutterViewEmbedder.reset()`.
    - `flutterViewEmbedder`.
    - `ensureFlutterViewEmbedderInitialized`.
- Deleted `FlutterViewEmbedder`.

Fixes https://github.com/flutter/flutter/issues/134443
2024-01-31 17:22:44 +00:00
skia-flutter-autoroll
d6a71d3e1a Roll Skia from 439a6aae5036 to 053848101c10 (2 revisions) (flutter/engine#50202)
https://skia.googlesource.com/skia.git/+log/439a6aae5036..053848101c10

2024-01-31 yorkiefixer@gmail.com Improve the error report
2024-01-31 drott@chromium.org Minor: Fix comment in Fontations FFI and reformat file

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jmbetancourt@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-31 17:15:00 +00:00
skia-flutter-autoroll
373efe3b0f Roll Skia from f916aedaa69b to 439a6aae5036 (4 revisions) (flutter/engine#50201)
https://skia.googlesource.com/skia.git/+log/f916aedaa69b..439a6aae5036

2024-01-31 drott@chromium.org [Fontations-backend] Provide FFI for retrieving number of fonts in TTC
2024-01-31 mike@reedtribe.org refactor freetype common into utils
2024-01-31 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 748ca55a148e to deb32c4a0943 (5 revisions)
2024-01-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e3e353f61590 to cfc202524ce6 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jmbetancourt@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-31 16:15:04 +00:00
skia-flutter-autoroll
5b4e1656dc Roll Dart SDK from cd834c2ade57 to fbf1d8ebceb4 (1 revision) (flutter/engine#50199)
https://dart.googlesource.com/sdk.git/+log/cd834c2ade57..fbf1d8ebceb4

2024-01-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-95.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-31 13:51:34 +00:00
skia-flutter-autoroll
501348944c Roll Fuchsia Linux SDK from Z-xFM2ILZJw22eU8q... to nymRxHV9Shod7cyLe... (flutter/engine#50197)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-31 11:07:27 +00:00
skia-flutter-autoroll
83ebba423f Roll Skia from ef48b123d2d1 to f916aedaa69b (1 revision) (flutter/engine#50196)
https://skia.googlesource.com/skia.git/+log/ef48b123d2d1..f916aedaa69b

2024-01-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 3c9b934fc33b to bae186e10a17

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jmbetancourt@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-31 09:05:30 +00:00
skia-flutter-autoroll
92d040787c Roll Dart SDK from 488e33cd39de to cd834c2ade57 (2 revisions) (flutter/engine#50195)
https://dart.googlesource.com/sdk.git/+log/488e33cd39de..cd834c2ade57

2024-01-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-94.0.dev
2024-01-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-93.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-31 08:28:06 +00:00
skia-flutter-autoroll
ff2f27dc7c Roll Skia from eb1d9b467596 to ef48b123d2d1 (1 revision) (flutter/engine#50194)
https://skia.googlesource.com/skia.git/+log/eb1d9b467596..ef48b123d2d1

2024-01-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 5c2fc02b8dd5 to 0ada0b7f1fd1 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jmbetancourt@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-31 08:08:22 +00:00
skia-flutter-autoroll
a08e7c7e41 Roll Skia from fec9deb3d8c6 to eb1d9b467596 (1 revision) (flutter/engine#50193)
https://skia.googlesource.com/skia.git/+log/fec9deb3d8c6..eb1d9b467596

2024-01-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from cc636969b7b7 to 748ca55a148e (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jmbetancourt@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-31 07:26:19 +00:00
skia-flutter-autoroll
88abd6a82b Roll Skia from 1fbb575f968d to fec9deb3d8c6 (1 revision) (flutter/engine#50192)
https://skia.googlesource.com/skia.git/+log/1fbb575f968d..fec9deb3d8c6

2024-01-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from d040a5bab638 to 2cc2b392c9ef (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jmbetancourt@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-31 06:24:05 +00:00
zijiehe@
b2d8969566 [Fuchsia] Execute most of the testing/fuchsia/test_suites.yaml on debug and release builds (flutter/engine#50058)
This change implements a BundledTestRunner to run most of the tests in testing/fuchsia/test_suites.yaml as ExecutableTestRunner.

- Tests with packages out of out/fuchsia_*_x64/ are ignored for now.
- Tests with extra test command line parameters are ignored for now.

The BundledTestRunner can share most of the logic in ExecutableTestRunner and avoid reinventing the wheel.

This change also fixes the build break of fuchsia_tests in fuchsia_release_x64 which allows tests to run on the build as well.

- Tests not built with AOT are filtered out with variant field in test_suites.yaml.

Bug: https://github.com/flutter/flutter/issues/140179

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-01-31 05:39:21 +00:00
skia-flutter-autoroll
136d0dad28 Roll Skia from bf27636582c7 to 1fbb575f968d (1 revision) (flutter/engine#50190)
https://skia.googlesource.com/skia.git/+log/bf27636582c7..1fbb575f968d

2024-01-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 35e2efb89c92 to 3c9b934fc33b (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jmbetancourt@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-31 05:33:12 +00:00
Martin Kustermann
891ac4e5bd More correctly name methods regarding event loop that are currently named microtask (flutter/engine#50138)
Flutter implements the UI isolates message via posting to a UI task queue. That task queue has a primary and a secondary queue. The

* primary is used for running tasks resulated to framework (e.g. draw frame)
* secondary is used to run Dart event loop messages (e.g. received data on a socket)

The Dart semantics requires running microtasks before processing the next event loop message.

The way flutter implements by attaching an observer to the secondary queue. Every time a task from the queue is run, all observers are run and one of them is going to run pending microtasks.

In some situations the engine pauses the dart event loop. The terminology used in the code is "microtask" when in reality what it means is "event loop".

=> This PR changes this terminology to reflect what actually happens.
2024-01-31 04:41:28 +00:00
skia-flutter-autoroll
f219a6aca1 Roll Skia from 76da7ec3e106 to bf27636582c7 (1 revision) (flutter/engine#50187)
https://skia.googlesource.com/skia.git/+log/76da7ec3e106..bf27636582c7

2024-01-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e4d0bd2c607d to e3e353f61590 (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jmbetancourt@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-31 00:06:04 +00:00
skia-flutter-autoroll
fdfc2f4506 Roll Skia from 62cab132c9ad to 76da7ec3e106 (1 revision) (flutter/engine#50186)
https://skia.googlesource.com/skia.git/+log/62cab132c9ad..76da7ec3e106

2024-01-30 bungeman@google.com [pdf] Avoid Skia color profile on single channel images

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jmbetancourt@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-30 23:10:36 +00:00
skia-flutter-autoroll
79730c43be Roll Dart SDK from 734aae9604e8 to 488e33cd39de (1 revision) (flutter/engine#50185)
https://dart.googlesource.com/sdk.git/+log/734aae9604e8..488e33cd39de

2024-01-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-92.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-30 23:09:09 +00:00
Jonah Williams
1cd141f1a1 [Impeller] Reland: add interface for submitting multiple command buffers at once. (flutter/engine#50180)
Reland of:  https://github.com/flutter/engine/pull/50139

Metal does not seem to like it when we collect 50+ command buffers at once. Adjust the aiks context logic to regularly flush the cmd buffers.
2024-01-30 21:21:48 +00:00
Ivan Inozemtsev
ed5346b40a Support running sound null safe kernels from flutter_jit_runner (flutter/engine#50002)
- use core vm snapshot instead of core-jit, which does not seem to support sound null safety agnostic mode
- remove hardcoded `--no-sound-null-safety` flags from native code and ninja args
- add `sound_null_safety` attribute to `flutter_component` in ninja, which propagates to `dart_kernel`
- migrate one integration test to sound null safety, so that there are integration tests in both modes

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-01-30 21:12:16 +00:00
skia-flutter-autoroll
a20f508ec0 Roll Skia from 739b66191c66 to 62cab132c9ad (2 revisions) (flutter/engine#50181)
https://skia.googlesource.com/skia.git/+log/739b66191c66..62cab132c9ad

2024-01-30 kjlubick@google.com Add missing dep to bmp_decode
2024-01-30 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 2c49546e9502 to cc636969b7b7 (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jmbetancourt@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-30 20:49:19 +00:00
杨加康
59947fce84 Revert "Close connection on keyboard close (#41500)" (flutter/engine#49366)
Related issue:

https://github.com/flutter/flutter/issues/140508
2024-01-30 19:20:25 +00:00
skia-flutter-autoroll
2c9ed77129 Roll Dart SDK from 10bbb376de7e to 734aae9604e8 (1 revision) (flutter/engine#50179)
https://dart.googlesource.com/sdk.git/+log/10bbb376de7e..734aae9604e8

2024-01-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-91.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-30 19:11:05 +00:00
gaaclarke
fca1b2166a [Impeller] added mipmaps to subpasses directly on a draw call (flutter/engine#50157)
fixes https://github.com/flutter/flutter/issues/142001

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-01-30 10:48:19 -08:00
skia-flutter-autoroll
72d65e3139 Manual roll Dart SDK from d0b48a008559 to 10bbb376de7e (8 revisions) (flutter/engine#50172)
Manual roll requested by jacksongardner@google.com

https://dart.googlesource.com/sdk.git/+log/d0b48a008559..10bbb376de7e

2024-01-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-90.0.dev
2024-01-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-89.0.dev
2024-01-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-88.0.dev
2024-01-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-87.0.dev
2024-01-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-86.0.dev
2024-01-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-85.0.dev
2024-01-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-84.0.dev
2024-01-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-83.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-30 18:16:19 +00:00
skia-flutter-autoroll
60a7698818 Roll Skia from 7df4d35e11cf to 739b66191c66 (1 revision) (flutter/engine#50175)
https://skia.googlesource.com/skia.git/+log/7df4d35e11cf..739b66191c66

2024-01-30 jvanverth@google.com Split MotionMark slide into separate slides.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jmbetancourt@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-30 17:53:50 +00:00
Jonah Williams
b651a8da81 [Android] Reland: recycle hardware buffer textures. (flutter/engine#50122)
Reland of https://github.com/flutter/engine/pull/50028 , which was reverted because I missed the different API level requirement of getId. getID now returns an optional which is nullopt on API level < 31.

Fixes https://github.com/flutter/flutter/issues/142365
2024-01-30 17:46:20 +00:00
Mitchell Kember
cc7d08d179 Roll buildroot to 52689fe8955a9a4916a38f0b8ae5ea3e217037f4 (flutter/engine#50160)
To pick up flutter/buildroot#821, which completed the migration to the fidlgen_cpp tables.c file.

This will unblock landing https://fxrev.dev/953990, which removes the fidlc `--tables` flag.

This work is tracked in https://fxbug.dev/42115242.
2024-01-30 17:24:04 +00:00
auto-submit[bot]
f3e4437823 Reverts "[Impeller] Add interface for submitting multiple command buffers at once." (flutter/engine#50174)
Reverts flutter/engine#50139
Initiated by: jonahwilliams
This change reverts the following previous change:
Original Description:
The Impeller Vulkan backend benefits from batching submission to the vk graphics queue. Managing this automatically is non-trivial and adds surprising/fragile thread based behavior, see: https://github.com/flutter/engine/pull/49870

Instead, introduce an impeller::CommandQueue object that command buffers must be submitted to in lieu of CommandBuffer->Submit, which has been made private.

TLDR

old
```c++
buffer->Submit();
```

new
```c++
context.GetQueue()->Submit({buffer});
```

The Metal and GLES implementations internally just call the private CommandBuffer->Submit, though there may be future opportunities to simplify here. The Vulkan implementation is where the meat is.

Aiks takes advantage of this by storing all command buffers on the aiks context while rendering a frame, and then performing one submit in aiks_context render. I don't think this will introduce any thread safety problems, as we don't guarantee much about aiks context - nor do we use it in a multithreaded context as far as I know.

Other tasks such as image upload still just directly submit their command buffers via the queue.

Fixes https://github.com/flutter/flutter/issues/141123
2024-01-30 17:13:17 +00:00
skia-flutter-autoroll
69ed53e89e Roll Skia from a3d46fac53be to 7df4d35e11cf (3 revisions) (flutter/engine#50173)
https://skia.googlesource.com/skia.git/+log/a3d46fac53be..7df4d35e11cf

2024-01-30 penghuang@chromium.org [graphite] Reduce fIntrinsicConstantBuffer size
2024-01-30 cwallez@chromium.org SkSL -> WGSL use @blend_src instead of @index.
2024-01-30 egdaniel@google.com [Graphite] Add Dawn and Native Vulkan test and perf jobs.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jmbetancourt@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-30 17:07:37 +00:00
skia-flutter-autoroll
e57271c3eb Roll Skia from c2fada52fdc4 to a3d46fac53be (2 revisions) (flutter/engine#50171)
https://skia.googlesource.com/skia.git/+log/c2fada52fdc4..a3d46fac53be

2024-01-30 johnstiles@google.com Fix fuzzer-discovered error with dead-variable elimination.
2024-01-30 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 2c6332b39875 to 2c49546e9502 (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jmbetancourt@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-30 16:16:20 +00:00
skia-flutter-autoroll
6bc5af534f Roll Skia from 7dc9ba2e8c90 to c2fada52fdc4 (1 revision) (flutter/engine#50170)
https://skia.googlesource.com/skia.git/+log/7dc9ba2e8c90..c2fada52fdc4

2024-01-30 johnstiles@google.com Fix fuzzer-discovered timeout by caching fIsAllowedInES2.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jmbetancourt@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-30 15:23:55 +00:00
skia-flutter-autoroll
26afe28da7 Roll Skia from 1c0eae94fc09 to 7dc9ba2e8c90 (1 revision) (flutter/engine#50169)
https://skia.googlesource.com/skia.git/+log/1c0eae94fc09..7dc9ba2e8c90

2024-01-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 9946e44cc7dd to e4d0bd2c607d (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jmbetancourt@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-30 10:43:22 +00:00
skia-flutter-autoroll
fe3a2a54be Roll Skia from 4e992fb3a9db to 1c0eae94fc09 (3 revisions) (flutter/engine#50167)
https://skia.googlesource.com/skia.git/+log/4e992fb3a9db..1c0eae94fc09

2024-01-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 0ea24ef2eb6d to 5c2fc02b8dd5 (8 revisions)
2024-01-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 35e2efb89c92 to d321e24b76db
2024-01-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from f2e1e7139942 to 35e2efb89c92 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jmbetancourt@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-30 10:03:29 +00:00
skia-flutter-autoroll
1de3c43d20 Roll Fuchsia Linux SDK from Hqi_x_A9lYsY58VSn... to Z-xFM2ILZJw22eU8q... (flutter/engine#50166)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-30 09:50:26 +00:00
Jonah Williams
6b613131d1 [Impeller] Add interface for submitting multiple command buffers at once. (flutter/engine#50139)
The Impeller Vulkan backend benefits from batching submission to the vk graphics queue. Managing this automatically is non-trivial and adds surprising/fragile thread based behavior, see: https://github.com/flutter/engine/pull/49870

Instead, introduce an impeller::CommandQueue object that command buffers must be submitted to in lieu of CommandBuffer->Submit, which has been made private.

TLDR

old
```c++
buffer->Submit();
```

new
```c++
context.GetQueue()->Submit({buffer});
```

The Metal and GLES implementations internally just call the private CommandBuffer->Submit, though there may be future opportunities to simplify here. The Vulkan implementation is where the meat is.

Aiks takes advantage of this by storing all command buffers on the aiks context while rendering a frame, and then performing one submit in aiks_context render. I don't think this will introduce any thread safety problems, as we don't guarantee much about aiks context - nor do we use it in a multithreaded context as far as I know.

Other tasks such as image upload still just directly submit their command buffers via the queue.

Fixes https://github.com/flutter/flutter/issues/141123
2024-01-30 07:48:35 +00:00
dependabot[bot]
41d20895e1 Bump actions/upload-artifact from 4.1.0 to 4.3.0 (flutter/engine#50165)
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.1.0 to 4.3.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases">actions/upload-artifact's releases</a>.</em></p>
<blockquote>
<h2>v4.3.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Reorganize upload code in prep for merge logic &amp; add more tests by <a href="https://github.com/robherley"><code>@​robherley</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/504">actions/upload-artifact#504</a></li>
<li>Add sub-action to merge artifacts by <a href="https://github.com/robherley"><code>@​robherley</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/505">actions/upload-artifact#505</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/upload-artifact/compare/v4...v4.3.0">https://github.com/actions/upload-artifact/compare/v4...v4.3.0</a></p>
<h2>v4.2.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Ability to overwrite an Artifact by <a href="https://github.com/robherley"><code>@​robherley</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/501">actions/upload-artifact#501</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/upload-artifact/compare/v4...v4.2.0">https://github.com/actions/upload-artifact/compare/v4...v4.2.0</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="26f96dfa69"><code>26f96df</code></a> Merge pull request <a href="https://redirect.github.com/actions/upload-artifact/issues/505">#505</a> from actions/robherley/merge-artifacts</li>
<li><a href="530ed2c9b8"><code>530ed2c</code></a> use correct artifact name in test</li>
<li><a href="53ef6987b3"><code>53ef698</code></a> add additional integration test for merge all behavior</li>
<li><a href="90b0f8eed8"><code>90b0f8e</code></a> add workflow to test merging</li>
<li><a href="199a58f54f"><code>199a58f</code></a> more docs</li>
<li><a href="3f353f9d9e"><code>3f353f9</code></a> ncc</li>
<li><a href="997fffa355"><code>997fffa</code></a> add merge artifact sub-action</li>
<li><a href="52899c8c02"><code>52899c8</code></a> Merge pull request <a href="https://redirect.github.com/actions/upload-artifact/issues/504">#504</a> from actions/robherley/reorganize</li>
<li><a href="da58a3f7b2"><code>da58a3f</code></a> ncc</li>
<li><a href="1f64adb853"><code>1f64adb</code></a> fix import</li>
<li>Additional commits viewable in <a href="1eb3cb2b3e...26f96dfa69">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/upload-artifact&package-manager=github_actions&previous-version=4.1.0&new-version=4.3.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
2024-01-30 07:26:07 +00:00
skia-flutter-autoroll
aed3662b73 Roll Skia from 083c1a4d9767 to 4e992fb3a9db (1 revision) (flutter/engine#50164)
https://skia.googlesource.com/skia.git/+log/083c1a4d9767..4e992fb3a9db

2024-01-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 31a1592736e3 to 2c6332b39875 (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-30 05:23:18 +00:00
Michael Brase
c4608bbfd1 Use structured logging on Fuchsia (flutter/engine#49918)
This change migrates off of the old fuchsia logging apis to use the
structured logging apis. The initial FIDL connection is made during
global initialization (before main()) and the initial minimum log level
is queried from the system. Later on, once the main loop is initialized,
we setup an async task to listen for additional log interest changes
from the system. The advantage of doing this on the main loop is that we
avoid spawning an additional background thread in the process (the
legacy logging apis use the background thread approach).

One added benefit of this change is it reduces the size of the
dart/flutter runner far packages by about 250kb in release mode, because
libsyslog.so and libbackend_fuchsia_globals.so are no longer needed.

flutter/flutter#141924

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-01-29 22:26:47 -06:00
Michael Brase
5a727d93d3 Fix incorrect FML_VLOG() severity usage (flutter/engine#50118)
The FML_VLOG() macros are designed to use a positive integers, since
they pass -severity to the LogMessage constructor. The negative severity
can also cause some surprising behavior with log filtering. This change
update usages of FML_VLOG(-1) to FML_VLOG(1).

flutter/flutter#141924
2024-01-29 22:23:07 -06:00
skia-flutter-autoroll
bd50e00c69 Roll Skia from 09379d00b455 to 083c1a4d9767 (1 revision) (flutter/engine#50162)
https://skia.googlesource.com/skia.git/+log/09379d00b455..083c1a4d9767

2024-01-30 michaelludwig@google.com [graphite] Reduce DrawList::kRenderSteps to 4096

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-30 02:09:25 +00:00
Matan Lurey
2c36f428af Revert: "Change how OpenGL textures are flipped in the Android embedder" (flutter/engine#50158)
Reverts #49938.

This broke `packages/packages/camera/camera/example`, and unfortunately
there is no test (in engine, framework, or packages) that would have
caught this. We also suspect (but are not sure) that this is related to
an internal customer reported bug as well (b/322750489).

---

Here is the output _pre_-revert:


![image](https://github.com/flutter/engine/assets/168174/0691feec-67a9-45b1-aa8e-1c692d09430b)

Here is the output _post_-revert:


![image](https://github.com/flutter/engine/assets/168174/016dc79a-1e44-48cf-9ba0-a61397f8e637)
2024-01-29 16:53:05 -08:00
John McCutchan
028c80cee5 Re-Re-land Manually revert TLHC optimizations (flutter/engine#50155)
- ImageReaderSurfaceProducer no longer drops frames when the producer and the consumers are up to two frames out of sync.
- Have the native C++ side of the Android external textures check if a new frame has been pushed and that the texture needs to be updated. This avoids having to schedule a task on the raster thread for each updated texture.
- Notify the engine earlier that a frame is needed when updating a TLHC texture.
- Re-land fix: Don't close the last dequeued from image reader until the dequeued image is no longer used.
2024-01-30 00:51:10 +00:00
John O'Neil
300d17912b Enable _Float16 "half-float" Functionality Only When Available. (flutter/engine#49851)
# Description:

We're cross-compiling impeller for Android, but x86 Android targets don't  have half float (`_Float16`) _ support. This change disables half float support in `impeller/geometry/half.h` for platforms where the `_Float16` builtin is lacking.

As can be seen in `half.h`, `Float16` support is enabled for all non-windows platforms, which doesn't not allow our use case.

# Issues

I can't seem to find a way to file an issue describing this, but

- [] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-01-29 23:53:10 +00:00
skia-flutter-autoroll
100acb28ef Roll Skia from c1899b2586da to 09379d00b455 (3 revisions) (flutter/engine#50156)
https://skia.googlesource.com/skia.git/+log/c1899b2586da..09379d00b455

2024-01-29 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll ANGLE from 2f4f3dcfb8ca to 0ea24ef2eb6d (5 revisions)
2024-01-29 kjlubick@google.com Remove legacy slug deserialize behavior
2024-01-29 mike@reedtribe.org move ScalerContextBits into subclass that needs it

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-29 23:43:03 +00:00
skia-flutter-autoroll
3b98e62178 Roll Skia from 0327d5b319fc to c1899b2586da (3 revisions) (flutter/engine#50152)
https://skia.googlesource.com/skia.git/+log/0327d5b319fc..c1899b2586da

2024-01-29 brianosman@google.com Remove SK_FORCE_AAA from build scripts - the flag no longer exists
2024-01-29 michaelludwig@google.com Match canvas2d sweep angle calculations in MotionMark slide, consolidate functions
2024-01-29 sky@chromium.org SkPath: special case adding path to empty path

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-29 22:34:23 +00:00