DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
85,274 Commits 882 Branches 1,069 Tags
Commit Graph

85274 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
engine-flutter-autoroll
c3279caa12
Roll Skia from 00765f238077 to da5a6704f8a3 (1 revision) (#172966) 
https://skia.googlesource.com/skia.git/+log/00765f238077..da5a6704f8a3

2025-07-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from c98f4a016f37 to b64ff232d6ed (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
aaclarke@google.com,jmbetancourt@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-07-30 12:39:40 +00:00
engine-flutter-autoroll
c9b1fa8bb9
Roll Skia from 62476cd444d2 to 00765f238077 (3 revisions) (#172955) 
https://skia.googlesource.com/skia.git/+log/62476cd444d2..00765f238077

2025-07-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from c8209fec9a5f to e286ef784996 (19 revisions)
2025-07-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 4bd5bd8d51e4 to 7cd1022cdc50 (1 revision)
2025-07-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 4695e6b7d184 to baf909de57f0 (14 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
aaclarke@google.com,jmbetancourt@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-07-30 10:10:30 +00:00
engine-flutter-autoroll
1ffcede0f2
Roll Skia from 34693354289f to 62476cd444d2 (1 revision) (#172950) 
https://skia.googlesource.com/skia.git/+log/34693354289f..62476cd444d2

2025-07-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from fcda4f3d4b8c to 87ae884a3c56 (19 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
aaclarke@google.com,jmbetancourt@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-07-30 07:16:35 +00:00
engine-flutter-autoroll
c372faadf5
Roll Skia from f72bd01a49b1 to 34693354289f (1 revision) (#172946) 
https://skia.googlesource.com/skia.git/+log/f72bd01a49b1..34693354289f

2025-07-30
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
aaclarke@google.com,jmbetancourt@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-07-30 04:58:28 +00:00
Yegor
2c5957a4f6
[a11y] add RangeSlider to a11y test app as additional use-case (#172922) 
Add `RangeSlider` as an additional use-case to the a11y_assessments app.
As part of that this PR adds a `Switch` to the app bar of the app to
reveal the additional use-cases. Each use-case is annotated to be either
a `core` or `additional` using a new `enum`, which is also introduced in
this PR.
 2025-07-30 03:13:21 +00:00
engine-flutter-autoroll
1cf0494e69
Roll Skia from a42898e5d622 to f72bd01a49b1 (21 revisions) (#172944) 
https://skia.googlesource.com/skia.git/+log/a42898e5d622..f72bd01a49b1

2025-07-30 nicolettep@google.com Revert "[graphite] Add
AHARDWAREBUFFER_FORMAT_B8G8R8A8_UNORM support"
2025-07-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 03166deacb9d to c98f4a016f37 (6 revisions)
2025-07-29 michaelludwig@google.com [graphite] Preserve rounded corners
for stroke bounds in ClipStack
2025-07-29 kjlubick@google.com Fix RustPNG build
2025-07-29 kjlubick@google.com Update -base versions of
shaders/skottie/fiddler/debugger
2025-07-29 michaelludwig@google.com [graphite] Optimize drawDRRect and
nested rect contours
2025-07-29 nicolettep@google.com [graphite] Add
AHARDWAREBUFFER_FORMAT_B8G8R8A8_UNORM support
2025-07-29 bungeman@google.com Remove unused
SkTypeface_AndroidSystem::fAxes
2025-07-29 fmalita@google.com [videodecoder] Forward-declare
GrRecordingContext
2025-07-29 kjlubick@google.com Update pinned jsfiddle-base
2025-07-29 mike@reedtribe.org Add RRect to raw-shapes
2025-07-29 mike@reedtribe.org Use optional for PathRef queries
2025-07-29 michaelludwig@google.com Fix cusp detection for linear cubics
in FindCubicConvex180Chops
2025-07-29 kjlubick@google.com Temporarily remove RustPNG from CQ
2025-07-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from aef5b0045b59 to 03166deacb9d (8 revisions)
2025-07-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 2fa5446206bd to fcda4f3d4b8c (12 revisions)
2025-07-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 8802b4ec130b to 4bd5bd8d51e4 (1 revision)
2025-07-29
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-07-29
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-07-29
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-07-28 ccameron@chromium.org identify_transfer_fn: Return C string
for PQ and HLG

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
aaclarke@google.com,jmbetancourt@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-07-30 02:47:29 +00:00
Bruno Leroux
c825031ba2
Fix SegmentedButton border doesn't reflect states (#172754) 
## Description

This PR fixes `SegmentedButton` border side not depending on the current
state.

It's based on one @TahaTesser 's great PR: see
https://github.com/flutter/flutter/pull/161942. 🙏
I updated some logic related to disabled border which led to Taha’s PR
failing internal Google tests.
I also added a test to verify the disabled border.

<details><summary>Code sample for screenshots</summary>

```dart
import 'package:flutter/material.dart';

void main() {
  runApp(const SegmentedButtonApp());
}

enum Calendar { day, week, month, year }

class SegmentedButtonApp extends StatefulWidget {
  const SegmentedButtonApp({super.key});

  @override
  State<SegmentedButtonApp> createState() => _SegmentedButtonAppState();
}

class _SegmentedButtonAppState extends State<SegmentedButtonApp> {
  Calendar? calendarView;

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData(
        segmentedButtonTheme: SegmentedButtonThemeData(
          style: ButtonStyle(
            side: WidgetStateProperty.fromMap(<WidgetStatesConstraint, BorderSide?>{
              WidgetState.disabled: const BorderSide(color: Colors.grey, width: 2),
              WidgetState.selected & WidgetState.hovered: const BorderSide(
                color: Colors.blue,
                width: 2,
              ),
              WidgetState.selected & WidgetState.focused: const BorderSide(
                color: Colors.pinkAccent,
                width: 2,
              ),
              WidgetState.hovered: const BorderSide(color: Colors.green, width: 2),
              WidgetState.focused: const BorderSide(color: Colors.purple, width: 2),
              WidgetState.any: const BorderSide(color: Colors.amber, width: 2),
            }),
          ),
        ),
      ),
      home: Scaffold(
        body: Center(
          child: SegmentedButton<Calendar>(
            segments: const <ButtonSegment<Calendar>>[
              ButtonSegment<Calendar>(
                value: Calendar.day,
                label: Text('Day'),
                icon: Icon(Icons.calendar_view_day),
                enabled: false,
              ),
              ButtonSegment<Calendar>(
                value: Calendar.week,
                label: Text('Week'),
                icon: Icon(Icons.calendar_view_week),
              ),
              ButtonSegment<Calendar>(
                value: Calendar.month,
                label: Text('Month'),
                icon: Icon(Icons.calendar_view_month),
              ),
              ButtonSegment<Calendar>(
                value: Calendar.year,
                label: Text('Year'),
                icon: Icon(Icons.calendar_today),
              ),
            ],
            selected: <Calendar>{?calendarView},
            emptySelectionAllowed: true,
            onSelectionChanged: (Set<Calendar> newSelection) {
              setState(() {
                calendarView = newSelection.isEmpty ? null : newSelection.first;
              });
            },
          ),
        ),
        floatingActionButton: FloatingActionButton(onPressed: () {}, child: const Icon(Icons.add)),
      ),
    );
  }
}

``` 

</details> 

# Before


https://github.com/user-attachments/assets/1581f431-f87a-4af3-8ef6-f1f0d170e54a


# After


https://github.com/user-attachments/assets/156a8a64-3d9f-4323-9a1d-60624f5ac5d4


## Related Issue

Fixes [SegmentedButton does not set its MaterialState for side
](https://github.com/flutter/flutter/issues/159884)

## Tests

Adds 2 tests.
 2025-07-29 23:53:22 +00:00
Robert Ancell
636b3c70f8
Fix documentation for FlutterEngineRunTask (#172889) 
The engine provides the tasks to the embedder, which then runs them
using FlutterEngineRunTask. The existing docs suggest the tasks are
given to the engine (i.e. are sourced in the embedder).
 2025-07-29 23:39:33 +00:00
engine-flutter-autoroll
4a798c0a4f
Roll Fuchsia Linux SDK from tK_PAaLeo0pUxi8hv... to bQVQlLssTxxLjoDU0... (#172925) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC aaclarke@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-07-29 22:03:27 +00:00
Alex Talebi
a5934ee348
fix(scrollbar): Update padding type to EdgeInsetsGeometry (#172056) 
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

This PR enhances RTL support for the RawScrollbar widget by updating its
padding type and adding comprehensive tests.

The changes include:
1. Updating RawScrollbar's `padding` parameter from `EdgeInsets` to
`EdgeInsetsGeometry`
- This change is non-breaking because `EdgeInsets` is a subclass of
`EdgeInsetsGeometry`
   - Existing code using `EdgeInsets` will continue to work as before
- Users can now optionally use `EdgeInsetsDirectional` for RTL support
2. Adding a test case that verifies scrollbar positioning with
EdgeInsetsDirectional padding
3. Testing both overscroll and regular scroll scenarios with directional
padding

These changes ensure that the scrollbar works correctly in both LTR and
RTL layouts, improving accessibility and internationalization support.

Fixes: #167922

## Pre-launch Checklist

- [x] I read the [Contributor
Guide](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview)
and followed the process outlined there for submitting PRs.
- [x] I read the [Tree
Hygiene](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md)
wiki page, which explains my responsibilities.
- [x] I read and followed the [Flutter Style
Guide](https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md),
including [Features we expect every widget to
implement](https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement).
- [x] I signed the [CLA](https://cla.developers.google.com/).
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on
[Discord](https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md).

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-07-29 20:51:22 +00:00
Gray Mackall
5f9b9ab498
Refactor Android platform view code in advance of enabling HCPP on existing PV widgets (behind a flag) (#170553) 
Should introduce no behavior changes. Refactors the android platform
view code so that
1. The delegator is ready to delegate between PlatformViewsController
(PVC) 1 and 2, and implements a
`PlatformViewsChannel.PlatformViewsHandler`.
2. The `PlatformViewCreationRequest` and `PlatformViewTouch` are fully
shared between the two platform view modes
3. Introduces new factory constructors for the different types of
`PlatformViewCreationRequest`s, corresponding to the modes.

Making the flag work on existing widgets will be done in a follow up PR
here
67262d9240/engine/src/flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/PlatformViewsChannel.java (L95).


## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Gray Mackall <mackall@google.com>
Co-authored-by: Reid Baker <1063596+reidbaker@users.noreply.github.com>
 2025-07-29 20:49:12 +00:00
engine-flutter-autoroll
26917f5216
Roll Packages from 6b2e34edba3c to ed235d11b7fd (4 revisions) (#172905) 
6b2e34edba...ed235d11b7

2025-07-29 engine-flutter-autoroll@skia.org Roll Flutter from
cfbaa18bdecc to 46b097a3070d (12 revisions) (flutter/packages#9695)
2025-07-29 robert.odrowaz@leancode.pl [camera_avfoundation]
Implementation swift migration - part 10 (flutter/packages#9664)
2025-07-29 10687576+bparrishMines@users.noreply.github.com
[interactive_media_ads] Adds remaining methods for internal wrapper of
the native `AdsRequest` (flutter/packages#9663)
2025-07-28 43054281+camsim99@users.noreply.github.com
[camera_android_camerax] Delete unused file (flutter/packages#9634)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-07-29 20:08:10 +00:00
stuartmorgan-g
2329a6c98c
Add package PR triage note (#172898) 
Add an explanation of the flutter/packages platform PR triage system, as
it isn't documented anywhere.
 2025-07-29 20:02:13 +00:00
gaaclarke
963218189b
Roll Skia from 409e1c7ba09b to a42898e5d622 (29 revisions) (#172906) 
manual land of https://github.com/flutter/flutter/pull/172881

https://skia.googlesource.com/skia.git/+log/409e1c7ba09b..a42898e5d622

2025-07-28
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial). 2025-07-28 michaelludwig@google.com
Revert "[graphite] Add option to avoid clear load op conversion"
2025-07-28 mike@reedtribe.org Defer drawOval to SkDraw 2025-07-28
mike@reedtribe.org Factor out rrect deducer, so it can be used outside
of pathref 2025-07-28
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial). 2025-07-28 mike@reedtribe.org
Refactor IsRectContour for other clients 2025-07-28 mike@reedtribe.org
Share code from PathRawShapes 2025-07-28 drott@chromium.org [Fontations]
Roll Fontations 2025-07-28 robertphillips@google.com [graphite] Fix
thread race in Dawn backend 2025-07-28
skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from
dfe81c21c267 to aef5b0045b59 (1 revision) 2025-07-28
skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from
d38531e82fd8 to c8209fec9a5f (6 revisions) 2025-07-28
skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from
a84d1801cf7b to 8802b4ec130b (1 revision) 2025-07-28
skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from
8aa65434c8ed to 4695e6b7d184 (7 revisions) 2025-07-28
skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from
3d2423f23524 to 2fa5446206bd (15 revisions) 2025-07-27
skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP
version 2025-07-27 skia-autoroll@skia-public.iam.gserviceaccount.com
Roll vulkan-deps from 1e5f8fd67984 to dfe81c21c267 (1 revision)
2025-07-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from f4b5d4a14233 to 1e5f8fd67984 (1 revision) 2025-07-26
skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from
75a29db5e706 to f4b5d4a14233 (3 revisions) 2025-07-25
ccameron@chromium.org HDR v2: Make more paths robust to new version
2025-07-25 robertphillips@google.com [graphite] Fix bug(s) in
PipelineKey serialization 2025-07-25
skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from
b16be89ea18d to 75a29db5e706 (3 revisions) 2025-07-25 mike@reedtribe.org
Reapply "Add defaults for path enums, declare as 8-bit" 2025-07-25
mike@reedtribe.org Update Matrix PolyToPoly to take spans 2025-07-25
michaelludwig@google.com Stick to 1/2 scale for final blur decimation
step 2025-07-25 kjlubick@google.com Remove old docker images related to
fiddler 2025-07-25 mike@reedtribe.org skscan to take pathraw 2025-07-25
skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from
f94510ab8d9e to d38531e82fd8 (13 revisions) 2025-07-25
skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from
2fdfa81e82dc to 8aa65434c8ed (8 revisions) 2025-07-25
skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from
b6b32cb6d1a1 to 3d2423f23524 (14 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jmbetancourt@google.com,jsimmons@google.com,kjlubick@google.com on the
revert to ensure that a human is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
 2025-07-29 20:02:04 +00:00
gaaclarke
ea378cfb6b
Made android_gradle_print_build_variants_test.dart more robust (#172910) 
issue: https://github.com/flutter/flutter/issues/172908

It's uncertain if this will fix the issue since we don't know why the
old matcher failed. This may fix it, or it may just give us more
information to debug with.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-07-29 19:33:37 +00:00
auto-submit[bot]
b5b5897342
Reverts "Reland licenses cpp switch (#172671)" (#172912) 
<!-- start_original_pr_link -->
Reverts: flutter/flutter#172671
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: gaaclarke
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: integration problems with google roller
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: gaaclarke
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {matanlurey, jtmcdole}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
changes since last land:
1) Now the license checker can trim matched licenses to remove regions
that aren't apropos
1) There is a `.autoroller-preupload.sh` script that should update the
LICENSE file when the autoroller executes

relies on:
- https://github.com/flutter/flutter/pull/172655
- https://skia-review.googlesource.com/c/buildbot/+/1025936

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
 2025-07-29 18:25:26 +00:00
Jenn Magder
30ae030c62
Fix Gemini Code Assist for GitHub config yaml (#172887) 
Gemini Code Assist for GitHub config seems incorrect, though the comment
doesn't tell us what's wrong.

https://github.com/flutter/flutter/pull/172886#issuecomment-3130134128

<img width="814" height="111" alt="Screenshot 2025-07-28 at 4 45 41 PM"
src="https://github.com/user-attachments/assets/6763a74b-3b14-4ef0-8234-4eaa70a72358"
/>


Speculating the yaml doesn't like the `**`.

Introduced in https://github.com/flutter/flutter/pull/172785

---------

Co-authored-by: John "codefu" McDole <john@mcdole.org>
Co-authored-by: Parker Lougheed <parlough@gmail.com>
Co-authored-by: John "codefu" McDole <codefu@google.com>
 2025-07-29 16:02:08 +00:00
Flutter GitHub Bot
915c7bcd04
Marks Linux_android_emu_unstable android_defines_test to be unflaky (#171856) 
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_android_emu_unstable android_defines_test"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_android_emu_unstable%20android_defines_test%22).
This test can be marked as unflaky.

Co-authored-by: Ben Konyi <bkonyi@google.com>
 2025-07-29 15:58:12 +00:00
auto-submit[bot]
46b097a307
Reverts "Manual roll of Dart from 5ede85aff798 to 14ea8d342149 (#172783)" (#172900) 
<!-- start_original_pr_link -->
Reverts: flutter/flutter#172783
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jtmcdole
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Failing in post submit tests:

```
╔═╡ERROR #1╞════════════════════════════════════════════════════════════════════
║ UNEXPECTED ERROR!
║ Exception: Found unexpected binary in cache: /Volumes/Work/s/w/ir/x/w/flutter/bin/cache/dart-sdk/bin/dartvm
║ #0      verifyExist (file:///Volumes/Work/s/w/ir/x/w/flutter/dev/bots/suite_runners/run_verify_binaries_codesigned_tests.dart:198:9)
║ <asynchron
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: a-siva
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {jason-simmons}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
https://dart.googlesource.com/sdk.git/+log/5ede85aff798..14ea8d342149

https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-36.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-35.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-34.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-33.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-32.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-31.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-30.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-29.0.dev
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
 2025-07-29 14:51:48 +00:00
Siva
9ceb7614fa
Manual roll of Dart from 5ede85aff798 to 14ea8d342149 (#172783) 
https://dart.googlesource.com/sdk.git/+log/5ede85aff798..14ea8d342149

https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-36.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-35.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-34.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-33.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-32.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-31.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-30.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-29.0.dev
 2025-07-29 00:49:09 +00:00
Lau Ching Jun
7832d840b6
Revert "Remove 2023 deprecated 'platforms' key from daemon output (#172593)" (#172883) 
This reverts commit cfe6f3d95b3fb1ccf2cf944eab0273efc944bcf3.

The change broke the vscode extension. The extension has been updated in
https://github.com/Dart-Code/Dart-Code/pull/5610 but it is worth keeping
this for a little while longer.
 2025-07-29 00:47:32 +00:00
Jim Graham
9e82be4b15
Migrate Embedder code to impeller/DL geometry classes (#172804) 
Ticks off another checkbox in
https://github.com/flutter/flutter/issues/161456
 2025-07-29 00:21:10 +00:00
Brandon DeRosier
831a7a179d
[Flutter GPU] Fix Android/GLES crashers. (#172588) 
Continuation of https://github.com/flutter/flutter/pull/165630.

Resolves https://github.com/flutter/flutter/issues/164278.
Resolves https://github.com/bdero/flutter_scene/issues/35.
Partly fixes: https://github.com/flutter/flutter/issues/160948.

* Fixes OpenGLES crashers.
  * Threadsafe GLES pipeline creation.
  * Threadsafe GLES texture creation.
  * Fix GLES internal float texture formats.
  * Encode GLES passes on the raster thread.
  * Overwrite GLES textures on the raster thread.
* Fixes vulkan memory leak
(https://github.com/flutter/flutter/issues/164278).
 2025-07-28 21:16:15 +00:00
engine-flutter-autoroll
24fc562d82
Roll Packages from 963550c6c297 to 6b2e34edba3c (7 revisions) (#172869) 
963550c6c2...6b2e34edba

2025-07-28 10687576+bparrishMines@users.noreply.github.com
[interactive_media_ads] Adds support to set general SDK settings
(flutter/packages#9648)
2025-07-28 engine-flutter-autoroll@skia.org Roll Flutter from
20788c07fcb8 to cfbaa18bdecc (43 revisions) (flutter/packages#9688)
2025-07-25 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
d7b523b356d1 to edada7c56edf (7 revisions) (flutter/packages#9677)
2025-07-25 jessiewong401@gmail.com Resolve `android_build_all_packages`
Warnings (flutter/packages#9643)
2025-07-25 stuartmorgan@google.com [video_player] Move Android to
per-player-instance Pigeon APIs (flutter/packages#9511)
2025-07-24 stuartmorgan@google.com [ci] Re-enable wasm and Windows ARM64
tests (flutter/packages#9667)
2025-07-24 engine-flutter-autoroll@skia.org Roll Flutter from
afba7d75b391 to 20788c07fcb8 (27 revisions) (flutter/packages#9670)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-07-28 21:08:20 +00:00
gaaclarke
7063ea19c4
Reland licenses cpp switch (#172671) 
changes since last land:
1) Now the license checker can trim matched licenses to remove regions
that aren't apropos
1) There is a `.autoroller-preupload.sh` script that should update the
LICENSE file when the autoroller executes

relies on:
- https://github.com/flutter/flutter/pull/172655
- https://skia-review.googlesource.com/c/buildbot/+/1025936

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-07-28 21:07:33 +00:00
auto-submit[bot]
4d060aeb34
Reverts "[flutter_tools] Add --no-codesign support for macOS build (#169034)" (#172878) 
<!-- start_original_pr_link -->
Reverts: flutter/flutter#169034
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: vashworth
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: failing in post-submit
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8708074284638575793/+/u/run_test.dart_for_analyze_shard_and_subshard_None/stdout
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: knopp
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {bkonyi, vashworth}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
Unlike iOS, the macOS build currently does not support `--no-codesign`
option to skip signing of application bundle. Having this option is
useful for situation where the code-signing step is happens separately
after the bundle is built (i.e. on CI).

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
 2025-07-28 20:07:47 +00:00
Matej Knopp
3ac59c9859
[flutter_tools] Add --no-codesign support for macOS build (#169034) 
Unlike iOS, the macOS build currently does not support `--no-codesign`
option to skip signing of application bundle. Having this option is
useful for situation where the code-signing step is happens separately
after the bundle is built (i.e. on CI).

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Victoria Ashworth <15619084+vashworth@users.noreply.github.com>
 2025-07-28 18:13:12 +00:00
stuartmorgan-g
3c9b1280a7
Add --config-only build option for Linux and Windows (#172239) 
Adds a `--config-only` option for Linux and Windows, which generates the
native build files (ninja and Visual Studio respectively) without
actually doing the build. This brings them into alignment with Android,
iOS, and macOS, which already have this flag, and will allow some
workflow improvements when running native plugin tests in environments
like the flutter/packages CI.

Fixes https://github.com/flutter/flutter/issues/93407
Fixes https://github.com/flutter/flutter/issues/172029

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
 2025-07-28 18:05:24 +00:00
Jenn Magder
b2cc192a31
Add Gemini Code Assist review config and style guide (#172785) 
- Initial config files for [Gemini Code Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
These config files are modified versions of the one already added to the
flutter/packages repo: https://github.com/flutter/packages/pull/9632
based on [the official
docs](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
- Style guide has links to various contributing docs and style guides.
- Ignore paths associated with version pins and third_party to avoid
reviews on rolls and code that doesn't need modification. See
https://github.com/flutter/packages/pull/9647.
- Add a note to the PR template to provide some notice/guidance to
contributors about how to use automated feedback, to clarify the role of
the automated reviews and hopefully minimize potential issues in case
the bot leaves incorrect feedback. This is a direct copy of the comment
introduced in https://github.com/flutter/packages/pull/9632.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-07-28 18:05:22 +00:00
hellohuanlin
053c8a55f1
[ios]update provisioning profile for 2025-2026 cert for chromium bots (#171021) 
This updates provisioning profile mainly for chromium bots. Some
devicelab tests also use this profile, according to
https://github.com/flutter/flutter/pull/155101.

*List which issues are fixed by this PR. You must list at least one
issue. An issue is not required if the PR fixes something trivial like a
typo.*

https://github.com/flutter/flutter/issues/168427


*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Co-authored-by: Victoria Ashworth <15619084+vashworth@users.noreply.github.com>
 2025-07-28 16:57:18 +00:00
René Kilczan
cfbaa18bde
Remove shortner (#172844) 
Replacing shortner urls with the long versions. Fixes #172843

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-07-28 15:07:11 +00:00
Matan Lurey
0125d95f7e
Update flutter pub get to use flutter.version.json (instead of version) (#172798) 
Towards https://github.com/flutter/flutter/issues/171900.

Discovered during https://github.com/flutter/flutter/pull/172793.

It's unfortunate that `DefaultPub` (and tests) need some massaging to
work, but the fact the tool is so inconsistent about global versus local
state is not a new thing, so I didn't worry about it in the context of
this PR.
 2025-07-28 14:17:38 +00:00
engine-flutter-autoroll
7de7baf2f1
Roll Fuchsia Linux SDK from i7RS-4iBtdndwa3Jy... to tK_PAaLeo0pUxi8hv... (#172827) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jsimmons@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-07-27 22:01:28 +00:00
engine-flutter-autoroll
b42ef81598
Roll Fuchsia Linux SDK from 4IewCwqcEm7r4QsXd... to i7RS-4iBtdndwa3Jy... (#172808) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jsimmons@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-07-26 15:30:58 +00:00
auto-submit[bot]
a9f310a4c9
Reverts "fix: get content hash for master on local engine branches (#172792)" (#172805) 
<!-- start_original_pr_link -->
Reverts: flutter/flutter#172792
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jtmcdole
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: almost, but not quite right. android builders
generate the wrong hash because they are on custom branches.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: jtmcdole
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {bdero, matanlurey}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
The content hash doesn't exist for local engine changes, except for on
CI. If we detect we're on a branch with committed or uncommitted changes
to engine files; use "master".

towards  #171790 

<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
 2025-07-26 03:58:26 +00:00
John "codefu" McDole
ba5aa78be5
fix: build size_exp artifacts in post (#172802) 2025-07-26 01:41:16 +00:00
John "codefu" McDole
e2d591cf88
fix: get content hash for master on local engine branches (#172792) 
The content hash doesn't exist for local engine changes, except for on
CI. If we detect we're on a branch with committed or uncommitted changes
to engine files; use "master".

towards  #171790
 2025-07-26 00:35:26 +00:00
Matan Lurey
35ebc20b99
Update main/master repoExceptions analysis set (#172796) 
Some of the repos are no longer referenced, others have migrated.
 2025-07-25 22:48:15 +00:00
Matan Lurey
e5b78fe6e5
Remove deprecated --[no-]-disable-dds (#172791) 
Closes https://github.com/flutter/flutter/issues/150279.

Made a warning in https://github.com/flutter/flutter/pull/172595 and
cherry-picked into the next beta (will be stable) as
https://github.com/flutter/flutter/pull/172790.
 2025-07-25 22:10:55 +00:00
Matan Lurey
55269c5fb5
last_engine_commit.ps1: Use $flutterRoot instead of $gitTopLevel (#172786) 
Closes https://github.com/flutter/flutter/issues/172190.
 2025-07-25 21:46:14 +00:00
Matan Lurey
ca7c95ceec
Check file contents, remove tests that are now invalid (: 'none') (#172788) 
Closes https://github.com/flutter/flutter/issues/171919.

The tests removed are covering cases no longer supported, but we never
caught them.
 2025-07-25 21:39:58 +00:00
Loïc PÉRON
c087fb36be
windows: allow pwsh.bat wrapper (#171778) 
After git clone flutter/flutter, flutter commands require the use of
powershell to run ps1 scripts. On my corporate workstation, I need to
use a pwsh.bat wrapper to run ps1 scripts.

This PR uses `pwsh` instead of `pwsh.exe` to find and use a bat wrapper
from the path if present.

Closes https://github.com/flutter/flutter/issues/171777.

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
 2025-07-25 21:36:21 +00:00
Brandon DeRosier
500684c142
[Impeller] Log glCheckFrameBufferStatus output when it fails in blit pass. (#172592) 
We haven't been able to reproduce
https://github.com/flutter/flutter/issues/169203. We should log the
error so that future repros are more useful.

We've already started doing this for other usages
(https://github.com/flutter/engine/pull/46692).
 2025-07-25 21:00:22 +00:00
Matan Lurey
0e7da1d019
Remove deprecated AssetManifest.json file (#172594) 
Closes https://github.com/flutter/flutter/issues/143577.
 2025-07-25 20:20:34 +00:00
Matan Lurey
476d998c56
Refactor verifyVersion into typed Version object, use it (#172780) 
Towards https://github.com/flutter/flutter/issues/171900.
 2025-07-25 19:25:54 +00:00
Justin McCandless
e97f612a35
Bump the customer tests to pick up an update to Zulip's tests, for th… (#172733) 
For https://github.com/flutter/flutter/pull/165832, picks up the test
change from https://github.com/zulip/zulip-flutter/pull/1741 that was
bumped in the `tests` repo in https://github.com/flutter/tests/pull/464.
 2025-07-25 19:24:19 +00:00
Matan Lurey
3e86cb8773
Rename AppRunLogger, stop writing status messages that break JSON (#172591) 
Closes https://github.com/flutter/flutter/issues/118907.

It looks like some of the work around splitting had already happened
(`DaemonLogger`), so this ... seems right?
 2025-07-25 19:14:01 +00:00
Matan Lurey
465b21cee1
Add --dart-define, -D to assemble, deprecate --define, -d. (#172510) 
Closes https://github.com/flutter/flutter/issues/98593.
Towards https://github.com/flutter/flutter/issues/97505.
 2025-07-25 18:55:01 +00:00
Renzo Olivares
0abc2ec292
Fix previous text input connection interrupts enter/space (#171973) 
Fixes an issue where a previously closed text input connection may cause
interference with hardware keyboard on Samsung devices.

On the Samsung Galaxy S10 Tab the Samsung IME will request the operating
system to show the IME when pressing enter/space on components like a
radio option or a checkbox if there was a previously opened text input
connection. It seems the Samsung Keyboard is caching some text input
related state, and when it detects an enter/space key it acts on this
previously cached state even if the text input connection has been
closed. This prevents the radio option/checkbox and framework as a whole
from responding to the key events. To solve this issue we should reset
the input method manager when the IME has been hidden, and when the
framework closes the input connection we should also reset the input
method manager if the IME is hidden at the time of closing. This
effectively resets any state cached by the Samsung keyboard and it no
longer acts on stale state.

Fixes https://github.com/flutter/flutter/issues/168099
Fixes https://github.com/flutter/flutter/issues/51478
Fixes https://github.com/flutter/flutter/issues/70546

Related:
https://github.com/flutter/flutter/issues/136745

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

---------

Co-authored-by: Renzo Olivares <roliv@google.com>
 2025-07-25 18:44:22 +00:00
Reid Baker
75b6c0f635
Update CHANGELOG.md for 3.32.8 (#172779) 
## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
 2025-07-25 18:40:15 +00:00