DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
85,867 Commits 882 Branches 1,069 Tags
Commit Graph

85867 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
engine-flutter-autoroll
c14a286a60
Roll Skia from 87ee27220133 to e1a200e25998 (4 revisions) (#175061) 
https://skia.googlesource.com/skia.git/+log/87ee27220133..e1a200e25998

2025-09-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from d0a341f6ee1b to 7e45e468cf42 (23 revisions)
2025-09-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
shaders-base from 0b85ebb8cd88 to a05e895e8ba2
2025-09-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
skottie-base from af8d227d9756 to 125a9ff87309
2025-09-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
debugger-app-base from 17223bbc481d to 8a197cae1e3d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brettos@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-09-08 12:55:21 +00:00
Ben Konyi
e4b7bdbe22
[ Widget Preview ] Improve --machine output (#175003) 
This change adds the following events:

- `widget_preview.initializing`: sent immediately after the widget
previewer starts. This event includes the PID of the process starting
the widget previewer for use by tooling to explicitly kill the tool
process.
- `widget_preview.logMessage`: sent for calls to `Logger` methods when
in machine mode. This follows the same format as `daemon.logMessage`.

This change also fixes and improves testing of
`WidgetPreviewMachineAwareLogger` in `widget_preview_machine_test.dart`
as the existing test validator did not cause tests to fail correctly.

Fixes https://github.com/flutter/flutter/issues/175002
 2025-09-08 12:37:39 +00:00
Bruno Leroux
6ae27959de
Fix DropdownMenuFormField does not clear text field content on reset … (#174937) 
## Description

This PR fixes `DropdownMenuFormField` not clearing the text field value
when the form is reset and DropdownMenuFormField.initialSelection is
null.

## Related Issue

Fixes [DropdownMenuFormField does not reset when calling
FormState.reset](https://github.com/flutter/flutter/issues/174578)

## Tests

Adds 2 tests.
 2025-09-08 12:09:10 +00:00
engine-flutter-autoroll
937f2b9ad4
Roll Skia from 310062ae6aee to 87ee27220133 (1 revision) (#175051) 
https://skia.googlesource.com/skia.git/+log/310062ae6aee..87ee27220133

2025-09-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
jsfiddle-base from c4343b58423e to e739450ff483

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brettos@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-09-08 06:55:37 +00:00
engine-flutter-autoroll
0439f0d8e2
Roll Dart SDK from 34cd2b4b56dd to c7518d480c73 (1 revision) (#175049) 
https://dart.googlesource.com/sdk.git/+log/34cd2b4b56dd..c7518d480c73

2025-09-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-180.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-09-08 06:09:28 +00:00
engine-flutter-autoroll
0081ee50dc
Roll Skia from b00ca433657b to 310062ae6aee (1 revision) (#175046) 
https://skia.googlesource.com/skia.git/+log/b00ca433657b..310062ae6aee

2025-09-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SKP
CIPD package from 532 to 533

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brettos@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-09-07 17:12:45 +00:00
engine-flutter-autoroll
06ab279c02
Roll Fuchsia Linux SDK from LRAtLJWUiZNmSVShG... to V_KooYFGRmGm6JrqM... (#175040) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC aaclarke@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-09-07 13:32:26 +00:00
engine-flutter-autoroll
d0ff5c76a8
Roll Skia from 064cf12ad0cc to b00ca433657b (1 revision) (#175028) 
https://skia.googlesource.com/skia.git/+log/064cf12ad0cc..b00ca433657b

2025-09-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 31fde841db1d to 6a661aa0f951 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,kjlubick@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-09-07 03:54:30 +00:00
engine-flutter-autoroll
ad3cd078d1
Roll Fuchsia Linux SDK from xG_uERsxHvUwFHpF2... to LRAtLJWUiZNmSVShG... (#175018) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC aaclarke@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-09-06 04:44:28 +00:00
engine-flutter-autoroll
920cead7df
Roll Dart SDK from f138e58bcf6d to 34cd2b4b56dd (2 revisions) (#175017) 
https://dart.googlesource.com/sdk.git/+log/f138e58bcf6d..34cd2b4b56dd

2025-09-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-179.0.dev
2025-09-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-178.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-09-06 03:38:26 +00:00
engine-flutter-autoroll
f56144f81f
Roll Skia from 5c60f8a66270 to 064cf12ad0cc (2 revisions) (#175015) 
https://skia.googlesource.com/skia.git/+log/5c60f8a66270..064cf12ad0cc

2025-09-05 bungeman@google.com Better bounds check idIndex in ImGuiLayer
2025-09-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 05f5847a3f30 to 31fde841db1d (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,kjlubick@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-09-06 00:59:27 +00:00
engine-flutter-autoroll
569ee71e35
Roll Skia from f29ea2795934 to 5c60f8a66270 (2 revisions) (#175010) 
https://skia.googlesource.com/skia.git/+log/f29ea2795934..5c60f8a66270

2025-09-05 bungeman@google.com Allow auto registration of
SkPngRustDecoder
2025-09-05
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,kjlubick@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-09-05 22:27:15 +00:00
manu-sncf
242043fca2
Fix SliverMainAxisGroup scrollOffsetCorrection (#174369) 
Fixes : [#174368](https://github.com/flutter/flutter/issues/174368)

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-09-05 21:15:21 +00:00
engine-flutter-autoroll
e7fab7edeb
Roll Skia from 759f406584da to f29ea2795934 (3 revisions) (#175000) 
https://skia.googlesource.com/skia.git/+log/759f406584da..f29ea2795934

2025-09-05 kjlubick@google.com Add cmake helper to task_builder
2025-09-05
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-09-05 mike@reedtribe.org GM to try out rect-vs-poly stroking

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,kjlubick@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-09-05 20:00:35 +00:00
engine-flutter-autoroll
75ad51d026
Roll Dart SDK from 5e3afb74ffdf to f138e58bcf6d (15 revisions) (#174994) 
https://dart.googlesource.com/sdk.git/+log/5e3afb74ffdf..f138e58bcf6d

2025-09-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-177.0.dev
2025-09-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-176.0.dev
2025-09-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-175.0.dev
2025-09-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-174.0.dev
2025-09-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-173.0.dev
2025-09-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-172.0.dev
2025-09-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-171.0.dev
2025-09-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-170.0.dev
2025-09-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-169.0.dev
2025-09-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-168.0.dev
2025-09-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-167.0.dev
2025-09-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-166.0.dev
2025-09-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-165.0.dev
2025-09-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-164.0.dev
2025-09-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-163.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-09-05 18:22:36 +00:00
engine-flutter-autoroll
145b73a3fc
Roll Packages from 98580c6c82fc to cab2ac2eb136 (2 revisions) (#174998) 
98580c6c82...cab2ac2eb1

2025-09-05 engine-flutter-autoroll@skia.org Roll Flutter from
6b18740d5a23 to 87d5b753196c (88 revisions) (flutter/packages#9962)
2025-09-04 6655696+guidezpl@users.noreply.github.com [google_fonts]
Improve CONTRIBUTING and generator README (flutter/packages#9917)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-09-05 17:56:30 +00:00
hellohuanlin
edbc5ca18e
[ios26]fix host engine compile error (#174723) 
## What it does

This adds `-plugin-path` flag to `swiftc` cmd to fix a compile error
related to missing swift plugin. The plugin is under
`mac_host_toolchain_path`, which is only available on macs. However, we
only build mac host engine on macs, so we are good.

## About unit test

This swiftc.py file currently has no test coverage, but it should - I
filed https://github.com/flutter/flutter/issues/174843. However, given
there's a big fire (https://github.com/flutter/flutter/issues/174513)
going on, and we are approaching iOS 26 release, I have to prioritize
that one.

I will manually verify the solution. 

*List which issues are fixed by this PR. You must list at least one
issue. An issue is not required if the PR fixes something trivial like a
typo.*

Fixes https://github.com/flutter/flutter/issues/172155


*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-09-05 17:45:08 +00:00
gaaclarke
135f367273
Added note about how to compile licenses_cpp (#174947) 
fixes https://github.com/flutter/flutter/issues/174942

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-09-05 17:26:10 +00:00
engine-flutter-autoroll
6675f1d01a
Roll Skia from 845ec125e94c to 759f406584da (3 revisions) (#174992) 
https://skia.googlesource.com/skia.git/+log/845ec125e94c..759f406584da

2025-09-05 kjlubick@google.com Add ninja to PATH in GN recipes
2025-09-05 kjlubick@google.com Update and create CMake asset for all
platforms
2025-09-05 kjlubick@google.com Remove CanvasKit_WebGPU job from CI/CQ

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,kjlubick@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-09-05 17:26:10 +00:00
Mouad Debbar
e6af6f9a0c
[web] Minor simplification in flutter.js loader (#174963) 2025-09-05 17:00:20 +00:00
gaaclarke
fd10d21948
deletes the old license checker. (#174719) 
This has been replaced by `//engine/src/flutter/tools/licenses_cpp`

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-09-05 16:59:27 +00:00
Ben Konyi
87d5b75319
[ Device Lab ] Add regression testing for flutter/flutter#174952 (#174956) 
Also switches to using a regex group to match the device state instead
of splitting the matched string on '='.

Fixes https://github.com/flutter/flutter/issues/174952

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
 2025-09-05 15:40:29 +00:00
engine-flutter-autoroll
dbc119c5f5
Roll Skia from 0ca53adfc6cc to 845ec125e94c (2 revisions) (#174978) 
https://skia.googlesource.com/skia.git/+log/0ca53adfc6cc..845ec125e94c

2025-09-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 0c650120dc77 to 05f5847a3f30 (5 revisions)
2025-09-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from a685b7a7df11 to d0a341f6ee1b (21 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,kjlubick@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-09-05 09:31:29 +00:00
Bruno Leroux
97a8e8303d
[a11y-app] Fix NavigationRail leading and trailing labels (#174861) 
## Description

This PR adds a11y labels for the heading and trailing buttons of the
NavigationRail use case (for the A11y assessments app).

## Related Issue

Part of [[VPAT][A11y][a11y-app] controls in a11y assessment missing
label](https://github.com/flutter/flutter/issues/173051)

## Tests

Adds 1 test.
 2025-09-05 05:40:29 +00:00
engine-flutter-autoroll
159b156156
Roll Skia from d7e99be07d5d to 0ca53adfc6cc (5 revisions) (#174972) 
https://skia.googlesource.com/skia.git/+log/d7e99be07d5d..0ca53adfc6cc

2025-09-04 lukasza@chromium.org [rust png] Prep for 0.18 update: remove
unused `output_buffer_size` API.
2025-09-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from bc2741a3b383 to 0c650120dc77 (5 revisions)
2025-09-04 borenet@google.com [infra] Use skp_min_version tag for
OldestSupportedSkpVersion task
2025-09-04 borenet@google.com [infra] Remove CL creation from
RecreateSKPs
2025-09-04 nscobie@google.com Revert "SkAndroidCodec: Remove one-off
CICP implementation"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,kjlubick@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-09-05 05:16:28 +00:00
engine-flutter-autoroll
279640b285
Roll Fuchsia Linux SDK from izfNA3o_2zL4Cjqmy... to xG_uERsxHvUwFHpF2... (#174970) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC aaclarke@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-09-05 02:20:33 +00:00
Bruno Leroux
c1ce4e530c
Fix IconButton.color overrided by IconButtomTheme (#174515) 
## Description

This PR fixes IconButton icon color resolution. 

## Before

The IconButton.color property does not take precedence over the ambient
`IconButtonTheme`

## After

The IconButton.color property overrides the ambient `IconButtonTheme`.

## Related Issue

Fixes [SnackBar closeIconColor does not respect widget
override](https://github.com/flutter/flutter/issues/174472)
Fixes [IconButton.color is overidden by
IconButtonTheme](https://github.com/flutter/flutter/issues/174511)

## Tests

Adds 1 test.
 2025-09-04 22:17:25 +00:00
Mouad Debbar
cc0b0471b9
[web] Reuse chrome instance to run all flutter tests (#174957) 
Web test shards take a significant time to run in CI compared to their
VM counterparts. One theory is that launching and shutting down Chrome
repeatedly is a major part of the slowness.

This PR makes `flutter test --platform=chrome` reuse the same Chrome
instance for all test files instead of launching a new one for each test
file.

At first glance, it may seem like we aren't shutting down Chrome
anymore, but we actually do in `closeEphemeral` and `close` methods.

Thanks @eyebrowsoffire for the idea!
 2025-09-04 21:27:24 +00:00
Pedro Massango
00e428a200
fix(Semantics): Ensure semantics properties take priority over button's (#174473) 
Fixes https://github.com/flutter/flutter/issues/157689

Flutter packages PR counterpart:
- https://github.com/flutter/packages/pull/9815



## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
 2025-09-04 21:05:27 +00:00
Victoria Ashworth
8a5c6df06f
Make every LLDB Init error message actionable (#174726) 
Fixes https://github.com/flutter/flutter/issues/172170.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-09-04 20:26:29 +00:00
Hannah Jin
5a89802d6d
Fix table cell semantics rect alignment issues. (#174914) 
fix: https://github.com/flutter/flutter/issues/171264 
should use cell rect bottom to compare with row height instead of using
cell rect top.


## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-09-04 20:20:44 +00:00
Kishan Rathore
8b6d1da851
Fix: Use route navigator for CupertinoSheetRoute pop (#173103) 
Use route navigator for CupertinoSheetRoute pop
Fixes: #172010 

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
 2025-09-04 19:09:09 +00:00
Ben Konyi
2965567997
[ Widget Preview] Add group property to Preview (#174849) 
This change adds support for creating groups of widget previews.
Previews with the same `group` parameter will be grouped together in a
collapsable tile in widget previewer. Previews without a provided
`group` will be placed in the `Default` group.

This change also slightly reworks the UI to make individual previews
more easily distinguishable from preview groups, moves the controls for
the previewer to the bottom of the preview window, and adds a divider
between the preview name and preview content if a name is provided.

Fixes https://github.com/flutter/flutter/issues/173871

**Example:**

<img width="767" height="640" alt="image"
src="https://github.com/user-attachments/assets/80dc202c-77d3-42a5-be9d-e0d9a9a0f28b"
/>
 2025-09-04 18:51:19 +00:00
chunhtai
ae3eb26237
Allow OverlayPortal.overlayChildLayoutBuilder to choose root Overlay (#174239) 
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

fixes https://github.com/flutter/flutter/issues/168785

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-09-04 18:27:19 +00:00
engine-flutter-autoroll
ad41861345
Roll Skia from 7c2f502e3304 to d7e99be07d5d (18 revisions) (#174936) 
https://skia.googlesource.com/skia.git/+log/7c2f502e3304..d7e99be07d5d

2025-09-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 875b7400b543 to 6888dfb1826d (6 revisions)
2025-09-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 468c8103a065 to a685b7a7df11 (17 revisions)
2025-09-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 8415cc875465 to bc2741a3b383 (5 revisions)
2025-09-03 vigneshv@google.com Remove SkHeifCodec and related defines
2025-09-03 ccameron@chromium.org SkAndroidCodec: Remove one-off CICP
implementation
2025-09-03 drott@chromium.org [Fontations] Roll Fontations
2025-09-03 bungeman@google.com Remove fontmgr_android_ndk from
Android.bp
2025-09-03 borenet@google.com [bazel] Add "gazelle" target to
bazel/Makefile
2025-09-03 bungeman@google.com Fix case compare in SkFontMgr_android_ndk
2025-09-03 syoussefi@google.com Simplify ComputeLevelCount calls
2025-09-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 0773b5e19b27 to 8415cc875465 (7 revisions)
2025-09-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from bb55ea10fcef to 875b7400b543 (10 revisions)
2025-09-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 0390a544a952 to 14f87286123a (1 revision)
2025-09-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 6bab1bd9fd23 to 468c8103a065 (14 revisions)
2025-09-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 507fe12d436d to 0773b5e19b27 (9 revisions)
2025-09-02 sharaks@google.com Merge 5 release notes into
RELEASE_NOTES.md
2025-09-02 sharaks@google.com Update Skia milestone to 142
2025-09-02
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,kjlubick@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-09-04 18:20:17 +00:00
Mouad Debbar
31aaf38a93
Remove 'terms of use' wording from web_unicode (#174939) 
This library isn't used anywhere and will be deleted here:
https://github.com/flutter/flutter/pull/174896

I'm removing the "terms of use" wording to unblock the G3 roll while I
investigate the failures on the full deletion PR.
 2025-09-04 18:16:51 +00:00
Ben Konyi
48b053aadb
[ Tool ] Remove leftover Android x86 deprecation warning constant (#174941) 
Android x86 support has already been removed.

Found during a post merge investigation of
https://github.com/flutter/flutter/issues/157543
 2025-09-04 18:15:18 +00:00
Victoria Ashworth
baf4de08b4
Prevent potential crash when accessing window in FlutterSceneDelegate (#174873) 
Accessing `appDelegate.window` may crash if the AppDelegate doesn't have
the window property. This can happen when using a custom
`UIApplicationDelegate` (and not the `FlutterAppDelegate`).

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-09-04 18:13:03 +00:00
engine-flutter-autoroll
096a794205
Roll Packages from 42bb34706103 to 98580c6c82fc (5 revisions) (#174943) 
42bb347061...98580c6c82

2025-09-04 stuartmorgan@google.com [mustache_template] Initial import
(flutter/packages#9944)
2025-09-04 69874219+WillBLogical@users.noreply.github.com
[google_maps_flutter_web] Omit styles when cloudMapId is set
(flutter/packages#9869)
2025-09-03 lukas.mirbt@hotmail.com [go_router_builder] Fix unnecessary
whitespace in generated `RelativeGoRouteData` (flutter/packages#9875)
2025-09-03 james@somethingwild.co.nz [google_maps_flutter_web] Stop
listening to map events when disposed (flutter/packages#9250)
2025-09-03 borisshishov@gmail.com [flutter_svg] loader buffer fix
(flutter/packages#9898)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-09-04 18:13:02 +00:00
Ben Konyi
850412cfee
[ Device Lab ] Fix wakefulness check to only match log entries with string values (#174953) 
Sometimes there can be multiple wakefulness log entries (e.g.,
'mWakefulness=Awake' and 'mWakefulness=1'), but we only care about the
entry with a string value.

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
 2025-09-04 17:03:37 +00:00
Bruno Leroux
6e9286d6eb
Fix expanded DropdownMenu panel is shorter than text field (#174443) 
## Description

This PR fixes DropdownMenu menu panel being shorter than the TextField
when it expands to full-screen width.

## Before

The menu panel is shorter than the text field:

<img width="297" height="130" alt="image"
src="https://github.com/user-attachments/assets/db42bd01-94d8-47fb-9331-ebd78111b931"
/>

## After

The menu panel expands as close as possible to the edge similarly to the
text field.

<img width="297" height="130" alt="image"
src="https://github.com/user-attachments/assets/b7d8f2aa-a668-439a-8195-9b9ce48dba6b"
/>


## Code sample

<details><summary>Code sample for recordings</summary>

```dart
import 'package:flutter/material.dart';

void main() {
  runApp(const DropdownMenuExample());
}

class DropdownMenuExample extends StatefulWidget {
  const DropdownMenuExample({super.key});

  @override
  State<DropdownMenuExample> createState() => _DropdownMenuExampleState();
}

class _DropdownMenuExampleState extends State<DropdownMenuExample> {
  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Scaffold(
        body: DropdownMenu<int>(
          expandedInsets: EdgeInsets.zero,
          dropdownMenuEntries: <DropdownMenuEntry<int>>[
            DropdownMenuEntry<int>(value: 0, label: 'Flutter'),
          ],
        ),
      ),
    );
  }
}


``` 
</details> 

## Implementation details

MenuAnchor automatically adds a default padding, see
2c21273bfd/packages/flutter/lib/src/material/menu_anchor.dart (L81-L82)

This PR add a property to menu anchor to expose the view padding.
DropdownMenu sets this padding to EdgeInsets.zero to opt-out from the
default 8 padding.


## Related Issue

Fixes [DropdownMenu children is shorter than the TextField when it
expands to full-screen
width](https://github.com/flutter/flutter/issues/172680)

## Tests

Adds 2 tests.

---------

Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>
 2025-09-04 06:35:20 +00:00
LongCatIsLooong
251f4a8d5b
Add a viewController property to the ios/macOS FlutterPluginRegistrar protocol (#174168) 
#104117

Adds a `viewController` (per
https://github.com/flutter/flutter/issues/104117#issuecomment-3114772381,
presumably because iOS plugins want to presenting new view controllers)
getter that makes the single-view assumption. ~This is a method instead
of a weak + readonly property like the macOS registrar protocol because
existing getters are also methods, e.g.,~
```objc
- (NSObject<FlutterBinaryMessenger>*)messenger;
- (NSObject<FlutterTextureRegistry>*)textures;
```

~Unfortunately swift callers will have to use a preprocess macro and add
different code paths for macOS and iOS.~

#### Single view assumption

I've considered adding a `- (nullable
UIViewController*)viewControllerForViewID: ViewIDType;` method but that
will force plugins to make breaking changes in order to migrate off of
the deprecated `keyWindow` property. Take the text input plugin as an
example, it has to add a `viewID` argument to the `setTextInputClient`
call when establishing a new text input connection, so the text input
plugin knows which view hierarchy to add the text input view to. It is
unclear to me whether more `FlutterPluginRegistrar` changes are needed
to completely get rid of the single-view assumption in the protocol (the
views `FlutterPlatformViewFactory` creates are always added as subviews
to `flutterView` so I guess that interface may have to change in the
future? According to according to [Flutter’s multi-window
status](https://docs.google.com/document/d/13E27tD8_9f6lDgwg3MpGNTV8XIRCZH3ByI-t9kI9IUM/edit?tab=t.0#heading=h.8lxwn1tiky70),
only a `viewForIdentifier` method will be added to registrar), so IMO it
would be a better experience to not introduce the `viewID` concept right
now and force plugins to make break changes, since they may have to make
more breaking changes in the future.

Alternatively, we could also ignore the `viewID` args for now and always
return the view controller of the implicit view in the implementation,
so that plugin authors can use made-up view IDs to get the implicit view
controller. But that's going to make future multiview migrations
difficult since the compiler won't be able to catch unmigrated code if
the plugin is using a bogus view ID.

##  Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-09-04 01:32:32 +00:00
engine-flutter-autoroll
fb4c6ab2dc
Roll Fuchsia Linux SDK from J3T_wZqL_57mRfWky... to izfNA3o_2zL4Cjqmy... (#174908) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC aaclarke@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-09-03 23:41:26 +00:00
chunhtai
f5ce9117ee
Wires up Android API to set section locale (#173364) 
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

related https://github.com/flutter/flutter/issues/99600

what still missing:
1. iOS equivalence
2. set application level locale 

internal only doc:
[go/flutter-semantics-language](http://goto.google.com/flutter-semantics-language)


## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-09-03 23:37:31 +00:00
Chinmay Garde
3a18c9449e
Delete impeller::SPrintF. (#174900) 
We have std::format at home.

This is superior for a few reasons. The caller doesn't have to remember
the format string for the type. I believe std::string_views that are not
null terminated are also handled correctly. Also, we don't have to
maintain and test our own SPrintF.
 2025-09-03 23:09:14 +00:00
Ahmed Mohamed Sameh
ff1aafde34
Make sure that a DropdownMenuFormField doesn't crash in 0x0 environment (#174777) 
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the
DropdownMenuFormField widget.
 2025-09-03 21:53:22 +00:00
Mouad Debbar
f372a6b9ed
Remove unnecessary presubmit_max_attempts from .ci.yaml (#174885) 
The original [issue](https://github.com/flutter/flutter/issues/132654)
was fixed 2 years ago: https://github.com/flutter/flutter/pull/135521.
There's no need to keep the `presubmit_max_attempts` workaround anymore.
 2025-09-03 21:35:54 +00:00
Mouad Debbar
e10d972367
Use local canvaskit in dart_data_asset_test.dart (#174891) 
Fixes https://github.com/flutter/flutter/issues/174884
 2025-09-03 20:31:14 +00:00
auto-submit[bot]
d438f2e527
Reverts "Mark Linux web_canvaskit_tests_7_last as bringup (#174878)" (#174897) 
<!-- start_original_pr_link -->
Reverts: flutter/flutter#174878
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: mdebbar
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: the issue was fixed by
https://github.com/flutter/flutter/pull/174881
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: mdebbar
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {jtmcdole}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
Unblocks tree while working on
https://github.com/flutter/flutter/issues/174877
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
 2025-09-03 19:35:49 +00:00
Victor Sanni
241f6e6649
Correct intrinsics calculation for CupertinoTextField with placeholder (#174889) 
Adds `computeMaxIntrinsicHeight` and `computeMinIntrinsicHeight` to
`_RenderBaselineAlignedStack`. This should have been added in
[Baseline-align CupertinoTextField
placeholder](https://github.com/flutter/flutter/pull/166952).

Fixes [CupertinoTextFormFieldRow with placeholder causes unnecessary
scrolling in
CupertinoAlertDialog](https://github.com/flutter/flutter/issues/174797)
Fixes [CupertinoAlertDialog actions obstructs CupertinoTextField content
with placeholder text](https://github.com/flutter/flutter/issues/174774)
 2025-09-03 19:10:18 +00:00