engine-flutter-autoroll
c09c65ff46
Roll Flutter Engine from 92ebd47dd8a8 to d872d50e53f4 (6 revisions) ( #145801 )
...
92ebd47dd8...d872d50e53skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from uu8lffXkeJQ9PC96I... to Lk8KBU-c97ROj-YHm... (flutter/engine#51690 )
2024-03-26 zanderso@users.noreply.github.com Turn off internal retries for Android scenario app tests (flutter/engine#51689 )
2024-03-26 skia-flutter-autoroll@skia.org Roll Skia from 1808016c7a6d to 23a5617e7f47 (1 revision) (flutter/engine#51688 )
2024-03-26 chris@bracken.jp [macOS] Consolidate FlutterViewController static types/data (flutter/engine#51486 )
2024-03-26 skia-flutter-autoroll@skia.org Roll Skia from 0590062821dc to 1808016c7a6d (3 revisions) (flutter/engine#51686 )
2024-03-26 jonahwilliams@google.com [iOS] remove arbitrary framerate cap. (flutter/engine#51663 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from uu8lffXkeJQ9 to Lk8KBU-c97RO
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-27 02:41:11 +00:00
godofredoc
1c8b378ffb
Update localization files. ( #145780 )
...
Update the localization files to be used in the upcoming stable release.
2024-03-27 02:33:05 +00:00
engine-flutter-autoroll
d07a0b56ef
Roll Flutter Engine from 026d8902e3b5 to 92ebd47dd8a8 (1 revision) ( #145788 )
...
026d8902e3...92ebd47dd8jonahwilliams@google.com [Impeller] use screen space coordinates for dithering. (flutter/engine#51668 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-27 01:53:30 +00:00
David Iglesias
9786682492
[web] Add BackgroundIsolateBinaryMessenger.ensureInitialized to web. ( #145786 )
...
This PR makes the static API of the `BackgroundIsolateBinaryMessenger` consistent between its web and IO implementations.
This way, multi-platform applications will compile for the web when using the `ensureInitialized` method (even though it'll throw at runtime, like the `instance` getter, because isolates are not supported on the web).
### Issues
* Fixes: https://github.com/flutter/flutter/issues/145260
2024-03-26 23:51:23 +00:00
dependabot[bot]
d2a193804b
Bump codecov/codecov-action from 4.1.0 to 4.1.1 ( #145787 )
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 4.1.0 to 4.1.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/codecov/codecov-action/releases ">codecov/codecov-action's releases</a>.</em></p>
<blockquote>
<h2>v4.1.1</h2>
<h2>What's Changed</h2>
<ul>
<li>build(deps): bump github/codeql-action from 3.24.5 to 3.24.6 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1315 ">codecov/codecov-action#1315</a></li>
<li>build(deps-dev): bump typescript from 5.3.3 to 5.4.2 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1319 ">codecov/codecov-action#1319</a></li>
<li>Removed mention of Mercurial by <a href="https://github.com/drazisil-codecov "><code>@âdrazisil-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1325 ">codecov/codecov-action#1325</a></li>
<li>build(deps): bump github/codeql-action from 3.24.6 to 3.24.7 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1332 ">codecov/codecov-action#1332</a></li>
<li>build(deps): bump actions/checkout from 4.1.1 to 4.1.2 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1331 ">codecov/codecov-action#1331</a></li>
<li>fix: force version by <a href="https://github.com/thomasrockhu-codecov "><code>@âthomasrockhu-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1329 ">codecov/codecov-action#1329</a></li>
<li>build(deps-dev): bump typescript from 5.4.2 to 5.4.3 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1334 ">codecov/codecov-action#1334</a></li>
<li>build(deps): bump undici from 5.28.2 to 5.28.3 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1338 ">codecov/codecov-action#1338</a></li>
<li>build(deps): bump github/codeql-action from 3.24.7 to 3.24.9 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1341 ">codecov/codecov-action#1341</a></li>
<li>fix: typo in disable_safe_directory by <a href="https://github.com/mkroening "><code>@âmkroening</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1343 ">codecov/codecov-action#1343</a></li>
<li>chore(release): 4.1.1 by <a href="https://github.com/thomasrockhu-codecov "><code>@âthomasrockhu-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1344 ">codecov/codecov-action#1344</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/mkroening "><code>@âmkroening</code></a> made their first contribution in <a href="https://redirect.github.com/codecov/codecov-action/pull/1343 ">codecov/codecov-action#1343</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/codecov/codecov-action/compare/v4.1.0...v4.1.1 ">https://github.com/codecov/codecov-action/compare/v4.1.0...v4.1.1 </a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md ">codecov/codecov-action's changelog</a>.</em></p>
<blockquote>
<h2>4.0.0-beta.2</h2>
<h3>Fixes</h3>
<ul>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/1085 ">#1085</a> not adding -n if empty to do-upload command</li>
</ul>
<h2>4.0.0-beta.1</h2>
<p><code>v4</code> represents a move from the <a href="https://github.com/codecov/uploader ">universal uploader</a> to the <a href="https://github.com/codecov/codecov-cli ">Codecov CLI</a>. Although this will unlock new features for our users, the CLI is not yet at feature parity with the universal uploader.</p>
<h3>Breaking Changes</h3>
<ul>
<li>No current support for <code>aarch64</code> and <code>alpine</code> architectures.</li>
<li>Tokenless uploading is unsuported</li>
<li>Various arguments to the Action have been removed</li>
</ul>
<h2>3.1.4</h2>
<h3>Fixes</h3>
<ul>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/967 ">#967</a> Fix typo in README.md</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/971 ">#971</a> fix: add back in working dir</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/969 ">#969</a> fix: CLI option names for uploader</li>
</ul>
<h3>Dependencies</h3>
<ul>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/970 ">#970</a> build(deps-dev): bump <code>@âtypes/node</code> from 18.15.12 to 18.16.3</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/979 ">#979</a> build(deps-dev): bump <code>@âtypes/node</code> from 20.1.0 to 20.1.2</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/981 ">#981</a> build(deps-dev): bump <code>@âtypes/node</code> from 20.1.2 to 20.1.4</li>
</ul>
<h2>3.1.3</h2>
<h3>Fixes</h3>
<ul>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/960 ">#960</a> fix: allow for aarch64 build</li>
</ul>
<h3>Dependencies</h3>
<ul>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/957 ">#957</a> build(deps-dev): bump jest-junit from 15.0.0 to 16.0.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/958 ">#958</a> build(deps): bump openpgp from 5.7.0 to 5.8.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/959 ">#959</a> build(deps-dev): bump <code>@âtypes/node</code> from 18.15.10 to 18.15.12</li>
</ul>
<h2>3.1.2</h2>
<h3>Fixes</h3>
<ul>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/718 ">#718</a> Update README.md</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/851 ">#851</a> Remove unsupported path_to_write_report argument</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/898 ">#898</a> codeql-analysis.yml</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/901 ">#901</a> Update README to contain correct information - inputs and negate feature</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/955 ">#955</a> fix: add in all the extra arguments for uploader</li>
</ul>
<h3>Dependencies</h3>
<ul>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/819 ">#819</a> build(deps): bump openpgp from 5.4.0 to 5.5.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/835 ">#835</a> build(deps): bump node-fetch from 3.2.4 to 3.2.10</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/840 ">#840</a> build(deps): bump ossf/scorecard-action from 1.1.1 to 2.0.4</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/841 ">#841</a> build(deps): bump <code>@âactions/core</code> from 1.9.1 to 1.10.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/843 ">#843</a> build(deps): bump <code>@âactions/github</code> from 5.0.3 to 5.1.1</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/869 ">#869</a> build(deps): bump node-fetch from 3.2.10 to 3.3.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/872 ">#872</a> build(deps-dev): bump jest-junit from 13.2.0 to 15.0.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/879 ">#879</a> build(deps): bump decode-uri-component from 0.2.0 to 0.2.2</li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="c16abc29c9https://redirect.github.com/codecov/codecov-action/issues/1344 ">#1344</a>)</li>
<li><a href="3e33441c19https://redirect.github.com/codecov/codecov-action/issues/1343 ">#1343</a>)</li>
<li><a href="85aacc9654https://redirect.github.com/codecov/codecov-action/issues/1341 ">#1341</a>)</li>
<li><a href="4ea9be0fa3https://redirect.github.com/codecov/codecov-action/issues/1338 ">#1338</a>)</li>
<li><a href="164fadeaa7https://redirect.github.com/codecov/codecov-action/issues/1334 ">#1334</a>)</li>
<li><a href="4621ecce09https://redirect.github.com/codecov/codecov-action/issues/1329 ">#1329</a>)</li>
<li><a href="251ba34669https://redirect.github.com/codecov/codecov-action/issues/1331 ">#1331</a>)</li>
<li><a href="5a593a5341https://redirect.github.com/codecov/codecov-action/issues/1332 ">#1332</a>)</li>
<li><a href="a15c0e43cahttps://redirect.github.com/codecov/codecov-action/issues/1325 ">#1325</a>)</li>
<li><a href="8be6ba5782https://redirect.github.com/codecov/codecov-action/issues/1319 ">#1319</a>)</li>
<li>Additional commits viewable in <a href="54bcd8715e...c16abc29c9https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=codecov/codecov-action&package-manager=github_actions&previous-version=4.1.0&new-version=4.1.1 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-03-26 22:16:06 +00:00
Christopher Fujino
385bec0abb
Roll pub packages and regenerate gradle lockfiles ( #145727 )
...
Example failing devicelab build https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_pixel_7pro%20platform_views_scroll_perf__timeline_summary/2980/overview
Fixes https://github.com/flutter/flutter/issues/145561
Supercedes https://github.com/flutter/flutter/pull/145564
2024-03-26 22:07:06 +00:00
engine-flutter-autoroll
b3c9f5f8d9
Roll Flutter Engine from 5c7aea6f20fc to 026d8902e3b5 (1 revision) ( #145785 )
...
5c7aea6f20...026d8902e3skia-flutter-autoroll@skia.org Roll Dart SDK from 09e56db7d600 to a600b67424a8 (5 revisions) (flutter/engine#51684 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-26 22:07:03 +00:00
engine-flutter-autoroll
0779480e01
Roll Flutter Engine from baede78d2352 to 5c7aea6f20fc (2 revisions) ( #145784 )
...
baede78d23...5c7aea6f20jason-simmons@users.noreply.github.com [Impeller] Do not apply mask filters to a DrawPaint cover geometry (flutter/engine#51670 )
2024-03-26 flar@google.com [Impeller] Simplify calculation of Matrix::GetMaxBasisXY() (flutter/engine#51664 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-26 21:18:25 +00:00
engine-flutter-autoroll
7f4d621fc9
Roll Flutter Engine from cffd1dcfe6a5 to baede78d2352 (2 revisions) ( #145778 )
...
cffd1dcfe6...baede78d23rmacnak@google.com Stop rolling zlib with Dart SDK rolls. (flutter/engine#51667 )
2024-03-26 skia-flutter-autoroll@skia.org Roll Skia from 90cfbf5fb91e to 0590062821dc (2 revisions) (flutter/engine#51680 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-26 20:37:05 +00:00
Lipu
e5e70b069a
Correct typo: "Free" to "Three" in comments ( #145689 )
...
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*
*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-03-26 20:25:00 +00:00
Taha Tesser
d2c8552944
Fix disabled DropdownMenu doesn't defer the mouse cursor ( #145686 )
...
fixes [DropdownMenu cursor in disabled state](https://github.com/flutter/flutter/issues/144611 )
This was added in https://github.com/flutter/flutter/pull/121353
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() {
runApp(const MyApp());
}
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
home: Scaffold(
body: Center(
child: Column(
mainAxisSize: MainAxisSize.min,
children: <Widget>[
const Spacer(),
const Text('enabled: true,\nrequestFocusOnTap: true,'),
const SizedBox(height: 16),
DropdownMenu<String>(
enabled: true,
initialSelection: 'First',
requestFocusOnTap: true,
width: 200,
dropdownMenuEntries: ['First', 'Second', 'Third']
.map((e) => DropdownMenuEntry(value: e, label: e))
.toList(),
),
const Text('Expected: text cursor'),
const Spacer(),
const Text('enabled: true,\nrequestFocusOnTap: false,'),
const SizedBox(height: 16),
DropdownMenu<String>(
enabled: true,
initialSelection: 'First',
requestFocusOnTap: false,
width: 200,
dropdownMenuEntries: ['First', 'Second', 'Third']
.map((e) => DropdownMenuEntry(value: e, label: e))
.toList(),
// label: const Text('requestFocusOnTap: false'),
),
const Text('Expected: clickable cursor'),
const Spacer(),
const Text('enabled: false,\nrequestFocusOnTap: true,'),
const SizedBox(height: 16),
DropdownMenu<String>(
enabled: false,
initialSelection: 'First',
requestFocusOnTap: true,
width: 200,
dropdownMenuEntries: ['First', 'Second', 'Third']
.map((e) => DropdownMenuEntry(value: e, label: e))
.toList(),
),
const Text('Expected: deferred cursor'),
const Spacer(),
const Text('enabled: false,\nrequestFocusOnTap: false,'),
const SizedBox(height: 16),
DropdownMenu<String>(
enabled: false,
initialSelection: 'First',
requestFocusOnTap: false,
width: 200,
dropdownMenuEntries: ['First', 'Second', 'Third']
.map((e) => DropdownMenuEntry(value: e, label: e))
.toList(),
),
const Text('Expected: deferred cursor'),
const Spacer(),
],
),
),
),
);
}
}
```
</details>
### Preview
2024-03-26 20:15:48 +00:00
engine-flutter-autoroll
8d31c58333
Roll Flutter Engine from b2d93a64cbc7 to cffd1dcfe6a5 (9 revisions) ( #145773 )
...
b2d93a64cb...cffd1dcfe6jacksongardner@google.com Pass the flutter test font by default. (flutter/engine#51671 )
2024-03-26 jonahwilliams@google.com [Impeller] revert usage of foreground blend optimization. (flutter/engine#51679 )
2024-03-26 jonahwilliams@google.com [Impeller] Refactor clip stack into separate testable class. (flutter/engine#51656 )
2024-03-26 zanderso@users.noreply.github.com Roll buildroot to ba3ca696f4f95e998707523be755c15440c6bf3f (flutter/engine#51678 )
2024-03-26 zanderso@users.noreply.github.com Use RBE for Fuchsia CI builds (flutter/engine#51675 )
2024-03-26 skia-flutter-autoroll@skia.org Roll Skia from 7ffd936a66df to 90cfbf5fb91e (15 revisions) (flutter/engine#51677 )
2024-03-26 chris@bracken.jp [macOS] Disable FlutterEngineTest.CanOverrideBackgroundColor (flutter/engine#51669 )
2024-03-26 zanderso@users.noreply.github.com Roll buildroot to 2a16784938d3be059014d4112f00ac70a386fa0c (flutter/engine#51674 )
2024-03-26 skia-flutter-autoroll@skia.org Roll Dart SDK from a783a4a043ec to 09e56db7d600 (2 revisions) (flutter/engine#51666 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-26 19:51:53 +00:00
engine-flutter-autoroll
1279df81e6
Roll Packages from 28d126c54c63 to ab1630b9b9bd (1 revision) ( #145755 )
...
28d126c54c...ab1630b9b9tarrinneal@gmail.com [pigeon] Adds @SwiftClass annotation (flutter/packages#6372 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-26 19:41:35 +00:00
Kostia Sokolovskyi
94c63f825f
Memory leaks clean up 2 ( #145757 )
2024-03-26 12:22:57 -07:00
Kostia Sokolovskyi
8953ba658f
Fix memory leak in Overlay.wrap. ( #145744 )
2024-03-26 12:21:21 -07:00
Jackson Gardner
158328921d
Be tolerant of backticks around directory name in pub output. ( #145768 )
...
This fixes https://github.com/flutter/flutter/issues/145766
The output of the pub command changed slightly with this change: https://dart.googlesource.com/pub/+/2179b765aa9071386be02d408b3c3caa82af98f5
Update the tests to be tolerant of the directory path being surrounded by backticks (or not) so that we are compatible with the current and upcoming implementation.
2024-03-26 19:04:52 +00:00
Taha Tesser
81f969e807
Fix ExpansionTile Expanded/Collapsed announcement is interrupted by VoiceOver ( #143936 )
...
fixes [`ExpansionTile` accessibility information doesn't read Expanded/Collapsed (iOS)](https://github.com/flutter/flutter/issues/132264 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
home: Scaffold(
appBar: AppBar(
title: const Text('ExpansionTile'),
),
body: const ExpansionTile(
title: Text("Title"),
children: <Widget>[
Placeholder(),
],
),
floatingActionButton: FloatingActionButton(
onPressed: () {},
child: const Icon(Icons.add),
),
),
);
}
}
```
</details>
### Before
https://github.com/flutter/flutter/assets/48603081/542d8392-52dc-4319-92ba-215a7164db49
### After
https://github.com/flutter/flutter/assets/48603081/c9225144-4c12-4e92-bc41-4ff82b370ad7
2024-03-26 18:36:09 +00:00
Kevin Moore
388f3217e4
[flutter_tools] Enable WebAssembly compilation everywhere, remove feature flag ( #145562 )
2024-03-26 18:23:49 +00:00
engine-flutter-autoroll
55528ba1b7
Roll Flutter Engine from 3c881b75cc28 to b2d93a64cbc7 (1 revision) ( #145759 )
...
3c881b75cc...b2d93a64cb58529443+srujzs@users.noreply.github.com Change JSBoxedDartObject to JSAny (flutter/engine#51634 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-26 17:14:27 +00:00
engine-flutter-autoroll
a8345d5399
Roll Flutter Engine from b2001fa6d773 to 3c881b75cc28 (1 revision) ( #145733 )
...
b2001fa6d7...3c881b75cczanderso@users.noreply.github.com Revert "Disable cleaning up ImageReaders in memory pressure callback" (flutter/engine#51665 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-26 01:07:30 +00:00
engine-flutter-autoroll
bc9e789e2c
Roll Flutter Engine from 5fc95a3277ea to b2001fa6d773 (1 revision) ( #145730 )
...
5fc95a3277...b2001fa6d7skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ySBsQPn-0UgTQaXIw... to uu8lffXkeJQ9PC96I... (flutter/engine#51660 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from ySBsQPn-0UgT to uu8lffXkeJQ9
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-25 23:55:24 +00:00
Taha Tesser
8363e78280
Fix SearchAnchor triggers unnecessary suggestions builder calls ( #143443 )
...
fixes [`SearchAnchor` triggers extra search operations](https://github.com/flutter/flutter/issues/139880 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
Future<List<String>> createFuture() async {
return List.generate(1000, (index) => "Hello World!");
}
void main() {
runApp(const MyApp());
}
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return const MaterialApp(
title: 'Flutter Demo',
home: MyHomePage(title: 'Flutter Demo Home Page'),
);
}
}
class MyHomePage extends StatefulWidget {
const MyHomePage({super.key, required this.title});
final String title;
@override
State<MyHomePage> createState() => _MyHomePageState();
}
class _MyHomePageState extends State<MyHomePage> {
final SearchController controller = SearchController();
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(
backgroundColor: Theme.of(context).colorScheme.inversePrimary,
title: Text(widget.title),
),
body: Center(
child: Column(
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
SearchAnchor(
searchController: controller,
suggestionsBuilder: (suggestionsContext, controller) {
final resultFuture = createFuture();
return [
FutureBuilder(
future: resultFuture,
builder: ((context, snapshot) {
if (snapshot.connectionState != ConnectionState.done) {
return const LinearProgressIndicator();
}
final result = snapshot.data;
if (result == null) {
return const LinearProgressIndicator();
}
return ListView.builder(
shrinkWrap: true,
physics: const NeverScrollableScrollPhysics(),
itemCount: result.length,
itemBuilder: (BuildContext context, int index) {
final root = result[index];
return ListTile(
leading: const Icon(Icons.article),
title: Text(root),
subtitle: Text(
root,
overflow: TextOverflow.ellipsis,
style: TextStyle(
color: Theme.of(suggestionsContext)
.colorScheme
.onSurfaceVariant,
),
),
onTap: () {},
);
},
);
}),
),
];
},
builder: (BuildContext context, SearchController controller) {
return IconButton(
onPressed: () {
controller.openView();
},
icon: const Icon(Icons.search),
);
},
),
],
),
),
);
}
}
```
</details>
### Before
https://github.com/flutter/flutter/assets/48603081/69f6dfdc-9f92-4d2e-8a3e-984fce25f9e4
### After
https://github.com/flutter/flutter/assets/48603081/be105e2c-51d8-4cb0-a75b-f5f41d948e5e
2024-03-25 22:58:11 +00:00
Jesse
2832611da8
Refactor add_to_app_life_cycle_tests ( #145546 )
...
Refactor add_to_app_life_cycle_tests in order to reduce testing logic in test.dart, create a suite_runners directory and allow for later implementing package:test onto add_to_app_life_cycle_tests
Part of https://github.com/flutter/flutter/issues/145482
2024-03-25 22:44:58 +00:00
engine-flutter-autoroll
b05937d3dc
Roll Flutter Engine from 04191a122e9a to 5fc95a3277ea (3 revisions) ( #145722 )
...
04191a122e...5fc95a3277skia-flutter-autoroll@skia.org Roll Skia from 625d04f3a7c5 to 7ffd936a66df (7 revisions) (flutter/engine#51657 )
2024-03-25 lauren@selfisekai.rocks font_subset tests: name correct variant in exception (flutter/engine#51492 )
2024-03-25 skia-flutter-autoroll@skia.org Roll Skia from 8a587a10323f to 625d04f3a7c5 (5 revisions) (flutter/engine#51655 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-25 21:51:21 +00:00
Taha Tesser
5e19b33534
Fix vertical Stepper draws connector on the last step ( #145703 )
...
fixes [Vertical stepper shows line after last step](https://github.com/flutter/flutter/issues/144376 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
home: Scaffold(
body: Center(
child: Stepper(
currentStep: 1,
steps: const <Step>[
Step(
title: Text("Step 1"),
content: Text("Content 1"),
),
Step(
title: Text("Step 2"),
content: Text("Content 2"),
),
],
),
),
),
);
}
}
```
</details>
### Before
### After
2024-03-25 21:47:05 +00:00
Michael Goderbauer
330a2ca2ab
Update links in analysis_options.yaml ( #145706 )
...
According to the [readme](https://github.com/dart-lang/linter?tab=readme-ov-file#repository-has-moved ) of the linter repository, the source of truth for the linter has moved to the SDK repository. This updates the link to `all.yaml` in our file.
While I am in here, I also updated two other links that were outdated.
2024-03-25 21:47:03 +00:00
Kenzie Davisson
31f4f2b6c0
Add a --print-dtd flag to print the DTD address served by DevTools server ( #144272 )
2024-03-25 13:04:18 -07:00
engine-flutter-autoroll
dbdcead932
Roll Flutter Engine from ef896e942f44 to 04191a122e9a (1 revision) ( #145709 )
...
ef896e942f...04191a122ejonahwilliams@google.com [Impeller] fix unbalanced restores. (flutter/engine#51648 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-25 18:17:57 +00:00
Ikko Eltociear Ashimine
9fa731ddf8
Update semantics.dart ( #145683 )
...
loosing -> losing
2024-03-25 18:17:54 +00:00
Kostia Sokolovskyi
453a04d9f3
TwoDimensionalChildDelegate should dispatch creation and disposal events ( #145684 )
2024-03-25 10:45:02 -07:00
Kostia Sokolovskyi
47bfa827ba
Memory leaks clean up 1 ( #145691 )
2024-03-25 10:36:42 -07:00
engine-flutter-autoroll
2dd276487b
Roll Flutter Engine from 2e8d77dbb0f0 to ef896e942f44 (1 revision) ( #145705 )
...
2e8d77dbb0...ef896e942fskia-flutter-autoroll@skia.org Roll Skia from e7ae039f5b1b to 8a587a10323f (1 revision) (flutter/engine#51654 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-25 17:35:09 +00:00
Sahil Kachhap
a9f18b803b
[Fix]: Searchbar doesn't lose focus when tapped outside ( #145232 )
...
Added a Fix to search bar that allows it be unfocused when tapped anywhere outside the search bar.
I have attached below the app flow after implementing the fix.
https://github.com/flutter/flutter/assets/54017876/70915c47-9b77-4a43-a128-8706107f921f
Issue that gets resolved by this fix : #145096
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-03-25 17:02:07 +00:00
Kostia Sokolovskyi
2851ed3202
Fix typo in hitTest docs ( #145677 )
...
This PR fixes the typo in the `hitTest` method documentation.
2024-03-25 17:00:06 +00:00
engine-flutter-autoroll
b39660df8f
Roll Packages from 611aea1657fb to 28d126c54c63 (1 revision) ( #145690 )
...
611aea1657...28d126c54cengine-flutter-autoroll@skia.org Roll Flutter from 18340ea16cee to 14774b95c250 (20 revisions) (flutter/packages#6376 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-25 15:49:39 +00:00
Daco Harkes
baa54fdd76
[deps] Bump native assets dependencies ( #145612 )
...
Roll of a bunch of breaking changes from the native_assets_builder and
native_assets_cli upstream. Most notably:
* https://github.com/dart-lang/native/pull/946
* https://github.com/dart-lang/native/pull/1018
* https://github.com/dart-lang/native/pull/1019
This PR also updates the template in `flutter create
--template=package_ffi` to use the rewritten API.
This PR does not change any functionality in Flutter.
For reference, the same roll in the Dart SDK:
* https://dart-review.googlesource.com/c/sdk/+/357605
* https://dart-review.googlesource.com/c/sdk/+/357623
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-03-25 15:02:49 +01:00
engine-flutter-autoroll
280037f6b1
Roll Flutter Engine from 857584c458ff to 2e8d77dbb0f0 (1 revision) ( #145678 )
...
857584c458...2e8d77dbb0skia-flutter-autoroll@skia.org Roll Skia from e6dc16a6d82d to e7ae039f5b1b (1 revision) (flutter/engine#51653 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-25 12:17:38 +00:00
Taha Tesser
23687c5260
Add AnimationStyle to showBottomSheet and showModalBottomSheet ( #145536 )
...
fixes [Introduce animation customizable with `AnimationStyle` to `BottomSheet`](https://github.com/flutter/flutter/issues/145532 )
### Default bottom sheet animation
### Custom bottom sheet animation
### No bottom sheet animation
2024-03-25 08:39:05 +00:00
engine-flutter-autoroll
62adaff870
Roll Flutter Engine from ae758d54630d to 857584c458ff (2 revisions) ( #145673 )
...
ae758d5463...857584c458skia-flutter-autoroll@skia.org Roll Skia from 7f2e8320bbfe to e6dc16a6d82d (1 revision) (flutter/engine#51652 )
2024-03-25 skia-flutter-autoroll@skia.org Roll Skia from df5d7a960d34 to 7f2e8320bbfe (1 revision) (flutter/engine#51651 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-25 08:00:16 +00:00
engine-flutter-autoroll
7f06c263a4
Roll Flutter Engine from efdde39a2a57 to ae758d54630d (1 revision) ( #145669 )
...
efdde39a2a...ae758d5463skia-flutter-autoroll@skia.org Roll Skia from fa486cd8b2d0 to df5d7a960d34 (1 revision) (flutter/engine#51650 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-25 04:33:34 +00:00
Andrew Kolos
cd785544fa
make hot reload reflect changes to asset transformer configurations ( #144660 )
...
In service of https://github.com/flutter/flutter/issues/143348
This PR makes hot reloads reflect changes to transformer configurations under the `assets` section in pubspec.yaml.
This PR is optimized for ease of implementation, and should not be merged as-is. If it is merged as-is, seriously consider creating a tech debt issue and assigning it to someone to make sure it gets resolved.
2024-03-25 04:13:11 +00:00
engine-flutter-autoroll
a5cf4191dc
Roll Flutter Engine from 0734f47f2a3d to efdde39a2a57 (2 revisions) ( #145668 )
...
0734f47f2a...efdde39a2arobert.ancell@canonical.com Add fl_standard_method_codec_new_with_message_codec() (flutter/engine#51599 )
2024-03-24 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from IPZvFWIGJFJnJ409e... to ySBsQPn-0UgTQaXIw... (flutter/engine#51649 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from IPZvFWIGJFJn to ySBsQPn-0UgT
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-25 02:30:39 +00:00
engine-flutter-autoroll
52dc43f34f
Roll Flutter Engine from 7c139e0a4897 to 0734f47f2a3d (1 revision) ( #145662 )
...
7c139e0a48...0734f47f2askia-flutter-autoroll@skia.org Roll Dart SDK from 88f531b19ed5 to a783a4a043ec (1 revision) (flutter/engine#51647 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-24 19:26:11 +00:00
Polina Cherkasova
9fee27b244
Leak clean up. ( #144803 )
...
Fix some leaks and mark others.
[Known leaks](https://github.com/issues?q=is%3Aopen+is%3Aissue+label%3A%22a%3A+leak+tracking%22+-label%3A%22c%3A+new+feature%22+ )
2024-03-24 18:01:17 +00:00
Polina Cherkasova
e10049b2ff
Turn off randomization for leak detection bots. ( #145624 )
2024-03-24 17:47:23 +00:00
engine-flutter-autoroll
3373961720
Roll Flutter Engine from 2f5afdf62365 to 7c139e0a4897 (1 revision) ( #145655 )
...
2f5afdf623...7c139e0a48skia-flutter-autoroll@skia.org Roll Skia from 755ca0094a77 to fa486cd8b2d0 (2 revisions) (flutter/engine#51646 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-24 08:52:24 +00:00
engine-flutter-autoroll
d8854fd898
Roll Flutter Engine from 7aa8521e640e to 2f5afdf62365 (2 revisions) ( #145651 )
...
7aa8521e64...2f5afdf623skia-flutter-autoroll@skia.org Roll Dart SDK from 567a19adbe9a to 88f531b19ed5 (1 revision) (flutter/engine#51644 )
2024-03-23 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from _uuBNUJ6KbprCDWmC... to IPZvFWIGJFJnJ409e... (flutter/engine#51643 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from _uuBNUJ6Kbpr to IPZvFWIGJFJn
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-24 02:03:12 +00:00
engine-flutter-autoroll
638e47146d
Roll Flutter Engine from 689ea4b10b17 to 7aa8521e640e (1 revision) ( #145643 )
...
689ea4b10b...7aa8521e64skia-flutter-autoroll@skia.org Roll Dart SDK from 4ed5b58c2cf7 to 567a19adbe9a (1 revision) (flutter/engine#51642 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-23 19:16:54 +00:00
engine-flutter-autoroll
73e78fd97c
Roll Flutter Engine from 42d4262b4b20 to 689ea4b10b17 (1 revision) ( #145636 )
...
42d4262b4b...689ea4b10bskia-flutter-autoroll@skia.org Roll Dart SDK from 45169152b424 to 4ed5b58c2cf7 (1 revision) (flutter/engine#51641 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-23 14:18:25 +00:00
Pierre-Louis
9ae8a6b7d5
Reland #128236 "Improve build output for all platforms" ( #145495 )
...
Reland #128236 , reverted in https://github.com/flutter/flutter/pull/143125 , https://github.com/flutter/flutter/pull/145261 , and https://github.com/flutter/flutter/pull/145487 .
The errors were raised in post-submit tests on Windows. I have finally obtained a Windows machine to reproduce the errors locally and adjust the test (remove size expectation and rename output `.exe`).
## Original description
Improves the build output:
1. Gives confirmation that the build succeeded, in green
1. Gives the path to the built executable, without a trailing period to make it slightly easier to cmd/ctrl+open
1. Gives the size of the built executable (when the built executable is self contained)
### `apk`, `appbundle`
<img width="607" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ecc52abe-cd2e-4116-b22a-8385ae3e980d ">
<img width="634" alt="image" src="https://github.com/flutter/flutter/assets/6655696/8af8bd33-c0bd-4215-9a06-9652ee019436 ">
### `macos`, `ios`, `ipa`
Build executables are self-contained and use a newly introduced `OperatingSystemUtils.getDirectorySize`.
<img width="514" alt="image" src="https://github.com/flutter/flutter/assets/6655696/b5918a69-3959-4417-9205-4f501d185257 ">
<img width="581" alt="image" src="https://github.com/flutter/flutter/assets/6655696/d72fd420-18cf-4470-9e4b-b6ac10fbcd50 ">
<img width="616" alt="image" src="https://github.com/flutter/flutter/assets/6655696/5f235ce1-252a-4c13-898f-139f6c7bc698 ">
### `windows`, `linux`, and `web`
Build executables aren't self-contained, and folder size can sometimes overestimate distribution size, therefore their size isn't mentioned (see discussion below).
<img width="647" alt="image" src="https://github.com/flutter/flutter/assets/6655696/7179e771-1eb7-48f6-b770-975bc073437b ">
<img width="658" alt="image" src="https://github.com/flutter/flutter/assets/6655696/a6801cab-7b5a-4975-a406-f4c9fa44d7a2 ">
<img width="608" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ee7c4125-a273-4a65-95d7-ab441edf8ac5 ">
### Size reporting
When applicable, the printed size matches the OS reported size.
- macOS
<img width="391" alt="image" src="https://github.com/flutter/flutter/assets/6655696/881cbfb1-d355-444b-ab44-c1a6343190ce ">
- Windows
<img width="338" alt="image" src="https://github.com/flutter/flutter/assets/6655696/3b806def-3d15-48a9-8a25-df200d6feef7 ">
- Linux
<img width="320" alt="image" src="https://github.com/flutter/flutter/assets/6655696/89a4aa3d-2148-4f3b-b231-f93a057fee2b ">
## Related issues
Part of #120127
Fixes https://github.com/flutter/flutter/issues/121401
2024-03-23 12:05:21 +00:00
