Loïc Sharma
bfdb366b50
Add example to ClipOval docs ( #157227 )
2024-10-22 22:20:00 +00:00
engine-flutter-autoroll
18d1afa3e4
Roll Flutter Engine from 2410cdf12c8f to 2d3f0f41b940 (5 revisions) ( #157383 )
...
2410cdf12c...2d3f0f41b9skia-flutter-autoroll@skia.org Roll Skia from 3731c1f7cf29 to ad09ab099fe4 (2 revisions) (flutter/engine#56033 )
2024-10-22 109111084+yaakovschectman@users.noreply.github.com Fix typo in testing script (flutter/engine#56029 )
2024-10-22 chinmaygarde@google.com [Impeller] libImpeller: Document the entire API. (flutter/engine#56003 )
2024-10-22 jonahwilliams@google.com [Impeller] eagerly flip backdrop back to onscreen. (flutter/engine#55983 )
2024-10-22 codefu@google.com Typo in engine_binary_hashing.md (flutter/engine#55866 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-22 21:24:42 +00:00
Matan Lurey
5a1ae9779d
Remove the only reference to settings.gradle.legacy_versions. ( #157380 )
...
Code references:
https://github.com/search?q=repo%3Aflutter%2Fflutter%20%22legacy_versions%22&type=code .
Closes https://github.com/flutter/flutter/issues/87922 .
Work towards https://github.com/flutter/flutter/issues/48918 .
2024-10-22 14:03:50 -07:00
Loïc Sharma
945067ae91
Remove duplicated widget of the week video embed ( #157299 )
...
The `ScaffoldMessenger` widget embeds its widget of the week video twice: https://main-api.flutter.dev/flutter/material/ScaffoldMessenger-class.html
2024-10-22 20:34:24 +00:00
auto-submit[bot]
60d4c9b741
Reverts "Fix TextField selects all content after the application is resumed ( #156968 )" ( #157378 )
...
Reverts: flutter/flutter#156968
Initiated by: jacobsimionato
Reason for reverting: Google3 roll failing - see b/375019489
Original PR Author: bleroux
Reviewed By: {justinmc, gspencergoog}
This change reverts the following previous change:
## Description
This PR makes `EditableText` aware of the lifecycle 'resumed' state to let the current selection unchanged when the application is resumed (on web and desktop, 'resumed' means the Flutter app window regained focus).
Before this PR, on web and desktop, the whole content of a `TextField` was selected whenever a `TextField` gained focus. This is the correct behavior when tabbing between fields but it is not when a field regains focus after the application is resumed
## Related Issue
Fixes [When switching to another browser tab or window and then going back, all text on TextField is selected automatically](https://github.com/flutter/flutter/issues/156078 ).
## Tests
Adds 1 test.
2024-10-22 19:59:22 +00:00
René Kilczan
48149781f2
Add windows build version detection ( #154797 )
...
With this PR flutter doctor will report the actual Windows version. This
resolves #154796
<!-- *If you had to change anything in the [flutter/tests] repo, include
a link to the migration guide as per the [breaking change policy].* -->
The flutter doctor result is with this patch like this:
```
[√] Flutter (Channel stable, 3.24.2, on Microsoft Windows [Version 10.0.22631.4037], locale de-DE)
[√] Windows Version (Windows 11 - 23H2)
[√] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[√] Chrome - develop for the web
[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.8.3)
[√] Android Studio (version 2024.1)
[√] Connected device (3 available)
[√] Network resources
• No issues found!
```
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Andrew Kolos <andrewrkolos@gmail.com>
2024-10-22 15:53:08 -04:00
Jenn Magder
e38eb756bc
Test alternate correct macOS framework xcprivacy manifest location ( #157318 )
...
Cherry-pick the beta branch test https://github.com/flutter/flutter/pull/157136 back to master so this doesn't regress in the next beta.
This is the framework test for https://github.com/flutter/flutter/issues/157016 on master. Engine fix can be merged once this merges.
2024-10-22 19:41:14 +00:00
João Victor Schramm
1d5087eb30
fix: CupertinoDatePicker.DateAndTime using showDayOfWeek ( #155260 )
...
As mentioned in the issue https://github.com/flutter/flutter/issues/153576 , even if we declare the 'showDayOfWeek' value as false, when using the mode CupertinoDatePickerMode.dateAndTime, the days of week still shows in the screen.
This PR is about making an assert that prevent developers from using `DateTimePicker.DateAndTime` with `showDayOfWeek` as false (because it only works on date mode) as suggested by @Piinks.
2024-10-22 19:37:19 +00:00
romain.gyh
21814805c1
fix: Considers strokeAlign to compute border dimensions ( #155495 )
...
Fixes #155491
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
There are 3 golden tests that don't pass on my computer, but they were
already not passing before my changes.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2024-10-22 12:02:02 -07:00
Bruno Leroux
260bee4d08
Fix MenuController.isOpen throws when unattached ( #157331 )
...
## Description
This PR change `MenuController.isOpen` to return false when the `MenuController` is not attached.
Previously `MenuController.isOpen` thrown an assert error when the menu controller was unattached.
With this PR, it is now possible to have some widgets outside the `MenuAnchor` body depending on the menu controller state.
## Related Issue
Fixes [Querying isOpen state for a menu controller that was never attached throws an assertion error](https://github.com/flutter/flutter/issues/157329 ).
## Tests
Adds 1 test.
2024-10-22 18:49:15 +00:00
Mouad Debbar
e9fb545c05
[web] Allow control of hitTestBehavior of Platform Views ( #157189 )
...
Hit testing behavior is currently hardcoded to `opaque` in `HtmlElementView` which causes the platform view to swallow pointer events when it's a descendant of a `GestureDetector` (see this [example](https://dartpad.dev/?id=5348fbf82be5eeb7d995f953437f0ce6 )).
In order to fix this, we need to make `hitTestBehavior` configurable in `HtmlElementView`. This way users can decide to make their platform views `transparent` for hit testing purposes.
**_Note_**: this specific case isn't fixable by `PointerInterceptor` because the framework is already receiving the pointer events, so there's nothing that `PointerInterceptor` can do. This issue is all happening on the framework side since it treats the rectangle occupied by the platform view as an opaque rectangle for hit testing.
**_Workaround_**: in the meantime, users can work around this limitation by surrounding the `HtmlElementView` with an `IgnorePointer` widget.
2024-10-22 17:53:17 +00:00
engine-flutter-autoroll
42773df6b6
Roll Flutter Engine from 1df749a00e32 to 2410cdf12c8f (1 revision) ( #157356 )
...
1df749a00e...2410cdf12cskia-flutter-autoroll@skia.org Roll Skia from b11804aaabbb to 3731c1f7cf29 (3 revisions) (flutter/engine#56027 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-22 17:42:09 +00:00
Jiten Patel
5fa5a64842
[ #155269 ] Platform adaptive showAboutDialog and AboutDialog feature c… ( #155377 )
...
This PR introduces a new `showAdaptiveAboutDialog` function, ensuring that the About dialog matches the platformâs design (Material for Android, Fuchsia, Linux, Windows, and, Cupertino for iOS & macOS), providing a more consistent user experience across platforms.
Fixes #155269
- [] I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
2024-10-22 17:32:05 +00:00
Bartek Pacia
eb5ef69d6b
Use Gradle KTS in new Android app projects by default (2nd try) ( #157195 )
...
This PR resolves #151166
This PR relands #154061
2024-10-22 17:28:31 +00:00
Polina Cherkasova
9edd1ae008
Fix leaks in some image tests and explain hackyness of opted-out. ( #154481 )
2024-10-22 10:22:01 -07:00
Jiten Patel
3e9901dac9
Fix: showDatePicker should have a simple example in the docs ( #156196 )
...
This PR introduces a basic example of how to use the `showDatePicker` function. The purpose of this PR is to simplify the onboarding process for new Flutter developers by providing a straightforward demonstration of handling the asynchronous Future returned by the showDatePicker. This will help users unfamiliar with the intricacies of asynchronous operations in Flutter.
Fixes #156157
2024-10-22 17:04:23 +00:00
engine-flutter-autoroll
849ce1d888
Roll Flutter Engine from b3205a28d0fa to 1df749a00e32 (1 revision) ( #157351 )
...
b3205a28d0...1df749a00eskia-flutter-autoroll@skia.org Roll Skia from c89324dd8f6e to b11804aaabbb (1 revision) (flutter/engine#56025 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-22 16:38:13 +00:00
engine-flutter-autoroll
9d27d52b5b
Roll Packages from b6f7e47c7586 to 5e03bb1da411 (3 revisions) ( #157349 )
...
b6f7e47c75...5e03bb1da443054281+camsim99@users.noreply.github.com [video_player_android] Correct rotation of videos recorded by the camera (flutter/packages#7846 )
2024-10-21 gspencergoog@users.noreply.github.com Allow custom blocks to be something other than `Column` or `SizedBox` (flutter/packages#7859 )
2024-10-21 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump androidx.annotation:annotation from 1.8.2 to 1.9.0 in /packages/camera/camera_android/android (flutter/packages#7905 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-22 15:47:24 +00:00
engine-flutter-autoroll
5fabd3d908
Roll Flutter Engine from e6856502b52b to b3205a28d0fa (3 revisions) ( #157348 )
...
e6856502b5...b3205a28d0bdero@google.com [Flutter GPU] Fix conditional when checking DeviceBuffer bounds. (flutter/engine#56017 )
2024-10-22 skia-flutter-autoroll@skia.org Roll Dart SDK from 86ac62245577 to 8de85635d731 (3 revisions) (flutter/engine#56019 )
2024-10-22 skia-flutter-autoroll@skia.org Roll Skia from 64f4f1922946 to c89324dd8f6e (1 revision) (flutter/engine#56018 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-22 15:43:31 +00:00
engine-flutter-autoroll
71ddc6836a
Roll Flutter Engine from 1596c6bd884f to e6856502b52b (1 revision) ( #157333 )
...
1596c6bd88...e6856502b5skia-flutter-autoroll@skia.org Roll Skia from 9c6cc020751d to 64f4f1922946 (3 revisions) (flutter/engine#56016 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-22 09:01:25 +00:00
engine-flutter-autoroll
38e8d0b5de
Roll Flutter Engine from 30bd6c9e8616 to 1596c6bd884f (1 revision) ( #157326 )
...
30bd6c9e86...1596c6bd88skia-flutter-autoroll@skia.org Roll Skia from a71df7d9bc63 to 9c6cc020751d (1 revision) (flutter/engine#56013 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-22 07:25:27 +00:00
Valentin Vignal
a484aa260b
Add test for selectable_region.0.dart ( #157258 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/test/material/selectable_region/selectable_region.0_test.dart`
2024-10-22 07:25:25 +00:00
engine-flutter-autoroll
ba1017d81e
Roll Flutter Engine from 88288446c395 to 30bd6c9e8616 (2 revisions) ( #157323 )
...
88288446c3...30bd6c9e86skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from avSAUwQTf5xVGuZQU... to xPbin_33tT-_omeQT... (flutter/engine#56011 )
2024-10-22 aam@google.com Copy gen_snapshots using python's shutil.copy, avoid links (flutter/engine#55830 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from avSAUwQTf5xV to xPbin_33tT-_
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-22 06:03:35 +00:00
Bruno Leroux
383a221cf3
Fix TextField selects all content after the application is resumed ( #156968 )
...
## Description
This PR makes `EditableText` aware of the lifecycle 'resumed' state to let the current selection unchanged when the application is resumed (on web and desktop, 'resumed' means the Flutter app window regained focus).
Before this PR, on web and desktop, the whole content of a `TextField` was selected whenever a `TextField` gained focus. This is the correct behavior when tabbing between fields but it is not when a field regains focus after the application is resumed
## Related Issue
Fixes to [When switching to another browser tab or window and then going back, all text on TextField is selected automatically](https://github.com/flutter/flutter/issues/156078 ).
## Tests
To be done
2024-10-22 04:41:31 +00:00
Valentin Vignal
27f0c6a08e
Add test for navigation_rail.extended_animation.0_test.dart ( #157222 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/test/material/navigation_rail/navigation_rail.extended_animation.0_test.dart`
2024-10-22 03:55:21 +00:00
engine-flutter-autoroll
b2ca7ebb59
Roll Flutter Engine from b3e227b9a5d9 to 88288446c395 (2 revisions) ( #157317 )
...
b3e227b9a5...88288446c3bdero@google.com [Flutter GPU] Add missing MSAA stuff. (flutter/engine#55424 )
2024-10-22 skia-flutter-autoroll@skia.org Roll Skia from 3a081993e2a7 to a71df7d9bc63 (24 revisions) (flutter/engine#56005 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-22 03:10:38 +00:00
engine-flutter-autoroll
07799f0343
Roll Flutter Engine from d302cc96e8b0 to b3e227b9a5d9 (3 revisions) ( #157314 )
...
d302cc96e8...b3e227b9a5devoncarew@google.com update the SoT location for package:http_parser (flutter/engine#55998 )
2024-10-21 68449066+zijiehe-google-com@users.noreply.github.com Reland: [fuchsia] Remove pm use in build_fuchsia_artifacts (flutter/engine#55932 )
2024-10-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 10387c3fc6d4 to 86ac62245577 (1 revision) (flutter/engine#55995 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-22 01:47:26 +00:00
John McDole
c60e69040d
Add dart command line tool for calculating engine hash ( #157212 )
...
Useful in tooling, releases, etc - where Dart is available
Example usages:
```bash
# Monorepo world
❯ dart ./dev/tools/bin/engine_hash.dart -s head
226e13826c7253c968d798666f323b1f207979f8
# Non-monorepo world
❯ dart ./dev/tools/bin/engine_hash.dart -s head
Error calculating engine hash: Not in a monorepo
```
2024-10-21 16:26:28 -07:00
engine-flutter-autoroll
53a97dd9d4
Roll Flutter Engine from 5eb21d2706c0 to d302cc96e8b0 (2 revisions) ( #157302 )
...
5eb21d2706...d302cc96e8yjbanov@google.com Revert "[web:a11y] make header a proper <header> (#55747 )" (flutter/engine#55993 )
2024-10-21 yjbanov@google.com [web] implement selectable semantics (flutter/engine#55970 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-21 23:04:36 +00:00
Jason Simmons
8b4d48715b
Ensure that the build system checks for updates of locally built flutter_web_sdk artifacts ( #156534 )
...
The SourceVisitor uses the engineVersion parameter to determine whether it needs to check for changes to artifacts or if it can assume that artifacts are unmodified from a versioned build of the engine. engineVersion is set based on whether the Artifacts instance sets the isLocalEngine property.
CachedLocalWebSdkArtifacts (instantiated when the --local-web-sdk flag is used) was only setting isLocalEngine if --local-engine was also used. This caused the build system to ignore changes to the files in the locally built flutter_web_sdk when using --local-web-sdk alone.
This PR renames Artifacts.isLocalEngine to usesLocalArtifacts in order to clarify what it means. It also changes CachedLocalWebSdkArtifacts to always enable usesLocalArtifacts.
2024-10-21 22:52:29 +00:00
Reid Baker
4e8060eff5
Match framework and engine android emulator versions ( #157291 )
...
Related to https://buganizer.corp.google.com/issues/371020223
See https://github.com/flutter/engine/pull/55591 where I updated the engine android 35 emulator version.
2024-10-21 22:34:25 +00:00
Jonah Williams
5bcb3073f4
[devicelab] remove flaky designation from flutter_driver_android_test ( #157300 )
...
https://github.com/flutter/engine/pull/55944 should have fixed all flakes and rolled into framework.
2024-10-21 22:27:52 +00:00
Jason Simmons
bf6c990765
Revert "[devicelab] handle missed lifecycle messages. ( #156596 )" ( #157293 )
...
This reverts commit f1f83aa909c0d6bf39ad8274ac68e48c20825c2b.
With https://github.com/flutter/engine/pull/55933 this should not be needed.
2024-10-21 21:50:04 +00:00
Polina Cherkasova
4b169a81ea
Fix some leaky tests. ( #157294 )
2024-10-21 21:29:05 +00:00
engine-flutter-autoroll
a945427e95
Roll Flutter Engine from de569baa5703 to 5eb21d2706c0 (2 revisions) ( #157295 )
...
de569baa57...5eb21d2706jonahwilliams@google.com [Impeller] Reland: one descriptor pool per frame. (flutter/engine#55960 )
2024-10-21 jmccandless@google.com Scribe (Android stylus handwriting text input) (flutter/engine#52943 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-21 21:17:23 +00:00
Mohellebi abdessalem
fba8c5770f
fix Consider using 'named' to avoid unnecessary configuration inside flutter.groovy ( #157221 )
...
see #147122 for context
[gradle docs](https://docs.gradle.org/current/userguide/task_configuration_avoidance.html ) for reference(scroll until [this)](https://docs.gradle.org/current/userguide/task_configuration_avoidance.html#eager_apis_to_avoid )
also this the lint :
2024-10-21 19:56:18 +00:00
Parker Lougheed
2336329baf
Resolve pupup menu test TODO ( #157251 )
...
Flutter no longer supports versions of Dart that will output the non-reified version.
2024-10-21 19:52:30 +00:00
engine-flutter-autoroll
4d39760097
Roll Flutter Engine from 315540ec20c5 to de569baa5703 (1 revision) ( #157290 )
...
315540ec20...de569baa57devoncarew@google.com re-land "update the repo references for package:file (#55906 )" (flutter/engine#55935 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-21 19:43:33 +00:00
Parker Lougheed
1995a6cba1
Migrate away from deprecated whereNotNull ( #157250 )
2024-10-21 19:25:54 +00:00
Parker Lougheed
a0a82f2821
Fix a few typos in framework code and doc comments ( #157248 )
2024-10-21 19:25:52 +00:00
stuartmorgan
e0d6271911
Update ecosystem contribution docs ( #157288 )
...
Document the requirements for adding a new external, client-facing dependency in flutter/packages
2024-10-21 19:06:04 +00:00
engine-flutter-autoroll
6cae408579
Roll Flutter Engine from 1a8ef6e24fc6 to 315540ec20c5 (1 revision) ( #157284 )
...
1a8ef6e24f...315540ec20zanderso@users.noreply.github.com Increase timeout for Linux mac_clangd (flutter/engine#55988 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-21 18:47:27 +00:00
Polina Cherkasova
6d3167e025
Dispose temporarily created CurvedAnimation [prod-leak-fix] ( #157233 )
2024-10-21 11:04:04 -07:00
engine-flutter-autoroll
effaeee603
Roll Flutter Engine from 68f922560038 to 1a8ef6e24fc6 (5 revisions) ( #157277 )
...
68f9225600...1a8ef6e24fjason-simmons@users.noreply.github.com Request another frame in ImageReaderSurfaceProducer.dequeueImage if more images are pending in the queue (flutter/engine#55944 )
2024-10-21 skia-flutter-autoroll@skia.org Roll Dart SDK from c8659684d34d to 10387c3fc6d4 (1 revision) (flutter/engine#55987 )
2024-10-21 mdebbar@google.com [web] Support woff2 fonts (flutter/engine#55908 )
2024-10-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from PWz1ufnYNOGpgw-qg... to avSAUwQTf5xVGuZQU... (flutter/engine#55985 )
2024-10-21 skia-flutter-autoroll@skia.org Manual roll Dart SDK from a51df90298ca to c8659684d34d (4 revisions) (flutter/engine#55984 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from PWz1ufnYNOGp to avSAUwQTf5xV
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-21 17:30:23 +00:00
Taha Tesser
2665a72559
Fix unattached MenuController throws assertion error when calling MenuController.close() ( #156588 )
...
Fixes [Closing a menu controller that was never attached throws an assertion error](https://github.com/flutter/flutter/issues/156572 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
title: 'Flutter Demo',
theme: ThemeData(
colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
useMaterial3: true,
),
home: const MyHomePage(),
);
}
}
class MyHomePage extends StatefulWidget {
const MyHomePage({super.key});
@override
State<MyHomePage> createState() => _MyHomePageState();
}
class _MyHomePageState extends State<MyHomePage> {
@override
Widget build(BuildContext context) {
return Scaffold(
body: Center(
child: ElevatedButton(
onPressed: () => Navigator.of(context).push(
MaterialPageRoute(
builder: (context) => const MenuControllerPage(),
),
),
child: const Text('Press Me'),
),
),
);
}
}
class MenuControllerPage extends StatefulWidget {
const MenuControllerPage({super.key});
@override
State<MenuControllerPage> createState() => _MenuControllerPageState();
}
class _MenuControllerPageState extends State<MenuControllerPage> {
// This menu controller is intentionally left as not attached to a MenuAnchor.
final MenuController _menuController = MenuController();
@override
void dispose() {
// Close the menu when the page is popped.
_menuController.close();
super.dispose();
}
@override
Widget build(BuildContext context) {
return Scaffold(
body: Center(
child: ElevatedButton(
child: const Text('Go back'),
onPressed: () => Navigator.of(context).pop(),
),
),
);
}
}
```
</details>
2024-10-21 17:26:09 +00:00
engine-flutter-autoroll
d21bf7139a
Roll Packages from 2a1c477a788c to b6f7e47c7586 (5 revisions) ( #157271 )
...
2a1c477a78...b6f7e47c75flutter/packages#7895 )
2024-10-18 stuartmorgan@google.com [in_app_purchase] Update iOS Pigeon for non-nullable generics (flutter/packages#7820 )
2024-10-18 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds internal wrapper for Android native `Ad` (flutter/packages#7880 )
2024-10-18 stuartmorgan@google.com [video_player] Remove Android API 19 SSL handling (flutter/packages#7876 )
2024-10-18 109111084+yaakovschectman@users.noreply.github.com [google_maps_android_flutter] Convert `Config.sdk` to `minSdk` in Robolectric tests and lower to `LOLLIPOP` (flutter/packages#7805 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-21 17:02:59 +00:00
Hannes Hultergård
8621694fdf
Add callbacks for detecting tap up events to TapRegion ( #156110 )
...
Adds `onTapUpOutside` and `onTapUpInside` callbacks to `TapRegion`, and `onTapUpOutside` to `EditableText` text fields. This allows users to detect `PointerUpEvent`s, which in turn can be used to differentiate between a tap and pan / scroll gesture (for example by comparing the distance between the down and up events).
Fixes #140271 and potentially #138190
2024-10-21 16:59:16 +00:00
Loïc Sharma
4ff8c9507b
Polish the texture example ( #157176 )
...
Replaces `SizedBox`es with the new `spacing` parameter in `Column` and fixes some minor formatting issues.
This is a refactoring with no semantic changes. I will get a test exemption.
2024-10-21 16:54:04 +00:00
engine-flutter-autoroll
a4280f9396
Roll Flutter Engine from 53e187a1d4e4 to 68f922560038 (1 revision) ( #157246 )
...
53e187a1d4...68f9225600flar@google.com [Impeller] New impeller round rect class (flutter/engine#55946 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-21 16:31:36 +00:00
Gray Mackall
3baf9d4c60
Make android dependency version test suite run on changes to templates ( #157196 )
...
We have a group of tests that verifies that we can build a flutter app across the range of AGP, Kotlin, and Gradle versions we claim to support. They currently only run on postsubmit.
This pr aims to make them run in presubmit as well, but only when changes are made to the templates (not just android templates, see https://github.com/flutter/flutter/pull/157196#discussion_r1807055791 as to why).
2024-10-21 15:36:45 +00:00
