14859 Commits

Author SHA1 Message Date
Nurhan Turgut
bfcafbec2b
[web_ui] Fixing invalid state bug for text editing (#12698)
* Fixing invalid state bug for text editing. Flutter Framework was sending editing state selection base and extent as -1. Since -1 is an invalid value for a dom element selection it was not applied to the last editing state. Now if the base or offset is sent as negative value, web engine will set 0 to the selection range.

* Addressing PR comments.
2019-09-30 12:31:17 -07:00
Ben Konyi
463762b817 Roll src/third_party/dart 132bee48d0..623fd5c8cd (50 commits)
dart-lang/sdk@623fd5c8cd Add embedder/vm layer checks to presubmits.
dart-lang/sdk@328addd2cf Skip timing out mac+linux tests.
dart-lang/sdk@f135761537 Set the context type for inference after rewriting AST.
dart-lang/sdk@34bdcec877 Don't statically register for LSP document changes when dynamic registration is supported
dart-lang/sdk@93902399dd Remove isAstBasedSummary, keep only 'true' branches in tests.
dart-lang/sdk@963c338104 Don't use ResolverTestCase for two tests.
dart-lang/sdk@3f65652ad0 Enable avoid_init_to_null.
dart-lang/sdk@a006914279 Enable prefer_contains and no_duplicate_case_values.
dart-lang/sdk@d3e7adf548 Issue 38641. Fix linking metadata with unqualified references to static methods.
dart-lang/sdk@82b25f9e47 Use server snapshot for LSP tests
dart-lang/sdk@0a5f736c68 [cfe] Fix missing comma between type parameters in function types
dart-lang/sdk@343723cdff Support navigation targets in migration tooling
dart-lang/sdk@f1d6282fa3 [cfe] Report error on extension members that conflict with Object members
dart-lang/sdk@b682235c4c [cfe] Preserve the nullability of LHS of intersection types
dart-lang/sdk@902a36e36f [cfe] Thread nullability of typedef types from source into Kernel
dart-lang/sdk@b361639a74 [cfe] Account for nullability in type substitution on TypeBuilders
dart-lang/sdk@7d75eb1fd9 [cfe] Account for nullability in type substitution on DartTypes
dart-lang/sdk@e39a15b6d6 [release] Add 2.5.1 to CHANGELOG.md
dart-lang/sdk@d8c5daf17a Enable extension methods by default
dart-lang/sdk@e52542b421 [cfe] Handle generic return types
dart-lang/sdk@dd028547ce [cfe] Support patching of extension methods
dart-lang/sdk@bb600e99e2 [SDK] Make dart2native default output .exe, not .dart.exe.
dart-lang/sdk@8f24bd2901 [cfe] Remove or reformulate some bad tips and messages.
dart-lang/sdk@4b9557e5e3 [cfe] Check valid return type of local async functions.
dart-lang/sdk@942af5bd62 Resolve initializers of final class fields in classes with const constructors.
dart-lang/sdk@200e5b668d Migration: extract decoratedClassHierarchy from EdgeBuilder.
dart-lang/sdk@595022bdea Remove summary1, part 1.
dart-lang/sdk@da75135c7d Revert "Revert "Issue 37608. Use instantiated FunctionType for tear-off(s).""
dart-lang/sdk@caaa577b0c Migration: add support for user-definable operators on generic classes
dart-lang/sdk@21ee71c3e5 Migration: favor explicit `/*?*/` comments over hard edges.
dart-lang/sdk@e4d8ad5866 Flow analysis: remove `add` method.
dart-lang/sdk@b47c8f0d24 [dartdevc] Actually apply SDK patch files from fork in DDC modular test
dart-lang/sdk@6da8c39c5a [vm] Small WasmImports API change, and more WASM error tests
dart-lang/sdk@fca257f8ba [dart2js] New RTI: Don't assert that RTI objects have old structure.
dart-lang/sdk@b7019a0340 [fuchsia] Currently Flutter/Dart -> Fuchsia rolls are broken
dart-lang/sdk@56082c230e Add highlight.pack.js and highlight.js's androidstudio.css to nnbd i13n output
dart-lang/sdk@a1a9d02cfd Fix CSS regarding tooltip positions and sizing
dart-lang/sdk@34899a8a56 Flow analysis: remove TypeOperations.isLocalVariable.
dart-lang/sdk@d2a0900a50 Reland "[vm] Wasm function imports"
dart-lang/sdk@34087a61ba [build] Remove dart_host_toolchain.
dart-lang/sdk@4aa10d0aeb Skip all dart:wasm tests
dart-lang/sdk@ec2823d052 Make an interface type to represent promotable variables.
dart-lang/sdk@2c94bb9849 Fix some recently introduced bugs found by running over logging
dart-lang/sdk@e5661b469d Parse all startup arguments from a file param.
dart-lang/sdk@d2897ff85f [vm/fuzzer] Catch oom error on last block
dart-lang/sdk@9bf38afe9c Check that ClassElement is Object using the corresponding getter.
dart-lang/sdk@05fb7d80dc [cfe] Update test expectations in static_extension_internal_name_conflict_error_test
dart-lang/sdk@7bf76c5925 Change i13n output files to live in a directory structure; fixes #38503
dart-lang/sdk@18f941d9e0 Fix for the ordering and caching issue for default types.
dart-lang/sdk@394f57ed7f [ VM / Service ] Add --object-id-ring-size to unblock UX studies for memory profiling
2019-09-30 11:50:17 -07:00
liyuqian
9675ca2f6b
Reland "Smooth out iOS irregular input events delivery (#12280)" (#12385)
This reverts commit c2879cae2ee3707ad07af1118bf4862dc1d82bb7.

Additionally, we fix https://github.com/flutter/flutter/issues/40863 by adding a secondary VSYNC callback.

Unit tests are updated to provide VSYNC mocking and check the fix of https://github.com/flutter/flutter/issues/40863.

The root cause of having https://github.com/flutter/flutter/issues/40863 is the false assumption that each input event must trigger a new frame. That was true in the framework PR https://github.com/flutter/flutter/pull/36616 because the input events there are all scrolling move events. When the PR was ported to the engine, we can no longer distinguish different types of events, and tap events may no longer trigger a new frame.

Therefore, this PR directly hooks into the `VsyncWaiter` and uses its (newly added) secondary callback to dispatch the pending input event.
2019-09-30 11:25:50 -07:00
Greg Spencer
be9039e351
Add missing flag for embedder. (#12700)
Adding missing flag for IsFocusable that I missed in #12618
2019-09-30 11:21:01 -07:00
Luca Zuccarini
cd1801c121 Add a method to flutter_window_controller to destroy the current window. (#12076)
This allows the embedder to be shutdown by means other than manually closing the window (e.g. by handling a SIGINT).
2019-09-30 10:58:36 -07:00
skia-flutter-autoroll
1f454c7533
Roll fuchsia/sdk/core/linux-amd64 from sWs8N... to _0Sq8... (#12697)
Roll fuchsia/sdk/core/linux-amd64 from sWs8N... to _0Sq8...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-09-30 13:07:42 -04:00
Jason Simmons
4658ecfc3e
Migrate from fuchsia.crash.Analyzer to fuchsia.feedback.CrashReporter (#12413)
Ported from Topaz
2019-09-30 09:50:07 -07:00
Greg Spencer
05f4b33cd2
Add isFocusable to SemanticsFlag (#12618)
This adds an isFocusable to SemanticsFlag so that the framework can tell the engine what semantics nodes are allowed to be focused, which will affect what platform flags are applied to the semantics information.

This flag is not yet in use by the frame
2019-09-30 09:46:48 -07:00
skia-flutter-autoroll
f0c77405d5
Roll src/third_party/skia e242d0ea937c..89e1f600ec78 (3 commits) (#12696)
https://skia.googlesource.com/skia.git/+log/e242d0ea937c..89e1f600ec78

git log e242d0ea937c..89e1f600ec78 --date=short --no-merges --format='%ad %ae %s'
2019-09-30 bungeman@google.com Improve implementations of copyTable.
2019-09-30 kjlubick@google.com Update gold aggregators to use new struct
2019-09-30 halcanary@google.com experimental/skottie_ios/SkottieMtkView: stopAtEnd option

Created with:
  gclient setdep -r src/third_party/skia@89e1f600ec78

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=rmistry@google.com
2019-09-30 12:02:12 -04:00
skia-flutter-autoroll
1ca97db31c
Roll fuchsia/sdk/core/mac-amd64 from ncc-K... to KH7Tv... (#12694)
Roll fuchsia/sdk/core/mac-amd64 from ncc-K... to KH7Tv...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-09-30 11:35:35 -04:00
Nurhan Turgut
a3a991aef1
Refactoring text_editing.dart (#12479)
* Refacting text_editing.dart to use EditingState more efficiently and removing unused/unimplemented code.

* Addressing PR comments. Comment changes. Removing unused methods. Method renaming.

* commiting text_editing_test.dart changes.
2019-09-30 08:26:28 -07:00
skia-flutter-autoroll
e068591272
Roll src/third_party/skia abc851eb3dcc..e242d0ea937c (2 commits) (#12693)
https://skia.googlesource.com/skia.git/+log/abc851eb3dcc..e242d0ea937c

git log abc851eb3dcc..e242d0ea937c --date=short --no-merges --format='%ad %ae %s'
2019-09-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/skia@e242d0ea937c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=rmistry@google.com
2019-09-30 08:12:31 -04:00
skia-flutter-autoroll
ae00dc066f
Roll src/third_party/skia 0e7500021402..abc851eb3dcc (3 commits) (#12692)
https://skia.googlesource.com/skia.git/+log/0e7500021402..abc851eb3dcc

git log 0e7500021402..abc851eb3dcc --date=short --no-merges --format='%ad %ae %s'
2019-09-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 7f506bde16f1..71c1138d6739 (6 commits)
2019-09-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 996b39934b3a..26279492794d (443 commits)
2019-09-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 6b4b8141e11d..faa2a365b5c0 (1 commits)

Created with:
  gclient setdep -r src/third_party/skia@abc851eb3dcc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=rmistry@google.com
2019-09-30 04:25:42 -04:00
skia-flutter-autoroll
c145694afc
Roll src/third_party/skia 7aeabcfa6a73..0e7500021402 (1 commits) (#12691)
https://skia.googlesource.com/skia.git/+log/7aeabcfa6a73..0e7500021402

git log 7aeabcfa6a73..0e7500021402 --date=short --no-merges --format='%ad %ae %s'
2019-09-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/skia@0e7500021402

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=rmistry@google.com
2019-09-30 00:36:14 -04:00
skia-flutter-autoroll
65103320b2
Roll fuchsia/sdk/core/linux-amd64 from eUBos... to sWs8N... (#12690)
Roll fuchsia/sdk/core/linux-amd64 from eUBos... to sWs8N...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-09-30 00:23:25 -04:00
skia-flutter-autoroll
8d6f008fb2
Roll fuchsia/sdk/core/mac-amd64 from VACNQ... to ncc-K... (#12689)
Roll fuchsia/sdk/core/mac-amd64 from VACNQ... to ncc-K...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-09-29 23:02:17 -04:00
skia-flutter-autoroll
c3b6ce0ff5
Roll fuchsia/sdk/core/linux-amd64 from OEG20... to eUBos... (#12688)
Roll fuchsia/sdk/core/linux-amd64 from OEG20... to eUBos...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-09-29 11:36:19 -04:00
skia-flutter-autoroll
90d88ef7bc
Roll fuchsia/sdk/core/mac-amd64 from 6fMRC... to VACNQ... (#12687)
Roll fuchsia/sdk/core/mac-amd64 from 6fMRC... to VACNQ...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-09-29 10:29:53 -04:00
skia-flutter-autoroll
5c791b980b
Roll src/third_party/skia be971636cf9b..7aeabcfa6a73 (3 commits) (#12686)
https://skia.googlesource.com/skia.git/+log/be971636cf9b..7aeabcfa6a73

git log be971636cf9b..7aeabcfa6a73 --date=short --no-merges --format='%ad %ae %s'
2019-09-29 kjlubick@google.com [SkParagraph] Require len if using addText(const char*)
2019-09-29 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version
2019-09-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/skia@7aeabcfa6a73

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=rmistry@google.com
2019-09-29 08:42:31 -04:00
skia-flutter-autoroll
58b2997444
Roll src/third_party/skia 2e856451654d..be971636cf9b (1 commits) (#12685)
https://skia.googlesource.com/skia.git/+log/2e856451654d..be971636cf9b

git log 2e856451654d..be971636cf9b --date=short --no-merges --format='%ad %ae %s'
2019-09-29 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps

Created with:
  gclient setdep -r src/third_party/skia@be971636cf9b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=rmistry@google.com
2019-09-29 04:53:37 -04:00
skia-flutter-autoroll
2c4cf6ae68
Roll fuchsia/sdk/core/linux-amd64 from lHiKM... to OEG20... (#12683)
Roll fuchsia/sdk/core/linux-amd64 from lHiKM... to OEG20...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-09-28 22:50:35 -04:00
skia-flutter-autoroll
78e537542d
Roll fuchsia/sdk/core/mac-amd64 from z3oH6... to 6fMRC... (#12682)
Roll fuchsia/sdk/core/mac-amd64 from z3oH6... to 6fMRC...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-09-28 21:56:14 -04:00
skia-flutter-autoroll
d5b392bbb6
Roll fuchsia/sdk/core/linux-amd64 from nVAcH... to lHiKM... (#12680)
Roll fuchsia/sdk/core/linux-amd64 from nVAcH... to lHiKM...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-09-28 10:06:31 -04:00
skia-flutter-autoroll
f9d9c3b04a
Roll fuchsia/sdk/core/mac-amd64 from Kiq-H... to z3oH6... (#12679)
Roll fuchsia/sdk/core/mac-amd64 from Kiq-H... to z3oH6...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-09-28 09:23:41 -04:00
skia-flutter-autoroll
73fa3c3bac
Roll src/third_party/skia bd84330ba277..2e856451654d (1 commits) (#12661)
https://skia.googlesource.com/skia.git/+log/bd84330ba277..2e856451654d

git log bd84330ba277..2e856451654d --date=short --no-merges --format='%ad %ae %s'
2019-09-28 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps

Created with:
  gclient setdep -r src/third_party/skia@2e856451654d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=bungeman@google.com
2019-09-28 04:12:39 -04:00
skia-flutter-autoroll
3e248cd6da
Roll src/third_party/skia 8ab1530cd3cd..bd84330ba277 (1 commits) (#12639)
https://skia.googlesource.com/skia.git/+log/8ab1530cd3cd..bd84330ba277

git log 8ab1530cd3cd..bd84330ba277 --date=short --no-merges --format='%ad %ae %s'
2019-09-28 reed@google.com Revert "Revert "add explicit src and dst colorspaces to filterColor4f""

Created with:
  gclient setdep -r src/third_party/skia@bd84330ba277

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=bungeman@google.com
2019-09-28 00:24:57 -04:00
skia-flutter-autoroll
0361c01ee3
Roll fuchsia/sdk/core/linux-amd64 from qx53U... to nVAcH... (#12620)
Roll fuchsia/sdk/core/linux-amd64 from qx53U... to nVAcH...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-09-27 21:21:11 -04:00
skia-flutter-autoroll
07aacf5de4
Roll fuchsia/sdk/core/mac-amd64 from oob8T... to Kiq-H... (#12616)
Roll fuchsia/sdk/core/mac-amd64 from oob8T... to Kiq-H...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-09-27 20:50:24 -04:00
skia-flutter-autoroll
897faab3a5
Roll src/third_party/skia 28ad6f869822..8ab1530cd3cd (5 commits) (#12614)
https://skia.googlesource.com/skia.git/+log/28ad6f869822..8ab1530cd3cd

git log 28ad6f869822..8ab1530cd3cd --date=short --no-merges --format='%ad %ae %s'
2019-09-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-27 bsalomon@google.com Remove vestiges of 32 float texture format support
2019-09-27 jvanverth@google.com Add gpu programmatic frame capture routines
2019-09-27 fmalita@chromium.org [skottie] Minimize top layer size

Created with:
  gclient setdep -r src/third_party/skia@8ab1530cd3cd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=bungeman@google.com
2019-09-27 20:37:26 -04:00
liyuqian
7c3dcee2e9
Revert "[fuchsia] Wire up OpacityLayer to Scenic (#11322)" (#12610)
This reverts commit fcc4ab32301396986dd5103d6d444bff35fe0f63.

Fixes https://github.com/flutter/flutter/issues/41394 and other
related correctness issues.

TBR: @arbreng @jason-simmons @mehmetf
2019-09-27 16:50:43 -07:00
gaaclarke
3c271bb942
Started asserting the FlutterEngine is running before communicating over channels. (#12469)
Started asserting the FlutterEngine is running before communicating
over channels.  This changes a null pointer exception to an
NSException that will provide some meaningful data to clients
incorrectly using the engine in an add-to-app situations.
2019-09-27 15:18:45 -07:00
gaaclarke
57f35d2763
Split out the logic to handle status bar touches into its own function (#12587)
Split out the logic to handle status bar touches into its own function.  This should make add-to-app clients' lives easier.
2019-09-27 15:10:28 -07:00
Ben Konyi
9fcef84492 Roll src/third_party/dart c3c31b74fd..132bee48d0 (16 commits)
dart-lang/sdk@132bee48d0 Revert "Reland "[vm, compiler] Reduce alignment of Instructions and remove some debugging trap instructions.""
dart-lang/sdk@134839098b Serialization/Deserialization for Variance in Type Parameters.
dart-lang/sdk@0829212a2a Add a way to map navigation target offsets to the edited content
dart-lang/sdk@605422c94e Flow analysis: Make TypeSystemTypeOperations public so it can be reused.
dart-lang/sdk@2cbaaba7ad Migration: add logic for converting a decorated type to its final post-migration form.
dart-lang/sdk@a46bb7cb5a Update dartdoc version in DEPS, extension methods support
dart-lang/sdk@61b4c0f770 Cleanup hints and lints in analyzer packages
dart-lang/sdk@fbea9d2e3c [vm] Fix use of Utils::Maximum in elf_loader.cc
dart-lang/sdk@a12c275901 [CFE] Avoid talking about const context in error messages.
dart-lang/sdk@349e861fd3 Enable urls for codes with recently published docs
dart-lang/sdk@6eaebb8463 Add navigation targets to the containing unit info
dart-lang/sdk@30b2a5dbb3 Update documentation for Function class.
dart-lang/sdk@9852c135a7 [vm] Fix Mac build.
dart-lang/sdk@85948bd799 [vm/elf] Run strip --strip-unneeded on ELF snapshots during testing.
dart-lang/sdk@a7cb8ee88b Revert "[vm] Wasm function imports"
dart-lang/sdk@ee1ab89987 [vm/infra] Fix compiler_configuration to use existing cross-compiler.
2019-09-27 14:46:45 -07:00
Kaushik Iska
6fcd795b4c
[flutter_runner] Refactor thread_application pair to ActiveApplication (#12573) 2019-09-27 13:38:25 -07:00
George Wright
d1901a2d15
Reword confusing messaging surrounding unhandled exception in flutter_runner on Fuchsia (#12428)
- Don't use 'unhandled' as that implies fatality which this is not
- Don't mention shutdown because this is not necessarily an exception-after-shutdown issue

Follow-up issue filed https://github.com/flutter/flutter/issues/41506 to implement the unit test for this.
2019-09-27 12:50:20 -07:00
skia-flutter-autoroll
dc9eb450c3
Roll src/third_party/skia b23d66e10a98..28ad6f869822 (10 commits) (#12580)
https://skia.googlesource.com/skia.git/+log/b23d66e10a98..28ad6f869822

git log b23d66e10a98..28ad6f869822 --date=short --no-merges --format='%ad %ae %s'
2019-09-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-27 reed@google.com Revert "add explicit src and dst colorspaces to filterColor4f"
2019-09-27 nifong@google.com Make move-assets obey SKIA_INFRA_ROOT
2019-09-27 benjaminwagner@google.com Switch to device_type dimension for iOS devices
2019-09-27 egdaniel@google.com Don't execute OpsTask which will have no effect on their target.
2019-09-27 mtklein@google.com add alternate gather() impl.
2019-09-27 reed@google.com add explicit src and dst colorspaces to filterColor4f
2019-09-27 fmalita@chromium.org [skottie] Fix skottie_tool anim null check logic
2019-09-27 herb@google.com Introduce SkIota a wrapper that adds an index
2019-09-27 bsalomon@google.com Use SW backend as ref for AsyncReadPixels unit test.

Created with:
  gclient setdep -r src/third_party/skia@28ad6f869822

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=bungeman@google.com
2019-09-27 15:41:55 -04:00
Kaushik Iska
ff5ccfe772
Revert "Update linux toolchain for fuchsia" (#12578)
This reverts commit 8d9e4411c08b00ee004e55e6ebc344f86383a46b.
2019-09-27 12:05:03 -07:00
Jonah Williams
6f5eb1332f
Add support for JIT release mode (#12446) 2019-09-27 11:20:54 -07:00
Kaushik Iska
b10b321904
Update linux toolchain for fuchsia (#12572) 2019-09-27 10:34:50 -07:00
Kaushik Iska
c25cdfee2b
Remove references to topaz (#12565)
* Add clangd directory to gitignore

* Remove references to TOPAZ_ from #ifdefs

We missed these in the migration.
2019-09-27 10:24:44 -07:00
Ben Konyi
123e85412b Roll src/third_party/dart 7901c508c8..c3c31b74fd (4 commits)
dart-lang/sdk@c3c31b74fd [parser] Fix bug wrt when the handleNonNullAssertExpression is added
dart-lang/sdk@3637e78014 Report inference failure on return types of typedefs and generic function types
dart-lang/sdk@40cc975932 Increase the severity of the unused_import hint (to a warning).
dart-lang/sdk@eac2eadff7 Stop using 'Element.type' in resolver.
2019-09-27 10:20:55 -07:00
skia-flutter-autoroll
6e12aa53b5
Roll src/third_party/skia 3787f51c65c3..b23d66e10a98 (1 commits) (#12559)
https://skia.googlesource.com/skia.git/+log/3787f51c65c3..b23d66e10a98

git log 3787f51c65c3..b23d66e10a98 --date=short --no-merges --format='%ad %ae %s'
2019-09-27 brianosman@google.com Interpreter: Lots of minor cleanup/refactoring

Created with:
  gclient setdep -r src/third_party/skia@b23d66e10a98

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=bungeman@google.com
2019-09-27 11:49:30 -04:00
skia-flutter-autoroll
59b7f0f040
Roll fuchsia/sdk/core/mac-amd64 from HoRV8... to oob8T... (#12538)
Roll fuchsia/sdk/core/mac-amd64 from HoRV8... to oob8T...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-09-27 08:19:07 -04:00
skia-flutter-autoroll
b8ff2fa9da
Roll fuchsia/sdk/core/linux-amd64 from YDv3O... to qx53U... (#12520)
Roll fuchsia/sdk/core/linux-amd64 from YDv3O... to qx53U...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-09-27 07:03:45 -04:00
skia-flutter-autoroll
7781884688
Roll src/third_party/skia 296743a86281..3787f51c65c3 (4 commits) (#12512)
https://skia.googlesource.com/skia.git/+log/296743a86281..3787f51c65c3

git log 296743a86281..3787f51c65c3 --date=short --no-merges --format='%ad %ae %s'
2019-09-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 f703443b1f67..7f506bde16f1 (9 commits)
2019-09-27 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps
2019-09-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 30d3c8afe19c..6b4b8141e11d (2 commits)
2019-09-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src fbc0a229ff3c..996b39934b3a (495 commits)

Created with:
  gclient setdep -r src/third_party/skia@3787f51c65c3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=bungeman@google.com
2019-09-27 05:49:23 -04:00
Ben Konyi
e31b2ff64d Roll src/third_party/dart 403c4af720..7901c508c8 (7 commits)
dart-lang/sdk@7901c508c8 [build] Enable ASAN leak detection during the build, not just tests.
dart-lang/sdk@75eb947bc8 [dart2js] New RTI: Support redirection in ruleset.
dart-lang/sdk@0c6249de26 [dart2js] New RTI: Remove converted closure classes from subtype metadata.
dart-lang/sdk@c1fdf3bde0 [dart2js] New RTI: Treat erased class type variables as dynamic.
dart-lang/sdk@e578b68b23 [dart2js] New RTI: Don't emit $as methods.
dart-lang/sdk@7a24aec8f4 [vm] Wasm function imports
dart-lang/sdk@1375e262be Minor NNBD fixes for type algebra and DartType.toString.
2019-09-26 23:41:47 -07:00
skia-flutter-autoroll
18bc0b2596
Roll src/third_party/skia b83cc76a5e3a..296743a86281 (1 commits) (#12491)
https://skia.googlesource.com/skia.git/+log/b83cc76a5e3a..296743a86281

git log b83cc76a5e3a..296743a86281 --date=short --no-merges --format='%ad %ae %s'
2019-09-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/skia@296743a86281

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=bungeman@google.com
2019-09-27 00:29:01 -04:00
Ben Konyi
ded1bacc01 Roll src/third_party/dart 327bc451f8..403c4af720 (9 commits)
dart-lang/sdk@403c4af720 Update dart_style to 1.3.1.
dart-lang/sdk@4a69ac1344 [vm, bytecode] Generate bytecode per package in fronend_server incremental compiles.
dart-lang/sdk@48f7636798 [ package:vm_service ] Added `HeapSnapshotGraph`, a helper class which parses the responses from the `HeapSnapshot` event stream.
dart-lang/sdk@7263b9aa9d [vm/fuzzer] rename dartfuzz_ffiapi
dart-lang/sdk@402951b399 Stop using 'Element.type' in ErrorVerifier.
dart-lang/sdk@1707aff921 [dart2js] Mark pkg/modular_test/test/validate_{pipeline,suite}_test as slow.
dart-lang/sdk@f0e5b380ab [build] Fix the depfile for gen_kernel_bytecode_dill
dart-lang/sdk@e6eafe20f7 Fix strict inference on overriding methods and setters.
dart-lang/sdk@5b33baded9 Migration: fix trial_migration.dart's handling of `required`
2019-09-26 20:43:48 -07:00
skia-flutter-autoroll
0b70151911
Roll fuchsia/clang/mac-amd64 from HfPKR... to zpVtV... (#12473)
Roll fuchsia/clang/mac-amd64 from HfPKR... to zpVtV...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-toolchain-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-09-26 21:48:49 -04:00
skia-flutter-autoroll
a206557f8f
Roll src/third_party/skia ec85f407bfee..b83cc76a5e3a (15 commits) (#12472)
https://skia.googlesource.com/skia.git/+log/ec85f407bfee..b83cc76a5e3a

git log ec85f407bfee..b83cc76a5e3a --date=short --no-merges --format='%ad %ae %s'
2019-09-26 mtklein@google.com Reland "hsw::S32_alpha_D32_filter_DX"
2019-09-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-26 mtklein@google.com reformat .gn files
2019-09-26 csmartdalton@google.com Reland "Remove the resolve rect and resolve types from GrRenderTarget"
2019-09-26 halcanary@google.com experimental/skottie_ios: Add methods to SkottieMtkView
2019-09-26 mtklein@google.com roll GN
2019-09-26 mtklein@google.com Revert "hsw::S32_alpha_D32_filter_DX"
2019-09-26 kjlubick@google.com [canvaskit] remove debugging code
2019-09-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-26 egdaniel@google.com Fix vulkan caps checks for external formats.
2019-09-26 robertphillips@google.com Add mipmap support to SkPixmap flavor of createBackendTexture
2019-09-26 csmartdalton@google.com Revert "Remove the resolve rect and resolve types from GrRenderTarget"
2019-09-26 kjlubick@google.com [canvaskit] Create SkFontMgr from passed in data
2019-09-26 mtklein@google.com hsw::S32_alpha_D32_filter_DX
2019-09-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/skia@b83cc76a5e3a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=bungeman@google.com
2019-09-26 20:41:18 -04:00