Adam Barth
b8953a4bbc
Fix Dart analyzer warnings in scaffold.dart
...
TBR=ianh@google.com
Review URL: https://codereview.chromium.org/1154013006
2015-05-28 16:55:09 -07:00
Adam Barth
8cbfd0a9fa
Split layout2.dart into several files
...
Previously layout2.dart was a thousand lines long.
R=ianh@google.com
Review URL: https://codereview.chromium.org/1161003002
2015-05-28 16:42:04 -07:00
Hixie
9f086ea445
Make RenderParagraph mutable, and make it fit the new RenderNode protocols
...
R=abarth@chromium.org , eseidel@chromium.org
Review URL: https://codereview.chromium.org/1165463002
2015-05-28 15:19:36 -07:00
Adam Barth
ad4249a804
Replace BoxDimensions with sky.Size
...
R=ianh@google.com
Review URL: https://codereview.chromium.org/1150253005
2015-05-28 14:29:29 -07:00
Adam Barth
aa8c852c06
Move simple_render_tree into tests as render_flex
...
R=ianh@google.com
Review URL: https://codereview.chromium.org/1146123003
2015-05-28 14:29:10 -07:00
Matt Perry
fb8596730c
Add an API to set the ColorFilter on a Paint object.
...
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/1158693005
2015-05-28 17:17:11 -04:00
Eric Seidel
7e7ed88f29
Add hello_fn2.dart and make Text("Hello fn2") actually render something.
...
R=ianh@google.com
Review URL: https://codereview.chromium.org/1160843005
2015-05-28 13:56:36 -07:00
Adam Barth
9a73fe989e
Introduce RenderProxyBox and RenderSizedBox
...
Also makes Point, Size, and Rect immutable.
R=ianh@google.com
Review URL: https://codereview.chromium.org/1162033002
2015-05-28 13:39:26 -07:00
Adam Barth
bf94f5c027
Use Point, Size, and Rect in layout2.dart
...
R=ianh@google.com
Review URL: https://codereview.chromium.org/1156303004
2015-05-28 12:42:54 -07:00
Eric Seidel
3971d9af9c
Remove bogus assert in layout()
...
TBR=ianh@google.com
Review URL: https://codereview.chromium.org/1157433006
2015-05-28 12:28:41 -07:00
Eric Seidel
faf554f03d
Move RenderParagraph into layout2.dart
...
TBR=ianh@google.com
Review URL: https://codereview.chromium.org/1155103003
2015-05-28 12:26:09 -07:00
Eric Seidel
108863ab95
Add a very simple RenderParagraph example using LayoutRoot.
...
I'm sure we'll want something more sophisticated in the near future.
Next step is to actually animate this updating layout.
R=ianh@google.com
Review URL: https://codereview.chromium.org/1150183005
2015-05-28 12:18:56 -07:00
Hixie
d99ee82260
Refactor layout/relayout into a single method.
...
This dramatically simplifies the layout model.
I haven't gone through and simplified the existing functions, we should probably go through and figure out if they can be cleaned up a bit.
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/1161983004
2015-05-28 11:15:58 -07:00
Eric Seidel
2cd0e5f4a0
Make app.dart not spew exceptions on mouse hover
...
app.dart assumes touch devices, which is great. We
just don't need to spam exceptions when testing inside
mojo_shell with a mouse. :)
R=jackson@google.com , ianh@google.com
Review URL: https://codereview.chromium.org/1160853003
2015-05-28 10:57:41 -07:00
Matt Perry
eaba0b981f
Add DartHandleCache and use it to cache strings used when converting Rect and
...
Point classes.
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/1145103005
2015-05-28 13:39:33 -04:00
Matt Perry
4ee1848817
Add operator==, hashCode, and toString for Rect, Point, and Size dart classes.
...
R=abarth@chromium.org , sethladd@google.com
Review URL: https://codereview.chromium.org/1154213005
2015-05-28 13:33:05 -04:00
Eric Seidel
3046acd9eb
Remove backface visibility
...
I made one edit in FrameView while looking at writing
RenderParagraph in Dart and then decided to look for
a slightly larger clean-up to justify committing it.
I found backface-visibility which I removed.
backface-visibility controls painting/hittesting of flipped objects.
https://developer.mozilla.org/en-US/docs/Web/CSS/backface-visibility
It's mostly used as a hack to get layers however. :)
TBR=abarth@chromium.org
Review URL: https://codereview.chromium.org/1161623004
2015-05-28 10:18:24 -07:00
Adam Barth
ae7e807f61
Flesh out Rect/Point/Size classes in dart:sky
...
R=mpcomplete@chromium.org
Review URL: https://codereview.chromium.org/1152213003
2015-05-28 09:42:17 -07:00
John McCutchan
f0c5ab0b82
Roll Dart forward
...
BUG=
R=eseidel@chromium.org
Review URL: https://codereview.chromium.org/1159443002
2015-05-28 07:45:06 -07:00
Collin Jackson
b5b6a10004
In Sky framework AppView, cache the hit test result for pointer events and continue using that result until pointerup or pointer cancel event is received
...
R=abarth@chromium.org , abarth
Review URL: https://codereview.chromium.org/1158933004
2015-05-27 17:49:14 -07:00
Hixie
26be5af114
Refactor padding out of RenderBlock.
...
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/1143153011
2015-05-27 17:11:45 -07:00
James Robinson
f0cf77ffaf
Move mojom definitions of URL{Request,Response} into SDK
...
This moves the definition of the mojom URLRequest and URLResponse
objects into the SDK at //mojo/public/interfaces/network/. These are
used directly by the shell and have a special place in the system. This
patch does the minimal amount of import/include updating to get tests
passing but doesn't fully update everything - in particular it
doesn't update all the C++ code that #includes url_loader.mojom.h for
the URLRequest or URLResponse definitions to #include the more specific
mojom.h files, or the equivalent in other languages. I'll do that in a
follow-up to minimize churn.
R=viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/1129063008
2015-05-27 17:07:51 -07:00
Adam Barth
a998a86caf
Introduce RenderNodeWithChildMixin
...
R=ianh@google.com
Review URL: https://codereview.chromium.org/1156013003
2015-05-27 14:31:08 -07:00
Adam Barth
1012325d88
DOM-less stocks app shouldn't crash on touch
...
R=ianh@google.com
Review URL: https://codereview.chromium.org/1162463002
2015-05-27 13:46:22 -07:00
Hixie
3cd544479f
remove debugging prints that snuck through
...
TBR=abarth
Review URL: https://codereview.chromium.org/1162443003
2015-05-27 13:42:50 -07:00
Hixie
63d5c73dd1
[Effen] port fn and stock to RenderNode, part 1 of many
...
This gets things off the ground barely enough to show some pixels.
These are not pixels that are actually part of the stock app, but
it's a start.
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/1157033006
2015-05-27 13:36:01 -07:00
James Robinson
52083cd919
Update to newer network service implementation and mojoms from monet
...
This updates to using the network service implementation and mojoms from
050294719fR=blundell@chromium.org , qsr@chromium.org , viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/1157783002
2015-05-27 13:24:56 -07:00
Matt Perry
1a07d29d7e
Sky: Add a DrawLooper interface to the painting API to be used for shadows.
...
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/1144193006
2015-05-27 16:22:01 -04:00
Ian Fischer
f89198557f
Make skydb --gdb work on mac.
...
R=eseidel@chromium.org
TBR=eseidel@chromium.org
Review URL: https://codereview.chromium.org/1155583006
2015-05-27 13:16:42 -07:00
Adam Barth
f179203848
Add support for testing content in SkyView
...
R=eseidel@chromium.org
Review URL: https://codereview.chromium.org/1160763004
2015-05-27 13:14:08 -07:00
Hixie
e2e68550af
Make RenderView support changing the root dynamically, including being null.
...
Remove the ScaffoldBox class (it'll move to the fn components directory).
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/1157563007
2015-05-27 12:25:34 -07:00
Hixie
ad87a6a82b
Fix compilation errors in render-sector.dart
...
TBR=abarth
Review URL: https://codereview.chromium.org/1153273002
2015-05-27 12:03:15 -07:00
Matt Perry
4139325e2c
Sky: Add a Point class.
...
Also, fix the style in Rect.cpp/.h.
R=eseidel@chromium.org
Review URL: https://codereview.chromium.org/1158843002
2015-05-27 14:40:02 -04:00
Eric Seidel
922ea790b8
Make it possible to draw Text in the new window/document-less world
...
I had to add back document.createText() since new Text()
does not work in the new world yet.
LayoutRoot is a new Dart-exposed class which holds the Frame and
all associated machinery, sufficient to trigger a restyle
and layout of the subtree.
This is all kinda hacky and I'm sure likely to cause many
crashes if folks call random methods on these disconnected
trees.
But this makes it at least possible to paint text for now
and we can improve this in the coming days.
This really should have Adam's review. It's hugely hacky
but I'd like to negotiate out with him the timeline on
which we should fix some of these hacks.
R=ianh@google.com
TBR=abarth@chromium.org
Review URL: https://codereview.chromium.org/1148253003
2015-05-27 11:05:42 -07:00
Hixie
bd110a8a8c
[Effen] Make syncChild() support the _new_ child being null.
...
This is needed for cases where the UINode doesn't have a list of
children (so it doesn't go through the RenderNodeWrapper sync logic
that removes children), but it still has multiple slots, and needs to
support removing nodes from those slots. (For example, removing a
drawer from a ScaffoldContainer.)
Also, expose syncChild (it used to be private) so it can be overridden
in descendants outside fn.dart.
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/1158563003
2015-05-27 11:00:40 -07:00
Hixie
e4ac84639e
[Effen] Expose various private members so that fn classes can exist outside fn.dart
...
This is needed to create a ScaffoldContainer in scaffold.dart.
This exposes:
UINode._root => root
UINode._removeChild => removeChild
RenderNodeWrapper._createNode => createNode
RenderNodeWrapper._emptyNode => emptyNode
RenderNodeWrapper._syncRenderNode => syncRenderNode
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/1148323004
2015-05-27 10:50:45 -07:00
Eric Seidel
eacb3bed6c
Add support for Mac vs. Linux sky_server builds
...
I also made sky_server get pulled down via DEPS
since thats how all the rest of our google storage-based
binaries work.
R=jamesr@chromium.org , jackson@google.com
TBR=abarth@chromium.org
Review URL: https://codereview.chromium.org/1150033006
2015-05-27 10:42:33 -07:00
Hixie
acdebf5520
Expose the RenderView root through the AppView, so that you can change it.
...
Also, attach the RenderView so that it actually updates during a flush layout.
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/1149063007
2015-05-27 10:42:02 -07:00
Hixie
f1b7dff0c7
Rearrange AppView so that the constructor is first.
...
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/1154403002
2015-05-27 09:47:11 -07:00
Hixie
85bf9d878c
[Effen] Point the stocks2 and components2 files at the forked libraries. (part II)
...
This was supposed to be in https://codereview.chromium.org/1153223003
TBR=abarth
Review URL: https://codereview.chromium.org/1160763003
2015-05-27 09:39:15 -07:00
Hixie
8789d0a312
Replace setBoxDecoration() with a decoration property. (part II)
...
This was supposed to be in https://codereview.chromium.org/1153893006/
TBR=abarth
Review URL: https://codereview.chromium.org/1151383003
2015-05-27 09:35:15 -07:00
Hixie
7adb9be998
Replace setBoxDecoration() with a decoration property.
...
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/1153893006
2015-05-27 09:30:25 -07:00
Hixie
bde2470ed6
[Effen] Point the stocks2 and components2 files at the forked libraries.
...
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/1153223003
2015-05-27 09:13:37 -07:00
Hixie
ad8d6de0d0
[Effen] Fork components/ since we'll be updating all the components before we're done.
...
Eventually this'll be merged back into components/, but we want to keep both running for now.
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/1158713007
2015-05-27 08:50:55 -07:00
Collin Jackson
39d005836a
Speed up shelldb by skipping unnecessary copies of APK to device
...
Right now I'm storing a SHA1 in a folder in /sdcard since
that seems likely to work on non-rooted devices, but
I haven't tested it.
This cuts build times from 6.5 seconds to 1.5 seconds for
me. You can save another 0.5sec by passing the --no_install
flag to avoid the SHA1 check altogether if you're sure
that nothing has changed.
R=eseidel@chromium.org , eseidel, hixie
Review URL: https://codereview.chromium.org/1149113005
2015-05-26 17:51:19 -07:00
Eric Seidel
2f3c23ed01
Fix dart:sky.internals to work in SkyView
...
R=ianh@google.com
TBR=abarth@chromium.org
Review URL: https://codereview.chromium.org/1156203003
2015-05-26 16:01:25 -07:00
Hixie
e0299f111b
[Effen] Fork stocks and fn.dart so we have something to work on during the porting process
...
R=eseidel@chromium.org
Review URL: https://codereview.chromium.org/1156543004
2015-05-26 12:53:08 -07:00
Hixie
b96da3b2ad
Rationalise hit testing in the new RenderNode world
...
- makes the event logic not involve a boolean return value (since we ignored it anyway)
- splits the event handling logic into two steps, hit testing and event dispatch
- introduces an App class on the Dart side to factor out the interaction with the C++ side
- ports sector-layout and simple_render_tree to the new App infrastructure
- port simple_render_tree to the new event handling logic
- implement hit testing for the sector-layout demo
R=eseidel@chromium.org
Review URL: https://codereview.chromium.org/1143343004
2015-05-26 12:44:35 -07:00
Collin Jackson
0991da0d06
Sky shelldb should restart app when using --no_install and forward observatory port
...
R=eseidel@chromium.org , eseidel
Review URL: https://codereview.chromium.org/1156993004
2015-05-26 11:16:08 -07:00
Collin Jackson
279cd62440
Clean up syntax as suggested by sethladd
...
R=sethladd@google.com , sethladd
Review URL: https://codereview.chromium.org/1159763003
2015-05-26 10:20:37 -07:00
