DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
20,087 Commits 882 Branches 1,069 Tags
Commit Graph

20087 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Hixie
878c984d39 Fix syntax error that resulted from badly converting a .forEach() to a for-in. 
TBR=abarth

Review URL: https://codereview.chromium.org/1169543009
 2015-06-08 10:05:08 -07:00
Hixie
76310148a0 Handle UINodes being moved around the Effen tree. 
Changes:
- Remove all the old tracing logic since that was a lot of code for
  just random printf debugging and nobody seems to use it
- Convert "defunct", a permanent state transition, to "mounted", a
  state that can be entered and exitted arbitrarily
- Coallesce mount/unmount notifications so there's only one per frame
- Remove handleRemoved() since we don't use it
- Rename a local variable 'parent' to 'ancestor' to avoid shadowing
  the field
- Replace uses of forEach() with for-in

Effects:
- Reusing a node provided to a constructor in a new place in a tree
  (especially at a different depth) no longer fails (it used to fail
  because the node would be marked defunct then remounted later, at
  which point it would fail)

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1169673002
 2015-06-08 09:59:25 -07:00
Collin Jackson
668e1e37ab Implement a simple checkbox in Sky’s fn2 components library 
R=abarth@chromium.org, abarth

Review URL: https://codereview.chromium.org/1161813005
 2015-06-05 14:51:37 -07:00
Eric Seidel
9af8d548e5 Make Text size to its content instead of always 100% width 
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1156383006
 2015-06-05 14:20:16 -07:00
Eric Seidel
0cbb319590 Stop leaking the TracingController's BroadcastReciever 
https://github.com/domokit/sky_sdk/issues/23

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1150263003
 2015-06-05 14:09:30 -07:00
Adam Barth
e6ad96e3e1 Don't crash when removing a radio button 
We were hitting an assert in RenderCustomPaint that the callback wasn't null.

R=eseidel@chromium.org, jackson@chromium.org

Review URL: https://codereview.chromium.org/1162023010
 2015-06-05 12:17:21 -07:00
Hixie
12aa568fc4 Export Point, Size, Rect, Color, Paint, Path, BoxDecoration, Border, BorderSide, EdgeDims, and FlexDirection from fn2.dart 
That way most of our libraries don't have to use sky.Foo all over the place, and we can reduce the number of imports in most Dart components.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1161323004
 2015-06-05 10:18:50 -07:00
Collin Jackson
18ab61e1ee Use an enum for Dart bindings for Skia Paint style 
R=abarth@chromium.org, abarth

Review URL: https://codereview.chromium.org/1171543002
 2015-06-05 10:12:45 -07:00
Adam Barth
247344193d Add the floating action button to stocks2 
The + isn't quite centered properly, but the button is a circle in the right
place.

R=eseidel@chromium.org, ianh@google.com

Review URL: https://codereview.chromium.org/1156383004
 2015-06-05 10:07:51 -07:00
Hixie
3cf7368d97 Silence a bunch of annoying bogus dartanalyzer warnings. 
- several places where we use a getter knowing that it will return a
   subclass of its declared type, even asserting that it does, but
   where the analyzer is worried that the getter might start returning
   a new value unexpectedly, solved by having a temporary local
   variable shadow the getter and asserting that it doesn't change
   value
 - many many places where we do this with parentData specifically,
   solved by type-erasing parentData.
 - a place where a mixin wants to be subclassing another class, and
   uses its methods, solved by saying that the mixin is abstract but
   implements the superclass

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1160923008
 2015-06-05 09:44:09 -07:00
Adam Barth
9ea7ac504c Expose _remove from fn2 
Turns out Scaffold needs to hook _remove, so we need to rename it to remove to
expose it outside fn2.dart.

R=ianh@google.com

Review URL: https://codereview.chromium.org/1160013007
 2015-06-05 09:03:23 -07:00
Benjamin Lerman
f276f4f149 Update network service. 
R=blundell@chromium.org

Review URL: https://codereview.chromium.org/1153933003
 2015-06-05 14:57:32 +02:00
Collin Jackson
45cbbc0fae Implement radio button for Sky’s fn2 
R=abarth@chromium.org, eseidel@chromium.org, abarth

Review URL: https://codereview.chromium.org/1157573012
 2015-06-04 17:24:38 -07:00
Viktor Lidholt
b91b750436 Adds a spaceship and (somewhat crappy) controls to the example game. 
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1151793003
 2015-06-04 17:14:46 -07:00
Eric Seidel
a2ae29cb40 Various fixes in preparation for deploying 
Fixed the mojo deploy script to no longer deploy mojo.
mojo now uses a more sophisticated CDN, etc.

Fixed old fn.dart to work again. :)  Looks like it was
victim of a mass rename.

Fixed engine.cc to be able to handle navigating from
WebView content to SkyView content.  We can't handle
the other direction yet, but we don't need to.
/sky_home is written in the .sky system but all of our
new examples are .dart (and thus SkyView).

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1165003006
 2015-06-04 16:48:09 -07:00
Adam Barth
689dc9844e stock2 should actually show some stocks data 
We're having trouble shrinkwrapping text, so this CL sets an explicit size for
the last sale and the change in price.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1164763006
 2015-06-04 16:35:56 -07:00
Hixie
96aadc99b4 Rename "BorderSide.None" to "BorderSide.none", since it's a constant, and change the sky.Size.infinite() constructor to a constant. 
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1158263005
 2015-06-04 16:17:20 -07:00
Hixie
10cda2fe28 Include DETACHED, NEEDS-LAYOUT, and relayoutSubtreeRoot info in the debug output for the render tree 
R=chinmaygarde@google.com

Review URL: https://codereview.chromium.org/1149083011
 2015-06-04 15:58:43 -07:00
Adam Barth
c5c3f31a17 Make the StockList actually work in stocks2 
RenderScaffold needs to attach and detach its children when asked.

R=eseidel@chromium.org, ianh@google.com

Review URL: https://codereview.chromium.org/1149893025
 2015-06-04 15:50:07 -07:00
Hixie
9b0cb975cb Improve the RenderObject.toString() logic so that there's not blank lines everywhere and to generally be better. 
Adds sizes, positions, transforms, improves RenderParagraph's output.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1160233004
 2015-06-04 15:45:44 -07:00
Eric Seidel
59f352c735 Fix examples/game to work after Hixie's grand rename. 
TBR=viktorl@google.com

Review URL: https://codereview.chromium.org/1158273009
 2015-06-04 15:25:46 -07:00
Eric Seidel
ca3b643ca9 Start making input work 
Does not work yet.

R=ianh@google.com

Review URL: https://codereview.chromium.org/1163973005
 2015-06-04 15:18:09 -07:00
Adam Barth
4674ab6ff8 Prepare StockList for use in stocks2 
This CL does a bunch of ground work for getting StockList ready for use in
stocks2. It's still not quite working because of an interaction with Scaffold
that we don't fully understand.

R=eseidel@chromium.org, ianh@google.com

Review URL: https://codereview.chromium.org/1148793005
 2015-06-04 15:10:09 -07:00
Adam Barth
bd7af16cf5 Make fetch work in the DOM-less world 
R=eseidel@chromium.org, ianh@google.com

Review URL: https://codereview.chromium.org/1166953005
 2015-06-04 15:00:08 -07:00
Adam Barth
b3a9abd09b Fix bogus asserts in searchForOldNode 
We should be asserting that old.root is a ContainerRenderObjectMixin because
we're able to manipulate its child list.

R=ianh@google.com

Review URL: https://codereview.chromium.org/1169593002
 2015-06-04 14:59:46 -07:00
Eric Seidel
54d01bc005 Attempt to write a RenderShadowedBox 
The goal of this is to have a Renderer-layer abstraction
around the Sky Engine c++ apis for drawing a shadow.

R=mpcomplete@chromium.org

Review URL: https://codereview.chromium.org/1146893004
 2015-06-04 14:49:24 -07:00
Hixie
67d883c506 We don't necessarily have a child, so debugDescribeChildren() needs to check for null. 
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1151533006
 2015-06-04 14:30:17 -07:00
Hixie
77ef219796 Fix some minor warnings from the analyzer in the framework. 
R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1162623011
 2015-06-04 14:11:02 -07:00
Hixie
8ee5aa0bc6 Give RenderObject a useful toString(). 
This makes debugging the render tree a lot easier. Just print the node
you care about, and you get an indented tree view of its subtree,
including settings. New subclasses should implement the new virtual
method debugDescribeSettings() to expose new settings.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1157993005
 2015-06-04 14:10:07 -07:00
Adam Barth
0fcbeef342 Make FixedHeightScrollable understand heights 
This CL makes FixedHeightScrollable able to measure heights. In the DOM-based
version, FixedHeightScrollable forced a synchronous layout in a microtask in
order to measure the size of itself and its children. In the DOM-less version,
we now require the subclass to tell us the item height and we measure our own
height using a layout callback.

R=ianh@google.com

Review URL: https://codereview.chromium.org/1161063005
 2015-06-04 13:42:16 -07:00
Collin Jackson
31f8f740d1 Implement menu_divider 
R=abarth@chromium.org, abarth

Review URL: https://codereview.chromium.org/1163913004
 2015-06-04 13:11:40 -07:00
Hixie
6a0d1ffb2f Style guide says enum values should be lowerCamelCase. 
https://www.dartlang.org/articles/style-guide/#names

R=jackson@google.com

Review URL: https://codereview.chromium.org/1158813004
 2015-06-04 12:24:10 -07:00
Matt Perry
e584f258fe Fix regression in RenderTransform caused by change to Canvas.concat. 
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1169583002
 2015-06-04 14:31:19 -04:00
Hixie
9706fc588f Assert that you can't mutate the tree during paint or layout. 
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1144933007
 2015-06-04 11:14:39 -07:00
Adam Barth
22b39a9f88 Add RenderClip and use it in FixedHeightScrollable 
In the future, we might want to extend this class to clip to a configurable
rect in addition to clipping to its bounds.

R=eseidel@chromium.org, ianh@google.com

Review URL: https://codereview.chromium.org/1145263006
 2015-06-04 11:14:30 -07:00
Hixie
c023507973 Rename OneChildListRenderObjectWrapper to MultiChildRenderObjectWrapper to avoid the confusing similarity with OneChildRenderObjectWrapper. 
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1150543005
 2015-06-04 11:14:18 -07:00
Viktor Lidholt
2d8240aa75 Adds support for transfer mode in Paint and SpriteNode classes. Adds support for opacity in sprites, and modifies example game. 
R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1164633004
 2015-06-04 11:14:07 -07:00
Collin Jackson
ab90994194 Stub out InkWell and implement Sky’s fn2 menu item 
R=abarth@chromium.org, ianh@google.com, abarth, hixie

Review URL: https://codereview.chromium.org/1165983002
 2015-06-04 11:04:01 -07:00
Adam Barth
4491168fcb Make FixedHeightScrollable mostly work in fn2 
We still need to add a clip and a way to integrate with layout, but those
changes are more invasive and I'll do them in separate CLs.

R=eseidel@chromium.org, ianh@google.com

Review URL: https://codereview.chromium.org/1166983003
 2015-06-04 10:52:12 -07:00
Matt Perry
8afcb0fe2d Canvas.concat takes a 16-element Float32List instead of an array. 
The array should be in column-major format, in the format used by vector_math.dart.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1155193004
 2015-06-04 13:51:44 -04:00
Hixie
08b2a30e0f Enable RenderDecoratedBox to draw borders. 
Currently supports only solid borders, but of any colour and size, independently controlling each side.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1154903006
 2015-06-04 10:50:59 -07:00
Adam Barth
05c7ca6bef Fix build after hixie's rename 
TBR=ianh@google.com

Review URL: https://codereview.chromium.org/1164073002
 2015-06-04 10:49:05 -07:00
Hixie
8e34567652 Rename RenderNode to RenderObject. 
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1165013003
 2015-06-04 10:45:21 -07:00
Hixie
04f10fbf64 Fix the crash when the drawer is hidden. 
The root cause of the crash was threefold:
 - you can't enumerate enums, in dart; you have to enumerate their values.
 - RenderNodeWrapper was trying to call remove(child.root) on its root, but that's
   not something that all RenderNodes have
 - when a RenderNode was deparented, its relayoutSubtreeRoot wasn't removed, so
   the node ended up in an inconsistent state regarding its parent tree

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1151573020
 2015-06-04 10:39:34 -07:00
Seth Ladd
ba9af31ed9 Add the sky sdk README back. 
Was removed in 1a396394dd

R=eseidel@chromium.org, johnmccutchan@google.com

Review URL: https://codereview.chromium.org/1159013011
 2015-06-04 09:13:15 -07:00
Adam Barth
6d7a850e25 Remove outdated copy of download_material_design_icons 
The current copy is in //sky/sdk/lib.

TBR=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1160393003
 2015-06-04 08:43:00 -07:00
Hixie
0e06bfbee0 Make EdgeDims and BoxConstraints printable (for debugging) 
R=jackson@google.com

Review URL: https://codereview.chromium.org/1166523006
 2015-06-03 17:24:31 -07:00
Eric Seidel
8d52fb51dc Make Icon work using space-aged base-url technology. 
I also moved Icon back to using int, since double doesn't
actually make sense for an icon pixel size.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1164023005
 2015-06-03 17:16:12 -07:00
Adam Barth
05a7ed066c Rename skydb to mojodb 
The skydb tool is actually used to run many mojo apps that aren't related to
Sky.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1164023004
 2015-06-03 17:03:42 -07:00
Adam Barth
1e9184d282 Make Uri.base work in SkyView 
R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1153673005
 2015-06-03 17:00:44 -07:00