This patch makes the sdk_xcode_harness work the same way as
hello_services. The goal is to eventually make these the same, but this
is just a first step.
The logic was reversed -- we should only go into fullscreen if the
user didn't specify a TOP overlay, and we should only hide the
system ui navigation if the user didn't specify a BOTTOM overlay.
This patch makes the FlutterViewController interface more idiomatic by not
retaining listeners. It's the callers responsibility to make sure the lifetimes
work out.
I gave up before I was completely done.
Items still remaining include:
* drawVertices
* drawAtlas
* TransferMode.*
* VertexMode
Also:
* Add a convenience constructor to RSTransform
* Add some convenience methods to Rect and Size
* Make some defaults more explicit
am: b4bbae3202
* commit 'b4bbae320244d949d1f7766916919cbb3a6e72f3':
Do not break after Myanmar viramas
Change-Id: I69972aed4fe1c1b956c0b65af18e1a4f1c739bf4
am: 00de2cc363
* commit '00de2cc3631df7ee3d755956bbf4ec6812d5517f':
Do not break after Myanmar viramas
Change-Id: I2e240fab84a49c73165056ee5ff18dbfca0faeec
am: 74b56175e5
* commit '74b56175e5d41c1c1dc992208842b5576973d452':
Do not break after Myanmar viramas
Change-Id: I13297120c3c3789c03b860c9e72b3a04922ab9fa
am: 74b56175e5
* commit '74b56175e5d41c1c1dc992208842b5576973d452':
Do not break after Myanmar viramas
Change-Id: Idb9303889ac87853a730cdb25fba7faaaf352b93
This is to work around a bug in ICU's line breaker, which thinks
there is a valid line break between a Myanmar kinzi and a consonant.
See http://bugs.icu-project.org/trac/ticket/12561 for the ICU bug.
Bug: 28964845
Change-Id: I076ac15077e5627cbccf6732900bcc60d8596dda
Switch sdk_xcode_harness to use flutter build aot
This patch moves a bunch of complexity out of FlutterApplication.xcodeproj and
into `flutter build aot`, which will make it easier for developers to create
their own FlutterApplication.xcodeproj.
This addresses the following cppcheck reports:
[frameworks/minikin/app/HyphTool.cpp:30]: (error) Resource leak: f
[frameworks/minikin/app/HyphTool.cpp:32]: (error) Resource leak: f
Change-Id: I5113e0a7268bd3a45bf1498fd023042d9dfe2b87
* Create an Xcode project template for dynamic service creation.
The `create_native_service_sdk.py` will be run on the buildbot similar
to `create_ios_sdk.py`. This will create an Xcode project with both arm
and x64 assets that the user can use to fill in the service
implementation.
* Add the complete_static_lib property to sdk_lib_archive in
dynamic/BUILD.gn
It crashes. We either need to make it safe to call before
Dart_Initialize on Mac or we need to use some other way of measuring
startup time.
Fixes#4006
