6580 Commits

Author SHA1 Message Date
Jason Simmons
574b2829c8 Update the sky_snapshot command line args to match the latest engine (#5273) 2016-08-05 15:55:43 -07:00
Bob Nystrom
b504fd428c Fix covariant overrides in SynchronousFuture. (#5262)
* Fix covariant overrides in SynchronousFuture.

There were two things going on here. In timeout(), the callback's return
type was needlessly tightened to only allow callbacks that return
futures. This makes SynchronousFuture not substitutable with Future,
whose timeout() allows callbacks that return immediate values.

Since SynchronousFuture.timeout() never calls the callback anyway, I
just loosened it to match Future.timeout().

SynchronousFuture.whenComplete() is just wrong. The type error, again,
is that the callback's return type is too tight. Future.whenComplete()
allows synchronous callbacks.

But the actual implementation is wrong as well. whenComplete() should
return a future that completes to the *original value*, not whatever the
callback returns.

So I just fixed the method to work correctly, including handling
callbacks with synchronous results.

* "(error, stackTrace)" -> "(e, stack)".
2016-08-05 15:18:07 -07:00
Chinmay Garde
21ee4b92f1 Specify the IPHONEOS_DEPLOYMENT_TARGET to 8.0. (#5268)
* Update examples to lower the deployment target on iOS.
2016-08-05 14:56:07 -07:00
Devon Carew
ce9fcb029f remove the resident cli option (#5263) 2016-08-05 14:16:46 -07:00
Ian Hickson
84cbefe2d4 Revert "When a list is scrolling, children can't be tapped" (#5264) 2016-08-05 13:42:55 -07:00
Todd Volkert
435ad476d8 Add --all-platforms option to flutter precache (#5254) 2016-08-05 13:11:47 -07:00
Hans Muller
eebe09d402 Set the ScrollConfiguration for dropdown menus (#5255) 2016-08-05 12:57:29 -07:00
Bob Nystrom
47139f1da9 Fix a couple of covariant overrides in Expression. (#5257)
It was widening the return type of a couple of operators compared to
what EquationMember declared it should return. Since it did in fact
always return an Expression, the widening wasn't needed.

This just tightens them to match the base class.
2016-08-05 12:16:58 -07:00
John McCutchan
81b4e827e1 Split hot run mode into a separate file (#5233) 2016-08-05 12:04:33 -07:00
Ian Hickson
ea7d5bf291 When a list is scrolling, children can't be tapped (#5222) 2016-08-05 10:40:24 -07:00
Matt Perry
260cfcdb7b Pesto: Prevent overscrolling on recipe page. (#5237)
BUG=https://github.com/flutter/flutter/issues/5098
2016-08-05 13:37:27 -04:00
Hans Muller
4a8dbb0e13 Add a repaint boundary to the cards on the shrine order page (#5251) 2016-08-05 10:02:53 -07:00
Eric Seidel
5a0589c781 Remove stray PRODUCT_BUNDLE_IDENTIFIER (#5242)
* Remove stray PRODUCT_BUNDLE_IDENTIFIER

This was erroneously added and overrides
the bundle for the gallery causing signing
to fail in my setup.

@chinmaygarde

* Remove PRODUCT_BUNDLE_IDENTIFIER from all Runner pbxproj's
2016-08-05 10:00:50 -07:00
Eric Seidel
ac9ab0c9d6 Update Gallery icons to have a white background. (#5252)
I took the logo_square from:
https://github.com/flutter/identity-assets/tree/master/assets/logo_square
Opened it in preview, gave it a white background
and then dropped it in the icon tool to create
these updated icons.

We may want to use offwhite like we did for Android
but this is sufficient for my demo today.

@hansmuller
2016-08-05 10:00:12 -07:00
Adam Barth
d321ce352e Disable parallax in gallery home header (#5250)
We don't yet know how to do this without poping during hero animations.
2016-08-05 09:59:17 -07:00
Adam Barth
4cc094ac9f Remove pop in AppBar hero animations (#5243)
Now the flexible space bar computes its effect from its size rather than from
the Scaffold's animation.
2016-08-05 09:30:45 -07:00
Collin Jackson
d2b3976110 Alter iOS template project to be CocoaPods enabled (#4893) 2016-08-05 09:17:13 -07:00
Hans Muller
4fe80830ca Use updated appbar background assets (#5248) 2016-08-05 09:02:34 -07:00
Adam Barth
7fd3691076 Heroes in flight shouldn't be interactive (#5246)
After this patch, they ignore pointers.
2016-08-05 08:43:16 -07:00
Adam Barth
326bb21278 Update engine.version (#5247) 2016-08-05 00:16:44 -07:00
Adam Barth
b342f2c40c Update engine.version (#5244) 2016-08-04 18:04:00 -07:00
Hans Muller
4770acebd1 updated Android launcher icons (#5238) 2016-08-04 15:35:26 -07:00
Matt Perry
92d0445a8f Add a fade-in animation for the text selection controls. (#5190)
BUG=https://github.com/flutter/flutter/issues/3938
2016-08-04 16:51:09 -04:00
Adam Barth
40d26f433e Update engine.version (#5221) 2016-08-04 13:05:43 -07:00
Adam Barth
628884a8a8 Make AppBar a Hero (#5214)
This patch improves the Post and Shrine transitions by making the AppBar
into a Hero and changing the default MaterialPageTransition. Now the
AppBar transitions smoothly between screens and the
MaterialPageTransition doesn't involve a fade effect.

Also, rejigger the bounds of the image header in Pesto to avoid the
"pop" at the end of the animation by laying out the image header at its
final visual size instead of relying on occlusion to size the image
header.

Fixes #5202
Fixes #5204
2016-08-04 13:05:18 -07:00
Matt Perry
8f3c498f2d Initialize ScrollBehavior's content size to infinite rather than 0. (#5199)
Why this matters: If you navigate back to a page with a Scrollable that
has a nonzero scrollOffset, we will restore that scrollOffset. We clamp
the scrollOffset to the contentExtent before the first layout, before
contentExtent is updated to its proper value. Initializing contentExtent
to INFINITY effectively disables the first clamp, until we can get a
valid value from layout. Since the previous scrollOffset was valid, it
seems safe to assume it's still valid.

BUG=https://github.com/flutter/flutter/issues/4883
BUG=https://github.com/flutter/flutter/issues/4797
2016-08-04 15:46:24 -04:00
Hans Muller
3a7508d702 New gallery identity (#5210) 2016-08-04 11:07:59 -07:00
Chris Bracken
0ba0127c1a Support a user-specified observatory port in CoverageCollector (#5217) 2016-08-04 10:43:04 -07:00
Jason Simmons
f8a80b1da6 Notify a Scrollable that the associated animation has stopped (#5209)
This also required changing the AnimationController state transition
logic to signal completion of the animation during the tick that
finishes the simulation.

Fixes https://github.com/flutter/flutter/issues/3675
2016-08-04 10:26:35 -07:00
Jason Simmons
b87cc8b14c Handle disposal of a HeroState while a hero is animating (#5189)
Fixes https://github.com/flutter/flutter/issues/5178
2016-08-04 10:26:26 -07:00
Adam Barth
22210c8baf Dispose AnimationController in examples (#5207)
These examples should show the best practices for working with
AnimationControllers.

Fixes #5206
2016-08-04 08:55:59 -07:00
Chris Bracken
88536859b4 Correct style in finalizeCoverage parameter list (#5213) 2016-08-03 19:54:33 -07:00
Chris Bracken
a1fa7c94e3 Support passing a custom coverage formatter to finalizeCoverage() (#5208) 2016-08-03 16:58:47 -07:00
Ian Hickson
1aeea6263a Fix some misuse of types (#5197)
Thanks to @leafpetersen for catching these.
2016-08-03 13:18:41 -07:00
Ian Hickson
c8db0041d8 Add debugPrintTransientCallbackRegistrationStack (#5198)
Adds Scheduler.debugPrintTransientCallbackRegistrationStack so that you
can find out how your current callback got registered.
2016-08-03 13:18:02 -07:00
Ian Hickson
d7fb51a551 Hot reload UI polish (#5193)
* General improvoments to the loader app:
   * Show a message after 8 seconds if no connection comes in.
   * Show a progress bar as files are being uploaded.
   * Hide the spinner just before launching the application.

* General improvements to the "flutter run" UI:
   * Add "?" key as a silent alias for "h".
   * Make the help text bold so it doesn't get mixed with the logs.
   * Make "R" do a cold restart when hot reload is enabled.

* Supporting features and bug fixes:
   * Add support for string service extensions.

* Other bug fixes:
   * Expose debugDumpRenderTree() outside debug mode.
   * Logger.supportsColor was missing a getter.
   * Mention in the usage docs that --hot requires --resident.
   * Trivial style fixes.
2016-08-02 16:52:57 -07:00
Jason Simmons
5c2623d977 Fix overflow of text on Pesto recipe cards (#5192) 2016-08-02 16:31:46 -07:00
Jason Simmons
39be1c3747 Tell image listeners if they are being called synchronously by the ImageStream (#5161)
Image listeners installed in paint handlers need to know whether the listener
is being called during the paint.

Fixes https://github.com/flutter/flutter/issues/4937
2016-08-02 16:07:21 -07:00
Hans Muller
2656006c41 OverscrollIndicator tracks horizontal drag input, etc (#5183) 2016-08-02 15:58:02 -07:00
Chinmay Garde
64fa825ba1 Update engine to pull in fixes for crashes related to accessibility. (#5184) 2016-08-02 14:38:06 -07:00
Adam Barth
4086e7a3c3 Improve performance of Pesto hero animation (#5182)
Previously we were resizing a paragraph of text during the animation. Now we
animate the text and the image separately. Also, add a default hero tag for
FloatingActionButton so that it animates as part of the hero transition as
well.
2016-08-02 11:35:15 -07:00
Adam Barth
82b7fc0d95 Update engine.version (#5179) 2016-08-01 21:12:20 -07:00
Seth Ladd
b34b453c6c Docs colors logo (#5176)
* update the color and logo for the docs site

* update the color and logo for the docs site

* remove unused file

* removed unused script code

* tweak styles for inherited names
2016-08-01 15:43:10 -07:00
Hans Muller
56a2d2262c Pesto home stack (#5168) 2016-08-01 15:09:50 -07:00
Adam Barth
fb3e64cce4 Add a semantic version for Flutter (#4923)
This patch starts a semantic versioning scheme for Flutter. We're still
experimenting with semantic versioning, which means the version number
might not be reliable yet.
2016-08-01 14:15:37 -07:00
Ian Hickson
735120f113 Extract applyImageFit logic. (#5158)
Also, add FractionalOffset.inscribe.
2016-07-29 16:52:42 -07:00
Dragoș Tiselice
f3444fcf28 Added BorderRadius. (#5072)
* Added custom radii to RRect.

This is the first commit towads an implementation of
MergeableMaterial. It adds custom radii to RRect.

* Renamed RRect constructors and added BorderRadius.

BorderRadius is a class similar to EdgeInsets that lets you define
all rounded corners of a rounded rectangle easily.
2016-07-29 16:17:57 -07:00
Ian Hickson
51f8fb9979 Add a scrollbar to the license screen. (#5114)
And make Scrollbar work with LazyBlock.

And an about box to the Stocks sample app.
2016-07-29 15:44:12 -07:00
Jason Simmons
2b3099c814 Always select a diagonal for ArcTween even if begin and end rects are equal (#5151)
Fixes https://github.com/flutter/flutter/issues/5086
2016-07-29 15:28:40 -07:00
Matt Perry
f59d04bfab Remove drawer history entry when drawer is disposed. (#5157)
BUG=https://github.com/flutter/flutter/issues/5103
2016-07-29 15:22:49 -07:00