DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Always select a diagonal for ArcTween even if begin and end rects are equal (#5151)

Browse Source 
Fixes https://github.com/flutter/flutter/issues/5086
This commit is contained in:
Jason Simmons 2016-07-29 15:28:40 -07:00 committed by GitHub
parent f59d04bfab
commit 2b3099c814
2 changed files with 20 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
packages/flutter/lib/src/foundation/basic_types.dart
View File

@ -243,3 +243,21 @@ class _LazyListIterator<E> implements Iterator<E> {
return true;
}
}
// COLLECTION UTILITIES
typedef dynamic KeyFunc<T>(T input);
/// Select the element for which the key function returns the maximum value.
dynamic/*=T*/ maxBy/*<T>*/(Iterable<dynamic/*=T*/> input, KeyFunc/*<T>*/ keyFunc) {
dynamic/*=T*/ maxValue;
dynamic maxKey;
for (dynamic/*=T*/ value in input) {
dynamic key = keyFunc(value);
if (maxKey == null || key > maxKey) {
maxValue = value;
maxKey = key;
}
}
return maxValue;
}

10
packages/flutter/lib/src/material/arc.dart
View File

@ -5,6 +5,7 @@
import 'dart:math' as math;
import 'dart:ui' show hashValues, lerpDouble;
import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';
import 'package:meta/meta.dart';
@ -165,14 +166,7 @@ class MaterialRectArcTween extends RectTween {
@required Rect end
}) : super(begin: begin, end: end) {
final Offset centersVector = end.center - begin.center;
double maxSupport = 0.0;
for (_Diagonal diagonal in _allDiagonals) {
final double support = _diagonalSupport(centersVector, diagonal);
if (support > maxSupport) {
_diagonal = diagonal;
maxSupport = support;
}
}
_diagonal = maxBy(_allDiagonals, (_Diagonal d) => _diagonalSupport(centersVector, d));
_beginArc = new MaterialPointArcTween(
begin: _cornerFor(begin, _diagonal.beginId),
end: _cornerFor(end, _diagonal.beginId)