Chris Bracken
be9dbfa994
[Linux] Use up_client_get_devices2 when possible ( #127699 )
...
The Linux platform channels sample makes a call to the libupower function `up_client_get_devices`, which was deprecated in libupower 0.99.8 in favour of `up_client_get_devices2`.
In order to build both for users on older versions of libupower, such as 0.99.7, which ships with Ubuntu 18.04 (Bionic), as well as users on newer versions where `up_client_get_devices` is deprecated, this adds a preprocessor check and selects the function available on the host system on which the build takes place.
The Flutter devicelab prod bots have been migrated to Ubuntu 20.04 LTS (Focal) which includes 0.99.11, but the trybots are still in the process of being migrated. This allows the build to work on both, and makes life easier for users running on a variety of Linux distributions.
No tests are added or modified since `up_client_get_devices` and `up_client_get_devices2` have the same semantics.
See: https://upower.freedesktop.org/docs/UpClient.html#up-client-get-devices
See: https://gitlab.freedesktop.org/upower/upower/-/blob/master/libupower-glib/up-version.h.in
Note: the `UP_CHECK_VERSION` macro has been around since 2010 (13 years ago), when DKP was forked into libupower. 27fada20behttps://github.com/flutter/flutter/issues/127611
2023-05-26 19:19:04 +00:00
engine-flutter-autoroll
51d6de186c
Roll Flutter Engine from 84f2fc16e55d to ec7b0ae3599f (3 revisions) ( #127698 )
...
84f2fc16e5...ec7b0ae359godofredoc@google.com Checkout android and emsdk deps in linux. (flutter/engine#42339 )
2023-05-26 110993981+htoor3@users.noreply.github.com [web] - Fix autofill group input ordering (flutter/engine#42268 )
2023-05-26 skia-flutter-autoroll@skia.org Roll Skia from 1622df035714 to ac897edeb16a (1 revision) (flutter/engine#42348 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-26 19:17:14 +00:00
fzyzcjy
c1558f6979
Fix TextField error in production environment because it wrongly uses ancestor render boxes ( #126324 )
...
Fixes a crash in a reparented TextField due to frame render phase timing
2023-05-26 10:49:37 -07:00
Jonathan Green
28605398ec
Interactive viewer doesn't appear to respect the trackpadScrollCausesScale parameter ( #127114 )
...
Fix a bug when using InteractiveViewer.trackpadScrollCausesScale
2023-05-26 10:45:56 -07:00
Casey Hillers
a655b05752
Remove release timeline ( #127685 )
...
Fixes https://github.com/flutter/flutter/issues/127592
2023-05-26 17:41:13 +00:00
engine-flutter-autoroll
8f09fa5d82
Manual roll Flutter Engine from 8573f3b63a1f to 84f2fc16e55d (7 revisions) ( #127676 )
...
Manual roll requested by zra@google.com
8573f3b63a...84f2fc16e5zanderso@users.noreply.github.com Revert Dart SDK to 398e847c0b24ad2e57194844410613b7dadcb74f (flutter/engine#42347 )
2023-05-26 jason-simmons@users.noreply.github.com Apply the drawShadow bounds workaround to the Web HTML backend (flutter/engine#42304 )
2023-05-26 skia-flutter-autoroll@skia.org Roll Dart SDK from f17b745f5c3c to 398e847c0b24 (1 revision) (flutter/engine#42345 )
2023-05-26 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from AgIKKqtBtb6RJnyI9... to c6-zqvlx2YtyGwGzJ... (flutter/engine#42344 )
2023-05-26 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from DNwJQMQZladAsKTjv... to 9aZkaKhX4GslPUnbX... (flutter/engine#42343 )
2023-05-26 skia-flutter-autoroll@skia.org Roll Skia from 7e20e6679785 to 1622df035714 (1 revision) (flutter/engine#42342 )
2023-05-26 skia-flutter-autoroll@skia.org Roll Dart SDK from bc65e3f5efa0 to f17b745f5c3c (1 revision) (flutter/engine#42341 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from DNwJQMQZladA to 9aZkaKhX4Gsl
fuchsia/sdk/core/mac-amd64 from AgIKKqtBtb6R to c6-zqvlx2Yty
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-26 17:15:07 +00:00
engine-flutter-autoroll
ee162e4b7f
Roll Packages from 995bfc5f9857 to 9f8dcc562b55 (4 revisions) ( #127671 )
...
995bfc5f98...9f8dcc562b54558023+keyonghan@users.noreply.github.com Append $flutter/osx sdk property to existing platforms/targets relying on xcode (flutter/packages#4074 )
2023-05-25 10687576+bparrishMines@users.noreply.github.com [url_launcher_android] Fix `unawaited_futures` lint errors (flutter/packages#4086 )
2023-05-25 stuartmorgan@google.com [url_launcher] Convert Android to Pigeon (flutter/packages#4045 )
2023-05-25 pq@users.noreply.github.com [multiple packages] Update collection-fors to prefer final (as per updated `prefer_final_in_for_each`) (flutter/packages#4073 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-26 16:00:38 +00:00
engine-flutter-autoroll
369192ae50
Roll Flutter Engine from 474fcbbe445e to 8573f3b63a1f (1 revision) ( #127647 )
...
474fcbbe44...8573f3b63askia-flutter-autoroll@skia.org Roll Skia from a47a68da8291 to 7e20e6679785 (1 revision) (flutter/engine#42340 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-26 08:56:16 +00:00
engine-flutter-autoroll
02c6873d8f
Roll Flutter Engine from f63fcf5a274e to 474fcbbe445e (1 revision) ( #127644 )
...
f63fcf5a27...474fcbbe44skia-flutter-autoroll@skia.org Roll Skia from be337bef2ad5 to a47a68da8291 (1 revision) (flutter/engine#42338 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-26 07:25:34 +00:00
engine-flutter-autoroll
5654eafbb8
Roll Flutter Engine from b6fcbe31ba1a to f63fcf5a274e (1 revision) ( #127642 )
...
b6fcbe31ba...f63fcf5a27jacksongardner@google.com Proper memory management in Skwasm (flutter/engine#42328 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-26 06:24:22 +00:00
engine-flutter-autoroll
f8bbbef42a
Roll Flutter Engine from bec5da5bff7c to b6fcbe31ba1a (1 revision) ( #127641 )
...
bec5da5bff...b6fcbe31baskia-flutter-autoroll@skia.org Roll Skia from f2de22b5f0f6 to be337bef2ad5 (1 revision) (flutter/engine#42336 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-26 05:08:16 +00:00
engine-flutter-autoroll
3ec5751533
Roll Flutter Engine from 593d4d6b1f9b to bec5da5bff7c (2 revisions) ( #127638 )
...
593d4d6b1f...bec5da5bffskia-flutter-autoroll@skia.org Roll Skia from bd677c195886 to f2de22b5f0f6 (1 revision) (flutter/engine#42335 )
2023-05-26 skia-flutter-autoroll@skia.org Roll Dart SDK from 5697e9123611 to bc65e3f5efa0 (2 revisions) (flutter/engine#42334 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-26 04:13:07 +00:00
engine-flutter-autoroll
6c2041e1e9
Roll Flutter Engine from f4dc96aef71b to 593d4d6b1f9b (1 revision) ( #127635 )
...
f4dc96aef7...593d4d6b1fjason-simmons@users.noreply.github.com [Impeller] Disable the wide gamut settings flag on iOS simulators (flutter/engine#42331 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-26 02:17:26 +00:00
engine-flutter-autoroll
77acfe9c36
Roll Flutter Engine from ff04d2fdd12b to f4dc96aef71b (2 revisions) ( #127633 )
...
ff04d2fdd1...f4dc96aef7dkwingsmt@users.noreply.github.com [macOS] Multi-view thread synchronizer (flutter/engine#41915 )
2023-05-25 skia-flutter-autoroll@skia.org Roll Dart SDK from 0e78305875a4 to 5697e9123611 (1 revision) (flutter/engine#42327 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-26 01:23:55 +00:00
LongCatIsLooong
56808b486d
Remove a bad assert from tooltip implementation ( #127629 )
...
Fixes https://github.com/flutter/flutter/issues/127575
The `_handleMouseEnter` and `_handleMouseExit` calls are balanced, but the tooltip could be dismissed by an external `PointerDown` event interacting with a different UI component so the ` assert(_activeHoveringPointerDevices.isNotEmpty);` does not really make sense.
2023-05-26 00:29:27 +00:00
LongCatIsLooong
43de3365f5
Remove rounding from TextPainter ( #127099 )
...
To opt-in, run the tests with: `SKPARAGRAPH_REMOVE_ROUNDING_HACK=1 flutter test --dart-define=SKPARAGRAPH_REMOVE_ROUNDING_HACK=1 `
Migration plans:
1. Turn the flags on in CI, migrate customer tests if needed
1. Migrate internal customers
2. Remove the flag from skparagraph. Remove the framework flag with a manual engine roll.
Also fixes https://github.com/flutter/flutter/issues/52038
2023-05-26 00:09:51 +00:00
pdblasi-google
07f7ffde50
Adds TestDisplay API for testing Display features ( #127525 )
...
* Adds `TestDisplay`
* Updates `TestPlatformDispatcher` to wrap all `Display`s and relate them to their appropriate `TestFlutterView`
* Updates `TestFlutterView` to tie `devicePixelRatio` to its display as per the documentation on `Display`
Closes #127225
2023-05-26 00:04:05 +00:00
engine-flutter-autoroll
51f7fdbc16
Roll Flutter Engine from 6a4e675ab0b4 to ff04d2fdd12b (3 revisions) ( #127630 )
...
6a4e675ab0...ff04d2fdd1flar@google.com Move checkerboard unit tests onto DisplayList mechanism (flutter/engine#41951 )
2023-05-25 jacksongardner@google.com [Skwasm] Implement miscellaneous drawing APIs (flutter/engine#42324 )
2023-05-25 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from X4uS4T6_J-VUh9M4A... to AgIKKqtBtb6RJnyI9... (flutter/engine#42326 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from X4uS4T6_J-VU to AgIKKqtBtb6R
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-25 23:49:37 +00:00
engine-flutter-autoroll
2460e63f73
Roll Flutter Engine from 99f2653cbb79 to 6a4e675ab0b4 (2 revisions) ( #127625 )
...
99f2653cbb...6a4e675ab0skia-flutter-autoroll@skia.org Roll Skia from e648bf802cd2 to bd677c195886 (2 revisions) (flutter/engine#42325 )
2023-05-25 dkwingsmt@users.noreply.github.com [Rasterizer] Make resubmit information temporary (flutter/engine#42001 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-25 22:51:25 +00:00
keyonghan
3eecc217cf
Append $flutter/osx sdk property to existing platforms/targets relying on xcode ( #127537 )
...
Part of https://github.com/flutter/flutter/issues/127534
2023-05-25 22:47:31 +00:00
Casey Hillers
ce894e8434
Indent markdown value on CP issue template ( #127623 )
...
Fixes https://github.com/flutter/flutter/issues/127592
2023-05-25 22:38:56 +00:00
engine-flutter-autoroll
08266bdfcf
Roll Flutter Engine from 6ff02c17268f to 99f2653cbb79 (6 revisions) ( #127619 )
...
6ff02c1726...99f2653cbbjacksongardner@google.com Implement Web Codecs for Skwasm (flutter/engine#42184 )
2023-05-25 godofredoc@google.com Move linux clang tidy to engine_v2. (flutter/engine#42112 )
2023-05-25 skia-flutter-autoroll@skia.org Roll Skia from 69d0aa065992 to e648bf802cd2 (11 revisions) (flutter/engine#42323 )
2023-05-25 jacksongardner@google.com Only use 8 cores for web test compilation. (flutter/engine#42321 )
2023-05-25 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from nLnQzTesaABpgroOl... to DNwJQMQZladAsKTjv... (flutter/engine#42322 )
2023-05-25 valentin.haloiu@gmail.com Dynamically link against system fontconfig (flutter/engine#40725 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from nLnQzTesaABp to DNwJQMQZladA
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-25 21:29:08 +00:00
Elias Yishak
cb3b1f8c84
ProcessResultMatcher created and used in test (#127414 )
...
Addresses issues:
- https://github.com/flutter/flutter/issues/127135
- https://github.com/flutter/flutter/issues/99767
Creates a matcher class that we can use for `ProcessResult` to check for the exit code.
*List which issues are fixed by this PR. You must list at least one issue.*
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2023-05-25 21:20:03 +00:00
Casey Hillers
8576da53c5
Fix yaml lint issue ( #127600 )
...
Fixes https://github.com/flutter/flutter/issues/127592
Tested by pasting this file into a yaml formatter.
2023-05-25 21:01:18 +00:00
engine-flutter-autoroll
931037438e
Roll Flutter Engine from 515a4bfc4b6e to 6ff02c17268f (1 revision) ( #127609 )
...
515a4bfc4b...6ff02c1726matej.knopp@gmail.com [macOS] Fix FlutterViewController retain cycle (flutter/engine#42317 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-25 20:40:10 +00:00
Qun Cheng
9fa351807f
SearchBar should not be impacted by overall InputDecorationTheme (#127465 )
2023-05-25 12:28:26 -07:00
engine-flutter-autoroll
f71075db2e
Roll Flutter Engine from 195009b91abd to 515a4bfc4b6e (4 revisions) ( #127601 )
...
195009b91a...515a4bfc4bdnfield@google.com Implement PlatformDispatcher.displays on web (flutter/engine#42297 )
2023-05-25 skia-flutter-autoroll@skia.org Roll Skia from b80e74dc4cda to 69d0aa065992 (3 revisions) (flutter/engine#42319 )
2023-05-25 bdero@google.com [Impeller] Safely access snapshot in the pipeline blend filter (flutter/engine#42314 )
2023-05-25 bdero@google.com [Impeller] Add generic path for mask blurring (flutter/engine#42308 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-25 18:43:08 +00:00
engine-flutter-autoroll
e583ba4cf0
Roll Flutter Engine from fb463217d1f3 to 195009b91abd (1 revision) ( #127591 )
...
fb463217d1...195009b91askia-flutter-autoroll@skia.org Roll Skia from fbba25f66405 to b80e74dc4cda (2 revisions) (flutter/engine#42316 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-25 16:21:03 +00:00
Dan Field
a21f33e7ad
avoid incorrect usage of TimelineTask ( #127527 )
...
This code was added based on a misunderstanding of the API surface.
2023-05-25 09:17:02 -07:00
Taha Tesser
c05a05e6fc
Add ScrollNotificationObserver sample ( #127023 )
...
fixes https://github.com/flutter/flutter/issues/126702
### Preview
https://github.com/flutter/flutter/assets/48603081/4c529a0d-b8a5-4950-9095-429f1c5eccbb
2023-05-25 15:58:52 +00:00
engine-flutter-autoroll
3e610f7333
Roll Packages from fba97fa4cc86 to 995bfc5f9857 (3 revisions) ( #127590 )
...
fba97fa4cc...995bfc5f98engine-flutter-autoroll@skia.org Roll Flutter from f86c529b2cd2 to 216605b60f67 (18 revisions) (flutter/packages#4071 )
2023-05-24 stuartmorgan@google.com [various] Fixes `unawaited_futures` violations (flutter/packages#4067 )
2023-05-24 48731731+phcs971@users.noreply.github.com [quick_actions] Fix iOS home screen quick actions documentation hyperlink (flutter/packages#4059 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-25 15:53:15 +00:00
engine-flutter-autoroll
60a64a5a5c
Roll Flutter Engine from a74d9d1f4776 to fb463217d1f3 (1 revision) ( #127577 )
...
a74d9d1f47...fb463217d1skia-flutter-autoroll@skia.org Roll Dart SDK from be01f9fdac37 to 0e78305875a4 (1 revision) (flutter/engine#42313 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-25 15:16:16 +00:00
engine-flutter-autoroll
20e164e60c
Roll Flutter Engine from a7f026b03e35 to a74d9d1f4776 (1 revision) ( #127565 )
...
a7f026b03e...a74d9d1f47skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from RSSC61ubl9JXmn4JO... to X4uS4T6_J-VUh9M4A... (flutter/engine#42311 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from RSSC61ubl9JX to X4uS4T6_J-VU
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-25 10:33:41 +00:00
engine-flutter-autoroll
1a17ba0e5e
Roll Flutter Engine from fb38bb6b1bc1 to a7f026b03e35 (1 revision) ( #127563 )
...
fb38bb6b1b...a7f026b03eskia-flutter-autoroll@skia.org Roll Dart SDK from 96e29af6e0c6 to be01f9fdac37 (2 revisions) (flutter/engine#42310 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-25 09:38:20 +00:00
engine-flutter-autoroll
54d001d442
Roll Flutter Engine from 2be736c390ee to fb38bb6b1bc1 (1 revision) ( #127560 )
...
2be736c390...fb38bb6b1bskia-flutter-autoroll@skia.org Roll Skia from 7ec172b433f1 to fbba25f66405 (2 revisions) (flutter/engine#42309 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-25 08:37:39 +00:00
LongCatIsLooong
1b800fd496
Remove Tooltip mouse tracker listener & update hovering/MouseRegion logic & animation ( #119199 )
...
Fixes https://github.com/flutter/flutter/issues/117627
### Behavior changes:
1. If fade in/fade out animation is already in progress, hiding/showing the tooltip will immediately take effect without waiting for `waitDuration`.
2. A PointerDownEvent that doesn't become a part of a "trigger" gesture dismisses the tooltip, even for hovered ones.
3. The OverlayEntry is now updated only when the previous tooltip was completely dismissed. This can be fixed by OverlayPortal but I'm not sure what the correct behavior is.
2023-05-25 07:24:45 +00:00
engine-flutter-autoroll
9da1d98ae9
Roll Flutter Engine from 37ebad2d5c27 to 2be736c390ee (2 revisions) ( #127554 )
...
37ebad2d5c...2be736c390skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from UYN_Tk7M6_5d2aGIj... to nLnQzTesaABpgroOl... (flutter/engine#42307 )
2023-05-25 bdero@google.com [Impeller] Simplify CreateContentsForGeometry overloads (flutter/engine#42306 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from UYN_Tk7M6_5d to nLnQzTesaABp
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-25 06:03:29 +00:00
engine-flutter-autoroll
b49830b339
Roll Flutter Engine from 62a83490ee60 to 37ebad2d5c27 (1 revision) ( #127551 )
...
62a83490ee...37ebad2d5cskia-flutter-autoroll@skia.org Roll Skia from 150d534341a4 to 7ec172b433f1 (1 revision) (flutter/engine#42305 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-25 05:17:28 +00:00
engine-flutter-autoroll
9e4104b094
Roll Flutter Engine from 1bed04a4375a to 62a83490ee60 (3 revisions) ( #127546 )
...
1bed04a437...62a83490ee54558023+keyonghan@users.noreply.github.com Append $flutter/osx sdk property to existing platforms/targets relying on xcode (flutter/engine#42299 )
2023-05-25 skia-flutter-autoroll@skia.org Roll Dart SDK from 9bea16a7dcbd to 96e29af6e0c6 (1 revision) (flutter/engine#42303 )
2023-05-25 skia-flutter-autoroll@skia.org Roll Skia from 76bae143aded to 150d534341a4 (2 revisions) (flutter/engine#42301 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-25 03:09:20 +00:00
engine-flutter-autoroll
5eacfe62bd
Roll Flutter Engine from 6a361090a367 to 1bed04a4375a (2 revisions) ( #127544 )
...
6a361090a3...1bed04a43730870216+gaaclarke@users.noreply.github.com [Impeller] Turn on vulkan tests for mac CI. (flutter/engine#42225 )
2023-05-24 jonahwilliams@google.com [Impeller] fix UV and color blending. (flutter/engine#42293 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-25 01:47:08 +00:00
engine-flutter-autoroll
9516368e06
Roll Flutter Engine from 9ba461efd3fe to 6a361090a367 (3 revisions) ( #127542 )
...
9ba461efd3...6a361090a3godofredoc@google.com Use engine_v2 builds on recipe testing. (flutter/engine#42298 )
2023-05-24 jason-simmons@users.noreply.github.com [Impeller] Golden test for text with a shader and a transform (flutter/engine#42291 )
2023-05-24 skia-flutter-autoroll@skia.org Roll Skia from 593ece8f74c7 to 76bae143aded (13 revisions) (flutter/engine#42295 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-25 00:33:07 +00:00
Casey Hillers
20eb5adff4
Revert "Update labeler action wildcards" ( #127541 )
...
Reverts flutter/flutter#127524
Bad YAML format is blocking presubmit PRs.
2023-05-24 16:40:53 -07:00
Mouad Debbar
2d142c5ba2
[web] ui.platformViewRegistry => ui_web.platformViewRegistry ( #127493 )
...
Now that `platformViewRegistry` is [exposed](https://github.com/flutter/engine/pull/41877 ) through `dart:ui_web`, we can do some cleanup here.
Part of https://github.com/flutter/flutter/issues/126831
2023-05-24 23:31:28 +00:00
engine-flutter-autoroll
ef54879b48
Roll Flutter Engine from c641f6307f08 to 9ba461efd3fe (6 revisions) ( #127536 )
...
c641f6307f...9ba461efd3mdebbar@google.com [web] Remove comment about dart:html migration (flutter/engine#42290 )
2023-05-24 mdebbar@google.com [web] Hide JS types from dart:ui_web (flutter/engine#42252 )
2023-05-24 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from qoLy9E5PjnAlICjUb... to RSSC61ubl9JXmn4JO... (flutter/engine#42287 )
2023-05-24 marcianx@gmail.com [web] Update a11y announcements to append divs instead of setting content. (flutter/engine#42258 )
2023-05-24 jonahwilliams@google.com [Impeller] fix Xcode frame capture. (flutter/engine#42289 )
2023-05-24 jason-simmons@users.noreply.github.com [Impeller] Create an autorelease pool for Impeller tests running on macOS. (flutter/engine#42265 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from qoLy9E5PjnAl to RSSC61ubl9JX
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-24 23:18:49 +00:00
lsaudon
7827a24207
Add missing parameters in TextFormField ( #127020 )
...
`TextFormField` does not have all the parameters of `TextField`.
Added:
```dart
UndoHistoryController? undoController,
AppPrivateCommandCallback? onAppPrivateCommand,
bool? cursorOpacityAnimates,
ui.BoxHeightStyle selectionHeightStyle = ui.BoxHeightStyle.tight,
ui.BoxWidthStyle selectionWidthStyle = ui.BoxWidthStyle.tight,
DragStartBehavior dragStartBehavior = DragStartBehavior.start,
ContentInsertionConfiguration? contentInsertionConfiguration,
Clip clipBehavior = Clip.hardEdge,
bool scribbleEnabled = true,
bool canRequestFocus = true,
```
2023-05-24 23:06:52 +00:00
Casey Hillers
99f792e085
Update labeler action wildcards ( #127524 )
...
https://github.com/flutter/flutter/issues/126002
2023-05-24 23:06:50 +00:00
LongCatIsLooong
62e78bf143
Improve TextPainter.layout caching ( #118128 )
...
Improves `TextPainter.layout` caching when only the input constraints change:
- removes the double layout calls in `TextPainter._layoutParagraph`: now double layout is only needed when `TextAlign` is not left, and the input `maxWidth == double.infinity`.
- skip calls to `ui.Paragraph.layout` when it's guaranteed that there's no soft line breaks before/after the layout call.
This doesn't introduce new APIs but may slightly shift text rendered on screen.
This reduces the number of `layout` calls but since shaping results are already cached so it only skips the relatively cheap line-breaking process when possible.
528 scuba failures but all of them seem reasonable.
2023-05-24 22:38:52 +00:00
dependabot[bot]
4d1c6a4346
Bump actions/labeler from 2713f7303c96cb1e69627957ec16eea0fd7f94a4 to 0776a679364a9a16110aac8d0f40f5e11009e327 ( #127533 )
...
Bumps [actions/labeler](https://github.com/actions/labeler ) from 2713f7303c96cb1e69627957ec16eea0fd7f94a4 to 0776a679364a9a16110aac8d0f40f5e11009e327.
<details>
<summary>Commits</summary>
<ul>
<li><a href="0776a67936https://redirect.github.com/actions/labeler/issues/571 ">#571</a> from akv-platform/remove-implicit-dependencies</li>
<li><a href="08382d15cbd1dd326ccc91076827ed2713f7303c...0776a67936
2023-05-24 22:36:58 +00:00
Bruno Leroux
2b105ac6dd
Fix ScrollPosition overscroll precision error ( #127321 )
...
## Description
This PR fixes a precision error in ~~`ClampingScrollPhysics`~~ `ScrollPosition` that leads to `StretchingOverscrollIndicator` stretching its content unexpectedly in some devices (see https://github.com/flutter/flutter/issues/126561 where this is visible in `TabBarView` and the test added in this PR where it reproduces with a `PageView`).
~~This PR also contains a change to `nested_scroll_view.dart` because the first change (the one in `ClampingScrollPhysics`) breaks the precision error test added by https://github.com/flutter/flutter/pull/87801.~~
## Related Issue
Fixes https://github.com/flutter/flutter/issues/126561
## Tests
Adds 1 test.
2023-05-24 22:34:06 +00:00
Devin
5451ea6e8f
Slider.onChangeStart & Slider.onChangeEnd are not called on keyboard shortcuts (#126896 )
...
fixes https://github.com/flutter/flutter/issues/123315
--------
This PR makes changes to the _actionHandler function used on the Slider.Dart Widget for Key Events. It ensures onChangeStart is called at the beginning of a Key Event and onChangeEnd at the end of one. This PR includes a test for the changes made.
I ran all existing tests after my changes were made and they passed.
2023-05-24 22:13:15 +00:00
