DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
33,424 Commits 882 Branches 1,069 Tags
Commit Graph

33424 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
skia-flutter-autoroll
bccb642dc6 Roll Skia from 81c8c425a050 to aa1b0074a1b5 (1 revision) (flutter/engine#49514) 
https://skia.googlesource.com/skia.git/+log/81c8c425a050..aa1b0074a1b5

2024-01-04 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 5566afc92caf to 7330dd2dfe64 (17 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-04 01:42:13 +00:00
Casey Hillers
9be43f26a3 Add Flutter CI status to README (flutter/engine#49330) 
https://github.com/flutter/flutter/issues/140460
 2024-01-04 01:34:17 +00:00
skia-flutter-autoroll
45eb89dfb3 Roll Skia from dd4077962cd5 to 81c8c425a050 (1 revision) (flutter/engine#49513) 
https://skia.googlesource.com/skia.git/+log/dd4077962cd5..81c8c425a050

2024-01-03 johnstiles@google.com Split SymbolTable::instantiateSymbolRef in half.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-04 00:54:23 +00:00
Jonny Wang
1b161e263e [fuchsia] Add libbackend_fuchsia_globals.so to common_libs (flutter/engine#49484) 
The libbackend_fuchsia_globals.so is now required by libsyslog.so, so
include it in the list of Fuchsia common_libs.

*Replace this paragraph with a description of what this PR is changing
or adding, and why. Consider including before/after screenshots.*

b/315973146

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x ] All existing and new tests are passing.

---------

Co-authored-by: skia-flutter-autoroll <skia-flutter-autoroll@skia.org>
Co-authored-by: Michael Brase <mbrase@google.com>
 2024-01-03 16:47:32 -08:00
skia-flutter-autoroll
7c56f5ead4 Roll Skia from e32d4d4f71eb to dd4077962cd5 (1 revision) (flutter/engine#49510) 
https://skia.googlesource.com/skia.git/+log/e32d4d4f71eb..dd4077962cd5

2024-01-03 johnstiles@google.com Forward-declare dependencies in PipelineUtils.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-04 00:04:08 +00:00
skia-flutter-autoroll
537ebfe48e Roll Skia from 7d73dd415ae9 to e32d4d4f71eb (3 revisions) (flutter/engine#49508) 
https://skia.googlesource.com/skia.git/+log/7d73dd415ae9..e32d4d4f71eb

2024-01-03 michaelludwig@google.com [skif] Remove SK_USE_LEGACY_CONTENT_BOUNDS_PROPAGATION flag
2024-01-03 ccameron@chromium.org Add SkGradientShader::ColorSpace::kOKLabGamutMap and kOKLCHGamutMap
2024-01-03 michaelludwig@google.com Remove staging flag from flutter_defines

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-03 23:12:59 +00:00
skia-flutter-autoroll
9ce1ec17a9 Roll Skia from 1ce1aa1f90fa to 7d73dd415ae9 (3 revisions) (flutter/engine#49506) 
https://skia.googlesource.com/skia.git/+log/1ce1aa1f90fa..7d73dd415ae9

2024-01-03 egdaniel@google.com Remove default enabling of vulkan on android in gn.
2024-01-03 johnstiles@google.com Remove Compiler::toBackend calls.
2024-01-03 johnstiles@google.com Decouple HLSL code generation from SkSL::Compiler.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-03 22:07:08 +00:00
skia-flutter-autoroll
b69420468d Roll Skia from 063e339bedfc to 1ce1aa1f90fa (6 revisions) (flutter/engine#49503) 
https://skia.googlesource.com/skia.git/+log/063e339bedfc..1ce1aa1f90fa

2024-01-03 johnstiles@google.com Decouple SPIR-V code generation from SkSL::Compiler.
2024-01-03 johnstiles@google.com Fix SKSL_ENABLE_TRACING flag in test code.
2024-01-03 brianosman@google.com Skip LastFragColorWithoutCaps.sksl error test (to fix Pixel4a bots)
2024-01-03 nicolettep@google.com [graphite] Add MSAA pipeline creation structs to VulkanResourceProvider
2024-01-03 johnstiles@google.com Decouple WGSL code generation from SkSL::Compiler.
2024-01-03 brianosman@google.com Revert "Update bots' NDK to r26b"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-03 21:12:52 +00:00
gaaclarke
d52f315f41 [Impeller] new blur: limit uvs to blur region (flutter/engine#49299) 
This will run the blur passes on a subset of the texture passed into it that will actually be blurred.  This is an optimization for backdrop filters.

issue: https://github.com/flutter/flutter/issues/131580
test coverage: devicelab `backdrop_filter_perf_ios__timeline_summary`

## performance results

This results in a 50% reduction in average GPU time in our benchmark, 79% reduction in the "99% percentile".
```
BEFORE

    "average_vsync_transitions_missed": 3.889423076923077,
    "90th_percentile_vsync_transitions_missed": 4.0,
    "99th_percentile_vsync_transitions_missed": 4.0,
    "average_vsync_frame_lag": 0.0,
    "90th_percentile_vsync_frame_lag": 0.0,
    "99th_percentile_vsync_frame_lag": 0.0,
    "average_layer_cache_count": 0.0,
    "90th_percentile_layer_cache_count": 0.0,
    "99th_percentile_layer_cache_count": 0.0,
    "average_frame_request_pending_latency": 16654.368333333332,
    "90th_percentile_frame_request_pending_latency": 16692.0,
    "99th_percentile_frame_request_pending_latency": 16749.0,
    "worst_layer_cache_count": 0.0,
    "average_layer_cache_memory": 0.0,
    "90th_percentile_layer_cache_memory": 0.0,
    "99th_percentile_layer_cache_memory": 0.0,
    "worst_layer_cache_memory": 0.0,
    "average_picture_cache_count": 0.0,
    "90th_percentile_picture_cache_count": 0.0,
    "99th_percentile_picture_cache_count": 0.0,
    "worst_picture_cache_count": 0.0,
    "average_picture_cache_memory": 0.0,
    "90th_percentile_picture_cache_memory": 0.0,
    "99th_percentile_picture_cache_memory": 0.0,
    "worst_picture_cache_memory": 0.0,
    "total_ui_gc_time": 0.659,
    "30hz_frame_percentage": 0.0,
    "60hz_frame_percentage": 100.0,
    "80hz_frame_percentage": 0.0,
    "90hz_frame_percentage": 0.0,
    "120hz_frame_percentage": 0.0,
    "illegal_refresh_rate_frame_count": 0,
    "average_gpu_frame_time": 52.13341346153846,
    "90th_percentile_gpu_frame_time": 62.5,
    "99th_percentile_gpu_frame_time": 62.5,
    "worst_gpu_frame_time": 62.5,
    "average_cpu_usage": 69.08979595918369,
    "90th_percentile_cpu_usage": 70.4,
    "99th_percentile_cpu_usage": 71.699999,
    "average_gpu_usage": 100.0,
    "90th_percentile_gpu_usage": 100.0,
    "99th_percentile_gpu_usage": 100.0,
    "average_memory_usage": 118.79942602040816,
    "90th_percentile_memory_usage": 138.125,
    "99th_percentile_memory_usage": 143.65625

AFTER

    "average_vsync_transitions_missed": 2.0,
    "90th_percentile_vsync_transitions_missed": 2.0,
    "99th_percentile_vsync_transitions_missed": 2.0,
    "average_vsync_frame_lag": 0.0,
    "90th_percentile_vsync_frame_lag": 0.0,
    "99th_percentile_vsync_frame_lag": 0.0,
    "average_layer_cache_count": 0.0,
    "90th_percentile_layer_cache_count": 0.0,
    "99th_percentile_layer_cache_count": 0.0,
    "average_frame_request_pending_latency": 16635.025,
    "90th_percentile_frame_request_pending_latency": 16715.0,
    "99th_percentile_frame_request_pending_latency": 16802.0,
    "worst_layer_cache_count": 0.0,
    "average_layer_cache_memory": 0.0,
    "90th_percentile_layer_cache_memory": 0.0,
    "99th_percentile_layer_cache_memory": 0.0,
    "worst_layer_cache_memory": 0.0,
    "average_picture_cache_count": 0.0,
    "90th_percentile_picture_cache_count": 0.0,
    "99th_percentile_picture_cache_count": 0.0,
    "worst_picture_cache_count": 0.0,
    "average_picture_cache_memory": 0.0,
    "90th_percentile_picture_cache_memory": 0.0,
    "99th_percentile_picture_cache_memory": 0.0,
    "worst_picture_cache_memory": 0.0,
    "total_ui_gc_time": 1.732,
    "30hz_frame_percentage": 0.0,
    "60hz_frame_percentage": 100.0,
    "80hz_frame_percentage": 0.0,
    "90hz_frame_percentage": 0.0,
    "120hz_frame_percentage": 0.0,
    "illegal_refresh_rate_frame_count": 0,
    "average_gpu_frame_time": 25.01558603491272,
    "90th_percentile_gpu_frame_time": 31.25,
    "99th_percentile_gpu_frame_time": 31.25,
```

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-01-03 20:46:00 +00:00
skia-flutter-autoroll
c86035488d Roll Skia from 1144b7950404 to 063e339bedfc (7 revisions) (flutter/engine#49500) 
https://skia.googlesource.com/skia.git/+log/1144b7950404..063e339bedfc

2024-01-03 brianosman@google.com Update bots' NDK to r26b
2024-01-03 drott@chromium.org [fontations-backend] Resolve palette overrides and store CPAL palette
2024-01-03 drott@chromium.org Fix viewer build after build target renames
2024-01-03 johnstiles@google.com Reland "Fix fuzzer-discovered Metal issue with sk_LastFragColor."
2024-01-03 johnstiles@google.com Decouple Metal code generation from SkSL::Compiler.
2024-01-03 michaelludwig@google.com [graphite] Disable short uniforms
2024-01-03 michaelludwig@google.com [graphite] Clean-up Uniform header, pack fields and add type asserts

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-03 20:18:47 +00:00
gaaclarke
408561bab3 [Impeller] pulled out the path unit tests to their own file (flutter/engine#49499) 
issue: https://github.com/flutter/flutter/issues/140106
tests: refactor of code

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-01-03 20:07:15 +00:00
John McCutchan
718ac2c814 Fix a crash in the new SurfaceProducer external texture (flutter/engine#49496) 
The following sequence of events would lead to a crash:

- Reader A is created.
- Reader A produces a frame (A0)
- Texture is resized.
- Reader B is created and reader A is scheduled to be closed.
- Reader A produces a frame (A1). This is skipped.
- Reader A is closed.
- Frame A0 is acquired.

Because we closed Reader A the frame A0 is invalid.

The fix is to not close Reader A when it is the last reader to produce a
frame.

Fixes internal bug b/318458306
 2024-01-03 10:56:46 -08:00
Jonah Williams
7446f3ff6f [Impeller] Disable compute for Vulkan. (flutter/engine#49463) 
This code is missing correct barriers which cannot be specified at the HAL level, see https://github.com/flutter/flutter/issues/140798
 2024-01-03 18:48:11 +00:00
Tong Mu
ceaa4c9fc6 Revert skiping illegal render in Dart (flutter/engine#49473) 2024-01-03 10:45:16 -08:00
skia-flutter-autoroll
607e8dca77 Roll Skia from 9e8069bba51d to 1144b7950404 (1 revision) (flutter/engine#49494) 
https://skia.googlesource.com/skia.git/+log/9e8069bba51d..1144b7950404

2024-01-03 johnstiles@google.com Decouple GLSL code generation from SkSL::Compiler.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-03 17:36:18 +00:00
skia-flutter-autoroll
9bc1c5bbce Roll Skia from a9db1213b179 to 9e8069bba51d (18 revisions) (flutter/engine#49490) 
https://skia.googlesource.com/skia.git/+log/a9db1213b179..9e8069bba51d

2024-01-03 johnstiles@google.com Remove shaderCompiler() from GrGpu.
2024-01-03 johnstiles@google.com Remove caps member from SkSL::Compiler.
2024-01-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from bd5dce9a8e85 to a6b9a7447d68 (35 revisions)
2024-01-03 drott@chromium.org [COLRv1] Add tests for PaintColrGlyph cycle detection
2024-01-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from fd810f3d94c5 to 766692bfd3f0
2024-01-03 mike@reedtribe.org add include guard
2024-01-03 egdaniel@google.com [Graphite] Fix Vulkan write and readPixels to RGB_888 format
2024-01-03 herb@google.com Reland "Compare two segments at a given y"
2024-01-03 mike@reedtribe.org Expose limit for TypefaceCache
2024-01-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from d32a5c6f592d to b9d08e6f5a57 (36 revisions)
2024-01-03 brianosman@google.com Add SK_ASSUME macro, to replace clang-only __builtin_assume
2024-01-03 drott@chromium.org Revert^2 "[Fontations-backend] Use new outline API"
2024-01-03 drott@chromium.org Pick unsigned 16 bit type for SkFontArgument palette overrides
2024-01-03 drott@chromium.org [Fontations-backend] Resolve palettes FFI functionality
2024-01-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from abf17e333489 to b09f6a97d1da (60 revisions)
2024-01-03 egdaniel@google.com Fix convexity check when we backtrack right from the start.
2024-01-03 olv@google.com [ganesh] Add VK_FORMAT_G10X6_B10X6R10X6_2PLANE_420_UNORM_3PACK16 support
2024-01-03 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from d7465b8b2585 to 5566afc92caf (21 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-03 16:02:29 +00:00
auto-submit[bot]
28d02b21eb Reverts "Roll Dart SDK from 7e9f7eab80d3 to c5a75ac9057c (1 revision)" (flutter/engine#49491) 
Reverts flutter/engine#49478
Initiated by: zanderso
This change reverts the following previous change:
Original Description:

https://dart.googlesource.com/sdk.git/+log/7e9f7eab80d3..c5a75ac9057c

2024-01-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-277.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-03 15:40:25 +00:00
skia-flutter-autoroll
cb4649c27a Roll Skia from 4b16117e94b2 to a9db1213b179 (1 revision) (flutter/engine#49487) 
https://skia.googlesource.com/skia.git/+log/4b16117e94b2..a9db1213b179

2023-12-21 johnstiles@google.com Fix IWYU inclusion of <atomic> when TRACE_EVENT is used.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-03 15:08:07 +00:00
Dan Field
125a9161bb [Impeller] Allow multiple --runtime-stage-* parameters to impellerc (flutter/engine#49475) 
This patch will be important for Android/Vulkan, where we'll need to bundle GLES, Vulkan, and SkSL (at least for now).

I've refactored impellerc_main to break up some of the larger methods into more granular ones.

I've also changed the way that the `IPLR` output works so that we create as many compilers as runtime stages requested.

We still are in a weird situation where we create one "Default" compiler for the reflection data and depfile. I don't think that needs to be addressed in this patch, but we should do something about this. I've talked a little with @bdero and @jonahwilliams - it will probably involve something like making the generated reflection data a bit more flexible than it currently is so that it can more ergonomically capture different platform anomalies - we could do this either by having a compiler type that is explicitly for generating reflection data rather than using one arbitrary one and making the reflector try to be platform agnostic. I've filed a couple TODOs related to this and linked them in the patch.

Fixes https://github.com/flutter/flutter/issues/140817
 2024-01-03 06:55:29 +00:00
skia-flutter-autoroll
cd0ed89b1c Roll Dart SDK from 7e9f7eab80d3 to c5a75ac9057c (1 revision) (flutter/engine#49478) 
https://dart.googlesource.com/sdk.git/+log/7e9f7eab80d3..c5a75ac9057c

2024-01-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-277.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-03 04:02:29 +00:00
Jonah Williams
3abb46f682 [Impeller] add doc on iOS flamegraph capture. (flutter/engine#49469) 
I find flamegraphs pretty useful, but Xcode doesn't have one built in that I know of.
 2024-01-02 23:52:21 +00:00
Loïc Sharma
8be4835c7c Revert "Reland "[Windows] Move to FlutterCompositor for rendering" (flutter/engine#49461) 
This reverts https://github.com/flutter/engine/pull/49262 (f3381e1080) as it regressed [`material_floating_search_bar`](https://pub.dev/packages/material_floating_search_bar_2)'s animation.

This revert was created manually due to merge conflicts.

Issue tracking bug: https://github.com/flutter/flutter/issues/140828

Part of https://github.com/flutter/flutter/issues/128904

<details>
<summary>Minimal repro of the broken animation...</summary>

Here's what the animation is supposed to look like:
![good](https://publish-01.obsidian.md/access/b48ac8ca270cd9dac18c4a64d11b1c02/assets/2023-12-28-compositor_animation_regression_good.gif)

Here's what the animation actually looks like: ![bad](https://publish-01.obsidian.md/access/b48ac8ca270cd9dac18c4a64d11b1c02/assets/2023-12-28-compositor_animation_regression_bad.gif)

Here is a minimal repro of the broken animation:

```dart
// The Windows compositor changes regresses the animation in
// the `material_floating_search_bar_2` package:
// 
// https://pub.dev/packages/material_floating_search_bar_2/versions/0.5.0
//
// Below is a minimal repro of the broken animation. This has two pieces:
//
//  1. The background fades to a grey color
//  2. A box is "revealed" using a custom clipper
//
// On framework commit b417fb828b332b0a4b0c80b742d86aa922de2649 this animation is broken on Windows.
// On framework commit 9c2a7560096223090d38bbd5b4c46760be396bc1 this animation works as expected on Windows.
//
// Good gif: https://publish-01.obsidian.md/access/b48ac8ca270cd9dac18c4a64d11b1c02/assets/2023-12-28-compositor_animation_regression_good.gif
// Bad gif: https://publish-01.obsidian.md/access/b48ac8ca270cd9dac18c4a64d11b1c02/assets/2023-12-28-compositor_animation_regression_bad.gif
import 'dart:math';
import 'dart:ui';

import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    // Not using `MaterialApp` is necessary to reproduce:
    return Container(
      color: Colors.white,
      child: const Directionality(
        textDirection: TextDirection.ltr,
        child: FloatingSearchBar(),
      ),
    );

    // Switching to `MaterialApp` fixes the issue:
    // return const MaterialApp(
    //   home: Scaffold(
    //     body: FloatingSearchBar(),
    //   ),
    // );
  }
}

class FloatingSearchBar extends StatefulWidget {
  const FloatingSearchBar({super.key});

  @override
  FloatingSearchBarState createState() => FloatingSearchBarState();
}

class FloatingSearchBarState extends State<FloatingSearchBar> with SingleTickerProviderStateMixin {
  late final AnimationController _controller = AnimationController(
    vsync: this,
    duration: const Duration(seconds: 2),
  );

  @override
  void dispose() {
    _controller.dispose();
    super.dispose();
  }

  void _animate() {
    if (_controller.isDismissed || _controller.status == AnimationStatus.reverse) {
      _controller.forward();
    } else {
      _controller.reverse();
    }
  }

  @override
  Widget build(BuildContext context) {
    return AnimatedBuilder(
      animation: _controller,
      builder: (BuildContext context, _) {
        return Stack(
          children: <Widget>[
            if (!_controller.isDismissed)
              FadeTransition(
                opacity: _controller,
                child: const SizedBox.expand(
                  child: DecoratedBox(
                    decoration: BoxDecoration(color: Colors.black26),
                  ),
                ),
              ),

            _buildSearchBar(),
          ],
        );
      },
    );
  }

  Widget _buildSearchBar() {
    return Column(
      crossAxisAlignment: CrossAxisAlignment.stretch,
      children: <Widget>[
        // This is where the search text input would go...
        GestureDetector(
          onTap: () => _animate(),
          child: Text(
            switch (_controller.status) {
              AnimationStatus.forward || AnimationStatus.completed => 'Click to close',
              AnimationStatus.reverse || AnimationStatus.dismissed => 'Click to open',
            },
            style: const TextStyle(color: Colors.black),
          ),
        ),
        
        // Below are where the search results would be. Clicking on the search
        // input above reveals the results below.

        // Removing this fixes the background's fade transition.
        ClipOval(
          clipper: _CircularRevealClipper(
            fraction: _controller.value,
          ),
          child: DecoratedBox(
            decoration: BoxDecoration(
              color: Colors.white,
              // Removing this line fixes the background's fade transition.
              borderRadius: BorderRadius.circular(16.0),
            ),
            child: const Padding(
              padding: EdgeInsets.all(64.0),
              child: Text(
                'Hello world',
                style: TextStyle(color: Colors.black),
              ),
            ),
          ),
        ),
      ],
    );
  }
}

class _CircularRevealClipper extends CustomClipper<Rect> {
  const _CircularRevealClipper({required this.fraction});

  final double fraction;

  @override
  Rect getClip(Size size) {
    final double halfWidth = size.width * 0.5;
    final double maxRadius = sqrt(halfWidth * halfWidth + size.height * size.height);
    final double radius = lerpDouble(0.0, maxRadius, fraction) ?? 0;

    return Rect.fromCircle(
      center: Offset(halfWidth, 0),
      radius: radius,
    );
  }

  @override
  bool shouldReclip(CustomClipper<Rect> oldClipper) {
    if (oldClipper is _CircularRevealClipper) {
      return oldClipper.fraction != fraction;
    }

    return true;
  }
}

```

</details>

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-01-02 23:31:04 +00:00
Dan Field
1255dfd26a Start wiring up fragment program for OpenGLES (flutter/engine#49347) 
Makes fragment programs work for OpenGLES backend.

Fixes https://github.com/flutter/flutter/issues/113715
Fixes https://github.com/flutter/flutter/issues/105538
I cannot find a dedicated issue for this, but there probably is someone somewhere and I don't want to file a new one for it.
 2024-01-02 22:11:05 +00:00
skia-flutter-autoroll
50c148a227 Roll Dart SDK from 014514e3e5b9 to 7e9f7eab80d3 (2 revisions) (flutter/engine#49471) 
https://dart.googlesource.com/sdk.git/+log/014514e3e5b9..7e9f7eab80d3

2024-01-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-276.0.dev
2024-01-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-275.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-02 22:05:08 +00:00
Yegor
7dce8b8825 [web] make TextStyle implementations consistent (flutter/engine#49465) 
Make TextStyle implementations consistent across web renderers and consistent with the mobile implementation. This will allow us to unskip `test/painting/text_style_test.dart` on the framework side.
 2024-01-02 20:41:08 +00:00
John McCutchan
6518198fc6 Android Platform Views support Verified Input Events (flutter/engine#49268) 
Android Platform Views process MotionEvents in a complicated way:

1. MotionEvent is captured and delivered to
PlatformViewWrapper.onTouchEvent (TLHC) or
FlutterMutatorView.onTouchEvent (HC)
2. MotionEvent is transformed by the AndroidTouchProcessor into a
PointerEvent
3. AndroidTouchProcessor sends the PointerEvent over the
PlatformViewChannel
4. Framework processes the PointerEvent
5. Framework sends the PointerEvent over the PlatformViewChannel.
6. in PlatformViewsController.onTouch a new MotionEvent is synthesized
7. The MotionEvent is delivered to the platform view

After step (6) the MotionEvent will fail Verification
(`android.hardware.input.InputManager.verifyInputEvent`).

The fix requires that in step (6) we use the original motion event
delivered in step (1) instead of synthesizing a new instance.
 2024-01-02 11:32:06 -08:00
gaaclarke
9ae8b1e79c [Impeller] new blur: implemented ping ponging (flutter/engine#49252) 
This will reuse the downsample texture for the blur pass.

issue: https://github.com/flutter/flutter/issues/140189

Testing: This has golden image coverage for the refactoring. There is a
slight performance difference which will show up in benchmarks. Ideally
there would also be a memory test for the blur. I don't think there is
one yet.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-01-02 11:23:08 -08:00
Dan Field
76fc29312f Make sure to finish the suite if all tests are skipped (flutter/engine#49339) 
Fixes https://github.com/flutter/flutter/issues/140481

Before this fix, if all tests are skipped, the `onDone` callback never fires, which means the recieve port never closes, which means the process just hangs indefinitely (and the success message is never printed).
 2024-01-02 18:34:04 +00:00
Rulong Chen（陈汝龙）
ba2b335b99 Fix NPE when platform plugin delegate is null (flutter/engine#49391) 
Fixes: 
https://github.com/flutter/flutter/issues/140600
https://github.com/flutter/flutter/issues/140031

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-01-02 08:54:39 -08:00
Rulong Chen（陈汝龙）
62abbc2a03 Add try-with-resource support to TraceSection (flutter/engine#49445) 
This PR adds a new way to define scoped trace events in Java, using the try-with-resource construct. This makes code simpler to read, and less error-prone.

Before:
```java
try {
  TraceSection.begin("name");
  // ....
} finally {
  TraceSection.end();
}
```

Now:
```java
try (TraceSection e = TraceSection.scoped("name")) {
  // ...
}
```

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-01-02 16:35:19 +00:00
skia-flutter-autoroll
954c4b07fb Roll Dart SDK from 54ae19428139 to 014514e3e5b9 (1 revision) (flutter/engine#49458) 
https://dart.googlesource.com/sdk.git/+log/54ae19428139..014514e3e5b9

2024-01-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-274.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-02 13:27:23 +00:00
skia-flutter-autoroll
f4bf7e1ad2 Roll Dart SDK from 4b2415d82948 to 54ae19428139 (1 revision) (flutter/engine#49423) 
https://dart.googlesource.com/sdk.git/+log/4b2415d82948..54ae19428139

2023-12-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-273.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-29 17:43:08 +00:00
skia-flutter-autoroll
81fecce800 Roll Dart SDK from 4d83ab20df11 to 4b2415d82948 (1 revision) (flutter/engine#49421) 
https://dart.googlesource.com/sdk.git/+log/4d83ab20df11..4b2415d82948

2023-12-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-272.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-29 11:24:36 +00:00
skia-flutter-autoroll
0de19e0064 Roll Dart SDK from 69ef0e9b3570 to 4d83ab20df11 (1 revision) (flutter/engine#49420) 
https://dart.googlesource.com/sdk.git/+log/69ef0e9b3570..4d83ab20df11

2023-12-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-271.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-29 07:42:26 +00:00
skia-flutter-autoroll
097f91034c Roll Dart SDK from c7442b492d15 to 69ef0e9b3570 (1 revision) (flutter/engine#49419) 
https://dart.googlesource.com/sdk.git/+log/c7442b492d15..69ef0e9b3570

2023-12-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-270.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-29 03:46:23 +00:00
skia-flutter-autoroll
8eec65c4d6 Roll Dart SDK from be080de22019 to c7442b492d15 (5 revisions) (flutter/engine#49417) 
https://dart.googlesource.com/sdk.git/+log/be080de22019..c7442b492d15

2023-12-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-269.0.dev
2023-12-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-268.0.dev
2023-12-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-267.0.dev
2023-12-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-266.0.dev
2023-12-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-265.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-29 00:02:34 +00:00
Loïc Sharma
e7b8646416 [Windows] Move DWM flush to Windows proc table for mocking (flutter/engine#49398) 
The `FlutterWindowsView` uses the `DwmFlush` win32 API to prevent artifacts during window resizing.

Currently, the view used the `FlutterWindow` to allow mocking this win32 API. However, the window is a complex type with lots of other responsibilities. The `WindowsProcTable` is the new preferred type for mocking win32 API.

Part of https://github.com/flutter/flutter/issues/140626

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-12-27 23:41:19 +00:00
skia-flutter-autoroll
fc7ff0d62b Roll Dart SDK from a95d7384db93 to be080de22019 (1 revision) (flutter/engine#49407) 
https://dart.googlesource.com/sdk.git/+log/a95d7384db93..be080de22019

2023-12-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-264.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-27 21:39:11 +00:00
skia-flutter-autoroll
48b0033f3d Roll Dart SDK from 5084fdc1d98a to a95d7384db93 (1 revision) (flutter/engine#49401) 
https://dart.googlesource.com/sdk.git/+log/5084fdc1d98a..a95d7384db93

2023-12-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-263.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-27 05:33:33 +00:00
skia-flutter-autoroll
13fde1c1df Roll Dart SDK from add161c68e6d to 5084fdc1d98a (1 revision) (flutter/engine#49399) 
https://dart.googlesource.com/sdk.git/+log/add161c68e6d..5084fdc1d98a

2023-12-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-262.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-27 01:23:16 +00:00
Loïc Sharma
ed5f58647f [Windows] Move DWM composition status to Windows proc table for mocking (flutter/engine#49397) 
The `FlutterWindowsView` needs the `DwmIsCompositionEnabled` win32 API to check whether it should block presents until the v-blank to prevent screen tearing.

Currently, the view used the `FlutterWindow` to allow mocking this win32 API. However, the window is a complex type with lots of other responsibilities. The `WindowsProcTable` is the new preferred type for mocking win32 API.

Part of https://github.com/flutter/flutter/issues/140626

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-12-26 23:08:34 +00:00
Loïc Sharma
e18aa559bd [Windows] Remove PlatformWindow and RenderTarget abstractions (flutter/engine#49312) 
The Windows embedder has three ways to get an `HWND`:

1. `GetWindowHandle` which returns the `HWND`
2. `GetPlatformWindow` which returns the `HWND` wrapped as a `PlatformWindow`
3. `GetRenderTarget` which returns the `HWND` wrapped as a `RenderTarget`

These abstractions are no longer useful now that we removed the UWP embedder. This change removes `PlatformWindow` and `RenderTarget` and uses `HWND` directly.

This change is a refactoring with no semantic changes.
 2023-12-26 19:34:06 +00:00
skia-flutter-autoroll
ddffb78df2 Roll Dart SDK from cf2d9652297b to add161c68e6d (1 revision) (flutter/engine#49390) 
https://dart.googlesource.com/sdk.git/+log/cf2d9652297b..add161c68e6d

2023-12-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-261.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-26 01:31:33 +00:00
skia-flutter-autoroll
15d4e2a739 Roll Dart SDK from c1f9520b30d7 to cf2d9652297b (1 revision) (flutter/engine#49382) 
https://dart.googlesource.com/sdk.git/+log/c1f9520b30d7..cf2d9652297b

2023-12-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-260.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-23 13:37:04 +00:00
skia-flutter-autoroll
8ff3ab7154 Roll Dart SDK from 25961234c1bc to c1f9520b30d7 (1 revision) (flutter/engine#49376) 
https://dart.googlesource.com/sdk.git/+log/25961234c1bc..c1f9520b30d7

2023-12-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-259.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-23 01:24:09 +00:00
skia-flutter-autoroll
92e0e84d14 Roll Dart SDK from eec6568c209f to 25961234c1bc (1 revision) (flutter/engine#49373) 
https://dart.googlesource.com/sdk.git/+log/eec6568c209f..25961234c1bc

2023-12-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-258.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-22 21:33:12 +00:00
skia-flutter-autoroll
662ec5f7e4 Roll Dart SDK from 151b363886f9 to eec6568c209f (1 revision) (flutter/engine#49369) 
https://dart.googlesource.com/sdk.git/+log/151b363886f9..eec6568c209f

2023-12-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-257.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-22 17:00:31 +00:00
skia-flutter-autoroll
f03066f831 Roll Dart SDK from 69423a5dd254 to 151b363886f9 (1 revision) (flutter/engine#49357) 
https://dart.googlesource.com/sdk.git/+log/69423a5dd254..151b363886f9

2023-12-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-256.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-22 08:37:22 +00:00
skia-flutter-autoroll
ba55ba32d0 Roll Dart SDK from fe94d9b88531 to 69423a5dd254 (1 revision) (flutter/engine#49354) 
https://dart.googlesource.com/sdk.git/+log/fe94d9b88531..69423a5dd254

2023-12-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-255.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-22 04:59:23 +00:00
Dan Field
cfdadd3c74 Fix GetImpellerContext for ShellTestPlatformViewGL (flutter/engine#49337) 
I tried to do this for Vulkan too but hit the limit of my patience for today on debugging why the Vulkan backend was segfaulting on shutdown.

Half of https://github.com/flutter/flutter/issues/140419
 2023-12-22 00:52:23 +00:00