DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-16 07:42:10 +08:00
Code Issues Packages Projects Releases Wiki Activity
83,883 Commits 879 Branches 1,069 Tags
Commit Graph

30342 Commits

Author SHA1 Message Date
engine-flutter-autoroll
0f1fb96211
Roll Skia from de42a0c4337b to 1161451d903b (2 revisions) (#167844) 
https://skia.googlesource.com/skia.git/+log/de42a0c4337b..1161451d903b

2025-04-25 danieldilan@google.com Allow mask filters to effect shading
properties for autolayer
2025-04-25 borenet@google.com [infra] Update OS dimension for Windows
GCE VMs

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
chinmaygarde@google.com,jmbetancourt@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-25 21:38:01 +00:00
Jim Graham
e7e19fb5bd
Impeller will stroke paths directly from the original path via iteration (#167422) 
Currently stroking paths in Impeller goes through a few steps:

- [Once per path object, if reused] If necessary, convert a source Skia
path to an Impeller path
- Ask the Impeller path object to create a polyline, with only line
segments each potentially marked as "coming from a curve"
- Widen the polyline treating curves specially
- render the widened vertex list

This PR attempts to streamline that process by iterating the original
curve and widening the strokes from that. It will require no conversion
of the path from SkPath to impeller::Path (if it was created as an
SkPath as is done for all ui.Path objects). It also avoids the
intermediate polyline stage. It will also produce fewer outline vertices
since it attempts to recognize which vertices are produced by the prior
and future line segments and avoid duplicating them.
 2025-04-25 18:18:09 +00:00
Jonah Williams
c0c12a759e
[Impeller] reland: defer impeller context initialization onto the raster thread. (#167765) 
Attempt to speed up vulkan startup by ensuring vulkan driver
initialization happens on raster thread. Prev. we immediately
initialized the impeller::Context, unfortunately setting up the vulkan
context can take upwards of 100ms. This time is running on the platform
thread and blocking startup.

Instead, I attempt to hide/defer as much as possible what backend is
being used - this requires us to access the impeller context via a
shared_future in some cases instead of immediately knowing it is valid.
 2025-04-25 18:01:19 +00:00
Matan Lurey
5da19ccfbc
Move backfill: "false" out of properties, make it a boolean. (#167820) 
Towards https://github.com/flutter/flutter/issues/167755.

Cocoon supports both formats at the moment, so this a NOP.
 2025-04-25 17:26:07 +00:00
zhongliugo
f01be78706
web: Use aria-current as fallback for aria-selected (#167672) 
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

Use aria-current as fallback for aria-selected.

Please check the Proposal section in the issue #167147. 

after the change demo:
https://aria-selected-04172025.web.app/
https://aria-current-04222025.web.app/

issue to fix:  #167147 


## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-04-25 16:53:17 +00:00
Jonah Williams
7d2dea222c
[Impeller] Slimpeller Android prototype. (#167608) 
Demonstate potential code size reduction from android slimpeller.
 2025-04-25 16:32:11 +00:00
Reid Baker
d6b1702e5f
Update platform views documentation with 4 standard names and abbreviations (#167752) 
After talking with @gmackall we are going to try to standardize on 

Virtual Display (VD) 
Hybrid Composition (HC) 
Texture Layer Hybrid Composition (TLHC)
Hybrid Composition++ (HCPP) 

for our documentation covering android platform views and how we
describe the code to each other.

For example HC++ would be discouraged, so would referring to HC as
expensive.

This pr also removes TargetSdk since that annotation has been deprecated
for a number of years and can be wholly replaced by the already used
RequiresApi annotations.


## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
 2025-04-25 14:26:44 +00:00
engine-flutter-autoroll
0cff5a3a45
Roll Dart SDK from 88e2c816be30 to 2790fef88d68 (3 revisions) (#167807) 
https://dart.googlesource.com/sdk.git/+log/88e2c816be30..2790fef88d68

2025-04-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-55.0.dev
2025-04-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-54.0.dev
2025-04-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-53.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert
to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-25 13:56:27 +00:00
engine-flutter-autoroll
b9e982614b
Roll Skia from 7104f1487466 to e5dcffd10068 (1 revision) (#167787) 
https://skia.googlesource.com/skia.git/+log/7104f1487466..e5dcffd10068

2025-04-24 jamesgk@google.com [graphite] Support lifting nested shader
expressions

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
chinmaygarde@google.com,jmbetancourt@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-25 01:50:42 +00:00
engine-flutter-autoroll
5574a51f56
Roll Fuchsia Linux SDK from kv7EzI7mADDgRbtmL... to Kf_RtNWkgzeuJbZo2... (#167775) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC chinmaygarde@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-24 23:34:07 +00:00
Tong Mu
83483976ec
[Impeller] Adds oval shortcut to DisplayListMatrixClipState::clip{RRect,RSuperellipse} (#164519) 
Fixes https://github.com/flutter/flutter/issues/163717

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-04-24 21:00:56 +00:00
engine-flutter-autoroll
7b229e71b1
Roll Dart SDK from 73641e1ef4f2 to 88e2c816be30 (1 revision) (#167746) 
https://dart.googlesource.com/sdk.git/+log/73641e1ef4f2..88e2c816be30

2025-04-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-52.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert
to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-24 20:41:19 +00:00
Gray Mackall
ce51065f81
[HCPP] Add filltype support for clipPath mutator (#167571) 
Fixes https://github.com/flutter/flutter/issues/164808.

Also overhauls the test app so that we can apply clippers independently
of each other.

Looks like (with a weirdly small box)

<img
src="https://github.com/user-attachments/assets/b290ea2e-79b8-46cd-93c2-5fe6024ba5d2"
width="200" />

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Gray Mackall <mackall@google.com>
 2025-04-24 20:16:04 +00:00
Chris Bracken
09d4dabd6d
iOS: Update minimum iOS version to 13.0 (#167737) 
This updates the Flutter minimum iOS version from 12.0 to 13.0, adds a
migrator for existing apps, and updates our own examples, tests, and
benchmark apps to 13.0. A follow-up patch will drop iOS 13 `@available`
checks in the embedder.

This is required in order to use Swift in the embedder and not need to
bundle the Swift runtime libs in every app that uses Flutter. Swift
stable ABI

As of March 2025, usage of iOS is well below 1%, see example public
usage data here:
https://telemetrydeck.com/survey/apple/iOS/majorSystemVersions/

This patch makes the following changes:
1. Updates ios_deployment_target from 12.0 to 13.0.
2. Changes templates to `IPHONEOS_DEPLOYMENT_TARGET`,
`MinimumOSVersion`, and Podfile `platform :ios` to 12.0.
3. Adds migrator for Podfile part to migrate `platform :ios, '11.0'` ->
`platform :ios, '12.0'`
4. Compiles with `-miphoneos-version-min=12.0`
5. Runs the migrator on all example apps and integration tests.
6. Updates examples, tests to iOS 13 deployment target

It also updates `verify_exported.dart`:
* iOS 13 introduces stricter separation of const and non-const global
symbols. Previously, these were declared in the Mach-O `__DATA` section
which may be mapped read-write, but now they're in a dedicated
`__DATA_CONST` section which is mapped read-only. This adds
`(__DATA_CONST,__const)` to the allowlist with the same enforcement on
exported symbol naming as before.

See also (ios_deployment_target):
* https://github.com/flutter/buildroot/pull/808
* https://github.com/flutter/buildroot/pull/574

See also (template, migrator):
* https://github.com/flutter/flutter/pull/62902
* https://github.com/flutter/flutter/pull/85174
* https://github.com/flutter/flutter/pull/101963
* https://github.com/flutter/flutter/pull/140478

Issue: https://github.com/flutter/flutter/issues/167735

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-04-24 20:15:13 +00:00
Jonah Williams
d2d453fdc5
[Impeller] fix playground validation errors in imgui overlay. (#167491) 
Fixes https://github.com/flutter/flutter/issues/167316

Recycling the render passes didn't account for a render pass changing
from MSAA to non-MSAA.
 2025-04-24 20:06:00 +00:00
auto-submit[bot]
bf108a5474
Reverts "[Impeller] defer impeller context initialization onto the raster thread. (#167527)" (#167748) 
<!-- start_original_pr_link -->
Reverts: flutter/flutter#167527
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: gmackall
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: failing postsubmit `Linux_mokey
flutter_engine_group_performance`
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: jonahwilliams
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {jason-simmons}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
Attempt to speed up vulkan startup by ensuring vulkan driver
initialization happens on raster thread. Prev. we immediately
initialized the impeller::Context, unfortunately setting up the vulkan
context can take upwards of 100ms. This time is running on the platform
thread and blocking startup.

Instead, I attempt to hide/defer as much as possible what backend is
being used - this requires us to access the impeller context via a
shared_future in some cases instead of immediately knowing it is valid.

<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
 2025-04-24 19:20:38 +00:00
Jonah Williams
97f358fd0a
[Impeller] defer impeller context initialization onto the raster thread. (#167527) 
Attempt to speed up vulkan startup by ensuring vulkan driver
initialization happens on raster thread. Prev. we immediately
initialized the impeller::Context, unfortunately setting up the vulkan
context can take upwards of 100ms. This time is running on the platform
thread and blocking startup.

Instead, I attempt to hide/defer as much as possible what backend is
being used - this requires us to access the impeller context via a
shared_future in some cases instead of immediately knowing it is valid.
 2025-04-24 17:35:25 +00:00
Reid Baker
46ef0dea2f
Remove flutter engine repo links (#167481) 
3 notable places I did not migrate. 

1. engine/src/flutter/docs/Engine-disk-footprint.md treemaps and what
hash is used for what upload.
1. engine/src/flutter/lib/gpu/pubspec.yaml, I didnt want this pr to
update code that could need to be reverted and I didnt know what to do
to test that publishing would not break or cause a downstream breakage.
1. engine/src/flutter/build/zip_bundle.gni I wasnt sure how to test my
changes.

Reviewers: Please let me know if you want a different link or if you
would prefer something unmodified.

Commits: 
- **Replace triage links with equivalents, change pull request to
generic flutter/flutter, replace code search link with equivalent**
- **Change link from flutter/engine to engine folder, modify link text
to team**
- **replace engine repo link with engine folder, replace text repo with
folder**
- **replace engine specific security info with flutter generic**
- **replace engine roller comment with a skia roller equivalent**
- **link to same file in new location**
- **Remove comment that some code lives in flutter/flutter and some in
flutter/engine**
- **Say to bump dart in flutter/flutter without mentioning engine**
- **Replace documentation with new locations**
- **replace code printed comments with new locations**

Partially addresses https://github.com/flutter/flutter/issues/167478

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
 2025-04-24 15:15:21 +00:00
engine-flutter-autoroll
138b10a68b
Roll Dart SDK from b966487154ae to 73641e1ef4f2 (2 revisions) (#167723) 
https://dart.googlesource.com/sdk.git/+log/b966487154ae..73641e1ef4f2

2025-04-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-51.0.dev
2025-04-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-50.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert
to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-24 14:59:39 +00:00
engine-flutter-autoroll
0f8beea2c2
Roll Dart SDK from 42a6f189b87a to b966487154ae (1 revision) (#167711) 
https://dart.googlesource.com/sdk.git/+log/42a6f189b87a..b966487154ae

2025-04-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-49.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert
to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-24 10:02:27 +00:00
engine-flutter-autoroll
49073a652f
Roll Dart SDK from 71102b6b910c to 42a6f189b87a (1 revision) (#167702) 
https://dart.googlesource.com/sdk.git/+log/71102b6b910c..42a6f189b87a

2025-04-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-48.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert
to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-24 04:53:26 +00:00
engine-flutter-autoroll
d47118b28b
Roll Skia from 3f703c75ca4c to 0b9c3c4b12c1 (8 revisions) (#167700) 
https://skia.googlesource.com/skia.git/+log/3f703c75ca4c..0b9c3c4b12c1

2025-04-23 robertphillips@google.com [graphite] Add option to specify
Paint-color opacity for Precompilation
2025-04-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 305ec8e5086e to db6394105846 (9 revisions)
2025-04-23 jvanverth@google.com Reland "[graphite] Free backing data for
Plots when we no longer need it."
2025-04-23 nicolettep@google.com [graphite] Store different dst read
strategies for single versus multisampling
2025-04-23 borenet@google.com [infra] Add script to format jobs.json
2025-04-23 robertphillips@google.com [graphite] Split
DrawTypeFlags::kSimpleShape into sub-types
2025-04-23 borenet@google.com [infra] Remove more jobs which no longer
have machines to run them
2025-04-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 962e147a59f4 to 6f9f343a2493 (12 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
chinmaygarde@google.com,jmbetancourt@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-24 03:58:18 +00:00
Matt Boetger
3438da3cf4
Remove Robolectric.setupActivity from engine junit tests (#167607) 
Remove the deprecated Robolectric.setupActivity from the engine junit
tests. This replaces it with the ActivityScenario.

Activity Scenario documentation

https://developer.android.com/reference/androidx/test/core/app/ActivityScenario
Extension function that sets up and shuts down an activity before and
after each test.

https://developer.android.com/reference/androidx/test/ext/junit/rules/ActivityScenarioRule

Fixes #133151

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
 2025-04-24 01:23:10 +00:00
engine-flutter-autoroll
f5ae49a862
Roll Dart SDK from 19c25afca603 to 71102b6b910c (1 revision) (#167690) 
https://dart.googlesource.com/sdk.git/+log/19c25afca603..71102b6b910c

2025-04-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-47.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert
to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-23 23:52:08 +00:00
Jason Simmons
e1630da24f
Fix a race in ShellTest.EncodeImageFailsWithoutGPUImpeller (#167669) 2025-04-23 22:18:40 +00:00
engine-flutter-autoroll
79a033bb15
Roll Dart SDK from 55cfa1d9f847 to 19c25afca603 (2 revisions) (#167666) 
https://dart.googlesource.com/sdk.git/+log/55cfa1d9f847..19c25afca603

2025-04-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-46.0.dev
2025-04-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-45.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert
to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-23 18:48:13 +00:00
engine-flutter-autoroll
4b4b1dd483
Roll Fuchsia Linux SDK from 8ftPq5MhZkxE_XSi1... to kv7EzI7mADDgRbtmL... (#167661) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC chinmaygarde@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-23 17:37:49 +00:00
Chinmay Garde
5896cefa18
[Impeller] Make incremental builds faster when tinkering on the compiler. (#167492) 
GN set the Ninja `restat` argument to 1 by default. Which means that it
notes the modification timestamp when writing the contents. Its man page
states "Scripts can improve build performance by taking care not to
change the timstamp of the output file(s) if the contents have not
changed.".

Modifying the compiler will now still re-compile shaders. But if the
shaders have not changed, downstream edges will be culled.

This can be observed in the Ninja progress update after this change.
After editing any file in the compiler, Ninja start out with `(2/866)
LINK ./impellerc`. But as it culls edges, it skips tasks and ends with
`(454/455) ACTION //flutter/...`. Around half the edges are culled. More
importantly, the unit-tests edges are culled as well. For workflows
where only the changed tests are run, this saves a ton of test time in
addition to build time.
 2025-04-23 17:36:20 +00:00
engine-flutter-autoroll
2ffcab0a18
Roll Dart SDK from 721dce1c9199 to 55cfa1d9f847 (1 revision) (#167641) 
https://dart.googlesource.com/sdk.git/+log/721dce1c9199..55cfa1d9f847

2025-04-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-44.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert
to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-23 10:59:25 +00:00
engine-flutter-autoroll
26ebdca6b4
Roll Dart SDK from ba5acf1e38b1 to 721dce1c9199 (1 revision) (#167611) 
https://dart.googlesource.com/sdk.git/+log/ba5acf1e38b1..721dce1c9199

2025-04-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-43.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert
to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-23 02:15:34 +00:00
engine-flutter-autoroll
0de0514761
Roll Skia from 1fb8f012de1b to be6f3563f1a0 (20 revisions) (#167609) 
https://skia.googlesource.com/skia.git/+log/1fb8f012de1b..be6f3563f1a0

2025-04-22 thomsmit@google.com Reland "[graphite] Update DrawWriter to
minimize binds by using pending base offsets."
2025-04-22 borenet@google.com [infra] Remove old MacMini9.1 Mac13 tasks
2025-04-22 danieldilan@google.com Add necessary include to compile
RustPNG (with correct flag name)
2025-04-22 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
Dawn from 32c8fdb708ef to 9428adfc1d3b (25 revisions)
2025-04-22 jmbetancourt@google.com Update buildtools version
2025-04-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from c70bb7aae968 to 00949bebf147 (1 revision)
2025-04-22 jamesgk@google.com [graphite] Ignore no-op nodes when lifting
shader expressions
2025-04-22 kjlubick@google.com Remove old alias for making pinnable
images
2025-04-22 kjlubick@google.com Make tail pixel scratch pad be aligned
for possibly better performance
2025-04-22 kjlubick@google.com Remove alignment assumptions in highp
gather
2025-04-22 kjlubick@google.com Enable C++20 for Clang-Tidy job
2025-04-22 danieldilan@google.com Add necessary include to compile
RustPNG
2025-04-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from f355e2b37ed4 to 962e147a59f4 (2 revisions)
2025-04-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 1eef77795230 to c70bb7aae968 (6 revisions)
2025-04-21 lukasza@chromium.org [rust png] Remove non-granular `.gni`
file lists.
2025-04-21 kjlubick@google.com Avoid assumption of 32 bit aligned pixel
data in RP's lowp gather()
2025-04-21 michaelludwig@google.com [graphite] Use TextureFormat in
AttachmentDesc
2025-04-21 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
Dawn from fe0be9e4b4f9 to 32c8fdb708ef (1 revision)
2025-04-21 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
vulkan-deps from 61080f55d11e to 1eef77795230 (11 revisions)
2025-04-21 kjlubick@google.com Use c++20 when building Dawn

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
chinmaygarde@google.com,jmbetancourt@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-23 01:29:26 +00:00
Loïc Sharma
08a59c2802
[iOS] Hide keyboard on hot restart (#167013) 
This hides the keyboard and text input context menu if you hot restart
your iOS app.

Before | After
-- | --
<video
src="https://github.com/user-attachments/assets/7ca5dbfe-a809-478c-9b36-4c168527b176"
/> | <video
src="https://github.com/user-attachments/assets/d1a48c16-f171-4d22-baa4-5c40488d055b"
/>

Part of https://github.com/flutter/flutter/issues/10713

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-04-22 23:33:02 +00:00
Hannah Jin
46144a2f4d
[a11y] Semanctis flag refactor step 1: engine part (#167421) 
issue: https://github.com/flutter/flutter/issues/166101 


**step 1:** Add struct SemanticsFlags in semantics_node.h and class
SemanticsFlags in dart:ui, it's still a bitmask in embedder and
framework.


TODO: 
Other parts will be in other following  PRs
* Embedder 
add a struct FlutterSemanticsFlags
add FlutterSemanticsFlags* to FlutterSemanticsNode2

* web engine
 use the new class

* SemanticsUpdateBuilder.updateNode
pass a list of bools instead of bitmask

* Framework
use the SemanticsFlags class instead of bitmask

* flutter_tester
use the SemanticsFlags class instead of bitmask
*
[apicheck_test.dart](https://github.com/flutter/flutter/pull/167421/files#diff-69aefaacf1041f639974044962123bfae0756ce86032ac1f26256099425d7a5a)
 Add this test back


*Replace this paragraph with a description of what this PR is changing
or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one
issue. An issue is not required if the PR fixes something trivial like a
typo.*

*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-04-22 22:25:31 +00:00
engine-flutter-autoroll
f47d55f59b
Roll Dart SDK from e596df519dce to ba5acf1e38b1 (9 revisions) (#167585) 
https://dart.googlesource.com/sdk.git/+log/e596df519dce..ba5acf1e38b1

2025-04-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-42.0.dev
2025-04-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-41.0.dev
2025-04-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-40.0.dev
2025-04-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-39.0.dev
2025-04-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-38.0.dev
2025-04-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-37.0.dev
2025-04-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-36.0.dev
2025-04-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-35.0.dev
2025-04-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-34.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert
to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

---------

Co-authored-by: Alexander Aprelev <aam@google.com>
 2025-04-22 22:03:10 +00:00
Jason Simmons
cddd4acaca
Ignore stdout in WindowsTest.LaunchMainHasNoOutput (#167583) 
The stdout stream may receive expected output printed by Dart
(specifically the message announcing the URL where the Dart VM service
is listening)

See https://github.com/flutter/flutter/issues/167418
 2025-04-22 21:57:46 +00:00
Reid Baker
cb3fd95ff6
Update mockito to 5.17.0 from 4.7.0, prework for android 36 support (#167573) 
This updates all the dependencies in
engine/src/flutter/shell/platform/android/test_runner/build.gradle and
ignores the play store deprecration so I could get android studio to
give me other lint help.

This work is required to unblock @jesswrd's work to update the engine to
use android 36.
Deleted mockito-inline because it is automatically used after 5.2.0
according to Maven docs:
https://mvnrepository.com/artifact/org.mockito/mockito-inline/5.2.0"

- **Remove config none annotations that have been deprecrated since
roboletrics 4.0.1**
- **Update all dependencies used in test runner, passes for
spellcheckplugintest**

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
 2025-04-22 20:02:12 +00:00
Jason Simmons
731d2d9e77
Reland "Reduce app startup latency by initializing the engine on a separate thread (#166918)" (#167519) 
This includes a fix for a race seen in
EmbedderTest.PlatformThreadIsolatesWithCustomPlatformTaskRunner

The implementaion of MergedPlatformUIThread::kMergeAfterLaunch required
changing the interface of the TaskObserverAdd/TaskObserverRemove
callbacks so that TaskObserverAdd returned the TaskQueueId where the
observer was added. That TaskQueueId would later be given to
TaskObserverRemove.

The original implementation of this PR updated the embedder library's
implementation of TaskObserverAdd to return TaskQueueId::kInvalid to
signal that the observer was not added. However, this conflicted with
the embedder's EmbedderTaskRunner, whose implementation of
GetTaskQueueId returns TaskQueueId::kInvalid as a placeholder.

This PR reverts the embedder's TaskObserverAdd/TaskObserverRemove to the
original implementation which adds the observer to the current thread's
message loop and does not call GetTaskQueueId.

See https://github.com/flutter/flutter/issues/167418
 2025-04-22 16:36:21 +00:00
Kaylee Lubick
4055380c5e
[skia] Use granular png source file lists (#167550) 
The old file lists were removed in
https://skia-review.googlesource.com/c/skia/+/982376 but we missed
updating Flutter. This should get the Skia->Flutter roll working again

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-04-22 16:01:49 +00:00
Alexander Aprelev
6473b6abef
Roll dart 3.9.0-33.0.dev (#167513) 
Roll dart sdk to 3.9.0-33.0.dev
    
Changes since last roll
```
e596df519dc (HEAD) Version 3.9.0-33.0.dev
4d298786022 Elements. Remove V1 MultiplyDefinedElement.
1b22cd0b15b Elements. Stop implementing V1 TypeDefiningElement in DynamicElementImpl and NeverElementImpl.
84be07364b1 Roll Fuchsia SDK from 27.20250417.3.1 to 27.20250418.3.1
5b123390cdc Elements. Remove V1 AugmentedXyz classes.
4f7eca8cc9b Elements. Remove V1 DartType.element
9fbed46b139 [DAS] Removes operators suggestions from `.` access and more considerations from extension suggestions
801b545cdbd Elements. Remove V1 lookupXyz methods.
04ec005e1e3 Elements. Remove V1 ConstructorElement.
969eeaadfb8 Roll BoringSSL from ef839bf397fb to 45a865d6682a (15 revisions)
```

Update license script to accommodate boringssl license change
 2025-04-22 15:57:29 +00:00
engine-flutter-autoroll
92ff6df1cb
Roll Fuchsia Linux SDK from nggV-vSVM14nIXPsZ... to 8ftPq5MhZkxE_XSi1... (#167556) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC chinmaygarde@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-22 15:32:21 +00:00
chunhtai
b9abb562f9
[Android] removes edge insets from a11y bound calculation (#167136) 
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

fixes android part of https://github.com/flutter/flutter/issues/102725

After throughly tested various configurations from

arm64 API level 25 to API level 35

no cutout/Tall cutout/waterfall cutout

LAYOUT_IN_DISPLAY_CUTOUT_MODE_ALWAYS,
LAYOUT_IN_DISPLAY_CUTOUT_MODE_DEFAULT,
LAYOUT_IN_DISPLAY_CUTOUT_MODE_NEVER

Talkback 7 to talkback 15

none of the combinations would require additional left insets
calculation.

I am not sure why we need it in the first place, but it seems the best
course of action will be removing the code.


## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-04-21 21:07:08 +00:00
ash2moon
8acfa88b77
Refine developer message for announcement use (#167127) 
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

Updates the developer message to include the flutter topline tracking
bug to reduce confusion when using Flutter widgets that use announce.

Example output from logcat:
```
Using AnnounceSemanticsEvent for accessibility is deprecated on Android. Migrate to using semantic properties for a more robust and accessible user experience.
Flutter: If you are unsure why you are seeing this bug, it might be because you are using a widget that calls this method. See https://github.com/flutter/flutter/issues/165510 for more details.
Android documentation: https://developer.android.com/reference/android/view/View#announceForAccessibility(java.lang.CharSequence)
```

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-04-21 20:16:06 +00:00
gaaclarke
46b6668f42
Turned on preserve bindings to impellerc (#167203) 
fixes https://github.com/flutter/flutter/issues/116900

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-04-21 20:16:06 +00:00
gbbosak
b574d40442
Add explicit dependency on the syslog shard (#167210) 
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

Update routing in Flutter to prepare for the removal of the LogSink
shard from RealmBuilder.

https://fxbug.dev/404543928


## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-04-21 19:37:23 +00:00
engine-flutter-autoroll
c169a17d85
Roll Skia from 93544b0c18ee to c91ea1a8fd3f (3 revisions) (#167480) 
https://skia.googlesource.com/skia.git/+log/93544b0c18ee..c91ea1a8fd3f

2025-04-21 jvanverth@google.com [graphite] Re-enable ProxyCache for
ClipAtlasManager.
2025-04-21 kjlubick@google.com Export mac utils Bazel target
2025-04-21 robertphillips@google.com New Chrome Pipeline labels

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC codefu@google.com,jmbetancourt@google.com,kjlubick@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-21 16:24:09 +00:00
engine-flutter-autoroll
e839c67f5d
Roll Fuchsia Linux SDK from RGmU4KeQhrxqE7hsr... to nggV-vSVM14nIXPsZ... (#167473) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC codefu@google.com,zra@google.com on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-21 13:30:26 +00:00
engine-flutter-autoroll
cfb887cd5f
Roll Fuchsia Linux SDK from 0U_vEALFF7qRJZ_cE... to RGmU4KeQhrxqE7hsr... (#167447) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC codefu@google.com,zra@google.com on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-20 08:08:17 +00:00
engine-flutter-autoroll
93e5d81201
Roll Fuchsia Linux SDK from MwYckh5OvwwmIYLx0... to 0U_vEALFF7qRJZ_cE... (#167430) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC codefu@google.com,zra@google.com on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-19 05:01:27 +00:00
Jason Simmons
c5864174d0
Revert "Reduce app startup latency by initializing the engine on a separate thread (#166918)" (#167427) 
This reverts commit c53fdbdf24daba4bc81ccc6d274ce13d7d34d05e.

See https://github.com/flutter/flutter/issues/167418
 2025-04-19 01:03:26 +00:00
auto-submit[bot]
8785fb357d
Reverts "Mark windows_host_engine_test flaky (#167419)" (#167425) 
<!-- start_original_pr_link -->
Reverts: flutter/flutter#167419
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: loic-sharma
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Test should no longer be flaky now that
https://github.com/flutter/flutter/pull/167420 has landed.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: matanlurey
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {jtmcdole}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
See https://github.com/flutter/flutter/issues/167418.
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
 2025-04-18 23:09:48 +00:00