7512 Commits

Author SHA1 Message Date
Michael Goderbauer
b65ed45222 Improvments to bat file (#8377)
Mainly: Don't call out to PoerShell (expansive!) if Dart SDK is upto date.
2017-02-23 12:09:52 -08:00
Chris Bracken
064a63e932 Add haptic feedback tests for DatePicker (#8376) 2017-02-23 10:53:40 -08:00
Chris Bracken
ebaffbdd07 Correct spelling of 'Interval' in var name (#8375) 2017-02-23 10:53:29 -08:00
Todd Volkert
a68c979b73 Add ability to record & replay VMService connection (#8355) 2017-02-23 10:05:00 -08:00
Jakob Andersen
2a05cfdf07 Remove superfluous (and wrong) target file check (#8367) 2017-02-23 16:27:30 +01:00
Jakob Andersen
6d66be17b9 Add support for target file in Gradle builds. (#8364)
If a target file is specified on the flutter tools command line, pass it
through to Gradle.

It is still possible to statically specify a target file in the flutter
section of build.gradle, but it is now possible to specify it on the
command line as well. The command line option takes precedence.

Fixes #8175.
2017-02-23 15:09:05 +01:00
Jakob Andersen
13d7770cf9 Fix local engine support for Gradle builds. (#8362)
Fixes #6761.
2017-02-23 14:56:19 +01:00
Devon Carew
fa04321604 filter an ios simulator assert (#8357) 2017-02-22 20:55:08 -08:00
Chris Bracken
093afe0255 Haptic feedback on time changes in TimePicker (#8348)
Trigger a vibration on hour/minute changes, with an upper bound on
number of feedback events per second.

Note: state changes are expected to trigger haptic feedback on Android,
but not on iOS time pickers.
2017-02-22 19:11:44 -08:00
Hans Muller
3a0b83b1b6 Added support for a pinned floating SliverAppBar (#8345) 2017-02-22 16:19:36 -08:00
Chris Bracken
9ada90a160 Suppress TimePicker haptic feedback on iOS (#8347)
State changes are expected to trigger haptic feedback on Android, but
not on iOS time pickers.
2017-02-22 16:16:52 -08:00
Adam Barth
5e93756f19 Clean up flipping of ScrollDirection (#8343)
Makes RenderViewport.layoutOneSide more readable.
2017-02-22 15:57:32 -08:00
xster
34a6e48ac8 16 dp title margin when there’s no leading button (#8344) 2017-02-22 14:53:53 -08:00
Michael Goderbauer
7201c8c994 add AppVeyor build status badge (#8341) 2017-02-22 14:01:50 -08:00
Michael Goderbauer
28a2b99989 only request sky_snapshot if it is actually needed (#8340) 2017-02-22 13:55:58 -08:00
Adam Barth
fc9a00fd6c Improve the error message for unbounded viewports (#8321)
Rather than generating a cryptic assert, we now generate a more useful error
message.

Fixes #8296
2017-02-22 13:29:13 -08:00
Michael Goderbauer
99ae5a897e Add line about Java version back to flutter doctor (#8332)
Line was accidentally removed by #8320

Also, change the version check from `java` to `javac` since we need the JDK and not just the JRE.
2017-02-22 13:01:53 -08:00
Chris Bracken
6d135e4520 Eliminate extraneous bool in DatePicker haptic feedback (#8337) 2017-02-22 12:51:06 -08:00
Chris Bracken
c8f8d0014a Disable DatePicker vibrate on date change on iOS (#8335)
In the Android native material DatePicker, haptic feedback is expected
on date change. This is not expected behaviour for iOS date/time
pickers.
2017-02-22 12:03:57 -08:00
xster
72fa281f12 Conform appbar buttons to Material (#8263)
Extend app bar left to edge, right to 4dp
Make leading button square and 56dp
Keep title at 72dp on Android according to Material
Renamed IconButton.size to .iconSize
IconButton minimum size expands to 48dp (#8264)
IconButton default constraints to 48. Can still stretch to infinity but can't be smaller than 48.
Ink splash for IconButton 40% bigger than the touch target to match Material
Tests
2017-02-22 11:32:22 -08:00
Hans Muller
52c7a123fc Fixed "AppBar actions are vertically centered" test (#8333) 2017-02-22 11:06:31 -08:00
Michael Goderbauer
7a7f9b68ec add appveyor config (#8323)
appveyor.com runs our tests on Windows for each PR.
2017-02-22 10:34:31 -08:00
Jakob Andersen
a745fd58be Don't reinstall the app if the latest build is already installed. (#8328)
Only implemented for Android devices for now. Compare the installed SHA1
to the latest build. If they match, there's no reason to reinstall the
build.

Fixes #8295
2017-02-22 14:35:49 +01:00
Jakob Andersen
3676ffe477 Fix bug parsing Gradle version. (#8326)
* Fix bug parsing Gradle version.

Version from pub_semver requires versions of the format X.Y.Z. Gradle
doesn't follow semantic versioning, though, so version parsing would
fail on versions like '3.2'. Fixed by writing a custom Version class.

Also removed a check for apksigner when building Gradle-based projects.

Fixes #8298
2017-02-22 11:53:32 +01:00
Michael Goderbauer
e552832635 fix tests on Windows for flutter tools (#8322) 2017-02-21 16:56:37 -08:00
Adam Barth
0e8b6aab46 ListView shouldn't be scrollable when there isn't any scroll extent (#8318)
Previously, a ListView would always accept user input, even if it wasn't
actually scrollable. Now, by default, we don't accept user input if there's no
scroll range. You can override this behavior using the ScrollPhysics.

Fixes #8276
Fixes #8278
Fixes #8271
2017-02-21 16:54:23 -08:00
Michael Goderbauer
7db8241a6d Revert "Revert "Replace jarsigner with apksigner" (#8164)" (#8320)
This reverts commit 70d7fe3a0dede9f3556fda8fe018dc4ed4a08490.

The Java version missmatch on the bots has been resolved.
2017-02-21 16:26:30 -08:00
Adam Barth
b6e282779a Disable menu button when bottom sheet open (#8319)
Otherwise tapping the menu button causes the bottom sheet to disappear and
reappear.

Fixes #8275
2017-02-21 16:25:28 -08:00
Todd Volkert
0d2c9670fd Resolve TODOs to migrate from OperatingSystemUtils to Platform (#8314) 2017-02-21 15:11:49 -08:00
Michael Goderbauer
ac7954c11a Migrate from touch cmd to dart's built-in API (#8313)
This enables us to run more tests on Windows.
2017-02-21 15:11:37 -08:00
Alexandre Ardhuin
e9a775bf38 prefer const constructors (#8316) 2017-02-21 14:54:29 -08:00
Adam Barth
663862557b Factor WillPopScope out of Form (#8311)
This functionality is independently useful.

Fixes #8293
2017-02-21 14:40:13 -08:00
Adam Barth
434d6c3ff8 Improve Stack docs (#8312)
Discuss how to change paint order.
2017-02-21 14:14:25 -08:00
Adam Barth
addcb1f7af Move RenderViewport to its own file (#8310)
It doesn't need to be in the same file as RenderSliver.
2017-02-21 13:13:02 -08:00
Chris Bracken
58898636cc Only attempt to deploy to USB-connected iOS devices (#8309)
Do not attempt to deploy/debug wifi connected iOS devices. ios-deploy is
able to install over wifi, but we've had several bugs reporting failure
to run/debug once installation has completed when the device is also
connected via USB. Note that we don't currently support deploy/debug
over wifi since libimobiledevice (which is also required) requires a USB
connection.
2017-02-21 13:02:50 -08:00
Adam Barth
6d4333410b Don't try to pop the initial route (#8307)
This functionality got lots somehow in the migration to maybePop.

Fixes #8258
2017-02-21 12:57:32 -08:00
Adam Barth
862fc05139 Call onPageChanged at the halfway mark (#8302)
Previously we called onPageChanged when the scroll ended, but that is too late.
Now we call onPageChanged when we cross the halfway mark, which, for example,
makes the tab indicator update earlier.

Fixes #8265
2017-02-21 12:12:34 -08:00
Michael Goderbauer
8c9e18ad0e Workaround for package:test bug (#8304)
Works around https://github.com/dart-lang/test/issues/545
2017-02-21 11:26:43 -08:00
Todd Volkert
73e079fe63 Update to file 2.1.0 (#8305) 2017-02-21 11:17:35 -08:00
Alexandre Ardhuin
da925c7d71 Replace @checked with covariant (#8300)
Fixes #7734
2017-02-21 09:30:22 -08:00
Michael Thomsen
1e1f7703cc Revert "Revert "Update /examples/ to new gradle based build flow (#8173)"" (#8291) 2017-02-21 12:22:26 +00:00
Jakob Andersen
421258baea Remove SHA1 check from AndroidDevice.isAppInstalled() (#8290)
* Remove SHA1 check from AndroidDevice.isAppInstalled()

The docs for isAppInstalled say 'check if a version of the given app is
already installed', however the current code returns true only if it's
the latest build that's installed.

This made sense in the past, when the use pattern was:

  if (!isAppInstalled(...)) installApp(...);

but now the usage is:

  if (isAppInstalled(...)) uninstallApp(...);
  installApp(...);

This has the probably unintended consequence that if you run `flutter
install` or `flutter run` two times in a row with no source changes, the
second invocation will uninstall the app, but the first invocation might
not.

Removing the SHA1 check makes us always uninstall the app if it's
installed.

Fixes #8172
2017-02-21 10:18:12 +01:00
Alexandre Ardhuin
2888139c6b prefer const constructor (#8292) 2017-02-20 14:07:16 -08:00
Jakob Andersen
8b820ccc54 One more fix for finding Android Studio on macOS. (#8288)
Finally found the command to run tests in checked mode on my system. This one should've been caught by the IDE, but wasn't.
2017-02-20 14:27:03 +01:00
Jakob Andersen
0f3cc6e943 Fix finding Android Studio on macOS. (#8287) 2017-02-20 13:19:22 +01:00
Jakob Andersen
77efc38b67 Teach flutter tools to find gradle (#8241)
* Teach flutter tools to find gradle

Flutter tools will now use Gradle from Android Studio, which is now found automatically.

flutter doctor will verify that Android Studio has been installed, and that the included Gradle is at least version 2.14.1.

It is still possible to manually configure the path to Android Studio (flutter config --android-studio-dir=XXX) or Gradle (flutter config --gradle-dir=XXX), but this should only be necessary if they're installed somewhere non-standard.

Only tested on Linux and macOS for now.

Fixes #8131
2017-02-20 11:02:50 +01:00
Adam Barth
df149c0b4b PageView should be able to resize from zero (#8286)
When resizing a PageView from 0x0, we weren't sure what the old page
number was because all the pages are collapsed at zero. Now we avoid the
divide by zero and default to the initialPage.

Fixes #8285
2017-02-19 14:12:57 -08:00
Adam Barth
64bae978f1 Add some dartdocs for slivers (#8284) 2017-02-18 21:00:27 -08:00
Adam Barth
a8e847aba9 PageView shouldn't crash in zero-size container (#8282)
Previously, we were dividing by zero.

Fixes #8281
2017-02-18 13:38:56 -08:00
Adam Barth
257be181fd Add some more dartdocs (#8259) 2017-02-17 21:38:20 -08:00