150 Commits

Author SHA1 Message Date
Hixie
b50d01ca6b Specs: move findId() to TreeScope since it wouldn't be O(1) on Element
Review URL: https://codereview.chromium.org/686243002
2014-10-29 12:22:13 -07:00
Ojan Vafai
959c404854 Remove all writing mode function arguments and remove writing mode from RenderStyle.
R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/683803006
2014-10-29 12:18:30 -07:00
Ojan Vafai
8b0d9e8ac9 First past at removing writing mode.
This removes the parsing and the enum. This leaves a bunch of
dead code around to fix in a followup.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/689743002
2014-10-29 12:17:11 -07:00
Eric Seidel
eb58358bab Slight simplification to prompt code
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/678833004
2014-10-29 12:15:34 -07:00
Eric Seidel
cc5219a17f Don't show sky_server logs to the skydb console
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/692593004
2014-10-29 11:03:54 -07:00
Scott Violet
e782924013 Fixes release build
Only fails in release.

R=abarth@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/684123003
2014-10-29 09:00:25 -07:00
Eric Seidel
9e09e175f9 Add basic console support to Sky's inspector.
I think longer-term we want to instead fork
InjectedScriptSource.js:
http://blink.lc/blink/tree/Source/core/inspector/InjectedScriptSource.js
since a ton of the "remote object" logic could be shared
between Blink and Sky here.

Since we're trying to talk exactly Chrome's inspector
protocol we should start from the Blink JS as much as possible.

That said, this is enough to get the Chrome devtools
inspector to talk to sky and have the console handle
basic commands!

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/674823003
2014-10-29 08:47:10 -07:00
Elliott Sprehn
3ad63531da Remove Nine Patch layers.
These were only used for doing effects in Clank and the
shadows around the page when bouncing on the Mac. Now
they're dead code.

In the future if we decide nine patch is an API we really
want we should expose web platform primitives instead of
having a special API on layer.

R=ojan@chromium.org, abarth@chromium.org

Review URL: https://codereview.chromium.org/685983002
2014-10-28 20:13:46 -07:00
Ojan Vafai
53638e9784 Remove more frame-level scrolling machinery.
We don't need to know anymore whether the scroll was programmatic.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/684063002
2014-10-28 20:10:59 -07:00
Ojan Vafai
6b0469399e Make printing limbo lines in test_sky only print the prefix once.
This makes the output much more readable and you can actually see
stacktraces. Long-term, we need to stick this output into the result
of the previous test instead of having them be printed to stderr.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/686723004
2014-10-28 19:44:29 -07:00
Elliott Sprehn
83ea6e812c Mark hixie's tests as Skip so they don't spam the console.
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/687893003
2014-10-28 19:36:12 -07:00
Ojan Vafai
ce9aa787cb Remove more frame-level scrolling machinery.
This is all dead code. No change in behavior.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/678193005
2014-10-28 19:27:52 -07:00
Elliott Sprehn
82245c19f8 Remove getTickmarks.
R=ojan@chromium.org

Review URL: https://codereview.chromium.org/681293005
2014-10-28 19:22:17 -07:00
Hixie
d7dbe841b4 This CL provides a bunch of new parser tests, and updates the
TestExpectations file to skip the ones that fail or crash. It also
updates the TestExpectations parser to support URLs pointing to the
mojo repo's issue tracker.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/685593006
2014-10-28 18:58:18 -07:00
Ojan Vafai
e246934fb9 Remove more scrolling methods from FrameView.
No change in behavior. Just deleting dead code.
Also removes ScrollAnimatorNone since it's unused.
We'll need to bring some of this back, but we'll
do that when we get rid of composited scrolling.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/682363002
2014-10-28 17:38:08 -07:00
Ojan Vafai
a10806067d Get rid of ScrollbarGroup. Sky doesn't use it.
More cleanup of dead code now that we don't have frame-level scrolling.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/687553006
2014-10-28 17:37:23 -07:00
Elliott Sprehn
dc00d6678b Remove a lot of dead Scrollbar methods.
R=ojan@chromium.org

Review URL: https://codereview.chromium.org/685003003
2014-10-28 17:29:41 -07:00
Adam Barth
74db9da5e1 Add inspect command to skydb
This CL adds an "inspect" command to skydb that injects the inspector module
into the page and prints some instructions for opening the inspector.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/690433004
2014-10-28 17:08:25 -07:00
James Robinson
e061930d2b Update from chromium https://crrev.com/301725/
This updates DEPS to reflect changes in 301725 /
90a7c4e3fdeb82a18e17f24e56345b9086a8308b, imports changes, and adds
a patch file for our ui/gl/gl_surface modifications.

Review URL: https://codereview.chromium.org/669813003
2014-10-28 17:00:48 -07:00
Ojan Vafai
423d08cc86 More cleanup of dead code now that we don't have frame-level scrolling.
No change in behavior. The overflowchanged event was never fired.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/687783003
2014-10-28 16:53:47 -07:00
Elliott Sprehn
b8843caa44 Remove concept of child Widgets.
FrameView doesn't really need to know about the child widgets,
which are just Scrollbars now.

I also deleted some dead code from Widget and removed FrameWidget
since we don't need that abstraction now.

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/685593005
2014-10-28 16:53:12 -07:00
Elliott Sprehn
e379c7382a Remove PageOverlays.
These were related to the inspector overlays, if we want to
do this in the future we should place mojo::Views over the
page in the sky debugger so sky itself doesn't need to manage
the overlay views.

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/687003002
2014-10-28 15:44:00 -07:00
Adam Barth
b1f39b7c1b Move framework/inspector/server to services/inspector
Moving the inspector WebSocket proxy server out of the framework directory
simplifies the mappings for the HTTP servers.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/687673004
2014-10-28 15:38:23 -07:00
Hixie
28fab08e02 Specs: Parser fixes for issues Adam found
Review URL: https://codereview.chromium.org/682283002
2014-10-28 15:15:52 -07:00
Elliott Sprehn
63d21b0287 Remove RenderWidget.
This is part of the old iframe and plugin system, we don't need it.

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/682263003
2014-10-28 15:10:32 -07:00
Elliott Sprehn
2f329e05b0 Remove RenderPart.
This was part of the old plugin system, we don't need it.

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/686903003
2014-10-28 15:01:27 -07:00
Ojan Vafai
c2ceb794d5 Get rid of slow repaint objects and main thread scrolling reasons.
We will only have one scrolling path in Sky, so we don't need
machinery for mutiple scrolling codepaths.

Remove viewportConstrained plumbing.

Sky doesn't have viewport constrained elements (no position:fixed).

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/661633003
2014-10-28 14:57:38 -07:00
Ojan Vafai
223c532e5f Remove viewportConstrained plumbing.
Sky doesn't have viewport constrained elements (no position:fixed).

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/688433003
2014-10-28 14:28:39 -07:00
Elliott Sprehn
4aa67a30c5 Remove AllowUserAgentScript.
This was only used for deprecated plugins in blink,
we don't need it now.

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/687803002
2014-10-28 14:28:30 -07:00
Adam Barth
f3e367c383 Don't crash when importing a module that doesn't export
Instead of crashing, we should use the value "undefined". There's some question
as to whether we should default to the document, but we can resolve that later.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/690483002
2014-10-28 14:13:31 -07:00
Ojan Vafai
f11504f4e8 Remove layerIsContainerForFixedPositionLayers.
We don't have fixed position. We'll later need to remove this
functionality from cc as well.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/680263005
2014-10-28 13:59:57 -07:00
Eric Seidel
6e77ef1031 Fix the inspector and integrate it with skydb
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/690433002
2014-10-28 13:18:17 -07:00
Ojan Vafai
054799183a Remove a bit more position:fixed plumbing.
No change in behavior.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/688443003
2014-10-28 12:56:42 -07:00
Adam Barth
e72e95ebf6 Re-enable the inspector tests
These work again.

R=eseidel@chromium.org, ojan@chromium.org

Review URL: https://codereview.chromium.org/683083004
2014-10-28 12:54:22 -07:00
Eric Seidel
441e3ee815 Add a sky_server for running sky apps
This automatically adds /sky and /mojo mappings
to the generated files for each.

Also taught skydb to use this new server.

R=esprehn@chromium.org, abarth@chromium.org

Review URL: https://codereview.chromium.org/682153003
2014-10-28 12:42:53 -07:00
Adam Barth
f0c80dc8cc Add beginnings of an inspector backend for Sky
R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/687673003
2014-10-28 10:46:47 -07:00
Eric Seidel
70c382c012 Remove wtf/Functional.h
The background parser was the last client.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/684813003
2014-10-28 10:41:02 -07:00
Adam Barth
2328807e06 Fix services/network.sky test
mojo_shell can't handle loading the same DLL from two different URLs.  The
extra trailing slash was causing us to load the network_service DLL twice.

R=ojan@chromium.org, eseidel@chromium.org

Review URL: https://codereview.chromium.org/687703002
2014-10-28 09:55:58 -07:00
Eric Seidel
c32433111b Remove almost all of Oilpan
The only things left are all the baseclasses
and macros in heap/Handle.h which are referenced
throughout all of core.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/686783002
2014-10-28 09:36:50 -07:00
Ojan Vafai
42ea48b379 Remove a bunch of fixed position dead code.
There is not change in behavior here. Just removing dead
code now that we no longer support position:fixed.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/686653002
2014-10-28 09:34:19 -07:00
Adam Barth
4ccdb12605 Move imports-can-load-404s.html to .sky so that it runs 2014-10-28 09:12:36 -07:00
Adam Barth
373117fdb8 Delete WebWaitableEvent
We don't use this interface. In the future, we can just use the base version
directly.

R=eseidel@chromium.org, ojan@chromium.org

Review URL: https://codereview.chromium.org/681173002
2014-10-27 21:50:35 -07:00
Eric Seidel
4d27846f85 Remove Heap.h
Had to move a couple macros into Handle.h
(which we won't be able to remove for
a while yet), but otherwise Heap is dead.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/681113004
2014-10-27 21:04:58 -07:00
Adam Barth
26813e1c3c Update tokenizer to match spec
This CL is a rough pass over the HTMLTokenizer to align it with parsing.md.
We'll need to do another pass more carefully in the future, but this CL gets us
roughly in the right ballpark.

We're not handling EOF properly. The parsing.md spec doesn't push the EOF
though the parser, which breaks our current way of handling EOF. We do ok if we
get EOF in the DataState, and that's enough to pass the tests for now.

Also, update camel-case.sky to reflect the fact that the parser doesn't
lower-case tag names anymore.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/678263002
2014-10-27 20:38:29 -07:00
Adam Barth
17e384c485 Use OSMesa when running Sky tests
This CL switches us to use OSMesa rather than the system GL implementation when
running the Sky tests. This makes the tests more machine-independent and also
makes them work properly in Chromoting and in VirtualBox.

R=ojan@chromium.org, esprehn@chromium.org

Review URL: https://codereview.chromium.org/680243002
2014-10-27 20:36:16 -07:00
Ojan Vafai
9423819dcc First pass at removing position:fixed.
The root is never scrollable, so position:fixed doesn't
do anything anymore.

Also remove some dead frame-level scrolling code that interacted
with fixed position things.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/686633002
2014-10-27 19:42:46 -07:00
Eric Seidel
6b82826198 Remove various Heap* types.
Also removed a bunch of trace() methods which
I touched by accident.  Turns out they're
all very interconnected sadly.

I re-wrote Supplement to not use templates
in an earlier version of this patch
but hit some trouble with vtables
and decided to table that work
for a later time once more of oilpan
has been unwound.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/683703003
2014-10-27 18:19:46 -07:00
Eric Seidel
e9e27699ad Remove GarbageCollectedFinalized
This class didn't actually do anything anymore.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/655083003
2014-10-27 17:41:38 -07:00
Hixie
de0ba17e8f Move the tests from .html to .sky
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/685623002
2014-10-27 17:35:15 -07:00
Adam Barth
c198c32164 Don't crash when importing a 404
Now we have a test for this case.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/682913002
2014-10-27 17:22:55 -07:00