DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
34,633 Commits 882 Branches 1,069 Tags
Commit Graph

34633 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
John McCutchan
aba108f662 Small improvements to et lint command (flutter/engine#51372) 
- Default to dumping out lint logs (can be disabled with `--quiet`
flag).
- Add Logger.fatal which logs an error and throws a FatalError which is
caught in main.
- Simplify `findDartBinDirectory` implementation.
- Make JSON serialized process artifacts more human readable.
 2024-03-13 13:39:08 -07:00
Jonah Williams
b5e86684b0 [Impeller] cleanup and test vk image usage flags. (flutter/engine#51301) 
Cleanups to the vk::ImageUsageFlagBits

* add unit tests
* remove input attachment from depth stencil
* remove defensive checks
 2024-03-13 19:39:01 +00:00
skia-flutter-autoroll
8f4cbc1831 Roll Skia from 1ad0d0fabe7a to a315e4572f4e (7 revisions) (flutter/engine#51377) 
https://skia.googlesource.com/skia.git/+log/1ad0d0fabe7a..a315e4572f4e

2024-03-13 brianosman@google.com Remove SkSerialProcs and SkDeserialProcs from Slug serialization
2024-03-13 robertphillips@google.com [graphite] Add Perlin noise shader to Precompilation system
2024-03-13 robertphillips@google.com Add CoordClampShader to Precompilation system
2024-03-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from e649d06fbad1 to d9ecf127ac94
2024-03-13 briansalomon@gmail.com [graphite] SkImage::WrapTexture allows client to request mipmap gen
2024-03-13 drott@chromium.org [Fontations-backend] Initial implementation of onGetAdvancedMetrics()
2024-03-13 drott@chromium.org [Fontations-backend] rustfmt ffi.rs

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-13 18:53:12 +00:00
Matej Knopp
9fac4c3db6 Reland "Reland: [macOS] Use CVDisplayLink to drive repaint" (flutter/engine#51210) 
[Original reland](https://github.com/flutter/engine/pull/51126) was
[reverted](f29d809efb)
because of skiaperf regressions. The regressions are caused by runner
machines running display at 30hz.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-03-13 19:20:16 +01:00
Jonah Williams
0cdb8526d2 [Impeller] fix heap selection process for YUV textures. (flutter/engine#51262) 
This does not fix the emulator weirdness!

Today we automatically select the first memory type index requested by an AHB. The device in question may lack that memory type index, so we can then fail to import the AHB. Additionally, if we do fail we need to ensure that we don't attempt to display the texture.
 2024-03-13 18:18:48 +00:00
zijiehe@
224b7f08ff [Fuchsia] Enable sound null safety everywhere (flutter/engine#51355) 
This change enables null_safety on fuchsia everywhere and remove the legacy conditions.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-03-13 17:56:05 +00:00
gaaclarke
0c6a230ad2 [Impeller] added missing golden test for DrawScaledTextWithPerspectiveSaveLayer (flutter/engine#51368) 
related:
 - https://github.com/flutter/flutter/issues/130633
 - https://github.com/flutter/engine/pull/51343

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-03-13 17:49:49 +00:00
skia-flutter-autoroll
6f9967a2db Roll Skia from dc7443fa4d88 to 1ad0d0fabe7a (1 revision) (flutter/engine#51373) 
https://skia.googlesource.com/skia.git/+log/dc7443fa4d88..1ad0d0fabe7a

2024-03-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 6b4cf4e2ca6b to 91aab7b7e25f (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-13 17:37:45 +00:00
Juanjo Tugores
db857bd325 Implement PlatformDispatcher.requestViewFocusChange on web. (flutter/engine#50535) 
Implement PlatformDispatcher.requestViewFocusChange on web. 

Relevant Issues are:

* Design doc: https://flutter.dev/go/focus-management 
* Focus in web multiview: https://github.com/flutter/flutter/issues/137443
* Platform dispatcher changes: https://github.com/flutter/engine/pull/49841

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-03-13 17:37:44 +00:00
Jonah Williams
674874e613 [Impeller] attempt to get validation errors from CI unittests. (flutter/engine#51341) 
Enables Vulkan validation layers for macOS and linux builds, enables macOS validation for macOS builds.

Fixes https://github.com/flutter/flutter/issues/144967

There may still be remaining issues with macOS validation, I need to verify I can reproduce https://github.com/flutter/flutter/issues/143324 . I plan to do that separately
 2024-03-13 17:35:58 +00:00
skia-flutter-autoroll
38d2c40d8d Roll Dart SDK from b19e0995f317 to 18ec60df0774 (1 revision) (flutter/engine#51374) 
https://dart.googlesource.com/sdk.git/+log/b19e0995f317..18ec60df0774

2024-03-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-228.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-13 17:33:54 +00:00
Jonah Williams
3b105855ac [scenario app] make image matching fuzzier. (flutter/engine#51376) 
Attempt to work around the minor 1px differences from
https://github.com/flutter/flutter/issues/145058
 2024-03-13 09:50:50 -07:00
skia-flutter-autoroll
fd1b1e383b Roll Skia from bbe453e3525d to dc7443fa4d88 (1 revision) (flutter/engine#51371) 
https://skia.googlesource.com/skia.git/+log/bbe453e3525d..dc7443fa4d88

2024-03-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 38c0aeb0143f to 7456bed4cecf (11 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-13 07:01:04 +00:00
skia-flutter-autoroll
92baa406b2 Roll Fuchsia Linux SDK from UR-nKoLidl7cVLrrN... to mYZPzdM3hCE1TA91s... (flutter/engine#51370) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-13 06:55:12 +00:00
Jim Graham
3485a463a9 Add a comparative benchmark for SkM44 vs SkMatrix vs impeller::Matrix (flutter/engine#51332) 
In preparation for converting the DisplayList and engine Layer code to using Impeller data structures the performance differential for the various transform objects is important information. According to this benchmark, the performance of Impeller's data structure is sometimes faster and never significantly worse than the Skia objects.
 2024-03-13 06:55:10 +00:00
John McCutchan
c2d3e6ce09 Add et lint command (flutter/engine#51238) 
- Invokes lints for dart, python, c, and java.
- Captures all output of executions into an artifacts file (a json
file).
- Runs lints concurrently.
- Cool status display while running.
- Tests.
 2024-03-12 23:29:25 -07:00
Matan Lurey
e889b287f1 Refactor golden_tests_harvester, throw when not --dry-run, add tests. (flutter/engine#51364) 
Closes https://github.com/flutter/flutter/issues/144948.

I went a little farther, as I'm not looking forward to debugging this in the future without tests or examples.
 2024-03-13 03:45:17 +00:00
Brandon DeRosier
ad2ae9605d Copy the flutter_gpu package into the engine artifacts. (flutter/engine#51365) 
Part of https://github.com/flutter/flutter/issues/131711.
 2024-03-13 02:30:19 +00:00
Chinmay Garde
6a151f5c40 [Impeller] Make masks type safe. (flutter/engine#51369) 
Uses the utility added in https://github.com/flutter/engine/pull/51361

I counted the removal of 58 static casts. There was one addition made to the original utility however. Vulkan HPP was promoting all enums to its own mask type. This in itself is problematic but we got away with it because there was no one else doing this kind of promotion. Till we added our own utility. To avoid polluting the namespace with methods that may cause ambiguity, enums that are masks must explicitly be marked as maskable with `IMPELLER_ENUM_IS_MASK` in the `impeller` namespace.

No change in functionality.
 2024-03-13 00:12:21 +00:00
Brandon DeRosier
fa6808182c Remove early Flutter GPU prototype from ui/experiments. (flutter/engine#51367) 
We moved to lib/gpu some time ago!
(Initially added with https://github.com/flutter/engine/pull/42228)
 2024-03-12 16:09:58 -07:00
Jason Simmons
e669520a2e Fix some races in the platform isolate tests (flutter/engine#51358) 
* Do not check IsolateIsShutdown after CreateAndRegisterIsolate in the MultithreadedCreation test.

The test's main thread could run ShutdownPlatformIsolates between a worker thread's calls to CreateAndRegisterIsolate and IsolateIsShutdown.  If that happens, IsolateIsShutdown will return true even though CreateAndRegisterIsolate succeeded.

* Change the is_registered flag to was_registered and do not clear it during isolate shutdown

Tests like MultithreadedCreation need to know whether RegisterPlatformIsolate succeeded so they can determine if the isolate will be shut down by ShutdownPlatformIsolates or if it needs to be shut down explicitly.  If the flag is cleared during shutdown, then the test may see an isolate that was successfully registered and shut down and think that it was never registered.
 2024-03-12 22:34:34 +00:00
skia-flutter-autoroll
f784aad8db Roll Skia from 187488b64570 to bbe453e3525d (1 revision) (flutter/engine#51366) 
https://skia.googlesource.com/skia.git/+log/187488b64570..bbe453e3525d

2024-03-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 804247a574ea to 6b4cf4e2ca6b (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-12 22:34:31 +00:00
Pavel Mazhnik
a9c40d24b7 [web] make addView/removeView functions sync (flutter/engine#51103) 
Related to https://github.com/flutter/flutter/issues/138930
 2024-03-12 22:29:27 +00:00
skia-flutter-autoroll
514a3895ce Roll Dart SDK from 7f26f32f374f to b19e0995f317 (1 revision) (flutter/engine#51363) 
https://dart.googlesource.com/sdk.git/+log/7f26f32f374f..b19e0995f317

2024-03-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-227.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-12 22:17:31 +00:00
Loïc Sharma
b2f119de6b [dart:ui] Add view ID to PointerData.toString (flutter/engine#51352) 
The `view_id` is useful information as the pointer's `x` and `y` coordinates are relative to the view's origin.

Part of https://github.com/flutter/flutter/issues/112205
Part of https://github.com/flutter/flutter/issues/142845

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-03-12 21:53:41 +00:00
Jim Graham
242e59c98f Fix null filter NOP case in DlLocalMatrixImageFilter (flutter/engine#51340) 
The `DlLocalMatrixImageFilter` was returning null from the bounds methods when it had no filter to apply which violates the method contracts. It should have been setting the result rect to the argument rect and returning a valid pointer to meet the method contract.
 2024-03-12 21:37:58 +00:00
skia-flutter-autoroll
6bc59d4b47 Roll Skia from 47baa55b4669 to 187488b64570 (1 revision) (flutter/engine#51362) 
https://skia.googlesource.com/skia.git/+log/47baa55b4669..187488b64570

2024-03-12 brianosman@google.com Remove initialPaint from Slug

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-12 21:33:19 +00:00
Chinmay Garde
67ee7c76fe [Impeller] Add utility for type safe masks. (flutter/engine#51361) 
We use and recommend type safe enums. But when it comes to masks of those enums (`TextureUsageMask`, `ColorWriteMask`, etc.), these are all untyped and you can create one either from a scalar of the enums underlying type, or using ugly and error prone static casts. At the callee, there is no type checking and another error prone static cast.

This patch adds a type-safe mask type. This should allow for the migration of something like:

```c++
using TextureUsageMask = uint64_t;
```

with

```c++
using TextureUsageMask = Mask<TextureUsage>;
```

Subsequently, all static casts can be removed with full type checking throughout.

This doesn't migrate existing uses yet. That will come in a separate patch.
 2024-03-12 20:59:08 +00:00
skia-flutter-autoroll
fde1e9cf6c Roll Dart SDK from c97f2b303259 to 7f26f32f374f (3 revisions) (flutter/engine#51359) 
https://dart.googlesource.com/sdk.git/+log/c97f2b303259..7f26f32f374f

2024-03-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-226.0.dev
2024-03-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-225.0.dev
2024-03-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-224.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-12 20:04:40 +00:00
skia-flutter-autoroll
7aa4b116d5 Roll Skia from 6e1f7333b2c7 to 47baa55b4669 (2 revisions) (flutter/engine#51360) 
https://skia.googlesource.com/skia.git/+log/6e1f7333b2c7..47baa55b4669

2024-03-12 robertphillips@google.com [graphite] Add Empty shader to PaintParamsKeyTest
2024-03-12 robertphillips@google.com [graphite] Add UniqueKeyUtils in order to share code

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-12 20:01:53 +00:00
Brandon DeRosier
40c0cdea26 [Impeller] Fix shader depth assignment & glyph atlas transform. (flutter/engine#51343) 
Resolves https://github.com/flutter/flutter/issues/144333.

This patch fixes two things:
* Absorb the homogenous component of the position before overriding the depth in all shaders that take a depth value. This ensures the transform can't end up affecting the depth.
* The glyph atlas transform: The same as @jason-simmons's fix in https://github.com/flutter/flutter/issues/144333#issuecomment-1986679500.

Before:
![Screenshot 2024-03-11 at 4 37 27 PM](https://github.com/flutter/engine/assets/919017/225171c0-87b6-4a95-a452-8ec139b92d24)

After:
![Screenshot 2024-03-11 at 4 38 16 PM](https://github.com/flutter/engine/assets/919017/62f6e803-6d2d-464f-a470-86fee898215f)
 2024-03-12 19:40:57 +00:00
Jackson Gardner
f646f9a40c Reland "Move emscripten out of the buildroot into the flutter repo" (flutter/engine#51353) 
This is a reland of the change moving the emsdk out of the buildroot, but without the removal of `web_dependencies`, since that removal was causing issues with the rollers.
 2024-03-12 18:32:08 +00:00
skia-flutter-autoroll
923a4f8a24 Roll Skia from c123cce23f20 to 6e1f7333b2c7 (1 revision) (flutter/engine#51356) 
https://skia.googlesource.com/skia.git/+log/c123cce23f20..6e1f7333b2c7

2024-03-12 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from f495bf1066de to ab71002e68a2 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-12 18:14:04 +00:00
skia-flutter-autoroll
4cba92e851 Roll Skia from 32f1cb50734a to c123cce23f20 (9 revisions) (flutter/engine#51351) 
https://skia.googlesource.com/skia.git/+log/32f1cb50734a..c123cce23f20

2024-03-12 robertphillips@google.com Skip image_from_yuv_textures on the Nexus7
2024-03-12 blnvdanil@gmail.com Handle drawing oval, rect and rrect with path effect in svg
2024-03-12 herb@google.com Add bulk option for quick unpremul
2024-03-12 brianosman@google.com Remove legacy (incorrect) non-AA edge rounding code
2024-03-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 51c9e2056611 to 804247a574ea (2 revisions)
2024-03-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 38c0aeb0143f to 29928baa390b
2024-03-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 912fc2090a1b to 38c0aeb0143f (7 revisions)
2024-03-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 12c6b842d83d to f495bf1066de (15 revisions)
2024-03-11 kjlubick@google.com Add SkCodec API to preserve original data

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-12 17:15:50 +00:00
Chris Bracken
dd2227c9f9 Migrate perfetto to flutter/third_party (flutter/engine#51272) 
Migrate perfetto from the buildroot's third_party directory to the engine's.

Issue: https://github.com/flutter/flutter/issues/144204
Part of: https://github.com/flutter/flutter/issues/67373

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-03-12 17:12:06 +00:00
Gray Mackall
25865c11b1 Try making android scenario app not do animations (flutter/engine#51349) 
Skips animations

Looks like this, for reference:
[no_animation_example.webm](https://github.com/flutter/engine/assets/34871572/0c8665a3-b546-4bbd-b7e1-00851c48e1ff)

(This is the animation from https://github.com/flutter/engine/pull/51329, so note that the first test looks weird because I lagged my emulator by alt tabbing).

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-03-12 17:03:18 +00:00
skia-flutter-autoroll
5958146dbb Roll Dart SDK from 7a2c94fd0a26 to c97f2b303259 (1 revision) (flutter/engine#51345) 
https://dart.googlesource.com/sdk.git/+log/7a2c94fd0a26..c97f2b303259

2024-03-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.4.0-223.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter Engine:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-12 08:35:36 -07:00
skia-flutter-autoroll
e40f26e9de Roll Fuchsia Linux SDK from L6_XzizcJqjneCvGA... to UR-nKoLidl7cVLrrN... (flutter/engine#51344) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-12 04:09:31 +00:00
gaaclarke
06027becb6 [Impeller] implements blur styles for gradients (flutter/engine#51264) 
fixes https://github.com/flutter/flutter/issues/144449

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-03-12 00:05:19 +00:00
Xilai Zhang
0fbd9368b6 [codesign] fix typo in binary path (flutter/engine#51339) 
failure in release: [link](https://logs.chromium.org/logs/dart-internal/buildbucket/cr-buildbucket/8753728916366397505/+/u/Global_generators/Codesign__Volumes_Work_s_w_ir_cache_builder_src_out_release_framework_unsigned_framework.zip/codesign_Apple_engine_binaries/stdout)

Updates x84 to x86
 2024-03-11 23:37:26 +00:00
David Iglesias
e62c718145 [web] Split initialization of the _flutter namespace and loader object. (flutter/engine#51294) 
This makes it possible to more flexibly compose `{{flutter_js}}` and `{{flutter_build_options}}` in @eyebrowsoffire's [bootstrapping improvements PR](https://github.com/flutter/flutter/pull/144434).

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-03-11 23:21:17 +00:00
skia-flutter-autoroll
41a13ea3e5 Roll Dart SDK from 09a1a1ede1c4 to 7a2c94fd0a26 (1 revision) (flutter/engine#51338) 
https://dart.googlesource.com/sdk.git/+log/09a1a1ede1c4..7a2c94fd0a26

2024-03-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-222.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-11 23:17:55 +00:00
skia-flutter-autoroll
f324bb2a69 Roll Skia from 6f10903e2d28 to 32f1cb50734a (5 revisions) (flutter/engine#51331) 
https://skia.googlesource.com/skia.git/+log/6f10903e2d28..32f1cb50734a

2024-03-11 brianosman@google.com Change Slug drawing to accept a paint at draw-time
2024-03-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f5ef6971f8fb to 51c9e2056611 (1 revision)
2024-03-11 johnstiles@google.com Fix ClangTidy readability-redundant-control-flow warning.
2024-03-11 jvanverth@google.com [graphite] Add zero-sized path handling to new RasterPathAtlas method.
2024-03-11 briansalomon@gmail.com [graphite] Support mipmap filtering for YUVA Images

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-11 23:13:47 +00:00
Gray Mackall
9eedb6ab86 Make scenario app have translucent splash screen so it doesn't affect screenshot colors (flutter/engine#51329) 
Makes the scenario app splash screen have a translucent color, so it doesn't end up overlaying on screenshots.

Before:
[device-2024-03-07-152047.webm](https://github.com/flutter/flutter/assets/34871572/a9b7a1f9-57ab-4eda-93e5-5ca70032cbef)

After:
[translucentsplash.webm](https://github.com/flutter/engine/assets/34871572/a6eb6407-add0-4004-83f9-4e0a5c1bb6f6)

This sort of fixes https://github.com/flutter/flutter/issues/144657? The issue is still odd to me, though, because I don't know why the test runner wouldn't be waiting properly for the splash screen.

Bonus, this is what it looks like if we [change the runner](a70a0abdec/testing/scenario_app/bin/run_android_tests.dart (L352)) to not use animations, with `--no-window-animation` (but don't include the splash screen change):
[no_animation_example.webm](https://github.com/flutter/engine/assets/34871572/0c8665a3-b546-4bbd-b7e1-00851c48e1ff)
You can see there is still a moment of color change at the end of tests (ignore the very first test I was alt tabbing and lagged out my emulator).

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-03-11 23:04:55 +00:00
Zachary Anderson
7fac661f11 [gn] Change sdk_rewriter() template to use depfiles (flutter/engine#51314) 
Part of https://github.com/flutter/flutter/issues/144430

From `gn help inputs`: "It may be tempting to write a script that enumerates all files in a directory
as inputs. Don't do this!"
 2024-03-11 21:46:01 +00:00
auto-submit[bot]
0c2c540e72 Reverts "Move emscripten out of the buildroot into the flutter repo. (#51299)" (flutter/engine#51330) 
Reverts: flutter/engine#51299
Initiated by: zanderso
Reason for reverting: Blocking the autoroller
Original PR Author: eyebrowsoffire

Reviewed By: {matanlurey}

This change reverts the following previous change:
This migrates the emscripten toolchain into the flutter repo, as well as the fonts for web unit tests. Also, removed the `web_dependencies` thing which is no longer used.

This fixes https://github.com/flutter/flutter/issues/143332

Depends on a buildroot change here: https://github.com/flutter/buildroot/pull/833
 2024-03-11 20:39:25 +00:00
skia-flutter-autoroll
43010eed2e Roll Skia from ff1eb5af6ce4 to 6f10903e2d28 (3 revisions) (flutter/engine#51326) 
https://skia.googlesource.com/skia.git/+log/ff1eb5af6ce4..6f10903e2d28

2024-03-11 bungeman@google.com Initialize fontations geometry sink
2024-03-11 jgaillard@google.com Add SkSharingProc to Android host builds
2024-03-11 nscobie@google.com Add nscobie back to OWNERS_build_files.android

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-11 20:23:16 +00:00
Matan Lurey
15779b7847 Conditionally run golden_tests_harvester for run_impeller_golden_tests. (flutter/engine#51325) 
I think this restores the behavior prior to
https://github.com/flutter/engine/pull/50844 without making the client
code faulty.

I'll file a follow-up issue, I don't think `golden_tests_harvester`
should accept running if `GOLDCTL` isn't set:
https://github.com/flutter/flutter/issues/144948.

/cc @godofredoc
 2024-03-11 12:10:57 -07:00
skia-flutter-autoroll
a70a0abdec Roll Dart SDK from c3bd630e89bb to 09a1a1ede1c4 (1 revision) (flutter/engine#51324) 
https://dart.googlesource.com/sdk.git/+log/c3bd630e89bb..09a1a1ede1c4

2024-03-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-221.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-11 18:27:12 +00:00
Jackson Gardner
048ee12c07 Move emscripten out of the buildroot into the flutter repo. (flutter/engine#51299) 
This migrates the emscripten toolchain into the flutter repo, as well as the fonts for web unit tests. Also, removed the `web_dependencies` thing which is no longer used.

This fixes https://github.com/flutter/flutter/issues/143332

Depends on a buildroot change here: https://github.com/flutter/buildroot/pull/833
 2024-03-11 17:24:19 +00:00