DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
30,815 Commits 882 Branches 1,069 Tags
Commit Graph

30815 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jackson Gardner
ab84ec613c Allow optional codepoints to be expressed to the font subset generator. (flutter/engine#44864) 
This is the engine side change to fix https://github.com/flutter/flutter/issues/132711. There will be a subsequent framework change to express the space character as an "optional" character.
 2023-08-18 22:08:10 +00:00
skia-flutter-autoroll
a1a247f7a2 Roll Skia from 2ddec49abd5c to e9cf3f1740eb (3 revisions) (flutter/engine#44862) 
https://skia.googlesource.com/skia.git/+log/2ddec49abd5c..e9cf3f1740eb

2023-08-18 jvanverth@google.com Revert "Re-enable *AsyncReadPixels tests on Qualcomm"
2023-08-18 scroggo@google.com Create separate CtsEnforcement levels per FilterResultsTest
2023-08-18 jvanverth@google.com Re-enable *AsyncReadPixels tests on Qualcomm

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-18 22:02:05 +00:00
skia-flutter-autoroll
01b6977163 Roll Skia from 2dd1ed0baa7d to 2ddec49abd5c (2 revisions) (flutter/engine#44860) 
https://skia.googlesource.com/skia.git/+log/2dd1ed0baa7d..2ddec49abd5c

2023-08-18 jvanverth@google.com Use rescale for asyncReadPixels colorspace conversion.
2023-08-18 scroggo@google.com Converge on ANDROID_NDK_HOME

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-18 21:14:12 +00:00
skia-flutter-autoroll
2b5a650a19 Roll Skia from cf37d99d844d to 2dd1ed0baa7d (1 revision) (flutter/engine#44859) 
https://skia.googlesource.com/skia.git/+log/cf37d99d844d..2dd1ed0baa7d

2023-08-18 scroggo@google.com Plumb proper CtsEnforcement value to Graphite tests

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-18 20:25:05 +00:00
skia-flutter-autoroll
569e02584c Roll Dart SDK from 8109103e041b to a4908f67b63e (2 revisions) (flutter/engine#44858) 
https://dart.googlesource.com/sdk.git/+log/8109103e041b..a4908f67b63e

2023-08-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-87.0.dev
2023-08-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-86.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-18 20:17:17 +00:00
skia-flutter-autoroll
25b2c86bb0 Roll Skia from edf0c0ecc7b1 to cf37d99d844d (1 revision) (flutter/engine#44857) 
https://skia.googlesource.com/skia.git/+log/edf0c0ecc7b1..cf37d99d844d

2023-08-18 jamesgk@google.com [graphite] Fix overlap with dst read

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-18 19:44:00 +00:00
skia-flutter-autoroll
1260aa383d Roll Skia from e3adabdd0511 to edf0c0ecc7b1 (3 revisions) (flutter/engine#44854) 
https://skia.googlesource.com/skia.git/+log/e3adabdd0511..edf0c0ecc7b1

2023-08-18 jvanverth@google.com Skip some colortypes for ImageAsyncReadPixels and SurfaceAsyncReadPixels
2023-08-18 jvanverth@google.com [graphite] Some asyncReadPixels cleanup.
2023-08-18 johnstiles@google.com Change the WGSL entrypoint name to 'main'.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-18 18:35:46 +00:00
Jason Simmons
8c77e605e6 Flush pending graphics commands when the unref queue is drained on the IO thread (flutter/engine#44831) 
See https://github.com/flutter/flutter/issues/131524
 2023-08-18 18:31:04 +00:00
skia-flutter-autoroll
d696c29f5a Roll Skia from 31baf15e8f2c to e3adabdd0511 (2 revisions) (flutter/engine#44851) 
https://skia.googlesource.com/skia.git/+log/31baf15e8f2c..e3adabdd0511

2023-08-18 brianosman@google.com Remove deprecated Vulkan GrBackendRenderTarget constructor
2023-08-18 scroggo@google.com Convert skqp_app to skqp_jni

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-18 17:49:47 +00:00
skia-flutter-autoroll
633ec70213 Roll Skia from c9294edc03b9 to 31baf15e8f2c (10 revisions) (flutter/engine#44850) 
https://skia.googlesource.com/skia.git/+log/c9294edc03b9..31baf15e8f2c

2023-08-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from 07e20fbc7bee to 2e999b8eedf7
2023-08-18 brianosman@google.com Check mutable state when comparing GrBackendRenderTargets
2023-08-18 brianosman@google.com Remove GrVkBackendSurfaceInfo
2023-08-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from 3590e8eac703 to 07e20fbc7bee
2023-08-18 jamesgk@google.com [graphite] Enable LCD blending
2023-08-18 johnstiles@google.com Fix ImageFilterCropRect_Gpu test disable.
2023-08-18 brianosman@google.com Remove GrBackendSurfaceMutableState
2023-08-18 johnstiles@google.com Replace deprecated GetAdapters() API.
2023-08-18 jvanverth@google.com Reland "Fix SurfaceAsyncReadPixels test and non-scaled colorspace transforms."
2023-08-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f84bc95c7dfa to 2542ba0a2d7e (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-18 17:03:47 +00:00
Zachary Anderson
3c29bdfb0f Update Impeller benchmarks.md with a Pixel 7 link (flutter/engine#44834) 2023-08-18 09:39:55 -07:00
skia-flutter-autoroll
93c76a072e Roll Fuchsia Linux SDK from 7xOzci7fempFgHNk9... to pSqQ556xmZp7S4np5... (flutter/engine#44846) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-18 16:26:36 +00:00
skia-flutter-autoroll
c83bb404ab Roll Dart SDK from 121fcbd8124c to 8109103e041b (1 revision) (flutter/engine#44844) 
https://dart.googlesource.com/sdk.git/+log/121fcbd8124c..8109103e041b

2023-08-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-85.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-18 16:25:43 +00:00
Jonah Williams
539e3833d2 [Impeller] add trace events for VkRenderPass and VkFrameBuffer creation. (flutter/engine#44837) 
To help diagnose https://github.com/flutter/flutter/issues/129392 , which seems to be just as bad on the Pixel 7s:

We're not blocking in allocation anymore thanks to our previous allocator clean ups, but something else is blocking. I think it might be one of these methods.

![image](https://github.com/flutter/engine/assets/8975114/b768b5d7-b8c1-4acd-b518-bfd83486d6b2)
 2023-08-18 16:24:50 +00:00
skia-flutter-autoroll
c25be8bb3a Roll Fuchsia Mac SDK from Tnp43n_nAR2N0l_gY... to onEHyyETXAMieDyfP... (flutter/engine#44845) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-18 16:23:33 +00:00
skia-flutter-autoroll
f442094303 Roll Skia from 1e62a2d4c429 to c9294edc03b9 (2 revisions) (flutter/engine#44843) 
https://skia.googlesource.com/skia.git/+log/1e62a2d4c429..c9294edc03b9

2023-08-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 228e9620e667 to b0469a9c40c7
2023-08-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from f1d21dc58818 to 228e9620e667 (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-18 16:20:36 +00:00
Bruno Leroux
4f50825d26 [Android] Expose channel buffer resize and overflow calls (flutter/engine#44434) 
## Description

This PR updates the Android engine in order to provide a more efficient implementation for `BasicMessageChannel.resizeChannelBuffer` (helper to call the `resize` control command).
It also adds a new helper called`BasicMessageChannel.allowChannelBufferOverflow` to call the `overflow` control command.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/132048
Android implementation for https://github.com/flutter/flutter/issues/132386

## Tests

Adds 2 tests.
 2023-08-18 06:16:22 +00:00
skia-flutter-autoroll
216984de1a Roll Dart SDK from 7101eb7569ac to 121fcbd8124c (1 revision) (flutter/engine#44832) 
https://dart.googlesource.com/sdk.git/+log/7101eb7569ac..121fcbd8124c

2023-08-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-84.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-18 02:32:22 +00:00
skia-flutter-autoroll
1c1daa0752 Roll Skia from 1bec2899ace8 to 1e62a2d4c429 (1 revision) (flutter/engine#44829) 
https://skia.googlesource.com/skia.git/+log/1bec2899ace8..1e62a2d4c429

2023-08-17 johnstiles@google.com Disable SkSL testing on Dawn + Ganesh.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-17 23:25:15 +00:00
skia-flutter-autoroll
0cf43bffee Roll Dart SDK from 7e4e5796ee99 to 7101eb7569ac (2 revisions) (flutter/engine#44828) 
https://dart.googlesource.com/sdk.git/+log/7e4e5796ee99..7101eb7569ac

2023-08-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-83.0.dev
2023-08-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-82.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-17 22:43:21 +00:00
skia-flutter-autoroll
9e6495e651 Roll Skia from e4be2cab442f to 1bec2899ace8 (1 revision) (flutter/engine#44826) 
https://skia.googlesource.com/skia.git/+log/e4be2cab442f..1bec2899ace8

2023-08-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from dce9e2d48bec to f84bc95c7dfa (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-17 21:51:31 +00:00
skia-flutter-autoroll
436cb62d3e Roll Skia from bfd45173e5e3 to e4be2cab442f (3 revisions) (flutter/engine#44824) 
https://skia.googlesource.com/skia.git/+log/bfd45173e5e3..e4be2cab442f

2023-08-17 lehoangquyen@chromium.org GraphiteDawn: use Dawn's MSAARenderToSingleSampled feature.
2023-08-17 johnstiles@google.com Fill out list of WGSL reserved words.
2023-08-17 jmbetancourt@google.com add skottie image slot support to CanvasKit's ManagedAnimation

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-17 21:02:06 +00:00
Greg Spencer
fc5b70b5d4 Add Doxygen doc generation for iOS, macOS, Linux, Windows, and Impeller (flutter/engine#43915) 
## Description

This starts generating Doxygen docs for iOS, macOS, Linux, Windows, and Impeller. It doesn't remove the existing generation for iOS for now, until we can migrate the API docs to include these instead of those.

## Related Issues
 - https://github.com/flutter/flutter/issues/130999
 - Fixes https://github.com/flutter/flutter/issues/124833
 2023-08-17 20:49:05 +00:00
skia-flutter-autoroll
e06e55f8ae Roll Fuchsia Mac SDK from VW7WAVPT3Cj5erlae... to Tnp43n_nAR2N0l_gY... (flutter/engine#44823) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-17 20:39:55 +00:00
Jason Simmons
1c573b5165 Fix FlutterInjectorTest assumptions about how the executor service assigns tasks to threads (flutter/engine#44775) 2023-08-17 20:37:59 +00:00
John McCutchan
5c518f77f3 Reenable HardwareBuffer backed Android Platform Views on SDK >= 29 (flutter/engine#44790) 
- Fix a bug in the SDK < 33 ImageReader construction code path.
- Fix a bug that resulted in references to Images produced by a closed
ImageReader.
- Fix an order of operations bug in ImageReaderPlatformViewRenderTarget
release/finalizer code path.
- Enable HardwareBuffer backed Android Platform Views on SDK >= 29

Manually tested on device rotating and shutting down the app.
 2023-08-17 13:15:25 -07:00
Tong Mu
177a6128c1 Basic view management for engine classes (flutter/engine#42991) 
_This PR is part of the multiview engine project. For a complete roadmap, see [this doc](https://docs.google.com/document/d/10APhzRDR7XqjWdbYWpFfKur7DPiz_HvSKNcLvcyA9vg/edit?resourcekey=0-DfGcg4-XWRMMZF__C1nmcA)._

------

This PR adds view management to all engine classes that need it. View management here basically means `AddView` and `RemoveView` methods, and most importantly, how to handle the implicit view.

The implicit view is a special view that's handled differently than all the other "regular views", since it keeps the behavior of the current single view of Flutter. Detailed introduction can be found in `Settings.implicit_view_enabled`.

The following two graphs show the difference between initializing with/without the implicit view and creating regular views.

<img width="879" alt="image" src="https://github.com/flutter/engine/assets/1596656/31244685-d9d3-4c9a-9a9e-6e8540a5711e">

<img width="864" alt="image" src="https://github.com/flutter/engine/assets/1596656/e2dd4b8c-57e3-428d-8547-834fb270052b">

<img width="860" alt="image" src="https://github.com/flutter/engine/assets/1596656/58dae687-8c17-434e-ae24-a48c2d8fa5fa">

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-17 20:06:25 +00:00
skia-flutter-autoroll
a257852606 Roll Skia from d0d390f9310d to bfd45173e5e3 (5 revisions) (flutter/engine#44820) 
https://skia.googlesource.com/skia.git/+log/d0d390f9310d..bfd45173e5e3

2023-08-17 kjlubick@google.com Fix old use of GrBackendRenderTarget for GL
2023-08-17 kjlubick@google.com [bazel] Fix extension handling in gcs_mirror
2023-08-17 johnstiles@google.com Fix WGSL code generation of matrix-div-scalar.
2023-08-17 kjlubick@google.com Remove bridge code for legacy GL GrBackendSurface code
2023-08-17 brianosman@google.com Remove SkOpts_avx and _ssse3 completely

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-17 20:06:23 +00:00
Matan Lurey
1aa93ad798 Implement 2 suggested Clang Tidy fixes we don't look for yet. (flutter/engine#44816) 
I haven't investigated if there are more occurrences or if it's worth
enforcing turning the check on generally.

(They were flagged on the Google roll, ironically)

---


[`readability-redundant-smartptr-get`](https://clang.llvm.org/extra/clang-tidy/checks/readability/redundant-smartptr-get.html)

> Find and remove redundant calls to smart pointer’s `.get()` method


[`performance-for-range-copy`](https://clang.llvm.org/extra/clang-tidy/checks/performance/for-range-copy.html)

> Finds C++11 for ranges where the loop variable is copied in each
iteration but it would suffice to obtain it by reference.
 2023-08-17 12:34:15 -07:00
LouiseHsu
089957e3e0 Add share to selection controls (flutter/engine#44554) 
In native iOS, users are able to select text and initiate a share menu, which provides several standard services, such as copy, sharing to social media, direct ability to send to various contacts through messaging apps, etc. 

https://github.com/flutter/engine/assets/36148254/d0af7034-31fd-412e-8636-a06bbff54765

This PR is the engine portion of the changes that will allow Share to be implemented
This PR addresses https://github.com/flutter/flutter/issues/107578
More details are available in this [design doc](https://github.com/flutter/engine/pull/flutter.dev/go/add-missing-features-to-selection-controls)
 2023-08-17 17:34:11 +00:00
Zachary Anderson
38d3dcbc72 Adds new builders for partial clang-tidy checks. (flutter/engine#44811) 
This is the first in a sequence of PRs which will lint only changed files on presubmit. The process is the following:
1. Add new `bringup: true` builders that lint only changed files. `bringup: true` builders don't run in presubmit, and since after landing this no files will be detected as changed, these builders will not do anything yet.
1. Remove `bringup: true`. This will allow the new builders to run in presubmit.
1. Ask the team to monitor the new checks on PRs to make sure they are doing the right thing.
1. When we're reasonably sure that the checks are doing the right thing, add `presubmit: false` to `mac_clang_tidy` and `linux_clang_tidy` so that we no longer needlessly lint all files in presubmit.

Related https://github.com/flutter/flutter/issues/105068
 2023-08-17 17:25:26 +00:00
hellohuanlin
380e7d7402 [ios][ios17]fix auto correction highlight on top left corner (flutter/engine#44779) 
Fix native auto-correction highlight region on top left corner. 

This PR uses the system auto-correction highlight on iOS 17, which was disabled by https://github.com/flutter/engine/pull/44354

<img width="479" alt="Screenshot 2023-08-16 at 1 19 39 PM" src="https://github.com/flutter/engine/assets/41930132/a5a1dda7-ba21-462e-a65c-1afeecf7559f">

*List which issues are fixed by this PR. You must list at least one issue.*

Fixes https://github.com/flutter/flutter/issues/131622
Fixes https://github.com/flutter/flutter/issues/131695
Fixes https://github.com/flutter/flutter/issues/130818

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-17 16:48:06 +00:00
yaakovschectman
deaf5f2b5b [Windows] Delay enabling app lifecycle states until requested (flutter/engine#44238) 
Await a platform message before sending lifecycle state updates so we
are not sending messages that do not get consumed by the framework.
In the _near_ future we hope to extend the embedder API to allow
registering callbacks called upon the framework registering a listener
to a channel, which would obviate this problem.

https://github.com/flutter/flutter/issues/131616

*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-08-17 12:30:28 -04:00
Tong Mu
bd3da2c47e Move viewConfiguration parsing from PlatformDispatcher to _hooks (flutter/engine#44787) 
This PR moves the code that parses `viewConfiguration` from
`PlatformDispatcher` to `_hooks`. This makes `PlatformDispatcher`'s API
cleaner by hiding the encoding implementation of `ViewConfiguration` in
`_hooks`, and allows more APIs to pass view configuration, such as the
`addView` that will be introduced in
https://github.com/flutter/engine/pull/42991.

This PR should not need unit tests since it's just a refactor, and the
code path that contains `_updateWindowMetrics` has been tested in
existing unit tests.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-08-17 09:29:12 -07:00
skia-flutter-autoroll
a2bf6ed1f2 Roll Dart SDK from 92c32df13d31 to 7e4e5796ee99 (2 revisions) (flutter/engine#44810) 
https://dart.googlesource.com/sdk.git/+log/92c32df13d31..7e4e5796ee99

2023-08-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-81.0.dev
2023-08-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-80.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-17 14:54:11 +00:00
skia-flutter-autoroll
f263998b92 Roll Skia from c4805a975ab3 to d0d390f9310d (2 revisions) (flutter/engine#44807) 
https://skia.googlesource.com/skia.git/+log/c4805a975ab3..d0d390f9310d

2023-08-17 johnstiles@google.com Enable WGSL golden outputs for SkSL folding tests.
2023-08-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 53905a380315 to dce9e2d48bec (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-17 14:50:53 +00:00
skia-flutter-autoroll
920014d79e Roll Fuchsia Linux SDK from cPncZK6z8HmuOmQr_... to 7xOzci7fempFgHNk9... (flutter/engine#44809) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-17 14:49:14 +00:00
skia-flutter-autoroll
e2c83b6115 Roll Skia from efb5a5e0b78b to c4805a975ab3 (2 revisions) (flutter/engine#44795) 
https://skia.googlesource.com/skia.git/+log/efb5a5e0b78b..c4805a975ab3

2023-08-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 152cf62b3887 to 78de02ab5230 (6 revisions)
2023-08-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from f1d21dc58818 to 76d835d26b04

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-17 07:21:55 +00:00
skia-flutter-autoroll
12e6652cce Roll Skia from 11cb8cdd37c1 to efb5a5e0b78b (1 revision) (flutter/engine#44792) 
https://skia.googlesource.com/skia.git/+log/11cb8cdd37c1..efb5a5e0b78b

2023-08-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 716ec65fb647 to f1d21dc58818 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-17 05:42:30 +00:00
Matan Lurey
809b6b8fa0 Passthrough stderr results of clang_tidy when --enable-check-profile. (flutter/engine#44789) 
Required to actually see the results of the profile :)
 2023-08-17 00:58:02 +00:00
skia-flutter-autoroll
147fcb7dbe Roll Dart SDK from d6e1fca5dbdf to 92c32df13d31 (1 revision) (flutter/engine#44788) 
https://dart.googlesource.com/sdk.git/+log/d6e1fca5dbdf..92c32df13d31

2023-08-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-79.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-17 00:27:00 +00:00
skia-flutter-autoroll
df58539fed Roll Skia from 233c4f26427a to 11cb8cdd37c1 (1 revision) (flutter/engine#44786) 
https://skia.googlesource.com/skia.git/+log/233c4f26427a..11cb8cdd37c1

2023-08-16 armansito@google.com [graphite][compute] Store buffer view size alongside BindBufferInfo

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-16 23:13:04 +00:00
Jason Simmons
156b05274e Revert "Conditionally enable HardwareBuffer backed platform views (#44744)" (flutter/engine#44785) 
This reverts commit 4620733d5c4b100fae10861eaae6d6e97003c282.

The https://github.com/flutter/flutter/tree/master/dev/integration_tests/abstract_method_smoke_test test was not rendering the platform view with that change.
 2023-08-16 23:09:08 +00:00
Dan Field
3020e19c19 [Impeller] Update docstring on layer.presentsWithTransaction (flutter/engine#44782) 
This got missed when setting this to always be `YES`.
 2023-08-16 22:01:30 +00:00
John McCutchan
1278a933a7 Switch some ERROR logs to WARNING logs (flutter/engine#44784) 2023-08-16 15:00:25 -07:00
skia-flutter-autoroll
ce8e23534d Roll Skia from 02870a1df818 to 233c4f26427a (1 revision) (flutter/engine#44780) 
https://skia.googlesource.com/skia.git/+log/02870a1df818..233c4f26427a

2023-08-16 johnstiles@google.com Add WGSL support for matrix-divided-by-matrix.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-16 21:28:33 +00:00
skia-flutter-autoroll
c23c289013 Roll Dart SDK from cc5eeac65f89 to d6e1fca5dbdf (1 revision) (flutter/engine#44770) 
https://dart.googlesource.com/sdk.git/+log/cc5eeac65f89..d6e1fca5dbdf

2023-08-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-78.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-16 20:41:59 +00:00
skia-flutter-autoroll
6b28b250fc Roll Skia from e65aabc26c86 to 02870a1df818 (7 revisions) (flutter/engine#44778) 
https://skia.googlesource.com/skia.git/+log/e65aabc26c86..02870a1df818

2023-08-16 jvanverth@google.com [OpenGL] Disable CopyTexSubImage2D when using sRGB on ES2
2023-08-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 53e39be12b9e to 53905a380315 (4 revisions)
2023-08-16 jamesgk@google.com [graphite] Allow multiple views on a Dawn texture
2023-08-16 cmumford@google.com [shaders] Create shaders Docker image build target
2023-08-16 jmbetancourt@google.com [jetski] ask for a crop rect when using ImageFilter.blur
2023-08-16 herb@google.com Define Point for Bentley-Ottmann
2023-08-16 brianosman@google.com Remove unused isValid parameter from GrVkBackendSurfaceInfo::assign

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-16 20:40:22 +00:00
Matan Lurey
c9246dfaf1 Add an optional '--enable-check-profile' to 'tools/clang_tidy'. (flutter/engine#44773) 
Example usage:

```shell
$ dart tools/clang_tidy/bin/main.dart --lint-all --enable-check-profile
```

I plan to use this to help triage why clang_tidy takes so long, and if
particular rules are contributing to most of the cost.
 2023-08-16 13:06:01 -07:00
skia-flutter-autoroll
5ae965359a Roll Fuchsia Mac SDK from Zp9or9YwxZHHPeQbA... to VW7WAVPT3Cj5erlae... (flutter/engine#44777) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-16 20:00:00 +00:00