84880 Commits

Author SHA1 Message Date
engine-flutter-autoroll
ab6101449a
Roll Fuchsia Linux SDK from paQphLeTdjksq0VgK... to sIXAJH-dBt0-F5XwX... (#171481)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC codefu@google.com,zra@google.com on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-07-01 23:25:08 +00:00
Alex Medinsh
906084a9db
Update CupertinoPicker docs (#170960)
This PR updates the docs after the changes introduced in
https://github.com/flutter/flutter/pull/170202.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-07-01 22:17:21 +00:00
engine-flutter-autoroll
4dcd1f12b9
Roll Skia from 97c3c984a17e to 7917d3922342 (5 revisions) (#171478)
https://skia.googlesource.com/skia.git/+log/97c3c984a17e..7917d3922342

2025-07-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from ae9b2969a750 to fae54fc27fa8 (2 revisions)
2025-07-01 lukasza@chromium.org [rust png] Prefer `SkASSERT_RELEASE`
over `SkASSERT`.
2025-07-01 mike@reedtribe.org SkTypeface virtuals to take SkSpan
2025-07-01 bungeman@google.com Remove fontations dep on pathops
2025-07-01 bungeman@google.com Only build fiddle_examples when possible

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC codefu@google.com,kjlubick@google.com,michaelludwig@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-07-01 22:00:09 +00:00
Mohellebi abdessalem
d3e5417310
remove x86 unused codepaths (#170191)
Towards #170142
## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Reid Baker <1063596+reidbaker@users.noreply.github.com>
2025-07-01 21:24:52 +00:00
matasb-google
f2814ddfe6
Fix crash when editableText is not mounted (#171159)
Fix issue when text_selection crashes due to editableText not being
mounted.

No issue filled (internal b/425840577)

Likely introduced by https://github.com/flutter/flutter/pull/167881

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-01 21:23:47 +00:00
Brandon DeRosier
a0711824a5
Add --enable-flutter-gpu flag to flutter_tool & FLTEnableFlutterGPU to the macOS embedder (#171404)
Resolves https://github.com/flutter/flutter/issues/168126
Resolves https://github.com/flutter/flutter/issues/171361
Resolves https://github.com/bdero/flutter-scene-example/issues/9

FLTEnableFlutterGPU was added for iOS and Android in
https://github.com/flutter/flutter/pull/165337 along with a setting in
the engine. This patch adds macOS support and allows the flag to be
overridden by passing `--enable-flutter-gpu` to the Flutter tool.
2025-07-01 18:27:50 +00:00
engine-flutter-autoroll
7386eb897e
Roll Packages from 471bfd305f4e to 3dc682deffb4 (2 revisions) (#171458)
471bfd305f...3dc682deff

2025-07-01 stuartmorgan@google.com [video_player] Use CADisplayLink on
macOS 14.0+ (flutter/packages#9533)
2025-06-30 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump exoplayer_version from 1.4.1 to 1.5.1 in
/packages/video_player/video_player_android/android
(flutter/packages#8414)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-07-01 18:26:07 +00:00
engine-flutter-autoroll
a4170daf0e
Roll Skia from 2580675b46d5 to 97c3c984a17e (5 revisions) (#171457)
https://skia.googlesource.com/skia.git/+log/2580675b46d5..97c3c984a17e

2025-07-01 mike@reedtribe.org Change patheffect's virtual to take
pathbuilder
2025-07-01 thomsmit@google.com [graphite] DrawContext calls Image::Copy
2025-07-01 kaylee.lubick@gmail.com Add Skia pride example
2025-07-01 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
Dawn from 3a5d9945a673 to 3e03a4fc77a2 (188 revisions)
2025-07-01 robertphillips@google.com [graphite] Improve error message in
Precompilation tools

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC codefu@google.com,kjlubick@google.com,michaelludwig@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-07-01 18:23:59 +00:00
Victor Sanni
a58caa3346
Focused search field hides prefix in higher accessibility text scale modes (#171406)
### Flutter



https://github.com/user-attachments/assets/231a2e93-5fa8-4d67-933b-5d5585d05fb5




### Native



https://github.com/user-attachments/assets/94cbc0c1-1326-47db-a902-d91e8009318b



Fixes [Focused CupertinoSearchTextField does not hide prefix in higher
accessibility text scale
modes](https://github.com/flutter/flutter/issues/168255)
2025-07-01 18:21:18 +00:00
Matan Lurey
ad722a2973
Add -v to flutter doctor for crash reporting (#171308)
Towards https://github.com/flutter/flutter/issues/38901.
2025-07-01 17:48:00 +00:00
Klemen Tusar
6ffa9dab3e
Fix infinite loop in CupertinoSliverNavigationBar collapse animation by adding bounds check for target scroll position (#170210)
This pull request includes a fix to the
`CupertinoSliverNavigationBarState` class in the `nav_bar.dart` file.
The change ensures that the `animateTo` method is only called when the
`target` is within the valid scroll extent range, i.e. `target <=
position.maxScrollExtent`.

Fixes https://github.com/flutter/flutter/issues/164458

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

---------

Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
2025-07-01 17:33:50 +00:00
engine-flutter-autoroll
a9f718335e
Roll Skia from 8de238c050fb to 2580675b46d5 (21 revisions) (#171444)
https://skia.googlesource.com/skia.git/+log/8de238c050fb..2580675b46d5

2025-07-01 bungeman@google.com Allow fiddle_examples in shared builds
2025-07-01 mike@reedtribe.org Propagate volatile between path and
builder
2025-07-01
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-07-01
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-07-01
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-07-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from f835be5aa629 to ae9b2969a750 (11 revisions)
2025-07-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 436722b39118 to 96a63130d839 (1 revision)
2025-07-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 686cc37642f5 to ef6b3564f12e (9 revisions)
2025-06-30 bungeman@google.com Fix more skia_component warnings
2025-06-30 robertphillips@google.com [graphite] More Android
PaintOptions
2025-06-30 rafael.cintron@microsoft.com Force Dawn to load components
from system folders
2025-06-30 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
Dawn from 772f77165cdf to 3a5d9945a673 (0 revision)
2025-06-30 thomsmit@google.com [graphite] Remove TintIR option and jobs
2025-06-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 9a4e8ded41e3 to f835be5aa629 (1 revision)
2025-06-30 bungeman@google.com Fix some component to be skia_component
2025-06-30 michaelludwig@google.com [graphite] Use correct working
context for precompile's withWorkingColorSpace/format
2025-06-30 fmalita@google.com Revert "Optional PathOps"
2025-06-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 8acd0e40f584 to 686cc37642f5 (7 revisions)
2025-06-30 fmalita@google.com Optional PathOps
2025-06-30 bungeman@google.com Rename :fontmgr_android_freetype
:fontmgr_android
2025-06-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from d90e098a4598 to 9a4e8ded41e3 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jonahwilliams@google.com,kjlubick@google.com,michaelludwig@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-07-01 15:47:15 +00:00
Matan Lurey
4fbc812a47
Add feature flags to flutter doctor -v (#171307)
Towards https://github.com/flutter/flutter/issues/38901.
2025-07-01 15:44:09 +00:00
Matan Lurey
b524df28bd
Report feature flags enabled if the flutter tool crashes on a bot. (#171304)
Towards https://github.com/flutter/flutter/issues/38901.

Next PR will also add feature flags to `flutter doctor`.
2025-07-01 15:44:09 +00:00
Matan Lurey
1a967e0d63
Remove a doctor event from the package:usage-era. (#171305)
No test because it's just unused.
2025-07-01 15:44:09 +00:00
Reid Baker
1b075f6b18
Android gradle use lowercase instead of toLowerCase in preparation for removal in v9 (#171397)
partial resolution for #170791 (lowercase but not filemode) 

This is the first time I have used the experimental api annotation. Most
users should have lowercase available without the annotation only the
oldest kotlin/agp versions should need the annotation.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-07-01 15:10:12 +00:00
Zachary Anderson
253cae121e
Re-pin package:intl (#171438)
Reverts https://github.com/flutter/flutter/pull/169286.

I am in agreement with the goal of unpinning packages dependencies, but
a change of this significance should have a fleshed out design doc and
plan, and be presented at the Dash forum so that the whole team is aware
of the changes.
2025-07-01 14:39:04 +00:00
engine-flutter-autoroll
975f6d8bef
Roll Dart SDK from 8d3120f38d52 to 8d69b07b9d9d (1 revision) (#171416)
https://dart.googlesource.com/sdk.git/+log/8d3120f38d52..8d69b07b9d9d

2025-07-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-293.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-07-01 06:29:09 +00:00
flutter-pub-roller-bot
4106752a92
Roll pub packages (#171415)
This PR was generated by `flutter update-packages --force-upgrade`.
2025-07-01 05:35:23 +00:00
Victor Sanni
5e6115d959
Correct position for an open CupertinoContextMenu (#170943)
## Larger-sized child

### Flutter

https://github.com/user-attachments/assets/e120bdda-4236-480d-a85f-183b176bc2a9

### Native


https://github.com/user-attachments/assets/7577b0a0-9111-47e0-ad5d-f533a14310ea



## Smaller-sized child

### Flutter

https://github.com/user-attachments/assets/98ba9ffe-715f-4ec6-8d33-e10a8ae69d7d

### Native


https://github.com/user-attachments/assets/b6dbc891-5e01-4ac5-a362-d714328e46d3



## Landscape mode

### Flutter

https://github.com/user-attachments/assets/9191b8ba-e80a-4d88-b6c4-75876704c2aa

### Native


https://github.com/user-attachments/assets/bb7dfe21-a87b-4eab-a2d2-fab35a7a4c70


<details>
<summary>Flutter sample code</summary>

```dart

import 'package:flutter/cupertino.dart';

void main() => runApp(const ContextMenuApp());

class ContextMenuApp extends StatelessWidget {
  const ContextMenuApp({super.key});

  @override
  Widget build(BuildContext context) {
    return CupertinoApp(
      home: MyStatelessWidget(),
    );
  }
}

/// This is the stateless widget that the main application instantiates.
class MyStatelessWidget extends StatelessWidget {
  const MyStatelessWidget({super.key});

  List<String> getDataList() {
    List<String> list = [];
    for (int i = 0; i < 15; i++) {
      list.add(i.toString());
    }
    return list;
  }

  List<Widget> getWidgetList(BuildContext context) {
    return getDataList()
        .map((item) => getItemContainer(context, item))
        .toList();
  }

  Widget getItemContainer(BuildContext context, String item) {
    return CupertinoContextMenu(
      actions: List<Widget>.generate(
        4,
        (index) {
          return CupertinoContextMenuAction(
            child: Text('Action ${index + 1}'),
            onPressed: () {
              Navigator.pop(context);
            },
          );
        },
      ),
      child: SizedBox.square(
        dimension:
            350, // Change to increase the size of the context menu's child.
        child: ColoredBox(
          color: CupertinoColors.destructiveRed,
          child: Align(
            alignment: Alignment.center,
            child: Text(
              item,
              style: TextStyle(color: CupertinoColors.white, fontSize: 20),
            ),
          ),
        ),
      ),
    );
  }

  @override
  Widget build(BuildContext context) {
    return CupertinoPageScaffold(
      navigationBar: CupertinoNavigationBar(
        middle: Text('Context Menu Demo'),
      ),
      child: SafeArea(
        child: GridView.count(
          crossAxisSpacing: 5.0,
          mainAxisSpacing: 5.0,
          padding: EdgeInsets.all(10.0),
          crossAxisCount: 3,
          childAspectRatio: 1.0,
          children: getWidgetList(context),
        ),
      ),
    );
  }
}


```

</details>

<details>
<summary>Native sample code</summary>

```swift
import SwiftUI

struct ContentView: View {
    let colors: [Color] = [.red, .orange, .blue, .green]
    
    var body: some View {
        NavigationView {
            ScrollView {
                LazyVGrid(columns: Array(repeating: GridItem(.flexible()), count: 3), spacing: 5) {
                    ForEach(0..<15) { index in
                        ContextMenuItem(item: "\(index)", color: colors.randomElement()!)
                    }
                }
                .padding(10)
            }
            .navigationTitle("Context Menu Demo")
            .navigationBarTitleDisplayMode(.inline)
        }
    }
}

struct ContextMenuItem: View {
    let item: String
    let color: Color
    
    var body: some View {
        
        Text(item)
            .font(.system(size: 20))
            .foregroundColor(.white)
            .frame(width: 220, height: 220)
            .background(color)
            .cornerRadius(8)
            .contextMenu {
                ForEach(1..<5) { i in
                    Button("Action \(i)") {
                        print("Action \(i) tapped for item: \(item)")
                    }
                }
            } preview: {
                Text(item)
                    .font(.system(size: 20))
                    .foregroundColor(.white)
                    .frame(width: 250, height: 500)
                    .background(color)
                    .cornerRadius(8)
                    
            }
    }
}

```

</details>

Fixes [iOS Context Menus incorrectly moves to the center between
screens](https://github.com/flutter/flutter/issues/60334)
2025-07-01 03:58:18 +00:00
engine-flutter-autoroll
2bbebd865f
Roll Dart SDK from d95798161a18 to 8d3120f38d52 (1 revision) (#171411)
https://dart.googlesource.com/sdk.git/+log/d95798161a18..8d3120f38d52

2025-06-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-292.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-07-01 01:24:25 +00:00
Brandon DeRosier
152cbfc2c7
Remove impeller-cmake build rules (#171407)
We no longer have any stakeholders relying on the impeller-cmake build,
and I am no longer maintaining it.

Developers who wish to use the Impeller renderer in native applications
should consider using the awesome [Impeller Standalone C
SDK](https://github.com/flutter/flutter/tree/master/engine/src/flutter/impeller/toolkit/interop#impeller-standalone-sdk)
built by @chinmaygarde instead.
2025-06-30 22:57:27 +00:00
Brandon DeRosier
2c970ccee1
Remove --enable-impeller-3d gn flag (#171405)
This flag is no longer used. Impeller Scene was removed a while back and
has been rewritten as [dart
package](https://pub.dev/packages/flutter_scene) that runs on Flutter
GPU.
2025-06-30 22:36:42 +00:00
Ramon Farizel
319bd1109c
Add WidgetStatesController to ListTile (#168878)
Add WidgetStatesController to ListTile

Fixes https://github.com/flutter/flutter/issues/166611

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-30 22:35:17 +00:00
zhongliugo
bb784b983b
feat(web): Add navigation focus handler for assistive technology focus restoration (#170046)
**Description**
This pull request adds a navigation focus handler to the Flutter web
engine that bridges assistive technology activations with Flutter's
focus tracking system. The listener intercepts screen reader activations
(VoiceOver, NVDA, JAWS, etc.) and forces DOM focus on the activated
elements, ensuring they integrate properly with Flutter's navigation
focus restoration.

**Before**
When using VoiceOver or other screen readers to navigate between pages
in a Flutter web app, focus restoration would fail because assistive
technology activations don't naturally trigger the DOM focus events that
Flutter's navigation system expects. Users would lose their navigation
context, with focus jumping to default elements instead of returning to
the previously activated button.

**Before behavior demo**
https://focus-demo-0529-before.web.app
On mac os, Use command + F5 to activate voice over. 
Use control + option + arrow right to focus on "Go to page two" button. 
Use control + option +  space to click the "Go to page two" button. 
Then in page two, use control + option + arrow right to focus on "Back
to page one" button.
The focus will be on "Page one" heading instead of "Go to page two"
button. This is not expected

**After**
Screen reader users can now navigate between pages and have their focus
properly restored to the previously activated element (e.g., "Go to Page
Two" button) when returning to a previous page, providing a consistent
and accessible navigation experience across all assistive technologies.

**After behavior demo**
https://focus-demo-0529-after.web.app
On mac os, Use command + F5 to activate voice over. 
Use control + option + arrow right to focus on "Go to page two" button. 
Use control + option +  space to click the "Go to page two" button. 
Then in page two, use control + option + arrow right to focus on "Back
to page one" button.
The focus will be on "Go to page two" button. This is expected.

**Issue Fixed**
This PR addresses GitHub Issue #140483, which reports that VoiceOver
focus restoration doesn't work in Flutter web applications during
navigation.


## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-06-30 22:20:26 +00:00
engine-flutter-autoroll
0287384953
Roll Dart SDK from 3061dd665885 to d95798161a18 (1 revision) (#171400)
https://dart.googlesource.com/sdk.git/+log/3061dd665885..d95798161a18

2025-06-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-291.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-30 20:16:27 +00:00
Mohellebi abdessalem
9ba6aafb94
remove x86 in BUILD.gn (#170965)
based on [this
comment](https://github.com/flutter/flutter/pull/170191#pullrequestreview-2910139454)
Towards #170142

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] All existing and new tests are passing.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-30 18:16:29 +00:00
Sam Rawlins
d72b1388b3
Update Setting-up-the-Engine-development-environment.md (#171051)
* Note that the flutter tool does not have sections. The docs do.
* Link to the relevant section.
2025-06-30 18:01:12 +00:00
John "codefu" McDole
123e969efa
feat: add "stamp" to et and create build-time engine_stamp.json (#171310)
Writes a stamp file, engine_stamp.json, containing interesting
information about this build:

```json
{
  "build_date": "2025-06-27T16:35:13.279188",
  "build_time_ms": 1751067313279,
  "git_revision": "e68e105667e9e5cace56b0431781062b773e4831",
  "git_revision_date": "2025-06-27 15:51:55 -0700",
  "content_hash": "23542e452fc55890626fd1c5eb77c4788c19f983"
}
```

Later; I'll update to the flutter tool to download this artifact to
bin/cache so it can be used instead of git commands.
2025-06-30 17:55:27 +00:00
Alex Medinsh
ee23d89857
Add CupertinoPicker ticking sound (#170641)
This PR adds a ticking sound to the `CupertinoPicker` on iOS.

Fixes https://github.com/flutter/flutter/issues/37329

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-06-30 17:54:07 +00:00
flutter-pub-roller-bot
2d80470bb5
Roll pub packages (#171392)
This PR was generated by `flutter update-packages --force-upgrade`.
2025-06-30 17:13:09 +00:00
engine-flutter-autoroll
d2b7e2a17e
Roll Packages from 4841ada7ad75 to 471bfd305f4e (7 revisions) (#171384)
4841ada7ad...471bfd305f

2025-06-30 stuartmorgan@google.com [google_maps_flutter] Remove legacy
renderer tests (flutter/packages#9517)
2025-06-30 49699333+dependabot[bot]@users.noreply.github.com Bump
lewagon/wait-on-check-action from 1.3.4 to 1.4.0 in the
all-github-actions group (flutter/packages#9524)
2025-06-29 43054281+camsim99@users.noreply.github.com
[camera_android_camerax] Fix incorrectly rotated captured photos
(flutter/packages#9498)
2025-06-29 stuartmorgan@google.com [in_app_purchase] Annotate
deprecation in test (flutter/packages#9473)
2025-06-29 malo.allee@gmail.com [video_player] Add poster attribute for
html video tag in video_player_platform_interface
(flutter/packages#8979)
2025-06-29 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
6fba2447e95c to fcf2c11572af (6 revisions) (flutter/packages#9502)
2025-06-29 muhatashim@google.com Skip test to unblock packages
(flutter/packages#9516)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-30 16:33:21 +00:00
Mouad Debbar
dc56ed81da
Run expression_evaluation_web_ddc_library_bundle_test.dart on Mac/Windows (#171278)
Part of https://github.com/flutter/flutter/issues/171276
2025-06-30 14:59:32 +00:00
flutter-pub-roller-bot
e3e51935dd
Roll pub packages (#171091)
This PR was generated by `flutter update-packages --force-upgrade`.
2025-06-30 14:31:25 +00:00
Derek Xu
10f0589a14
Activate microtask profiling in dart:async when Switch::ProfileMicrotasks is set (#171035)
Here is the logic in the Dart VM that is analogous to the logic in this
PR:
2be548666d/runtime/bin/dartutils.cc (L540-L561).
2025-06-30 13:59:34 +00:00
Moritz
94f9963199
Unpin package:intl (#169286)
Fixes #158050

Created by running `flutter update-packages --cherry-pick=intl:^0.20.2
--exclude-tools` - we probably don't want to unpin `flutter_tools`
dependencies to avoid breaking it.

Add comment to `package:intl`s pubspec in
https://github.com/dart-lang/i18n/pull/980.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-30 06:19:21 +00:00
engine-flutter-autoroll
cfd2047b6d
Roll Dart SDK from 96807993a052 to 3061dd665885 (1 revision) (#171362)
https://dart.googlesource.com/sdk.git/+log/96807993a052..3061dd665885

2025-06-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-290.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-30 03:47:37 +00:00
engine-flutter-autoroll
f346592ade
Roll Dart SDK from fb5803534ded to 96807993a052 (1 revision) (#171357)
https://dart.googlesource.com/sdk.git/+log/fb5803534ded..96807993a052

2025-06-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-289.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-29 22:43:26 +00:00
engine-flutter-autoroll
706525b262
Roll Skia from 340371f50fc8 to 8de238c050fb (1 revision) (#171354)
https://skia.googlesource.com/skia.git/+log/340371f50fc8..8de238c050fb

2025-06-29 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com
Update SKP version

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
aaclarke@google.com,kjlubick@google.com,michaelludwig@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-29 14:48:25 +00:00
engine-flutter-autoroll
c25f5dd896
Roll Skia from 023fe1834785 to 340371f50fc8 (1 revision) (#171349)
https://skia.googlesource.com/skia.git/+log/023fe1834785..340371f50fc8

2025-06-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from d284305388b0 to d90e098a4598 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
aaclarke@google.com,kjlubick@google.com,michaelludwig@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-29 08:40:25 +00:00
engine-flutter-autoroll
e44ab22aa4
Roll Skia from 8657e39b03e7 to 023fe1834785 (1 revision) (#171342)
https://skia.googlesource.com/skia.git/+log/8657e39b03e7..023fe1834785

2025-06-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from b39b1685ca27 to d284305388b0 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-28 19:09:24 +00:00
Nate Biggs
85486ffffc
Allow minification to be toggled for wasm builds (#171211)
Provides extra minification controls for web builds. Updates the
existing `--minify` flag to pass its value to both JS and wasm (instead
of just JS).

Also adds two new flags `--minify-js` and `--minify-wasm` which toggle
minification for just one of the web targets. While JS minification has
a huge impact on code size, wasm minification has a much smaller effect
on the program's size. Since minification can obfuscate useful info
(like errors) one may want to turn off minification for wasm but leave
it on for JS.

The plan is to temporarily use `--no-minify-wasm` for devtools to help
debug some exceptions being seen.

---------

Co-authored-by: Nate Biggs <natebiggs@google.com>
2025-06-28 17:46:44 +00:00
engine-flutter-autoroll
771b631eae
Roll Fuchsia Linux SDK from mQv6OKiD6nn3FNUYG... to paQphLeTdjksq0VgK... (#171340)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC aaclarke@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-28 16:26:33 +00:00
engine-flutter-autoroll
02da4cc00d
Roll Dart SDK from ccd972a7de32 to fb5803534ded (1 revision) (#171321)
https://dart.googlesource.com/sdk.git/+log/ccd972a7de32..fb5803534ded

2025-06-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-288.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-28 08:55:18 +00:00
engine-flutter-autoroll
9e9fccd3d2
Roll Skia from af1b461830c0 to 8657e39b03e7 (1 revision) (#171316)
https://skia.googlesource.com/skia.git/+log/af1b461830c0..8657e39b03e7

2025-06-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 7693ce33ea24 to b39b1685ca27 (11 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-28 05:23:15 +00:00
engine-flutter-autoroll
60e85d6317
Roll Dart SDK from f29159da9270 to ccd972a7de32 (1 revision) (#171315)
https://dart.googlesource.com/sdk.git/+log/f29159da9270..ccd972a7de32

2025-06-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-287.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-28 03:59:20 +00:00
Valentin Vignal
b2056cb629
Add radioBackgroundColor to RadioListTile (#171204)
Part of https://github.com/flutter/flutter/issues/168787

Continuation of https://github.com/flutter/flutter/pull/169415

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-28 03:47:20 +00:00
engine-flutter-autoroll
c3119fc319
Roll Fuchsia Test Scripts from 2wEtX_lDNhHhDNsP6... to ZpnML-jis0gVIvtx5... (#171314)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-test-scripts-flutter
Please CC aaclarke@google.com,chrome-fuchsia-engprod@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-28 03:16:09 +00:00
engine-flutter-autoroll
9d220154d7
Roll Skia from 2dc747ddcc4e to af1b461830c0 (1 revision) (#171313)
https://skia.googlesource.com/skia.git/+log/2dc747ddcc4e..af1b461830c0

2025-06-28
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-28 03:08:23 +00:00
Loïc Sharma
94e97d9c12
Ensure disabling text fields' interactive selection disables shortcuts (#171050)
[`EditableText.enableInteractiveSelection`](https://api.flutter.dev/flutter/widgets/EditableText/enableInteractiveSelection.html)
can be used to disable text selection and shortcuts in a text field.

Previously, `EditableText` would disable the shortcut actions using
[`Action.isEnabled`](https://api.flutter.dev/flutter/widgets/Action/isEnabled.html).
As a result, the action would ignore the key event, and the key event
would propagate. On some platforms, the key event would propagate to the
native text view, causing weird behaviors like text getting copied.

Now, the text field shortcuts stop propagation of the key event when
`enableInteractiveSelection` is `false`. This ensures that the text
field "consumes" the key events and prevents a parent of the text field
or native views from receiving the key event.

Partially addresses https://github.com/flutter/flutter/issues/157611

⚠️ Note: This does not fix the bug on Flutter Web as it handles text
field shortcuts separately. This will be fixed in a separate pull
request.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-28 00:01:27 +00:00