Kostia Sokolovskyi
1280fad73f
Fix drawerScrimColor transition. ( #173280 )
...
Fixes https://github.com/flutter/flutter/issues/173112
### Description
- Fixes `drawerScrimColor` transition issue caused by
`Colors.transparent` usage in color interpolation
| BEFORE | AFTER |
| - | - |
| <video alt="before"
src="https://github.com/user-attachments/assets/67d4295e-667e-4f73-b5e0-7841d29f8f57 "
/> | <video alt="after"
src="https://github.com/user-attachments/assets/0f3cacc1-55bd-4c00-8ebe-a5d06ebb7663 "
/> |
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-08-07 06:50:40 +00:00
engine-flutter-autoroll
0db0acb238
Roll Skia from dd60ed46a006 to 9a886bdfb716 (2 revisions) ( #173382 )
...
https://skia.googlesource.com/skia.git/+log/dd60ed46a006..9a886bdfb716
2025-08-07
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-08-06 bungeman@google.com [fontations] Fix macro flag name
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com ,codefu@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-07 05:07:27 +00:00
engine-flutter-autoroll
e003f82b79
Roll Skia from 05d82af3f4bd to dd60ed46a006 (2 revisions) ( #173376 )
...
https://skia.googlesource.com/skia.git/+log/05d82af3f4bd..dd60ed46a006
2025-08-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 1909eee37eb8 to e7132a7a7ef9 (6 revisions)
2025-08-06 bungeman@google.com [fontations] Move " (Fontations)"
appending to C++
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com ,codefu@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-06 23:50:26 +00:00
engine-flutter-autoroll
7920077a5d
Roll Skia from 5518bb27db67 to 05d82af3f4bd (2 revisions) ( #173372 )
...
https://skia.googlesource.com/skia.git/+log/5518bb27db67..05d82af3f4bd
2025-08-06
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-08-06 fmalita@google.com [skottie] Add guard for fill rule change
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com ,codefu@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-06 21:54:17 +00:00
engine-flutter-autoroll
417f69cf94
Roll Skia from 9bb1fc4bc326 to 5518bb27db67 (2 revisions) ( #173363 )
...
https://skia.googlesource.com/skia.git/+log/9bb1fc4bc326..5518bb27db67
2025-08-06 bungeman@google.com Remove
SK_FONTMGR_ANDROID_IGNORE_FALLBACK_FIX
2025-08-06 bungeman@google.com Reland "Rely on clients to opt into
legacy RRect scaling"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com ,codefu@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-06 20:02:13 +00:00
engine-flutter-autoroll
ca16ba745a
Roll Skia from a918c0e08500 to 9bb1fc4bc326 (24 revisions) ( #173355 )
...
https://skia.googlesource.com/skia.git/+log/a918c0e08500..9bb1fc4bc326
2025-08-06 bungeman@google.com Revert "Formalize structure for IsA info"
2025-08-06 syoussefi@google.com [graphite][vulkan] Use
VK_EXT_multisampled_render_to_single_sampled
2025-08-06 bungeman@google.com Revert "Rely on clients to opt into
legacy RRect scaling"
2025-08-06 jlavrova@google.com Revert "Paragraph: Add option to exclude
trailing space in getRectsForRange"
2025-08-06 fmalita@google.com [skottie] Add support for fill rule
2025-08-06
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-08-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from ffd86bf82322 to 1909eee37eb8 (4 revisions)
2025-08-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from fc0e039788e8 to f1c6e1a8372f (9 revisions)
2025-08-06
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-08-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 49dacbc10c7d to 8409182162d1 (19 revisions)
2025-08-06
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-08-06
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-08-05 syoussefi@google.com [vulkan] Re-enable use of
VK_EXT_extended_dynamic_state[2]
2025-08-05 bungeman@google.com Remove IntelIris640 jobs
2025-08-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 03d1948c7084 to ffd86bf82322 (4 revisions)
2025-08-05 syoussefi@google.com [graphite][vulkan] Support input
attachment reads with MSAA
2025-08-05
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-08-05 michaelludwig@google.com [graphite] Enforce F2B order for
opaque draws
2025-08-05 manoj.mohan@zohocorp.com Paragraph: Add option to exclude
trailing space in getRectsForRange
2025-08-05 mike@reedtribe.org Formalize structure for IsA info
2025-08-05 mike@reedtribe.org Rely on clients to opt into legacy RRect
scaling
2025-08-05 sharaks@google.com Merge 4 release notes into
RELEASE_NOTES.md
2025-08-05 sharaks@google.com Update Skia milestone to 141
2025-08-05 mike@reedtribe.org Create bench for path perpsective
transforms
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com ,codefu@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-06 17:56:25 +00:00
engine-flutter-autoroll
9de63a0342
Roll Packages from 83ae18a4faf6 to f0b272645902 (4 revisions) ( #173350 )
...
83ae18a4fa...f0b2726459okorohelijah@google.com [local_auth] Differentiate iOS
authentication errors (flutter/packages#9705 )
2025-08-06 tarrinneal@gmail.com manual roll to
59fc766c6fdfd03d0983fc95ce8b76793a300dd5 (flutter/packages#9758 )
2025-08-05 magder@google.com [ci] Exclude packages using deprecated APIs
from the pod linter check (flutter/packages#9746 )
2025-08-05 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.android.tools.build:gradle from 8.5.1 to 8.11.1
in /packages/file_selector/file_selector_android/android
(flutter/packages#9621 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-06 16:29:19 +00:00
Flutter GitHub Bot
96933bf400
Marks Windows plugin_test to be unflaky ( #173339 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows plugin_test"
}
-->
The issue https://github.com/flutter/flutter/issues/148834 has been
closed, and the test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20plugin_test%22 ).
This test can be marked as unflaky.
2025-08-06 13:38:21 +00:00
engine-flutter-autoroll
e03e8dbeb1
Roll Fuchsia Linux SDK from XEsjoUSNHijML1i9h... to 2Mo76-tiDj4ZCZbPv... ( #173329 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC codefu@google.com ,zra@google.com on the revert to ensure that
a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-06 07:00:33 +00:00
Tong Mu
de3dedaa74
Add radius clamping to web RSuperellipse ( #172254 )
...
This PR fixes rendering errors on Web when the provided corner radii sum
up larger than the size. It implements radius scaling using the same
algorithm as in [the C++
implementation](b2d4210b37/engine/src/flutter/impeller/geometry/rounding_radii.cchttps://github.com/user-attachments/assets/eb526338-84d9-4eca-975b-d44bee0c11ac "
/>
After: (it stays this way for r>100)
<img width="611" height="471" alt="image"
src="https://github.com/user-attachments/assets/08ca2499-d5f7-47e1-9ecf-29f60c968016 "
/>
It also fixes a bug that uses an incorrect starting point.
Both changes are backed by the new test cases in
`rounded_superellipse_border_test.dart`.
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-08-05 23:53:14 +00:00
gaaclarke
a374668798
licenses_cpp: moved is_minimal_linux to pkgconfig usage ( #173248 )
...
addresses feedback from
https://github.com/flutter/flutter/pull/173139#pullrequestreview-3080740288
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-08-05 23:06:14 +00:00
engine-flutter-autoroll
bdaa94404e
Roll Dart SDK from 1553753fee86 to 5b44a0f0b380 (3 revisions) ( #173306 )
...
https://dart.googlesource.com/sdk.git/+log/1553753fee86..5b44a0f0b380
2025-08-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-74.0.dev
2025-08-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-73.0.dev
2025-08-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-72.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-05 22:29:08 +00:00
Mouad Debbar
59fc766c6f
[web] Fix potential race condition in ClickDebouncer ( #173294 )
...
Based on Gemini's comment:
https://github.com/flutter/flutter/pull/173072#discussion_r2246216031
2025-08-05 21:31:15 +00:00
John "codefu" McDole
efa5893347
fix: content_aware_hash tag for fuchsia merge / upload ( #173253 )
...
Also tag after the upload, similar to #173140
fixes : #173137
2025-08-05 20:53:34 +00:00
Dmitry Grand
de33a3b2ab
Remove properties from .ci.yaml no longer used by (docs) recipes ( #173296 )
...
Removed unused properties for `docs.py` recipes
Fixes https://github.com/flutter/flutter/issues/169108 .
2025-08-05 20:29:02 +00:00
Ben Konyi
024a80bf42
[ Widget Preview ] Cleanup for experimental release ( #173289 )
...
Widget previews are being released as an experimental feature in the
next stable release.
This change has some minor last minute changes to prepare for release:
- Makes `flutter widget-preview` visible
- Adds documentation links to docs.flutter.dev (not yet staged)
- Fixes minor bug with asset loading due to `AssetManifest.bin.json` not
being accounted for in the asset path mapping logic
2025-08-05 18:10:06 +00:00
engine-flutter-autoroll
1be877592f
Roll Packages from 1a722878a551 to 83ae18a4faf6 (6 revisions) ( #173290 )
...
1a722878a5...83ae18a4faNearTox@outlook.com [go_router] add initial json support
#110781 (flutter/packages#9404 )
2025-08-04 magder@google.com Update CODEOWNERS (flutter/packages#9721 )
2025-08-04 magder@google.com [google_maps_flutter_ios] Fix
kCGImageAlphaPremultipliedLast implicit conversion from enumeration type
(flutter/packages#9720 )
2025-08-04 engine-flutter-autoroll@skia.org Roll Flutter from
871849e4b6bf to beda687d63f2 (34 revisions) (flutter/packages#9745 )
2025-08-04 10687576+bparrishMines@users.noreply.github.com
[interactive_media_ads] Fixes setting adsresponse on Android
(flutter/packages#9744 )
2025-08-04 10687576+bparrishMines@users.noreply.github.com
[interactive_media_ads]: Adds additional methods to configure ad
requests (flutter/packages#9696 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-05 18:04:08 +00:00
Gray Mackall
2c3438f313
Unmark Linux android_java17_tool_integration_tests as bringup ( #173284 )
...
The only failures in the last 100 runs are those for which large swaths
of the bots were failing:
https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.staging/Linux%20android_java17_tool_integration_tests?limit=100
<img width="1242" height="257" alt="Screenshot 2025-08-05 at 9 13 55 AM"
src="https://github.com/user-attachments/assets/248de580-27ca-4704-9754-a109e961fb6f "
/>
Co-authored-by: Gray Mackall <mackall@google.com>
2025-08-05 17:55:08 +00:00
Michael Goderbauer
10c32b56f6
[dync_modules] enable iOS ddm build in the merge queue ( #173094 )
...
Similar to https://github.com/flutter/flutter/pull/168233 , but this time
for iOS
Follow-up to https://github.com/flutter/flutter/pull/168717
As we start to work more seriously with ddm we'd like to have these
builds always available instead of on demand only.
2025-08-05 17:44:46 +00:00
Jenn Magder
41ab71c76b
Suppress deprecated iOS windows API in integration_test ( #173251 )
...
Suppress the scene deprecation warning to unblock iOS 15+ deprecation
checks in the packages repo:
https://github.com/flutter/packages/pull/7542
Not really part of https://github.com/flutter/flutter/issues/170171 , but
related problem.
Tracking issue: https://github.com/flutter/flutter/issues/154365
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-08-05 17:39:33 +00:00
engine-flutter-autoroll
f6a268392e
Roll Skia from 260e9149ba3e to a918c0e08500 (3 revisions) ( #173283 )
...
https://skia.googlesource.com/skia.git/+log/260e9149ba3e..a918c0e08500
2025-08-05 bungeman@google.com Allow fallback to named fonts in
SkFontmgr_android
2025-08-05 mike@reedtribe.org Deprecate SkApplyPerspectiveClip option
2025-08-05 mike@reedtribe.org Store pathdirection instead of bool
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com ,codefu@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-05 17:27:31 +00:00
engine-flutter-autoroll
b88feac56e
Roll Skia from 8d6eae20579d to 260e9149ba3e (1 revision) ( #173278 )
...
https://skia.googlesource.com/skia.git/+log/8d6eae20579d..260e9149ba3e
2025-08-05 danieldilan@google.com Saturate in bilerp_clamp lowp stage
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com ,codefu@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-05 14:26:27 +00:00
engine-flutter-autoroll
d6153d1d3c
Roll Dart SDK from 794b2c233650 to 1553753fee86 (1 revision) ( #173276 )
...
https://dart.googlesource.com/sdk.git/+log/794b2c233650..1553753fee86
2025-08-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-71.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-05 12:06:30 +00:00
engine-flutter-autoroll
6e002b65d0
Roll Skia from 89074a4c2ea0 to 8d6eae20579d (1 revision) ( #173272 )
...
https://skia.googlesource.com/skia.git/+log/89074a4c2ea0..8d6eae20579d
2025-08-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from b6b2f380814e to fc0e039788e8 (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com ,codefu@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-05 09:46:27 +00:00
engine-flutter-autoroll
d904dc6a09
Roll Skia from 14ee1a562e7d to 89074a4c2ea0 (2 revisions) ( #173268 )
...
https://skia.googlesource.com/skia.git/+log/14ee1a562e7d..89074a4c2ea0
2025-08-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 681d07e76d8e to fdb6700ecb04 (1 revision)
2025-08-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 0b095928b312 to 49dacbc10c7d (18 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,bungeman@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-05 07:52:39 +00:00
engine-flutter-autoroll
17addf2402
Roll Dart SDK from 8e9e37dc3ff6 to 794b2c233650 (2 revisions) ( #173266 )
...
https://dart.googlesource.com/sdk.git/+log/8e9e37dc3ff6..794b2c233650
2025-08-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-70.0.dev
2025-08-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-69.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-05 07:23:33 +00:00
Kostia Sokolovskyi
dd790ea5da
Fix Slider dragged mouse cursor visibility. ( #172759 )
...
Fixes https://github.com/flutter/flutter/issues/172752
### Description
- Fixes dragged cursor visibility in `Slider`
- Replaces `MaterialState` occurrences with `WidgetState`
| Before | After |
| - | - |
| <video
src="https://github.com/user-attachments/assets/bb6c1e9e-fdec-456d-bf29-070ad2cbb47d "
/> | <video
src="https://github.com/user-attachments/assets/8ae76bc2-bb6c-4439-9321-6ec925db7c31 "
/> |
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-08-05 06:58:19 +00:00
Ahmed Mohamed Sameh
c8ec3058fa
Make sure that an AboutListTile doesn't crash in 0x0 environment ( #172421 )
...
This is my attempt to handle #6537 for the AboutListTile UI control.
2025-08-05 06:52:55 +00:00
engine-flutter-autoroll
1cc5d09f65
Roll Skia from 5da6e04f04b9 to 14ee1a562e7d (1 revision) ( #173264 )
...
https://skia.googlesource.com/skia.git/+log/5da6e04f04b9..14ee1a562e7d
2025-08-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 0a496a889c4c to 03d1948c7084 (6 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,bungeman@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-05 05:57:25 +00:00
engine-flutter-autoroll
325405bc6c
Roll Fuchsia Linux SDK from ufssK8EgJ_9RpLFgu... to XEsjoUSNHijML1i9h... ( #173261 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC aaclarke@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-05 03:17:09 +00:00
engine-flutter-autoroll
2b2bd9c418
Roll Dart SDK from c43b8f60ebe1 to 8e9e37dc3ff6 (1 revision) ( #173260 )
...
https://dart.googlesource.com/sdk.git/+log/c43b8f60ebe1..8e9e37dc3ff6
2025-08-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-68.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-05 02:21:57 +00:00
engine-flutter-autoroll
7b48fe1f4d
Roll Skia from a7c8e461d609 to 5da6e04f04b9 (6 revisions) ( #173249 )
...
https://skia.googlesource.com/skia.git/+log/a7c8e461d609..5da6e04f04b9
2025-08-04
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-08-04 mike@reedtribe.org Refine PathBuilder::transform
2025-08-04 mike@reedtribe.org Reapply "New way to scale RRect"
2025-08-04 mike@reedtribe.org Change path clipper to use builder
2025-08-04 bungeman@google.com Ensure correct includes for SkTime.cpp
2025-08-04 mike@reedtribe.org faster rect bounds
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,bungeman@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-04 23:57:33 +00:00
Loïc Sharma
384331e171
Migrate to list and builder Sliver convenience constructors ( #173011 )
...
In 2022, we introduced new convenience constructors like
`SliverList.builder` and `SliverList.list`. Unfortunately, LLMs like
Gemini seem to prefer the delegate pattern even when these convenience
constructors are usable. This updates Flutter's docs, code, and tests to
use these convenience constructors where possible. Hopefully this will
nudge LLMs to consider using the new APIs :)
I migrated 80% of the code by hand, and 20% using Gemini CLI. See
[go/loic-ai-log](http://goto.google.com/loic-ai-log ) (Google internal)
for details.
There's a few locations that I wasn't able to migrate to the convenience
constructors due to missing APIs. I filed the following issues:
1. https://github.com/flutter/flutter/issues/173018
2. https://github.com/flutter/flutter/issues/173019
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-08-04 22:32:22 +00:00
engine-flutter-autoroll
92415d2315
Roll Dart SDK from 3f1307d72d6f to c43b8f60ebe1 (8 revisions) ( #173244 )
...
https://dart.googlesource.com/sdk.git/+log/3f1307d72d6f..c43b8f60ebe1
2025-08-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-67.0.dev
2025-08-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-66.0.dev
2025-08-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-65.0.dev
2025-08-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-64.0.dev
2025-08-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-63.0.dev
2025-08-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-62.0.dev
2025-08-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-61.0.dev
2025-08-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-60.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-04 21:12:16 +00:00
engine-flutter-autoroll
268a5e387c
Roll Skia from dce9550a1356 to a7c8e461d609 (6 revisions) ( #173238 )
...
https://skia.googlesource.com/skia.git/+log/dce9550a1356..a7c8e461d609
2025-08-04 thomsmit@google.com [graphite] Add rewind checks to render
steps
2025-08-04 fmalita@google.com Add SkRect::Bounds bench
2025-08-04
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-08-04 thomsmit@google.com [graphite] Refactor
VkCmdBuf::recordTexAndSamp
2025-08-04 mike@reedtribe.org Switch to optional iter pattern
2025-08-04 bungeman@google.com Revert "Reland "[graphite] Add
AHARDWAREBUFFER_FORMAT_B8G8R8A8_UNORM support""
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,bungeman@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-04 19:48:13 +00:00
Jim Graham
37736df671
Migrate surface frame shell code to DisplayList/Impeller geometry classes ( #173086 )
...
Converting a large variety of classes involved in tracking surfaces,
frames, surface damage, etc. to using the DisplayList/Impeller geometry
classes.
Addresses a bullet item in
https://github.com/flutter/flutter/issues/161456
---------
Co-authored-by: Reid Baker <1063596+reidbaker@users.noreply.github.com>
2025-08-04 19:20:19 +00:00
Jason Simmons
40fcfc7686
In "flutter create", use the project directory in the suggested "cd" command instead of the main source file path ( #173132 )
2025-08-04 19:12:12 +00:00
Matthew Kosarek
7b8fceda91
Using a shared message-only HWND for clip board data on win32 instead of the implicit view ( #173076 )
...
alternative to #172719
## What's new?
This pull request removes the implicit view assumption from the
clipboard on the win32 platform.
To fix it, we create a read-only "null" window handle that we can use to
do clipboard things with.
I updated the tests to reflect the fact that a view is no longer needed
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-08-04 18:23:29 +00:00
Chinmay Garde
12ef2415de
Upload the Android standalone embedder API dylibs. ( #173131 )
...
Fixes https://github.com/flutter/flutter/issues/173130
2025-08-04 18:00:51 +00:00
Jason Simmons
beda687d63
[Impeller] Improvements to the Vulkan pipeline cache data writer ( #173014 )
...
PipelineCacheDataPersist runs on a worker thread pool. The raster thread
may be executing rendering operations while PipelineCacheDataPersist is
reading the state of the pipeline cache.
PipelineCacheDataPersist calls vkGetPipelineCacheData to get the size
required for the cache data buffer and then calls it again to fill the
buffer. If the cache state changed between those two calls, then the
count of bytes written may be less than the size returned by the first
call. In that case, PipelineCacheDataPersist should only write the
portion of the buffer that was filled.
This PR also adds a mutex to PipelineCacheVK::PersistCacheToDisk.
PipelineLibraryVK could queue multiple PersistCacheToDisk tasks to
different worker pool threads. These tasks should not run concurrently.
See https://github.com/flutter/flutter/issues/172624
2025-08-04 17:58:57 +00:00
Jason Simmons
2831e61a9d
[Impeller] Terminate the fence waiter but do not reset it during ContextVK shutdown ( #173085 )
...
ContextVK::Shutdown was clearing the context's fence_waiter_. This could
cause crashes if a pending task such as image decoding is still holding
a reference to the context after ContextVK::Shutdown is called.
The image decode task will submit a command buffer through the context,
and CommandQueueVK::Submit will get a null pointer deference when it
tries to use the fence waiter.
This PR changes ContextVK::Shutdown to terminate the fence waiter
instead of clearing it. FenceWaiterVK::Terminate will now stop the
waiter thread and wait for the thread to exit.
This ensures that the fence waiter thread is stopped in
ContextVK::Shutdown even if something else is holding a reference to the
FenceWaiterVK. Tasks like image decoding will now get an error result
instead of a crash when submitting a command buffer after context
shutdown.
2025-08-04 17:58:57 +00:00
Matthew Kosarek
69264e4a60
Add the 'windowing' feature flag and use to wrap an implementation for regular windows that always throws ( #172478 )
...
## What's new?
- Added the `windowing` feature flag to the project
- Created the internal `_window.dart` API with support for regular
windows
- Implemented a `_WindowingOwnerUnsupported` implementation of the
`WindowingOwner` interface
- Marked all points of the public API as `@internal` with a
corresponding warning documentation
- Threw an `UnsupportedError` where it is appropriate to do so
Note that this PR does **NOT** include a real implementation of
`WindowingOwner` (e.g. for win32 or macOS). That work will be opened as
a follow up.
This work is based off of https://github.com/flutter/flutter/pull/168697
and http://github.com/flutter/flutter/pull/168437 , as well as this
design document:
https://docs.flutter.dev/go/multi-window-experimental-apis
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
---------
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
2025-08-04 17:54:53 +00:00
gaaclarke
bd542bb687
licenses_cpp: reland switch 4 ( #173139 )
...
Let's give this one more go, otherwise we'll have to switch to
downloading a prebuilt binary.
## whats new since revert
I've added `is_minimal_linux` flag which removes targets that can't be
processed by GN on the autoroller image. The linux bot has been changed
to use that flag too.
## testing
I got access to the docker image of the autoroller bots and manually
tested that this works.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
2025-08-04 17:37:29 +00:00
engine-flutter-autoroll
92d944ff11
Roll Skia from 763bba9c33fd to dce9550a1356 (1 revision) ( #173219 )
...
https://skia.googlesource.com/skia.git/+log/763bba9c33fd..dce9550a1356
2025-08-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 3678a87313f1 to 0a496a889c4c (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,bungeman@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-04 17:26:15 +00:00
Reid Baker
561c3d27d3
Improve robustness of comment detection when using flutter analyze --suggestions ( #172977 )
...
Fixes #172055
~For some reason a trailing slash at the end of a comment or a line
below the commented out line that otherwise would match would cause the
regex to match that should be ignored.~
~I could not reason about why the trailing slash would cause a match but
the primary change apart from more robust tests is adding `^\s*` which
pins the match on lines that start with some amount of space before
excluding lines that use `//`~
The regex was overbroad at matching and we were getting lucky that the
second "version" was the one being selected a trailing slash broke the
overbroad match and selected the smaller match that was inside the
comment. The new fix was to pin the multi line regex to the start of a
line that way we can still handle newlines in the definition while
ensuring that commented out lines are not included.
The bug was for AGP version in plugins but the fix was applied to all of
the regular expressions in this area of code along with adversarial
units tests to prevent regression.
Note for other contributors https://regex101.com/ was a great resource
for debugging what was happening here.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-08-04 16:49:07 +00:00
Ahmed Mohamed Sameh
a5a407032b
Make sure that a LicensePage doesn't crash in 0x0 environment ( #172610 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the LicensePage UI
control.
2025-08-04 16:28:20 +00:00
engine-flutter-autoroll
8047f8a01e
Roll Packages from f0645d8448a5 to 1a722878a551 (4 revisions) ( #173215 )
...
f0645d8448...1a722878a5stuartmorgan@google.com Add an initial AGENTS.md
(flutter/packages#9716 )
2025-08-01 engine-flutter-autoroll@skia.org Roll Flutter from
c3279caa127d to 871849e4b6bf (56 revisions) (flutter/packages#9728 )
2025-08-01 gavrilko.alexander@gmail.com
[webview_flutter_platform_interface] Provide flexible API for loading
local HTML files (flutter/packages#9697 )
2025-08-01 jessiewong401@gmail.com Extending Timeout on `Linux_android
android_build_all_packages *` (flutter/packages#9717 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-04 15:45:59 +00:00
engine-flutter-autoroll
82a2c28688
Roll Skia from edf0f8a5bba6 to 763bba9c33fd (1 revision) ( #173213 )
...
https://skia.googlesource.com/skia.git/+log/edf0f8a5bba6..763bba9c33fd
2025-08-04 kjlubick@google.com Reland "Roll Skia Infra from d032ed5ea841
to 57b81f6717e0 (12 revisions)"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,bungeman@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-04 14:37:21 +00:00
Kostia Sokolovskyi
a128ccbe94
[web] Add Intl.Locale to parse browser languages. ( #172964 )
...
Closes https://github.com/flutter/flutter/issues/130174
### Description
- Adds `DomLocale` extension type for
[`Intl.Locale`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Locale )
- Replaces manual browser language parsing with `DomLocale` usage
- Adds tests to cover new functionality
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-08-04 14:28:20 +00:00
engine-flutter-autoroll
fe07188bf3
Roll Skia from 439f80973f4a to edf0f8a5bba6 (2 revisions) ( #173204 )
...
https://skia.googlesource.com/skia.git/+log/439f80973f4a..edf0f8a5bba6
2025-08-04 greengrape@google.com Revert "Roll Skia Infra from
d032ed5ea841 to 57b81f6717e0 (12 revisions)"
2025-08-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 2ef85c2418f4 to b6b2f380814e (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,bungeman@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-04 11:43:27 +00:00
