engine-flutter-autoroll
c836426f6a
Roll Skia from af6feb799ea6 to f88706e3a863 (2 revisions) ( #171056 )
...
https://skia.googlesource.com/skia.git/+log/af6feb799ea6..f88706e3a863
2025-06-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 31127c60fb32 to 1b6f53279a7b (12 revisions)
2025-06-24 fmalita@google.com Revert "[gn] Split :pdf and :xps from
:skia"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com ,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-24 06:36:32 +00:00
engine-flutter-autoroll
1c00399b47
Roll Dart SDK from aebd78999b1a to d9edd9e7a634 (1 revision) ( #171053 )
...
https://dart.googlesource.com/sdk.git/+log/aebd78999b1a..d9edd9e7a634
2025-06-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-268.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-24 04:04:34 +00:00
engine-flutter-autoroll
3704500e6e
Roll Skia from ae517eba0170 to af6feb799ea6 (1 revision) ( #171052 )
...
https://skia.googlesource.com/skia.git/+log/ae517eba0170..af6feb799ea6
2025-06-24
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com ,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-24 03:46:27 +00:00
engine-flutter-autoroll
0db6d7b1bb
Roll Skia from a7735d517e6a to ae517eba0170 (9 revisions) ( #171049 )
...
https://skia.googlesource.com/skia.git/+log/a7735d517e6a..ae517eba0170
2025-06-23 mike@reedtribe.org Declare SkPathVerb to use uint8_t storage
2025-06-23 fmalita@google.com [gn] Split :pdf and :xps from :skia
2025-06-23 fmalita@google.com Reland "move pathops into a module"
2025-06-23
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-06-23 syoussefi@google.com [vulkan] Remove VulkanPreferredFeautres
usage assert
2025-06-23 robertphillips@google.com [graphite] Handle
"CoverBoundsRenderStep[InverseCover] + (empty)" Pipeline(s)
2025-06-23 michaelludwig@google.com [graphite] Add
SK_TRACE_GRAPHITE_PIPELINE_USE build variant, expand tracing
2025-06-23 zengyonghust@gmail.com Correct the writing errors in
discardStatement().
2025-06-23 danieldilan@google.com Implement specialized A8 blur to
SkBlurEngine from SkMaskBlurFilter
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com ,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-24 01:20:24 +00:00
Ryan Macnak
475f732faa
Enable interpretation fallback when unable to JIT on iOS. ( #170835 )
...
Bug: https://github.com/flutter/flutter/issues/163984
2025-06-24 01:12:29 +00:00
Kevin Moore
8aef6e2775
Flutter test cleanup ( #170891 )
...
Mostly related to error tracking.
2025-06-24 00:10:55 +00:00
Matan Lurey
40766c2752
Move packages_autoroller out of the carcass of conductor, delete conductor ( #171029 )
...
Towards https://github.com/flutter/flutter/issues/169780 .
Sorted the workspace paths while I was at it.
2025-06-24 00:03:41 +00:00
auto-submit[bot]
46ecb28f7e
Reverts "Don't strip symbols from libapp.so on android by default ( #162464 )" ( #171044 )
...
<!-- start_original_pr_link -->
Reverts: flutter/flutter#162464
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: gmackall
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Failing `Linux_pixel_7pro android_obfuscate_test`
(https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_pixel_7pro%20android_obfuscate_test/8088/overview )
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: gmackall
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {mraleph, bkonyi}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
Fixes https://github.com/flutter/flutter/issues/170664
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
<!-- end_revert_body -->
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
2025-06-23 23:07:48 +00:00
engine-flutter-autoroll
86ce755359
Roll Dart SDK from a09de0d3556c to aebd78999b1a (2 revisions) ( #171039 )
...
https://dart.googlesource.com/sdk.git/+log/a09de0d3556c..aebd78999b1a
2025-06-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-267.0.dev
2025-06-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-266.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-23 22:57:29 +00:00
Gray Mackall
619acc278e
Don't strip symbols from libapp.so on android by default ( #162464 )
...
Fixes https://github.com/flutter/flutter/issues/170664
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Gray Mackall <mackall@google.com>
2025-06-23 21:50:09 +00:00
engine-flutter-autoroll
02c90f0089
Roll Skia from 0311837abe86 to a7735d517e6a (12 revisions) ( #171037 )
...
https://skia.googlesource.com/skia.git/+log/0311837abe86..a7735d517e6a
2025-06-23 michaelludwig@google.com [graphite] Extract intersect_shape
helper from RawElement::combine
2025-06-23 mike@reedtribe.org Make pathbuilder robust for odd inputs
2025-06-23 robertphillips@google.com [graphite] Expand
PrecompileSettings to include kAnalyticClip handling
2025-06-23 mike@reedtribe.org Use SkPathBuilder for building
2025-06-23 mike@reedtribe.org Use pathbuilder in freetype
2025-06-23 kjlubick@google.com Make SkImage_Raster get cpu Recorder from
GPU recorders
2025-06-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 317a1e4780ef to 31127c60fb32 (1 revision)
2025-06-23
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-06-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 9e24b0b15986 to 5220e634850e (7 revisions)
2025-06-23
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-06-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 825731c55823 to 63bd78a28535 (5 revisions)
2025-06-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 47399fc146fa to 0ce9bc68d3fc (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com ,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-23 21:24:09 +00:00
bungeman
a7713b0168
Pass font scanner to font mgr that need it ( #170701 )
...
Skia is removing the constructors which default to the FreeType font
scanner. This will allow Skia to simplify dependencies.
2025-06-23 21:12:30 +00:00
Jackson Gardner
6b17f99216
Make service worker tests more lenient. ( #170939 )
...
Some of these request paths are not guaranteed to be requested by the
time the test is finished, which makes this test somewhat flaky. We
don't really care about verifying these requests specifically anyway, so
just don't track them or compare them to our expectations.
This fixes https://github.com/flutter/flutter/issues/171025
2025-06-23 20:28:24 +00:00
Loïc Sharma
2a82af4d2f
Remove update CHANGELOG step from stable cherry pick process ( #171017 )
2025-06-23 18:46:49 +00:00
Victoria Ashworth
73282fd455
Include dev_dependencies in all builds for iOS and macOS ( #171015 )
...
Currently dev_dependencies are excluded from release builds. However,
this is not implemented fully for iOS and macOS yet and has caused
issues. So until the iOS team is ready and can fully implement this
feature, we're removing it for iOS and macOS.
Fixes https://github.com/flutter/flutter/issues/170119 ,
https://github.com/flutter/flutter/issues/167377 .
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-23 18:43:50 +00:00
Matan Lurey
b74cbbb5fd
Move web_long_running_tests_{1,5}_5 to bringup. ( #171026 )
...
See https://github.com/flutter/flutter/issues/171025 .
2025-06-23 18:20:32 +00:00
ash2moon
4fb1042870
rename from announce to supportsAnnounce on engine ( #170618 )
...
Part of https://github.com/flutter/flutter/issues/165510
⤴️ Original PR: https://github.com/flutter/flutter/pull/169685
⤵️ Child PR: https://github.com/flutter/flutter/pull/168992
This is a renaming of the announce to `supportsAnnounce`. See more info
in this comment thread:
https://github.com/flutter/flutter/pull/168992#discussion_r2146068546
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-23 18:17:09 +00:00
flutter-pub-roller-bot
f1c146181a
Roll pub packages ( #171016 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2025-06-23 17:38:02 +00:00
Azat
148e794e1c
Enhance Text Contrast for WCAG AAA Compliance ( #170758 )
...
Enhance Text Contrast for WCAG AAA Compliance #170697
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
---------
Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com>
2025-06-23 17:34:10 +00:00
Mouad Debbar
d733bea58c
Add --no-web-resources-cdn to all web integration tests ( #171013 )
...
Let's avoid downloading canvaskit from the CDN in our integration tests.
Closes https://github.com/flutter/flutter/issues/110879
2025-06-23 17:02:27 +00:00
Ben Konyi
57f27a7828
[ Tool ] Roll package:dds 5.0.4 ( #171007 )
2025-06-23 16:33:52 +00:00
jesswrd
20969cf264
Update Docs to Warn Users Edge-To-Edge opt out is being deprecated for Android 16+ (API 36+) ( #170816 )
...
Documenting that starting Android 16 (API 36) there will be no way to
opt out of Edge to Edge mode, which was added in Android 15 (API 35)
with a way to opt out.
Fixes https://github.com/flutter/flutter/issues/165329
Partially Addresses https://github.com/flutter/flutter/issues/169746 ,
https://github.com/flutter/flutter/issues/169251 ,
https://github.com/flutter/flutter/issues/163545 ,
https://github.com/flutter/flutter/issues/165329
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-23 16:33:51 +00:00
gaaclarke
bc30d1cd41
License cpp jun20 ( #170948 )
...
I'm down to 40 exceptions and runtime 20s.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-23 16:18:37 +00:00
Mouad Debbar
f8f9506fc0
Un-bringup Linux web_tool_tests ( #171004 )
...
Since https://github.com/flutter/flutter/pull/170565 the `Linux
web_tool_tests` task has been green:
-
https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.staging/Linux%20web_tool_tests?limit=100
-
https://flutter-dashboard.appspot.com/#/build?taskFilter=Linux+web_tool&showBringup=true
Fixes https://github.com/flutter/flutter/issues/169574
2025-06-23 16:10:11 +00:00
engine-flutter-autoroll
6983043d3b
Roll Packages from 7f41e758714a to 02770da46831 (5 revisions) ( #171006 )
...
7f41e75871...02770da468
2025-06-23 engine-flutter-autoroll@skia.org Roll Flutter from
c7362b475576 to 0ab008a17228 (18 revisions) (flutter/packages#9472 )
2025-06-20 stuartmorgan@google.com [video_player] Update tests for
deprecatitons (flutter/packages#9463 )
2025-06-20 stuartmorgan@google.com [google_maps_flutter] Annotate
`zIndex` usage (flutter/packages#9462 )
2025-06-20 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
b25305a8832c to 6fba2447e95c (11 revisions) (flutter/packages#9435 )
2025-06-20 engine-flutter-autoroll@skia.org Roll Flutter from
85a9b4f38906 to c7362b475576 (14 revisions) (flutter/packages#9466 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-23 15:54:00 +00:00
engine-flutter-autoroll
ff1be7d67e
Roll Dart SDK from bb16990911b5 to a09de0d3556c (2 revisions) ( #171000 )
...
https://dart.googlesource.com/sdk.git/+log/bb16990911b5..a09de0d3556c
2025-06-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-265.0.dev
2025-06-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-264.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-23 14:18:46 +00:00
Bruno Leroux
99d909aed0
Reland: Fix InputDecoration.floatingLabelBehavior is not inherited ( #170995 )
...
## Description
Reland https://github.com/flutter/flutter/pull/170905 which was reverted
in https://github.com/flutter/flutter/pull/170994
The change from https://github.com/flutter/flutter/pull/170905 had to be
adjusted with a change which landed just before
(https://github.com/flutter/flutter/pull/168981 ).
2025-06-23 09:03:21 +00:00
engine-flutter-autoroll
c099f038fc
Roll Skia from aef4081157f0 to 0311837abe86 (1 revision) ( #170992 )
...
https://skia.googlesource.com/skia.git/+log/aef4081157f0..0311837abe86
2025-06-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 83f69a4f154f to d03fe7eda12d (37 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com ,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-23 08:41:33 +00:00
Sigurd Meldgaard
a0e30bf18a
Run pub get post-processing for each package in workspace ( #170517 )
...
Fixes https://github.com/flutter/flutter/issues/161927
2025-06-23 08:37:26 +00:00
auto-submit[bot]
73daff152f
Reverts "Fix InputDecoration.floatingLabelBehavior is not inherited ( #170905 )" ( #170994 )
...
<!-- start_original_pr_link -->
Reverts: flutter/flutter#170905
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: goderbauer
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Analyzer failure: `The argument type
'InputDecorationTheme' can't be assigned to the parameter type
'InputDecorationThemeData?'. •
packages/flutter/test/material/input_decorator_test.dart:2959:33 •
argument_type_not_assignable`
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: bleroux
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {justinmc}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
## Description
This PR fixes `InputDecoration.floatingLabelBehavior` logic to query
ambient InputDecorationTheme.floatingLabelBehavior, previously it was
ignored.
## Related Issue
Fixes [InputDecorationTheme and IconTheme isn't fully
inherited](https://github.com/flutter/flutter/issues/71813 )
Will help to complete https://github.com/flutter/flutter/pull/168981
## Tests
Adds 1 test
<!-- end_revert_body -->
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
2025-06-23 07:24:42 +00:00
Bruno Leroux
6ebb7cf46b
Fix InputDecoration.floatingLabelBehavior is not inherited ( #170905 )
...
## Description
This PR fixes `InputDecoration.floatingLabelBehavior` logic to query
ambient InputDecorationTheme.floatingLabelBehavior, previously it was
ignored.
## Related Issue
Fixes [InputDecorationTheme and IconTheme isn't fully
inherited](https://github.com/flutter/flutter/issues/71813 )
Will help to complete https://github.com/flutter/flutter/pull/168981
## Tests
Adds 1 test
2025-06-23 06:09:28 +00:00
engine-flutter-autoroll
4df47b7f40
Roll Skia from fcd1c55da9cc to aef4081157f0 (1 revision) ( #170990 )
...
https://skia.googlesource.com/skia.git/+log/fcd1c55da9cc..aef4081157f0
2025-06-23
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com ,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-23 04:07:39 +00:00
Robert Ancell
8d5d0e21e9
Clear background in the GTK layer, instead of OpenGL ( #170840 )
...
Since OpenGL was being blitted, it would overwrite the color set with
clear color anyway. Also fix the software rendering case that was not
setting any background.
This could cause a black screen to show by default, if you want the
previous behaviour set the view background to transparent with:
```
GdkRGBA background_color;
gdk_rgba_parse(&background_color, "#00000000 ");
fl_view_set_background_color(view, &background_color);
```
---------
Co-authored-by: Matthew Kosarek <matt.kosarek@canonical.com>
2025-06-22 23:55:25 +00:00
Robert Ancell
5d5355f48d
Show window on first frame on Linux ( #170844 )
...
Wait for the first Flutter frame before showing the window. This avoids
showing a window with empty Flutter content, which defaults to a black
background.
Part of https://github.com/flutter/flutter/issues/55427
Fixes https://github.com/flutter/flutter/issues/118269
2025-06-22 22:46:36 +00:00
engine-flutter-autoroll
dd40c13375
Roll Dart SDK from 98db1db5ff65 to bb16990911b5 (1 revision) ( #170988 )
...
https://dart.googlesource.com/sdk.git/+log/98db1db5ff65..bb16990911b5
2025-06-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-263.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-22 22:13:32 +00:00
engine-flutter-autoroll
0ab008a172
Roll Skia from 203469ef4672 to fcd1c55da9cc (1 revision) ( #170986 )
...
https://skia.googlesource.com/skia.git/+log/203469ef4672..fcd1c55da9cc
2025-06-22 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com
Update SKP version
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com ,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-22 14:47:30 +00:00
engine-flutter-autoroll
06911952c8
Roll Dart SDK from e5db5e0f81ba to 98db1db5ff65 (2 revisions) ( #170979 )
...
https://dart.googlesource.com/sdk.git/+log/e5db5e0f81ba..98db1db5ff65
2025-06-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-262.0.dev
2025-06-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-261.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-22 00:00:39 +00:00
Bruno Leroux
de3f804590
Normalize input decoration theme ( #168981 )
...
This PR is to make `InputDecorationTheme` conform to Flutter Material's
conventions for component themes:
- Added a `InputDecorationThemeData` class which defines overrides for
the defaults for `InputDecorator` properties.
- Added `InputDecorationTheme` constructor parameters:
`InputDecorationThemeData? data` and `Widget? child`. This is now the
preferred way to configure a `InputDecorationTheme`:
```dart
InputDecorationTheme(
data: InputDecorationThemeData(
filled: true,
fillColor: Colors.amber,
...
),
child: const TextField()
)
```
These two properties are made nullable to not break existing apps which
has customized `ThemeData.inputDecorationTheme`.
- Update `InputDecorationTheme` to be an `InheritedTheme` subclass.
- Changed the type of component theme defaults from
`InputDecorationTheme` to `InputDecorationThemeData`.
- Changed the `InputDecorationTheme bottomAppBarTheme` property to
`Object? bottomAppBarTheme` in `ThemeData` and `ThemeData.copyWith()`
(Object? is used for the moment to minimize Google tests failure. A
follow-up PR will replace `Object?` with `InputDecorationThemeData`.
- Addresses the "theme normalization" sub-project within #91772 .
A migration guide will be created on website repo.
2025-06-21 23:02:13 +00:00
engine-flutter-autoroll
84885d2555
Roll Skia from dceb857b1c47 to 203469ef4672 (1 revision) ( #170959 )
...
https://skia.googlesource.com/skia.git/+log/dceb857b1c47..203469ef4672
2025-06-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from a875f13dac14 to 317a1e4780ef (3 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
danieldilan@google.com ,jimgraham@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-21 12:54:22 +00:00
engine-flutter-autoroll
6a3cc3f372
Roll Dart SDK from 6325aeacaef4 to e5db5e0f81ba (1 revision) ( #170958 )
...
https://dart.googlesource.com/sdk.git/+log/6325aeacaef4..e5db5e0f81ba
2025-06-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-260.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-21 12:30:42 +00:00
engine-flutter-autoroll
35aa07e4ea
Roll Dart SDK from a6a3d65e33d7 to 6325aeacaef4 (2 revisions) ( #170955 )
...
https://dart.googlesource.com/sdk.git/+log/a6a3d65e33d7..6325aeacaef4
2025-06-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-259.0.dev
2025-06-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-258.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-21 07:21:42 +00:00
engine-flutter-autoroll
eaa168d699
Roll Skia from 773188560221 to dceb857b1c47 (1 revision) ( #170954 )
...
https://skia.googlesource.com/skia.git/+log/773188560221..dceb857b1c47
2025-06-21
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
danieldilan@google.com ,jimgraham@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-21 02:37:26 +00:00
engine-flutter-autoroll
549fa4e6fb
Roll Dart SDK from 750eaa028445 to a6a3d65e33d7 (1 revision) ( #170953 )
...
https://dart.googlesource.com/sdk.git/+log/750eaa028445..a6a3d65e33d7
2025-06-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-257.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-21 02:05:41 +00:00
YU-KI Hidea
453d113161
Fix the Japanese IME problem on macOS reported in the following issue. ( #166291 )
...
flutter/engine#57286
Fixes https://github.com/flutter/flutter/issues/160935
2025-06-21 00:10:21 +00:00
engine-flutter-autoroll
37a85d9fdd
Roll Fuchsia Test Scripts from IfPORaYjQ2zP4bcq-... to 2wEtX_lDNhHhDNsP6... ( #170946 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-test-scripts-flutter
Please CC chrome-fuchsia-engprod@google.com ,jimgraham@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-21 00:10:21 +00:00
engine-flutter-autoroll
7f3f08cff2
Roll Skia from 104460420c48 to 773188560221 (2 revisions) ( #170942 )
...
https://skia.googlesource.com/skia.git/+log/104460420c48..773188560221
2025-06-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 316ed08fbc9a to a875f13dac14 (8 revisions)
2025-06-20 thomsmit@google.com Fix SubSetting on Mali400
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
danieldilan@google.com ,jimgraham@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-20 23:22:08 +00:00
Huy
41acbd244d
Normalize AppBarTheme ( #169130 )
...
This PR is to make `AppBarTheme` conform to Flutter Material's
conventions for component themes:
- Added a `AppBarThemeData` class which defines overrides for the
defaults for `AppBar` properties.
- Added AppBarTheme constructor parameters: `AppBarThemeData? data` and
`Widget? child`. This is now the preferred way to configure a
`AppBarTheme`:
```dart
AppBarTheme(
data: AppBarThemeData(),
child: Scaffold(
appBar: AppBar(
title: xxx,
leading: xxx,
actions: xxx,
),
),
```
These two properties are made nullable to not break existing apps which
has customized `ThemeData.appBarTheme`.
- Update `AppBarTheme` to be an `InheritedWidget` subclass.
- Changed the type of component theme defaults from `AppBarTheme` to
`AppBarThemeData`.
- Add new tests for `AppBarThemeData` and update the existing
`AppBarTheme` tests.
- This also temporarily changes `AppBarThemeData` to `Object?` in
`ThemeData` class, to bypass g3 tests, following
https://github.com/flutter/flutter/pull/168586#discussion_r2082606584 .
- Addresses the "theme normalization" sub-project within
https://github.com/flutter/flutter/issues/91772 .
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Signed-off-by: huycozy <huy@nevercode.io>
Co-authored-by: Qun Cheng <chengqunq@gmail.com>
2025-06-20 23:07:37 +00:00
Victor Sanni
be8cdeb84f
Close CupertinoContextMenu overlay if the widget is disposed or a new route is pushed ( #170186 )
...
Fixes [CupertinoContextMenu potential unremoved overlay
entry](https://github.com/flutter/flutter/issues/131471 )
Fixes [CupertinoContextMenu onTap gesture interferes with child widget
with onTap
GestureRecognizer](https://github.com/flutter/flutter/issues/169911 )
<details>
<summary>Sample code</summary>
```dart
import 'dart:async';
import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';
bool ctxMenuRemoved = false;
class ContextMenuApp extends StatelessWidget {
const ContextMenuApp({super.key});
@override
Widget build(BuildContext context) {
final colorScheme = ColorScheme.fromSeed(seedColor: Colors.orange);
return MaterialApp(
theme: ThemeData(
colorScheme: colorScheme,
appBarTheme:
AppBarTheme(backgroundColor: colorScheme.secondaryContainer),
),
home: const HomePage(),
);
}
}
class HomePage extends StatelessWidget {
const HomePage({super.key});
@override
Widget build(BuildContext context) => Scaffold(
appBar: AppBar(
title: Text('Home'),
),
body: Center(
child: CupertinoContextMenu(
actions: [
CupertinoContextMenuAction(
child: Text('Test'),
),
],
child: GestureDetector(
onTap: () {
Navigator.of(context).push(
MaterialPageRoute(builder: (context) => _OtherPage()),
);
},
child: Container(
color: Colors.orange,
height: 100,
width: 100,
),
),
),
),
);
}
class _OtherPage extends StatelessWidget {
const _OtherPage({super.key});
@override
Widget build(BuildContext context) {
return Scaffold(
body: Align(
child: Builder(builder: (context) {
return Listener(
onPointerDown: (_) {
Timer(const Duration(milliseconds: 480), () {
ctxMenuRemoved = true;
(context as Element).markNeedsBuild();
});
},
child: ctxMenuRemoved
? const SizedBox()
: CupertinoContextMenu(
actions: [
CupertinoContextMenuAction(
child: const Text('Action one'),
onPressed: () {},
),
],
child: Container(
height: 100,
width: 100,
color: Colors.black45,
),
),
);
}),
),
);
}
}
```
</details>
2025-06-20 22:20:11 +00:00
engine-flutter-autoroll
cca7287639
Roll Dart SDK from a554bdd0a2cc to 750eaa028445 (1 revision) ( #170933 )
...
https://dart.googlesource.com/sdk.git/+log/a554bdd0a2cc..750eaa028445
2025-06-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-256.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-20 21:00:18 +00:00
engine-flutter-autoroll
6dff536403
Roll Skia from b638003de37e to 104460420c48 (1 revision) ( #170932 )
...
https://skia.googlesource.com/skia.git/+log/b638003de37e..104460420c48
2025-06-20 syoussefi@google.com [vulkan] Adjust Vulkan preferred
features expectations
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
danieldilan@google.com ,jimgraham@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-20 20:54:08 +00:00