Sam Rawlins
d72b1388b3
Update Setting-up-the-Engine-development-environment.md ( #171051 )
...
* Note that the flutter tool does not have sections. The docs do.
* Link to the relevant section.
2025-06-30 18:01:12 +00:00
John "codefu" McDole
123e969efa
feat: add "stamp" to et and create build-time engine_stamp.json ( #171310 )
...
Writes a stamp file, engine_stamp.json, containing interesting
information about this build:
```json
{
"build_date": "2025-06-27T16:35:13.279188",
"build_time_ms": 1751067313279,
"git_revision": "e68e105667e9e5cace56b0431781062b773e4831",
"git_revision_date": "2025-06-27 15:51:55 -0700",
"content_hash": "23542e452fc55890626fd1c5eb77c4788c19f983"
}
```
Later; I'll update to the flutter tool to download this artifact to
bin/cache so it can be used instead of git commands.
2025-06-30 17:55:27 +00:00
Alex Medinsh
ee23d89857
Add CupertinoPicker ticking sound ( #170641 )
...
This PR adds a ticking sound to the `CupertinoPicker` on iOS.
Fixes https://github.com/flutter/flutter/issues/37329
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-06-30 17:54:07 +00:00
flutter-pub-roller-bot
2d80470bb5
Roll pub packages ( #171392 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2025-06-30 17:13:09 +00:00
engine-flutter-autoroll
d2b7e2a17e
Roll Packages from 4841ada7ad75 to 471bfd305f4e (7 revisions) ( #171384 )
...
4841ada7ad...471bfd305fstuartmorgan@google.com [google_maps_flutter] Remove legacy
renderer tests (flutter/packages#9517 )
2025-06-30 49699333+dependabot[bot]@users.noreply.github.com Bump
lewagon/wait-on-check-action from 1.3.4 to 1.4.0 in the
all-github-actions group (flutter/packages#9524 )
2025-06-29 43054281+camsim99@users.noreply.github.com
[camera_android_camerax] Fix incorrectly rotated captured photos
(flutter/packages#9498 )
2025-06-29 stuartmorgan@google.com [in_app_purchase] Annotate
deprecation in test (flutter/packages#9473 )
2025-06-29 malo.allee@gmail.com [video_player] Add poster attribute for
html video tag in video_player_platform_interface
(flutter/packages#8979 )
2025-06-29 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
6fba2447e95c to fcf2c11572af (6 revisions) (flutter/packages#9502 )
2025-06-29 muhatashim@google.com Skip test to unblock packages
(flutter/packages#9516 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-30 16:33:21 +00:00
Mouad Debbar
dc56ed81da
Run expression_evaluation_web_ddc_library_bundle_test.dart on Mac/Windows ( #171278 )
...
Part of https://github.com/flutter/flutter/issues/171276
2025-06-30 14:59:32 +00:00
flutter-pub-roller-bot
e3e51935dd
Roll pub packages ( #171091 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2025-06-30 14:31:25 +00:00
Derek Xu
10f0589a14
Activate microtask profiling in dart:async when Switch::ProfileMicrotasks is set ( #171035 )
...
Here is the logic in the Dart VM that is analogous to the logic in this
PR:
2be548666d/runtime/bin/dartutils.cc (L540-L561)
2025-06-30 13:59:34 +00:00
Moritz
94f9963199
Unpin package:intl ( #169286 )
...
Fixes #158050
Created by running `flutter update-packages --cherry-pick=intl:^0.20.2
--exclude-tools` - we probably don't want to unpin `flutter_tools`
dependencies to avoid breaking it.
Add comment to `package:intl`s pubspec in
https://github.com/dart-lang/i18n/pull/980 .
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-30 06:19:21 +00:00
engine-flutter-autoroll
cfd2047b6d
Roll Dart SDK from 96807993a052 to 3061dd665885 (1 revision) ( #171362 )
...
https://dart.googlesource.com/sdk.git/+log/96807993a052..3061dd665885
2025-06-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-290.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-30 03:47:37 +00:00
engine-flutter-autoroll
f346592ade
Roll Dart SDK from fb5803534ded to 96807993a052 (1 revision) ( #171357 )
...
https://dart.googlesource.com/sdk.git/+log/fb5803534ded..96807993a052
2025-06-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-289.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-29 22:43:26 +00:00
engine-flutter-autoroll
706525b262
Roll Skia from 340371f50fc8 to 8de238c050fb (1 revision) ( #171354 )
...
https://skia.googlesource.com/skia.git/+log/340371f50fc8..8de238c050fb
2025-06-29 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com
Update SKP version
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
aaclarke@google.com ,kjlubick@google.com,michaelludwig@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-29 14:48:25 +00:00
engine-flutter-autoroll
c25f5dd896
Roll Skia from 023fe1834785 to 340371f50fc8 (1 revision) ( #171349 )
...
https://skia.googlesource.com/skia.git/+log/023fe1834785..340371f50fc8
2025-06-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from d284305388b0 to d90e098a4598 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
aaclarke@google.com ,kjlubick@google.com,michaelludwig@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-29 08:40:25 +00:00
engine-flutter-autoroll
e44ab22aa4
Roll Skia from 8657e39b03e7 to 023fe1834785 (1 revision) ( #171342 )
...
https://skia.googlesource.com/skia.git/+log/8657e39b03e7..023fe1834785
2025-06-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from b39b1685ca27 to d284305388b0 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-28 19:09:24 +00:00
Nate Biggs
85486ffffc
Allow minification to be toggled for wasm builds ( #171211 )
...
Provides extra minification controls for web builds. Updates the
existing `--minify` flag to pass its value to both JS and wasm (instead
of just JS).
Also adds two new flags `--minify-js` and `--minify-wasm` which toggle
minification for just one of the web targets. While JS minification has
a huge impact on code size, wasm minification has a much smaller effect
on the program's size. Since minification can obfuscate useful info
(like errors) one may want to turn off minification for wasm but leave
it on for JS.
The plan is to temporarily use `--no-minify-wasm` for devtools to help
debug some exceptions being seen.
---------
Co-authored-by: Nate Biggs <natebiggs@google.com>
2025-06-28 17:46:44 +00:00
engine-flutter-autoroll
771b631eae
Roll Fuchsia Linux SDK from mQv6OKiD6nn3FNUYG... to paQphLeTdjksq0VgK... ( #171340 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC aaclarke@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-28 16:26:33 +00:00
engine-flutter-autoroll
02da4cc00d
Roll Dart SDK from ccd972a7de32 to fb5803534ded (1 revision) ( #171321 )
...
https://dart.googlesource.com/sdk.git/+log/ccd972a7de32..fb5803534ded
2025-06-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-288.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-28 08:55:18 +00:00
engine-flutter-autoroll
9e9fccd3d2
Roll Skia from af1b461830c0 to 8657e39b03e7 (1 revision) ( #171316 )
...
https://skia.googlesource.com/skia.git/+log/af1b461830c0..8657e39b03e7
2025-06-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 7693ce33ea24 to b39b1685ca27 (11 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-28 05:23:15 +00:00
engine-flutter-autoroll
60e85d6317
Roll Dart SDK from f29159da9270 to ccd972a7de32 (1 revision) ( #171315 )
...
https://dart.googlesource.com/sdk.git/+log/f29159da9270..ccd972a7de32
2025-06-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-287.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-28 03:59:20 +00:00
Valentin Vignal
b2056cb629
Add radioBackgroundColor to RadioListTile ( #171204 )
...
Part of https://github.com/flutter/flutter/issues/168787
Continuation of https://github.com/flutter/flutter/pull/169415
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-28 03:47:20 +00:00
engine-flutter-autoroll
c3119fc319
Roll Fuchsia Test Scripts from 2wEtX_lDNhHhDNsP6... to ZpnML-jis0gVIvtx5... ( #171314 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-test-scripts-flutter
Please CC aaclarke@google.com ,chrome-fuchsia-engprod@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-28 03:16:09 +00:00
engine-flutter-autoroll
9d220154d7
Roll Skia from 2dc747ddcc4e to af1b461830c0 (1 revision) ( #171313 )
...
https://skia.googlesource.com/skia.git/+log/2dc747ddcc4e..af1b461830c0
2025-06-28
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-28 03:08:23 +00:00
Loïc Sharma
94e97d9c12
Ensure disabling text fields' interactive selection disables shortcuts ( #171050 )
...
[`EditableText.enableInteractiveSelection`](https://api.flutter.dev/flutter/widgets/EditableText/enableInteractiveSelection.html )
can be used to disable text selection and shortcuts in a text field.
Previously, `EditableText` would disable the shortcut actions using
[`Action.isEnabled`](https://api.flutter.dev/flutter/widgets/Action/isEnabled.html ).
As a result, the action would ignore the key event, and the key event
would propagate. On some platforms, the key event would propagate to the
native text view, causing weird behaviors like text getting copied.
Now, the text field shortcuts stop propagation of the key event when
`enableInteractiveSelection` is `false`. This ensures that the text
field "consumes" the key events and prevents a parent of the text field
or native views from receiving the key event.
Partially addresses https://github.com/flutter/flutter/issues/157611
⚠️ Note: This does not fix the bug on Flutter Web as it handles text
field shortcuts separately. This will be fixed in a separate pull
request.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-28 00:01:27 +00:00
engine-flutter-autoroll
5ae914e869
Roll Dart SDK from ae2f0f72ec2e to f29159da9270 (2 revisions) ( #171302 )
...
https://dart.googlesource.com/sdk.git/+log/ae2f0f72ec2e..f29159da9270
2025-06-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-286.0.dev
2025-06-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-285.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-27 22:37:24 +00:00
Matan Lurey
1d93621ed4
Ensure flutter_tools's pubspec.lock is newer than pubspec.yaml ( #171300 )
...
Closes https://github.com/flutter/flutter/issues/171024 .
2025-06-27 22:26:32 +00:00
Gray Mackall
36ec20bd78
[Android] Remap each pair of (pointerId, toolType) to its own unique id ( #171240 )
...
Fixes https://github.com/flutter/flutter/issues/160144 , by replacing the
ID passed by original Android `MotionEvent` with a newly constructed one
that is unique per tool type, per offline discussion with @dkwingsmt.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Gray Mackall <mackall@google.com>
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
Co-authored-by: Reid Baker <1063596+reidbaker@users.noreply.github.com>
2025-06-27 21:38:15 +00:00
engine-flutter-autoroll
d6d41df9c6
Roll Skia from a37b97ce2b74 to 2dc747ddcc4e (2 revisions) ( #171295 )
...
https://skia.googlesource.com/skia.git/+log/a37b97ce2b74..2dc747ddcc4e
2025-06-27 bungeman@google.com Remove SkFontMgr_New_* FreeType defaults
2025-06-27
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-27 21:13:00 +00:00
Nicholas Shahan
4a60bf22a7
Re-combine reload error and restart test cases ( #171251 )
...
Also add an explicit test case for reload rejection error followed by an
expression evaluation.
These cases should work as expected now that this Dart SDK change has
been rolled into Flutter
https://dart-review.googlesource.com/c/sdk/+/434522 .
Closes https://github.com/flutter/flutter/issues/170062
2025-06-27 21:03:14 +00:00
Lucas SAUDON
8aa701bf0c
fix: Add focusNode and textEditingController in Autocomplete ( #170936 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
*Allows you to keep the selected value when the autocomplete is in a
listview and you scroll through it.*
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
2025-06-27 20:38:07 +00:00
Juergen Werner
5b6b62183f
NavigationRail: optionally scrollable and more configurable ( #169421 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
This is modified and extended version of the merged and reverted PR
#137415 . It was reverted, because it broke a the sample app "Material 3
demo". This PR circumvents the breaking of existing code, by making the
changes optional via constructor parameters. Default values for the
parameters are functionally equivalent to the state before this change.
The new key parameter for this is `scrollable`.
Additionally this change includes the parameters `leadingAtTop: true`
and `trailingAtBottom: false`.
Fixes #89167
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-27 18:19:06 +00:00
engine-flutter-autoroll
8f70d8c510
Roll Packages from 2c8d2bc0589c to 4841ada7ad75 (8 revisions) ( #171292 )
...
2c8d2bc058...4841ada7ad#9427 )"
(flutter/packages#9509 )
2025-06-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts
"[ci] Remove in_app_purchase_storekit from Xcode analyzer exclusion list
(#9429 )" (flutter/packages#9507 )
2025-06-26 magder@google.com [ci] Check macOS 15 for Xcode analyzer
warnings (flutter/packages#9427 )
2025-06-26 magder@google.com [ci] Remove in_app_purchase_storekit from
Xcode analyzer exclusion list (flutter/packages#9429 )
2025-06-26 stuartmorgan@google.com [google_sign_in] Add contributor
setup instructions (flutter/packages#9489 )
2025-06-26 stuartmorgan@google.com [google_sign_in] Use an activity for
credential requests (flutter/packages#9497 )
2025-06-26 engine-flutter-autoroll@skia.org Roll Flutter from
d733bea58c1a to 2773c0c8e15e (42 revisions) (flutter/packages#9495 )
2025-06-26 stuartmorgan@google.com
[extension_google_sign_in_as_googleapis_auth] Update to google_sign_in 7
(flutter/packages#9484 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-27 18:16:24 +00:00
Valentin Vignal
f83d842347
Add side to Radio ( #171217 )
...
Part of https://github.com/flutter/flutter/issues/168787
This PR adds `side` parameter to `Radio` to be able to control its color
and width.
This allows me to implement something like:
https://github.com/user-attachments/assets/8065df9b-4cea-48b6-ba34-21379a831a2e
In order to make it non breaking, when absent, it uses the `fillColor`
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-27 17:48:00 +00:00
Mouad Debbar
8b2f80e04f
Run expression_evaluation_web_amd_test.dart on Mac/Windows ( #171277 )
...
Part of https://github.com/flutter/flutter/issues/171276
2025-06-27 17:25:53 +00:00
engine-flutter-autoroll
00e5d4ba70
Roll Dart SDK from c44e64e5a856 to ae2f0f72ec2e (1 revision) ( #171286 )
...
https://dart.googlesource.com/sdk.git/+log/c44e64e5a856..ae2f0f72ec2e
2025-06-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-284.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-27 17:20:23 +00:00
engine-flutter-autoroll
834dfc4053
Roll Skia from e8ac41a93e63 to a37b97ce2b74 (1 revision) ( #171287 )
...
https://skia.googlesource.com/skia.git/+log/e8ac41a93e63..a37b97ce2b74
2025-06-27 lukasza@chromium.org [rust png] Limit the allowed dimensions
of PNG images.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-27 17:18:56 +00:00
Jackson Gardner
af61a6f97d
Revert "[skwasm] Use transferToImageBitmap instead of createImageBitmap ( #163251 )" ( #171238 )
...
This reverts commit 7d22606cda72accc2232e6b9a1f6fee4c6ea1c9c.
It turns out that in many scenarios, resizing the OffscreenCanvas
multiple times per frame is prohibitively expensive. It also turns out
that neither API works well enough on non-Chrome browsers to make it
viable anyway, so we should switch back to `createImageBitmap`.
2025-06-27 17:15:20 +00:00
engine-flutter-autoroll
fa71d1b3e4
Roll Skia from 062c986ad62e to e8ac41a93e63 (1 revision) ( #171273 )
...
https://skia.googlesource.com/skia.git/+log/062c986ad62e..e8ac41a93e63
2025-06-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 15e9b7e82d5a to 7693ce33ea24 (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-27 15:16:12 +00:00
Vladislav Semyanov
d3a2cf8fcd
Fix broken markdown link to Engine repository in Project-teams.md ( #171267 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
This PR fixes a broken markdown link in the Flutter project teams
documentation that prevents proper navigation to the Engine repository.
**Issue Fixed**: In `docs/about/Project-teams.md`, the Engine repository
link was malformed due to a missing opening bracket in the markdown
syntax. The link appeared as `([flutter
engine]https://github.com/flutter/flutter/tree/main/engine )` instead of
proper markdown link syntax.
**Change Made**: Added the missing opening parenthesis to fix the
markdown link:
```diff
- * The Engine ([flutter engine]https://github.com/flutter/flutter/tree/main/engine )
+ * The Engine ([flutter engine](https://github.com/flutter/flutter/tree/main/engine ))
```
**Impact**: This ensures developers reading the documentation can
properly navigate to the Engine repository and that the markdown renders
correctly across all platforms.
This fixes a documentation quality issue found during routine
documentation review. While this doesn't correspond to a specific filed
GitHub issue, it addresses a clear usability problem in the official
Flutter documentation.
## Pre-launch Checklist
- [x] I read the [[Contributor
Guide](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview )]
and followed the process outlined there for submitting PRs.
- [x] I read the [[Tree
Hygiene](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md )]
wiki page, which explains my responsibilities.
- [x] I read and followed the [[Flutter Style
Guide](https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md )],
including [[Features we expect every widget to
implement](https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement )].
- [x] I signed the [[CLA](https://cla.developers.google.com/ )].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[[test-exempt](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests )].
- [x] I followed the [[breaking change
policy](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes )]
and added [[Data Driven
Fixes](https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md )]
where supported.
- [x] All existing and new tests are passing.
**Note**: This PR is test-exempt as it only fixes a markdown syntax
error in documentation. No code functionality is changed, and the fix
can be verified by visual inspection of the markdown rendering.
If you need help, consider asking for advice on the #hackers-new channel
on
[[Discord](https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md )].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-27 13:38:17 +00:00
engine-flutter-autoroll
54e57dd265
Roll Fuchsia Linux SDK from lOriymW5zTP5ByH8-... to mQv6OKiD6nn3FNUYG... ( #171263 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC aaclarke@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-27 08:36:27 +00:00
davidhicks980
86767f6663
[widgets/raw_menu_anchor.3.dart] Replace arrow character with Icon in RawMenuAnchor submenu example ( #171218 )
...
Replaces the arrow character with an icon on the RawMenuAnchor animated
submenu example. Currently, submenu arrows render as gibberish.
Apologies to chunhtai since this is the second time I've done this.
<img width="500" alt="image"
src="https://github.com/user-attachments/assets/866220e3-3d09-4502-9aee-211dc333822d "
/>
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-27 07:29:28 +00:00
Ahmed Elsayed
05add65f63
Reland [ #166645 ] Fix DropdownButtonFormField focusing when replacing FocusNode ( #170761 )
...
This is a reland of #166645
fixes #166642
**The newly added tests verify the following behaviors:**
1. DropdownButtonFormField can be focused if it was unfocused and we
replaced FocusNode.
2. DropdownButtonFormField can be unfocused if it was focused and we
replaced FocusNode.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-06-27 07:12:22 +00:00
engine-flutter-autoroll
306b350bdb
Roll Dart SDK from 4bd485d911a1 to c44e64e5a856 (2 revisions) ( #171260 )
...
https://dart.googlesource.com/sdk.git/+log/4bd485d911a1..c44e64e5a856
2025-06-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-283.0.dev
2025-06-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-282.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-27 07:06:21 +00:00
engine-flutter-autoroll
cd4d714db0
Roll Skia from d388ecb0ceea to 062c986ad62e (1 revision) ( #171259 )
...
https://skia.googlesource.com/skia.git/+log/d388ecb0ceea..062c986ad62e
2025-06-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 793884c7084d to 8acd0e40f584 (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-27 06:48:26 +00:00
engine-flutter-autoroll
42553c9f69
Roll Skia from f041aa580d11 to d388ecb0ceea (2 revisions) ( #171253 )
...
https://skia.googlesource.com/skia.git/+log/f041aa580d11..d388ecb0ceea
2025-06-27 robertphillips@google.com [graphite] Remove need for
kPrecompileCases indices in AndroidPrecompileTest
2025-06-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 216f8f420080 to 15e9b7e82d5a (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-27 02:18:31 +00:00
engine-flutter-autoroll
49cd72063e
Roll Skia from 28b3d2dad5d5 to f041aa580d11 (23 revisions) ( #171248 )
...
https://skia.googlesource.com/skia.git/+log/28b3d2dad5d5..f041aa580d11
2025-06-26
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-06-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 08cf3372adf6 to 216f8f420080 (4 revisions)
2025-06-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 14960950b20c to b3ec3a5f5448 (4 revisions)
2025-06-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 0b45ace1550e to 793884c7084d (7 revisions)
2025-06-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from f1e896dba6c3 to 772f77165cdf (19 revisions)
2025-06-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from ed01d9931de3 to 436722b39118 (1 revision)
2025-06-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 1b6f53279a7b to 08cf3372adf6 (16 revisions)
2025-06-25 danieldilan@google.com Use NinePatch for
SkBitmapDevice::drawBlurredRRect()
2025-06-25 michaelludwig@google.com [graphite] Treat inverse filled
draws as kDifference ops for clip stack traversal
2025-06-25 michaelludwig@google.com [graphite] Check for null surface
for GPU blur profile
2025-06-25 robertphillips@google.com [graphite] Additional
Android-specific PaintOptions
2025-06-25
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-06-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 79ac1a8cd767 to 14960950b20c (3 revisions)
2025-06-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 6043290d5e93 to 0b45ace1550e (9 revisions)
2025-06-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 0df5a8fd9a75 to f1e896dba6c3 (24 revisions)
2025-06-25
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-06-24
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-06-24
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-06-24 fmalita@google.com Revert "Reland "move pathops into a
module""
2025-06-24 michaelludwig@google.com [graphite] Clip shape intersections
rely only on relative transform
2025-06-24 sharaks@google.com Merge 7 release notes into
RELEASE_NOTES.md
2025-06-24 sharaks@google.com Update Skia milestone to 140
2025-06-24 michaelludwig@google.com [graphite] Differentiate async
compile failures from other command failures
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-27 00:07:07 +00:00
engine-flutter-autoroll
c136585897
Roll Dart SDK from 21c55ff25118 to 4bd485d911a1 (2 revisions) ( #171243 )
...
https://dart.googlesource.com/sdk.git/+log/21c55ff25118..4bd485d911a1
2025-06-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-281.0.dev
2025-06-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-280.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-26 23:22:08 +00:00
Justin McCandless
142cce676e
Avoid using a Key whose only purpose is to be looked up in a test ( #170952 )
...
This PR investigates moving away from the few places where we rely on
Keys to instead solely look up a widget in a test. Reasons:
* No extra stuff in users' apps that they don't need for production.
* Avoid collisions between Keys in users' apps that might have the same
identifier string.
I'm definitely still up for discussion on whether or not this is a good
idea!
Written in response to the discussion on
https://github.com/flutter/flutter/pull/170761#discussion_r2159760635 .
2025-06-26 23:18:05 +00:00
Justin McCandless
6b7662649f
Diagnosticable, not toString, for IOSSystemContextMenuItemDatas ( #171028 )
...
Flutter prefers using Diagnosticable instead of toString. See
https://github.com/flutter/flutter/issues/169696 and the related PR
https://github.com/flutter/flutter/pull/169705 . This does the same thing
for a few more classes that I missed.
2025-06-26 23:12:03 +00:00
gaaclarke
2597ee726b
License cpp jun25 ( #171235 )
...
Changes:
1) Headers are now included in the output even if there is a covering
LICENSE file
1) .c files are now included
1) excluded files are now printed out in --v=1
1) there's a new flag that allows us to treat unmatched comments as
errors (since this represents the last of what is missing between
LICENSE and LICENSE_CPP)
1) Adds a tool for auditing LICENSE versus LICENSE_CPP
1) Adds "COPYING" as a potential license file name
The results of the comparison tool showed us that the difference between
LICENSE and LICENSE_CPP is all the matched header licenses for files
that have covering LICENSE files in their directories.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-26 22:26:10 +00:00
engine-flutter-autoroll
cf045ea520
Roll Skia from a462e701b493 to 28b3d2dad5d5 (5 revisions) ( #171093 )
...
https://skia.googlesource.com/skia.git/+log/a462e701b493..28b3d2dad5d5
2025-06-24 fmalita@google.com Guard AnnotationTest on SK_SUPPORT_PDF
2025-06-24 robertphillips@google.com [graphite] Treat linear/encode as
sRGBish for fast path
2025-06-24 kainino@chromium.org [graphite] Handle Dawn breaking change
in WGPUInstanceDescriptor
2025-06-24 michaelludwig@google.com Reland "[graphite]
Context::insertRecording returns more status info on failure"
2025-06-24 nscobie@google.com Revert "Reland "[Fontations] Roll
Fontations""
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-26 21:48:55 +00:00
