8916 Commits

Author SHA1 Message Date
Jason Simmons
a7e14ea474 libtxt: refactor glyph position calculation (#4134)
* Remove padding values in line_heights and glyph_position_x.  Each value
  in glyph_position_x now represents an actual glyph in the layout.

* Remove code intended to handle extra characters beyond the end of the
  last line.  The LineBreaker should ensure that the end of the last run
  matches the end of the last line.

* Return the upstream/downstream affinity of the cursor position in
  GetGlyphPositionAtCoordinate.

* Account for the space at the end of a word wrapped line in
  GetGlyphPositionAtCoordinate / GetCoordinatesForGlyphPosition
2017-09-22 15:15:59 -07:00
Jason Simmons
76dd4e1138 Roll Skia (#4131) 2017-09-22 14:38:46 -07:00
P.Y. Laligand
d7da1255c9 Moved Maxwell to //peridot. (#4137) 2017-09-22 14:17:41 -07:00
Jason Simmons
e31d0f4ea1 Update the license script to include the topaz root and exclude Skia's version of libpng (#4136) 2017-09-22 14:03:14 -07:00
P.Y. Laligand
fc3cb8fb3b Adjust to new location of lib/tonic. (#4132) 2017-09-21 14:30:28 -07:00
Alexander Aprelev
0a6e415b60 Revert "account for pixel scale when checking against existing buffer storage size (#4103)" (#4133)
This reverts commit 2d530daeca438ca24562d290616c0aec5ab76b88 as it looks
like a potential cause of performance benchmark regressions on
https://flutter-dashboard.appspot.com/benchmarks.html:
 - flutter_gallery_ios__transition_perf average_frame_build_time_millis
 - flutter_gallery_ios__transition_perf missed_frame_build_budget_count
2017-09-21 12:45:16 -07:00
Travis Martin
9d98d886ad Report onscreen text to Fuchsia context engine. (#4097)
Add a class to track onscreen text via SemanticsNodes from the
accessibility layer, and report this text to the ContextEngine.
2017-09-21 12:41:13 -07:00
Michael Goderbauer
4aee64f6be Revert "Roll skia to 76d640d14ea78e1f827a2f545e7f0729cdc2896f" (#4130)
* Revert "Roll Dart to 3d21a46b726c24ded2d3cb3cce4f43aeed875dbc. (#4127)"

This reverts commit 321e639b6a27f381241df2e665c4304c659ccda8.

* Revert "Roll skia to 76d640d14ea78e1f827a2f545e7f0729cdc2896f (#4129)"

This reverts commit 6aaba3d2917647dfbd5569dc9e506a1c59e65ee2.
2017-09-20 16:59:14 -07:00
Ryan Macnak
321e639b6a Roll Dart to 3d21a46b726c24ded2d3cb3cce4f43aeed875dbc. (#4127) 2017-09-20 16:44:15 -07:00
Michael Goderbauer
6aaba3d291 Roll skia to 76d640d14ea78e1f827a2f545e7f0729cdc2896f (#4129) 2017-09-20 16:34:29 -07:00
Michael Goderbauer
dd68239b43 Don't crash on iOS if there is only a single SemanticsNode (#4128)
* Don't crash if there is only a single SemanticsNode

Previously, the code assumed that the root SemanticsNode will allways have a child. This is not true as can be seen in the hello_world example app, which would crash when a11y is turned on.

* review comment
2017-09-20 14:17:50 -07:00
Adam Barth
2f50beabcb Update paths for magma move (#4126) 2017-09-20 10:26:31 -07:00
Michael Goderbauer
c5602ab197 Three finger a11y scrolling for iOS (#4123)
* Three finger a11y scrolling for iOS

* review comments

* review feedback
2017-09-20 09:59:14 -07:00
Abhishek Amit
bd64e8dc5a Add flags to allow cross compiling to linux arm (#4120) 2017-09-19 14:09:35 -07:00
Abhishek Amit
004d0bdf67 Add API to send platform messages into engine through embedder API (#4112) 2017-09-19 13:57:44 -07:00
Abhishek Amit
aa2437b9f5 Add support for running bundles to embedder API (#4099) 2017-09-19 13:12:51 -07:00
Ian McKellar
dd1e0b59ec Support cleaner Dart isolate shutdown handling. (#4121)
If an isolate shuts down (for example if an app calls
Isolate.current.kill()), the UIDartState* on DartController will refer
to a freed object. This wires through notification that the is shutting
down through to the DartController so it can clean up appropriately.

This also makes gives the vm-service isolate an UIDartState* so that
the shutdown callback can behave correctly.
2017-09-19 12:11:05 -07:00
Michael Goderbauer
773dfb549a Silence Wawrning (#4122)
Follow-up to https://github.com/flutter/engine/pull/4110
2017-09-19 10:15:39 -07:00
Jason Simmons
e58c2dc335 Support ligatures in libtxt (#4119) 2017-09-19 10:07:17 -07:00
Michael Goderbauer
af74ea6177 Allow nested semantics on iOS (#4110)
* Allow nested semantics on iOS

* review comments

* review comments
2017-09-18 17:27:14 -07:00
Jason Simmons
191a2fab39 Set a higher filter quality for drawing raster cache images (#4116)
According to Skia, kLow offers a quality improvement with little cost over
the default kNone

Fixes https://github.com/flutter/flutter/issues/12091
2017-09-18 12:28:52 -07:00
Alexander Aprelev
0f79a0cc1a Capture all aspects of messages from compiler (#4118)
* Capture all aspects of messages from compiler

* Make static
2017-09-15 16:04:58 -07:00
Ian Hickson
82fb559566 Add operators to Radius (#4117)
This will make it easier to implement BorderRadius RTL in a manner consistent with EdgeInsets.
2017-09-15 14:52:38 -07:00
Ryan Macnak
6abb2651f5 DEPS: Change the URL for Dart to the new Gerrit instance. (#4111)
Makes it easy to upload a Dart change from a Flutter client.
2017-09-15 10:47:31 -07:00
Carlo Bernaschina
2820d0e722 Fix engine on iOS (#4113)
Related https://github.com/flutter/engine/pull/4105
2017-09-15 09:59:53 -07:00
George Kulakowski
550d0c6490 Rename Magenta to Zircon, along with associated abbreviations (#4114) 2017-09-14 22:49:46 -07:00
Carlo Bernaschina
0c1e217287 Add anchor events for developer centric timeline (#4105)
By adding these events the new developer centric timeline will be able
to identify and correlate events related to the different stages of the
drawing pipeline.

Roll Dart to 62045a4590a333ae557f8f261a909ee75449cd70
2017-09-14 20:18:07 -07:00
Alexander Aprelev
0e8ffa24e0 Reverting to unblock engine roll (#4109)
* Revert "Make Travis happy again (#4101)"

This reverts commit c99b2559df05f4b5f547d26bb0a61d88809f5564.

* Revert "Support cleaner Dart isolate shutdown handling. (#4096)"

This reverts commit 05751f7be993316057d772e8334a783537e10e26.
2017-09-14 12:10:11 -07:00
Ryan Macnak
b5f5377186 Remove use of CADisplayLink targetTimestamp, which was only added in iOS 10.0. (#4108) 2017-09-14 10:48:28 -07:00
Alexander Aprelev
e9014c2335 Roll garnet dependency to pick up a win bot fix (#4107)
* Roll garnet dependency to pick up a win bot fix

* Update license
2017-09-14 09:51:40 -07:00
Alexander Aprelev
3ea0eef6f8 Follow up PR that updates lib licenses hash (#4106) 2017-09-14 08:50:37 -07:00
Alexander Aprelev
1b367b06f1 Provide callback to free fetched bytes when reading kernel binary. (#4095) 2017-09-14 08:01:25 -07:00
Michael Goderbauer
3df8c88f89 More clarification about license script (#4104) 2017-09-13 15:41:03 -07:00
xster
2d530daeca account for pixel scale when checking against existing buffer storage size (#4103) 2017-09-13 14:05:45 -07:00
Michael Goderbauer
f808426ef4 Clarify licenses/README.md (#4102) 2017-09-13 14:04:34 -07:00
Michael Goderbauer
c99b2559df Make Travis happy again (#4101) 2017-09-13 12:42:37 -07:00
Ian McKellar
05751f7be9 Support cleaner Dart isolate shutdown handling. (#4096)
If an isolate shuts down (for example if an app calls
Isolate.current.kill()), the UIDartState* on DartController will refer
to a freed object. This wires through notification that the is shutting
down through to the DartController so it can clean up appropriately.
2017-09-13 10:29:21 -07:00
Carlo Bernaschina
57a1445a45 Add --trace-skia parameter to flutter run (#4100)
Skia tracing is extremely useful for internal debug, but reduces the
amount of space available in the Dart Timeline buffers.
Disable skia tracing by default and expose them via the --trace-skia
flag.
2017-09-13 10:18:45 -07:00
Michael Goderbauer
ff0a9a8d96 Enforce clang-format for c-like sources on Travis (#4089)
* Enforce clang-format for c-like sources on Travis

* Edit CONTRIBUTING,md

* review feedback:

* ++

* ++

* ++
2017-09-12 15:42:37 -07:00
Michael Goderbauer
08961f8ec5 Format all c-like sources with clang-format (#4088)
* format

* license script adaptions

* updated licenses

* review comments
2017-09-12 15:36:20 -07:00
Jason Simmons
7fd7ecdcc3 Update licenses for Garnet/FXL renaming (#4093) 2017-09-12 09:51:33 -07:00
George Kulakowski
31d03de019 Rename mtl to fsl (#4094) 2017-09-11 17:56:02 -07:00
Michael Goderbauer
952798cc1b More renaming of FTL->FXL (#4092) 2017-09-11 17:29:48 -07:00
George Kulakowski
6502090278 Fix remaining ftl->fxl conversions (#4091)
* Fix remaining ftl->fxl conversions

The previous scripting pass at this did not account for objective c file endings

* Update tonic DEPS reference to the post-fxl version
2017-09-11 16:31:18 -07:00
George Kulakowski
3aa7522c11 Rename ftl to fxl in Fuchsia specific code (#4090) 2017-09-11 15:58:48 -07:00
George Kulakowski
3b2b2f96a1 Update DEPS to reflect garnet changes (#4087) 2017-09-11 15:45:04 -07:00
Jason Simmons
19590d2e42 Enable the Skia subpixel text flag in libtxt (#4086)
This flag was set in the Blink renderer (see FontPlatformData::setupPaint)
2017-09-11 15:06:47 -07:00
Michael Goderbauer
afcc1d1e1f a11y improvements for iOS (#4079)
* Various iOS a11y fixes

* undo

* review comments

* review comments
2017-09-11 14:44:17 -07:00
Adam Barth
2a13951fa9 Update paths for //application move (#4085) 2017-09-11 14:40:03 -07:00
Jason Simmons
a44146f13b Log instead of asserting when sending a reply message to a defunct engine (#4084)
Fixes https://github.com/flutter/flutter/issues/12037
2017-09-11 14:05:14 -07:00