11734 Commits

Author SHA1 Message Date
Alexander Aprelev
a7d954eb31
Add TODOs to remove lint ignore directives. (#21170)
This is follow-up to https://github.com/flutter/flutter/pull/21143.
2018-08-29 10:25:19 -07:00
Alexander Aprelev
1e5cb2d87f
Remove workaround for compiler dill-initialization. (#20541)
Workaround is not needed since real fix has landed in dart sdk: https://dart-review.googlesource.com/c/sdk/+/62729.
2018-08-29 08:56:19 -07:00
engine-flutter-autoroll
8c8ee83b33
Roll engine eceb722b7111..a02a94e0182c (1 commits) (#21163)
eceb722b71...a02a94e018

git log eceb722b7111..a02a94e0182c --no-merges --oneline
a02a94e01 Roll src/third_party/skia 33f34556b5fc..a81c2be75adc (1 commits) (flutter/engine#6109)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-08-29 11:05:32 -04:00
engine-flutter-autoroll
11d49a2db4
Roll engine f3ff83a5db71..eceb722b7111 (2 commits) (#21161)
f3ff83a5db...eceb722b71

git log f3ff83a5db71..eceb722b7111 --no-merges --oneline
eceb722b7 Roll Dart to dart-lang/sdk@760a9690c2 (flutter/engine#6108)
be9d8ffbb Roll src/third_party/skia 5f0726b01019..33f34556b5fc (1 commits) (flutter/engine#6107)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-08-29 10:00:34 -04:00
Danny Tuppeny
a9275d2154
Swap order of attach/stop in flutter_attach integration test (#21106)
This is a bit of a stab in the dark for a flake sometimes seen on bots (but I can't repro locally) #20822. Detaching from a Flutter app currently seems to terminate it, so it may be the cause of the "app not found" when trying to stop the app subsequently.

This change means we stop the app from the main process first, before terminating the attach process.
2018-08-29 07:58:11 +01:00
Alexander Aprelev
cf764e3012
Use differrent name for initial flutter tester kernel file. (#21137)
Bug: https://github.com/flutter/flutter/issues/17833
2018-08-28 22:16:38 -07:00
Alexander Aprelev
abc17236f7
Roll engine to f3ff83a5db71262d240aa5337a2a9a22c73c4749. (dart roll). (#21143)
* Roll engine to 56139397e6ae1257bdabd1ef79ff7aca96c67d4.6

Changes since last roll:
```
56139397e Roll src/third_party/skia 7ba1d64f0706..5f0726b01019 (12 commits) (#6104)
47a1ce0e6 Allow embedders to set the root surface transformation. (#6085)
```

* Roll engine to f3ff83a5db71262d240aa5337a2a9a22c73c4749. (dart roll).

* Add const

* Add ignore analyzer prefer_const_constructors_in_immutables
2018-08-28 21:30:36 -07:00
Jonah Williams
bf5e4b45fe
Make sure modal BottomSheets routes are identified as dialog routes (#21075) 2018-08-28 19:21:00 -07:00
xster
373243bcf8
make /timeline-dashboard consistent between build and paint profiles (#21099) 2018-08-28 16:48:58 -07:00
xster
f23c9ae5f8
Cupertino nav bar transitions between routes (#20322) 2018-08-28 16:44:34 -07:00
Jacob Richman
05b4bd748c Update CONTRIBUTING.md to suggest Android Studio and fix Mac command to install android-platform-tools. (#19537) 2018-08-28 16:22:50 -07:00
Janice Collins
e7d87af4d2
Update dartdoc to 0.20.4. (#21131) 2018-08-28 14:58:52 -07:00
engine-flutter-autoroll
af8986e969
Roll engine af42b6dc95bd..56bad48ab2ed (9 commits) (#21132)
af42b6dc95...56bad48ab2

git log af42b6dc95bd..56bad48ab2ed --no-merges --oneline
56bad48ab expose bold text flag in accessibility features for iOS (flutter/engine#6072)
ad4e87d07 Convert synthesized Android motion events to long and not to int. (flutter/engine#6103)
f05b08b7b Roll src/third_party/skia f125111ca733..7ba1d64f0706 (18 commits) (flutter/engine#6102)
eb9738610 Roll src/third_party/skia 0fdc53f9ffc6..f125111ca733 (10 commits) (flutter/engine#6100)
06b8fa4ed Roll src/third_party/skia dd04bec39cea..0fdc53f9ffc6 (13 commits) (flutter/engine#6098)
bf078042d Roll ICU to c56c671998902fcc4fc9ace88c83daa99f980793 (flutter/engine#6097)
c867305c3 Unconditionally set resource id to empty string (flutter/engine#6096)
b4b1d0578 Roll src/third_party/skia e00fe30b8fe7..dd04bec39cea (4 commits) (flutter/engine#6095)
8694036a6 Roll src/third_party/skia 420696961c8c..e00fe30b8fe7 (1 commits) (flutter/engine#6094)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-08-28 17:40:32 -04:00
Ian Hickson
10aa41f00f
Fix coverage collection crash (#21015)
* Fix coverage collection crash

Based on Jason's patch in https://github.com/flutter/flutter/pull/19546/

This is more or less the same but I tried to avoid using `dynamic`.

* Improve argument and variable names in flutter_platform

* Don't bother with reduce, since the order is guaranteed.
2018-08-28 14:36:06 -07:00
David Shuckerow
77095356e9
Attach command: add Bazel filesystem support (#21082) 2018-08-28 14:50:03 -06:00
Janice Collins
5e39476aef
Remove workaround for markup stripping dartdoc bug (#20748)
* Remove workaround for dart-lang/dartdoc#1125

* Update update_icons.dart for optional const and to remove markup stripping workaround
2018-08-28 13:23:07 -07:00
Jonah Williams
3b309bda07
Add a localization for counter text, separate into own semantic node (#21029) v0.7.3 2018-08-28 12:39:24 -07:00
Ian Hickson
1c2d3f324d
Shut down gradle at the end of each task (#20968)
Apparently Gradle leaks memory and it's causing failures.
2018-08-28 11:28:25 -07:00
Ian Hickson
53b635817c
Re-enable missing_return (#20844) 2018-08-28 11:22:57 -07:00
David Shuckerow
458d0b3d21
Update the reorderable list to use the primary scroll controller when… (#20895) 2018-08-28 12:08:41 -06:00
Danny Tuppeny
8b0227b4a3
Don't time out if process terminates when told to stop (#21103)
* Don't time out if process terminates when told to stop but response was not processed

While trying to reproduce #20822 I found a condition where the app may quit before the `app.stop` response is received but this code (which is called in integration test teardown) would sit around waiting and time out. With this change, the process exit is considered a valid response to the stop request.

* Add process exit to log for better errors in failures

This log can be turned on for debugging but is also dumped when a test fails (in certain conditions). With this in the log, it'll be clear if the timeout is because we're waiting for an event but the process quit.
2018-08-28 18:26:46 +01:00
Danny Tuppeny
5eebfeb345
Let bot/devicelab tests run concurrently (#21116) 2018-08-28 18:15:00 +01:00
Michael Goderbauer
91dde9074a
No more nasty errors during flutter upgrade/channel on Windows (#21085)
Fixes https://github.com/flutter/flutter/issues/14578.
2018-08-28 09:37:34 -07:00
Greg Spencer
7a07b28c93
Fix typo in AnimatedWidget (#21091) 2018-08-28 09:12:16 -07:00
Amir Hardon
c5b7766cbb
Re-land "Make AndroidView participate in gesture arenas." (#21097)
This re-lands commit c594696.

The original PR was breaking the integration test as while the
gesture was active the AndroidView's parent widget got rebuilt which
disposed the _AndroidViewGestureRecognizer and dropped pointer events
from that point on.

This change adds a unit test that reproduces the failure case, and
fixes it by not rebuilding the _AndroidViewGestureRecognizer if the
list of gesture recognizers did not change.
2018-08-28 08:52:46 -07:00
Greg Spencer
2b14ac1efc
Fix setting of ANDROID_HOME in deploy_gallery.sh (#21080)
ANDROID_HOME should be coming from the env, and it wasn't: it was being set in the script.
2018-08-27 22:17:22 -07:00
Michael Goderbauer
f88d2d9c12
Revert 20917 platform view arena (#21086)
This reverts commit c594696f0626e32dcd83d2a7d8c479460d475374.
2018-08-27 17:36:40 -07:00
xster
3313f5185f
Put Cupertino gallery demos in alphabetical order (#21081) 2018-08-27 15:10:05 -07:00
amirh
c594696f06
Make AndroidView participate in gesture arenas. (#20917)
Pointer events are dispatched to the Android view only if it won
Flutter's gesture arena for the pointer.
Specific gestures that should be dispatched to the android view can be
specified with the gestureRecognizers parameter.
2018-08-27 15:07:19 -07:00
Viet Do
0b93911653
Add Cupertino Countdown Timer Picker (#20966)
Add a countdown timer picker as part of the Cupertino date picker.
2018-08-27 12:37:55 -07:00
Sebastian Podjasek
f8a2fc7c28 Implement resizeToAvoidBottomPadding in CupertinoPageScaffold (#20929) v0.7.2 2018-08-27 11:58:30 -07:00
liyuqian
38d155a421
Add default-no-clip tests to more buttons (#21012)
Note that such tests already exist for RaisedButton and MaterialButton
2018-08-27 11:25:47 -07:00
amirh
688d96b652
Add a creation parameters argument to AndroidView. (#21067)
This allows to pass construction parameters for the embedded Android
view from the Dart side.
2018-08-27 11:24:54 -07:00
Michael Thomsen
7f0f938de7
A few README fixes (#20985)
* Few readme fixes

* Fix link

* Make casing consistent
2018-08-27 11:11:14 +02:00
Danny Tuppeny
4466c9db4c
Re-enable integration tests (#20947)
* Unskip expression evaluation integration tests for non-Windows

* Add additional into to skip comments

* Add missing import
2018-08-27 09:29:07 +01:00
engine-flutter-autoroll
546449238a
Roll engine a52724fcf859..af42b6dc95bd (7 commits) (#21044)
Auto-roller completed checks. Merging.
2018-08-26 19:50:02 -04:00
engine-flutter-autoroll
b661886259
Roll engine 091492601479..a52724fcf859 (2 commits) (#21013)
Auto-roller completed checks. Merging.
2018-08-26 19:06:00 -04:00
amirh
510c0eeaff
Don't ignore the ByteData buffer offset in StringCodec.decode(). (#21011) 2018-08-24 17:19:30 -07:00
Greg Spencer
977da4fb20
Ignore pub-cache when analyzing (#20925)
This adds ".pub-cache" to the list of directories to ignore when checking for dependence upon dart:test, since when people install a downloadable package, their pub cache is in the flutter directory.

Also, I centralized the ANSI "red line" so that they would all use the same final string.
2018-08-24 14:06:25 -07:00
liyuqian
5d6707b78e
Expose clipBehavior to more buttons (#20538)
This allows developers to control the clipBehavior of those buttons.
2018-08-24 13:53:54 -07:00
amirh
fd44d0bb65
Update the android_views integration test to the new Android views API. (#20999)
This updates the test to match the engine API change introduced in:
https://github.com/flutter/engine/pull/6081

This also rolls the engine, the roll includes only the relevant engine commit:
```
091492601 Allow passing extra creation parameters for embedded Android views. (#6081)
```
2018-08-24 12:43:56 -07:00
Mehmet Fidanboylu
ac8d442a6f
Fix Dart check failure. (#20995) 2018-08-24 10:15:05 -07:00
engine-flutter-autoroll
20e019ef8d
Roll engine 0b728a314001..78e74d4d1816 (7 commits) (#20997)
Auto-roller completed checks. Merging.
2018-08-24 13:08:20 -04:00
Shams Zakhour
3c624f8b2c
Update README.md
Updating a few things on the README page. It needs more work.
v0.7.1
2018-08-23 19:23:02 -07:00
amirh
146b906bbb
Mark the embedded_android_views_test as non flaky. (#20962)
Was marked as flaky as that's our policy for assing new device lab
tests. It's been consistently green so marking as non flaky.
2018-08-23 19:01:28 -07:00
xster
c418b2f328
Auto populate nav bar title and previous from page route (#19637) 2018-08-23 18:24:30 -07:00
liyuqian
ce8ba6e8b3
Set the default clip to Clip.none again. (#20752)
This reverts commit 8de0e15e4fdd3a1be8878394a7f8c8bda948e59b and
updates the goldens versoin.

This requires https://github.com/flutter/flutter/pull/20751 to
land first.
2018-08-23 18:05:11 -07:00
jslavitz
3900d42bfa
Control, Shift and Arrow Key functionality for Chromebook (#20204)
* added keyboard functionatliy to android builds

* Added tests

* almost ready for review

* ready for review

* Fixes

* final comments

* final commit

* removing raw keyboard changes

* removing raw keyboard changes

* removing raw keyboard changes

* actual last commit

* fixed the imports

* a few more changes

* A few more changes

* a few changes

* Final changes

* Final changes2

* final actual commit for real

* final actual commit for real2

* final actual commit for real3

* final actual commit for real4

* final

* final 2

* f

* f2

* fin

* fin 2

* fin3

* fin4
2018-08-23 17:16:44 -07:00
Danny Tuppeny
dc5a5c18a9
Start logger in startProgress to avoid assertion failure (#20814)
* Start logger in startProgress to avoid assertion failure

There are lots of places that create a Status() and all but two of them call ..start() immediately. This is one of the places that doesn't, which causes an assertion failure when running with --enable-asserts and the other is in the same file (I suspect it's also incorrect, but possibly it's never used - I'll look at that separately when I can trace some code that calls it).

Fixes #20812.

* Enable asserts for tools tests

* Fix lint

* Rename enableAsserts -> enableFlutterToolAsserts

To make it clearer that it only enables asserts for flutter_tools when set.
2018-08-23 20:49:59 +01:00
amirh
1ba16d55f3
Don't size Android views to (0,0) (#20956)
Virtual displays must have a non zero size. This was causing a crash:
https://github.com/flutter/flutter/issues/20456
2018-08-23 12:29:29 -07:00