21827 Commits

Author SHA1 Message Date
htoor3
a5fdffa8c8 [web] - Move text editing nodes outside of shadowDOM, reland (flutter/engine#40968)
[web] - Move text editing nodes outside of shadowDOM, reland
2023-04-11 19:41:14 +00:00
yaakovschectman
8179d070b3 [Windows] Ignore case optionally in AXPlatformNodeTextRangeProviderWin::FindText (flutter/engine#39922)
When `ignore_case` is `true`, convert needle and haystack strings to
lowercase before performing search,

https://github.com/flutter/flutter/issues/117013

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-04-11 14:54:56 -04:00
skia-flutter-autoroll
a82c7ce989 Roll Skia from 94ed2b7c0aa3 to 53b61e040046 (1 revision) (flutter/engine#41084)
Roll Skia from 94ed2b7c0aa3 to 53b61e040046 (1 revision)
2023-04-11 18:51:16 +00:00
Chris Yang
d753239cc0 [mac] Build mac framework with app extension flag (flutter/engine#41011)
[mac] Build mac framework with app extension flag
2023-04-11 18:32:29 +00:00
Jackson Gardner
f8cb7c00c7 Revert "Migrate ios_builders to engine_v2." (flutter/engine#41083)
Reverts flutter/engine#40844

We suspect this may be the cause of
https://github.com/flutter/flutter/issues/124572
2023-04-11 11:26:15 -07:00
godofredoc
9a943da9c1 Promote mac_unopt to prod. (flutter/engine#41078)
Promote mac_unopt to prod.
2023-04-11 17:29:06 +00:00
Brandon DeRosier
29585b2482 [Impeller] Move TextRenderContext::Create symbol into the text backend (flutter/engine#41067)
Moves the `TextRenderContext::Create` symbol into the backend, so that
we can easily swap out the backend when building the 2D renderer in
impeller-cmake.
2023-04-11 10:09:28 -07:00
Chinmay Garde
d56e587985 [Impeller] Remove GPUTracer. (flutter/engine#41079)
[Impeller] Remove GPUTracer.
2023-04-11 17:07:16 +00:00
godofredoc
753f2a77b1 Promote linux_desktop build to prod. (flutter/engine#41076)
Promote linux_desktop build to prod.
2023-04-11 17:01:54 +00:00
Jonah Williams
c3a94facab [Impeller] convert most filters to utilize entities instead of subpasses (flutter/engine#40973)
[Impeller] convert most filters to utilize entities instead of subpasses
2023-04-11 16:49:07 +00:00
Jonah Williams
e14c6ed93d [Impeller] remove unref queue usage on Impeller. (flutter/engine#41050)
[Impeller] remove unref queue usage on Impeller.
2023-04-11 16:49:04 +00:00
Jason Simmons
c9147eae32 [Impeller] Obtain the subpass texture after calling OnRender (flutter/engine#41052)
[Impeller] Obtain the subpass texture after calling OnRender
2023-04-11 14:41:08 +00:00
skia-flutter-autoroll
c8a92db52f Roll Fuchsia Linux SDK from P15HfBhD19GOwL0lz... to Ondwn68bALJT8Y_Kp... (flutter/engine#41069)
Roll Fuchsia Linux SDK from P15HfBhD19GOwL0lz... to Ondwn68bALJT8Y_Kp...
2023-04-11 08:54:29 +00:00
skia-flutter-autoroll
a168084487 Roll Skia from 8cfe86a8c5da to d662473a1e8e (1 revision) (flutter/engine#41066)
Roll Skia from 8cfe86a8c5da to d662473a1e8e (1 revision)
2023-04-11 07:04:14 +00:00
Chris Yang
94fa5f4edf [ios] fix background crash when FlutterViewController is destroyed after engine destroyed context (flutter/engine#41037)
[ios] fix background crash when FlutterViewController is destroyed after engine destroyed context
2023-04-11 03:45:27 +00:00
Brandon DeRosier
b3e7898f48 Revert "[Impeller] Load instead of restore drawing for non-MSAA passes" (flutter/engine#41060)
Revert "[Impeller] Load instead of restore drawing for non-MSAA passes"
2023-04-11 03:25:09 +00:00
skia-flutter-autoroll
462e87bb8e Roll Skia from 7eebce479ff8 to 8cfe86a8c5da (3 revisions) (flutter/engine#41061)
Roll Skia from 7eebce479ff8 to 8cfe86a8c5da (3 revisions)
2023-04-11 02:38:17 +00:00
godofredoc
2dcb069273 Update the timeout to 3h for mac build in staging. (flutter/engine#41048)
Update the timeout to 3h for mac build in staging.
2023-04-11 01:36:08 +00:00
godofredoc
75eff09609 Migrate ios_builders to engine_v2. (flutter/engine#40844)
Migrate ios_builders to engine_v2.
2023-04-11 00:05:58 +00:00
skia-flutter-autoroll
922e2f7d18 Roll Skia from d0e0b423e3c0 to 7eebce479ff8 (12 revisions) (flutter/engine#41053)
Roll Skia from d0e0b423e3c0 to 7eebce479ff8 (12 revisions)
2023-04-10 23:50:04 +00:00
Jonah Williams
c1e31d865b [Impeller] Reland of Simplify Advanced Blend color filters with a foreground color. (flutter/engine#40927)
[Impeller] Reland of Simplify Advanced Blend color filters with a foreground color.
2023-04-10 22:50:10 +00:00
Bernardo Ferrari
aa47305b4d SemanticsFlag/SemanticsAction cleanup (part 3) (flutter/engine#40567)
`SemanticsFlag`/`SemanticsAction` cleanup (part 3)
2023-04-10 22:32:03 +00:00
Jason Simmons
1458a66d66 [Impeller] Some fixes to shader pipeline validation (flutter/engine#40925)
[Impeller] Some fixes to shader pipeline validation
2023-04-10 20:50:17 +00:00
luckysmg
727da6c7bc Reland [iOS] Send connectionClosed message when resignFirstResponder to ensure framework focus state is correct. (flutter/engine#41022)
Correct focus behavior when the keyboard is closed.
2023-04-10 13:49:49 -07:00
Jonah Williams
a3f04c55c1 [Impeller] playground upload to device private on macOS (flutter/engine#41001)
[Impeller] playground upload to device private on macOS
2023-04-10 20:15:55 +00:00
Jackson Gardner
34cfb4d663 Re-enable some wasm tests which have been fixed now. (flutter/engine#40931)
Re-enable some wasm tests which have been fixed now.
2023-04-10 20:15:52 +00:00
Jonah Williams
763ede53cc [Impeller] add goldens for filter optimizations. (flutter/engine#41033)
[Impeller] add goldens for filter optimizations.
2023-04-10 20:11:45 +00:00
Jason Simmons
5fdd31653e Update some more uses of the deprecated Skia SkImage::MakeFromBitmap API (flutter/engine#41041) 2023-04-10 12:27:56 -07:00
Chris Yang
5da580cfb2 [embedder] embedder external view adopt DisplayListEmbedderViewSlice (flutter/engine#40578)
[embedder] embedder external view adopt DisplayListEmbedderViewSlice
2023-04-10 18:54:39 +00:00
skia-flutter-autoroll
0a31bb8e4d Roll Skia from 7635aa1d11c2 to d0e0b423e3c0 (4 revisions) (flutter/engine#41034)
Roll Skia from 7635aa1d11c2 to d0e0b423e3c0 (4 revisions)
2023-04-10 18:00:10 +00:00
Dan Field
ce45be217d [Impeller] Fix issues in path polyline generation. (flutter/engine#40975)
[Impeller] Fix issues in path polyline generation.
2023-04-10 17:44:02 +00:00
Jackson Gardner
439141c38d Skwasm scene (flutter/engine#40330)
Skwasm scene
2023-04-10 17:38:57 +00:00
Dan Field
e92e4daa76 Move Skia conversion utilities to own TU (flutter/engine#40997)
Move Skia conversion utilities to own TU
2023-04-10 16:46:04 +00:00
luckysmg
418c28e09a Add trace event when updating ViewportMetrics (flutter/engine#41024)
Add trace event when updating ViewportMetrics
2023-04-10 16:17:08 +00:00
skia-flutter-autoroll
6194bf9b8b Roll Fuchsia Linux SDK from 5psyBv8pQX3rf4LaU... to P15HfBhD19GOwL0lz... (flutter/engine#41028)
Roll Fuchsia Linux SDK from 5psyBv8pQX3rf4LaU... to P15HfBhD19GOwL0lz...
2023-04-10 14:24:33 +00:00
skia-flutter-autoroll
dda1ee658b Roll Skia from 20d8ddab2b13 to 7635aa1d11c2 (4 revisions) (flutter/engine#41026)
Roll Skia from 20d8ddab2b13 to 7635aa1d11c2 (4 revisions)
2023-04-10 10:09:37 +00:00
dependabot[bot]
5a91db530b Bump github/codeql-action from 2.2.9 to 2.2.11 (flutter/engine#41025)
Bump github/codeql-action from 2.2.9 to 2.2.11
2023-04-10 09:39:17 +00:00
skia-flutter-autoroll
cbc6a9f6ef Roll Fuchsia Linux SDK from 0ItFGt3CsrDlgrM3S... to 4qFZIXvizluvZnqDX... (flutter/engine#41010)
Roll Fuchsia Linux SDK from 0ItFGt3CsrDlgrM3S... to 4qFZIXvizluvZnqDX...
2023-04-08 18:03:23 +00:00
Chris Bracken
5fe41d4d1d [a11y] Improve EmbedderA11yTest, fixture comments (flutter/engine#40995)
Add breadcrumbs to make it easier to jump between the Dart fixture side
and the embedder side of the EmbedderA11yTest unit test.
2023-04-08 10:25:07 -07:00
skia-flutter-autoroll
56cf7e4caa Roll Fuchsia Linux SDK from P6Fk6LO_vzmUU08Ab... to 0ItFGt3CsrDlgrM3S... (flutter/engine#41004)
Roll Fuchsia Linux SDK from P6Fk6LO_vzmUU08Ab... to 0ItFGt3CsrDlgrM3S...
2023-04-08 04:20:09 +00:00
skia-flutter-autoroll
11814c78d6 Roll Skia from 557d71a445ac to f4803c264c54 (43 revisions) (flutter/engine#41002)
Roll Skia from 557d71a445ac to f4803c264c54 (43 revisions)
2023-04-08 00:57:22 +00:00
yaakovschectman
af61f5dda0 Fix flaky Windows exit unit test, remove error messages (flutter/engine#40945)
Shutdown is async, so we can not guarantee the order of execution and,
by extension, ignorance of execution used as an auxiliary part of a unit
test. Also, mock the windows view/binding handler for the engine in
order to avoid error messages.

Addresses https://github.com/flutter/flutter/issues/124162

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-04-07 17:11:15 -04:00
Chris Bracken
3ea75b15f1 [a11y] Use DartConverter for embedder a11y tests (flutter/engine#40993)
No semantic change. This just simplifies converting Dart arguments to
C++ types, making it more consistent with the rest of the codebase.

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I signed the [CLA].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-04-07 13:11:42 -07:00
Corey Tabaka
dac17395ad [Fuchsia] Implement thread priorities. (flutter/engine#40970)
[Fuchsia] Implement thread priorities.
2023-04-07 19:25:20 +00:00
Mouad Debbar
5d30f3f043 [web] Make 'Noto Color Emoji' opt-in (flutter/engine#40990)
[web] Make 'Noto Color Emoji' opt-in
2023-04-07 16:54:22 +00:00
Kevin Lubick
a08288c38b Remove (unused) SkImageEncoder.h includes (flutter/engine#40989)
I'm refactoring Skia's image codecs and noticed that although Flutter
includes this header, it doesn't seem to use any of the symbols from it:
`SkEncodeImage` and `SkEncodePixmap`.

This PR removes those includes and also adds some missing includes which
will aid future Skia cleanup CLs.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-04-07 08:27:24 -07:00
skia-flutter-autoroll
f72ad3fb1c Roll Fuchsia Linux SDK from nS_R3f779FLIEjE8I... to P6Fk6LO_vzmUU08Ab... (flutter/engine#40987)
Roll Fuchsia Linux SDK from nS_R3f779FLIEjE8I... to P6Fk6LO_vzmUU08Ab...
2023-04-07 14:29:34 +00:00
Jenn Magder
225d7017f2 Fix UIWindowSceneGeometryPreferencesIOS leak (flutter/engine#40957) 2023-04-06 18:31:33 -07:00
skia-flutter-autoroll
a21c24bbc6 Roll Fuchsia Linux SDK from rQKj0gZPJNATiErM8... to nS_R3f779FLIEjE8I... (flutter/engine#40985)
Roll Fuchsia Linux SDK from rQKj0gZPJNATiErM8... to nS_R3f779FLIEjE8I...
2023-04-07 00:47:19 +00:00
Chris Bracken
3bf49d72e4 Support disabling backtrace support (flutter/engine#40980)
This adds a gn flag (--backtrace, --no-backtrace) that defaults to
enabling backtraces, which drives a gn variable `enable_backtrace` which
is defaulted true for debug builds.

Backtrace collection is supported on Windows, and on POSIX-like
operating systems via execinfo.h. execinfo support exists in Android,
macOS/iOS, and in glibc and uclibc on Linux. musl libc notably does not
include execinfo support, so this provides an escape hatch to build with
backtrace_stub.cc for situations in which compile time support doesn't
exist.

Proposed as an alternative to
https://github.com/flutter/engine/pull/40958 by @selfisekai.

Issue: https://github.com/flutter/flutter/issues/124285
2023-04-06 17:21:34 -07:00