DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Support disabling backtrace support (flutter/engine#40980)

Browse Source 
This adds a gn flag (--backtrace, --no-backtrace) that defaults to
enabling backtraces, which drives a gn variable `enable_backtrace` which
is defaulted true for debug builds.

Backtrace collection is supported on Windows, and on POSIX-like
operating systems via execinfo.h. execinfo support exists in Android,
macOS/iOS, and in glibc and uclibc on Linux. musl libc notably does not
include execinfo support, so this provides an escape hatch to build with
backtrace_stub.cc for situations in which compile time support doesn't
exist.

Proposed as an alternative to
https://github.com/flutter/engine/pull/40958 by @selfisekai.

Issue: https://github.com/flutter/flutter/issues/124285
This commit is contained in:
Chris Bracken 2023-04-06 17:21:34 -07:00 committed by GitHub
parent 8b8fc13b93
commit 3bf49d72e4
3 changed files with 25 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
engine/src/flutter/common/config.gni
View File

@ -19,6 +19,9 @@ declare_args() {
# Whether to build host-side development artifacts.
flutter_build_engine_artifacts = true
# Whether to include backtrace support.
enable_backtrace = true
}
# feature_defines_list ---------------------------------------------------------

4
engine/src/flutter/fml/BUILD.gn
View File

@ -97,7 +97,7 @@ source_set("fml") {
"wakeable.h",
]
if (is_mac || is_linux || is_win || (is_ios && is_debug)) {
if (enable_backtrace) {
sources += [ "backtrace.cc" ]
} else {
sources += [ "backtrace_stub.cc" ]
@ -116,7 +116,7 @@ source_set("fml") {
"//third_party/icu",
]
if (is_mac || is_linux || is_win || (is_ios && is_debug)) {
if (enable_backtrace) {
# This abseil dependency is only used by backtrace.cc.
deps += [ "//third_party/abseil-cpp/absl/debugging:symbolize" ]
}

20
engine/src/flutter/tools/gn
View File

@ -393,6 +393,15 @@ def to_gn_args(args):
# flags allow preventing those targets from being part of the build tree.
gn_args['enable_desktop_embeddings'] = not args.disable_desktop_embeddings
# Determine whether backtace support should be compiled in.
if args.backtrace:
gn_args['enable_backtrace'] = (
args.target_os in ['linux', 'mac', 'win'] or
args.target_os == 'ios' and runtime_mode == 'debug'
)
else:
gn_args['enable_backtrace'] = False
# Overrides whether Boring SSL is compiled with system as. Only meaningful
# on Android.
gn_args['bssl_use_clang_integrated_as'] = True
@ -773,6 +782,17 @@ def parse_args(args):
'--arm-float-abi', type=str, choices=['hard', 'soft', 'softfp']
)
# Whether to compile in backtrace support.
# Available for Windows and POSIX platforms whose libc includes execinfo.h.
# MUSL doesn't include execinfo.h should be build with --no-backtrace.
parser.add_argument(
'--backtrace',
default=True,
action='store_true',
help='Whether OS support exists for collecting backtraces.'
)
parser.add_argument('--no-backtrace', dest='backtrace', action='store_false')
parser.add_argument(
'--build-engine-artifacts',
default=True,