21605 Commits

Author SHA1 Message Date
Michael Goderbauer
a508065bbc Reland "Post 3.0 lint sync (#40394)" (flutter/engine#40688)
Reland "Post 3.0 lint sync (#40394)"
2023-03-28 03:25:02 +00:00
Chris Bracken
787ed3f63c [macOS] Eliminate explicit main window init() (flutter/engine#40695)
[macOS] Eliminate explicit main window init()
2023-03-28 01:31:20 +00:00
Jackson Gardner
82886d52b3 Web test reorganization (flutter/engine#39984)
Web test reorganization
2023-03-28 00:08:48 +00:00
gaaclarke
b9fe5d10f1 Improved readme for golden tests. (flutter/engine#40679)
Improved readme for impeller golden tests.
2023-03-27 23:24:53 +00:00
Brandon DeRosier
9e9590a68f Revert "Post 3.0 lint sync (#40394)" (flutter/engine#40687)
This reverts commit 8ba209121d2671b0d202d9731fe67ec5eb1529b4.
2023-03-27 15:45:59 -07:00
Brandon DeRosier
2af281a806 Revert "Return an empty JavaScript object as a replacement for exports/module in patchCanvasKitModule (#40582)" (flutter/engine#40686)
This reverts commit 33dd135fc0034f0fc4dcb8803721d9a77d35852a.
2023-03-27 15:40:29 -07:00
joshualitt
92ca1327a6 Revert "[web] Add js_types sources to build. (#40597)" (flutter/engine#40685)
This reverts commit c14d10c2b110fc04b45e487bb07b38a8acea5026.
2023-03-27 15:37:58 -07:00
Brandon DeRosier
5b4b920911 [Impeller] Fix Impeller Metal wide gamut (flutter/engine#40671) 2023-03-27 13:26:34 -07:00
bungeman
13b279990a Simplify SkFontMgr classes for sk_sp (flutter/engine#40627)
These subclasses were previously made very generic to work with both the
pre-sk_sp version of SkFontMgr and the using-sk_sp version of SkFontMgr.
Now that SkFontMgr uses sk_sp for return types, simplify the subclasses.
2023-03-27 16:06:07 -04:00
Jason Simmons
33dd135fc0 Return an empty JavaScript object as a replacement for exports/module in patchCanvasKitModule (flutter/engine#40582)
Return an empty JavaScript object as a replacement for exports/module in patchCanvasKitModule
2023-03-27 20:04:28 +00:00
joshualitt
c14d10c2b1 [web] Add js_types sources to build. (flutter/engine#40597) 2023-03-27 13:03:57 -07:00
skia-flutter-autoroll
286aed32aa Roll Skia from 4ca827754bc1 to c55605969a59 (5 revisions) (flutter/engine#40668)
Roll Skia from 4ca827754bc1 to c55605969a59 (5 revisions)
2023-03-27 19:50:33 +00:00
Jonah Williams
fffe7e4cb9 [Impeller] initialize text alpha to 1.0 (flutter/engine#40667)
[Impeller] initialize text alpha to 1.0
2023-03-27 19:46:32 +00:00
David Iglesias
34a936b07e Revert "[web] Accepts assetBase through JS config. (#40615)" (flutter/engine#40670)
This reverts commit e0be0c5676f56ef918eb806e1173346dcbadbe5b.

This commit is causing problems with new lint rules:

```
   info - test/engine/assets_test.dart:5:1 - This annotation must be attached to a library directive. Try attaching library annotations to library directives. - library_annotations
```
2023-03-27 12:07:01 -07:00
David Iglesias
e0be0c5676 [web] Accepts assetBase through JS config. (flutter/engine#40615)
[web] Accepts assetBase through JS config.
2023-03-27 17:43:47 +00:00
Brandon DeRosier
d9140ba50c [Impeller] Document EntityPass, make positioning less confusing (flutter/engine#40636) 2023-03-27 10:39:20 -07:00
Michael Goderbauer
8ba209121d Post 3.0 lint sync (flutter/engine#40394)
Post 3.0 lint sync
2023-03-27 17:15:08 +00:00
Filip Filmar
c68289bb76 Remove timezone from flutter (flutter/engine#40588)
Remove timezone from flutter
2023-03-27 17:08:05 +00:00
dependabot[bot]
8ca44c985b Bump actions/checkout from 3.4.0 to 3.5.0 (flutter/engine#40662)
Bump actions/checkout from 3.4.0 to 3.5.0
2023-03-27 09:47:23 +00:00
skia-flutter-autoroll
1d2f54a1d6 Roll Skia from 4d02e783654f to 4ca827754bc1 (2 revisions) (flutter/engine#40659)
Roll Skia from 4d02e783654f to 4ca827754bc1 (2 revisions)
2023-03-27 07:58:38 +00:00
Chinmay Garde
3ec046f92c [Impeller] Remove verbose validation logs in the Vulkan pipeline cache. (flutter/engine#40651)
[Impeller] Remove verbose logs in the Vulkan pipeline cache.
2023-03-26 22:59:21 +00:00
Brandon DeRosier
74ad3dd70f [Impeller] Fix stroke cap disconnection (flutter/engine#40643) 2023-03-26 12:34:20 -07:00
Brandon DeRosier
7340201478 [Impeller] Fix accumulating translucency opacity peephole bug (flutter/engine#40639) 2023-03-26 12:33:11 -07:00
Brandon DeRosier
fba3461d8c [Impeller] Fix AtlasContents crash (flutter/engine#40637) 2023-03-26 12:32:49 -07:00
Brandon DeRosier
7cfb268a9a [Impeller] Keep impeller scene build working (flutter/engine#40635) 2023-03-26 12:32:13 -07:00
Chinmay Garde
96948d3d5a [Impeller] Enable RendererTest::TheImpeller for Vulkan. (flutter/engine#40634)
[Impeller] Enable RendererTest::TheImpeller for Vulkan.
2023-03-26 19:09:18 +00:00
skia-flutter-autoroll
1401f27256 Roll Fuchsia Linux SDK from smNcvjxC6Ja3FkteX... to y4h2rtyt6Mx8xHEte... (flutter/engine#40647)
Roll Fuchsia Linux SDK from smNcvjxC6Ja3FkteX... to y4h2rtyt6Mx8xHEte...
2023-03-26 15:16:09 +00:00
Chinmay Garde
753e03413a [Impeller] More sundry fixes to the Vulkan backend. (flutter/engine#40603)
* Fix mip-map generation in unit-tests where the command buffer was not
  submitted.
* Cleanup descriptor counts being always 1 in Vulkan code-gen.
* Reworked capabilities. Platforms can add to the base capability set.
* Vulkan backend picks between more available color and stencil formats.
* Descriptor pools are dynamically sized.
* Layout transitions are more explicit. Both allocated and swapchain images
  track their own layouts and redundant transitions are avoided.
* Objects active in a pending command buffer are collected but the waits happen
  on a separate fence waiter. Thread is named
  "io.flutter.impeller.fence_waiter".
* Added queue and command buffer instant markers for better traces.
* Command pools and their buffers are now thread local. Fixes sync validation
  failure.
* Debug reports are now more readable and command buffer and queue breadcrumbs
  will be displayed on a validation report.
* Staging buffers are back.
* Pipeline caches have been wired up. After 50 frames, the current Vulkan
  pipeline cache will be written out to disk for subsequent launches. Writes
  will happen on a background worker.
* Runtime stages have been wired up. But the build rules to provide the right
  stages are still remaining.

Fixes https://github.com/flutter/flutter/issues/121536
Fixes https://github.com/flutter/flutter/issues/121627
Fixes https://github.com/flutter/flutter/issues/121632
Fixes https://github.com/flutter/flutter/issues/120499
2023-03-25 13:40:19 -07:00
skia-flutter-autoroll
a474b1809f Roll Skia from 497dc2e1f01f to 17bce5f4f78f (2 revisions) (flutter/engine#40629)
Roll Skia from 497dc2e1f01f to 17bce5f4f78f (2 revisions)
2023-03-25 18:08:24 +00:00
skia-flutter-autoroll
cab301a5fe Roll Fuchsia Linux SDK from jdkyVHuAgQFiwEVQj... to 6JDOgmv1GqjN0MccU... (flutter/engine#40622)
Roll Fuchsia Linux SDK from jdkyVHuAgQFiwEVQj... to 6JDOgmv1GqjN0MccU...
2023-03-25 09:11:25 +00:00
gaaclarke
142803bf72 [Impeller] Adds golden image tests. (flutter/engine#40366)
Added golden image tests to impeller
2023-03-24 16:42:28 -07:00
Dan Field
8f0de93feb Make PathComponent POD, allow querying specific component type counts (flutter/engine#40605)
[Impeller] Make PathComponent POD, allow querying specific component type counts
2023-03-24 22:53:12 +00:00
skia-flutter-autoroll
2e4ce766bf Roll Skia from 86228d7534de to 497dc2e1f01f (14 revisions) (flutter/engine#40611)
Roll Skia from 86228d7534de to 497dc2e1f01f (14 revisions)
2023-03-24 22:07:47 +00:00
Dan Field
96773d7c04 Avoid implicit conversions to floats in dart:ui (flutter/engine#40098)
Avoid implicit conversions to floats in dart:ui
2023-03-24 21:36:41 +00:00
chunhtai
c56c8d9354 Added additional uri field to routeInformationUpdated to accept entir… (flutter/engine#40250)
Added additional uri field to routeInformationUpdated to accept entir…
2023-03-24 20:12:13 +00:00
Jackson Gardner
b6af3bcc91 Ensure all golden filenames end in .png. (flutter/engine#40604)
Ensure all golden filenames end in .png.
2023-03-24 19:28:57 +00:00
yaakovschectman
c5156e2370 Revert "Unregister the FlutterWindowsView on its destruction (#39824)" (flutter/engine#40607)
Revert "Unregister the FlutterWindowsView on its destruction"
2023-03-24 19:26:34 +00:00
Harry Terkelsen
888d56a309 Reland "Default the CanvasKit base URL to local artifacts. (#40293)" (flutter/engine#40470)
This reverts commit d56b53d0c6006873499ba75dcc0bf478834a1b64.
2023-03-24 11:41:33 -07:00
Loïc Sharma
cbee4256c0 [Windows] Use the new update semantics embedder API (flutter/engine#40072)
[Windows] Use the new update semantics embedder API
2023-03-24 18:29:26 +00:00
joshualitt
4babe7a6e9 Revert "[web] Migrate canvaskit_api to JS types.(#40538)" (flutter/engine#40602)
This reverts commit 1a76a2115d94ed64c5e1c08303e1154215347d87.
2023-03-24 10:56:53 -07:00
yaakovschectman
d7059df4eb Listen to WM_CLOSE message on Windows to allow framework to cancel exit (flutter/engine#40493)
* Intercept WM_CLOSE

* Messy but framework is in place

* Test exit and cancel

* Try to test for windows

* Check for parent HWND

* Move string to PlatformHandler class

* Rename lifecycle manageR

* Change condition for headless

* Move window proc to lambda

* Formatting and licenses

* Encode JSON dart values

* Clean up lifecycle

* PR feedback

* Update shell/platform/windows/platform_handler.h

Co-authored-by: Chris Bracken <chris@bracken.jp>

* Update shell/platform/windows/windows_lifecycle_manager.cc

Co-authored-by: Chris Bracken <chris@bracken.jp>

* Update shell/platform/windows/windows_lifecycle_manager.cc

Co-authored-by: Chris Bracken <chris@bracken.jp>

* Static cast enum to int

* Formatting

* Update shell/platform/windows/testing/engine_modifier.h

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>

* Update shell/platform/windows/windows_lifecycle_manager.cc

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>

* Update shell/platform/windows/platform_handler.cc

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>

* Update unit tests

* PR Feedback

* PR Feedback

* Constexpr

* Formatting

* Wparam

---------

Co-authored-by: Chris Bracken <chris@bracken.jp>
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
2023-03-24 12:44:42 -04:00
joshualitt
1a76a2115d [web] Migrate canvaskit_api to JS types.(flutter/engine#40538) 2023-03-24 08:53:11 -07:00
Ricardo Amador
0fabddfb3b Adding autosubmit configuration pointer file (flutter/engine#40581)
* Adding autosubmit config pointer file.

* Add wiki page to the file
2023-03-24 08:25:39 -07:00
skia-flutter-autoroll
47691f5dd3 Roll Fuchsia Linux SDK from aIkSAx7637llNDq75... to jdkyVHuAgQFiwEVQj... (flutter/engine#40594)
Roll Fuchsia Linux SDK from aIkSAx7637llNDq75... to jdkyVHuAgQFiwEVQj...
2023-03-24 10:30:17 +00:00
Jonah Williams
1ae57920a9 [impeller] runtime effect doesnt accept opacity (flutter/engine#40579)
[impeller] runtime effect doesnt accept opacity
2023-03-24 02:55:21 +00:00
skia-flutter-autoroll
58ad9ae24e Roll Skia from 32ffab0c9432 to 86228d7534de (7 revisions) (flutter/engine#40586)
Roll Skia from 32ffab0c9432 to 86228d7534de (7 revisions)
2023-03-24 02:11:24 +00:00
LongCatIsLooong
42c2dc35ad Fix default test font on web (flutter/engine#40479)
Fix default test font on web
2023-03-23 22:24:36 +00:00
godofredoc
e11ed85b7a Use target platform name when generating artifacts. (flutter/engine#40519)
Use target platform name when generating artifacts.
2023-03-23 20:58:57 +00:00
skia-flutter-autoroll
cc8e00d2f4 Roll Skia from b46961dcb142 to 32ffab0c9432 (3 revisions) (flutter/engine#40577)
Roll Skia from b46961dcb142 to 32ffab0c9432 (3 revisions)
2023-03-23 20:38:48 +00:00
Jonah Williams
60987522d2 [impeller] use lossy texture compression on iOS (flutter/engine#40520)
[Impeller] use lossy texture compression on iOS for decode images and MSAA resolve textures.
2023-03-23 20:29:40 +00:00