28753 Commits

Author SHA1 Message Date
skia-flutter-autoroll
a3165bca40 Roll ICU from d8daa943f64c to a2961dc659b4 (2 revisions) (flutter/engine#41801)
d8daa943f6..a2961dc659

2023-05-03 ayzhao@google.com Explicitly include <utility> in measunit.h
2023-04-17 fmil@google.com [fuchsia] Add a slot for extra compilation flags

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/icu-sdk-flutter-engine
Please CC jimgraham@google.com,tq-i18n-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ICU: https://github.com/unicode-org/icu
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-07 18:44:16 +00:00
skia-flutter-autoroll
83b10f773d Roll Fuchsia Mac SDK from k4NzlntuagXZIlCJg... to VD0zJZ-ezOAfA9O1s... (flutter/engine#41800)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-07 16:08:23 +00:00
skia-flutter-autoroll
56c17e01e3 Roll Fuchsia Mac SDK from FFOWihz4lzOeDHmNj... to k4NzlntuagXZIlCJg... (flutter/engine#41799)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-07 03:16:34 +00:00
skia-flutter-autoroll
3135753f57 Roll Dart SDK from d04e8b571819 to ab64c4a56e2c (1 revision) (flutter/engine#41798)
https://dart.googlesource.com/sdk.git/+log/d04e8b571819..ab64c4a56e2c

2023-05-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-84.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,dart-vm-team@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-06 22:26:23 +00:00
Dan Field
ea5131772d Add a Display API to dart:ui that reports the physical size, DPR, and refresh rate of the main display (flutter/engine#41685)
Fixes https://github.com/flutter/flutter/issues/123307 - for Android, iOS, and Web, for the main display only (https://github.com/flutter/flutter/issues/125938 tracks supporting multiple displays, https://github.com/flutter/flutter/issues/125939 for desktop).

Desktop will need to be implemented for this, but given priority for a couple of our customers targetting foldable devices on Android I'm inclined to get this in before desktop can be finished.

The main concern for this right now is that on some Android foldable devices, setting a preferred orientation will cause letterboxing and the `MediaQuery` will _never_ get the full screen size when unfolded. This causes apps to think the screen is smaller than it is, as they've mainly been using `MediaQueryData.size` to figure this out. Android's recommendation is to not set a preferred orientation, and if you must to use the new method introduced in `ViewUtil.java` to calculate the maximal window size.
2023-05-06 18:28:22 +00:00
skia-flutter-autoroll
7026d52d58 Roll Skia from e7de10e25736 to 8a93b289c2ed (1 revision) (flutter/engine#41796)
https://skia.googlesource.com/skia.git/+log/e7de10e25736..8a93b289c2ed

2023-05-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 764046e2223f to cda100bdb284 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-06 15:44:21 +00:00
skia-flutter-autoroll
3680c223a2 Roll Fuchsia Mac SDK from S3gPFEsS1wP40ivwV... to FFOWihz4lzOeDHmNj... (flutter/engine#41795)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-06 14:31:33 +00:00
skia-flutter-autoroll
c88842d501 Roll Dart SDK from 8695bed2bc58 to d04e8b571819 (1 revision) (flutter/engine#41793)
https://dart.googlesource.com/sdk.git/+log/8695bed2bc58..d04e8b571819

2023-05-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-83.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,dart-vm-team@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-06 07:32:34 +00:00
skia-flutter-autoroll
c2a83f1ad9 Roll Skia from 2e622658996c to e7de10e25736 (1 revision) (flutter/engine#41791)
https://skia.googlesource.com/skia.git/+log/2e622658996c..e7de10e25736

2023-05-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from aff87689f063 to 764046e2223f (13 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-06 02:32:23 +00:00
skia-flutter-autoroll
0eb1d7530a Roll Fuchsia Mac SDK from Z3O1yYOsNgkQ6b0o3... to S3gPFEsS1wP40ivwV... (flutter/engine#41790)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-06 01:47:19 +00:00
skia-flutter-autoroll
e69f9f3bae Roll Skia from bc0197405951 to 2e622658996c (1 revision) (flutter/engine#41789)
https://skia.googlesource.com/skia.git/+log/bc0197405951..2e622658996c

2023-05-05 michaelludwig@google.com Skip desk_carsvg on QuadroP400 windows bots

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-06 00:03:21 +00:00
Jonah Williams
aa966cb2f1 [Impeller] remove SDF code paths. (flutter/engine#41754)
From my investigations, we're not likely to be able to use SDF in the near term. To make planned refactors of the text rendering easier to land, I've moved the primary piece of code for generating the SDFs into a new TU for testing.

The shader itself has been deleted so that we don't ship + register it.
2023-05-05 23:43:03 +00:00
skia-flutter-autoroll
2ef6ee34aa Roll Fuchsia Linux SDK from jbpFz7qSikrKiRanC... to leCRDVJ8szOS2LsPV... (flutter/engine#41788)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-05 23:23:24 +00:00
skia-flutter-autoroll
5ded91dab7 Roll Skia from aa52cd1afae2 to bc0197405951 (3 revisions) (flutter/engine#41787)
https://skia.googlesource.com/skia.git/+log/aa52cd1afae2..bc0197405951

2023-05-05 johnstiles@google.com Revert "Prevent name collisions between variables and intrinsics."
2023-05-05 jlavrova@google.com Making ParagraphBuilder API for Client ICU public
2023-05-05 johnstiles@google.com Remove unused accessors from ThreadContext.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-05 23:19:21 +00:00
skia-flutter-autoroll
535e335abc Roll Dart SDK from bb9f17a8f0c3 to 8695bed2bc58 (1 revision) (flutter/engine#41786)
https://dart.googlesource.com/sdk.git/+log/bb9f17a8f0c3..8695bed2bc58

2023-05-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-82.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,dart-vm-team@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-05 22:27:04 +00:00
skia-flutter-autoroll
abf9a42c2d Roll Skia from d6149a13d696 to aa52cd1afae2 (3 revisions) (flutter/engine#41783)
https://skia.googlesource.com/skia.git/+log/d6149a13d696..aa52cd1afae2

2023-05-05 johnstiles@google.com Prevent name collisions between variables and intrinsics.
2023-05-05 jlavrova@google.com Changing tests after harfbuzz update
2023-05-05 jlavrova@google.com Fixing getLineNumberAt method

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-05 20:11:10 +00:00
Zachary Anderson
f0a5d579e7 Roll impeller-cmake-example to 270e648f8c00aa900d2d16ef8a347938652d17fb (flutter/engine#41758) 2023-05-05 12:17:35 -07:00
Jason Simmons
87a63996d7 [Impeller] Do not free a Vulkan command buffer if its command pool has already been destroyed (flutter/engine#41761)
Fixes https://github.com/flutter/flutter/issues/125519
2023-05-05 18:49:57 +00:00
Tong Mu
05036058d7 Remove single window assumption from SceneBuilder (flutter/engine#41559)
This PR fixes https://github.com/flutter/flutter/issues/112202. `Scene`
is no longer tied to views, but receives method arguments for view
properties, clearing the path to multiview Flutter.

`Scene` no longer creates a `LayerTree` on construction, but only part
of the config. When a output method is called (`toImage`, `toImageSync`,
or `takeLayerTree`), the `LayerTree` is constructed on the spot. In this
way, all `LayerTree`s return to being `unique_ptr`s instead of
`shared_ptr`s, reverting part of
https://github.com/flutter/engine/pull/35608 . And `Scene` no longer
needs to disfunction after one `takeLayerTree`, since the layer tree
config is never really taken away.

A `device_pixel_ratio` is now added to the parameter list of `Engine::Render` and `Animator::Render`.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-05-05 11:25:55 -07:00
skia-flutter-autoroll
93248512ea Roll Skia from 1a1c7db436e4 to d6149a13d696 (6 revisions) (flutter/engine#41779)
https://skia.googlesource.com/skia.git/+log/1a1c7db436e4..d6149a13d696

2023-05-05 johnstiles@google.com Parse statements without using DSLCore.
2023-05-05 johnstiles@google.com Parse for statements without using DSLCore.
2023-05-05 michaelludwig@google.com [skif] Remove use of deprecated Magnifier factory within Skia
2023-05-05 jamesgk@google.com [graphite] Dst reads using copies
2023-05-05 johnstiles@google.com Remove ThreadContext::SymbolTable.
2023-05-05 johnstiles@google.com Move the active symbol table into the SkSL::Context.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-05 18:19:02 +00:00
godofredoc
8e28d74274 Replace legacy linux unopt with engine v2. (flutter/engine#41757)
This moves the legacy linux unopt build to staging and the engine v2 version to production.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-05-05 17:47:11 +00:00
godofredoc
8cd97026b0 Allow default out_dir for fuchsia symbols upload. (flutter/engine#41776)
This also allows passing target files as relative to the src folder. This is required for migrating the fuchsia builds to engine_v2.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-05-05 17:36:20 +00:00
skia-flutter-autoroll
50264eb154 Roll Dart SDK from 07016e96b9ed to bb9f17a8f0c3 (1 revision) (flutter/engine#41773)
https://dart.googlesource.com/sdk.git/+log/07016e96b9ed..bb9f17a8f0c3

2023-05-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-81.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,dart-vm-team@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-05 15:11:50 +00:00
skia-flutter-autoroll
a99f54a4e9 Roll Skia from d71ece9f9f1a to 1a1c7db436e4 (1 revision) (flutter/engine#41772)
https://skia.googlesource.com/skia.git/+log/d71ece9f9f1a..1a1c7db436e4

2023-05-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 3ef8bd4528d0 to aff87689f063 (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-05 13:41:06 +00:00
skia-flutter-autoroll
3cf35fd8ea Roll Fuchsia Mac SDK from de2Eqw0IsOzTq15m3... to Z3O1yYOsNgkQ6b0o3... (flutter/engine#41771)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-05 13:03:53 +00:00
skia-flutter-autoroll
fbc6f9f936 Roll Dart SDK from eff8f62a7bc7 to 07016e96b9ed (1 revision) (flutter/engine#41770)
https://dart.googlesource.com/sdk.git/+log/eff8f62a7bc7..07016e96b9ed

2023-05-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-80.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,dart-vm-team@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-05 11:17:34 +00:00
skia-flutter-autoroll
5be5a3d00c Roll Skia from edc4ee2e286e to d71ece9f9f1a (2 revisions) (flutter/engine#41768)
https://skia.googlesource.com/skia.git/+log/edc4ee2e286e..d71ece9f9f1a

2023-05-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from cd171d2ef3ca to dd7eb1d8e8dc (14 revisions)
2023-05-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 5894e1e3e47d to 2cde5edfb81e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-05 09:54:34 +00:00
skia-flutter-autoroll
1b9b698951 Roll Fuchsia Linux SDK from m0-fwGyFnoDVAvxgk... to jbpFz7qSikrKiRanC... (flutter/engine#41769)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-05 09:40:21 +00:00
skia-flutter-autoroll
c4d5616ed5 Roll Dart SDK from afeed9f8701e to eff8f62a7bc7 (2 revisions) (flutter/engine#41764)
https://dart.googlesource.com/sdk.git/+log/afeed9f8701e..eff8f62a7bc7

2023-05-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-79.0.dev
2023-05-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-78.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,dart-vm-team@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-05 07:28:22 +00:00
skia-flutter-autoroll
330fc18be0 Roll Skia from bf4217c3f0da to edc4ee2e286e (1 revision) (flutter/engine#41763)
https://skia.googlesource.com/skia.git/+log/bf4217c3f0da..edc4ee2e286e

2023-05-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from d6fb4eb8ccb8 to 5894e1e3e47d (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-05 07:00:21 +00:00
Tong Mu
0d1d5a7d34 [macOS] Change view ID's type to signed and a typedef (flutter/engine#41653)
This PR changes the view ID type to `int64_t` and typedef it to
`FlutterViewId`

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-05-04 23:08:57 -07:00
skia-flutter-autoroll
71c4831258 Roll Skia from 6577130e14b6 to bf4217c3f0da (1 revision) (flutter/engine#41762)
https://skia.googlesource.com/skia.git/+log/6577130e14b6..bf4217c3f0da

2023-05-05 michaelludwig@google.com Reland "[skif] Use FilterResult::applyColorFilter in SkColorFilterImageFilter"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-05 04:02:09 +00:00
陈昱
aa95b83a0d Close connection on keyboard close (flutter/engine#41500)
Fix:
- https://github.com/flutter/flutter/issues/123523
- https://github.com/flutter/flutter/issues/124890

### Before this patch:

https://user-images.githubusercontent.com/30322203/228413196-29c57bb0-3220-495b-9e73-f58777de440f.mp4

### After this patch:

https://user-images.githubusercontent.com/30322203/228413249-fc06f49d-6579-4476-9788-90f12a53b8c3.mp4
2023-05-05 02:55:05 +00:00
skia-flutter-autoroll
24a866fe8e Roll Fuchsia Mac SDK from SD8Q_B7eWZqLgqo0f... to de2Eqw0IsOzTq15m3... (flutter/engine#41755)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-05 00:17:02 +00:00
skia-flutter-autoroll
7e16e1d4a2 Roll Skia from 00693e987828 to 6577130e14b6 (1 revision) (flutter/engine#41752)
https://skia.googlesource.com/skia.git/+log/00693e987828..6577130e14b6

2023-05-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 9b1cd443e07a to 3ef8bd4528d0 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-04 23:55:39 +00:00
Jackson Gardner
f2970b73b0 Revert "Skwasm Font Loading" (flutter/engine#41750)
Reverts flutter/engine#41246

The new font manifest parsing fails in some cases.
2023-05-04 23:54:18 +00:00
skia-flutter-autoroll
f19f8994e8 Roll Dart SDK from 95e133dbd3a6 to afeed9f8701e (1 revision) (flutter/engine#41749)
https://dart.googlesource.com/sdk.git/+log/95e133dbd3a6..afeed9f8701e

2023-05-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-77.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,dart-vm-team@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-04 23:38:37 +00:00
Jenn Magder
29dc3361f0 Fix flaky FlutterChannelsTests, stop mocking NSObject (flutter/engine#41747)
I don't know why this is only flaking on arm64 Macs, but instead of mocking out `NSObject` which seems to continue to be mocked on some background thread, instead mock out the more-specific `FlutterTaskQueue` protocol.  Turn the tests back on.

Fixes https://github.com/flutter/flutter/issues/126013
Reverts https://github.com/flutter/engine/pull/41740

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-05-04 22:58:12 +00:00
skia-flutter-autoroll
c8110a1cb7 Roll Skia from a4828415b4af to 00693e987828 (6 revisions) (flutter/engine#41746)
https://skia.googlesource.com/skia.git/+log/a4828415b4af..00693e987828

2023-05-04 johnstiles@google.com Remove unused flag from VarDeclaration::Convert.
2023-05-04 johnstiles@google.com Use packed contexts for ternary ops in SkRP.
2023-05-04 michaelludwig@google.com [skif] Automatically switch to NN sampling when possible
2023-05-04 johnstiles@google.com Create test case demonstrating inliner issue.
2023-05-04 johnstiles@google.com Generate simpler code when SkArenaAlloc makes a POD type.
2023-05-04 michaelludwig@google.com Add skia_use_legacy_colorfilter_imagefilter GN arg for flutter roll

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-04 22:58:10 +00:00
godofredoc
67ff63e16a Migrate linux unopt to engine_v2. (flutter/engine#41658)
Migrates linux unopt to use engine v2 recipes.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-05-04 21:59:52 +00:00
Jonah Williams
11bd4c8bb3 [Impeller] check if path is Rect/RRect/Oval (flutter/engine#41744)
This avoids tessellation if the application draws a Rect or RREct with Path.addRect or Path.addRREct.
2023-05-04 20:51:21 +00:00
Michael Ludwig
4a82a1b867 Add temporary staging GN arg for Skia roll (flutter/engine#41743)
In order to enable the new behavior, dl_imagefilter_unittests need to be
updated to reflect new bounds mapping values. This requires an atomic PR
to disable the legacy arg and update after skia rolls.

Required to land https://skia-review.googlesource.com/c/skia/+/693058
and progress on https://skbug.com/9283

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-05-04 13:38:01 -07:00
Jason Simmons
f9a3a4889f Roll buildroot to 05ec9f7124191c7ba354521f3ffd34b09af872e7 (flutter/engine#41736) 2023-05-04 20:03:19 +00:00
skia-flutter-autoroll
14647eace4 Roll Dart SDK from 7b56aac98a5a to 95e133dbd3a6 (1 revision) (flutter/engine#41741)
https://dart.googlesource.com/sdk.git/+log/7b56aac98a5a..95e133dbd3a6

2023-05-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-76.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,dart-vm-team@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-04 19:51:57 +00:00
Dan Field
ee7376a670 Disable flaky tests on arm64 (flutter/engine#41740)
Reduces severity of https://github.com/flutter/flutter/issues/126013
2023-05-04 12:22:18 -07:00
skia-flutter-autoroll
e6ece101f0 Roll Skia from 6950f56ad2ec to a4828415b4af (2 revisions) (flutter/engine#41737)
https://skia.googlesource.com/skia.git/+log/6950f56ad2ec..a4828415b4af

2023-05-04 johnstiles@google.com Use a packed context for SkRP case_op.
2023-05-04 johnstiles@google.com Ensure linear-SRGB conversion is free when it's a no-op.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-04 19:11:41 +00:00
skia-flutter-autoroll
7a7f907adf Roll Fuchsia Linux SDK from LIacrdFhuTuHnYh0B... to m0-fwGyFnoDVAvxgk... (flutter/engine#41738)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-04 18:37:59 +00:00
Jackson Gardner
6f5ad9737e Skwasm Font Loading (flutter/engine#41246)
This implements font loading for the skwasm renderer.

In addition, it does some pretty major refactors:
1) Simplified the font collection interface to just have a single `loadAssetFonts` call, without the separate registration and debug fonts loading stuff
2) Debug fonts load now through http/asset mocking mechanisms instead of having a separate `downloadDebugTestFonts` call
3) Consolidated a few of our different unit test setup functions into a single `setUpUnitTests` function
2023-05-04 18:22:53 +00:00
godofredoc
a21064fb0a Migrate linux_host_engine to engine v2. (flutter/engine#41715)
The artifacts generated by legacy and engine v2 are identical. This PR is moving linux host engine to staging and starts uploading engine v2 artifacts to production.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-05-04 16:23:51 +00:00
skia-flutter-autoroll
f6636f5cdc Roll Dart SDK from 47da769ae13a to 7b56aac98a5a (1 revision) (flutter/engine#41731)
https://dart.googlesource.com/sdk.git/+log/47da769ae13a..7b56aac98a5a

2023-05-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-75.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,dart-vm-team@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-04 13:25:39 +00:00