DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
85,768 Commits 882 Branches 1,069 Tags
Commit Graph

85768 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Kamil Kras
9efb790691
Fix typo in widget_inspector.dart (#174115) 
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-08-29 21:41:21 +00:00
engine-flutter-autoroll
947c28ddd7
Roll Skia from 9c26b17dd7b7 to e308c951ead3 (1 revision) (#174727) 
https://skia.googlesource.com/skia.git/+log/9c26b17dd7b7..e308c951ead3

2025-08-29 thomsmit@google.com [graphite] Separates uniform manager
components

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com,kjlubick@google.com,nicolettep@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-29 21:39:04 +00:00
Ahmed Mohamed Sameh
6e4b1fe407
Handle#6537 date picker dialog (#174359) 
Apply
https://github.com/flutter/flutter/issues/6537#issuecomment-3216557050
 2025-08-29 21:31:06 +00:00
Ahmed Mohamed Sameh
0fe60b15a2
Make sure that a Dialog doesn't crash in 0x0 environment (#174023) 
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the Dialog UI
control.

Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
 2025-08-29 21:27:09 +00:00
Ahmed Hussein
05fbe0ed1b
Add SliverGrid.list convenience constructor (#173925) 
This PR adds a new `SliverGrid.list` convenience constructor that
accepts a `List<Widget> children` parameter, providing a cleaner API
compared to manually creating `SliverChildListDelegate`.

## What was added

The constructor uses `SliverChildListDelegate` internally and follows
the same pattern as existing convenience constructors like
`SliverGrid.count` and `SliverGrid.extent`. This addresses the use case
where developers want to create sliver grids with predefined widget
lists without the verbosity of manually constructing the delegate.

## Before/After comparison

**Before:**
```dart
SliverGrid(
  gridDelegate: gridDelegate,
  delegate: SliverChildListDelegate([widget1, widget2, widget3]),
)
```

**After:**
```dart
SliverGrid.list(
  gridDelegate: gridDelegate,
  children: [widget1, widget2, widget3],
)
```

## Implementation details

- Added `SliverGrid.list` constructor in
`packages/flutter/lib/src/widgets/sliver.dart`
- Constructor accepts `List<Widget> children` and all necessary delegate
configuration parameters
- Uses `SliverChildListDelegate` internally for consistent behavior
- Added comprehensive test coverage in
`packages/flutter/test/widgets/slivers_test.dart`

## Issue addressed

Fixes: #173018

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

---------

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
 2025-08-29 21:05:42 +00:00
engine-flutter-autoroll
5a0aed4502
Roll Dart SDK from 72cda0f3dc42 to 6d356e5cd4ec (1 revision) (#174718) 
https://dart.googlesource.com/sdk.git/+log/72cda0f3dc42..6d356e5cd4ec

2025-08-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-154.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-29 20:45:19 +00:00
chunhtai
03195e6990
Reapply "Add set semantics enabled API and wire iOS a11y bridge" (#174163) 
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->


Previous pr is reverted due to internal test failure

This is a straight reland, no change from previous. only need to migrate
internal code

fixes https://github.com/flutter/flutter/issues/158399

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-08-29 19:29:12 +00:00
Victoria Ashworth
b039be55b3
Remove build configuration mismatch warning (#174715) 
A build configuration mismatch warning was introduced in
https://github.com/flutter/flutter/pull/169395 to help handle
dev_dependencies relying on the build configuration. However, we
disabled dev_dependencies from being excluded per configuration in
https://github.com/flutter/flutter/pull/171015. This warning therefore
can also be removed.

Fixes https://github.com/flutter/flutter/issues/174015.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-08-29 18:55:08 +00:00
engine-flutter-autoroll
4760345abe
Roll Packages from 141d8e304419 to a3f09e5705d7 (2 revisions) (#174706) 
141d8e3044...a3f09e5705

2025-08-28 stuartmorgan@google.com [google_sign_in] Implement hosted
domain on Android (flutter/packages#9871)
2025-08-28 monteiroamelo@gmail.com
[google_maps_flutter_platform_interface] Add cameraControl
enable/disable & position on web (flutter/packages#9897)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-29 15:42:56 +00:00
engine-flutter-autoroll
ec22666615
Roll Skia from 43e79dc80ca8 to 9c26b17dd7b7 (6 revisions) (#174704) 
https://skia.googlesource.com/skia.git/+log/43e79dc80ca8..9c26b17dd7b7

2025-08-29
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-08-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from c4290955f303 to 3c8902583f3c (4 revisions)
2025-08-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 873473557ae0 to 4983b4c94e40 (14 revisions)
2025-08-29
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-08-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 029eb3459232 to b03da099c360 (23 revisions)
2025-08-29
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com,kjlubick@google.com,nicolettep@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-29 14:34:03 +00:00
engine-flutter-autoroll
6b18740d5a
Roll Dart SDK from 11f6cd99f6b3 to 72cda0f3dc42 (2 revisions) (#174697) 
https://dart.googlesource.com/sdk.git/+log/11f6cd99f6b3..72cda0f3dc42

2025-08-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-153.0.dev
2025-08-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-152.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-29 14:05:27 +00:00
Kostia Sokolovskyi
03e9fe3357
Fix empty adaptive text selection toolbars building. (#174656) 
Fixes https://github.com/flutter/flutter/issues/174649

This PR fixes `AdaptiveTextSelectionToolbar` and
`CupertinoAdaptiveTextSelectionToolbar` building when `children` and
`buttonItems` are both `null`.

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-08-29 05:17:06 +00:00
Hannah Jin
8912a2ad36
[flutter_test] update the _isImportantForAccessibility method in SemanticsController to include tooltip (#174476) 
updates the _isImportantForAccessibility method in SemanticsController
to include tooltip
tester.semantics.simulatedAccessibilityTraversal() now will show those
semantics nodes with only tooltip!


## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-08-29 05:10:21 +00:00
engine-flutter-autoroll
4c6bbcb5e7
Roll Skia from 89794f0b5384 to 43e79dc80ca8 (1 revision) (#174678) 
https://skia.googlesource.com/skia.git/+log/89794f0b5384..43e79dc80ca8

2025-08-29
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com,kjlubick@google.com,nicolettep@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-29 05:00:55 +00:00
engine-flutter-autoroll
97134f1ce5
Roll Skia from f3c8b4c677f5 to 89794f0b5384 (6 revisions) (#174675) 
https://skia.googlesource.com/skia.git/+log/f3c8b4c677f5..89794f0b5384

2025-08-28 danieldilan@google.com [rustpng] Use newer rust api
`read_row` to avoid extra memcpys
2025-08-28 ccameron@chromium.org skcms: Remove unsupported configuration
from colorspace_gm
2025-08-28 mike@reedtribe.org Check if CTM overflows the path
2025-08-28 bungeman@google.com Modernize SkFontMgr_AndroidNDK iteration
2025-08-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 140a4bc26cef to c4290955f303 (3 revisions)
2025-08-28 kjlubick@google.com Use updated cmake docker container in CI

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com,kjlubick@google.com,nicolettep@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-29 01:22:37 +00:00
chunhtai
989529342b
Implement Overlay.of with inherited widget (#174315) 
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

for https://github.com/flutter/flutter/pull/174239

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-08-29 01:11:25 +00:00
Jackson Gardner
c98cc294ba
[impeller] Support partitioned host buffer (#174463) 
This change adds support for host buffer that keeps index buffers
separate from other general-purpose data. This is a requirement for
WebGL:
https://registry.khronos.org/webgl/specs/latest/2.0/#BUFFER_OBJECT_BINDING

No current backends use the partitioned implementation, but once I add
WebGL support it will use it to avoid
https://github.com/flutter/flutter/issues/149603
 2025-08-29 01:08:47 +00:00
chunhtai
ebca75b86c
Adds semantics for disabled buttons in date picker (#174064) 
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

fixes https://github.com/flutter/flutter/issues/172988
fixes https://github.com/flutter/flutter/issues/173870

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-08-29 01:08:44 +00:00
engine-flutter-autoroll
be7997f185
Roll Fuchsia Linux SDK from bHYRvLv2Dg56RWZF2... to 00VSr-5B7hq0G2eZx... (#174667) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jimgraham@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-29 01:06:59 +00:00
Robert Ancell
99012ee692
Check GTK calls are done on the same thread. (#174488) (#174624) 
Resubmitted, as the previous PR had a merge error.

Fixes https://github.com/flutter/flutter/issues/173660
 2025-08-29 01:05:21 +00:00
Ben Konyi
89ba8a06a5
[ Tool ] Only listen for DebugConnectionInfo if the service protocol is supported (#174664) 
Fixes https://github.com/flutter/flutter/issues/174330
 2025-08-29 01:05:21 +00:00
engine-flutter-autoroll
a99c389b22
Roll Dart SDK from 89023922f96d to 11f6cd99f6b3 (9 revisions) (#174669) 
https://dart.googlesource.com/sdk.git/+log/89023922f96d..11f6cd99f6b3

2025-08-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-151.0.dev
2025-08-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-150.0.dev
2025-08-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-149.0.dev
2025-08-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-148.0.dev
2025-08-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-147.0.dev
2025-08-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-146.0.dev
2025-08-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-145.0.dev
2025-08-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-144.0.dev
2025-08-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-143.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-29 01:05:21 +00:00
auto-submit[bot]
b94a29ea82
Reverts "[web] Refactor renderers to use the same frontend code (#174588)" (#174672) 
<!-- start_original_pr_link -->
Reverts: flutter/flutter#174588
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: harryterkelsen
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Skwasm benchmarks and google_sign_in tests are
broken as a result of this PR
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: harryterkelsen
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {mdebbar}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
Refactors the renderer code so both renderers (Skwasm and CanvasKit) use
the same SceneBuilder and platform view embedding code. This change is
discussed in a design doc here:
https://flutter.dev/go/web-renderer-unification

Fixes https://github.com/flutter/flutter/issues/172311
Fixes https://github.com/flutter/flutter/issues/172308
Fixes https://github.com/flutter/flutter/issues/142072

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
 2025-08-28 22:19:47 +00:00
Hannah Jin
1639e62e8f
[a11y] [test] containsSemantics can ignore SemanticsValidationResult (#174608) 
issue: https://github.com/flutter/flutter/issues/173838 


## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-08-28 21:50:21 +00:00
Kostia Sokolovskyi
23e65c0b49
Fix some issues in engine-tool README. (#174512) 
- Fixes broken `Note` alert
https://github.com/flutter/flutter/blob/master/engine/src/flutter/tools/engine_tool/README.md#running-a-flutter-app-with-a-local-engine-build
- Fixes a couple of typos

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-08-28 21:31:55 +00:00
Flutter GitHub Bot
26031d57df
Marks Linux_pixel_7pro new_gallery__transition_perf to be flaky (#174106) 
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_pixel_7pro new_gallery__transition_perf"
}
-->
Issue link: https://github.com/flutter/flutter/issues/174105
 2025-08-28 20:57:09 +00:00
Ahmed Mohamed Sameh
d0261ea6f7
Make sure that an AlertDialog doesn't crash in 0x0 environment (#174091) 
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the AlertDialog UI
control.
 2025-08-28 20:34:52 +00:00
Flutter GitHub Bot
520fe3f3fa
Marks Linux_pixel_7pro hello_world_impeller to be flaky (#173699) 
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_pixel_7pro hello_world_impeller"
}
-->
Issue link: https://github.com/flutter/flutter/issues/173698
 2025-08-28 20:31:17 +00:00
Flutter GitHub Bot
a16a112723
Marks Linux_pixel_7pro drive_perf_debug_warning to be flaky (#174112) 
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_pixel_7pro drive_perf_debug_warning"
}
-->
Issue link: https://github.com/flutter/flutter/issues/174111
 2025-08-28 20:28:17 +00:00
Flutter GitHub Bot
d1967d719b
Marks Linux_android_emu android_display_cutout to be flaky (#174501) 
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_android_emu android_display_cutout"
}
-->
Issue link: https://github.com/flutter/flutter/issues/174500
 2025-08-28 20:28:17 +00:00
Flutter GitHub Bot
37953c81fa
Marks Linux_pixel_7pro service_extensions_test to be flaky (#174114) 
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_pixel_7pro service_extensions_test"
}
-->
Issue link: https://github.com/flutter/flutter/issues/174113
 2025-08-28 20:28:17 +00:00
Flutter GitHub Bot
472c4116a7
Marks Windows plugin_test to be flaky (#174117) 
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows plugin_test"
}
-->
Issue link: https://github.com/flutter/flutter/issues/174116
 2025-08-28 20:27:47 +00:00
Flutter GitHub Bot
474ea7f09b
Marks Windows_mokey basic_material_app_win__compile to be flaky (#173702) 
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows_mokey basic_material_app_win__compile"
}
-->
Issue link: https://github.com/flutter/flutter/issues/173701
 2025-08-28 20:27:28 +00:00
Flutter GitHub Bot
82cc70c24c
Marks Mac_mokey microbenchmarks to be flaky (#174102) 
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_mokey microbenchmarks"
}
-->
Issue link: https://github.com/flutter/flutter/issues/174101
 2025-08-28 20:26:49 +00:00
Flutter GitHub Bot
8724b124d5
Marks Linux_mokey complex_layout__start_up to be flaky (#173692) 
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_mokey complex_layout__start_up"
}
-->
Issue link: https://github.com/flutter/flutter/issues/173691
 2025-08-28 20:26:23 +00:00
Flutter GitHub Bot
17ff0c9a05
Marks Linux build_android_host_app_with_module_aar to be flaky (#172631) 
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux build_android_host_app_with_module_aar"
}
-->
Issue link: https://github.com/flutter/flutter/issues/172630
 2025-08-28 20:25:41 +00:00
Flutter GitHub Bot
a0159ba497
Marks Linux_pixel_7pro new_gallery_opengles_impeller__transition_perf to be flaky (#173338) 
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_pixel_7pro
new_gallery_opengles_impeller__transition_perf"
}
-->
Issue link: https://github.com/flutter/flutter/issues/173337
 2025-08-28 20:25:40 +00:00
Flutter GitHub Bot
9ef8d665f5
Marks Linux_pixel_7pro platform_views_scroll_perf_impeller__timeline_summary to be flaky (#172211) 
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_pixel_7pro
platform_views_scroll_perf_impeller__timeline_summary"
}
-->
Issue link: https://github.com/flutter/flutter/issues/172210
 2025-08-28 20:25:40 +00:00
Jason Simmons
d721cabe19
Remove the option to disable the merged platform/UI thread on Android and iOS (#174408) 
See https://github.com/flutter/flutter/issues/150525 for background on
the migration to a merged platform/UI thread.

The merged platform/UI thread model has been the default option for
nearly a year on the Android and iOS platforms and has been successfully
deployed in major applications. Future versions of the Flutter engine
will require the merged thread model, which provides benefits to
embedders such as synchronous calls between the host platform main
thread and Dart isolates.
 2025-08-28 20:01:40 +00:00
Mouad Debbar
2edf7786fc
Don't fail when hot restarting web-server and there are no connected clients (#174600) 
Fixes https://github.com/flutter/flutter/issues/173971
 2025-08-28 19:47:03 +00:00
engine-flutter-autoroll
e3d120bea0
Roll Skia from 7c2fe2629d4a to f3c8b4c677f5 (7 revisions) (#174654) 
https://skia.googlesource.com/skia.git/+log/7c2fe2629d4a..f3c8b4c677f5

2025-08-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms
from a58dfb3b4353 to 7852fc3f0085 (1 revision)
2025-08-28 thomsmit@google.com [graphite] Fixes variable access in
DrawPass
2025-08-28 bungeman@google.com Hack RobotoStatic in SkFontMgr_NDK
2025-08-28 kjlubick@google.com Fix cmake installation in cmake-release
image
2025-08-28 ccameron@chromium.org Reland "HDR v2: Change
SkNamedTransferFn::kHLG/kPQ to new version"
2025-08-28 kjlubick@google.com Add data flow diagram and some
architectural notes for CPU backend
2025-08-28 nicolettep@google.com [graphite] Check for
VK_EXT_layer_settings during test instance creation

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com,kjlubick@google.com,nicolettep@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-28 18:38:07 +00:00
Mouad Debbar
b8cd9aff20
[WebParagraph] More plumbing towards making it usable in Flutter apps (#174587) 
- Introduce a `WebFontCollection`
([copied](a488d104f2/engine/src/flutter/lib/web_ui/lib/src/engine/text/font_collection.dart)
from the HTML renderer with minor tweaks).
- Teach `CkCanvas.drawParagraph` how to draw a `WebParagraph`.
- Remove several text-related features from CanvasKit/Skia that we don't
need anymore.

Part of https://github.com/flutter/flutter/issues/172561

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
 2025-08-28 18:11:28 +00:00
engine-flutter-autoroll
a708ff0fa0
Roll Packages from 86fbeecb7b4f to 141d8e304419 (6 revisions) (#174645) 
86fbeecb7b...141d8e3044

2025-08-28 engine-flutter-autoroll@skia.org Roll Flutter from
c65f01dc373c to da5523afc3c1 (26 revisions) (flutter/packages#9903)
2025-08-28 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump androidx.test.espresso:espresso-core from 3.6.1 to
3.7.0 in /packages/local_auth/local_auth_android/android
(flutter/packages#9916)
2025-08-28 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump androidx.test.espresso:espresso-core from 3.6.1 to
3.7.0 in
/packages/google_maps_flutter/google_maps_flutter_android/android
(flutter/packages#9915)
2025-08-28 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump androidx.test.espresso:espresso-core from 3.6.1 to
3.7.0 in /packages/in_app_purchase/in_app_purchase_android/android
(flutter/packages#9914)
2025-08-27 stuartmorgan@google.com [google_fonts] Initial import
(flutter/packages#9895)
2025-08-27 43054281+camsim99@users.noreply.github.com
[camera_android_camerax] Support NV21 (flutter/packages#9853)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-28 15:54:23 +00:00
Harry Terkelsen
111f5a45f0
[web] Refactor renderers to use the same frontend code (#174588) 
Refactors the renderer code so both renderers (Skwasm and CanvasKit) use
the same SceneBuilder and platform view embedding code. This change is
discussed in a design doc here:
https://flutter.dev/go/web-renderer-unification

Fixes https://github.com/flutter/flutter/issues/172311
Fixes https://github.com/flutter/flutter/issues/172308
Fixes https://github.com/flutter/flutter/issues/142072

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-08-28 15:27:58 +00:00
engine-flutter-autoroll
0628f86a78
Roll Skia from eb000b138a9d to 7c2fe2629d4a (3 revisions) (#174637) 
https://skia.googlesource.com/skia.git/+log/eb000b138a9d..7c2fe2629d4a

2025-08-28 robertphillips@google.com [graphite] Use UniqueKey in
find[OrCreate]GraphicsPipeline
2025-08-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 60607c8e6ce6 to 873473557ae0 (11 revisions)
2025-08-28
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com,kjlubick@google.com,nicolettep@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-28 14:05:40 +00:00
Ben Konyi
a8249b5c1c
[ Tool ] Roll package:dwds 25.0.4 (#174601) 
Fixes https://github.com/flutter/flutter/issues/174437
 2025-08-28 12:02:30 +00:00
engine-flutter-autoroll
8c9ca2315f
Roll Skia from 9b1642f2cfea to eb000b138a9d (2 revisions) (#174627) 
https://skia.googlesource.com/skia.git/+log/9b1642f2cfea..eb000b138a9d

2025-08-28
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-08-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 293e519b21cc to 029eb3459232 (21 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com,kjlubick@google.com,nicolettep@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-28 08:18:30 +00:00
engine-flutter-autoroll
a40e73084f
Roll Skia from 430d60054d66 to 9b1642f2cfea (7 revisions) (#174625) 
https://skia.googlesource.com/skia.git/+log/430d60054d66..9b1642f2cfea

2025-08-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from b99b4f439cf2 to 140a4bc26cef (13 revisions)
2025-08-28
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-08-28 fmalita@google.com Include SkUnicode.h when needed in
FactoryHelpers.h
2025-08-28
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-08-27 bungeman@google.com Ownership for SkFontMgr_Android_Parser
FontFamily
2025-08-27 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
skcms from c602c137fb05 to a58dfb3b4353 (1 revision)
2025-08-27 fmalita@google.com More SkUnicode nextPos16 cleanup

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com,kjlubick@google.com,nicolettep@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-28 06:11:34 +00:00
gaaclarke
b897fb76a0
Refactored Canvas to disallow null inline contexts. (#174530) 
One of the possible explanations for the crash in
https://github.com/flutter/flutter/issues/168210#issuecomment-3130088036
is a null inline pass context. This makes that statically impossible
(barring an allocation problem).

tests: exempt, just a refactor

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-08-28 05:04:17 +00:00
Jim Graham
066982b537
Revert "Check GTK calls are done on the same thread." (#174604) 
Reverts flutter/flutter#174488

It is causing failures in testing:


https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8705343407724739553/+/u/build_ci_host_release_benchmarks_flutter_build_dart:copy_dart_sdk_flutter_display_list:display_list_benchmarks_flutter_display_list:display_list_builder_benchmarks_flutter_display_list:display_list_region_benchmarks_flutter_display_list:display_list_transform_benchmarks_flutter_fml:fml_benchmarks_flutter_impeller_geometry:geometry_benchmarks_flutter_lib_ui:ui_benchmarks_flutter_shell_common:shell_benchmarks_flutter_shell_testing_flutter_txt:txt_benchmarks_flutter_tools_path_ops_flutter_build_archives:flutter_patched_sdk_flutter:unittests/stdout
 2025-08-28 03:42:50 +00:00