10110 Commits

Author SHA1 Message Date
Justin McCandless
9d6883135a
Remove unused context parameter (#124254)
Tidying up the spell check API.
2023-04-18 10:31:05 -07:00
Justin McCandless
39becb7770
iOS spell check cursor placement (#124875)
Fixes the cursor location after selecting a spell check result on iOS.
2023-04-18 10:18:41 -07:00
Tirth
5de716f7f8
[InputDatePickerFormField] adds acceptEmptyDate to InputDatePickerFormField Widget (#124143)
Adds `acceptEmptyDate` property to `InputDatePickerFormField`.

Fixes: #117511

| `acceptEmptyDate` is **false** | `acceptEmptyDate` is **true** |
| --- | ---|
| ![acceptemptydate_false](https://user-images.githubusercontent.com/13456345/229893658-280ecdee-d509-4579-b53c-9d8d485c61b4.gif) | ![acceptemptydate__true](https://user-images.githubusercontent.com/13456345/229895144-115e71bd-e5bb-4653-8db2-9f57dd8262aa.gif) |
2023-04-18 09:33:30 +00:00
Viren Khatri
3ba249a6b3
relayout active ListWheelScrollView children every performLayout (#124476)
during performLayout, active children's constraints were updated, but they weren't laid out again w.r.t their parent (ListWheelScrollView).

Fixes #123497
2023-04-18 05:16:33 +00:00
Kate Lovett
e867d1c686
Add optional axis specifier to static scrollable methods (#124894)
This is motivated by part of the 2D scrolling proposal: [flutter.dev/go/2D-Foundation](https://flutter.dev/go/2D-Foundation)

This is one of the last little PRs to prep for the 2D scrolling foundation. 
This adds an optional `axis` parameter to the static Scrollable methods `[of, maybeOf, recommendDeferredLoadingForContext]`. This allows developers that are nesting scrollables (or one day using 2D scrolling) to look them up instead by a particular axis.

In general, even outside the context of 2D, I think this is helpful. I am often asked how to get the outer scrollable when nesting. Now it can be done.

There is also a small semantic refactor here in ScrollableState.build, this just creates a private method (_buildChrome) that will be overridden in 2D later. It is easier to add now than in the really big PR that will be.
2023-04-18 00:08:07 +00:00
Qun Cheng
6e85113418
Add an example for SearchBar (#124992)
This PR is to: 
* Update API doc for `SearchBar`.
* Add an example to show how to use a `SearchBar` as the builder of the `SearchAnchor`.
2023-04-17 23:23:57 +00:00
chunhtai
cc9ffd3f3b
SelectionContainer's listeners can remove itself during listener call… (#124624)
When swapping out delegate of  selectioncontainer, if the newly passed in delegate doesn't have any selectable content(which is usually the case), the selectioncontainerstate will notify all of the listeners. One of the listener would be SelectionRegistrant._updateSelectionRegistrarSubscription, and since it doesn't have content, it would remove itself from the listener which causes concurrent modification
2023-04-17 23:19:11 +00:00
Taha Tesser
15cb1f84d7
Fix Chip highlight color isn't drawn on top of the background color (#124673) 2023-04-17 13:41:55 -07:00
chunhtai
7424f3448d
Deprecates string for reorderable list in material_localizations (#124711)
deprecates the these strings since they are now moved into widgetslocalizations

migration guide https://github.com/flutter/website/pull/8543/files
2023-04-17 20:03:06 +00:00
hangyu
2f45458e2c
Fix a null crash in SelectableRegion Widget (#124736)
issue #123378
2023-04-17 19:59:06 +00:00
Mubarak Bakarman
df8d819410
Customize color and thickness of connected lines in Stepper.dart (#122485) 2023-04-17 12:52:48 -07:00
Jonah Williams
00495da0b5
Revert "[framework] use shader tiling instead of repeated calls to drawImage" (#124640)
Reverts flutter/flutter#119495

We'll managed to optimize almost all of the cases that made this slow. Actually, it will soon be harder to optimize shader tiling...
2023-04-15 22:04:20 +00:00
Jonah Williams
d1d426e5a8
[cupertino] improve cupertino picker performance by using at most one opacity layer (#124719)
Fixes https://github.com/flutter/flutter/issues/124703

Rather than applying an opacity layer per picker item, apply them to all partially opaque picker items at once. This dramatically improves performance for impeller, by reducing the number of required subpasses and texture allocations signficantly.

Before:
Doesn't finish, 100s of passes

After:

![image](https://user-images.githubusercontent.com/8975114/231569280-91f55c9a-53a5-4b75-8728-59a4dceebe81.png)

![image](https://user-images.githubusercontent.com/8975114/231569309-7c82e5ff-46c7-4f00-80f0-9b4096aa4b14.png)

See also:

https://github.com/flutter/flutter/issues/124658
2023-04-15 22:00:48 +00:00
hangyu
4d6ef78ca5
Add optional labelText and semanticLabel to Checkbox (#124555)
Re-open from https://github.com/flutter/flutter/pull/116551

This PR added optional labelText (which will be  rendered side by side with Checkbox in the future, and thus is also announced by default by screen readers), and semanticLabel(which will be announced by screen reader if provided, overrides labelText, in order to do that we might want to wrap the Text widget inside ExcludeSemantics in the future).

Issues fixed:
[b/239564167]
2023-04-14 22:40:10 +00:00
Justin McCandless
119744a63c
iOS context menu shadow (#122429)
Update the visuals of the iOS context menu to match iOS 16.3.1 more closely.
2023-04-14 10:43:17 -07:00
Tirth
aa8cc44e03
[CupertinoListSection] adds new property separatorColor (#124803)
Adds new property `separatorColor` to `CupertinoListSection` widget.

Fixes: #124744

### `separatorColor` property is null

<img src="https://user-images.githubusercontent.com/13456345/231840875-22605c23-ee9f-464f-a005-c9fce1b641a7.png" width=350>

### `separatorColor` property is not-null

| Color.fromARGB(255, 136, 13, 207) | Color.fromARGB(255, 13, 62, 207) | Color.fromARGB(255, 29, 207, 13) |
| --- | --- | --- |
| ![a](https://user-images.githubusercontent.com/13456345/231840832-6027cf86-e9c0-4206-b6f8-23556471c1bd.png) | ![b](https://user-images.githubusercontent.com/13456345/231840862-dcc30212-14f8-44af-a8cb-d04b22b7a078.png) | ![c](https://user-images.githubusercontent.com/13456345/231840870-d9fafe23-e9a4-423a-a25c-b71835991d07.png) |
2023-04-14 17:19:19 +00:00
Taha Tesser
4c41c0dbcd
Fix CupertinoContextMenu throws exception on route animation (#124785)
Fix `CupertinoContextMenu` throws exception on route animation
2023-04-14 01:59:11 +00:00
Taha Tesser
55dc9f93ea
Refactor SliverAppBar.medium & SliverAppBar.large to fix several issues (#122542)
Refactor `SliverAppBar.medium` & `SliverAppBar.large` to fix several issues
2023-04-13 18:54:08 +00:00
Justin McCandless
62cb61d3f3
Improve the docs around the TextSelectionHandleControls deprecations (#123827)
Explain how to do the two-step migration to the context menus feature.
2023-04-13 10:13:13 -07:00
Justin McCandless
8abeefef91
Localize the 'No Replacements Found' spell check string (#124259)
Localize the 'No Replacements Found' spell check string
2023-04-12 22:15:05 +00:00
Bernardo Ferrari
2e4d976bde
SemanticsFlag/SemanticsAction cleanup (part 4) (#123329)
`SemanticsFlag`/`SemanticsAction` cleanup (part 4)
2023-04-12 19:07:08 +00:00
Nabeel Parkar
6d01ae1377
Bug report 2 issue template (#122385)
Bug report 2 issue template
2023-04-12 11:06:16 +00:00
Bernardo Ferrari
56e4f8e0ff
Add StrokeCap to CircularProgressIndicator (#122664)
Add `StrokeCap` to `CircularProgressIndicator`
2023-04-12 00:35:46 +00:00
Gabriel Gava
ee0b67dd8a
Exposed EdgeDraggingAutoScroller velocityScalar to ReorderableList (#124459)
Exposed EdgeDraggingAutoScroller velocityScalar to ReorderableList
2023-04-12 00:07:20 +00:00
xubaolin
328635b3df
DraggableScrollableSheet & NestedScrollView should respect NeverScrollableScrollPhysics (#123109)
DraggableScrollableSheet & NestedScrollView  should respect NeverScrollableScrollPhysics
2023-04-12 00:01:11 +00:00
Justin McCandless
f5c1fb1d26
Remove deprecations from TextSelectionHandleControls instances (#124611)
Moves to a two-step deprecation process for context menus, avoiding immediate breaking changes.
2023-04-11 16:43:40 -07:00
Chris Bobbe
952ace627f
BottomAppBar: Fix doubled layers of color and shadow (#123294)
Fixes BottomAppBar with translucent colors.
2023-04-11 11:21:13 -07:00
Aditya Thakur
c9f23b0bc2
Fix ShaderMask Example issue (#124511)
Fix ShaderMask Example issue
2023-04-11 18:17:53 +00:00
Tae Hyung Kim
3c18f57480
Sliver Constrained Cross Axis (#124337)
Sliver Constrained Cross Axis
2023-04-10 21:15:48 +00:00
chunhtai
f662f2efe8
ExpansionTile audit (#124281)
ExpansionTile audit
2023-04-10 20:22:54 +00:00
Callum Moffat
535b4d5ec3
Reduce macOS overscroll friction (#122142)
Reduce macOS overscroll friction
2023-04-10 19:34:51 +00:00
joshualitt
191465ac6f
[web] Migrate the bulk of JS interop to JS types. (#123286) 2023-04-10 12:08:26 -07:00
luckysmg
f4cd897e7e
[Text Input] Only unfocus when receive connectionClosed on platform except web (#123929)
[Text Input] Only unfocus when receive connectionClosed on platform except web
2023-04-10 02:09:21 +00:00
Christopher Fujino
3ea2d72446
document StaticIconProvider (#120935)
document StaticIconProvider
2023-04-08 02:45:14 +00:00
Greg Spencer
ba097e2371
Prepare for adding values to AppLifecycleState (#119954)
Prepare for adding values to AppLifecycleState
2023-04-08 02:43:23 +00:00
Bruno Leroux
9f98f63585
Fix InkWell ripple visible on right click when not expected (#124386)
Right clicking an InkWell with no secondary tap handlers will no longer cause a ripple.
2023-04-07 16:02:14 -07:00
chunhtai
e5e765e683
Reland Refactor reorderable list semantics (#124395)
Reland Refactor reorderable list semantics
2023-04-07 17:47:06 +00:00
chunhtai
9884b5f55e
Fixes IgnorePointer and AbsorbPointer to only block user interactions… (#120619)
Fixes IgnorePointer and AbsorbPointer to only block user interactions…
2023-04-07 15:51:05 +00:00
Bruno Leroux
aa6a0a9dea
Fix EditableText misplaces caret when selection is invalid (#123777)
Fix EditableText misplaces caret when selection is invalid
2023-04-07 04:52:30 +00:00
Xilai Zhang
e749db6f91
Revert "Refactor reorderable list semantics" (#124368)
Revert "Refactor reorderable list semantics"
2023-04-07 01:46:06 +00:00
Greg Spencer
692a7efa3f
Initialize ThemeData.visualDensity using ThemeData.platform instead of defaultTargetPlatform (#124357)
Initialize `ThemeData.visualDensity` using `ThemeData.platform` instead of `defaultTargetPlatform`
2023-04-07 01:44:23 +00:00
Henry Riehl
73996ea40b
Add vertical alignment offset to the ``MenuAnchor`` widget when overflowing (#123740)
Positioning of cascading menus.
2023-04-06 16:57:30 -07:00
Michael Goderbauer
9ebd4b49f7
Fix double the (#124236)
Fix double the
2023-04-06 22:29:24 +00:00
chunhtai
94327e7aa8
Refactor reorderable list semantics (#123263)
Refactor reorderable list semantics
2023-04-06 22:01:03 +00:00
Tirth
6338ab1575
[DropdownMenu] add helperText & errorText to DropdownMenu Widget (#123775)
[DropdownMenu] add helperText & errorText to DropdownMenu Widget
2023-04-06 21:33:21 +00:00
Justin McCandless
e4f2d61b5c
TextSelectionHandleControls deprecation deletion timeframe (#124262)
Make sure the removal of deprecated APIs TextSelectionControls.buildToolbar and TextSelectionHandleControls happen in two separate steps.  Will make a tricky migration situation a little easier for affected users.
2023-04-06 14:00:22 -07:00
Ian Hickson
806c1f8186
Deprecate these old APIs (#116793)
Deprecate these old APIs
2023-04-06 19:53:50 +00:00
Gregory Conrad
4fc78b9355
Fix a memory leak in AutomaticKeepAlive (#124163)
Fix a memory leak in `AutomaticKeepAlive`
2023-04-06 18:17:56 +00:00
Tirth
743fcf7fcc
[Docs] Fix Typos (#124249)
[Docs] Fix Typos
2023-04-06 15:43:21 +00:00
Loune Lam
5eb236c3c5
Remove mouse tap text drag selection throttling to improve responsiveness (#123460)
Remove mouse tap text drag selection throttling to improve responsiveness
2023-04-06 13:32:55 +00:00