34425 Commits

Author SHA1 Message Date
Justin McCandless
9d6883135a
Remove unused context parameter (#124254)
Tidying up the spell check API.
2023-04-18 10:31:05 -07:00
Justin McCandless
39becb7770
iOS spell check cursor placement (#124875)
Fixes the cursor location after selecting a spell check result on iOS.
2023-04-18 10:18:41 -07:00
engine-flutter-autoroll
f7245b647e
Roll Flutter Engine from d2973619074e to 55bb065c607b (1 revision) (#125047)
d297361907...55bb065c60

2023-04-18 10456171+caroqliu@users.noreply.github.com [fuchsia] migrate touch-input integration tests to gfx scene manager test ui stack (flutter/engine#41118)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-18 17:06:39 +00:00
Zachary Anderson
c31467f18c
Stop running "_impeller_" benchmark variants (#125044)
Impeller is now the default on iOS, so these are redundant.

In a subsequent change, I'll clean up the source files for these.
2023-04-18 09:54:02 -07:00
engine-flutter-autoroll
a9ffc1666c
Roll Packages from 0277f2ad9d92 to faf53fb3998c (7 revisions) (#125040)
0277f2ad9d...faf53fb399

2023-04-18 engine-flutter-autoroll@skia.org Manual roll Flutter from 50171bbae357 to 15cb1f84d726 (9 revisions) (flutter/packages#3749)
2023-04-17 reidbaker@google.com [palette_generator] run agp update for example (flutter/packages#3747)
2023-04-17 47866232+chunhtai@users.noreply.github.com [go_router] Fixes a bug that go_router would crash if pageBuilder depends on InheritedWidgets.s. (flutter/packages#3714)
2023-04-17 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump com.android.tools.build:gradle from 7.3.1 to 8.0.0 in /packages/pigeon/platform_tests/alternate_language_test_plugin/android (flutter/packages#3727)
2023-04-17 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump com.android.tools.build:gradle from 7.3.1 to 8.0.0 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#3726)
2023-04-17 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump io.mockk:mockk from 1.13.4 to 1.13.5 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#3725)
2023-04-17 stuartmorgan@google.com [tool] Add initial gradle validation command (flutter/packages#3715)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-18 16:06:15 +00:00
engine-flutter-autoroll
ec02eb35ad
Roll Flutter Engine from c4396f9f602f to d2973619074e (6 revisions) (#125039)
c4396f9f60...d297361907

2023-04-18 leroux_bruno@yahoo.fr [macOS] Fix Ctrl+Tab is broken
(flutter/engine#40706)
2023-04-18 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
K1LGtKXyxRlW3Q9O1... to qZHSvkpAU1-YYGvYc... (flutter/engine#41293)
2023-04-18 aam@google.com Roll buildroot to
059d155b4d452efd9c4427c45cddfd9445144869 (flutter/engine#41288)
2023-04-18 bdero@google.com [Impeller] Remove glyph pixel rounding
during text frame conversion (flutter/engine#41285)
2023-04-18 godofredoc@google.com Revert "Reland "Migrate mac_host_engine
to engine v2 builds."" (flutter/engine#41284)
2023-04-17 flar@google.com focus SkiaGPUObject wrappers on only those
objects that need the protection (flutter/engine#41237)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from K1LGtKXyxRlW to qZHSvkpAU1-Y

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-18 08:58:21 -07:00
Flutter GitHub Bot
b0346b2953
Roll pub packages (#125005)
This PR was generated by `flutter update-packages --force-upgrade`.
2023-04-18 13:35:36 +00:00
Tirth
5de716f7f8
[InputDatePickerFormField] adds acceptEmptyDate to InputDatePickerFormField Widget (#124143)
Adds `acceptEmptyDate` property to `InputDatePickerFormField`.

Fixes: #117511

| `acceptEmptyDate` is **false** | `acceptEmptyDate` is **true** |
| --- | ---|
| ![acceptemptydate_false](https://user-images.githubusercontent.com/13456345/229893658-280ecdee-d509-4579-b53c-9d8d485c61b4.gif) | ![acceptemptydate__true](https://user-images.githubusercontent.com/13456345/229895144-115e71bd-e5bb-4653-8db2-9f57dd8262aa.gif) |
2023-04-18 09:33:30 +00:00
Viren Khatri
3ba249a6b3
relayout active ListWheelScrollView children every performLayout (#124476)
during performLayout, active children's constraints were updated, but they weren't laid out again w.r.t their parent (ListWheelScrollView).

Fixes #123497
2023-04-18 05:16:33 +00:00
engine-flutter-autoroll
4075503489
Roll Flutter Engine from 4a603aaff32e to c4396f9f602f (2 revisions) (#125007)
4a603aaff3...c4396f9f60

2023-04-17 zanderso@users.noreply.github.com Roll impeller-cmake-example to 58042bb24833a3cbd615ad082b1d17daef42d097 (flutter/engine#41280)
2023-04-17 jacksongardner@google.com Reland ui_web files in sky_engine (flutter/engine#41169)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-18 01:17:14 +00:00
engine-flutter-autoroll
9cc5f5558a
Roll Flutter Engine from 20034a8d62c4 to 4a603aaff32e (2 revisions) (#125004)
20034a8d62...4a603aaff3

2023-04-17 magder@google.com Remove 'Mac mac_unopt' in favor of Linux (flutter/engine#41226)
2023-04-17 chinmaygarde@google.com [Impeller] Add debug ToString methods to render targets. (flutter/engine#41221)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-18 00:15:14 +00:00
Kate Lovett
e867d1c686
Add optional axis specifier to static scrollable methods (#124894)
This is motivated by part of the 2D scrolling proposal: [flutter.dev/go/2D-Foundation](https://flutter.dev/go/2D-Foundation)

This is one of the last little PRs to prep for the 2D scrolling foundation. 
This adds an optional `axis` parameter to the static Scrollable methods `[of, maybeOf, recommendDeferredLoadingForContext]`. This allows developers that are nesting scrollables (or one day using 2D scrolling) to look them up instead by a particular axis.

In general, even outside the context of 2D, I think this is helpful. I am often asked how to get the outer scrollable when nesting. Now it can be done.

There is also a small semantic refactor here in ScrollableState.build, this just creates a private method (_buildChrome) that will be overridden in 2D later. It is easier to add now than in the really big PR that will be.
2023-04-18 00:08:07 +00:00
Bartek Pacia
e99eb40222
Update usage of standalonepub executable in flutter_tools testing docs (#124898)
Just found this while trying to run the integration test shard of `flutter_tools` locally :)
2023-04-17 23:34:23 +00:00
Harish Anbalagan
0ac1813b16
Add Harish Anbalagan to AUTHORS (#124684)
Adding my name (Harish Anbalagan) to Authors.
2023-04-17 23:29:03 +00:00
engine-flutter-autoroll
67a84e6c87
Roll Flutter Engine from b2d07388ceb6 to 20034a8d62c4 (7 revisions) (#125001)
b2d07388ce...20034a8d62

2023-04-17 godofredoc@google.com Reland  "Migrate mac_host_engine to engine v2 builds." (flutter/engine#41279)
2023-04-17 41930132+hellohuanlin@users.noreply.github.com [rotation_distortion] Use "delayed swap" solution to reduce rotation distortion (flutter/engine#40730)
2023-04-17 akash.mercer@gmail.com null check added to avoid NPE while calling FlutterView.detachFromFlutterEngine() (flutter/engine#41082)
2023-04-17 5236035+fzyzcjy@users.noreply.github.com [Impeller] Make `DoMakeRasterSnapshot` output timeline event. (flutter/engine#41197)
2023-04-17 bdero@google.com [Impeller] Remove ContentContextOptions declarations from AnonymousContents (flutter/engine#41256)
2023-04-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 786a70d8ef6b to a335e6724332 (1 revision) (flutter/engine#41278)
2023-04-17 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from atix5Ek_OOxH-uoPA... to Cy5LG4U2InaFLkJGz... (flutter/engine#41275)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from atix5Ek_OOxH to Cy5LG4U2InaF

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-17 23:24:00 +00:00
Qun Cheng
6e85113418
Add an example for SearchBar (#124992)
This PR is to: 
* Update API doc for `SearchBar`.
* Add an example to show how to use a `SearchBar` as the builder of the `SearchAnchor`.
2023-04-17 23:23:57 +00:00
chunhtai
cc9ffd3f3b
SelectionContainer's listeners can remove itself during listener call… (#124624)
When swapping out delegate of  selectioncontainer, if the newly passed in delegate doesn't have any selectable content(which is usually the case), the selectioncontainerstate will notify all of the listeners. One of the listener would be SelectionRegistrant._updateSelectionRegistrarSubscription, and since it doesn't have content, it would remove itself from the listener which causes concurrent modification
2023-04-17 23:19:11 +00:00
Taha Tesser
15cb1f84d7
Fix Chip highlight color isn't drawn on top of the background color (#124673) 2023-04-17 13:41:55 -07:00
chunhtai
7424f3448d
Deprecates string for reorderable list in material_localizations (#124711)
deprecates the these strings since they are now moved into widgetslocalizations

migration guide https://github.com/flutter/website/pull/8543/files
2023-04-17 20:03:06 +00:00
hangyu
2f45458e2c
Fix a null crash in SelectableRegion Widget (#124736)
issue #123378
2023-04-17 19:59:06 +00:00
Mubarak Bakarman
df8d819410
Customize color and thickness of connected lines in Stepper.dart (#122485) 2023-04-17 12:52:48 -07:00
engine-flutter-autoroll
53f31c7c06
Roll Flutter Engine from 30e1c4308213 to b2d07388ceb6 (7 revisions) (#124987)
30e1c43082...b2d07388ce

2023-04-17 30870216+gaaclarke@users.noreply.github.com Adds AndroidSurfaceGLImpeller unit tests (flutter/engine#40979)
2023-04-17 yjbanov@google.com [web:canvaskit] migrate Paint API to UniqueRef (flutter/engine#41230)
2023-04-17 kjlubick@users.noreply.github.com Migrate uses of deprecated SkImage->encodeToData (flutter/engine#41204)
2023-04-17 skia-flutter-autoroll@skia.org Roll Skia from 962800967591 to d9e216e62223 (1 revision) (flutter/engine#41270)
2023-04-17 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from xPacy_rLieLS05d_g... to K1LGtKXyxRlW3Q9O1... (flutter/engine#41271)
2023-04-17 skia-flutter-autoroll@skia.org Roll Skia from 82665485077b to 962800967591 (1 revision) (flutter/engine#41267)
2023-04-17 skia-flutter-autoroll@skia.org Roll Skia from 5c4d2a518736 to 82665485077b (2 revisions) (flutter/engine#41266)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from xPacy_rLieLS to K1LGtKXyxRlW

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-17 19:36:29 +00:00
godofredoc
8bbe71787a
Remove token permissions for coverage. (#124909)
The coverage build does not require write access to checks.
2023-04-17 17:31:30 +00:00
engine-flutter-autoroll
c368d64d88
Roll Packages from e4ec15590935 to 0277f2ad9d92 (9 revisions) (#124972)
e4ec155909...0277f2ad9d

2023-04-16 engine-flutter-autoroll@skia.org Roll Flutter from 00171b07130e to 50171bbae357 (7 revisions) (flutter/packages#3723)
2023-04-15 engine-flutter-autoroll@skia.org Roll Flutter from f74054467bed to 00171b07130e (17 revisions) (flutter/packages#3717)
2023-04-15 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.2.9 to 2.2.12 (flutter/packages#3711)
2023-04-15 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.5.0 to 3.5.2 (flutter/packages#3710)
2023-04-14 stuartmorgan@google.com [path_provider] Fix Android lint warnings (flutter/packages#3706)
2023-04-14 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android] [camera_android_camerax] Updates internal Java InstanceManager to only stop finalization callbacks when stopped (flutter/packages#3571)
2023-04-14 stuartmorgan@google.com [shared_preferences] Fix Android Java version issue (flutter/packages#3712)
2023-04-14 48185017+andreisas06@users.noreply.github.com [image_picker][android] Non-bitmap images now return path instead of null (flutter/packages#3590)
2023-04-14 engine-flutter-autoroll@skia.org Roll Flutter from be45eb2420b2 to f74054467bed (24 revisions) (flutter/packages#3713)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-17 15:51:25 +00:00
engine-flutter-autoroll
bfd92a8619
Roll Flutter Engine from 360ca05311c8 to 30e1c4308213 (3 revisions) (#124963)
360ca05311...30e1c43082

2023-04-17 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.5.0 to 3.5.2 (flutter/engine#41264)
2023-04-17 skia-flutter-autoroll@skia.org Roll Skia from a64c248e62e0 to 5c4d2a518736 (1 revision) (flutter/engine#41262)
2023-04-17 skia-flutter-autoroll@skia.org Roll Skia from 03c8e529196d to a64c248e62e0 (1 revision) (flutter/engine#41261)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-17 11:10:32 +00:00
engine-flutter-autoroll
858d4ff634
Roll Flutter Engine from 4a998b73a2df to 360ca05311c8 (2 revisions) (#124952)
4a998b73a2...360ca05311

2023-04-17 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from AAx6fLy6ykWVhXvNh... to xPacy_rLieLS05d_g... (flutter/engine#41260)
2023-04-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 46T4ZTAt48yPRDEn5... to atix5Ek_OOxH-uoPA... (flutter/engine#41258)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 46T4ZTAt48yP to atix5Ek_OOxH
  fuchsia/sdk/core/mac-amd64 from AAx6fLy6ykWV to xPacy_rLieLS

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3.10.0-6.0.pre
2023-04-17 03:21:38 +00:00
engine-flutter-autoroll
50171bbae3
Roll Flutter Engine from da0805a9cf03 to 4a998b73a2df (5 revisions) (#124944)
da0805a9cf...4a998b73a2

2023-04-16 skia-flutter-autoroll@skia.org Roll Skia from cc3404330d3b to 03c8e529196d (1 revision) (flutter/engine#41255)
2023-04-16 skia-flutter-autoroll@skia.org Roll Skia from 2d0b05335104 to cc3404330d3b (1 revision) (flutter/engine#41254)
2023-04-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from hacWN-gQSoWudziIS... to 46T4ZTAt48yPRDEn5... (flutter/engine#41253)
2023-04-16 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from gI2knJ4Rh0yoK4Syd... to AAx6fLy6ykWVhXvNh... (flutter/engine#41252)
2023-04-16 bdero@google.com [Impeller] Add offscreen texture checkerboarding (flutter/engine#41199)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from hacWN-gQSoWu to 46T4ZTAt48yP
  fuchsia/sdk/core/mac-amd64 from gI2knJ4Rh0yo to AAx6fLy6ykWV

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-16 17:37:40 +00:00
engine-flutter-autoroll
2d57261069
Roll Flutter Engine from feb476b7b991 to da0805a9cf03 (4 revisions) (#124933)
feb476b7b9...da0805a9cf

2023-04-15 skia-flutter-autoroll@skia.org Roll Skia from 2a4d95762651 to 2d0b05335104 (1 revision) (flutter/engine#41250)
2023-04-15 jonahwilliams@google.com [Impeller] add a generic porter duff blend foreground shader. (flutter/engine#41098)
2023-04-15 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Y_tD90hDX_jiubGbC... to hacWN-gQSoWudziIS... (flutter/engine#41248)
2023-04-15 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from RFyPoDrXzIiy-E3wn... to gI2knJ4Rh0yoK4Syd... (flutter/engine#41249)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from Y_tD90hDX_ji to hacWN-gQSoWu
  fuchsia/sdk/core/mac-amd64 from RFyPoDrXzIiy to gI2knJ4Rh0yo

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-16 00:34:24 +00:00
engine-flutter-autoroll
d8a916f232
Roll Flutter Engine from ee66f0d6f2c9 to feb476b7b991 (2 revisions) (#124929)
ee66f0d6f2...feb476b7b9

2023-04-15 skia-flutter-autoroll@skia.org Roll Skia from cf580fd68a21 to 2a4d95762651 (2 revisions) (flutter/engine#41247)
2023-04-15 skia-flutter-autoroll@skia.org Roll Dart SDK from eb26d88d7f58 to 786a70d8ef6b (1 revision) (flutter/engine#41245)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-15 22:32:13 +00:00
Jonah Williams
00495da0b5
Revert "[framework] use shader tiling instead of repeated calls to drawImage" (#124640)
Reverts flutter/flutter#119495

We'll managed to optimize almost all of the cases that made this slow. Actually, it will soon be harder to optimize shader tiling...
2023-04-15 22:04:20 +00:00
Jonah Williams
d1d426e5a8
[cupertino] improve cupertino picker performance by using at most one opacity layer (#124719)
Fixes https://github.com/flutter/flutter/issues/124703

Rather than applying an opacity layer per picker item, apply them to all partially opaque picker items at once. This dramatically improves performance for impeller, by reducing the number of required subpasses and texture allocations signficantly.

Before:
Doesn't finish, 100s of passes

After:

![image](https://user-images.githubusercontent.com/8975114/231569280-91f55c9a-53a5-4b75-8728-59a4dceebe81.png)

![image](https://user-images.githubusercontent.com/8975114/231569309-7c82e5ff-46c7-4f00-80f0-9b4096aa4b14.png)

See also:

https://github.com/flutter/flutter/issues/124658
2023-04-15 22:00:48 +00:00
Andrew Kolos
68ec71f46c
[flutter_tools] Remove Version.unknown (#124771)
Fixes #124756 by removing the concept of `Version.unknown`.

`Version` fields that needed the ability to represent an unknown version have been made nullable. Assigning `null` to them represents an unknown version.
2023-04-15 19:56:41 +00:00
engine-flutter-autoroll
4543766a10
Roll Flutter Engine from 41c1ea9a8283 to ee66f0d6f2c9 (2 revisions) (#124923)
41c1ea9a82...ee66f0d6f2

2023-04-15 skia-flutter-autoroll@skia.org Roll Skia from f489b4a06e19 to cf580fd68a21 (3 revisions) (flutter/engine#41244)
2023-04-15 skia-flutter-autoroll@skia.org Roll Dart SDK from afb0adeca5b6 to eb26d88d7f58 (1 revision) (flutter/engine#41241)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-15 16:54:35 +00:00
engine-flutter-autoroll
00171b0713
Roll Flutter Engine from f24e37bb4d9e to 41c1ea9a8283 (1 revision) (#124916)
f24e37bb4d...41c1ea9a82

2023-04-15 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from wL-3zhH7VC1ugMJUN... to RFyPoDrXzIiy-E3wn... (flutter/engine#41240)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from wL-3zhH7VC1u to RFyPoDrXzIiy

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-15 10:38:23 +00:00
engine-flutter-autoroll
d0d02cbd12
Roll Flutter Engine from f6e64a87407f to f24e37bb4d9e (2 revisions) (#124914)
f6e64a8740...f24e37bb4d

2023-04-15 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Z0of2S9pf3Zn1nsJP... to Y_tD90hDX_jiubGbC... (flutter/engine#41238)
2023-04-15 magder@google.com Remove jazzy and Xcode properties from impeller-cmake-example builder (flutter/engine#41222)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from Z0of2S9pf3Zn to Y_tD90hDX_ji

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-15 09:52:38 +00:00
engine-flutter-autoroll
7975257c7a
Roll Flutter Engine from c8d84cf3b761 to f6e64a87407f (2 revisions) (#124913)
c8d84cf3b7...f6e64a8740

2023-04-15 godofredoc@google.com Revert "Migrate mac_host_engine to engine v2 builds." (flutter/engine#41233)
2023-04-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 5687f08b854d to afb0adeca5b6 (2 revisions) (flutter/engine#41232)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-15 04:35:29 +00:00
engine-flutter-autoroll
e1642bafbd
Roll Flutter Engine from 4552a6e105f1 to c8d84cf3b761 (1 revision) (#124907)
4552a6e105...c8d84cf3b7

2023-04-15 chris@bracken.jp [macOS] Fix arm64 floating-point test failure (flutter/engine#41228)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-15 03:19:35 +00:00
engine-flutter-autoroll
f89caf7caf
Roll Flutter Engine from 0a5ed019cea5 to 4552a6e105f1 (1 revision) (#124904)
0a5ed019ce...4552a6e105

2023-04-15 godofredoc@google.com Do not run clang tidy on recipes cq. (flutter/engine#41227)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-15 02:13:32 +00:00
engine-flutter-autoroll
016bcc1000
Roll Flutter Engine from f7945293aced to 0a5ed019cea5 (2 revisions) (#124901)
f7945293ac...0a5ed019ce

2023-04-14 skia-flutter-autoroll@skia.org Roll Skia from 22e417bea884 to f489b4a06e19 (6 revisions) (flutter/engine#41225)
2023-04-14 skia-flutter-autoroll@skia.org Roll Dart SDK from 36b37d0a8db7 to 5687f08b854d (1 revision) (flutter/engine#41224)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-15 01:21:26 +00:00
engine-flutter-autoroll
c40eed10b1
Roll Flutter Engine from e9739bca5c66 to f7945293aced (5 revisions) (#124900)
e9739bca5c...f7945293ac

2023-04-14 magder@google.com Change v2 `mac_unopt` orchestrator builder to Linux (flutter/engine#41184)
2023-04-14 zanderso@users.noreply.github.com Specify allowed Macmini models (flutter/engine#41219)
2023-04-14 godofredoc@google.com Migrate mac_host_engine to engine v2 builds. (flutter/engine#41149)
2023-04-14 magder@google.com Remove cores dimension from Mac Host clang-tidy (flutter/engine#41214)
2023-04-14 magder@google.com Run mac_host_engine orchestrator on arm Macs (flutter/engine#41185)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-15 00:21:24 +00:00
engine-flutter-autoroll
2f36100ef4
Roll Flutter Engine from 413e95d1e22d to e9739bca5c66 (7 revisions) (#124896)
413e95d1e2...e9739bca5c

2023-04-14 chris@bracken.jp [macOS] Build unittests on all macOS host builds (flutter/engine#41215)
2023-04-14 mdebbar@google.com [web] Don't run goldctl init more than once (flutter/engine#41207)
2023-04-14 skia-flutter-autoroll@skia.org Roll Skia from 2bd12e31d578 to 22e417bea884 (4 revisions) (flutter/engine#41213)
2023-04-14 chillers@google.com Revert "[Android] Send connectionClosed message when keyboard becomes invisible to ensure framework focus state is correct." (flutter/engine#41211)
2023-04-14 magder@google.com Remove `Mac mac_android_aot_engine` in favor of Linux (flutter/engine#41210)
2023-04-14 magder@google.com Run clang tidy builds on arm Macs (flutter/engine#41183)
2023-04-14 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from diD1gLr_dKWFJlsSn... to Z0of2S9pf3Zn1nsJP... (flutter/engine#41209)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from diD1gLr_dKWF to Z0of2S9pf3Zn

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-14 22:59:37 +00:00
hangyu
4d6ef78ca5
Add optional labelText and semanticLabel to Checkbox (#124555)
Re-open from https://github.com/flutter/flutter/pull/116551

This PR added optional labelText (which will be  rendered side by side with Checkbox in the future, and thus is also announced by default by screen readers), and semanticLabel(which will be announced by screen reader if provided, overrides labelText, in order to do that we might want to wrap the Text widget inside ExcludeSemantics in the future).

Issues fixed:
[b/239564167]
2023-04-14 22:40:10 +00:00
engine-flutter-autoroll
094bd85845
Roll Flutter Engine from 9c314065c852 to 413e95d1e22d (1 revision) (#124892)
9c314065c8...413e95d1e2

2023-04-14 skia-flutter-autoroll@skia.org Roll Dart SDK from 0150b91de0b0 to 36b37d0a8db7 (2 revisions) (flutter/engine#41208)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-14 21:56:07 +00:00
engine-flutter-autoroll
0a834beb67
Roll Flutter Engine from 87fc46430e1d to 9c314065c852 (5 revisions) (#124886)
87fc46430e...9c314065c8

2023-04-14 zanderso@users.noreply.github.com Run the Mac impeller-cmake-example orchestrator on arm64 (flutter/engine#41194)
2023-04-14 chinmaygarde@google.com Fix warning about angle_build_all being unread on Mac builds. (flutter/engine#41176)
2023-04-14 magder@google.com Change v2 `mac_android_aot_engine` orchestrator builder to Linux (flutter/engine#41181)
2023-04-14 zanderso@users.noreply.github.com Do not run mac unit tests on macmini7,1 (flutter/engine#41203)
2023-04-14 skia-flutter-autoroll@skia.org Manual roll Skia from ad2e21650306 to 2bd12e31d578 (14 revisions) (flutter/engine#41206)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-14 20:45:02 +00:00
engine-flutter-autoroll
5a8ce8f4cb
Roll Flutter Engine from ea0e1b17006c to 87fc46430e1d (1 revision) (#124878)
ea0e1b1700...87fc46430e

2023-04-14 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from fRDyjjf-0gc4uVHv7... to wL-3zhH7VC1ugMJUN... (flutter/engine#41205)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from fRDyjjf-0gc4 to wL-3zhH7VC1u

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-14 19:36:22 +00:00
Justin McCandless
119744a63c
iOS context menu shadow (#122429)
Update the visuals of the iOS context menu to match iOS 16.3.1 more closely.
2023-04-14 10:43:17 -07:00
engine-flutter-autoroll
b95cd931ae
Roll Flutter Engine from 4b96e38c9275 to ea0e1b17006c (1 revision) (#124867)
4b96e38c92...ea0e1b1700

2023-04-14 skia-flutter-autoroll@skia.org Manual roll Skia from 2e4223a5f4bf to ad2e21650306 (16 revisions) (flutter/engine#41195)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-14 17:20:49 +00:00
Jackson Gardner
2269dc10b3
Add option to run wasm-opt on module output. (#124831)
This fixes https://github.com/flutter/flutter/issues/124159

Adds the command line argument `--wasm-opt` to optimize the web assembly output.
2023-04-14 17:19:21 +00:00
Tirth
aa8cc44e03
[CupertinoListSection] adds new property separatorColor (#124803)
Adds new property `separatorColor` to `CupertinoListSection` widget.

Fixes: #124744

### `separatorColor` property is null

<img src="https://user-images.githubusercontent.com/13456345/231840875-22605c23-ee9f-464f-a005-c9fce1b641a7.png" width=350>

### `separatorColor` property is not-null

| Color.fromARGB(255, 136, 13, 207) | Color.fromARGB(255, 13, 62, 207) | Color.fromARGB(255, 29, 207, 13) |
| --- | --- | --- |
| ![a](https://user-images.githubusercontent.com/13456345/231840832-6027cf86-e9c0-4206-b6f8-23556471c1bd.png) | ![b](https://user-images.githubusercontent.com/13456345/231840862-dcc30212-14f8-44af-a8cb-d04b22b7a078.png) | ![c](https://user-images.githubusercontent.com/13456345/231840870-d9fafe23-e9a4-423a-a25c-b71835991d07.png) |
2023-04-14 17:19:19 +00:00
engine-flutter-autoroll
5dbab86676
Roll Packages from d01f4eaabb54 to e4ec15590935 (5 revisions) (#124863)
d01f4eaabb...e4ec155909

2023-04-14 stuartmorgan@google.com [shared_preferences] Remove Android lint baseline (flutter/packages#3707)
2023-04-13 37607224+AmanNegi@users.noreply.github.com [shared_preferences] Ports SharedPreferencesAndroid to Pigeon (flutter/packages#3321)
2023-04-13 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android] Fix Android lint warnings (flutter/packages#3675)
2023-04-13 gautier.bayzelon@gmail.com [go_router_builder] Use only one .where() (flutter/packages#3698)
2023-04-13 engine-flutter-autoroll@skia.org Roll Flutter from 3b4b14919173 to be45eb2420b2 (21 revisions) (flutter/packages#3701)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-14 16:01:07 +00:00