Justin McCandless
98aaf00a09
Fix the position of the Android-style spell check toolbar ( #124897 )
...
The spell check menu now appears directly below the misspelled word on Android.
2023-04-24 10:26:47 -07:00
engine-flutter-autoroll
3ab8cd2615
Roll Flutter Engine from fcf46af2d38c to 5fbde6c0fc57 (4 revisions) ( #125410 )
...
fcf46af2d3...5fbde6c0fcflutter/engine#41444 )
2023-04-24 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from kZQW1hC63MessR4gl... to EEdHfWcEn3fHwQj46... (flutter/engine#41441 )
2023-04-24 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 1RnHwa4NRXqe4iS6H... to fJ7ysM-O4VYAGeBDc... (flutter/engine#41440 )
2023-04-23 skia-flutter-autoroll@skia.org Roll Skia from b9c90858cdd8 to 1f84e5060646 (1 revision) (flutter/engine#41432 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 1RnHwa4NRXqe to fJ7ysM-O4VYA
fuchsia/sdk/core/mac-amd64 from kZQW1hC63Mes to EEdHfWcEn3fH
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-24 14:49:13 +00:00
Kevin Chisholm
a00babf47b
[Process] Update cherry-pick template assignees ( #125402 )
...
Updates the cherry-pick template to add @itsjustkevin as primary and
@CaseyHillers as secondary assignees to all cherry-pick requests.
2023-04-24 07:10:03 -07:00
engine-flutter-autoroll
60077ff979
Roll Flutter Engine from 0e329d5e2196 to fcf46af2d38c (1 revision) ( #125384 )
...
0e329d5e21...fcf46af2d3skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from KWUhrqWF9DaVpikxZ... to kZQW1hC63MessR4gl... (flutter/engine#41430 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from KWUhrqWF9DaV to kZQW1hC63Mes
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-23 11:09:16 +00:00
engine-flutter-autoroll
e4b2a5abdc
Roll Flutter Engine from f364492e2010 to 0e329d5e2196 (1 revision) ( #125381 )
...
f364492e20...0e329d5e21skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from I9z-K7N5PdhXN-5SG... to 1RnHwa4NRXqe4iS6H... (flutter/engine#41428 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from I9z-K7N5PdhX to 1RnHwa4NRXqe
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-23 08:03:36 +00:00
engine-flutter-autoroll
6382136e1f
Roll Flutter Engine from b6749106a482 to f364492e2010 (7 revisions) ( #125378 )
...
b6749106a4...f364492e20skia-flutter-autoroll@skia.org Roll Dart SDK from fd4797c1464b to a1c1e0d3bb18 (1 revision) (flutter/engine#41427 )
2023-04-22 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from qLDaxNMysjqL-IcPn... to KWUhrqWF9DaVpikxZ... (flutter/engine#41426 )
2023-04-22 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from RdOaZ2-aDsn_64hk5... to I9z-K7N5PdhXN-5SG... (flutter/engine#41424 )
2023-04-22 skia-flutter-autoroll@skia.org Roll Dart SDK from be6db2b60a41 to fd4797c1464b (2 revisions) (flutter/engine#41422 )
2023-04-22 skia-flutter-autoroll@skia.org Roll Skia from 9912500bcca3 to b9c90858cdd8 (2 revisions) (flutter/engine#41421 )
2023-04-22 skia-flutter-autoroll@skia.org Roll Dart SDK from b6de2d42e58d to be6db2b60a41 (2 revisions) (flutter/engine#41416 )
2023-04-22 skia-flutter-autoroll@skia.org Roll Skia from 36a6690cd1f1 to 9912500bcca3 (2 revisions) (flutter/engine#41415 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from RdOaZ2-aDsn_ to I9z-K7N5PdhX
fuchsia/sdk/core/mac-amd64 from qLDaxNMysjqL to KWUhrqWF9DaV
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-23 04:41:22 +00:00
engine-flutter-autoroll
d2646cf87d
Roll Flutter Engine from d96a09559ebf to b6749106a482 (2 revisions) ( #125350 )
...
d96a09559e...b6749106a4skia-flutter-autoroll@skia.org Roll Skia from aa592c60846d to 36a6690cd1f1 (11 revisions) (flutter/engine#41413 )
2023-04-22 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from fMOcI5zn1z0nOrV7s... to qLDaxNMysjqL-IcPn... (flutter/engine#41412 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from fMOcI5zn1z0n to qLDaxNMysjqL
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-22 03:06:17 +00:00
Nabeel Parkar
1c56c565f5
Migrate new feature issue template to GitHub forms ( #123682 )
...
Fixes https://github.com/flutter/flutter/issues/119919
<details>
<summary>Preview</summary>
</details>
2023-04-22 02:40:20 +00:00
Callum Moffat
e84daf3b70
Adjust selection rects inclusion criteria ( #125022 )
...
Include rects with any overlap instead of only when top-left or bottom-right included. The previous criteria didn't send any selection rects when text was taller than the text box and scroll offset was not zero.
Part of #30476
2023-04-22 01:40:20 +00:00
Nate Bosch
1789a4244b
Remove some ignores for un-deprecated imports ( #125261 )
...
The latest version of `test_api` removed the deprecated annotation for a couple libraries. The deprecations had been a hack to avoid usage from inappropriate places, but they cause trouble and likely weren't effective for that goal.
Remove separate import for `registerException` since that was also moved to be available from the top level `scaffolding.dart` library.
2023-04-22 01:04:24 +00:00
engine-flutter-autoroll
dff451ece6
Roll Flutter Engine from 462e9bbb8469 to d96a09559ebf (5 revisions) ( #125346 )
...
462e9bbb84...d96a09559eskia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Edv0I0o8GQ7c0z8XK... to RdOaZ2-aDsn_64hk5... (flutter/engine#41407 )
2023-04-21 skia-flutter-autoroll@skia.org Roll Dart SDK from fabaeef00dfb to b6de2d42e58d (2 revisions) (flutter/engine#41401 )
2023-04-21 jason-simmons@users.noreply.github.com [Impeller] Add a CommandBuffer::WaitUntilScheduled API (flutter/engine#41303 )
2023-04-21 30870216+gaaclarke@users.noreply.github.com [Impeller] Turned off the TextRotated golden test again (flutter/engine#41399 )
2023-04-21 skia-flutter-autoroll@skia.org Roll Skia from 5754b81988b8 to aa592c60846d (11 revisions) (flutter/engine#41398 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Edv0I0o8GQ7c to RdOaZ2-aDsn_
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-22 00:54:14 +00:00
Kevin Moore
702f0144e0
[tool,web] track web-renderer, and Wasm build args in analytics ( #125336 )
...
Addresses part of https://github.com/flutter/flutter/issues/125164
2023-04-21 23:09:00 +00:00
Luccas Clezar
f86b9220a3
Update Cupertino desktop text selection toolbar ( #121829 )
...
Visual fidelity of the right-click context menu on MacOS.
2023-04-21 16:03:34 -07:00
chunhtai
8a815c1d1d
Remove unecessary reference to ClipboardStatusNotifier ( #125255 )
...
fixes https://github.com/flutter/flutter/issues/99360
2023-04-21 22:38:06 +00:00
Jenn Magder
baafa1991d
Combine flutter_tool_startup devicelab tests ( #125226 )
...
`flutter_tool_startup__windows/linux/macos` were identical. Use the same task for all three.
2023-04-21 22:33:07 +00:00
Jenn Magder
a2c247117b
Remove self from CODEOWNERS ( #125337 )
...
Remove self from `CODEOWNERS` file for `flutter_tools`. Now that we have the PR cocoon labeler the tools team should see any PRs that change these files, and tag the right people to review.
Also remove ownership of the `CODEOWNERS` file itself.
2023-04-21 22:33:05 +00:00
Jenn Magder
152f160508
Swap bundler dependabot reviewers ( #125333 )
...
Remove myself as a the CocoaPods gem [dependabot](https://github.blog/2020-06-01-keep-all-your-packages-up-to-date-with-dependabot/ ) reviewer and add @christopherfujino and @vashworth instead for Ruby gem bumps:
3a436f47f5/dev/ci/mac/Gemfilehttps://github.com/flutter/flutter/pulls?q=is%3Apr+dependabot+cocoapods+is%3Aclosed
Note the last minor version was ignored https://github.com/flutter/flutter/pull/122051 due to https://github.com/flutter/flutter/issues/122057 .
We have pretty good plugins/CocoaPods test coverage, so if that infra issue were fixed we should feel pretty safe about bumping this if all the tests pass.
2023-04-21 22:26:18 +00:00
Christopher Fujino
1561b65812
add gradle error handler for when the remote ssl host terminates handshake process ( #125270 )
...
Will fix transient network failures as in: https://github.com/flutter/flutter/issues/125108#issuecomment-1516519929
2023-04-21 21:59:10 +00:00
Hugo
d93ffc10c4
Fix the divider_theme space documentation problem ( #125195 )
...
In the specific implementation, the Divider uses the "space" field as the height for horizontal dividers, and the "space" field as the width for VerticalDivider , which is different from the documentation description.
2023-04-21 21:59:08 +00:00
Polina Cherkasova
3a436f47f5
Upgrade leak_tracker. ( #125272 )
2023-04-21 13:49:23 -07:00
engine-flutter-autoroll
d727aaf2e1
Roll Flutter Engine from dd67063fc921 to 462e9bbb8469 (3 revisions) ( #125324 )
...
dd67063fc9...462e9bbb8430870216+gaaclarke@users.noreply.github.com [impeller] fixed flake where blit wasn't tracking its texture (flutter/engine#41347 )
2023-04-21 121665385+andoriyaprashant@users.noreply.github.com removing the check_gn_format.py file from ci/ (flutter/engine#41397 )
2023-04-21 ditman@gmail.com [web] Fix HashUrlStrategy.addPopStateListener (flutter/engine#41384 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-21 19:31:38 +00:00
Greg Spencer
11f8ee5bb0
Add docs for kIsWeb on defaultTargetPlatform ( #125313 )
...
## Description
Adding some see also links to connect `defaultTargetPlatform` and `kIsWeb` docs.
2023-04-21 19:11:29 +00:00
engine-flutter-autoroll
c9004ff822
Roll Flutter Engine from 3f7e12b8e656 to dd67063fc921 (1 revision) ( #125316 )
...
3f7e12b8e6...dd67063fc9bdero@google.com [Impeller] Fix division by zero for transparent shadows (flutter/engine#41391 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-21 18:00:25 +00:00
Justin McCandless
8784eb1d8e
Red spell check selection on iOS ( #125162 )
...
iOS now hides the selection handles and shows red selection when tapping a misspelled word, like native.
2023-04-21 09:15:08 -07:00
engine-flutter-autoroll
4b188bd81f
Roll Flutter Engine from a7899c45791c to 3f7e12b8e656 (6 revisions) ( #125302 )
...
a7899c4579...3f7e12b8e6skia-flutter-autoroll@skia.org Roll Skia from fbfed7c82918 to 5754b81988b8 (1 revision) (flutter/engine#41395 )
2023-04-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 4cc2e637a315 to fabaeef00dfb (1 revision) (flutter/engine#41394 )
2023-04-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from PqBDstaESE_l77k1e... to Edv0I0o8GQ7c0z8XK... (flutter/engine#41393 )
2023-04-21 bdero@google.com [Impeller] Fix SupportsReadFromOnscreenTexture capability check (flutter/engine#41386 )
2023-04-21 bdero@google.com [Impeller] Always use BGRA10_XR for wide gamut (flutter/engine#41385 )
2023-04-21 skia-flutter-autoroll@skia.org Roll Skia from 90a93bb0990f to fbfed7c82918 (2 revisions) (flutter/engine#41392 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from PqBDstaESE_l to Edv0I0o8GQ7c
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-21 15:54:21 +00:00
engine-flutter-autoroll
c18388588f
Roll Packages from 746750ecef78 to 7e3f5da42e81 (1 revision) ( #125301 )
...
746750ecef...7e3f5da42estuartmorgan@google.com [google_maps_flutter] Add examples for different iOS versions (flutter/packages#3757 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-21 15:44:06 +00:00
engine-flutter-autoroll
7f11020c55
Roll Flutter Engine from 122c3b382012 to a7899c45791c (7 revisions) ( #125290 )
...
122c3b3820...a7899c4579skia-flutter-autoroll@skia.org Roll Skia from 524ecb58945e to
90a93bb0990f (1 revision) (flutter/engine#41390 )
2023-04-21 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
4OrPF9lzqCKGwBLRh... to fMOcI5zn1z0nOrV7s... (flutter/engine#41389 )
2023-04-21 skia-flutter-autoroll@skia.org Roll Skia from f4609aa2eaba to
524ecb58945e (23 revisions) (flutter/engine#41388 )
2023-04-21 skia-flutter-autoroll@skia.org Roll Dart SDK from
50b96abe9f6f to 4cc2e637a315 (1 revision) (flutter/engine#41387 )
2023-04-21 54558023+keyonghan@users.noreply.github.com Update xcode to
14c18 (flutter/engine#41370 )
2023-04-21 zanderso@users.noreply.github.com Revert "[Impeller] Turned
on wide gamut support by default." (flutter/engine#41382 )
2023-04-21 chillers@google.com Revert "Manual roll skia to d5b4acfb4"
(flutter/engine#41381 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 4OrPF9lzqCKG to fMOcI5zn1z0n
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-21 08:06:42 -07:00
Michael Thomsen
dc481b23d1
Cleanup flutter config output ( #122384 )
2023-04-21 16:45:43 +02:00
Bruno Leroux
d4f884e000
Make selectable text mouse cursor configurable ( #125133 )
...
## Description
This PR introduces `DefaultSelectionStyle.mouseCursor` to configure the mouse cursor over selectable text.
It also applies this solution to `InkResponse` to make the mouse cursor win over the default one provided by selectable `Text` for many Material components (such as buttons).
### Before
https://user-images.githubusercontent.com/840911/233627729-ddf98e2a-444d-4c6d-a6d5-f521982f48dd.mov
### After
https://user-images.githubusercontent.com/840911/233627718-8871a68f-d33c-44cf-b4a1-91bb1fcdf076.mov
## Related Issue
Fixes https://github.com/flutter/flutter/issues/104595
## Tests
Adds 6 tests.
2023-04-21 13:43:37 +00:00
keyonghan
d186792c00
Update xcode to 14c18 for host only bots ( #125211 )
...
With https://flutter-review.googlesource.com/c/recipes/+/42160 , we are
ready to make all tests consistent with xcode 14c18.
> auto label is removed for flutter/flutter, pr: 125211, due to This PR has not met approval requirements for merging. Changes were requested by {jmagman}, please make the needed changes and resubmit this PR. You have project association MEMBER and need 1 more review(s) in order to merge this PR.
>
> * Merge guidelines: You need at least one approved review if you are already a MEMBER or two member reviews if you are not a MEMBER before re-applying the autosubmit label. **Reviewers**: If you left a comment approving, please use the "approve" review action instead.
Sounds an auto-submit bug. Manually submit.
2023-04-20 20:50:59 -07:00
engine-flutter-autoroll
7aa01f53f8
Roll Flutter Engine from 2db85cbe6a01 to 122c3b382012 (22 revisions) ( #125271 )
...
2db85cbe6a...122c3b3820737941+loic-sharma@users.noreply.github.com [Windows] Don't
block raster thread until v-blank (flutter/engine#41231 )
2023-04-21 chillers@google.com Manual roll skia to d5b4acfb4
(flutter/engine#41378 )
2023-04-21 magder@google.com Run mac unopt arm builds with arm toolchain
(flutter/engine#41353 )
2023-04-20 zanderso@users.noreply.github.com Revert "re-land "Migrate
mac_host_engine to engine v2 builds." (#41233 )"" (flutter/engine#41380 )
2023-04-20 skia-flutter-autoroll@skia.org Roll Dart SDK from
df05e451b79a to 50b96abe9f6f (1 revision) (flutter/engine#41379 )
2023-04-20 109111084+yaakovschectman@users.noreply.github.com Move
ownership of `AccessibilityBridgeWindows` to `FlutterWindowsView`
(flutter/engine#41308 )
2023-04-20 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
AoPEjX8Xfq1v0h4kx... to PqBDstaESE_l77k1e... (flutter/engine#41373 )
2023-04-20 godofredoc@google.com Revert "Upload windows arm artifacts to
production bucket." (flutter/engine#41372 )
2023-04-20 godofredoc@google.com re-land "Migrate mac_host_engine to
engine v2 builds." (#41233 )" (flutter/engine#41323 )
2023-04-20 godofredoc@google.com Upload windows arm artifacts to
production bucket. (flutter/engine#41324 )
2023-04-20 jason-simmons@users.noreply.github.com [Impeller] Change the
default color format for the GLES backend to RGBA (flutter/engine#41342 )
2023-04-20 maRci002@users.noreply.github.com [web] change status bar
color based on SystemUiOverlayStyle (flutter/engine#40599 )
2023-04-20 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
OcPCdaE17MAihaCrD... to 4OrPF9lzqCKGwBLRh... (flutter/engine#41367 )
2023-04-20 skia-flutter-autoroll@skia.org Roll Skia from fc09f9b2fb27 to
f4609aa2eaba (1 revision) (flutter/engine#41366 )
2023-04-20 skia-flutter-autoroll@skia.org Roll Dart SDK from
7d165bd0bb5e to df05e451b79a (2 revisions) (flutter/engine#41365 )
2023-04-20 skia-flutter-autoroll@skia.org Roll Skia from 80c38970791e to
fc09f9b2fb27 (1 revision) (flutter/engine#41362 )
2023-04-20 skia-flutter-autoroll@skia.org Roll Skia from c50081c62219 to
80c38970791e (2 revisions) (flutter/engine#41360 )
2023-04-20 skia-flutter-autoroll@skia.org Roll Skia from c21e7df194c3 to
c50081c62219 (11 revisions) (flutter/engine#41358 )
2023-04-20 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
Tun7i4VLz6ncx8JJJ... to AoPEjX8Xfq1v0h4kx... (flutter/engine#41357 )
2023-04-20 skia-flutter-autoroll@skia.org Roll Dart SDK from
88a3b66b50d6 to 7d165bd0bb5e (1 revision) (flutter/engine#41356 )
2023-04-20 jason-simmons@users.noreply.github.com Manual Skia roll from
ad90b6bd4760 to c21e7df194c3 (flutter/engine#41341 )
2023-04-20 jonahwilliams@google.com [impeller] convert src over to src
for solid color (flutter/engine#41351 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Tun7i4VLz6nc to PqBDstaESE_l
fuchsia/sdk/core/mac-amd64 from OcPCdaE17MAi to 4OrPF9lzqCKG
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-20 19:31:11 -07:00
Andrew Kolos
cf76b24df1
When searching for the JDK bundled with an unrecognized version of Android Studio, assume the version to be the latest ( #125247 )
...
Fixes #125246 by restoring the intended behavior of #101862 . That is, when searching for a JDK and we encounter an Android Studio version we don't recognize, assume it to be the latest version `flutter` is aware of.
Also does some light refactoring in the tests, like using test objects instead of referencing `globals`.
2023-04-21 01:12:59 +00:00
Casey Hillers
7d2669b8e7
[ci.yaml] Remove unnecessary use of { ( #125058 )
...
In yaml, indented blocks indicate the following fields are children of the parent indent. The use of curly brackets is unnecessary here
2023-04-21 00:32:31 +00:00
Hans Muller
5d3c1ca870
Updated the BottomNavigationBar API doc to link to NavigationBar ( #125240 )
...
The BottomNavigationBar API doc now makes it clear that NavigationBar is preferred in new M3 applications.
Fixes https://github.com/flutter/flutter/issues/124687
2023-04-20 23:21:05 +00:00
dependabot[bot]
a6ea22c285
Bump codecov/codecov-action from 3.1.2 to 3.1.3 ( #125253 )
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 3.1.2 to 3.1.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/codecov/codecov-action/releases ">codecov/codecov-action's releases</a>.</em></p>
<blockquote>
<h2>3.1.3</h2>
<h2>What's Changed</h2>
<ul>
<li>build(deps-dev): bump jest-junit from 15.0.0 to 16.0.0 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/957 ">codecov/codecov-action#957</a></li>
<li>build(deps): bump openpgp from 5.7.0 to 5.8.0 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/958 ">codecov/codecov-action#958</a></li>
<li>build(deps-dev): bump <code>@âtypes/node</code> from 18.15.10 to 18.15.12 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/959 ">codecov/codecov-action#959</a></li>
<li>fix: allow for aarch64 build by <a href="https://github.com/thomasrockhu-codecov "><code>@âthomasrockhu-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/960 ">codecov/codecov-action#960</a></li>
<li>chore(release): bump to 3.1.3 by <a href="https://github.com/thomasrockhu-codecov "><code>@âthomasrockhu-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/961 ">codecov/codecov-action#961</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/codecov/codecov-action/compare/v3.1.2...v3.1.3 ">https://github.com/codecov/codecov-action/compare/v3.1.2...v3.1.3 </a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md ">codecov/codecov-action's changelog</a>.</em></p>
<blockquote>
<h2>3.1.3</h2>
<h3>Fixes</h3>
<ul>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/960 ">#960</a> fix: allow for aarch64 build</li>
</ul>
<h3>Dependencies</h3>
<ul>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/957 ">#957</a> build(deps-dev): bump jest-junit from 15.0.0 to 16.0.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/958 ">#958</a> build(deps): bump openpgp from 5.7.0 to 5.8.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/959 ">#959</a> build(deps-dev): bump <code>@âtypes/node</code> from 18.15.10 to 18.15.12</li>
</ul>
<h2>3.1.2</h2>
<h3>Fixes</h3>
<ul>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/718 ">#718</a> Update README.md</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/851 ">#851</a> Remove unsupported path_to_write_report argument</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/898 ">#898</a> codeql-analysis.yml</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/901 ">#901</a> Update README to contain correct information - inputs and negate feature</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/955 ">#955</a> fix: add in all the extra arguments for uploader</li>
</ul>
<h3>Dependencies</h3>
<ul>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/819 ">#819</a> build(deps): bump openpgp from 5.4.0 to 5.5.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/835 ">#835</a> build(deps): bump node-fetch from 3.2.4 to 3.2.10</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/840 ">#840</a> build(deps): bump ossf/scorecard-action from 1.1.1 to 2.0.4</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/841 ">#841</a> build(deps): bump <code>@âactions/core</code> from 1.9.1 to 1.10.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/843 ">#843</a> build(deps): bump <code>@âactions/github</code> from 5.0.3 to 5.1.1</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/869 ">#869</a> build(deps): bump node-fetch from 3.2.10 to 3.3.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/872 ">#872</a> build(deps-dev): bump jest-junit from 13.2.0 to 15.0.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/879 ">#879</a> build(deps): bump decode-uri-component from 0.2.0 to 0.2.2</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/889 ">#889</a> build(deps): bump ossf/scorecard-action from 1.1.1 to 2.1.2</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/895 ">#895</a> build(deps): bump json5 from 2.2.1 to 2.2.3</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/896 ">#896</a> build(deps): bump actions/upload-artifact from 3.1.0 to 3.1.2</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/900 ">#900</a> build(deps-dev): bump <code>@âvercel/ncc</code> from 0.34.0 to 0.36.1</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/905 ">#905</a> build(deps-dev): bump typescript from 4.7.4 to 4.9.5</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/911 ">#911</a> build(deps-dev): bump <code>@âtypes/node</code> from 16.11.40 to 18.13.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/922 ">#922</a> build(deps-dev): bump <code>@âtypes/node</code> from 18.13.0 to 18.14.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/924 ">#924</a> build(deps): bump openpgp from 5.5.0 to 5.7.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/927 ">#927</a> build(deps-dev): bump <code>@âtypes/node</code> from 18.14.0 to 18.14.2</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/933 ">#933</a> build(deps-dev): bump <code>@âtypes/node</code> from 18.14.2 to 18.14.6</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/937 ">#937</a> build(deps-dev): bump <code>@âtypes/node</code> from 18.14.6 to 18.15.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/938 ">#938</a> build(deps): bump node-fetch from 3.3.0 to 3.3.1</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/945 ">#945</a> build(deps-dev): bump <code>@âtypes/node</code> from 18.15.0 to 18.15.5</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/946 ">#946</a> build(deps-dev): bump <code>@âtypes/node</code> from 18.15.5 to 18.15.6</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/947 ">#947</a> build(deps-dev): bump <code>@âtypes/node</code> from 18.15.6 to 18.15.10</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/951 ">#951</a> build(deps): bump ossf/scorecard-action from 2.1.2 to 2.1.3</li>
</ul>
<h2>3.1.1</h2>
<h3>Fixes</h3>
<ul>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/661 ">#661</a> Update deprecation warning</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/593 ">#593</a> Create codeql-analysis.yml</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/712 ">#712</a> README: fix typo</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/725 ">#725</a> fix: Remove a blank row</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/726 ">#726</a> Update README.md with correct badge version</li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="894ff025c7https://redirect.github.com/codecov/codecov-action/issues/961 ">#961</a>)</li>
<li><a href="f539f977d5https://redirect.github.com/codecov/codecov-action/issues/960 ">#960</a>)</li>
<li><a href="6757614f24https://redirect.github.com/codecov/codecov-action/issues/959 ">#959</a>)</li>
<li><a href="cdee249da5https://redirect.github.com/codecov/codecov-action/issues/958 ">#958</a>)</li>
<li><a href="ce548e935ahttps://redirect.github.com/codecov/codecov-action/issues/957 ">#957</a>)</li>
<li>See full diff in <a href="40a12dcee2...894ff025c7https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=codecov/codecov-action&package-manager=github_actions&previous-version=3.1.2&new-version=3.1.3 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2023-04-20 22:41:49 +00:00
Chris Bobbe
58e30852e6
BottomAppBar doc: Fix doc about surfaceTintColor ( #124563 )
2023-04-20 15:39:24 -07:00
Renzo Olivares
01b4dd5eee
Toolbar should re-appear on drag end ( #125165 )
...
#125151 introduced the magnifier on touch drag gestures, but when showing the magnifier the toolbar is implicitly hidden, this change makes the toolbar re-appear on drag end for double tap + drag.
2023-04-20 22:34:35 +00:00
Nate Bosch
dcfd35f8a7
Remove uses of deprecated test_api imports ( #124732 )
...
Most of these imports were never appropriate. The `test_api` package was never intended for use in `_test.dart` files.
Where possible move imports to `matcher`, otherwise move them to `test` or `flutter_test`.
Leave uses of `test_api` from `flutter_test` library code.
2023-04-20 20:55:28 +00:00
Ian Hickson
55825f166e
Remove dynamic calls ( #125238 )
...
I don't know what I was thinking when I wrote this code back in 2017 but this is so trivially fixable...
2023-04-20 20:09:12 +00:00
Tae Hyung Kim
9caabdd220
Revert "Sliver Constrained Cross Axis" ( #125233 )
...
Going to make some changes to the implementation so I'll revert in the meantime.
Reverts flutter/flutter#124337
2023-04-20 18:47:50 +00:00
9oya
0c7bc2f9c9
Implement CheckmarkableChipAttributes on ChoiceChip ( #124743 )
2023-04-20 11:43:49 -07:00
Flutter GitHub Bot
d85e2fb810
Roll pub packages ( #125225 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2023-04-20 18:28:10 +00:00
chunhtai
5764404f5c
fix localization typo for expansionTileExpandedHint ( #125212 )
...
as title
2023-04-20 18:23:06 +00:00
Justin McCandless
13f4fe4091
Show iOS menu on iOS for TextField by default ( #124895 )
...
Even in TextField using the Material library, iOS devices will still show the iOS-style spell check toolbar by default when using spell check.
2023-04-20 11:09:37 -07:00
Ben Konyi
0d023144d9
Fix race condition in flutter test when passing --serve-observatory ( #123556 )
...
`flutter test` wasn't awaiting the `_serveObservatory` request which was
causing a race condition in the `flutter test should respect
--serve-observatory` test in `test/integration.general/test_test.dart`.
Related to https://github.com/flutter/flutter/issues/123516
2023-04-20 13:46:33 -04:00
Flutter GitHub Bot
a573d1aeee
Roll pub packages ( #125050 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2023-04-20 17:36:10 +00:00
Christopher Fujino
800175af6b
[flutter_tools] make overall_experience_test resilient to extraneous pub output ( #125172 )
...
use `containsAllInOrder` so that pub output doesn't cause htis test to fail, as in https://ci.chromium.org/p/flutter/builders/try/Linux%20tool_tests_general/22929 ?
2023-04-20 17:31:58 +00:00
chunhtai
8ac94c16b2
MinimumTapTargetGuideline skips nodes at scrollable boundaries ( #124615 )
...
fixes https://github.com/flutter/flutter/issues/107615
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-04-20 09:09:55 -07:00
engine-flutter-autoroll
70ca469792
Roll Packages from 88591becfb3f to 746750ecef78 (4 revisions) ( #125208 )
...
88591becfb...746750ecefstuartmorgan@google.com [pigeon] Add an initial example app (flutter/packages#3761 )
2023-04-20 imagipioneer@gmail.com [google_maps_flutter_web] Allow marker position updates (flutter/packages#3697 )
2023-04-19 tarrinneal@gmail.com [Tool] [Code Excerpt] allow excerpts in example readme (flutter/packages#3758 )
2023-04-19 47866232+chunhtai@users.noreply.github.com [go_router] migrates test for route information.location deprecation (flutter/packages#3763 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-20 15:53:21 +00:00
Reid Baker
64591356b9
i125138 abstract method smoke agp update ( #125139 )
...
- Update gradle and AGP version for abstract_method_smoke_test
#125138 part 1/N
To update successfully:
1. Update gradle to a version supported by jdk 17
2. Uncommented the lockfile lines in android/build.gradle
3. Then ran the AGP update assistant from AndroidStudio -> tools
4. From android ran `./gradlew dependencies --write-locks`
5. From android/app ran `./gradlew dependencies --write-locks`
6. Re enabled the lockfiles section of android/build.gradle
7. Ensured `flutter build apk` passed
2023-04-20 15:16:18 +00:00
