17931 Commits

Author SHA1 Message Date
skia-flutter-autoroll
96fbde253e Roll Skia from 9753199415ac to ee6f41262b2e (1 revision) (flutter/engine#33673) 2022-05-27 19:38:02 -07:00
Chris Bracken
56fbdd0232 [lint] Enforce k prefix for global constants (flutter/engine#33666)
Enforces that all global constants are prefixed with a 'k' as per the
style guide and updates the codebase into conformance where necessary.

This does not change any public API.

Additional testing provided by the addition of the lint rule.

Ref: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#begin-global-constant-names-with-prefix-k
2022-05-27 18:33:38 -07:00
skia-flutter-autoroll
1e275928fc Roll Skia from 162dfca3403b to 9753199415ac (1 revision) (flutter/engine#33671) 2022-05-27 18:13:04 -07:00
Chinmay Garde
cc83eb1091 [Impeller] Compile simulator specific Metal shader variants. (flutter/engine#33670) 2022-05-27 17:53:05 -07:00
Chinmay Garde
c928cd3e6a [Impeller] Import docs from wiki. (flutter/engine#33668)
It took me a while to figure out how best to put image heavy docs into a Wiki on
GitHub. Finally, gave up and moved these to a docs folder in Markdown syntax.
The images have been `pngcrush`ed with the `-brute` so they are about as small
as can be expected.

Added links to the articles from the README and also added Brandon's showcase to
zhoosh it up a bit :)

Fixes https://github.com/flutter/flutter/issues/104740
2022-05-27 14:52:49 -07:00
skia-flutter-autoroll
c23c4d1b32 Roll Fuchsia Linux SDK from QmhwWAbzL... to v57clWK63... (flutter/engine#33667) 2022-05-27 14:08:04 -07:00
J-P Nurmi
f35001f852 [Linux] fix typos in FlAccessibleNode docs (flutter/engine#32651) 2022-05-27 13:28:31 -07:00
Chris Bracken
2b84fdf8cb [macOS] Document onKeyboardLayoutChanged (flutter/engine#33663)
Replaces a TODO with documentation. No tests changed, since this change
simply adds a missing doc comment.
2022-05-27 12:48:10 -07:00
Shivesh Ganju
61a5c8873c [fuchsia] remove Fuchsia-specific kVsyncTraceName from VsyncWaiter. (flutter/engine#33519)
This CL changes the vsync trace name to "VsyncProcessCallback". The
benchmarks in fuchsia currently support "VsyncProcessCallback" and "vsync callback". After this change, support for "vsync callback" can be safely removed from fuchsia benchmarks.

Test: fx test host_x64/knowledge_card_test

Bug: 73367
2022-05-27 12:04:12 -07:00
Brandon DeRosier
41a5bd513e [Impeller] Interpret odd path winding in the dispatcher (flutter/engine#33657) 2022-05-27 11:49:24 -07:00
Michael Goderbauer
782679ce66 Move platform-specific stuff from macOS FVC to FlutterEngine (flutter/engine#33234) 2022-05-27 09:56:28 -07:00
skia-flutter-autoroll
292a7c9d11 Roll Skia from 6e1e6f3825d0 to 162dfca3403b (1 revision) (flutter/engine#33658) 2022-05-27 05:33:04 -07:00
moko256
94fa5033bf [Windows] Pass a function which returns ScopedClipboardInterface instead of ScopedClipboardInterface to PlatformHandlerWin32 (flutter/engine#33609) 2022-05-27 04:33:04 -07:00
Brandon DeRosier
183a7e414f Use factory in display list for mask filter (flutter/engine#33654) 2022-05-27 01:57:21 -07:00
skia-flutter-autoroll
50086b29f6 Roll Fuchsia Linux SDK from 10urDSi3_... to QmhwWAbzL... (flutter/engine#33653) 2022-05-27 00:48:03 -07:00
skia-flutter-autoroll
18904b5d4a Roll Skia from c41cf0d4f8d7 to 6e1e6f3825d0 (1 revision) (flutter/engine#33652) 2022-05-27 00:43:04 -07:00
skia-flutter-autoroll
8a5186bb35 Roll Skia from b0831daddc8d to c41cf0d4f8d7 (1 revision) (flutter/engine#33650) 2022-05-26 23:10:05 -07:00
Chinmay Garde
08355df4dc [Impeller] Upload textures on the IO context where available. (flutter/engine#33648)
In the OpenGL ES backend, if an Impeller operation happens on a thread
with no OpenGL context current, the reactor enqueues it for later
execution. This later execution may happen on the main context. To avoid
this pessimization, queue the upload to the IO thread (which already has
a context) instead.

I was hoping that the reactor would manage task pinning as well but that
change is more invasive and I wanted to add parity with the Metal
backend ASAP. Hence the post-task fix.

Fixes https://github.com/flutter/flutter/issues/104756
2022-05-26 21:51:32 -07:00
Zachary Anderson
ba64d1e1b5 Run some unit tests in parallel (flutter/engine#33603) 2022-05-26 20:14:06 -07:00
Chris Yang
bf761b4c12 Fix test: make sure end_frame_latch is signaled after accessing the used_this_frame flag (flutter/engine#33649) 2022-05-26 20:02:20 -07:00
Emmanuel Garcia
f4887a67d3 Fix Android platform view resize and direction in nested layouts. (flutter/engine#33645) 2022-05-26 19:50:04 -07:00
Chris Bracken
19696ceb2e [macOS] Fix some incorrectly-named string constants (flutter/engine#33647)
Renames from `FooBarBaz` to `kFooBarBaz` in line with style guide.

No tests since no functional changes are being made.

Ref: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#begin-global-constant-names-with-prefix-k
2022-05-26 18:37:58 -07:00
skia-flutter-autoroll
17b8cafc98 Roll Skia from 93b062926223 to b0831daddc8d (1 revision) (flutter/engine#33646) 2022-05-26 16:55:04 -07:00
Jonah Williams
39760a89fe [Impeller] Implement drawVertices (flutter/engine#33492) 2022-05-26 14:45:05 -07:00
Zachary Anderson
5d5c396ec0 Run run_tests.py Dart tests in parallel (flutter/engine#33619) 2022-05-26 14:44:09 -07:00
skia-flutter-autoroll
68fca1f2a7 Roll Skia from 2d51639e4b4d to 93b062926223 (2 revisions) (flutter/engine#33643) 2022-05-26 14:35:03 -07:00
Chris Yang
190118f789 Set UsedThisFrame before EndFrame (flutter/engine#33627) 2022-05-26 14:10:04 -07:00
skia-flutter-autoroll
7e04d295b4 Roll Skia from d78d52a86fa3 to 2d51639e4b4d (4 revisions) (flutter/engine#33642) 2022-05-26 13:15:06 -07:00
J-P Nurmi
12ac248051 [Linux] FlTextInputPlugin: use FlView as GTK IM client window (flutter/engine#33111)
GTK IM operates in [coordinates relative to its client window](https://docs.gtk.org/gtk3/method.IMContext.set_cursor_location.html#:~:text=The%20location%20is%20relative%20to%20the%20client%C2%A0window.). Let GTK
IM use the native window that backs FlView, which is the same native
window that is used for key event processing - see GDK_KEY_XXX_MASK in
fl_view_realize().

This is an important step towards testable FlTextInputPlugin because it
eliminates the depency to GtkWidget's coordinate translation API and
that way paves the road for replacing FlTextInputPlugin's FlView
instance with a plain GdkWindow. In tests, that window can be an
instance of GdkOffscreenWindow.

There are no tests included yet but after a few more refactoring steps
it will be possible to execute tests like this: [fl_text_input_plugin_test.cc](f2e0d91b59/shell/platform/linux/fl_text_input_plugin_test.cc).
The other refactoring steps are visible at [jpnurmi/engine/commits/text-input-plugin](https://github.com/jpnurmi/engine/commits/text-input-plugin).
2022-05-26 13:08:06 -07:00
Sophie Winter
86379d5cb3 Force GTK IM context to initialize at start (flutter/engine#32118)
Fixes https://github.com/flutter/flutter/issues/100385
2022-05-26 13:07:34 -07:00
skia-flutter-autoroll
6cdc25d322 Roll Skia from 6a67f1f40f4c to d78d52a86fa3 (1 revision) (flutter/engine#33641) 2022-05-26 11:45:04 -07:00
skia-flutter-autoroll
71e4158f4b Roll Fuchsia Linux SDK from le9UQNXi2... to 10urDSi3_... (flutter/engine#33640) 2022-05-26 11:25:05 -07:00
skia-flutter-autoroll
8dcaf0d7e4 Roll Skia from 35ef74b7a4c5 to 6a67f1f40f4c (3 revisions) (flutter/engine#33637) 2022-05-26 10:05:07 -07:00
joshualitt
b36c0ce61e [web] Migrate Flutter Web DOM usage to JS static interop - 20. (flutter/engine#33348) 2022-05-26 08:58:50 -07:00
skia-flutter-autoroll
37e49fc83c Roll Skia from f92fbda20782 to 35ef74b7a4c5 (1 revision) (flutter/engine#33636) 2022-05-26 08:40:04 -07:00
Zachary Anderson
8e85a8d270 Fixes a few asan errors (flutter/engine#33632) 2022-05-26 07:29:50 -07:00
skia-flutter-autoroll
757c3f34f6 Roll Skia from bf7409b32105 to f92fbda20782 (1 revision) (flutter/engine#33634) 2022-05-26 04:10:03 -07:00
skia-flutter-autoroll
04f7531acf Roll Skia from c9c86fef729d to bf7409b32105 (1 revision) (flutter/engine#33633) 2022-05-26 00:15:04 -07:00
Chinmay Garde
667051ea5b [Impeller] GLES: Keep track of OpenGL ES device capabilities. (flutter/engine#33628) 2022-05-26 00:05:05 -07:00
skia-flutter-autoroll
50d2130a71 Roll Fuchsia Linux SDK from 4MItR-HyL... to le9UQNXi2... (flutter/engine#33631) 2022-05-25 22:05:04 -07:00
dependabot[bot]
29292c67c2 Bump ossf/scorecard-action from 1.0.4 to 1.1.0 (flutter/engine#33629) 2022-05-25 19:33:04 -07:00
dependabot[bot]
7b7ff3fc71 Bump actions/upload-artifact from 3.0.0 to 3.1.0 (flutter/engine#33552) 2022-05-25 18:28:05 -07:00
Chinmay Garde
87bd337836 [Impeller] GLES: Wire up program link log dumping and fix TheImpeller showcase. (flutter/engine#33626)
The linker error was due to the same uniform name with different types
appearing in different shader stages. I'll add an Impeller validation
for this in a subsequent patch so we don't depend on testing in GLES.

There was also another issue related to not being able to bind a
cube-map type texture.

After these fixes, the showcase runs but the one of the textures
doesn't seem to be sampled still. But still, the progress is pretty
neat.

Fixes https://github.com/flutter/flutter/issues/104585.
2022-05-25 17:32:08 -07:00
skia-flutter-autoroll
1471e8c959 Roll Skia from f58d05a909d9 to c9c86fef729d (2 revisions) (flutter/engine#33625) 2022-05-25 15:53:04 -07:00
Lau Ching Jun
7e1f01af02 [impeller] Include <functional> in a header file where std::function is used. (flutter/engine#33621) 2022-05-25 14:48:04 -07:00
Lau Ching Jun
bf793ac0cd [impeller] Import the header file in the generated shader file. (flutter/engine#33623) 2022-05-25 14:28:04 -07:00
skia-flutter-autoroll
0833dd05f1 Roll Skia from 052566d8ccb7 to f58d05a909d9 (4 revisions) (flutter/engine#33620) 2022-05-25 14:18:06 -07:00
skia-flutter-autoroll
25c5043012 Roll Skia from b3a74c7d8b49 to 052566d8ccb7 (2 revisions) (flutter/engine#33617) 2022-05-25 12:38:05 -07:00
Kaushik Iska
796e65f687 Layer snapshots also contain bounds information (flutter/engine#33615) 2022-05-25 11:43:04 -07:00
Chinmay Garde
97bbedec8c [impeller] OpenGL ES: Refactor handle table and debug label management. (flutter/engine#33598)
Acquires fewer locks and doesn't throw GL errors when setting labels on
create-on-bind resources that haven't been bound yet. In such cases, the
label will be set on the next reaction.
2022-05-25 11:38:03 -07:00