Victoria Ashworth
951b25d240
Check for devicectl launch logs from std and file ( #178167 )
...
For some reason in different editors, `devicectl` does not appear to
stream its logs to `stdout`. Usually after calling `xcrun devicectl
device process launch --console ...`, the `stdout` stream will receive a
log of `'Waiting for the application to terminate'`. To workaround this,
we use the `--log-ouput` flag with the `devicectl` command, which tells
`devicectl` to write its logs to a file. We then periodically read the
file looking for the `'Waiting for the application to terminate'` log.
Fixes b/454953393.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-10 20:46:51 +00:00
Mohellebi abdessalem
32ea58f183
Replace deprecated withOpacity in hero.1.dart example ( #177810 )
...
<img width="859" height="148" alt="Screenshot 2025-10-27 at 20 09 35"
src="https://github.com/user-attachments/assets/daf13a7b-a157-410a-9feb-dc466128c5a1 "
/>
Similar PRs:
- #177374
- #177490
- #177540
- #177541
- #177542
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
2025-11-10 20:46:49 +00:00
engine-flutter-autoroll
87482a5dad
Roll Skia from 38d87df93572 to f10dd19a7a04 (18 revisions) ( #178241 )
...
https://skia.googlesource.com/skia.git/+log/38d87df93572..f10dd19a7a04
2025-11-10
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-11-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from eea1fcf95a58 to cc7e0e04887e (5 revisions)
2025-11-10
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-11-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 97d930843592 to 8f80a4b72d9f (15 revisions)
2025-11-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 1e0c6ee5dcff to f474b0ce14a6 (1 revision)
2025-11-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from c6623330827f to 95921c1502d6 (2 revisions)
2025-11-10
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-11-10
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-11-09 michaelludwig@google.com [graphite] Use combined
depth+stencil format when using MSAA
2025-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 6b26ee706b9d to c6623330827f (3 revisions)
2025-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SKP
CIPD package from 538 to 539
2025-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from e54d06824ab3 to 6b26ee706b9d (1 revision)
2025-11-08 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
Dawn from 090cac345695 to a8dc09f23c22 (20 revisions)
2025-11-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from eb3facbc43cf to e54d06824ab3 (5 revisions)
2025-11-08
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-11-07
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-11-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from a34bdd1b0084 to eb3facbc43cf (4 revisions)
2025-11-07
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com ,jimgraham@google.com,kjlubick@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-10 20:45:37 +00:00
Daco Harkes
d88fd12ce8
[native assets] Roll and unpin dependencies ( #178181 )
...
Rolling the dependencies to the latest versions and unpinning them.
Tests: All existing tests of build hooks and code assets.
2025-11-10 20:44:40 +00:00
Ahmed Mohamed Sameh
9f666e161f
Make sure that a SpellCheckSuggestionsToolbar doesn't crash in 0x0 en… ( #177965 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the
SpellCheckSuggestionsToolbar widget.
2025-11-10 20:44:39 +00:00
Tomoo Kikuchi
35a9f5b6ac
Add DeviceOrientationBuilder widget by MediaQuery orientation ( #177437 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
## Issues Fixed
Fixes https://github.com/flutter/flutter/issues/177435
On foldable Android devices, `OrientationBuilder` and
`MediaQuery.orientation` can report different orientations.
`OrientationBuilder` calculates orientation from layout constraints
(width vs height),
while `MediaQuery` reports the actual device orientation from the
platform. This PR adds a new `DeviceOrientationBuilder` widget that uses
`MediaQuery.orientationOf()` to ensure consistency with the
device's actual orientation.
## Breaking Changes
No breaking changes. This PR does not modify any existing code in the
flutter/tests repo or require a migration guide.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-10 20:44:36 +00:00
Jason Simmons
60be753a43
[Android] Encode the original pointer count in messages that represent Android touch events ( #178015 )
...
Android touch events include updates to multiple pointers, but each
pointer data message sent from the embedder to the framework represents
a single pointer. So the Android embedder will send multiple messages
for each touch event, and the framework's AndroidViewController will
reassemble the messages and forward the resulting event to the platform
view.
The AndroidViewController tracks the number of active pointers in its
own local state. If that state is out of sync with the event handled by
the Android embedder, then the AndroidViewController may send duplicate
events to the platform view.
This PR encodes the Android touch event's pointer count in the messages
sent to the framework. This allows the AndroidViewController to reliably
determine whether it has received all of the pointer messages that
originated from an event.
Fixes https://github.com/flutter/flutter/issues/176574
2025-11-10 20:43:48 +00:00
Ahmed Mohamed Sameh
4a19bffa14
Make sure that a SwitchListTile doesn't crash in 0x0 environment ( #178069 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the SwitchListTile
widget.
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
2025-11-10 20:43:45 +00:00
Jenn Magder
0d1c6d2c78
Update Android TESTOWNERS ( #178182 )
...
Update TESTOWNERS for Android tests.
We'll do another rebalancing exercise soon.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-10 20:43:45 +00:00
engine-flutter-autoroll
f892a5a3cc
Roll Dart SDK from 380f494ce0ab to a2761156b6c3 (1 revision) ( #178196 )
...
https://dart.googlesource.com/sdk.git/+log/380f494ce0ab..a2761156b6c3
2025-11-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-114.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-10 19:35:58 +00:00
engine-flutter-autoroll
e74c595450
Roll Dart SDK from 34902d333e4d to 380f494ce0ab (1 revision) ( #178192 )
...
https://dart.googlesource.com/sdk.git/+log/34902d333e4d..380f494ce0ab
2025-11-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-113.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-08 06:03:30 +00:00
engine-flutter-autoroll
9b5ad80316
Roll Fuchsia Linux SDK from qDVe2mrpSgQdxra7p... to rzOSWgcdwiZ5vxyB0... ( #178190 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jimgraham@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-08 04:55:25 +00:00
chunhtai
8b32a3daf7
Fixes tab to allow child to have semantics role ( #177809 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
as title, unblocks https://github.com/flutter/flutter/pull/165173
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-08 00:46:17 +00:00
engine-flutter-autoroll
c3f2704f19
Roll Dart SDK from cf69b162e2eb to 34902d333e4d (19 revisions) ( #178183 )
...
https://dart.googlesource.com/sdk.git/+log/cf69b162e2eb..34902d333e4d
2025-11-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-112.0.dev
2025-11-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-111.0.dev
2025-11-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-110.0.dev
2025-11-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-109.0.dev
2025-11-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-108.0.dev
2025-11-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-107.0.dev
2025-11-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-106.0.dev
2025-11-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-105.0.dev
2025-11-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-104.0.dev
2025-11-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-103.0.dev
2025-11-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-102.0.dev
2025-11-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-101.0.dev
2025-11-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-100.0.dev
2025-11-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-99.0.dev
2025-11-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-98.0.dev
2025-11-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-97.0.dev
2025-11-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-96.0.dev
2025-11-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-95.0.dev
2025-11-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-94.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-08 00:18:20 +00:00
engine-flutter-autoroll
c3d103b3df
Roll Skia from 513b15b675f5 to 38d87df93572 (5 revisions) ( #178179 )
...
https://skia.googlesource.com/skia.git/+log/513b15b675f5..38d87df93572
2025-11-07
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-11-07 michaelludwig@google.com [ganesh] Support AHB RGBA10x6 as an
external texture format
2025-11-07 michaelludwig@google.com [graphite] Update backend texture
creation flags to match VulkanCaps
2025-11-07 bungeman@google.com Revert "Add script and language to
SkShaper::RunHandler"
2025-11-07 cwallez@chromium.org Handle Dawn's deprecation for the
SetImmediateData rename.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,jimgraham@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-07 23:42:27 +00:00
Ben Konyi
df1d6485e5
[ Tool ] Ignore invalid UTF-8 from ADB's stdout ( #178170 )
...
This was incorrectly updated as part of
https://github.com/flutter/flutter/pull/177470
2025-11-07 19:56:28 +00:00
engine-flutter-autoroll
3daaf5966e
Roll Skia from 581d1ecd5029 to 513b15b675f5 (1 revision) ( #178165 )
...
https://skia.googlesource.com/skia.git/+log/581d1ecd5029..513b15b675f5
2025-11-07 kjlubick@google.com Make more tests and gms do explicit PNG
handling
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,jimgraham@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-07 17:34:43 +00:00
Jason Simmons
acdca87356
Reland "Update all uses of mutable SkPath methods to use SkPathBuilder" ( #178142 )
...
This is a reland of https://github.com/flutter/flutter/pull/177738 with
a fix to the `Op` function in `tools/path_ops`.
To match the previous behavior, `Op` will use `SkPathBuilder::operator=`
to copy the result path so that attributes like the fill type will be
copied.
---------
Co-authored-by: Kaylee Lubick <kjlubick@users.noreply.github.com>
2025-11-07 16:36:27 +00:00
engine-flutter-autoroll
ee23168ddb
Roll Packages from f13bad3649af to 3caa48bc1eef (5 revisions) ( #178164 )
...
f13bad3649...3caa48bc1e38378650+hgraceb@users.noreply.github.com [go_router]
Migrates test for leak testing (flutter/packages#10276 )
2025-11-06 okorohelijah@google.com Run tests on macOS 15.5 or 15.7
(flutter/packages#10336 )
2025-11-06 altomanigianluca@gmail.com [pigeon] Encode custom enum as
long in Kotlin generator (flutter/packages#10085 )
2025-11-06 stuartmorgan@google.com [tool] Ensure that all packages
format with correct language version (flutter/packages#10374 )
2025-11-06 engine-flutter-autoroll@skia.org Roll Flutter from
e5d5c01850f2 to c5e809a998fe (29 revisions) (flutter/packages#10369 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-07 15:58:22 +00:00
Kostia Sokolovskyi
fc3c5a2c4b
Fix text input actions in DropdownMenu. ( #177313 )
...
Fixes https://github.com/flutter/flutter/issues/177009
### Description
- Moves `MenuButton` submit logic from `onEditingComplete` to
`onSubmitted` to allow `TextField` to handle the `textInputAction` logic
- Wraps each item into `ExcludeFocus` to enable proper
`TextInputAction.previous` handling. If we don't wrap each child in
`ExcludeFocus`, then focus will be moved to one of them, which is not
the expected behavior for `TextInputAction.previous`.
| BEFORE | AFTER |
| - | - |
| <video alt="before"
src="https://github.com/user-attachments/assets/a50d41de-7e54-409b-bf81-80dfb1db132f "
/> | <video alt="after"
src="https://github.com/user-attachments/assets/152e47e6-d774-481c-8478-af526b5f6749 "
/> |
<details closed><summary>Code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() {
runApp(const DropdownMenuExample());
}
class DropdownMenuExample extends StatefulWidget {
const DropdownMenuExample({super.key});
@override
State<DropdownMenuExample> createState() => _DropdownMenuExampleState();
}
class _DropdownMenuExampleState extends State<DropdownMenuExample> {
final FocusNode _previousFocusNode = FocusNode(debugLabel: 'previous');
final FocusNode _textFieldFocusNode = FocusNode(debugLabel: 'textField');
final FocusNode _nextFocusNode = FocusNode(debugLabel: 'next');
@override
void dispose() {
_previousFocusNode.dispose();
_textFieldFocusNode.dispose();
_nextFocusNode.dispose();
super.dispose();
}
@override
Widget build(BuildContext context) {
return MaterialApp(
theme: ThemeData(colorSchemeSeed: Colors.green),
home: Scaffold(
body: Center(
child: Column(
mainAxisSize: MainAxisSize.min,
crossAxisAlignment: CrossAxisAlignment.center,
mainAxisAlignment: MainAxisAlignment.center,
spacing: 20,
children: [
TextField(
focusNode: _previousFocusNode,
textInputAction: TextInputAction.next,
decoration: InputDecoration(
border: OutlineInputBorder(),
labelText: 'Previous TextField',
),
),
DropdownMenu<String>(
label: Text('Dropdown with filter cannot close keyboard'),
initialSelection: 'green',
focusNode: _textFieldFocusNode,
requestFocusOnTap: true,
showTrailingIcon: false,
textInputAction: TextInputAction.next,
onSelected: (String? color) {
print('SELECTED $color');
},
dropdownMenuEntries: [
DropdownMenuEntry(value: 'red', label: 'red'),
DropdownMenuEntry(value: 'green', label: 'green'),
DropdownMenuEntry(value: 'blue', label: 'blue'),
],
),
TextField(
focusNode: _nextFocusNode,
textInputAction: TextInputAction.done,
decoration: InputDecoration(
border: OutlineInputBorder(),
labelText: 'Next TextField',
),
),
],
),
),
),
);
}
}
```
</details>
There is still one behavior I would like to discuss. When the
`showTrailingIcon: true` and `textInputAction: TextInputAction.previous`
are used, the focus moves not to the previous field but to the
`IconButton`. If we wrap the `IconButton` with `ExcludeFocus`, then this
is fixed, but I am not sure whether this is the correct way to proceed.
| TextInputAction.previous and no ExcludeFocus on IconButton |
TextInputAction.previous and ExcludeFocus on IconButton |
| - | - |
| <video alt="before"
src="https://github.com/user-attachments/assets/76c90dcf-3ea1-492f-8e67-7e987b08c2ff "
/> | <video alt="after"
src="https://github.com/user-attachments/assets/2a1600a2-e308-430e-a12f-acdc06cbf81c "
/> |
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-07 14:48:29 +00:00
engine-flutter-autoroll
00e8d9fb5b
Roll Skia from f838c4b31edb to 581d1ecd5029 (1 revision) ( #178157 )
...
https://skia.googlesource.com/skia.git/+log/f838c4b31edb..581d1ecd5029
2025-11-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from feb8f7b1cf78 to a34bdd1b0084 (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,jimgraham@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-07 13:34:29 +00:00
engine-flutter-autoroll
da952a44b5
Roll Skia from eb3c5b280ae6 to f838c4b31edb (3 revisions) ( #178149 )
...
https://skia.googlesource.com/skia.git/+log/eb3c5b280ae6..f838c4b31edb
2025-11-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 8c5e129d48ad to eea1fcf95a58 (2 revisions)
2025-11-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 516bf37a739d to 090cac345695 (15 revisions)
2025-11-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 153470c12fdf to 1e0c6ee5dcff (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,jimgraham@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-07 10:55:28 +00:00
engine-flutter-autoroll
b296302559
Roll Skia from 360fe72b5bf4 to eb3c5b280ae6 (1 revision) ( #178147 )
...
https://skia.googlesource.com/skia.git/+log/360fe72b5bf4..eb3c5b280ae6
2025-11-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from ff55757db3ba to 97d930843592 (21 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,jimgraham@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-07 07:39:25 +00:00
engine-flutter-autoroll
3ee372ceb5
Roll Skia from 116f237bb39d to 360fe72b5bf4 (4 revisions) ( #178146 )
...
https://skia.googlesource.com/skia.git/+log/116f237bb39d..360fe72b5bf4
2025-11-06 bungeman@google.com Add script and language to
SkShaper::RunHandler
2025-11-06 nicolettep@google.com Add kR16_unorm_SkColorType
2025-11-06
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-11-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from c8f0766414a4 to feb8f7b1cf78 (3 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,jimgraham@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-07 04:44:36 +00:00
engine-flutter-autoroll
58e5b30d97
Roll Fuchsia Linux SDK from cm88aTLui5yorSGYQ... to qDVe2mrpSgQdxra7p... ( #178144 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jimgraham@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-07 02:02:25 +00:00
Kishan Rathore
83081357ef
fix: findChildIndexCallback to take seperators into account for seperated named constructor in ListView and SliverList ( #174491 )
...
FindChildIndexCallback to take seperators into account for seperated
named constructor in ListView and SliverList
fixes : #174261
## Migration guide
https://github.com/flutter/website/pull/12636
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-11-07 01:09:17 +00:00
Mouad Debbar
1e94ac4f57
[web] Remove unnecessary android_sdk dep ( #178078 )
2025-11-06 23:43:06 +00:00
Kostia Sokolovskyi
c0e052941a
Add haptic notifications support. ( #177721 )
...
Closes https://github.com/flutter/flutter/issues/150029
### Description
- Adds `successNotification`, `warningNotification` and
`errorNotification` haptics to the framework
- Adds `UINotificationFeedbackTypeSuccess`,
`UINotificationFeedbackTypeWarning` and
`UINotificationFeedbackTypeError` haptics support on iOS
- Adds `HapticFeedbackConstants.CONFIRM` and
`HapticFeedbackConstants.REJECT` haptics support on Android
- Adds tests
| iOS | Android | Web |
|:-:|:-:|:-:|
| UINotificationFeedbackTypeSuccess | HapticFeedbackConstants.CONFIRM |
20ms vibration |
| UINotificationFeedbackTypeWarning |
HapticFeedbackConstants.KEYBOARD_TAP | 20ms vibration |
| UINotificationFeedbackTypeError | HapticFeedbackConstants.REJECT |
30ms vibration |
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-06 22:53:22 +00:00
Bruno Leroux
411566a2e2
Allow label to be used to compute InputDecorator Intrinsic width ( #178101 )
...
## Description
This PR adds `InputDecorator.maintainLabelSize` (similar to
`InputDecorator.maintainHintSize`) to allow the label to be used in the
intrinsic width calculation (if could be used for the intrinsic height
calculation later if needed).
I opted for this flag (and defaulting to false) because changing the
default calculation would probably break various usages.
See
https://github.com/flutter/flutter/issues/178099#issuecomment-3496116095
for why this change will be helpful to simplify and fix DropdownMenu
implementation.
## Before
The label might be cut off:
<img width="126" height="71" alt="Screenshot 2025-11-05 at 20 16 43"
src="https://github.com/user-attachments/assets/61d9f817-5c58-43f9-9307-976f9c124ec7 "
/>
## After
The label is entirely visible because it is part of the intrinsic width
calculation:
<img width="126" height="71" alt="Screenshot 2025-11-05 at 20 16 09"
src="https://github.com/user-attachments/assets/47360e17-3cde-4f05-8a6b-cc9e86644ffc "
/>
## Related Issue
Fixes [DropdownMenu menu panel does not close when pressing ESC and
requestFocusOnTap is
false](https://github.com/flutter/flutter/issues/177993 )
Part of https://github.com/flutter/flutter/issues/123797
## Tests
- Adds 4 tests.
- Updates 1 non-related test where I spotted some nits.
2025-11-06 21:45:20 +00:00
Matt Boetger
767fac1b8d
Respect product flavor abiFilters by adding a disable-abi-filtering Android project flag. ( #177753 )
...
This PR introduces a flag (`disable-abi-filtering`) that disables the
FlutterPlugin's abiFiltering on buildTypes. This should only be used
when the developers know what they are doing. Specifically this allows
developers to set their own abiFilters in ProductFlavors or
defaultConfig.
Because Gradle has complex merging logic, there is a hierarchy of
priority when calculating settings (like abiFilters). For example:
defaultConfig < productFlavors < buildTypes when combining the three
into the final build variant. If abiFilters are set in buildType, it
will override abiFilters in productFlavors.
When the FlutterPlugin executes, it cannot know about the developers
build.gradle settings and therefore we cannot add logic that checks to
see if abiFilters are set in productFlavors. Therefore, this flag gives
developers an escape hatch so they can implement what they want.
Fixes : #175845
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
2025-11-06 21:36:20 +00:00
zhongliugo
f19a80a142
Use aria-hidden attribute for platform view accessibility on web ( #177969 )
...
Use aria-hidden attribute for platform view accessibility on web
Before change:
https://map-1023-before.web.app/
After change:
https://map-1023-after.web.app/
Fixes #171948 .
Note: When a descendant element receives focus (for example, a marker),
the browser automatically overrides aria-hidden. This behavior is
correct and expected for accessibility compliance.
2025-11-06 21:02:02 +00:00
Kevin Moore
e979e166d6
[tool] Fix IP parsing by using Uri constructor ( #178083 )
...
Also DRY'd up use of `"any"` constant is several places.
Fixes https://github.com/flutter/flutter/issues/178082
2025-11-06 21:01:18 +00:00
engine-flutter-autoroll
31a8481cd1
Roll Skia from 68bdfbf5f80a to 116f237bb39d (6 revisions) ( #178121 )
...
https://skia.googlesource.com/skia.git/+log/68bdfbf5f80a..116f237bb39d
2025-11-06 nicolettep@google.com Use SkColor helpers for color
generation in SkPixmap
2025-11-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 5a075c3f5e7c to c8f0766414a4 (10 revisions)
2025-11-06 fmalita@google.com [skottie] Fix nullptr deref in
TextAnimator
2025-11-06 robertphillips@google.com Suppress Ubuntu24.04+QuadroP400
failures on the tree
2025-11-06 kjlubick@google.com Remove no-op gn flag
2025-11-06 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
ANGLE from c983fa9dfb61 to 8c5e129d48ad (7 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,jimgraham@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-06 20:23:34 +00:00
auto-submit[bot]
1d7845ae00
Reverts "Update all uses of mutable SkPath methods to use SkPathBuilder ( #177738 )" ( #178125 )
...
<!-- start_original_pr_link -->
Reverts: flutter/flutter#177738
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: chingjun
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Broke internal tests. Some shapes are not drawn.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: kjlubick
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {jason-simmons}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
Skia is removing the APIs that allow changing an SkPath. This updates
those callsites to use SkPathBuilder where appropriate.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
<!-- end_revert_body -->
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
2025-11-06 19:50:19 +00:00
engine-flutter-autoroll
200d913684
Roll Packages from 3d926aa495d3 to f13bad3649af (12 revisions) ( #178111 )
...
3d926aa495...f13bad3649stuartmorgan@google.com Add Linux CODEOWNERS
(flutter/packages#10235 )
2025-11-06 stuartmorgan@google.com [ci] Add missing deps
(flutter/packages#10366 )
2025-11-05 65709676+huanghui1998hhh@users.noreply.github.com [go_router]
ShellRoute will merge GoRouter's observers (flutter/packages#9436 )
2025-11-05 dgyurov@gmail.com [pigeon] Update analyzer version
(flutter/packages#10352 )
2025-11-04 stuartmorgan@google.com [tool] Remove use of FETCH_HEAD
(flutter/packages#10357 )
2025-11-04 engine-flutter-autoroll@skia.org Roll Flutter from
027f2e410241 to e5d5c01850f2 (73 revisions) (flutter/packages#10362 )
2025-11-04 8490712+ruicraveiro@users.noreply.github.com
[camera_platform_interface] Adds support for video stabilization to
camera_platform_interface (flutter/packages#10337 )
2025-11-04 filiph@users.noreply.github.com [google_maps_flutter] Raise
`MapUsedAfterWidgetDisposedError` when map controller used after map
disposed (flutter/packages#9242 )
2025-11-04 tarrinneal@gmail.com [pigeon] Replace containsKey with
contains in Kotlin generator (flutter/packages#10274 )
2025-11-04 116356835+AbdeMohlbi@users.noreply.github.com [video_player]
Remove `package` in example `AndroidManifest.xml` file
(flutter/packages#10245 )
2025-11-04 me@nils.re [flutter_svg] Fixes typo of
`allowDrawingOutsideViewBox` in doc comments. (flutter/packages#10256 )
2025-11-04 stuartmorgan@google.com [in_app_purchase] Remove use of
Pigeon's Dart test generator (flutter/packages#10328 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-06 18:49:42 +00:00
Gray Mackall
77cb77b947
Fix verified input integration test without breaking the rest of the devicelab tests (attempt 5) ( #178093 )
...
Reland of https://github.com/flutter/flutter/pull/178018/
On top of the above:
Only gets the adb path if it is an android test, and also try catches to
be doubly safe.
Note that the above PR did work for the android case, so as long as we
don't break the non-android case the test will be running now:
https://ci.chromium.org/ui/p/flutter/builders/staging/Linux_pixel_7pro%20android_verified_input_test/228/overview
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Gray Mackall <mackall@google.com>
2025-11-06 18:38:26 +00:00
Ivan Inozemtsev
7dc982e1b1
Roll Dart SDK to 3.11.0-93.1.beta ( #177988 )
...
Roll Dart 3.11 beta1 candidate into the engine. The new dart revision
differs from the current dart revision only in version number:
https://dart.googlesource.com/sdk/+diff/156bf665dba4ab17a47e29e22512beff8609ae1e..cf69b162e2eb106a907f328c9c15ed2275c1f9cc .
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-06 17:40:13 +00:00
Victoria Ashworth
ac3b91db0d
Hide SwiftPM warnings on non-mac platforms ( #178073 )
...
Fixes https://github.com/flutter/flutter/issues/162594 .
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-06 15:40:15 +00:00
engine-flutter-autoroll
c458833839
Roll Skia from 5c4e1352128f to 68bdfbf5f80a (2 revisions) ( #178107 )
...
https://skia.googlesource.com/skia.git/+log/5c4e1352128f..68bdfbf5f80a
2025-11-06 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
Dawn from 23e882a42a2f to 516bf37a739d (27 revisions)
2025-11-06 fmalita@google.com [skottie] Remove
SK_ENABLE_SKOTTIE_FILLRULE guard
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,jimgraham@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-06 15:09:10 +00:00
Elijah Okoroh
aebe02b44f
Update .ci.yaml in flutter/flutter to use 15.5 ( #177939 )
...
Update .ci.yaml in flutter/flutter to use 15.5
Note: (Not all devicelab bots are macOS 15.5. Some are 15.1 and 15.6.1)
*List which issues are fixed by this PR. You must list at least one
issue. An issue is not required if the PR fixes something trivial like a
typo.*
Fixes #177394
*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-06 15:03:00 +00:00
Kaylee Lubick
6925f8b815
Update all uses of mutable SkPath methods to use SkPathBuilder ( #177738 )
...
Skia is removing the APIs that allow changing an SkPath. This updates
those callsites to use SkPathBuilder where appropriate.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-06 14:46:25 +00:00
Robert Ancell
c5e809a998
Remove WindowingOwner.hasTopLevelWindows ( #178033 )
...
This function doesn't seem to serve any purpose.
Top level is not a term we are currently using in the multi window code.
If we want to track if we have open windows, this can be done in the
Flutter framework - it doesn't need to be done at the platform level.
2025-11-06 13:11:28 +00:00
Bruno Leroux
c093967de2
Fix DropdownMenu escape key does not close the menu ( #178002 )
...
## Description
This PR fixes escape key not closing the menu when
`DropdownMenu.requestFocusOnTap` is false.
## Related Issue
Fixes [DropdownMenu menu panel does not close when pressing ESC and
requestFocusOnTap is
false](https://github.com/flutter/flutter/issues/177993 )
Part of https://github.com/flutter/flutter/issues/123797
## Tests
- Adds 3 tests.
- Updates 2 non-related tests where I spotted some nits.
2025-11-06 10:34:26 +00:00
Tirth
6f4a8c784e
Update documentation tool reference in image.dart ( #177782 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
Uses `@tool sample` instead of `@tool dartdoc` for one of the
ImageProvider's example in docs. Similar fix as #175256 .
Fixes #155935
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-06 07:06:26 +00:00
engine-flutter-autoroll
d0f3b4b8f3
Roll Skia from 4eb2383d38f2 to 5c4e1352128f (5 revisions) ( #178094 )
...
https://skia.googlesource.com/skia.git/+log/4eb2383d38f2..5c4e1352128f
2025-11-06
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-11-05 kjlubick@google.com Fix Gofmt issue
2025-11-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms
from 96d9171c94b9 to 026f8a969740 (1 revision)
2025-11-05 kjlubick@google.com Remove gpu version specificity for P400s
2025-11-05 michaelludwig@google.com [vk] Add RGBA10x6 format to
VkFormatBytesPerBlock
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,jimgraham@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-06 07:00:10 +00:00
Lau Ching Jun
f066ed6591
Revert "Refactor OverlayPortal semantics ( #173005 )" ( #178007 )
...
This reverts commit ccf6466b14e144971a7d65983bdd16459d65a62a.
~This is a test PR for investigation, the commit seems to be breaking a
customer app.~
The original PR caused b/457553134
2025-11-06 03:41:26 +00:00
auto-submit[bot]
cffd3ab54f
Reverts "Fix verified input test failure in CI (attempt 4) ( #178018 )" ( #178089 )
...
<!-- start_original_pr_link -->
Reverts: flutter/flutter#178018
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jtmcdole
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: The call to `adbPath` causes the tool to fail if
ANDROID isn't installed.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: gmackall
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {mboetger}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
I think this should actually fix at least the current issue. The last PR
added logs
https://github.com/flutter/flutter/pull/178005/
And we can now see:
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8699078049543853521/+/u/run_android_verified_input_test/stdout
```
[2025-11-04 18:33:56.587985] [STDOUT] stdout: [+2998 ms] Expected: <0>
[2025-11-04 18:33:56.588075] [STDOUT] stdout: [ ] Actual: <1>
[2025-11-04 18:33:56.588106] [STDOUT] stdout: [ ] Stdout:
[2025-11-04 18:33:56.588135] [STDOUT] stdout: [ ] Stderr: adb server version (41) doesn't match this client (39); killing...
```
The test was directly invoking adb (using whatever is on the path),
while the devicelab harness has a more complicated way of finding adb
and then invoking it directly. So it seems they have found different adb
versions.
This pr pipes the devicelab adb path through to the individual test, so
the test can reference the same adb, and then uses it. This is again
sort of an abuse of this environment map (if one of the tests decided to
use these environment variables we would be in a weird state), but I
think it isn't too bad, and again I think it is reasonable because any
android devicelab test may wish to use adb, so this solution isn't hyper
specific to the problem.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
<!-- end_revert_body -->
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
2025-11-06 02:27:27 +00:00
auto-submit[bot]
b64f673f92
Reverts "[web] Unify Surface code between Skwasm and CanvasKit ( #177138 )" ( #178085 )
...
<!-- start_original_pr_link -->
Reverts: flutter/flutter#177138
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: harryterkelsen
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: broke skwasm benchmarks
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: harryterkelsen
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {mdebbar}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
This PR introduces a significant refactoring of the web engine's
rendering layer by unifying the `Surface` and `Rasterizer`
implementations. These components have been moved from being
renderer-specific to a generic `compositing` directory, making the
architecture more modular and easier to maintain. The rasterizers are
now renderer-agnostic and are provided with renderer-specific surface
factories via dependency injection. A new `CanvasProvider` abstraction
has also been introduced to manage the lifecycle of the underlying
canvas elements.
A key outcome of this work is that the Skwasm backend now correctly
handles WebGL context loss events. This was achieved by refactoring
`SkwasmSurface` to allow the Dart side to manage the `OffscreenCanvas`
lifecycle. A communication channel between the main thread and the web
worker is now used to gracefully handle context loss and recovery. This
effort also included fixing several related bugs around surface sizing,
resource cleanup, and callback handling in multi-surface scenarios.
To validate these changes, new testing APIs have been added to allow for
the creation of renderer-agnostic surface tests. A new test file,
`surface_context_lost_test.dart`, has been added to verify the context
loss and recovery behavior across all supported renderers, ensuring the
new architecture is robust and reliable.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
<!-- end_revert_body -->
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
2025-11-06 00:22:38 +00:00
Gray Mackall
40acb0449f
Fix verified input test failure in CI (attempt 4) ( #178018 )
...
I think this should actually fix at least the current issue. The last PR
added logs
https://github.com/flutter/flutter/pull/178005/
And we can now see:
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8699078049543853521/+/u/run_android_verified_input_test/stdout
```
[2025-11-04 18:33:56.587985] [STDOUT] stdout: [+2998 ms] Expected: <0>
[2025-11-04 18:33:56.588075] [STDOUT] stdout: [ ] Actual: <1>
[2025-11-04 18:33:56.588106] [STDOUT] stdout: [ ] Stdout:
[2025-11-04 18:33:56.588135] [STDOUT] stdout: [ ] Stderr: adb server version (41) doesn't match this client (39); killing...
```
The test was directly invoking adb (using whatever is on the path),
while the devicelab harness has a more complicated way of finding adb
and then invoking it directly. So it seems they have found different adb
versions.
This pr pipes the devicelab adb path through to the individual test, so
the test can reference the same adb, and then uses it. This is again
sort of an abuse of this environment map (if one of the tests decided to
use these environment variables we would be in a weird state), but I
think it isn't too bad, and again I think it is reasonable because any
android devicelab test may wish to use adb, so this solution isn't hyper
specific to the problem.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Co-authored-by: Gray Mackall <mackall@google.com>
2025-11-05 22:43:27 +00:00
Jaineel Mamtora
8892bc8fed
fix: inconsistent horizontal spacing between hours and mins in time picker for non-english language ( #173706 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
This PR aims to fix an open issue:
https://github.com/flutter/flutter/issues/173621
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
## Screenshots
Please find below the _before_ and _after_ screenshots
- Before
<img width="294" height="264" alt="before_fixing_spacing"
src="https://github.com/user-attachments/assets/ce519c72-cb5e-4f08-8976-abb01f9eb76d "
/>
- After
<img width="294" height="261" alt="after_fixing_spacing"
src="https://github.com/user-attachments/assets/f010cbbf-680d-495b-a028-16c7fbdb9a09 "
/>
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-11-05 22:15:32 +00:00
