DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
36,008 Commits 882 Branches 1,069 Tags
Commit Graph

36008 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Zachary Anderson
7de6e0dcc1 Add commands to rbe.md (flutter/engine#52442) 2024-04-29 23:00:25 +00:00
Chinmay Garde
a5ed4ed7d5 Add a host_debug_unopt_arm64 macOS configuration. (flutter/engine#52443) 
This is the default development configuration for local engine host builds on the corp M1 macOS boxes.
 2024-04-29 22:55:05 +00:00
skia-flutter-autoroll
b91460396a Roll Skia from 9ffb18cccf2a to 29a483abf358 (2 revisions) (flutter/engine#52441) 
https://skia.googlesource.com/skia.git/+log/9ffb18cccf2a..29a483abf358

2024-04-29 johnstiles@google.com Factor out fold_two_constants into a helper function.
2024-04-29 johnstiles@google.com Remove unnecessary virtual from method.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-29 22:30:05 +00:00
skia-flutter-autoroll
8741c56c71 Roll Skia from 953589c71b4a to 9ffb18cccf2a (4 revisions) (flutter/engine#52438) 
https://skia.googlesource.com/skia.git/+log/953589c71b4a..9ffb18cccf2a

2024-04-29 jamesgk@google.com [graphite] Analytic blur for rrects
2024-04-29 bungeman@google.com Roll depot_tools and recipes-py
2024-04-29 brianosman@google.com Simplify/optimize SkPath::hasOnlyMoveTos
2024-04-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from a2456e74640e to 5eaadb2feb71 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-29 20:21:15 +00:00
skia-flutter-autoroll
19355a7425 Roll Skia from f7bfa8eef5b5 to 953589c71b4a (6 revisions) (flutter/engine#52437) 
https://skia.googlesource.com/skia.git/+log/f7bfa8eef5b5..953589c71b4a

2024-04-29 brianosman@google.com Add SkArc (in)equality operators
2024-04-29 johnstiles@google.com Add a FixedArray class to shrink SkSL::ComponentArray.
2024-04-29 johnstiles@google.com Clean up TArray tests and add a comparison test.
2024-04-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from b0e42fbd5e63 to f83e07df2219
2024-04-29 kjlubick@google.com Remove reference to deleted file
2024-04-29 johnstiles@google.com Remove unused version of Swizzle::Convert.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-29 18:12:23 +00:00
Zachary Anderson
448613ae74 Remove references to goma (flutter/engine#52411) 
This removes goma most places except for the arguments to the `gn`
script, which are referenced by recipes. This does not remove goma
capabilities from the GN build entirely. That requires changes in the
buildroot which have to be staged after this change.
 2024-04-29 09:40:16 -07:00
Kaylee Lubick
b763678f03 Make SkUnicode explicitly instead of relying on SkParagraph to make it for us (flutter/engine#52086) 
In https://skia-review.googlesource.com/c/skia/+/838417 Skia staged the
removal of automatically creating an SkUnicode as part of the effort to
make Skia more modular. Clients will now have to construct and SkUnicode
and pass it to SkParagraph to provide the appropriate data. Flutter
sometimes uses ICU and sometimes uses a "client" SkUnicode which makes
use of the browser APIs to get the data.

We should come back to the skwasm code especially, because right now
skwasm gets the data necessary to make an SkUnicode::Client, but stores
it in the ParagraphBuilder, just to take it out again later to make the
SkUnicode::Client and pass that back into the ParagraphBuilder. skwasm
should just create the SkUnicode::Client directly and pass it to the
ParagraphBuilder::make().

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-04-29 11:59:33 -04:00
skia-flutter-autoroll
a93cd5f570 Roll Skia from 27e872349963 to f7bfa8eef5b5 (1 revision) (flutter/engine#52436) 
https://skia.googlesource.com/skia.git/+log/27e872349963..f7bfa8eef5b5

2024-04-29 johnstiles@google.com Report an error if `sk_Caps` is used as an SkSL expression.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-29 14:48:33 +00:00
Jonah Williams
8f21d27541 [Impeller] fix GLES image upload. (flutter/engine#52430) 
TLDR: this was a load bearing closure.

See https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_pixel_7pro%20complex_layout_scroll_perf_impeller_gles__timeline_summary/1492/overview
 2024-04-29 14:24:21 +00:00
skia-flutter-autoroll
6a25ce6b0f Roll Skia from aeab79038011 to 27e872349963 (1 revision) (flutter/engine#52435) 
https://skia.googlesource.com/skia.git/+log/aeab79038011..27e872349963

2024-04-29 robertphillips@google.com [graphite] Revert KeyContext copy ctor behavior to earlier state

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-29 13:36:10 +00:00
skia-flutter-autoroll
df5eafad93 Roll Skia from c720e2446926 to aeab79038011 (1 revision) (flutter/engine#52434) 
https://skia.googlesource.com/skia.git/+log/c720e2446926..aeab79038011

2024-04-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 94a452f2f2ae to bca2b386b5e5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-29 07:17:01 +00:00
skia-flutter-autoroll
10be137655 Roll Skia from 1a5436d50954 to c720e2446926 (1 revision) (flutter/engine#52433) 
https://skia.googlesource.com/skia.git/+log/1a5436d50954..c720e2446926

2024-04-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 07bdf2c05272 to 94a452f2f2ae (20 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-29 05:59:30 +00:00
skia-flutter-autoroll
9e43a8b820 Roll Fuchsia Linux SDK from bIUvi3y4gRFxMSKV3... to TFm2_qWC2xpkzk8QS... (flutter/engine#52432) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-29 04:35:34 +00:00
skia-flutter-autoroll
a1fc2188c2 Roll Skia from e3dfcd1b25af to 1a5436d50954 (1 revision) (flutter/engine#52431) 
https://skia.googlesource.com/skia.git/+log/e3dfcd1b25af..1a5436d50954

2024-04-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 5c853cf916a0 to a2456e74640e (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-29 04:19:18 +00:00
Robert Ancell
2ab69c9f42 Use a AT-SPI socket/plug to export the Flutter accessibility state. (flutter/engine#52355) 
This will be useful when using GTK4, which doesn't support custom a11y
code in GTK and will require the Flutter code to be exported in a plug.
 2024-04-29 09:34:20 +12:00
Jonah Williams
584a0394aa [Impeller] remove image upload from IO thread, limit concurrent worker threads. (flutter/engine#52423) 
Fixes https://github.com/flutter/flutter/issues/123058
Fixes https://github.com/flutter/flutter/issues/135443

We're currently using the IO thread to bottleneck image uploads. Instead, just use fewer concurrent worker threads - and cap the limit at something small. For a Pixel device, this should use about 2 threads maximum, instead of  5 (4 worker and 1 IO).
 2024-04-28 17:22:15 +00:00
Jonah Williams
185f7cc518 [Impeller] when creating new pipeline variant block on current thread, re-persist dirty pipeline cache. (flutter/engine#52375) 
Current diagram of how PSO variants are created (after first bootstrap)

```
Raster thread.                             Worker Thread
1.  Check Pipeline Cache
2. Pipeline Cache Empty
3. Create Promise
4. Spawn Worker                     ->      Compile Pipeline
5. Block On Future.                       ..                                                    
6.
7. Resolve                          <-      Complete Future
```

This is a serialized workload due to blocking on future completion. But performing it on two threads means that we're also adding in the somewhat random cost of thread scheduling and or getting deprioritized.

Instead when creating variants, block on the current thread. Now if we knew all the variants we need to create for a frame ahead of time, we could spawn one or more works to creat them more quickly. This would require more work though.

While I'm at it. Update the pipeline cache to persist every 50 frames, if it has added a new shader.

part of https://github.com/flutter/flutter/issues/129660
 2024-04-28 17:22:13 +00:00
skia-flutter-autoroll
229c530d87 Roll Skia from 362737e0d9ad to e3dfcd1b25af (2 revisions) (flutter/engine#52429) 
https://skia.googlesource.com/skia.git/+log/362737e0d9ad..e3dfcd1b25af

2024-04-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from a42fa34aea30 to 94a452f2f2ae
2024-04-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 9dbe6ddebdf8 to 5c853cf916a0 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-28 07:26:22 +00:00
skia-flutter-autoroll
064bd92699 Roll Dart SDK from 7173b4dd0163 to 9eb838fa00af (3 revisions) (flutter/engine#52428) 
https://dart.googlesource.com/sdk.git/+log/7173b4dd0163..9eb838fa00af

2024-04-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-109.0.dev
2024-04-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-108.0.dev
2024-04-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-107.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-28 05:00:23 +00:00
skia-flutter-autoroll
538b6634b8 Roll Fuchsia Linux SDK from SVcynyah0BO4d5mRM... to bIUvi3y4gRFxMSKV3... (flutter/engine#52427) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-28 03:02:22 +00:00
Jason Simmons
3645fa8b52 Manual Dart roll to 7173b4dd0163 (flutter/engine#52425) 
Updates test expectations for a change to the expect.dart library
 2024-04-28 00:55:24 +00:00
skia-flutter-autoroll
84e64222c6 Roll Skia from 7e92a0458e21 to 362737e0d9ad (1 revision) (flutter/engine#52417) 
https://skia.googlesource.com/skia.git/+log/7e92a0458e21..362737e0d9ad

2024-04-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 07bdf2c05272 to 57b1569a232f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-27 03:57:51 +00:00
skia-flutter-autoroll
4b420e4cac Roll Skia from a819e9fa3016 to 7e92a0458e21 (2 revisions) (flutter/engine#52415) 
https://skia.googlesource.com/skia.git/+log/a819e9fa3016..7e92a0458e21

2024-04-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 736920240f0b to 9dbe6ddebdf8 (7 revisions)
2024-04-26 kjlubick@google.com Add missing visibility to Bazel rule

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-27 02:23:09 +00:00
skia-flutter-autoroll
52c218b71f Roll Fuchsia Linux SDK from Rc4K-_-ym7vwUzXyo... to SVcynyah0BO4d5mRM... (flutter/engine#52413) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-27 01:46:56 +00:00
skia-flutter-autoroll
49c1cbaa6d Roll Skia from 3401ef9641cc to a819e9fa3016 (17 revisions) (flutter/engine#52412) 
https://skia.googlesource.com/skia.git/+log/3401ef9641cc..a819e9fa3016

2024-04-26 johnstiles@google.com Allow pre/post-increment on vectors and matrices.
2024-04-26 johnstiles@google.com Add support for non-scalar pre/postincrement in SPIR-V.
2024-04-26 kjlubick@google.com Make module for mock ganesh backend
2024-04-26 jvanverth@google.com [graphite] Compute largest valid UV inset rectangle for subsets.
2024-04-26 johnstiles@google.com Add support for matrix pre/postincrement in Metal.
2024-04-26 brianosman@google.com Properly pre-size path storage in addOval and addRRect
2024-04-26 johnstiles@google.com Add SPIR-V `writeBinaryOperationComponentwiseIfMatrix`.
2024-04-26 johnstiles@google.com Fix signedness of format string.
2024-04-26 jvanverth@google.com [graphite] Remove unnecessary checks in UV inset setup.
2024-04-26 michaelludwig@google.com [graphite] Dst copy tasks stored in DrawTask not root Recorder task list
2024-04-26 scroggo@google.com Revert "Use a VMA block size of only 64k"
2024-04-26 brianosman@google.com Improve SkArc ergonomics, use it everywhere but SkCanvas
2024-04-26 michaelludwig@google.com [graphite] Assume sources are already instantiated in copies
2024-04-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e65031c8b1d6 to 736920240f0b (1 revision)
2024-04-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from e6a1f0f0732a to 07bdf2c05272 (10 revisions)
2024-04-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from e6a1f0f0732a to 07bdf2c05272
2024-04-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from c771d4aa9a32 to e65031c8b1d6 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-27 00:41:59 +00:00
Tong Mu
94448fc97f Move PointerDataPacketConverter from PlatformView to RuntimeController (flutter/engine#51952) 
This is a refactor that moves the `PointerDataPacketConverter` from `PlatformView` to `RuntimeController`. 

This change is made for the following reasons:
- Currently, the pointer data conversion contains no platform specific logic (because the current converter's only responsibility is to make the event sequence conform Flutter's protocol). Therefore these logics should reside in a platform-independent place.
- The converter typically converts one event to many. It's better to have this conversion later than earlier.
- It removes a member from `PlatformView`, making it closer to a pure virtual class.

The reason to choose `RuntimeController` as the destination is because `RuntimeController` manages a map for views, which is required for the converter to implement a later patch https://github.com/flutter/engine/pull/51925.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-04-26 23:45:21 +00:00
skia-flutter-autoroll
9b0d851082 Manual roll Dart SDK from 9936bafe5eb1 to 919c7cab870b (1 revision) (flutter/engine#52409) 
Manual roll requested by aam@google.com

https://dart.googlesource.com/sdk.git/+log/9936bafe5eb1..919c7cab870b

2024-04-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-105.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-26 22:20:23 +00:00
skia-flutter-autoroll
dc5d935340 Roll Dart SDK from 9936bafe5eb1 to 919c7cab870b (1 revision) (flutter/engine#52407) 
https://dart.googlesource.com/sdk.git/+log/9936bafe5eb1..919c7cab870b

2024-04-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-105.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-26 21:02:05 +00:00
gabeschine
6b3f0f17dc Delete errant back-tick in CONTRIBUTING.md (flutter/engine#52324) 
Delete an extra "`" in `CONTRIBUTING.md` in a code block.

No issues associated with this change.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-04-26 20:06:47 +00:00
Dustin Green
1bdc2a83c6 [fuchsia] route fuchsia.sysmem2.Allocator (flutter/engine#52187) 
Fuchsia's fake-display will be migrating to sysmem2, which requires fuchsia.sysmem2.Allocator to be routed in a few places.

fixes flutter/flutter#146858

- [y] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
- [y] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
- [na] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
- [y] I listed at least one issue that this PR fixes in the description above.
- [fixes to existing tests] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests.
- [na] I updated/added relevant documentation (doc comments with `///`).
- [na / googler] I signed the [CLA].
- [y] All existing and new tests are passing.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-04-26 20:05:09 +00:00
Jonah Williams
3cae3c9f7b [Impeller] clamp maximum glyph scale. (flutter/engine#52403) 
Workaround for https://github.com/flutter/flutter/issues/136112

If the glyph scale is too large, say in the hundreds or thousands, then glyph itself will likely be too big to fit in the atlas. Instead of failing to render - clamp the scale (not the size, which is bounds * scale) to a much lower scaling parameter.
 2024-04-26 17:06:13 +00:00
Zachary Anderson
2015604d7a Add markdown docs about RBE (flutter/engine#52394) 2024-04-26 09:34:10 -07:00
skia-flutter-autoroll
02d2b5218e Roll Skia from 52083c205016 to 3401ef9641cc (5 revisions) (flutter/engine#52402) 
https://skia.googlesource.com/skia.git/+log/52083c205016..3401ef9641cc

2024-04-25 jamesgk@google.com Move some Ganesh rrect blur code to gpu/
2024-04-25 michaelludwig@google.com [graphite] Remove 'k' from op labels
2024-04-25 michaelludwig@google.com Fix protected setting in unit test
2024-04-25 fmalita@google.com [svg] Add new private header to public.bzl
2024-04-25 kjlubick@google.com Apply fixes to coretext Bazel targets

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-26 15:32:12 +00:00
Jason Simmons
bef76e554e Fix function type cast warnings for macOS embedder callbacks (flutter/engine#52377) 
The latest version of Clang is reporting warnings from the -Wcast-function-type-mismatch check when a function taking a __strong pointer parameter is converted to a void* parameter.
 2024-04-26 15:28:11 +00:00
skia-flutter-autoroll
dad62d2ab2 Roll Dart SDK from e1bc6a6bca79 to 9936bafe5eb1 (1 revision) (flutter/engine#52406) 
https://dart.googlesource.com/sdk.git/+log/e1bc6a6bca79..9936bafe5eb1

2024-04-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-104.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-26 10:03:27 +00:00
Brandon DeRosier
410b3e7ed3 [Flutter GPU] Add support for drawing Flutter GPU textures in the playground. (flutter/engine#52352) 2024-04-25 20:43:43 -07:00
skia-flutter-autoroll
39ff7b95b7 Roll Dart SDK from 29afb0500d51 to e1bc6a6bca79 (1 revision) (flutter/engine#52405) 
https://dart.googlesource.com/sdk.git/+log/29afb0500d51..e1bc6a6bca79

2024-04-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-103.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-26 02:21:05 +00:00
skia-flutter-autoroll
28e549398b Roll Fuchsia Linux SDK from PJBX8xxRnd5vCFnQM... to Rc4K-_-ym7vwUzXyo... (flutter/engine#52404) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-26 00:33:03 +00:00
Jenn Magder
59cd6af303 Remove "gclient sync" warning call during pre-rebase (flutter/engine#52342) 
Remove `pre-rebase` check from `gclient sync` warning, and instead remove the warning call from `pre_rebase_command`

Follow-up to https://github.com/flutter/engine/pull/52133#discussion_r1575447161
 2024-04-25 23:12:03 +00:00
skia-flutter-autoroll
7f8d6a3cf3 Roll Dart SDK from f9c9894a2500 to 29afb0500d51 (1 revision) (flutter/engine#52399) 
https://dart.googlesource.com/sdk.git/+log/f9c9894a2500..29afb0500d51

2024-04-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-102.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-25 22:24:23 +00:00
Jonah Williams
5935f48862 [Impeller] while we still have benchmarks, see if we're efficient enough for this to be faster. (flutter/engine#52398) 
We don't need to decode images to a malloc'd buffer, but this benchmarked as faster because we did so much allocation during the frame. Maybe this is better now? Lets run the benchmarks
 2024-04-25 21:12:10 +00:00
Jonah Williams
45d5af365f [Impeller] Vulkan validation off by default. (flutter/engine#52397) 
Fixes https://github.com/flutter/flutter/issues/142659

can be turned on via --enable-vulkan-validation cmd line flag.
 2024-04-25 21:04:04 +00:00
skia-flutter-autoroll
67c113eb55 Roll Skia from cb32ad619678 to 52083c205016 (1 revision) (flutter/engine#52396) 
https://skia.googlesource.com/skia.git/+log/cb32ad619678..52083c205016

2024-04-25 michaelludwig@google.com [graphite] Instantiate non-budgeted TextureProxies in Make()

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-25 20:52:22 +00:00
Jonah Williams
9dbe934a9b [Impeller] kick off registration and initial PSO compilation of runtime effect earlier. (flutter/engine#52381) 
I thought about changing this API so that it blocks on compilation, but I think that isn't necesasary as the workload can happen while the UI thread is building. Plus, even blocking on shader completion does not guarantee that we won't need to compile a variant anyway.

While I was at it I moved the descriptor sets computation to the runtime effect constructor.

With this change the pipleine variant used during the frame is produced much faster than the initial 12ms compilation.

![image](https://github.com/flutter/engine/assets/8975114/42626676-0a71-4503-a3e9-4109c36fbbef)

Fixes https://github.com/flutter/flutter/issues/113719
Fixes https://github.com/flutter/flutter/issues/141222
 2024-04-25 20:23:56 +00:00
Jonah Williams
b14463a57b [Impeller] combine text shaders. (flutter/engine#52392) 
Combine both text shaders into one. One more down!

https://github.com/flutter/flutter/issues/143540
 2024-04-25 20:18:13 +00:00
skia-flutter-autoroll
8e9dd76646 Roll Skia from 67bba57bfe80 to cb32ad619678 (2 revisions) (flutter/engine#52395) 
https://skia.googlesource.com/skia.git/+log/67bba57bfe80..cb32ad619678

2024-04-25 jvanverth@google.com [graphite] Fix edges of YUV images.
2024-04-25 fmalita@google.com [svg] Optional ellipse radii

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-25 18:42:05 +00:00
skia-flutter-autoroll
a36407757b Roll Dart SDK from b5f51d886819 to f9c9894a2500 (1 revision) (flutter/engine#52393) 
https://dart.googlesource.com/sdk.git/+log/b5f51d886819..f9c9894a2500

2024-04-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-101.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-25 17:58:26 +00:00
skia-flutter-autoroll
3a3e735e23 Roll Skia from b440433e2df5 to 67bba57bfe80 (1 revision) (flutter/engine#52391) 
https://skia.googlesource.com/skia.git/+log/b440433e2df5..67bba57bfe80

2024-04-25 robertphillips@google.com [graphite] Swap the PrecompileShaders and Priv LocalMatrix factories

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-25 17:13:06 +00:00
Zachary Anderson
c04e13ac47 Remove goma support from impeller-cmake-example (flutter/engine#52390) 2024-04-25 10:05:23 -07:00
Jonah Williams
dc65cc62c1 [Impeller] delete specific vertices shader. (flutter/engine#52360) 
Once https://github.com/flutter/engine/pull/52348 and https://github.com/flutter/engine/pull/52345 land we can delete this shader

Part of https://github.com/flutter/flutter/issues/143540
 2024-04-25 16:48:13 +00:00