DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
29,546 Commits 882 Branches 1,069 Tags
Commit Graph

22654 Commits

Author SHA1 Message Date
Jonah Williams
93351f1448 [Impeller] dont use concurrent runner to decode images on Android. (flutter/engine#42944) 
Even with separate allocators and queues, I think that using the concurrent runner is just overloading the phone.

On Android force it all onto the I/O thread.

https://github.com/flutter/flutter/issues/128919
 2023-06-18 03:54:04 +00:00
skia-flutter-autoroll
281d006dfe Roll Fuchsia Linux SDK from Au1gd3XLMuSt1Z4oh... to -PsA0LDB2FdS_4_vK... (flutter/engine#42959) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-17 19:23:14 +00:00
Brandon DeRosier
080271007d [Impeller] Print malioc errors on CI (flutter/engine#42906) 
Resolves https://github.com/flutter/flutter/issues/128989.

Also bumps the buildroot to head for:
https://github.com/flutter/buildroot/pull/744
 2023-06-16 21:37:37 -07:00
skia-flutter-autoroll
3675e9050d Roll Fuchsia Linux SDK from -NW1eatBbmjvLaIcV... to Au1gd3XLMuSt1Z4oh... (flutter/engine#42948) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-17 03:07:10 +00:00
Siva
2c57a3f9fa Fix analyzer warnings (prefer_final_in_for_each is now the default) (flutter/engine#42943) 
The analyzer option `prefer_final_in_for_each` has been made the default
and this has triggered new warnings.
 2023-06-16 17:33:59 -07:00
skia-flutter-autoroll
b00436f1bc Roll Skia from 64fa632d3b01 to dc11c7ddb33f (3 revisions) (flutter/engine#42939) 
https://skia.googlesource.com/skia.git/+log/64fa632d3b01..dc11c7ddb33f

2023-06-16 johnstiles@google.com Fix some outdated comments.
2023-06-16 brianosman@google.com Stop suppressing divide-by-zero errors in SkScalarInvert
2023-06-16 herb@google.com Move SkPoint to base

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-16 23:10:31 +00:00
skia-flutter-autoroll
dec05499a1 Roll Skia from 01f3be45e0d6 to 64fa632d3b01 (3 revisions) (flutter/engine#42937) 
https://skia.googlesource.com/skia.git/+log/01f3be45e0d6..64fa632d3b01

2023-06-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 58c6e1ea988a to 8ca65cb391f4 (6 revisions)
2023-06-16 johnstiles@google.com Factor apart Program::dump into a helper class.
2023-06-16 herb@google.com Use float for SkPoint's coordinates

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-16 22:00:19 +00:00
Hassan
5e05d8b967 [web] Fix for Safari autofill flickering bug (flutter/engine#42830) 
Safari web autofill has an issue where the autofill dialog flickers and doesn't completely render and allow users to fill any forms. 

This is caused by a collision between default browser behavior on the `pointerdown` event and the programatic focusing of our inputs. 

### Problem

When we click into an input, the element is created, placed, and (explicitly) focused.  However, all of this is done before the `pointerdown` event can finish.  Since all `pointerdown` elements target the `flutter-view` (formerly `flt-glass-pane`), default browser behavior is to trigger a `blur` event since the target doesn't match what's currently focused, which is the input element.  This doesn't manifest into most text editing issues because we listen for `blur` events on the `input` and call `focus()`.  However, in Safari, this near-instant focus/blur results in the disappearance of the autofill popup. 

The current chain of events looks like: 

`pointerdown` event starts -> input is created + focused -> `pointerdown` event ends, and triggers a `blur` -> input refocuses on `blur`

### Solution

This change ensures that we don't focus the input until after the `pointerdown` event concludes, thus preventing any rapid-fire `blur` event from being emitted.  We do this via wrapping the focus logic within a zero-duration Timer.  

The new chain of events looks like:

`pointerdown` event starts -> `pointerdown` event ends ->  input is created + focused

### Alternative approach

Note: Another option was to call `preventDefault()` on the `pointerdown` event to prevent the `blur` from occurring that way.  There may be unintended side effects from that approach, especially as it relates to platform views.  The surface area of the chosen approach is much more contained and should result in no side effects outside of Safari Desktop's text editing strategy. 

<img width="699" alt="Screenshot 2023-06-15 at 7 34 02 PM" src="https://github.com/flutter/engine/assets/110993981/3548d1ea-65f7-412f-b3c7-f94db2658127">

Fixes https://github.com/flutter/flutter/issues/127960
 2023-06-16 21:48:59 +00:00
Jonah Williams
68ce594530 [Impeller] correct default PSO pixel format and sample count. (flutter/engine#42902) 
Despite compiling an initial PSO variant for every shader, in practice these were completely useless as they had a sample count of 1 (instead of 4 for MSAA) and an invalid pixel format.

Correct the defaults so they may be usful.

Not enough to fix https://github.com/flutter/flutter/issues/128963 , because we still have far too much state for Vulkan to handle
 2023-06-16 20:53:02 +00:00
skia-flutter-autoroll
a6e9576963 Roll Skia from 90dae91b2242 to 01f3be45e0d6 (4 revisions) (flutter/engine#42934) 
https://skia.googlesource.com/skia.git/+log/90dae91b2242..01f3be45e0d6

2023-06-16 robertphillips@google.com Convert rest of affected GMs and tests over to new tiled image API
2023-06-16 robertphillips@google.com Move tiling utility methods to shareable location
2023-06-16 brianosman@google.com Fix return type of Benchmark::getSize
2023-06-16 jvanverth@google.com [graphite] Add onCopyTextureToTexture for the Vulkan backend.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-16 20:49:46 +00:00
skia-flutter-autoroll
e8a1d6b948 Roll Skia from 20e9cc928715 to 90dae91b2242 (5 revisions) (flutter/engine#42932) 
https://skia.googlesource.com/skia.git/+log/20e9cc928715..90dae91b2242

2023-06-16 brianosman@google.com Fix incorrect filename for WGSL ClampUInt
2023-06-16 johnstiles@google.com Add Type::slotType(n).
2023-06-16 johnstiles@google.com Add WGSL support for common-function intrinsics.
2023-06-16 jmbetancourt@google.com track Color and Opacity slots through new SlotManager
2023-06-16 lovisolo@google.com [gm] Make GPU backend dependency conditional on SK_GANESH constant.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-16 19:39:53 +00:00
skia-flutter-autoroll
10994cebdc Roll Skia from a4ad5b369313 to 20e9cc928715 (3 revisions) (flutter/engine#42926) 
https://skia.googlesource.com/skia.git/+log/a4ad5b369313..20e9cc928715

2023-06-16 jvanverth@google.com [graphite] Set Vulkan viewport and scissor
2023-06-16 johnstiles@google.com Reject first-class arrays on initializers in strict-ES2 mode.
2023-06-16 johnstiles@google.com Use IRHelpers class to assemble matrix-multiply workaround.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-16 18:28:55 +00:00
gaaclarke
2b5c1f8d95 Revert "Add deprecations to PlatformMessage stuff" (flutter/engine#42921) 
Reverts flutter/engine#42580
 2023-06-16 10:54:40 -07:00
Jacob MacDonald
660bdd6b03 add dart_internal override where necessary (flutter/engine#42920) 
A dependency to dart_internal was added in https://dart-review.googlesource.com/c/sdk/+/309460/6 and all transitive deps need to have overrides.
 2023-06-16 17:20:18 +00:00
skia-flutter-autoroll
694060f78f Roll Skia from 9ab04a53b7be to d43262e90f25 (5 revisions) (flutter/engine#42918) 
https://skia.googlesource.com/skia.git/+log/9ab04a53b7be..d43262e90f25

2023-06-16 johnstiles@google.com Disable SwitchWithFallthrough test on iOS + GLSL.
2023-06-16 kjlubick@google.com Remove Android GPU methods from SkCanvas
2023-06-16 kjlubick@google.com Introduce delegate for Atlas regeneration
2023-06-16 kjlubick@google.com Extract VertexFiller and add AtlasDrawDelegate as GPU abstraction
2023-06-16 kjlubick@google.com Extract SlugImpl.h and remove #ifdefs of slugs from Canvas

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-16 15:34:23 +00:00
Mouad Debbar
3dc65b209f [web] Move webOnlyAssetManager to dart:ui_web (flutter/engine#42642) 
Moving `webOnlyAssetManager` to `dart:ui_web` and renaming it to simply `assetManager`. This will make it easier for plugins and apps to get a hold of the asset manager without doing `dart:ui` shims or other shenanigans.

Part of https://github.com/flutter/flutter/issues/126831
 2023-06-16 14:54:09 +00:00
skia-flutter-autoroll
c1246d270e Roll Fuchsia Linux SDK from E5G7PwYbRA-u-ZJ9F... to -NW1eatBbmjvLaIcV... (flutter/engine#42915) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-16 13:57:14 +00:00
skia-flutter-autoroll
11e37d337b Roll Skia from f0410a265d2b to 504a26e85fc6 (1 revision) (flutter/engine#42907) 
https://skia.googlesource.com/skia.git/+log/f0410a265d2b..504a26e85fc6

2023-06-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 894306cf4c91 to d044984a01de (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-16 06:03:36 +00:00
godofredoc
79f7e23ebf Set xcode explicitly on mac builds with release_build. (flutter/engine#42898) 
Xcode version needs to be set explicitly for builds running on
dart-internal.

Bug: https://github.com/flutter/flutter/issues/128977

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I signed the [CLA].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-06-15 22:04:21 -07:00
Konstantin Scheglov
327e2a3d85 Fix prefer_final_in_for_each (flutter/engine#42899) 
Context: https://dart-review.googlesource.com/c/sdk/+/309821
 2023-06-15 20:57:43 -07:00
godofredoc
ad32caa1ab Remove release_build from clang_tidy build. (flutter/engine#42900) 
release_build property is used to flag that artifacts from the build need to also include provenance. Clang tidy build does not generate any artifacts and it is failing in dart internal.

Bug: https://github.com/flutter/flutter/issues/128981

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-16 02:24:07 +00:00
skia-flutter-autoroll
d2a19b52b6 Roll Fuchsia Linux SDK from 53EjCyuRu91oFTBf2... to E5G7PwYbRA-u-ZJ9F... (flutter/engine#42897) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-16 00:43:45 +00:00
skia-flutter-autoroll
7c1d7aedc8 Roll Skia from 2ab2678058a3 to abfa3505db23 (1 revision) (flutter/engine#42894) 
https://skia.googlesource.com/skia.git/+log/2ab2678058a3..abfa3505db23

2023-06-15 herb@google.com Harden quadratic solver

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-15 21:53:13 +00:00
skia-flutter-autoroll
24c04400b0 Roll Skia from 794b6f9240a8 to 2ab2678058a3 (6 revisions) (flutter/engine#42889) 
https://skia.googlesource.com/skia.git/+log/794b6f9240a8..2ab2678058a3

2023-06-15 robertphillips@google.com [graphite] New tiled image draw API
2023-06-15 kjlubick@google.com Add extra specification for some enums
2023-06-15 jvanverth@google.com [graphite] Temporarily disable draw pass commands in Vulkan to get dm running
2023-06-15 nicolettep@google.com [graphite] Fix dawn typo
2023-06-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4f33c22decdf to 6f8e5c2f4684 (3 revisions)
2023-06-15 robertphillips@google.com Minor refactoring of the Device drawImage code path

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-15 20:40:41 +00:00
Michael Goderbauer
57ffdedfc4 Add deprecations to PlatformMessage stuff (flutter/engine#42580) 
Fixes old TODOs originally added in https://github.com/flutter/engine/pull/22181.
The framework appears to be fully migrated off these.
 2023-06-15 19:53:13 +00:00
gaaclarke
c3105fa995 [Impeller] Joined obligatory vulkan swapchain submits (flutter/engine#42865) 
Every frame we submit to the queue a layout transition and a notify to the `acquire` fence.  This joins those together into one `vkQueueSubmit` call.  Thus eliminating a fence that was happening after the layout transition.

issue https://github.com/flutter/flutter/issues/128838

## testing results from the gallery driver test
```
Before:
  "average_frame_build_time_millis": 1.379130952380952,
  "90th_percentile_frame_build_time_millis": 1.965,
  "99th_percentile_frame_build_time_millis": 20.246,
  "worst_frame_build_time_millis": 29.578,
  "missed_frame_build_budget_count": 7,
  "average_frame_rasterizer_time_millis": 20.447408955223867,
  "90th_percentile_frame_rasterizer_time_millis": 25.398,
  "99th_percentile_frame_rasterizer_time_millis": 160.198,
  "worst_frame_rasterizer_time_millis": 178.042,
  "missed_frame_rasterizer_budget_count": 122,
  "frame_count": 336,
  "frame_rasterizer_count": 335,
  "new_gen_gc_count": 0,
  "old_gen_gc_count": 0,
  "frame_build_times": [
after:
  "average_frame_build_time_millis": 1.1907232876712324,
  "90th_percentile_frame_build_time_millis": 1.926,
  "99th_percentile_frame_build_time_millis": 16.666,
  "worst_frame_build_time_millis": 27.39,
  "missed_frame_build_budget_count": 5,
  "average_frame_rasterizer_time_millis": 15.525100817438704,
  "90th_percentile_frame_rasterizer_time_millis": 20.116,
  "99th_percentile_frame_rasterizer_time_millis": 33.835,
  "worst_frame_rasterizer_time_millis": 56.075,
  "missed_frame_rasterizer_budget_count": 156,
  "frame_count": 365,
  "frame_rasterizer_count": 367,
  "new_gen_gc_count": 0,
  "old_gen_gc_count": 0,
```

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-15 19:50:10 +00:00
skia-flutter-autoroll
be22b33d27 Roll Skia from 2d531d020c26 to 794b6f9240a8 (3 revisions) (flutter/engine#42888) 
https://skia.googlesource.com/skia.git/+log/2d531d020c26..794b6f9240a8

2023-06-15 robertphillips@google.com [graphite] Remove SkImageGenerator::makeTextureImage
2023-06-15 michaelludwig@google.com [skif] Fix morphology sksl to avoid switch fallthroughs
2023-06-15 nicolettep@google.com [graphite] Fix multisample state in Vulkan graphics pipeline

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-15 19:30:00 +00:00
skia-flutter-autoroll
fda5a44992 Roll Skia from 0b66c6928dcf to 2d531d020c26 (3 revisions) (flutter/engine#42883) 
https://skia.googlesource.com/skia.git/+log/0b66c6928dcf..2d531d020c26

2023-06-15 michaelludwig@google.com [graphite] Fix extra semicolons for runtime effect constants/structs
2023-06-15 fmalita@chromium.org Add color mode to Viewer::Mesh slide
2023-06-15 brianosman@google.com Many-stop gradients: Convert texture to destination space

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-15 17:27:30 +00:00
Matej Knopp
b50910b277 Raster cache should preserve RTree for overlay layers (flutter/engine#42552) 
Fixes https://github.com/flutter/flutter/issues/116069

When raster cache paints to a layer over platform view, it will draw the
individual rectangles from the content RTree, to ensure that the
destination layer RTree is not clobbered. This is necessary for raster
cache to not break unobstructed platform views and/or hit testing.

When raster cache paints in the root (bottom-most) layer the behavior it
just copies the entire image as it did before. This is to minimise risk
of performance regressions.

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I signed the [CLA].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-06-15 17:25:53 +02:00
skia-flutter-autoroll
a03778f60d Roll Skia from c0c74b433117 to 0b66c6928dcf (1 revision) (flutter/engine#42879) 
https://skia.googlesource.com/skia.git/+log/c0c74b433117..0b66c6928dcf

2023-06-15 bungeman@google.com Add DirectWrite COLRv1 support

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-15 15:07:21 +00:00
Bruno Leroux
d4326f7b08 [Linux] Allow BasicMessageChannel sending and responding to null message (flutter/engine#42808) 
## Description

This PR changes how a null message is handled by the Linux engine for a basic message channel.

**Before**:

- when receiving a null message a warning was emitted.
- `fl_binary_messenger_send_response` was called but failed and the application exited.

```
** (bug:9866): WARNING **: 23:13:42.109: Failed to decode message: Unexpected end of data

** (bug:9866): CRITICAL **: 23:13:42.109: gboolean send_response(FlBinaryMessenger *, FlBinaryMessengerResponseHandle *, GBytes *, GError **): assertion 'response_handle->response_handle != nullptr' failed
```

**After**:

- Receiving a null message is handled as expected from the framework side documentation:

9287e81d52/packages/flutter/lib/src/services/platform_channel.dart (L149-L150)

## Related Issue

Fixes https://github.com/flutter/flutter/issues/128704

## Tests

Adds 2 tests.
 2023-06-15 13:04:00 +00:00
skia-flutter-autoroll
808065cb76 Roll Skia from 12375fb6f3c8 to c0c74b433117 (1 revision) (flutter/engine#42876) 
https://skia.googlesource.com/skia.git/+log/12375fb6f3c8..c0c74b433117

2023-06-15 drott@chromium.org [Fontations] Implement onGetVariationDesignPosition

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-15 12:14:09 +00:00
skia-flutter-autoroll
72742da840 Roll Skia from c3abd540c7f9 to e2e0256d4c6a (1 revision) (flutter/engine#42869) 
https://skia.googlesource.com/skia.git/+log/c3abd540c7f9..e2e0256d4c6a

2023-06-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from ae32157135ff to 894306cf4c91 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-15 06:00:29 +00:00
skia-flutter-autoroll
de2eea2975 Roll Fuchsia Linux SDK from uvmDF7KM34dWGdsuK... to 53EjCyuRu91oFTBf2... (flutter/engine#42868) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-15 05:18:56 +00:00
skia-flutter-autoroll
84121740ee Roll Skia from 19051bc5fc90 to 2718866006d2 (33 revisions) (flutter/engine#42864) 
Roll Skia from 19051bc5fc90 to 2718866006d2 (33 revisions)

https://skia.googlesource.com/skia.git/+log/19051bc5fc90..2718866006d2

2023-06-14 johnstiles@google.com Disable SwitchWithFallthrough test on Adreno GPUs.
2023-06-14 jmbetancourt@google.com Reland "[skottie] add functionality for get, set, and tracking image slots to SlotManager"
2023-06-14 brianosman@google.com Swap the order of the final two gradient FPs
2023-06-14 brianosman@google.com Extract RP code for converting interpolated to destination color space
2023-06-14 michaelludwig@google.com [skif] Update morphology filters to use FilterResult
2023-06-14 het@google.com [canvaskit] Allow OffscreenCanvas to make a CPU Surface
2023-06-14 johnstiles@google.com Add WGSL support for switches that have fallthrough cases.
2023-06-14 johnstiles@google.com Add WGSL support for switches that do not have fallthrough cases.
2023-06-14 johnstiles@google.com Migrate switch top-level variables into a block.
2023-06-14 wcandillon@gmail.com Refine the EmbindObject type so that TypeScript can differentiate between opaque types such as Shader, ColorFilter, and so on.
2023-06-14 jvanverth@google.com [graphite] Remove deprecated YUVA constructor
2023-06-14 robertphillips@google.com Simplify parameters to drawEdgeAAImage and DrawTiledBitmap
2023-06-14 johnstiles@google.com Add WGSL support for exponential intrinsics.
2023-06-14 kjlubick@google.com Fix G3 roll
2023-06-14 robertphillips@google.com Reorganize parameters to new drawEdgeAAImage method
2023-06-14 robertphillips@google.com Move tiled image draws to operate at the Device level (take 2)
2023-06-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 5b7ee750e5e8 to a3ea6d67d5de (3 revisions)
2023-06-14 maryla@google.com Refactor SkJpegXmp into SkXmp which is more generic.
2023-06-14 dnfield@google.com Support kBGR_101010x_XR_SkColorType gather
2023-06-14 michaelludwig@google.com [skif] Delete SkImageFilters::AlphaThreshold
2023-06-14 jamesgk@google.com Reland "Add unit test for nested runtime blending"
2023-06-14 fmalita@chromium.org Add my chromium.org email to owners
2023-06-14 herb@google.com Revert "Quad intersections for glyph underlines"
2023-06-14 bungeman@google.com Remove duplicate paint_scale gms
2023-06-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 1572f609c18e to 3a3a3c655a96 (11 revisions)
2023-06-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from ecc1c77185cb to ae32157135ff (6 revisions)
2023-06-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from bfe346b8723e to a0e679b77011 (10 revisions)
2023-06-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f4703823888a to 5b7ee750e5e8 (5 revisions)
2023-06-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 3ab2beba4131 to ae32157135ff
2023-06-14 michaelludwig@google.com [skif] Remove legacy Magnifier implementation
2023-06-14 johnstiles@google.com Add WGSL support for additional intrinsics.
2023-06-13 bungeman@google.com [pdf] Remove SK_IGNORE_PDF_DW_FIX
2023-06-13 apli@google.com [sksl] Fix alphabetic ordering of compute shader texture intrinsics

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

...
 2023-06-15 02:20:29 +00:00
godofredoc
c1f94c5fab Add missing artifact to the android_arm64_profile config. (flutter/engine#42858) 
The generation and archiving of this artifact was missed during the engine v2 migration.

Bug: https://github.com/flutter/flutter/issues/128907

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-15 00:44:20 +00:00
Harry Terkelsen
488833486c Build skia with expat (flutter/engine#42859) 
Skia codecs depends on Skia's xml libraries which depend on expat, so we
must enable expat for non-wasm builds.

See https://github.com/flutter/engine/pull/42857 for an example of a
failing build on Skia.
 2023-06-14 16:41:05 -07:00
Chris Yang
57582c3dd0 [ios] use interfaceOrientation orientation on iOS 13 and above (flutter/engine#42846) 
The UIApplication.statusBarOrientation is deprecated on iOS 9. The replacement is UIScene.interfaceOrientation, which is available on iOS 13 and above. See: https://developer.apple.com/documentation/uikit/uiapplication/1623026-statusbarorientation?language=objc

Part of https://github.com/flutter/flutter/issues/128730

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-14 22:33:07 +00:00
Jonah Williams
b1f2905fbf [Impeller] Make interleaved layout (more) explicit in generated headers. (flutter/engine#42628) 
Working on https://github.com/flutter/engine/pull/42415 , I found that it was difficult to customize the buffer layout as the interleaved layout is implicitly confiured in the backends. Rather than bake another built in layout, I've pulled (most) information about buffer layout into the generated headers so it is explicitly confiured, which should allow easier customization as the backend has fewer choices to make.

TBD whether or not we need to do something weird for GLES since stride has a different meaning there...

Work towards https://github.com/flutter/flutter/issues/116168
 2023-06-14 20:04:35 +00:00
gaaclarke
c85a8b9cdd Renamed validation layers build (flutter/engine#42826) 
followup to https://github.com/flutter/engine/pull/42724

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-06-14 12:44:04 -07:00
Chris Yang
c0a630899e [ios] view controller based status bar (flutter/engine#42643) 
UIApplication based status bar API was deprecated.

This PR makes the ViewController based status bar appearance the default.
Still keep UIApplication based status bar for apps that explicitly sets `UIViewControllerBasedStatusBarAppearance` to NO in info.plist.

Part of https://github.com/flutter/flutter/issues/124289

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-14 19:27:23 +00:00
skia-flutter-autoroll
857fc5a372 Roll Skia from 6d5dc31d88e2 to 19051bc5fc90 (25 revisions) (flutter/engine#42828) 
https://skia.googlesource.com/skia.git/+log/6d5dc31d88e2..19051bc5fc90

2023-06-13 robertphillips@google.com Revert "Move tiled image draws to
operate at the Device level"
2023-06-13 jvanverth@google.com [graphite] Add generation from SkImages
to wacky_yuv GM
2023-06-13 jamesgk@google.com Revert "Add unit test for nested runtime
blending"
2023-06-13 jamesgk@google.com Add unit test for nested runtime blending
2023-06-13 apli@google.com [sksl] Rename compute shader texture
intrinsics
2023-06-13 robertphillips@google.com Move tiled image draws to operate
at the Device level
2023-06-13 kjlubick@google.com Rename SkPromiseImageTexture ->
GrPromiseImageTexture
2023-06-13 jvanverth@google.com [graphite] Add Vulkan draw support.
2023-06-13 johnstiles@google.com Fix GLSL codegen when sk_Clockwise
appears in more than one function.
2023-06-13 herb@google.com Quad intersections for glyph underlines
2023-06-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 13e40cf948ed to f4703823888a (3 revisions)
2023-06-13 johnstiles@google.com Port a handful of intrinsics to WGSL.
2023-06-13 kjlubick@google.com Remove
SkYUVAPixmapInfo::SupportedDataTypes(const GrImageContext&)
2023-06-13 johnstiles@google.com Emit const-variables in WGSL where
possible.
2023-06-13 kjlubick@google.com Revert "[skottie] add functionality for
get, set, and tracking image slots to SlotManager"
2023-06-13 drott@chromium.org [Fontations] Implement onGetTableTags()
2023-06-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK
Tool from ecc1c77185cb to 94c481e189bc
2023-06-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from c5beac3c360b to ecc1c77185cb (2 revisions)
2023-06-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 10380f4ba473 to 1572f609c18e (9 revisions)
2023-06-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 3a77c42f230d to bfe346b8723e (11 revisions)
2023-06-13 ayzhao@google.com Fix missing include in SkJpegXmp.cpp
2023-06-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 2219aacad808 to 13e40cf948ed (13 revisions)
2023-06-12 jmbetancourt@google.com [skottie] add functionality for get,
set, and tracking image slots to SlotManager
2023-06-12 kjlubick@google.com Remove ddl from SkSurface
2023-06-12 johnstiles@google.com Add WGSL support for sk_Caps.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
brianosman@google.com,chinmaygarde@google.com,herb@google.com,rmistry@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-14 11:45:45 -07:00
utzcoz
5351826be1 Fix generateLockfiles running directory for documentation (flutter/engine#42734) 
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-14 15:07:06 +00:00
skia-flutter-autoroll
0c9dec9128 Roll Fuchsia Linux SDK from kQbij6Tvqe7F9-PhR... to Xi3c5nti2LKnEOqYt... (flutter/engine#42832) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-14 03:05:14 +00:00
skia-flutter-autoroll
bd5241196c Roll Skia from 6bdb0ef30cb6 to 6d5dc31d88e2 (7 revisions) (flutter/engine#42790) 
https://skia.googlesource.com/skia.git/+log/6bdb0ef30cb6..6d5dc31d88e2

2023-06-12 nicolettep@google.com [graphite] Fix unused variable warning
in release builds
2023-06-12 nicolettep@google.com [graphite] Set more Vulkan pipeline
states.
2023-06-12 nicolettep@google.com [graphite] Implement Vulkan Pipeline
input assembly & depth/stencil state setup.
2023-06-12 nicolettep@google.com [graphite] Set up vertex attributes in
VulkanGraphicsPipeline.
2023-06-12 jvanverth@google.com Reland "[graphite] Use SkSpan for
YUVATextureProxies and YUVABackendTextures."
2023-06-12 sky@chromium.org SkPathBuilder: converts incReserve back to
using reserve()
2023-06-12 kjlubick@google.com Remove stub GrBackend* classes

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
brianosman@google.com,herb@google.com,jacksongardner@google.com,rmistry@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-13 15:45:52 -07:00
Dan Field
8cbdaca6a8 Make validation logs ERROR level (flutter/engine#42825) 
INFO logs do not show up in normal logging unless an extra flag is passed by the tool (and it is a different flag from the "-v" flag).

This means bug reports that include logs about impeller are missing the validation errors, which makes them harder to triage and dedupe.

Fixes https://github.com/flutter/flutter/issues/128808
 2023-06-13 22:43:53 +00:00
skia-flutter-autoroll
c42f5f03aa Manual roll ICU from 1eea59cabae0 to a2961dc659b4 (0 revision) (flutter/engine#42817) 
Manual roll requested by fmil@google.com

1eea59caba..a2961dc659

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/icu-sdk-flutter-engine
Please CC chinmaygarde@google.com,fmil@google.com,tq-i18n-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ICU: https://github.com/unicode-org/icu
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-13 22:30:15 +00:00
Chris Yang
cc1ec72179 Remove some trivial deprecated symbol usages in iOS Embedder (flutter/engine#42711) 
stringWithCString was deprecated in iOS 2.0
UIAccessibilityVoiceOverStatusChanged was deprecated in iOS 11.0

fixes: https://github.com/flutter/flutter/issues/128732
https://github.com/flutter/flutter/issues/128736

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-13 22:26:59 +00:00
Chris Yang
4f88b3f075 Reland "[ios_platform_view] only recycle maskView when the view is applying mutators #42115" (flutter/engine#42823) 
Relands https://github.com/flutter/engine/pull/42115, which was reverted in https://github.com/flutter/engine/pull/42231 due to a crash in the framework test.

The crash is due to a memory management issue that I fixed it in this PR, I also added a scenario test to catch the crash.

fixes: https://github.com/flutter/flutter/issues/125620

See also: orignal PR https://github.com/flutter/engine/pull/41573 for more details.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-13 22:14:06 +00:00
gaaclarke
162698d8fd [Impeller] Added cache for command buffers in vulkan (flutter/engine#42793) 
issue https://github.com/flutter/flutter/issues/118727

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-06-13 15:03:10 -07:00