11795 Commits

Author SHA1 Message Date
Chris Yang
930696bbb7 Improve iOS PlatformViews to better handle thread merging. (flutter/engine#16935) 2020-04-08 17:33:33 -07:00
skia-flutter-autoroll
0fafb9d02e Roll fuchsia/sdk/core/mac-amd64 from wZ5qZ... to dCOo1... (flutter/engine#17576)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2020-04-08 17:23:48 -07:00
Ferhat
cf1e97470b [web] Fix multi-reply on message channel. Add test (flutter/engine#17591)
* Fix multi-reply on message channel. Add test
* Add check for viewInstanceCount
* skip no-headless test
2020-04-08 17:18:06 -07:00
Dan Field
d5f40cc11e set -e on assemble_apk.sh (flutter/engine#17588)
* set -e on assemble_apk.sh

* build the necessary artifacts
2020-04-08 14:52:14 -07:00
Mouad Debbar
ec2ab6a871 [web] Fix regression of pointer events on mobile browsers (flutter/engine#17595) 2020-04-08 14:48:56 -07:00
Mouad Debbar
f353d919aa [web] Fix window.defaultRouteName (flutter/engine#17580) 2020-04-08 13:51:38 -07:00
Gary Qian
a03f69c53a Implement repeat filtering logic in Android Embedder (flutter/engine#17509) 2020-04-08 12:51:43 -07:00
godofredoc
e894999885 Add logs between fuchsia test steps. (flutter/engine#17584)
* Add logs between fuchsia test steps.

Adding logs and date time in between steps will simplify finding the
steps that are failing during the fuchsia tests.

https://github.com/flutter/flutter/issues/54253

* Use date command instead of DATE..

* Remove extra log line.

* Same spacer lenght for all the log lines.
2020-04-08 12:50:17 -07:00
liyuqian
9f6c6e0218 Fix typo in shell_benchmarks (flutter/engine#17578) 2020-04-08 12:16:03 -07:00
Harry Terkelsen
fc74a96f37 Do not enable antialiasing by default in CanvasKit mode (flutter/engine#17534)
* Do not enable antialiasing by default in CanvasKit mode

* Add comment
2020-04-08 11:55:23 -07:00
Kaushik Iska
78c5bc73ba [perf] Add a SceneDisplayLag event when we miss vsyncs (flutter/engine#17575)
This event goes from now -> current vsync target time
to avoid the limitations as seen in https://github.com/flutter/flutter/issues/54095#issuecomment-610636237

This event also tags additional metadata to capture
`vsync_transitions_missed` considering the refresh rate of the display.
2020-04-08 09:14:11 -07:00
Emmanuel Garcia
36c79c8a65 Change the directory to the scenario app (flutter/engine#17583) 2020-04-08 08:40:04 -07:00
skia-flutter-autoroll
5cf8142431 Roll src/third_party/skia 07b2bafbbc3c..f6860405e1bf (9 commits) (flutter/engine#17587) 2020-04-08 06:41:02 -07:00
skia-flutter-autoroll
55be348d0b Roll src/third_party/dart a90b84544426..28c4c6c156e5 (2 commits) (flutter/engine#17586) 2020-04-08 04:46:03 -07:00
skia-flutter-autoroll
512d1a24cc Roll src/third_party/skia b41a420ed8db..07b2bafbbc3c (13 commits) (flutter/engine#17579)
https://skia.googlesource.com/skia.git/+log/b41a420ed8db..07b2bafbbc3c

git log b41a420ed8db..07b2bafbbc3c --date=short --first-parent --format='%ad %ae %s'
2020-04-07 mtklein@google.com build conservative stack frame on x86-64
2020-04-07 mtklein@google.com add and test stack load/store
2020-04-07 brianosman@google.com Remove secret wireframe mode from drawVertices
2020-04-07 mtklein@google.com remove "debian9" ASAN jobs
2020-04-07 brianosman@google.com Remove gamma GM
2020-04-07 csmartdalton@google.com Implement support for indirect draws
2020-04-07 scroggo@google.com Upgrade libwebp used for testing to v1.1.0
2020-04-07 robertphillips@google.com Remove GrStrikeCache.h from all other header files
2020-04-07 mtklein@google.com backup plan for ASAN bots
2020-04-07 reed@google.com approximate sine for skvm
2020-04-07 mtklein@google.com remove SK_USE_SKVM_BLITTER
2020-04-07 jlavrova@google.com Mixed languages text crashes
2020-04-07 reed@google.com remove deprecated concat44 -- use concat

Created with:
  gclient setdep -r src/third_party/skia@07b2bafbbc3c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC csmartdalton@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: csmartdalton@google.com
2020-04-08 07:32:47 -04:00
skia-flutter-autoroll
b1cfdbf6f2 Roll src/third_party/dart dcdc71d7639a..a90b84544426 (32 commits) (flutter/engine#17585) 2020-04-07 22:36:02 -07:00
liyuqian
5600aee512 Add comments to build_and_test_linux_unopt_debug (flutter/engine#17567)
Clarify that the test depends on the framework repo. It may fail if the
framework repo is broken, so the engine committer don't need to be in
panic.
2020-04-07 16:44:57 -07:00
Kaushik Iska
0460673759 Remove SceneDisplayLag trace event temporarily (flutter/engine#17571)
Working theory is that adding async events with begin times
in the past causes the timeline to skip some events.

See: https://github.com/flutter/flutter/issues/54095
2020-04-07 16:33:52 -07:00
skia-flutter-autoroll
c824fa3c9f Roll src/third_party/skia 3ef77ddf9ec4..b41a420ed8db (35 commits) (flutter/engine#17568) 2020-04-07 15:01:02 -07:00
LongCatIsLooong
d6d4f376a1 iOS UITextInput autocorrection prompt (flutter/engine#13959) 2020-04-07 14:45:59 -07:00
George Wright
c55f1eaed9 Roll fuchsia/sdk/core/linux-amd64 from 3yOjK... to VzWN4... (flutter/engine#17569) 2020-04-07 14:41:01 -07:00
stuartmorgan
b64faf3a69 Reland "Improve C++ plugin lifetime handling" (flutter/engine#17570)
Relands #17489 with a fix for the unit test flake.

The previous unit test relied on the new instance not being created at the same memory address, which isn't guaranteed.
2020-04-07 14:11:56 -07:00
gaaclarke
9513e65f95 Added "unrecognized-selector" errors to match g3 builds (flutter/engine#17566)
Added "unrecognized-selector" errors to match g3 builds, added
"overriding-method-mismatch" to catch a common error.
2020-04-07 13:28:42 -07:00
stuartmorgan
06e24a71ba Fix flutter_windows_unittests runtime dependency (flutter/engine#17524)
The transitive dependency on the embedder library brings in the right
runtime for the build mode, so directly depending on the JIT version
isn't necessary, and causes duplicate symbol issues in release builds.
2020-04-07 13:19:49 -07:00
Nurhan Turgut
c30986c146 [web] fix clipboard.getData (flutter/engine#17544)
* remove the fake reply for paste message. the clipboard.dart will reply with the content of the clipboard

* also remove the fake answer for copy
2020-04-07 11:34:33 -07:00
Ryoichi Izumita
fee9895d51 Fixed a bug that left a blank at the bottom of the screen (flutter/engine#17474)
I fixed a bug that left a blank at the bottom of the screen when the iPad's split keyboard was hidden.

I also had the same problem with this issue, so I fixed it.
iPad split keyboard cause a blank space problem

There is no function to change the space size at the bottom of the screen when the split keyboard is moved. This is because it's not clear what the keyboard should do when it's moved to the top of the screen.
2020-04-07 11:27:15 -07:00
Jason Simmons
33843702fe Add the Android SDK lambda stub library to the classpath (flutter/engine#17508)
Previously the build scripts obtained the lambda support classes from rt.jar,
which is no longer provided by recent versions of the JDK.
2020-04-07 11:24:52 -07:00
chunhtai
2a55af809a always forward move event (flutter/engine#17541)
flutter/flutter#54022

The original issue is the _MotionEventsDispatcher depends on all down pointers to send out their own move events. If the third pointer has the movement of zero, it will get filter out by the PointerDataPacketConverter. This result with only two pointer move events been sent to RenderAndroidView, and they both get ignored because it is waiting for the third one.

This pr fixes it by always forward the move event
2020-04-07 11:24:11 -07:00
skia-flutter-autoroll
d5245440ff Roll src/third_party/dart 275a76f2fcd8..dcdc71d7639a (31 commits) (flutter/engine#17562)
https://dart.googlesource.com/sdk.git/+log/275a76f2fcd8..dcdc71d7639a

git log 275a76f2fcd8..dcdc71d7639a --date=short --first-parent --format='%ad %ae %s'
2020-04-07 scheglov@google.com Report CONFLICTING_GENERIC_INTERFACES using ClassHierarchy.
2020-04-07 eernst@google.com Adjust member signature expectations for mixed inheritance
2020-04-07 kustermann@google.com [vm/compiler] Move runtime call of Throw/ReThrow/AssertBoolean/InstanceOf out into a Stub
2020-04-07 cskau@google.com [Compiler] Adds a set of generic AllocateObject stubs.
2020-04-07 scheglov@google.com Update constants_2018/constant_types_test to allow type parameters in 'as'.
2020-04-07 alexmarkov@google.com [vm/tests] Speed up / filter slow vm/dart/minimal_kernel*_test
2020-04-07 leafp@google.com Add tests for extended GLB.
2020-04-07 sra@google.com [dart2js] createFromStaticType for LegacyType
2020-04-07 rnystrom@google.com Migrate language_2/covariant to NNBD.
2020-04-07 srujzs@google.com [dart:html] Fix named args in js_typed_interop tests
2020-04-06 rnystrom@google.com Migrate language_2/constants_2018 to NNBD.
2020-04-06 scheglov@google.com Update language/constructor/return_test
2020-04-06 scheglov@google.com Update ClassHierarchy for legacy support, record errors.
2020-04-06 rmacnak@google.com Revert "[vm, gc] Parallel scavenge."
2020-04-06 srujzs@google.com [dart:html] Add nullability to item type for lists
2020-04-06 srujzs@google.com [dart:html] Remove 2.7 annotation from lib/html
2020-04-06 srujzs@google.com [dart:html] Migrate tests with only null asserts
2020-04-06 srujzs@google.com [dart:html] Migrate tests that need changes to NNBD
2020-04-06 srujzs@google.com [dart:html] Migrate more js tests to NNBD
2020-04-06 srujzs@google.com [dart:html] Migrate html tests with dynamic list conversions
2020-04-06 srujzs@google.com [dart:html] Migrate htmlcollection_test to null-safe
2020-04-06 rmacnak@google.com [vm, gc] Parallel scavenge.
2020-04-06 jwren@google.com Update the completion_metrics.dart algorithm to have 2 overlay options
2020-04-06 scheglov@google.com Clear class hierarchies to reduce memory consumption.
2020-04-06 rileyporter@google.com [tests] Removing more List constructor usage in corelib tests.
2020-04-06 liama@google.com [vm] Fix bug in late field reloading
2020-04-06 mfairhurst@google.com [nnbd_migration] Add sanity checks before writing to disk.
2020-04-06 mfairhurst@google.com [nnbd_migration] Change edit links to buttons.
2020-04-06 mehmetf@google.com Reland "[dart:_http] Allow the embedder to prohibit HTTP traffic."
2020-04-06 rmacnak@google.com [vm] Include the handler function in HandleMessage timeline events.
2020-04-06 scheglov@google.com Allow potentially constant type expression in 'as'.

Created with:
  gclient setdep -r src/third_party/dart@dcdc71d7639a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: dart-vm-team@google.com
2020-04-07 11:23:23 -07:00
Chris Bracken
2a97bc1e16 Revert "Added errors to match g3 builds and simple errors (#17536)" (flutter/engine#17564)
Test failure:

    [ RUN      ] FlutterStringCodec.CanEncodeAndDecodeNil
    2020-04-07 10:21:25.091 flutter_channels_unittests[26965:163315] *** Assertion failure in -[FlutterStringCodec encode:], ../../flutter/shell/platform/darwin/common/framework/Source/FlutterCodecs.mm:36
    2020-04-07 10:21:25.118 flutter_channels_unittests[26965:163315] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: ''
    *** First throw call stack:
    (
    	0   CoreFoundation                      0x00007fff2ccabcf9 __exceptionPreprocess + 256
    	1   libobjc.A.dylib                     0x00007fff5785ea17 objc_exception_throw + 48
    	2   CoreFoundation                      0x00007fff2ccc6a16 +[NSException raise:format:arguments:] + 98
    	3   Foundation                          0x00007fff2ef58e11 -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:] + 194
    	4   flutter_channels_unittests          0x0000000105f1cce2 -[FlutterStringCodec encode:] + 290
    	5   flutter_channels_unittests          0x0000000105f01bbb _ZN45FlutterStringCodec_CanEncodeAndDecodeNil_Test8TestBodyEv + 107
    	6   flutter_channels_unittests          0x00000001081d1732 _ZN7testing8internal38HandleSehExceptionsInMethodIfSupportedINS_4TestEvEET0_PT_MS4_FS3_vEPKc + 146
    	7   flutter_channels_unittests          0x00000001081a76b0 _ZN7testing8internal35HandleExceptionsInMethodIfSupportedINS_4TestEvEET0_PT_MS4_FS3_vEPKc + 128
    	8   flutter_channels_unittests          0x00000001081a75c1 _ZN7testing4Test3RunEv + 209
    	9   flutter_channels_unittests          0x00000001081a8415 _ZN7testing8TestInfo3RunEv + 229
    	10  flutter_channels_unittests          0x00000001081a95aa _ZN7testing9TestSuite3RunEv + 266
    	11  flutter_channels_unittests          0x00000001081b4e43 _ZN7testing8internal12UnitTestImpl11RunAllTestsEv + 995
    	12  flutter_channels_unittests          0x00000001081d8572 _ZN7testing8internal38HandleSehExceptionsInMethodIfSupportedINS0_12UnitTestImplEbEET0_PT_MS4_FS3_vEPKc + 146
    	13  flutter_channels_unittests          0x00000001081b49b3 _ZN7testing8internal35HandleExceptionsInMethodIfSupportedINS0_12UnitTestImplEbEET0_PT_MS4_FS3_vEPKc + 131
    	14  flutter_channels_unittests          0x00000001081b4835 _ZN7testing8UnitTest3RunEv + 197
    	15  flutter_channels_unittests          0x0000000105f22e73 _Z13RUN_ALL_TESTSv + 35
    	16  flutter_channels_unittests          0x0000000105f22d79 main + 553
    	17  libdyld.dylib                       0x00007fff5908c3d5 start + 1
    )
    libc++abi.dylib: terminating with uncaught exception of type NSException
    [ERROR:flutter/fml/backtrace.cc(110)] Caught signal SIGABRT during program execution.
    Frame 0: 0x7fff591316a6 abort
    Frame 1: 0x7fff560ea641 __cxa_bad_cast
    Frame 2: 0x7fff560ea7df default_unexpected_handler()�
    Frame 3: 0x7fff57860ee3 _objc_terminate()�
    Frame 4: 0x7fff560f619e std::__terminate(void (*)())�
    Frame 5: 0x7fff560f5f86 __cxa_get_exception_ptr
    Frame 6: 0x7fff560e8f99 __cxa_get_globals
    Frame 7: 0x7fff5785eb51 objc_exception_throw
    Frame 8: 0x7fff2ccc6a16 +[NSException raise:format:arguments:]
    Frame 9: 0x7fff2ef58e11 -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:]
    Frame 10: 0x105f1cce2 -[FlutterStringCodec encode:]
    Frame 11: 0x105f01bbb FlutterStringCodec_CanEncodeAndDecodeNil_Test::TestBody()�
    Frame 12: 0x1081d1732 void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*)�
    Frame 13: 0x1081a76b0 void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*)�
    Frame 14: 0x1081a75c1 testing::Test::Run()�
    Frame 15: 0x1081a8415 testing::TestInfo::Run()�
    Frame 16: 0x1081a95aa testing::TestSuite::Run()�
    Frame 17: 0x1081b4e43 testing::internal::UnitTestImpl::RunAllTests()�
    Frame 18: 0x1081d8572 bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*)�
    Frame 19: 0x1081b49b3 bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*)�
    Frame 20: 0x1081b4835 testing::UnitTest::Run()�
    Frame 21: 0x105f22e73 RUN_ALL_TESTS()�
    Frame 22: 0x105f22d79 main
    Frame 23: 0x7fff5908c3d5 start

This reverts commit 46f82a3d938a621d2cae8591d6f7566e01f118e1.
2020-04-07 10:32:38 -07:00
Chris Bracken
4f108b7be1 Revert "Improve C++ plugin lifetime handling (#17489)" (flutter/engine#17563)
Seems to have triggered flaky failures on the Windows bot since landing.
Example failure:

    [ RUN      ] PluginRegistrarTest.ManagerRemovesOnDestruction
    c:\b\s\w\ir\cache\builder\src\flutter\shell\platform\common\cpp\client_wrapper\plugin_registrar_unittests.cc(149): error: Expected: (manager->GetRegistrar<PluginRegistrar>(dummy_registrar_handle)) != (first_wrapper), actual: 000002400A90E3D0 vs 000002400A90E3D0

This reverts commit 478a7855943d81a58dd9e9037fb338d3a18bb294.
2020-04-07 10:22:55 -07:00
gaaclarke
46f82a3d93 Added errors to match g3 builds and simple errors (flutter/engine#17536)
"unrecognized-selector" and "overriding-method-mismatch" added as errors.
2020-04-07 10:03:49 -07:00
skia-flutter-autoroll
13775f12d0 Roll src/third_party/dart 1210d27678a0..275a76f2fcd8 (4 commits) (flutter/engine#17531) 2020-04-06 15:16:03 -07:00
skia-flutter-autoroll
78265d74e7 Roll src/third_party/skia 04513752fd6e..3ef77ddf9ec4 (3 commits) (flutter/engine#17530) 2020-04-06 15:11:03 -07:00
Amir Hardon
97d47bf1b6 Fix AlertDialogs built by platform views (flutter/engine#17511) 2020-04-06 15:06:07 -07:00
Mouad Debbar
a5bc2eceb5 [web] Detect when the mouseup occurs outside of window (flutter/engine#17495) 2020-04-06 15:06:03 -07:00
gaaclarke
b3c7bb7ae9 Added missing declaration (only showed up in g3 builds). (flutter/engine#17535) 2020-04-06 15:02:47 -07:00
Kaushik Iska
de296a6f37 Revert "[tools][fuchsia] Do not tar debug symbol CIPD uploads (#17506)" (flutter/engine#17537)
This reverts commit 25f1f346f2e85e8bb33fbd9f4cd7d116767db143.
2020-04-06 14:15:40 -07:00
gaaclarke
2190b0c3c0 Fixed nullability in plugin header and overridden type mismatch error. (flutter/engine#17532) 2020-04-06 13:23:00 -07:00
Joshua Seaton
25f1f346f2 [tools][fuchsia] Do not tar debug symbol CIPD uploads (flutter/engine#17506)
Fuchsia is the main consumer of these CIPD packages and - to simplify
its infrastructure - it is migrating its SDK partners over to producing
a CIPD package containing a flat .build-id directory.

This change also updates the CIPD package so that the .build-id
directory is placed at the root.

Bug: fxbug.dev/41443
2020-04-06 10:04:54 -07:00
stuartmorgan
478a785594 Improve C++ plugin lifetime handling (flutter/engine#17489)
This makes two changes:
- Adds a way to register a callback for when a FlutterDesktopPluginRegistrarRef is destroyed, and implements the logic to call it in the Windows and Linux embeddings.
- Adds a class to the C++ wrapper that handles making a singleton owning PluginRegistrar wrappers, and destroying them when the underlying reference goes away, to avoid needing that boilerplate code in every plugin's source.

Fixes https://github.com/flutter/flutter/issues/53496
2020-04-06 09:55:42 -07:00
skia-flutter-autoroll
fd58075c0c Roll src/third_party/skia cc8a76f3c763..04513752fd6e (22 commits) (flutter/engine#17529) 2020-04-06 09:11:02 -07:00
skia-flutter-autoroll
266e04a7ff Roll src/third_party/dart a8251f820b09..1210d27678a0 (5 commits) (flutter/engine#17528) 2020-04-06 09:06:04 -07:00
skia-flutter-autoroll
93b3859442 Roll fuchsia/sdk/core/mac-amd64 from LDdBU... to wZ5qZ... (flutter/engine#17527) 2020-04-06 04:36:02 -07:00
skia-flutter-autoroll
970134d919 Roll src/third_party/dart 05103dfe5a0e..a8251f820b09 (4 commits) (flutter/engine#17526) 2020-04-06 00:36:01 -07:00
skia-flutter-autoroll
435997a84a Roll fuchsia/sdk/core/linux-amd64 from Ezm2f... to 3yOjK... (flutter/engine#17525) 2020-04-06 00:16:01 -07:00
skia-flutter-autoroll
04a1a24977 Roll src/third_party/dart 987ad1d96748..05103dfe5a0e (2 commits) (flutter/engine#17522) 2020-04-05 18:31:03 -07:00
skia-flutter-autoroll
3bc18065eb Roll fuchsia/sdk/core/mac-amd64 from 6CeXq... to LDdBU... (flutter/engine#17521) 2020-04-05 14:16:02 -07:00
skia-flutter-autoroll
cf0c5a4770 Roll src/third_party/dart a7f1a5e677e5..987ad1d96748 (1 commits) (flutter/engine#17520) 2020-04-05 12:16:02 -07:00
skia-flutter-autoroll
e64079e7f9 Roll fuchsia/sdk/core/linux-amd64 from hUO_b... to Ezm2f... (flutter/engine#17519) 2020-04-05 04:06:02 -07:00