498 Commits

Author SHA1 Message Date
nturgut
9193e2e487
cloning flutter repo for luci recipes (#21532)
* cloning flutter repo for luci recipes

* rename the file, script does not clone the repo, but reset it to the right commit

* adding the version logging
2020-10-01 12:32:43 -07:00
Filip Filmar
4e99e6f2e1
Git versioning flag (#20748)
* [gn] Adds a flag to turn off git hash versioning

Without this flag, it is excessively tedious to build Dart SDK
for local testing on Fuchsia, since Fuchsia runner will reject
a Dart SDK without a matching version.

* [gn] Add flag --no-dart-version-git-info

This flag suppresses the SDK stamping by git hash, which allows
deploying self-built Dart SDK.  Without this flag, it is impossible
to build and deploy a development Dart SDK on Fuchsia.
2020-09-24 14:52:32 -07:00
Jason Simmons
1345359642
Fix boolean value checks in StandardMessageCodec (#21270)
Fixes https://github.com/flutter/flutter/issues/65619
2020-09-23 16:31:07 -07:00
Dan Field
90b82ec75d
avoid hard coding OS (#21248) 2020-09-17 12:57:03 -07:00
Chris Bracken
08dabe9601
Clean up C++ includes (#21127)
Cleans up header order/grouping for consistency: associated header, C/C++ system/standard library headers, library headers, platform-specific #includes.

Adds <cstring> where strlen, memcpy are being used: there are a bunch of places we use them transitively.

Applies linter-required cleanups. Disables linter on one file due to included RapidJson header. See https://github.com/flutter/flutter/issues/65676

This patch does not cover flutter/shell/platform/darwin. There's a separate, slightly more intensive cleanup for those in progress.
2020-09-11 21:18:35 -07:00
Chris Bracken
36f7f3ca82
Copyright header hygiene improvements (#21089)
Add copyright headers in a few files where they were missing.

Trim trailing blank comment line where present, for consistency with
other engine code.

Use the standard libtxt copyright header in one file where it differed
(extra (C) and comma compared to other files in libtxt).

This also amends tools/const_finder/test/const_finder_test.dart to look
for a const an additional four lines down to account for the copyright
header added to the test fixture.
2020-09-11 08:55:37 -07:00
Siva
26488499b8
Remove support for option 'dart_custom_version_for_pub' that generates (#20765)
a custom version string of Dart for Flutter.

Dart is going to be removing support for this ability to generate
a custom version string (only dev branch hashes are being rolled into
flutter).
2020-08-25 19:55:01 -07:00
David Worsham
4dc866283d
fuchsia: Convert legacy permutations to build flag (#20647) 2020-08-19 19:09:51 -07:00
Dan Field
3dd1151e3b
Make const_finder work with implemented and extended classes (#20614) 2020-08-18 23:16:03 -07:00
David Worsham
9f146b5f47
Add --unoptimied and --asan to Fuchsia builds (#20427) 2020-08-12 14:47:55 -07:00
Dan Field
93cdb907c3
improve error messages for font-subset (#20410) 2020-08-11 11:45:22 -07:00
Christopher Fujino
1e50d87dc8
Reland "ensure we do not double publish to CIPD #19724" (#19853) 2020-08-06 16:23:34 -07:00
Yuqian Li
9a244b2152
Revert "Revert "Add preliminary Windows arm64 plumbing (#20156)" (#20236)" (#20243)
This reverts commit 4126c0662296f977f5d02a0b3a5a27dea6c4ce50.

The LUCI recipe issue should have already been fixed by @christopherfujino 

Try to trigger the LUCI tests with this as the "retry" button is somehow disabled for https://ci.chromium.org/p/flutter/builders/prod/Linux%20Fuchsia/4755 even if I logged in.
2020-08-04 14:08:47 -07:00
Yuqian Li
4126c06622
Revert "Add preliminary Windows arm64 plumbing (#20156)" (#20236)
This reverts commit 00e75747e3cc33efcb3a8f7e4e14e9aadeed13b3.

Try to fix the LUCI Fuchsia build.
2020-08-04 11:35:21 -07:00
stuartmorgan
00e75747e3
Add preliminary Windows arm64 plumbing (#20156)
- Rolls buildroot to pick up
  https://github.com/flutter/buildroot/pull/389
- Adds support to the gn wrapper for setting the traget CPU on Windows

Attempting to generate Windows arm64 GN files will currently fail, due
to lack of arm64 support for an OpenGL test support target, but this
sets the foundation, and makes experimentation easier.

Part of https://github.com/flutter/flutter/issues/62597
2020-08-04 09:28:14 -07:00
Juyeong Lee
13e993ed1a
Fix Typos (#19691) 2020-07-31 16:32:58 -07:00
David Worsham
e1c9673bbb
Fix targets in build_fuchsia_artifacts (#19794) 2020-07-30 14:35:33 -07:00
Greg Spencer
e23e4775ae
Lint fixes for fml, tools subdirs (#19990)
This does lint fixes for the fml and tools subdirs.
2020-07-30 12:40:31 -07:00
Siva
406891841f
Manual roll of Dart 40fd1c456e...7e8348f4ce (#20125)
* Manual roll of Dart 40fd1c456e...7e8348f4ce

dart-lang/sdk@7e8348f4ce [dart2js] Assume `isPotentialSubtype` is always true.
dart-lang/sdk@5671730c5a [dart2js] Pass type arguments to callable properties even with --omit-implicit-checks.
dart-lang/sdk@4c74ebb367 [benchmark] Add dartdevc-null targets.
dart-lang/sdk@56708696a9 [vm/nnbd/bytecode] Distinguish function types with different nullabilities in bytecode generator
dart-lang/sdk@d2f7039e9c [dart:io] Parse scoped IPv6 in constructor of InternetAddress
dart-lang/sdk@c2d28d1569 Rename Null Safety tests.
dart-lang/sdk@4d3ec06277 Add more data and performance operations for Cider.
dart-lang/sdk@3103d859e4 Remove unused TypeSystemImpl.mostSpecificTypeArgument().
dart-lang/sdk@6d9a4f16dd Issue 42757. Implement null spread element typing with null-safety.
dart-lang/sdk@8c316a99de Remove unnecessary null checks.
dart-lang/sdk@6c9b885e57 Remove StrongModeCode.INVALID_PARAMETER_DECLARATION; it's redundant
dart-lang/sdk@b98eb386ea [ddc] Use prebuilt_dart_action to build js
dart-lang/sdk@8796382840 Analyzer: Move invalid_super_invocation to compile-time error
dart-lang/sdk@cece303eb4 Check diagnostics in List/Map/SetLiteralTest(s).
dart-lang/sdk@cc519b9a03 Test that during partial resolution for Cider we don't resolve some nodes.
dart-lang/sdk@4ea6d6e130 [tests/ffi] Re-enable commented out tests
dart-lang/sdk@2225b6f472 Migration: fix handling of async functions that return FutureOr.
dart-lang/sdk@f907e561c9 Migration: never produce a type of the form `FutureOr<T?>?`.
dart-lang/sdk@69ba6e5f80 Make FileSystemEntity.absolutePath understand more Windows paths.
dart-lang/sdk@202e32afeb [vm] Native API: Introduce Dart_FinalizableHandle
dart-lang/sdk@debb4dddea [co19] Language/Types and Language/Variables tests enabled
dart-lang/sdk@3661464297 [infra] Update checked-in SDKs to 2.10.0-0.0.dev
dart-lang/sdk@b8dc7627a9 [cfe] Handle NullCheck in constant evaluation

* Switch Android windows builds to also use clang.

* Bump buildroot version to fe3b46e595e7ce1350e11aa0c90365976051f4a3

* Update license.
2020-07-29 20:52:06 -07:00
stuartmorgan
ec9e17c5cb
Roll zlib (#20119)
Picks up the buildroot change to roll zlib to the latest version from Chromium.
2020-07-29 16:02:30 -07:00
Siva
b955e15ee9
Manual roll of Dart from 24c7666def...40fd1c456e (#20092)
* Manual roll of Dart from 24c7666def...40fd1c456e

dart-lang/sdk@40fd1c456e Revert "[dart:io] Add Abort() on HttpClientRequest"
dart-lang/sdk@17d7296a42 [vm/nnbd/bytecode] Fix reuse of type arguments in bytecode
dart-lang/sdk@58b6f40c73 Issue 42797. Understand in legacy libraries that a function returning Never (in Null Safety library) never returns. (reland)
dart-lang/sdk@fc8a6d9f9b [VM/compiler] Dereference TypeRef literal when propagating constants.
dart-lang/sdk@0689ec527a Move "test.dart" (well, most of its contents) into pkg/test_runner.
dart-lang/sdk@1094b3c61d Prepare static error test updater tool to handle web tests.
dart-lang/sdk@b258585f2f [observatory] Migrate from deprecated isInstanceOf to isA.
dart-lang/sdk@dfe1d9b682 Disable OverrideContributor for Cider.
dart-lang/sdk@aea99b2f5c scope debug property assist to Diagnosticables
dart-lang/sdk@4b96f20a79 [dart:io] Add Abort() on HttpClientRequest
dart-lang/sdk@1b1a39708c [build] Use frameworks instead of libs
dart-lang/sdk@3fef522496 Revert "Reland "[vm] Replaces fuchsia.deprecatedtimezone""
dart-lang/sdk@8c664d4f3f Revert "Issue 42797. Understand in legacy libraries that a function returning Never (in Null Safety library) never returns."
dart-lang/sdk@2efb5bebc7 [ dart:_http ] Fix typo in HTTP response timeline event
dart-lang/sdk@0884dae36c Revert "Fix the #include path for ICU headers"
dart-lang/sdk@5171534e81 Scope tweaks. Report REFERENCED_BEFORE_DECLARATION in more places.
dart-lang/sdk@6bba75079a Issue 42797. Understand in legacy libraries that a function returning Never (in Null Safety library) never returns.
dart-lang/sdk@b4ebbb7f5c [build] Update gn to match Fuchsia
dart-lang/sdk@cb428a7a02 [dart2js] Remove old bug work around in collector.
dart-lang/sdk@08663c20ab Change flutter patch to match existing DEPS on master branch
dart-lang/sdk@146ad014d9 update js/meta for the 2.10 dev sdk
dart-lang/sdk@488c718793 [co19] Roll co19 to d79951e06e443213243e54c2c32694b79a221b65
dart-lang/sdk@ba20edd7be Add patch for flutter-engine when changing to version 2.10

* Rev buildroot to latest version.

* Update license.

* update.

* Update gn revision.

* Format BUILD.gn files as the gn revision has been updated.
2020-07-29 13:10:15 -07:00
Jonah Williams
10adbbd0c5
fix gclient runhooks for windows (#20014)
* fix gclient runhooks for windows
2020-07-24 13:22:24 -07:00
Jonah Williams
3596b9b8b4
remove usage of dartdev command (#20011)
* remove usage of dartdev command so that gclient runhooks can re-generate package_config.json
2020-07-24 12:22:45 -07:00
Siva
3bb6cc265e
Manual merge of Dart a3815b6590...24c7666def (#19967)
* Manual merge or Dart into flutter a3815b6590...24c7666def

dart-lang/sdk@24c7666def Update tests that have the current version number hardcoded
dart-lang/sdk@f88ce7aef5 Increase Dart version to 2.10

* Update language version.

* Update license.

* Hpdate language version.

* Update license.
2020-07-24 11:00:34 -07:00
gaaclarke
21efd7325e
Made the linter print out more information in its output and fixed bugs (#19895) 2020-07-22 15:38:09 -07:00
skia-flutter-autoroll
e120fe0361
Roll Fuchsia Linux SDK from 39EKo... to nP7Ux... (#19825) 2020-07-16 16:56:10 -07:00
Jonah Williams
3fb6899e0e
[null-safety] remove package references from flutter frontend-server test, ci analyze (#19810) 2020-07-16 12:16:02 -07:00
Jonah Williams
5d757690d5
[null-safety] update use of dot packages to package_config.json (#19780)
Work towards flutter/flutter#60999

All usage of .packages must eventually be replace with package_config.json to support language versioning.
2020-07-15 15:26:34 -07:00
Kaushik Iska
7b1515ed29
Revert "ensure we do not double publish to CIPD (#19724)" (#19759)
This reverts commit 56bb3c5b335820c9ee97ec82cd63a5a471bbc604.
2020-07-14 18:55:03 -07:00
Christopher Fujino
56bb3c5b33
ensure we do not double publish to CIPD (#19724) 2020-07-14 14:19:14 -07:00
Chase Latta
b919945af8
include list_libraries.dart as a snapshot for fuchsia (#19567) 2020-07-07 11:16:50 -07:00
Jonah Williams
35b5aa5af2
switch const finder to package_config (#19576)
Generate package config during gclient runhooks and update BUILD.gn to reference it
2020-07-07 10:31:01 -07:00
Chris Yang
cc9ccf98ae
Implement mutator stack on Android hybrid composition platform view (#19426) 2020-07-04 13:03:04 -07:00
renyou
cee437e8d1
Revert "Add tests & --unopt to build_fuchsia_artifacts (#18625)" (#19494)
This reverts commit fae8141f9f5f64bd9aad8d53f031f2416bf82ec8.
2020-07-03 13:26:19 -07:00
Jonah Williams
9837bb062c
generate package config during runhooks (#19428)
The dart SDK needs to ship several packages which have opted into null safety for the tech preview. This requires the use of a package_config.json for compilation as this file contains the language versions. Use a dart script to generate the package_config file from the .packages file, and include that in the DEPS hooks section.

Fixes flutter/flutter#60628
2020-06-30 17:48:36 -07:00
Alexandre Ardhuin
218d98f4d8
Operator equals (#19303)
* use Object for operator==

* apply style guide for operator==
2020-06-30 23:16:31 +02:00
David Worsham
fae8141f9f
Add tests & --unopt to build_fuchsia_artifacts (#18625)
We can build unoptimized code for easier debugging with this flag.
2020-06-29 16:39:15 -07:00
Chase Latta
a4c842f1e6
[fuchsia] include icudtl.dat in cipd bucket (#19296)
Includes the icudtl.dat file which is built into the runner
so it can be used in testing from within the fuchsia repo
2020-06-25 13:04:19 -07:00
Filip Filmar
2a5053f299
[fuchsia] Adds --targets arg for build_fuchsia_artifacts.py (#19109)
The Fuchsia artifact builder didn't allow the end user to add more
packages to build for Fuchsia.  The current default is building only
the platform-specific packages; but packages like
`flutter/shell/common:shell_tests` are also defined for Fuchsia but
not compiled by default.

This change makes it less of a hassle to compile such packages.
2020-06-22 14:51:57 -07:00
Michael Goderbauer
ed5df03dcd
Word substitutions (#19111) 2020-06-18 11:05:24 -07:00
Siva
60a9b85f06
Manual roll of Dart 6d4e7d6830...021a49e88c (#19074)
* 1. Manual roll of Dart 6d4e7d6830...021a49e88c

dart-lang/sdk@021a49e88c Update the way to get feature set and language version.
dart-lang/sdk@d1638508c1 Migration: streamline behavior injection in migration_cli_test.dart.

2. Update ICU dependency and adjust license script to account for this
   change.

* Update license tool signature.
2020-06-16 16:50:30 -07:00
stuartmorgan
5c69b8beb5
Roll ANGLE to ToT (#15868)
Updates the ANGLE checkout to the latest master. Among other things, picks up fixes for errors when building under Visual Studio 2019.

Part of fix for https://github.com/flutter/flutter/issues/48831
2020-06-10 08:52:57 -07:00
Jonah Williams
d13861da2b
Remove simulator build mode restrictions (#18898) 2020-06-08 12:33:02 -07:00
George Wright
ef43e6e3f2
Enable LTO for Fuchsia artifact builds (#18481) 2020-05-18 13:35:01 -07:00
Kaushik Iska
dc500fdfc2
[fuchsia] Dbg symbols cipd package doesn't contain tmp dir (#18433)
Fixes: fxb/41743
2020-05-18 12:22:00 -07:00
George Wright
c8ff03caca
Publish validation layer deps as part of the fuchsia artifacts (#18214) 2020-05-08 12:39:02 -07:00
Ali Mahdiyar
9cdb5a9b6a
Custom unicode handling for Android backspace via JNI to ICU (#17960) 2020-05-06 14:01:02 -07:00
Jason Simmons
663bfe8d61
Remove the ResourceCleaner from the Android embedding (#18072) 2020-05-04 16:34:02 -07:00
Dan Field
fa0e464a71
use clang on Windows (#17407)
* use clang on Windows for everything but Android

This pulls the Clang build from Chromium. We should eventually switch to use the Fuchsia toolchain when it is available.
2020-04-29 09:38:15 -07:00
Nurhan Turgut
2db3276573
use $CIRRUS_BASE_BRANCH for the branch name (#18014)
use $CIRRUS_BASE_BRANCH for getting the branch name when cloning the flutter repo.
2020-04-28 17:23:20 -07:00