DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

improve error messages for font-subset (#20410)

Browse Source
This commit is contained in:
Dan Field 2020-08-11 11:45:22 -07:00 committed by GitHub
parent be78eba183
commit 93cdb907c3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
tools/font-subset/main.cc
View File

@ -63,14 +63,18 @@ int main(int argc, char** argv) {
hb_blob_create_from_file(input_file_path.c_str()));
if (!hb_blob_get_length(font_blob.get())) {
std::cerr << "Failed to load input font " << input_file_path
<< "; aborting." << std::endl;
<< "; aborting. This error indicates that the font is invalid or "
"the current version of Harfbuzz is unable to process it."
<< std::endl;
return -1;
}
HarfbuzzWrappers::HbFacePtr font_face(hb_face_create(font_blob.get(), 0));
if (font_face.get() == hb_face_get_empty()) {
std::cerr << "Failed to load input font face " << input_file_path
<< "; aborting." << std::endl;
<< "; aborting. This error indicates that the font is invalid or "
"the current version of Harfbuzz is unable to process it."
<< std::endl;
return -1;
}
@ -103,13 +107,18 @@ int main(int argc, char** argv) {
HarfbuzzWrappers::HbFacePtr new_face(hb_subset(font_face.get(), input.get()));
if (new_face.get() == hb_face_get_empty()) {
std::cerr << "Failed to subset font; aborting." << std::endl;
std::cerr
<< "Failed to subset font; aborting. This error normally indicates "
"the current version of Harfbuzz is unable to process it."
<< std::endl;
return -1;
}
HarfbuzzWrappers::HbBlobPtr result(hb_face_reference_blob(new_face.get()));
if (!hb_blob_get_length(result.get())) {
std::cerr << "Failed get new font bytes; aborting" << std::endl;
std::cerr << "Failed get new font bytes; aborting. This error may indicate "
"low availability of memory or a bug in Harfbuzz."
<< std::endl;
return -1;
}