Alexander Aprelev
90ee66eeaa
Roll watcher dependency for web_ui to 1.1.0. ( flutter/engine#42248 )
...
Incoming dart sdk roll
https://dart.googlesource.com/sdk.git/+log/90b4df96e9dc..4881eadbade6
needs updated version of watcher due to FileSystemEvent becoming sealed.
2023-05-23 09:44:20 -07:00
Mouad Debbar
9aec8c5c62
[web] Move platformViewRegistry to ui_web ( flutter/engine#41877 )
...
In this PR, I'm leaving a getter for `platformViewRegistry` in `dart:ui` for backwards compatibility. At some point, we need to properly deprecate it (e.g. print a warning asking users to import it from `dart:ui_web` instead).
Next step is to migrate all call sites in flutter/flutter, flutter/packages and flutter/devtools (anything else?).
Issue: https://github.com/flutter/flutter/issues/126831
Fixes https://github.com/flutter/flutter/issues/41563
2023-05-23 16:17:56 +00:00
skia-flutter-autoroll
e784e3174d
Roll Skia from 3ded22186598 to 225d51031ad0 (1 revision) ( flutter/engine#42246 )
...
https://skia.googlesource.com/skia.git/+log/3ded22186598..225d51031ad0
2023-05-23 kjlubick@google.com Make codec registration for decoding explicit
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,rmistry@google.com,scroggo@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-23 14:59:34 +00:00
skia-flutter-autoroll
1c4967760e
Roll Fuchsia Mac SDK from DzmjiSg6XC0JUfbKP... to aAjEDVse7qfMt0NqE... ( flutter/engine#42245 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-23 14:45:41 +00:00
skia-flutter-autoroll
9b509745e3
Roll Skia from 4d0166106722 to 3ded22186598 (2 revisions) ( flutter/engine#42242 )
...
https://skia.googlesource.com/skia.git/+log/4d0166106722..3ded22186598
2023-05-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e2fe2393abb4 to 8a3971e5e9c5 (7 revisions)
2023-05-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from a4b1d12cd5ba to 3f633521356d (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,rmistry@google.com,scroggo@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-23 09:39:24 +00:00
William Hesse
09f694b9bc
Add leak_tracker package from Dart DEPS to DEPS ( flutter/engine#42241 )
...
The package leak_tracker was added to Dart DEPS, and analysis_server now depends on it.
This fixes a breakage when rolling Dart into Flutter engine.
Bug: https://github.com/flutter/devtools/issues/5606
2023-05-23 08:55:22 +00:00
skia-flutter-autoroll
48d103e6ed
Roll Dart SDK from 1ca8f8368ecc to 90b4df96e9dc (2 revisions) ( flutter/engine#42239 )
...
https://dart.googlesource.com/sdk.git/+log/1ca8f8368ecc..90b4df96e9dc
2023-05-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-136.0.dev
2023-05-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-135.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-23 08:07:30 +00:00
skia-flutter-autoroll
0497fa73e4
Roll Skia from 1c3d1e200d72 to 4d0166106722 (2 revisions) ( flutter/engine#42238 )
...
https://skia.googlesource.com/skia.git/+log/1c3d1e200d72..4d0166106722
2023-05-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from ddf59ec4e8fc to 97f14b3b6c39
2023-05-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from a17cd49ee1eb to ddf59ec4e8fc (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,rmistry@google.com,scroggo@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-23 07:17:30 +00:00
Brandon DeRosier
892d301b87
[Impeller] Place Entity Geometry classes in separate TUs ( flutter/engine#42236 )
...
Resolves https://github.com/flutter/flutter/issues/122854.
One of those quality of life things I keep putting off...
2023-05-22 22:46:41 -07:00
skia-flutter-autoroll
580e361377
Roll Skia from fc369d15070f to 1c3d1e200d72 (1 revision) ( flutter/engine#42235 )
...
https://skia.googlesource.com/skia.git/+log/fc369d15070f..1c3d1e200d72
2023-05-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 30dc1b5abb1f to cd1fb6876701 (9 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,rmistry@google.com,scroggo@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-23 05:26:27 +00:00
skia-flutter-autoroll
545e8806ff
Roll Skia from 6a57876d0e44 to fc369d15070f (1 revision) ( flutter/engine#42234 )
...
https://skia.googlesource.com/skia.git/+log/6a57876d0e44..fc369d15070f
2023-05-23 brianosman@google.com Revert "Replace SkOpts::hash/hash_fn with SkChecksum::Hash32"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,rmistry@google.com,scroggo@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-23 03:54:27 +00:00
skia-flutter-autoroll
a8326dc3f7
Roll Fuchsia Linux SDK from LrfeC0dLk8ToJVik5... to Zbd3haNY2Idcdu1Fj... ( flutter/engine#42232 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-23 03:30:18 +00:00
Zachary Anderson
1a85b3733f
Revert "[ios_platform_view] only recycle maskView when the view is applying mutators #41573 " ( flutter/engine#42231 )
...
Reverts flutter/engine#42115
Failing on the framework tree as in
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20platform_views_scroll_perf_ios__timeline_summary/11103/overview
2023-05-22 19:35:47 -07:00
skia-flutter-autoroll
10a6d1ec51
Roll Skia from ac87929b3d2e to 6a57876d0e44 (2 revisions) ( flutter/engine#42230 )
...
https://skia.googlesource.com/skia.git/+log/ac87929b3d2e..6a57876d0e44
2023-05-22 nscobie@google.com Revert "Disable thinLTO in skia for riscv"
2023-05-22 scroggo@google.com Revert "[skottie] Don't revalidate during render()"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,rmistry@google.com,scroggo@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-23 02:01:27 +00:00
skia-flutter-autoroll
a5bb722995
Roll Fuchsia Mac SDK from QAwORJOkyNl4J3x4Y... to DzmjiSg6XC0JUfbKP... ( flutter/engine#42227 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-23 01:55:51 +00:00
skia-flutter-autoroll
6921d843b3
Manual roll Dart SDK from b3e1eeda4918 to 1ca8f8368ecc (5 revisions) ( flutter/engine#42229 )
...
Manual roll requested by aam@google.com
https://dart.googlesource.com/sdk.git/+log/b3e1eeda4918..1ca8f8368ecc
2023-05-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-134.0.dev
2023-05-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-133.0.dev
2023-05-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-132.0.dev
2023-05-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-131.0.dev
2023-05-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-130.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com ,dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-23 01:54:22 +00:00
skia-flutter-autoroll
98661be0ff
Roll Skia from d448fe07ea46 to ac87929b3d2e (8 revisions) ( flutter/engine#42226 )
...
https://skia.googlesource.com/skia.git/+log/d448fe07ea46..ac87929b3d2e
2023-05-22 brianosman@google.com Replace SkOpts::hash/hash_fn with SkChecksum::Hash32
2023-05-22 jamesgk@google.com Make destcolor GM non-Ganesh-specific
2023-05-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from dc49e5c6de1e to e2fe2393abb4 (1 revision)
2023-05-22 brianosman@google.com Add wyhash as SkChecksum::Hash32/64
2023-05-22 brianosman@google.com Make ChecksumBench much more interesting and representative
2023-05-22 michaelludwig@google.com Revert "[skif] Add FilterResult::Builder and update SkMergeImageFilter to use it"
2023-05-22 johnstiles@google.com Add WGSL support for anonymous function parameters.
2023-05-22 robertphillips@google.com Add Protected checks to GL and Mock onCanCopySurface methods
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,rmistry@google.com,scroggo@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-23 00:10:08 +00:00
Dan Field
ccd8afabde
Make FML_LOG safe from static initialization ( flutter/engine#42219 )
...
I ran into this while trying to get some printing going for places where we're creating thread local keys.
Supposedly, just including `<iostream>` should statically initialize `std::cout/cerr`, but it gets really hard to reason about whether your statically initialized code is going to be initialized before or after that happens. I tried making sure that the TU for `fml/logging.cc` did that initialization statically, but that also failed in the verison of the test included here (it passed in some other iterations that modified run_all_unittests.cc). We _could_ make sure it happens each and every time we touch `std::cerr` but ... we could also just use `fprintf(stderr, ...)` and it works just fine.
/cc @flar who ran into problems around this a little while back and was asking about it.
2023-05-23 00:02:17 +00:00
Emircan Uysaler
d84c05920b
[fuchsia] Bind ChildViewWatcher on platform thread ( flutter/engine#42222 )
...
This CL posts ChildViewWatcher calls on platform thread.
Bug: fxb/125256
2023-05-23 10:00:27 +10:00
skia-flutter-autoroll
652e1f18ca
Roll Dart SDK from b3e1eeda4918 to 1ca8f8368ecc (5 revisions) ( flutter/engine#42224 )
...
https://dart.googlesource.com/sdk.git/+log/b3e1eeda4918..1ca8f8368ecc
2023-05-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-134.0.dev
2023-05-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-133.0.dev
2023-05-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-132.0.dev
2023-05-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-131.0.dev
2023-05-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-130.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-22 23:35:04 +00:00
Jason Simmons
b4b589148b
[Impeller] Return image decoder error messages to the Dart API ( flutter/engine#42175 )
...
Fixes https://github.com/flutter/flutter/issues/127061
See https://github.com/flutter/flutter/issues/126768
2023-05-22 20:43:05 +00:00
fzyzcjy
7387859481
Again a two-word super tiny typo ( flutter/engine#42181 )
...
Find this when reading source code today...
Btw, what about introducing a spell checker to Flutter source code? ;)
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-05-22 13:28:16 -07:00
Chris Yang
b20b25128a
Reland "[ios_platform_view] only recycle maskView when the view is applying mutators #41573 " ( flutter/engine#42115 )
...
The original PR (https://github.com/flutter/engine/pull/41573 ) was reverted due to https://github.com/flutter/flutter/issues/126951
The issue will be fixed in https://github.com/flutter/engine/pull/42079
This needs to be landed after https://github.com/flutter/engine/pull/42079
fixes: https://github.com/flutter/flutter/issues/125620
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-05-22 20:10:37 +00:00
Jason Simmons
c40d8bbc8e
[Impeller] Use untransformed text bounds to calculate the size of ColorSourceTextContents ( flutter/engine#42142 )
...
Previously this was attempting to invert the TransformBounds done by GetCoverage. TransformBounds computes a bounding box of the transformed rectangle and can not be reversed.
Fixes https://github.com/flutter/flutter/issues/127103
2023-05-22 20:01:49 +00:00
Jonah Williams
19c071da39
[Impeller] Add UV compute shader. ( flutter/engine#42192 )
...
Adds a compute shader that computes the UV mapping for an arbitrary geometry. Use it with drawPoints since I didn't realize it was possible to use an image shader with this ð .
2023-05-22 20:01:47 +00:00
Jonah Williams
e4427e5c92
[Impeller] remove final cmd buffer waitUntilScheduled on physical iOS ( flutter/engine#42160 )
...
From local testing, this doesn't seem to be necessary on physical iOS devices, with or without platform views.
2023-05-22 20:00:37 +00:00
skia-flutter-autoroll
fee0f3ae59
Roll Skia from 2612bb159848 to d448fe07ea46 (5 revisions) ( flutter/engine#42213 )
...
https://skia.googlesource.com/skia.git/+log/2612bb159848..d448fe07ea46
2023-05-22 michaelludwig@google.com [skif] Remove dedicated SkDropShadowImageFilter implementation
2023-05-22 fmalita@chromium.org [skottie] Don't revalidate during render()
2023-05-22 michaelludwig@google.com [skif] Add FilterResult::Builder and update SkMergeImageFilter to use it
2023-05-22 michaelludwig@google.com Skip flaky tests in Xe and Radeon ANGLE D3D9
2023-05-22 kjlubick@google.com Update all versions of Bazelisk and add one for Intel Macs
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,rmistry@google.com,scroggo@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-22 19:59:03 +00:00
Alexander Aprelev
88faba02e2
Skip and ignore boringssl/src/rust when looking for the licenses. ( flutter/engine#42210 )
...
third_party/boringssl/src/rust/bssl-crypto/deny.toml coming in as part of https://dart-review.googlesource.com/c/sdk/+/304210 triggers 'potential license' license script error.
Rust sources of boringssl are not included into flutter, don't need to be scanned for licenses.
2023-05-22 19:53:54 +00:00
Jonah Williams
6ee594c86f
[Impeller] Create reusable prefix sum. ( flutter/engine#42167 )
...
Creates a reusable function macro for performing a prefix sum. Eventually, we'll need this for polyline decomposition

Reasonably fast with max (1024) input elements.
2023-05-22 16:08:06 +00:00
skia-flutter-autoroll
80d986be9f
Roll Skia from ef226c5a7930 to 2612bb159848 (1 revision) ( flutter/engine#42209 )
...
https://skia.googlesource.com/skia.git/+log/ef226c5a7930..2612bb159848
2023-05-22 kjlubick@google.com Remove GPU code from MaskFilters
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,rmistry@google.com,scroggo@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-22 16:08:05 +00:00
skia-flutter-autoroll
2fe4f4071c
Roll Fuchsia Linux SDK from NE_eTA29vOHN4goJL... to LrfeC0dLk8ToJVik5... ( flutter/engine#42208 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-22 13:41:23 +00:00
skia-flutter-autoroll
92d8810b09
Roll Fuchsia Mac SDK from HPZKiLZlLCR6moOCE... to QAwORJOkyNl4J3x4Y... ( flutter/engine#42207 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-22 12:01:27 +00:00
skia-flutter-autoroll
3c3a0d54b7
Roll Skia from 16c60e5bebfc to ef226c5a7930 (1 revision) ( flutter/engine#42206 )
...
https://skia.googlesource.com/skia.git/+log/16c60e5bebfc..ef226c5a7930
2023-05-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from b76166d0275a to a4b1d12cd5ba (11 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,rmistry@google.com,scroggo@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-22 10:26:24 +00:00
skia-flutter-autoroll
90c76a36b8
Roll Skia from 79088c6b7a33 to 16c60e5bebfc (1 revision) ( flutter/engine#42205 )
...
https://skia.googlesource.com/skia.git/+log/79088c6b7a33..16c60e5bebfc
2023-05-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 2968842d10ac to dc49e5c6de1e (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,rmistry@google.com,scroggo@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-22 08:19:28 +00:00
skia-flutter-autoroll
82d77fd9ab
Roll Skia from 76303a5498e9 to 79088c6b7a33 (2 revisions) ( flutter/engine#42204 )
...
https://skia.googlesource.com/skia.git/+log/76303a5498e9..79088c6b7a33
2023-05-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from a17cd49ee1eb to 19a1ee338aa1
2023-05-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from b6ae2e881c8b to a17cd49ee1eb (7 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,rmistry@google.com,scroggo@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-22 07:27:35 +00:00
skia-flutter-autoroll
0eb04015fb
Roll Skia from 2d4ea9542e83 to 76303a5498e9 (1 revision) ( flutter/engine#42203 )
...
https://skia.googlesource.com/skia.git/+log/2d4ea9542e83..76303a5498e9
2023-05-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 34fd751bd753 to 30dc1b5abb1f (17 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,rmistry@google.com,scroggo@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-22 05:31:22 +00:00
skia-flutter-autoroll
72a48f5755
Roll Fuchsia Linux SDK from 88pzkUAkSKsJrNG38... to NE_eTA29vOHN4goJL... ( flutter/engine#42202 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-22 00:51:22 +00:00
Tong Mu
4a01af4737
[macOS] Clean up unused methods in FlutterRenderer ( flutter/engine#42196 )
...
This PR removes the methods in `FlutterRenderer` that will never be
used.
These methods allows the engine to get a drawable and present a
drawable, but they will never be called on the macOS embedder. This is
because they go through the `FlutterMetalRendererConfig` struct to
`GPUSurfaceMetalSkia`, which is bypassed if the engine has a non-null
external view embedder, which the macOS always provides.
Removing these methods not only cleans up the code (and the confusion),
but also reduces the methods that might need to be migrated for the
multi-view project.
After this change, `FlutterRenderer` is left with very few
functionalities:
* It hosts `device` and `commandQueue`.
* It creates `FlutterRendererConfig`.
* It implements `FlutterTextureRegistry` and
`FlutterTextureRegistrarDelegate`, linking `FlutterTexture` and
`FlutterTextureRegistrar`.
We might want to refactor this class, but that's for the future.
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-05-21 16:53:57 -07:00
skia-flutter-autoroll
afba20df24
Roll Fuchsia Mac SDK from JU-dKW3CQIUzhbqWE... to HPZKiLZlLCR6moOCE... ( flutter/engine#42201 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-21 23:16:07 +00:00
skia-flutter-autoroll
b43f7317f1
Roll Skia from 5b2005e47bf3 to 2d4ea9542e83 (1 revision) ( flutter/engine#42200 )
...
https://skia.googlesource.com/skia.git/+log/5b2005e47bf3..2d4ea9542e83
2023-05-21 johnstiles@google.com Fix fuzzer-discovered issue with empty buffers.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,rmistry@google.com,scroggo@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-21 17:03:23 +00:00
skia-flutter-autoroll
e41cfec63d
Roll Skia from 7c7dff949a27 to 5b2005e47bf3 (1 revision) ( flutter/engine#42199 )
...
https://skia.googlesource.com/skia.git/+log/7c7dff949a27..5b2005e47bf3
2023-05-21 johnstiles@google.com Reject SkSL programs that are larger than 8MB.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,rmistry@google.com,scroggo@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-21 15:12:05 +00:00
skia-flutter-autoroll
b76fe66050
Roll Fuchsia Linux SDK from gQ989rlKAuTJHQR-C... to 88pzkUAkSKsJrNG38... ( flutter/engine#42198 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-21 12:00:23 +00:00
skia-flutter-autoroll
1f54e772df
Roll Fuchsia Mac SDK from 868_67npyO8nD_JCx... to JU-dKW3CQIUzhbqWE... ( flutter/engine#42197 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-21 10:30:23 +00:00
skia-flutter-autoroll
ae27a39ba4
Roll Skia from a60bfcb01af9 to 7c7dff949a27 (1 revision) ( flutter/engine#42195 )
...
https://skia.googlesource.com/skia.git/+log/a60bfcb01af9..7c7dff949a27
2023-05-21 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,johnstiles@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-21 08:12:01 +00:00
skia-flutter-autoroll
f9ee7a1658
Roll Fuchsia Linux SDK from c_fRDyBVZX-MwW5fS... to gQ989rlKAuTJHQR-C... ( flutter/engine#42194 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-20 23:09:22 +00:00
skia-flutter-autoroll
4a20bc8d74
Roll Skia from f3e9cb7d37fd to a60bfcb01af9 (1 revision) ( flutter/engine#42193 )
...
https://skia.googlesource.com/skia.git/+log/f3e9cb7d37fd..a60bfcb01af9
2023-05-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 44392282e953 to 2968842d10ac (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,johnstiles@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-20 22:51:09 +00:00
skia-flutter-autoroll
5d71e56f33
Roll Fuchsia Mac SDK from sfLkc5VBFU6UkljF6... to 868_67npyO8nD_JCx... ( flutter/engine#42191 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-20 21:42:19 +00:00
Kevin Lubick
7751d1c5eb
Move SkSurface::MakeNull to SkSurfaces::Null ( flutter/engine#42158 )
...
In https://skia-review.googlesource.com/c/skia/+/696537 (and earlier in
https://skia-review.googlesource.com/c/skia/+/687639 ), Skia moved all
SkSurface factories. This changes the last calls of the old static
methods to the methods in the `SkSurfaces` namespace
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-05-20 10:11:44 -04:00
skia-flutter-autoroll
a98b701976
Roll Fuchsia Linux SDK from TWjmvLCOnYAUgAzvT... to c_fRDyBVZX-MwW5fS... ( flutter/engine#42189 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-20 10:20:23 +00:00
skia-flutter-autoroll
2b107100a3
Roll Skia from b4a4782cf89d to f3e9cb7d37fd (1 revision) ( flutter/engine#42188 )
...
https://skia.googlesource.com/skia.git/+log/b4a4782cf89d..f3e9cb7d37fd
2023-05-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 6d84c9857781 to a17cd49ee1eb
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,johnstiles@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-20 09:32:24 +00:00