4531 Commits

Author SHA1 Message Date
Chinmay Garde
8fc8c8b670 Create an empty group that the Fuchsia bots use to determine the root_out_dir. (flutter/engine#5265)
The Fuchsia bots seem to reference this target to figure out the root_out_directory https://fuchsia.googlesource.com/build/+/master/dart/dart_test.gni#67. Note that the presence of the flutter_tester binary location itself is not depended on. Instead, the target is used to infer the directory containing the flutter_tester after a build.

Patching the //build repository in Fuchsia would mean making the tree red till a //topaz patch lands. To avoid doing this, we add back the missing reference.
2018-05-15 12:50:10 -07:00
Jason Simmons
4f15413841 Support a model where the application creates a FlutterNativeView that is never destroyed (flutter/engine#5256)
This allows applications to start a Flutter engine instance during app startup
and keep it running throughout the app process' lifetime.

FlutterActivity subclasses can override createFlutterNativeView to provide a
preinitialized FlutterNativeView instance and override retainFlutterNativeView
to signal that the FlutterNativeView should be kept alive when the activity
is destroyed.
2018-05-15 12:05:54 -07:00
skia-flutter-autoroll
2f8d2f374e Roll src/third_party/skia/ 81f60ecd9..6e9f34f0e (7 commits) (flutter/engine#5264)
Auto-roller completed checks. Merging.
2018-05-15 14:28:56 -04:00
Matan Lurey
7528e47e84 Fix documentation mistake in painting.dart (flutter/engine#5236)
s/`[red]`/_correct color_.
2018-05-15 08:00:30 -07:00
skia-flutter-autoroll
e24cb3c172 Roll src/third_party/skia/ 6bbd386a0..81f60ecd9 (1 commit) (flutter/engine#5262)
Auto-roller completed checks. Merging.
2018-05-15 10:58:55 -04:00
skia-flutter-autoroll
0921f06525 Roll src/third_party/skia/ 3b9effcb1..6bbd386a0 (2 commits) (flutter/engine#5260)
Auto-roller completed checks. Merging.
2018-05-14 22:27:56 -04:00
Chinmay Garde
baf5293906 Create a session presentation backed Vsync waiter on Fuchsia. (flutter/engine#5255) 2018-05-14 16:51:19 -07:00
skia-flutter-autoroll
8fa8950266 Roll src/third_party/skia/ 8803ebb47..3b9effcb1 (8 commits) (flutter/engine#5257)
Auto-roller completed checks. Merging.
2018-05-14 18:59:55 -04:00
skia-flutter-autoroll
892fc8df55 Roll src/third_party/skia/ 16ffdd4ed..8803ebb47 (8 commits) (flutter/engine#5254)
Auto-roller completed checks. Merging.
2018-05-14 15:30:56 -04:00
skia-flutter-autoroll
2bb527ef21 Roll src/third_party/skia/ 5140f9a8e..16ffdd4ed (4 commits) (flutter/engine#5252)
Auto-roller completed checks. Merging.
2018-05-14 12:00:56 -04:00
skia-flutter-autoroll
74ea493f15 Roll src/third_party/skia/ b06a1eb4e..5140f9a8e (1 commit) (flutter/engine#5251)
Auto-roller completed checks. Merging.
2018-05-14 08:28:55 -04:00
skia-flutter-autoroll
b928a1f4c9 Roll src/third_party/skia/ ec48812c5..b06a1eb4e (1 commit) (flutter/engine#5250)
Auto-roller completed checks. Merging.
2018-05-13 14:31:55 -04:00
skia-flutter-autoroll
44220baf50 Roll src/third_party/skia/ 96b0b46f2..ec48812c5 (1 commit) (flutter/engine#5249)
Auto-roller completed checks. Merging.
2018-05-12 19:08:56 -04:00
skia-flutter-autoroll
d8bee18a47 Roll src/third_party/skia/ 3202ac4d2..96b0b46f2 (1 commit) (flutter/engine#5248)
Auto-roller completed checks. Merging.
2018-05-12 02:24:55 -04:00
Chinmay Garde
f89c3f3ed1 Terminate the engine immediately if there are isolate launch errors. (flutter/engine#5244) 2018-05-11 18:32:35 -07:00
skia-flutter-autoroll
bcca6e20ec Roll src/third_party/skia/ 811b944a8..3202ac4d2 (5 commits; 1 trivial rolls) (flutter/engine#5242)
Auto-roller completed checks. Merging.
2018-05-11 18:23:55 -04:00
Jason Simmons
b0d9893494 Allow Canvas.saveLayer without bounds (flutter/engine#5240)
Fixes https://github.com/flutter/flutter/issues/17497
2018-05-11 15:18:35 -07:00
Jonah Williams
984b70e6ad swap brightness definition on iOS to match android (flutter/engine#5239) 2018-05-11 14:01:29 -07:00
Zachary Anderson
2240b7e4c3 Roll dart to 46ab040e589adc5200370dec7952ce5150850822 (flutter/engine#5235) 2018-05-11 12:43:53 -07:00
Jason Simmons
4ff9861d43 Re-land "libtxt: exclude trailing whitespace from right-justified lines" (flutter/engine#5234)
If a line is right justified, then remove any trailing whitespace from the
text range given to Minikin.  Right justification shifts the line's glyphs
by the layout advance computed by Minikin, and this advance should exclude
whitespace so that the last visible character will be flush with the right
margin.

Also exclude trailing whitespace from center justified lines.

Fixes https://github.com/flutter/flutter/issues/17502
Fixes https://github.com/flutter/flutter/issues/16333
2018-05-11 12:17:31 -07:00
skia-flutter-autoroll
55ebf10053 Roll src/third_party/skia/ 1d686a962..811b944a8 (25 commits; 5 trivial rolls) (flutter/engine#5237)
Auto-roller completed checks. Merging.
2018-05-11 14:55:59 -04:00
Jason Simmons
6431f174d4 Detach from JNI before exiting the GPU thread. (flutter/engine#5231)
The GPU thread calls into Java via JNI in order to update external textures.

Fixes https://github.com/flutter/flutter/issues/17329
2018-05-11 11:42:19 -07:00
Todd Volkert
a911ad0a97 Revert ad4771c35f3a36a69c0b777abff993fa5ab398a4 (flutter/engine#5233)
In introduced a regression in text layout: https://github.com/flutter/flutter/issues/17502
2018-05-10 23:50:19 -07:00
Todd Volkert
f423883164 Revert 399a30a974dd80076fcaa106f9df10b6a40d5c81 (flutter/engine#5232)
It introduced https://github.com/dart-lang/sdk/issues/33095
2018-05-10 18:49:41 -07:00
Ben Konyi
4ef87176ae Fixed Windows build after Blink removal (flutter/engine#5230) 2018-05-10 17:21:12 -07:00
Jason Simmons
67381c0c35 Remove Blink code (flutter/engine#5218)
Fixes https://github.com/flutter/flutter/issues/12212
2018-05-10 15:57:29 -07:00
skia-flutter-autoroll
3a45cda6f8 Roll src/third_party/skia/ f31fece65..1d686a962 (10 commits) (flutter/engine#5228)
Auto-roller completed checks. Merging.
2018-05-10 16:20:55 -04:00
Todd Volkert
99d48aab30 Bypass the raster cache when screenshotting (flutter/engine#5227)
Fixes https://github.com/flutter/flutter/issues/17448
2018-05-10 12:32:17 -07:00
Zachary Anderson
399a30a974 Roll Dart to 779dc6eb85c1f2249803d017ffa785c85681ad1b (flutter/engine#5224)
This roll includes the following Dart SDK commits:

779dc6eb85 Stop leaking file descriptors for HTTP clients
b294e48bdf Hack to fix sort order
5951f1e4f1 Improve enum declaration identifier recovery
1860096702 Use correct type arguments for Forest.
6e15762556 Bump to linter 0.1.50
e5820f7e94 Place generator body in same unit as entry
41fcbd097c [VM runtime] Initial version of Kernel Bytecode interpreter in VM runtime. Not fully working yet, only x64, no gc, no frame walking, etc...
a4772ea629 Refer to Expression and Statement via prefix
310745ca8b Add support for adding missing named parameters to constructors.
e8c8557fcb Switch the fix for adding not named required/positional parameter to using _ExecutableParameters.
fa071e8ecb Update AstBuildingForest tests
bedf640eca Address review comments from previous CLs
2d95c54392 CHANGELOG for cast/retype changes
6efd3b3654 Refactor output code for generators
e67222a92b [vm/compiler] Do not use call->ArgumentAt(0) to access receiver.
5afa2dca51 [dart:io] Fix ProcessStartMode.values
a49fd95d59 [CHANGELOG] Update for dart:io constant rename
3ec1b929e3 Remove dependencies on isolates.
2ad715e706 [vm/hr] Directly compare type arguments count when validate hot reload.
8dbe716085 Remove the unused GenericCovariantInterface bit
f61e1c0fb3 Mark metadata_test as failing on dart_precompiled
24224ced5b [VM] Update status file, test became much slower after strong-mode changes to mirrors implementation
a8364e3412 Add missing method to FastaParserTestCase
b5154dd01e Revert "[vm/kernel] Expression execution through Kernel.
2daa5610ac Add more issue numbers to fasta status file
b25e12ddc6 [fasta] Remove BuiltTypeBuilder
afd0a52a5a [vm/kernel] Expression execution through Kernel.
41eb5ddfdc Add some issue numbers to fasta status file
df9af04061 Remove CompilerOptions.useKernel
972d4b0b1d Add frontendInternal key and external example to messages tests
ee0a2cd8bc Restore type arguments on Forest
a65dc90bd0 Improve error message for invalid characters
fe3f87f192 [fasta] Reland "Handle annotations on formals and variables"
4c7926107e Remove support for --use-old-frontend option
039e8a1755 [vm/kernel] Enable kernel2kernel "constants" transformation in AOT mode (after running TFA)
2f781e46b0 Introduced support for metadata on enum values
862a894de6 Make `cast` do the same things as `retype`.
b347839ee6 Remove impact_test
3adb731af3 Remove id equivalence test and ast id helpers
d0112f4431 Remove old frontend equivalence tests
17e22dfcd3 Remove unneeded kernel tests and sourcemap old-frontend tests
a0d3bef5fb [release] Prepare changelog for 2.0.0-dev.54.0
2f924e457e Revert "[infra] Temporarily remove windows builder from the CQ"
fd9823ae9e Issue 21965. Add Quick Fix for adding missing named parameter.
964dae472c Issue 30577. Use AST to find position for the first directive.
74d03e7a75 Add a test that reproduces hot reload issue when class type arguments change.
3beb7fe860 Fix how we pass the type-parameter to StreamIterator in for-in
cc034472bb Fix LineInfo.getOffsetOfLineAfter().
f2b137343c Do not run analyzer benchmarks in checked mode.
702aca4ab1 [vm] Address TODOs for warn on unused result.
ac6ea06fd2 [dart:io] Switch ProcessStartMode back to an enum
0bab7e6bfa Issue 32765. Improve guess for type name identifier.
b73541cffe Add a skeleton for Dart Folding
ebcf5bec30 Update Analyzer/CFE type resolution test to use AstBuildingForest
316b10216f Fix Analyzer warning
1d8620044a Call computeTypeVar rather than parseTypeArguments when parsing expressions
8f6c6c2a8e Implement some missing override checking
2296f9d637 Run transformations on expression compilation.
c9cd32fb58 Clean up Forest.literalList and Forest.literalMap
2ccafe7a54 [kernel] Change dill representation of doubles
51fa3f3b0c Decouple HNode from TypeMask
d3c7df35b4 Revive AbstractValueDomain
03abbc73d2 CFE support for expression evaluation, refactored.
054559c5f3 Revert "CFE support for compiling individual expressions in a context."
95fab34cdf [infra] Temporarily remove windows builder from the CQ
4f586e265e [fasta] Update expectation files after CL 50941
9c6c3dcd89 [fasta] Store calculated bounds of type variables as their defaults
831a6ba598 Remove useOldFrontend testing from various tests
9bac9ee596 Remove useOldFrontend from compiler_helper
4b53f7e0d2 Remove useOldFrontend testing from TypeEnvironment
8e885f4393 Remove CompileMode
27ae11e4d8 Filter instantiation stubs
2e1c17e5c1 Revert "dump-info: Use relative paths for library canonicalUri..."
e10f0717d2 fix test status for a few tests changed in 3002e47e
95c29e6fb0 First cut test for Analyzer/BodyBuilder integration test
b017db1e8c [corelib_2 tests] Bigint computations are slow on simulated architectures. An added regression test for modPow increased computation time.
446668e95c Add required information for three more cases
3002e47e36 cleanup language_2 and corelib_2 tests that import dart:mirrors
4da831fd3a Latest pub_semver
179b31c157 Allow built-in identifiers for non-type entities, with a warning.
603d832371 Test for sync* checks
d87642df9c fix #33036, dartdevk now uses CFE for patching its SDK
1b8a3b1045 Implement support for overridden elements that are declared in mixins.
6c301a4e32 Bring in the latest pub
e62dd0157e [VM bigint] Fix padding length in Montgomery Reduction (fixes #32626). Add regression test to existing bigint test.
8515d74332 Add ImportElement.namespace and use it in completion.
410db09743 Do not convert the worker object in jsinterop, just like we do for window
f62302b8ee Make extracted widgets follow Flutter style - const constructor and @required named parameters.
d624b8580a Add DartEditBuilder.writeReference().
2dd6aba0f4 Add the analyzer implementation of Forest
65d7bf8152 [vm] Align 64-bit atomic variables for 32-bit iOS.
de59cdf498 [VM] Fix for issue 33027 (Fixes strong mode runtime error in _FileSystemWatcher
3192d0052c Start adding parameters needed by analyzer
86ccd4f790 Fix poor error messages on null dereference
92f50475b8 Issue 32849. Use export namespace for import prefix and combinator completions.
66412a28f2 Use %systemroot% instead of hardcoded 'C:\Windows'
a06b1d96cb Revert "[VM] Reduce Smi size to 32 bit on 64 bit platforms"
89e43b4141 [fasta] Normalize type arguments as in Dart 1 when not in strong mode
dffbbad8a5 [gardening] Fix analyzer warning on regress_33040_instantiation_test
a6b6d6a608 [VM] Remove converted closure function code from the VM
56e47e6b2d Fix analyzer on #33040 regression test.
235b81d045 Remove MockCompiler
b74bb147ce Remove use of MockCompiler from type_test_helper
3cd0a1f5e4 Remove old_frontend and mirrors tests
add1e67295 Include generic type arguments in deferred load computation.
296ab86012 Revert "Add DartEditBuilder.writeTopLevelElementReference()."
e9e0166375 Add regression test for #33040
772c9bb5f3 [vm/kernel] Re-land partial instantiation of local functions.
5618373690 Copy timers to jsshell.js preamble
e5e83a29fb Revert "Add a fix for prefer_single_quotes"
eb2fbf501f Add a fix for prefer_single_quotes
f6a1f48450 Allow using pseudo keywords for names in refactorings.
332dc7f3e9 Issue 32935. Fix NPE in 'Make final' quick fix.
67d3e4e3a1 Use actual names of the @isTest of isTestGroup executable in outlines.
07ad1904f3 Sort declarations in type_system.dart and type_system_test.dart.
04e9f7da27 [vm/kernel/aot] Fix infinite looping in TFA (ensure convergence of analysis)
515a7acc0b [ VM / Dart 2 ] Updated status file entries for remaining DartAPI tests that are failing with issue numbers.
b7a63c8d52 Use @isTest and @isTestGroup to understand executable element as a test/group.
5904247715 Fix a typo in socket.dart.
23a1534432 Add DartEditBuilder.writeTopLevelElementReference().
a989bac685 [frontend-server] Re-enable depfile test on Windows.
543d8775e3 Clarify that global/local/static functions can also be closurized
64754764b1 Update computeType to call computeTypeParamOrArg
94be474fee Generate cross buildfiles for armsimdbc and armsimdbc64.
31597f1cd7 [fasta] Add more nodes to the Forest API
c8c994b26d Revert "Add some status entries for crashing tests related to issue"
f35bb0379d [vm/kernel] Initialize function type args even when resuming from yield.
19cf8d1768 [vm] Rewrite Intrinsifier::InitializeState to be data driven.
e434cb91e1 Mark some commonly failing flaky tests.
5a69552d34 [VM] Fix typo in 54d842a89c722b7c27762b96ba21fab55a2ad55a.
2f458c4c48 [vm] Reify more generics in the mirrors implementation to appease Dart 2.
54d842a89c [VM runtime] Explicitly specify length of parent type argument vector in native call Internal_prependTypeArguments to protect against vector reuse optimization. This is indirectly related to issue #33040.
50fbd1a3ed [GN] Fix dartanalyzer_aot target
e5e4871a04 Simplify 'this' caching in constructors.
8f52be2282 Don't infer types when there's an irreconcilable type mismatch.
dfa661d460 Add AnalysisSessionHelper.getTopLevelPropertyAccessor().
58f41fd1b5 update issue21159_test for Dart 2, fixes #30701
2018-05-10 11:13:36 -07:00
skia-flutter-autoroll
1d8c2c866c Roll src/third_party/skia/ 21015b700..f31fece65 (12 commits) (flutter/engine#5225)
Auto-roller completed checks. Merging.
2018-05-10 12:52:56 -04:00
skia-flutter-autoroll
c2fbfc681e Roll src/third_party/skia/ d31b2f674..21015b700 (1 commit) (flutter/engine#5223)
Auto-roller completed checks. Merging.
2018-05-10 09:24:56 -04:00
skia-flutter-autoroll
6cd7a2b4b4 Roll src/third_party/skia/ baf831d07..d31b2f674 (1 commit) (flutter/engine#5222)
Auto-roller completed checks. Merging.
2018-05-10 05:07:56 -04:00
skia-flutter-autoroll
5041f7e51e Roll src/third_party/skia/ 27c66e28e..baf831d07 (2 commits; 1 trivial rolls) (flutter/engine#5221)
Auto-roller completed checks. Merging.
2018-05-10 01:55:56 -04:00
skia-flutter-autoroll
d7c9443837 Roll src/third_party/skia/ cb8b5d110..27c66e28e (22 commits; 2 trivial rolls) (flutter/engine#5219)
Auto-roller completed checks. Merging.
2018-05-09 22:25:56 -04:00
Chinmay Garde
105fc9bf7b Revert "Roll skia cb8b5d110..e0dc9432d (15 commits)" (flutter/engine#5217) 2018-05-09 15:39:23 -07:00
Ryan Macnak
4f023940cd [fuchsia] Add dependencies needed to build the test shell. (flutter/engine#5216) 2018-05-09 13:43:27 -07:00
skia-flutter-autoroll
7516bcd072 Roll src/third_party/skia/ cb8b5d110..e0dc9432d (15 commits) (flutter/engine#5215)
Auto-roller completed checks. Merging.
2018-05-09 16:22:18 -04:00
Jason Simmons
540616b4da libtxt: in GetRectsForRange, add placeholders only for newline characters (flutter/engine#5157)
If the range passed to GetRectsForRange includes a newline character, then
the framework expects to see a rectangle representing the newline so it knows
where to position the cursor at the end of the line.

If the range covers other non-printing characters but not the newline, then
GetRectsForRange should not produce a rectangle for the line.
2018-05-09 11:42:44 -07:00
Jason Simmons
a45e210692 Provide an SkPaint that describes the background of a text style (flutter/engine#5153)
Fixes https://github.com/flutter/flutter/issues/11961
2018-05-09 11:36:52 -07:00
skia-flutter-autoroll
73d1dcd8b1 Roll src/third_party/skia/ 1c2bcd8b1..cb8b5d110 (12 commits; 1 trivial rolls) (flutter/engine#5214)
Auto-roller completed checks. Merging.
2018-05-09 14:16:56 -04:00
skia-flutter-autoroll
3e86def1cf Roll src/third_party/skia/ a2595f925..1c2bcd8b1 (1 commit) (flutter/engine#5213)
Auto-roller completed checks. Merging.
2018-05-09 10:57:56 -04:00
skia-flutter-autoroll
022d48fc35 Roll src/third_party/skia/ 499a9b210..a2595f925 (1 commit) (flutter/engine#5212)
Auto-roller completed checks. Merging.
2018-05-09 02:11:52 -04:00
skia-flutter-autoroll
8bf8ef741b Roll src/third_party/skia/ 8a8a14495..499a9b210 (3 commits; 1 trivial rolls) (flutter/engine#5211)
Auto-roller completed checks. Merging.
2018-05-08 22:39:31 -04:00
skia-flutter-autoroll
2e23abcc4d Roll src/third_party/skia/ efb84e673..8a8a14495 (3 commits) (flutter/engine#5208)
Auto-roller completed checks. Merging.
2018-05-08 19:11:52 -04:00
Todd Volkert
7feaee6a77 Restore Skia revision (flutter/engine#5206) 2018-05-08 13:02:06 -07:00
Todd Volkert
ac0f878146 Roll Skia back to d8a189fca3cdfa064de75a280d5af34cc5026bbe (flutter/engine#5204)
Attempt #2 at isolating regressions
2018-05-08 12:49:51 -07:00
skia-flutter-autoroll
34388dab01 Roll src/third_party/skia/ d925f2d38..efb84e673 (4 commits) (flutter/engine#5205)
Auto-roller completed checks. Merging.
2018-05-08 15:42:31 -04:00
Chinmay Garde
47d04deb99 Read/apply settings that apply process wide before creating any shell components. (flutter/engine#5203) 2018-05-08 11:56:31 -07:00
skia-flutter-autoroll
5c02bf571f Roll src/third_party/skia/ e7df0bb90..d925f2d38 (4 commits) (flutter/engine#5202)
Auto-roller completed checks. Merging.
2018-05-08 12:10:31 -04:00
Todd Volkert
024d5455e6 Roll Skia to e7df0bb900ec266021bc6bf4477d533ce1b1f749 (flutter/engine#5200) 2018-05-08 08:28:55 -07:00