Michael Goderbauer
8e0993eda8
Auto-format Dart code in engine ( #160576 )
...
This auto-formats all *.dart files in the `engine` subdirectory and
enforces that these files stay formatted with a presubmit check.
2024-12-19 17:13:07 +00:00
Matan Lurey
ba01bab4b8
Change CRLF line endings to LF to match the .gitattributes expectations. ( #160557 )
...
Closes https://github.com/flutter/flutter/issues/160529 .
2024-12-19 15:03:06 +00:00
Yegor
b79ee9282c
[tech debt] remove web engine windows build ( #160573 )
...
It takes 30 minutes while all other bots are done in 10-20 minutes. The
old Windows build used to test in IE11 and old Edge. Since we stopped
testing on those we switched to Chromium, but that doesn't provide any
extra signal in addition to what we get from Linux Chromium already.
2024-12-19 06:56:38 +00:00
John McDole
0fcb6aa5bb
Upstream and Origin check ( #160574 )
...
Several use cases for `origin` as default:
* Some github actions checkout the tree
* Some users download from flutter.dev and then use `master`
Fixes #160558
2024-12-19 05:31:21 +00:00
John McDole
d14259a25d
Commit engine.realm as empty ( #160541 )
...
- only set it when the environment FLUTTER_REALM is present
2024-12-19 02:48:45 +00:00
John McDole
f0bf495594
Trigger Build Part Deux ( #160481 )
...
Hello, Monorepo Part Deux - after adding commit to datastore.
2024-12-18 20:18:06 +00:00
John McDole
1398dc7eec
Trigger Build ( #160476 )
...
Hello Monorepo.
2024-12-17 14:30:30 -08:00
John McDole
721b47e7e6
Merge flutter/engine into framework
...
Adds files from flutter/flaux which contain modifications for the engine
structure. The history for engine/ has been edited. Please see
flutter/engine for the original PRs.
2024-12-17 14:00:52 -08:00
Yegor
4fcf6333d2
[monorepo] remove realm checker ( #160457 )
...
This needs to work entirely differently in the monorepo world.
2024-12-17 19:26:41 +00:00
skia-flutter-autoroll
2a17b75443
Roll Dart SDK from a74650e32880 to 37bbc285d8d2 (1 revision) ( flutter/engine#57244 )
...
https://dart.googlesource.com/sdk.git/+log/a74650e32880..37bbc285d8d2
2024-12-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-260.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-17 18:32:05 +00:00
Hannes Winkler
7f8da94c21
embedder: fix bit-order in software pixel format description ( flutter/engine#57156 )
...
The order of the components for packed software pixel formats is incorrectly documented as being the order in the native type, least-significant-bit first. In reality it's the other way around. For example, for `RGB565`, the `R` is the 5 most significant bits in the 2-byte pixel value, rather than the least significant bits. The test even verify it is that way:
https://github.com/flutter/engine/blob/main/shell/platform/embedder/tests/embedder_unittests.cc#L2782-L2785
I assume noone used the software pixel formats until @sodiboo did, that's why it's gone unnoticed for so long.
Also contains some other minor documentation improvements.
- Issue: https://github.com/flutter/flutter/issues/160149
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-12-17 18:09:06 +00:00
engine-flutter-autoroll
10514a0322
Roll Flutter Engine from 8535ce3c9e5e to 6a75cb6a6a57 (1 revision) ( #160450 )
...
8535ce3c9e...6a75cb6a6amdebbar@google.com [web] Reland: (Add `crossOrigin` property
to `<img>` tag used for decoding)++ (flutter/engine#57228 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-17 18:03:55 +00:00
Yegor
fe7d6f3917
[monorepo] remove Linux Web Framework tests ( flutter/engine#57234 )
...
The motivation is described in https://github.com/flutter/flutter/issues/160405 . This is just one step towards cleaning everything up. More PRs to follow.
2024-12-17 17:53:16 +00:00
skia-flutter-autoroll
7db982f38d
Roll Skia from dca47129cf2e to f784f78a5669 (3 revisions) ( flutter/engine#57242 )
...
https://skia.googlesource.com/skia.git/+log/dca47129cf2e..f784f78a5669
2024-12-17 fmalita@google.com [svg writer] Add support for radial and 2pt conical gradients
2024-12-17 fmalita@google.com [svg writer] Clean up addShaderResources
2024-12-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 8d4040d12fd2 to dbec774c7f68 (6 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC egdaniel@google.com ,jacksongardner@google.com,kjlubick@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-17 17:24:01 +00:00
engine-flutter-autoroll
047cbb01f4
Roll Flutter Engine from cda6630c8e53 to 8535ce3c9e5e (1 revision) ( #160447 )
...
cda6630c8e...8535ce3c9eskia-flutter-autoroll@skia.org Roll Skia from 804042d75299 to
dca47129cf2e (1 revision) (flutter/engine#57241 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-17 17:12:09 +00:00
engine-flutter-autoroll
9ac9783985
Roll Flutter Engine from 5a7ccbc4f6fa to cda6630c8e53 (4 revisions) ( #160438 )
...
5a7ccbc4f6...cda6630c8eskia-flutter-autoroll@skia.org Roll Dart SDK from
58fb2704f28a to a74650e32880 (1 revision) (flutter/engine#57240 )
2024-12-17 skia-flutter-autoroll@skia.org Roll Dart SDK from
930f66fab234 to 58fb2704f28a (1 revision) (flutter/engine#57239 )
2024-12-17 skia-flutter-autoroll@skia.org Roll Skia from 2422a3fc829a to
804042d75299 (1 revision) (flutter/engine#57238 )
2024-12-17 skia-flutter-autoroll@skia.org Roll Skia from fbc41b0b55a1 to
2422a3fc829a (1 revision) (flutter/engine#57236 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-17 15:45:38 +00:00
Mouad Debbar
d2a5b9dcb1
[web] Reland: (Add crossOrigin property to <img> tag used for decoding)++ ( flutter/engine#57228 )
...
Relands https://github.com/flutter/engine/pull/54961 with a few more changes and tests.
Fixes https://github.com/flutter/flutter/issues/160127
2024-12-17 15:35:17 +00:00
skia-flutter-autoroll
37a7c44c11
Roll Skia from 804042d75299 to dca47129cf2e (1 revision) ( flutter/engine#57241 )
...
https://skia.googlesource.com/skia.git/+log/804042d75299..dca47129cf2e
2024-12-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 00d9ef8f182c to c0ee7b203bad (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC egdaniel@google.com ,jacksongardner@google.com,kjlubick@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-17 15:31:22 +00:00
skia-flutter-autoroll
9acfa539f8
Roll Dart SDK from 58fb2704f28a to a74650e32880 (1 revision) ( flutter/engine#57240 )
...
https://dart.googlesource.com/sdk.git/+log/58fb2704f28a..a74650e32880
2024-12-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-259.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-17 13:59:35 +00:00
Tess Strickland
ddc0866e8f
Add more entry-point annotations for test-only code. ( #160421 )
...
This change adds entry-point annotations to methods and classes accessed
by native code during Flutter tests. Currently, entry point annotations
are not checked by the Dart VM when running in JIT mode, only in AOT
mode. In order to also enforce entry point annotations in JIT mode,
first tests in Flutter must be appropriately annotated to avoid roll
failures.
Related issues:
* https://github.com/flutter/flutter/issues/118608
* https://github.com/dart-lang/sdk/issues/50649
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-12-17 11:40:14 +00:00
skia-flutter-autoroll
891e5c6f20
Roll Dart SDK from 930f66fab234 to 58fb2704f28a (1 revision) ( flutter/engine#57239 )
...
https://dart.googlesource.com/sdk.git/+log/930f66fab234..58fb2704f28a
2024-12-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-258.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-17 09:43:24 +00:00
skia-flutter-autoroll
d0293d328c
Roll Skia from 2422a3fc829a to 804042d75299 (1 revision) ( flutter/engine#57238 )
...
https://skia.googlesource.com/skia.git/+log/2422a3fc829a..804042d75299
2024-12-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 43322002e471 to 47e0bdae10c9 (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC egdaniel@google.com ,jonahwilliams@google.com,kjlubick@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-17 07:29:17 +00:00
engine-flutter-autoroll
8631412f25
Roll Flutter Engine from 23731d6a967d to 5a7ccbc4f6fa (1 revision) ( #160408 )
...
23731d6a96...5a7ccbc4f6skia-flutter-autoroll@skia.org Roll Dart SDK from
7ed58b3c462a to 930f66fab234 (1 revision) (flutter/engine#57235 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-17 06:54:21 +00:00
skia-flutter-autoroll
d559ba43db
Roll Skia from fbc41b0b55a1 to 2422a3fc829a (1 revision) ( flutter/engine#57236 )
...
https://skia.googlesource.com/skia.git/+log/fbc41b0b55a1..2422a3fc829a
2024-12-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from ad54e957a812 to 9fbc613d8170 (6 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC egdaniel@google.com ,jonahwilliams@google.com,kjlubick@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-17 06:04:28 +00:00
skia-flutter-autoroll
9bdbf77fc4
Roll Dart SDK from 7ed58b3c462a to 930f66fab234 (1 revision) ( flutter/engine#57235 )
...
https://dart.googlesource.com/sdk.git/+log/7ed58b3c462a..930f66fab234
2024-12-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-257.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-17 05:24:23 +00:00
Matan Lurey
27ef1967b0
Rename and define FlutterManifest.generateLocalizations. ( #160401 )
...
Part of https://github.com/flutter/flutter/issues/102983 .
`<FlutterManifest>.generateSyntheticPackage` _never_ meant generate a
synthetic package 😒 , it only meant "we _might_ need to generate a
synthetic package because localizations are being generated and the
default, unless otherwise specified, is to generate a synthetic
package".
Renamed as `generateLocalizations` and added some strategic TODOs in
places where removing the `package:flutter_gen` feature
(https://github.com/flutter/flutter/issues/102983 ) will allow us to
cleanup this erroneous code and technical debt.
Simplified a bit code (just a refactor) in the process, and fixes a bug
that `flutter packages get` would generate internationalization files
even if `flutter: generate: true` was not present in `pubspec.yaml` that
was revealed as part of fixing this up.
/cc @sigurdm.
2024-12-17 04:29:14 +00:00
Matan Lurey
eb926ea840
Consistently set Cache.flutterRoot in create_test.dart. ( #160403 )
...
Without this change, the order that tests run matter and it's easy to
add tests without remembering this flag.
(There are existing tests that forgot it too, they just happen to work
if shuffled in a way that, well, works)
2024-12-17 03:15:07 +00:00
Matan Lurey
cb8c15c4f3
Replace --no-implicit-pubspec-resolution with flutter config --explicit-package-dependencies. ( #160400 )
...
This was a mistake, and should have already been removed and cleaned up.
Part of https://github.com/flutter/flutter/issues/160257 .
2024-12-17 03:11:07 +00:00
engine-flutter-autoroll
fb67b0c56b
Roll Flutter Engine from 90c9185be6a5 to 23731d6a967d (2 revisions) ( #160404 )
...
90c9185be6...23731d6a96skia-flutter-autoroll@skia.org Roll Skia from 2c5159518cf2 to
fbc41b0b55a1 (1 revision) (flutter/engine#57231 )
2024-12-17 skia-flutter-autoroll@skia.org Roll Dart SDK from
4bfbad776c1a to 7ed58b3c462a (1 revision) (flutter/engine#57230 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-17 03:07:34 +00:00
engine-flutter-autoroll
0c7f02085e
Roll Flutter Engine from 1d2eb3f6ac5f to 90c9185be6a5 (1 revision) ( #160399 )
...
1d2eb3f6ac...90c9185be6goderbauer@google.com Pre-format licenses script
(flutter/engine#57219 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-17 02:11:26 +00:00
engine-flutter-autoroll
256a127da3
Roll Flutter Engine from 4944aebc5015 to 1d2eb3f6ac5f (2 revisions) ( #160396 )
...
4944aebc50...1d2eb3f6acgoderbauer@google.com Properly report `dart format` errors
(flutter/engine#57206 )
2024-12-16 skia-flutter-autoroll@skia.org Roll Skia from 7fc6934b2034 to
2c5159518cf2 (1 revision) (flutter/engine#57229 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-17 01:17:07 +00:00
skia-flutter-autoroll
b195862d14
Roll Skia from 2c5159518cf2 to fbc41b0b55a1 (1 revision) ( flutter/engine#57231 )
...
https://skia.googlesource.com/skia.git/+log/2c5159518cf2..fbc41b0b55a1
2024-12-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 296cdf58b6ec to 8d4040d12fd2 (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC egdaniel@google.com ,jonahwilliams@google.com,kjlubick@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-17 01:15:19 +00:00
skia-flutter-autoroll
ea85c9e222
Roll Dart SDK from 4bfbad776c1a to 7ed58b3c462a (1 revision) ( flutter/engine#57230 )
...
https://dart.googlesource.com/sdk.git/+log/4bfbad776c1a..7ed58b3c462a
2024-12-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-256.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-17 01:15:16 +00:00
Michael Goderbauer
9802c1cde7
Normalize localizations with dartfmt in presubmit check ( #160395 )
...
Makes the presubmit check independent of whether the files in the repo
are dartfmt formatted or not.
2024-12-17 01:07:17 +00:00
Michael Goderbauer
79506323b9
Adjust tools tests that would be broken by formatting ( #160393 )
...
These tests depend on line numbers that `dart format` is changing.
Pre-format the files in question and adjust the tests so they continue
to pass when the entire repo is formatted.
2024-12-17 00:34:00 +00:00
Michael Goderbauer
e19e117c37
Fix line-dependent tests for formatting ( #160389 )
...
These tests are dependent on line numbers. This formats them and updates
the line number to take them off the critical path.
2024-12-17 00:29:51 +00:00
Michael Goderbauer
d00bfbb87a
Pre-format licenses script ( flutter/engine#57219 )
...
The license script has load-baring formatting: Changing its format makes signature checks fail. To ensure the formatting change goes in smoothly later this week I am taking it off the critical path by pre-formatting it.
The script itself is fairly stable, so I am not expecting any changes to it between now and when we actually enforce formatting.
Edit: The issue that surfaced with `ci/licenses_golden/licenses_dart` is another reason to take this off the critical path of enforcing formatting.
2024-12-17 00:19:17 +00:00
engine-flutter-autoroll
43ee8029c9
Roll Flutter Engine from eac3180b2366 to 4944aebc5015 (1 revision) ( #160392 )
...
eac3180b23...4944aebc50skia-flutter-autoroll@skia.org Roll Skia from 8054b098b5cd to
7fc6934b2034 (14 revisions) (flutter/engine#57227 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-17 00:14:14 +00:00
Michael Goderbauer
93d08f2c1a
Properly report dart format errors ( flutter/engine#57206 )
...
`dart format` can fail (e.g. if a file contains invalid dart code). Previously, those failures were swallowed. This change adds logic to properly print those failures to the terminal.
2024-12-16 23:36:47 +00:00
Michael Goderbauer
06dd9a3525
Properly report dart format errors ( #160364 )
...
This applied the improvements from
https://github.com/flutter/engine/pull/57206 to the flutter/flutter
version of that script (hopefully, we can deduplicate this soon with the
repo merge).
2024-12-16 23:35:01 +00:00
skia-flutter-autoroll
220114f83f
Roll Skia from 7fc6934b2034 to 2c5159518cf2 (1 revision) ( flutter/engine#57229 )
...
https://skia.googlesource.com/skia.git/+log/7fc6934b2034..2c5159518cf2
2024-12-16 fmalita@google.com [viewer] Add support for animated GIF, WEBP
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC egdaniel@google.com ,jonahwilliams@google.com,kjlubick@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-16 23:17:09 +00:00
engine-flutter-autoroll
4a6ae1ebab
Roll Flutter Engine from 61616ace5fa8 to eac3180b2366 (3 revisions) ( #160386 )
...
61616ace5f...eac3180b23skia-flutter-autoroll@skia.org Manual roll Dart SDK from
02aa27c6a075 to 4bfbad776c1a (12 revisions) (flutter/engine#57226 )
2024-12-16 skia-flutter-autoroll@skia.org Roll Dart SDK from
02aa27c6a075 to 4bfbad776c1a (12 revisions) (flutter/engine#57224 )
2024-12-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
iYz_WkWk1uPr8BLSZ... to zvsXvTuk-Z1Mgtn34... (flutter/engine#57222 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from iYz_WkWk1uPr to zvsXvTuk-Z1M
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-16 23:15:23 +00:00
Matan Lurey
81f628f340
Migrate mac_test.dart to explicit-package-dependencies. ( #160375 )
...
Fixes forward <https://github.com/flutter/flutter/issues/160257 > that
will happen when this flag is enabled
([example](https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8728366579836767153/+/u/run_test.dart_for_tool_tests_shard_and_subshard_general/stdout )).
2024-12-16 22:59:17 +00:00
Matan Lurey
f177d8aab4
Migrate test/commands.shard (mostly) to explicit-package-dependencies. ( #160288 )
...
Towards https://github.com/flutter/flutter/issues/160257 .
I intentionally skipped `create_test.dart`, as that requires updating
the generated template which uses l10n, a feature changing. I'll do that
in the "big bang" PR that finally enables the feature to avoid getting
us into a bad state.
2024-12-16 22:59:16 +00:00
Kevin Chisholm
abe3f4014f
Merges changes from stable changelog to master. ( #160284 )
...
Merges changes to master to match stable.
2024-12-16 22:49:11 +00:00
Matan Lurey
256ad9f9cb
Move integration_test dependencies to non-dev_dependencies. ( #160380 )
...
First part of https://github.com/flutter/flutter/issues/160379 .
This should be a NOP, because without the
`explicit-package-dependencies` feature flag, all dependencies
(including dev_dependencies) are considered, for the purposes of
plugins, non-dev dependencies.
This change prepares for flipping that flag, so when the flip occurs, it
is _also_ a NOP for these tests.
2024-12-16 22:42:01 +00:00
engine-flutter-autoroll
71f140ee16
Roll Flutter Engine from 0dfbd04106ed to 61616ace5fa8 (3 revisions) ( #160385 )
...
0dfbd04106...61616ace5frobert.ancell@canonical.com Migrate FlBinaryMessenger using
embedder API instead of mock engine. (flutter/engine#57214 )
2024-12-16 brett.morgan@gmail.com Flutter-GPU.md: Fix spelling
(flutter/engine#57216 )
2024-12-16 mdebbar@google.com [web] Don't close image source too early
(flutter/engine#57200 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-16 22:16:05 +00:00
Matan Lurey
18f56e3224
Refactor TestGoldenComparator to be useful for non-web (Android, iOS) integration tests ( #160215 )
...
Part of https://github.com/flutter/flutter/issues/160043 , makes it
easier to add https://github.com/flutter/flutter/pull/160131 .
This PR has no functional changes to any of the code, but does refactor
both the code and tests:
- Makes a number of always non-null but not migrated to non-null
properties, well, not-null
- Creates two concrete methods (`update` and `compare` versus a
positional nullable boolean)
- Uses type signatures instead of `String?` to explain the possible
results of the methods
- Renames the mysterious `shellPath` variable to `flutterTesterBinPath`
- Expands and rewrites internally-facing doc comments
- Moves `WebRenderer` environment variable setting to
`flutter_web_platform.dart`
- Makes the tests have less duplication, and check for update/compare
cases
After this PR, I can use it in the non-web branch of the Flutter tool
without any hacks or TODOS :)
/cc @eyebrowsoffire (trivial web refactoring), @camsim99 (changes being
made to tool).
2024-12-16 22:08:54 +00:00
Michael Goderbauer
8fee7cb832
Adjust ignores for 'dart format' ( #160382 )
...
When running `dart format` over these lines the `// ignore` ended up on
a line where it wasn't properly ignoring the lint. This adjusts the
placement of `// ignore`s so they will continue to ignore the right
thing even after the code is auto formatted.
I am hoping that if we do this now the large PR that formats the entire
repo will go in smoother without manual intervention.
2024-12-16 22:01:25 +00:00
Ben Konyi
6159f2eef6
Manual pub roll with flutter_tools patch ( #160174 )
...
Fixes: https://github.com/flutter/flutter/issues/160055
2024-12-16 21:41:54 +00:00
