8936 Commits

Author SHA1 Message Date
Florian Loitsch
8d5fe6d430 Don't use runBinaryGuarded. (#11816)
Since the called function can't throw, there is no need for the "guarded".
Since the function returns something, running in guarded mode doesn't really work. The `uncaught` handler wouldn't know what to return (except for `null`).
2017-08-29 19:54:00 +02:00
Mehmet Fidanboylu
a7d2f8359f Notify the completer after the close animation completes on the snackbar (#11688)
* Notify the completer after the close animation completes on the snackbar

* Review comments

* Fix tests and analyzer warnings

* Fix analyzer warnings
2017-08-29 09:39:54 -07:00
Ian Hickson
6aae676441 Avoid returning null from debugDescribeChildren (#11806)
In some cases, the element tree is not clean but we are required to dump the tree anyway.
To avoid crashing in those cases, we return an explicit null node.
2017-08-29 09:14:12 -07:00
Sarah Zakarias
f1a23e263c roll engine (#11814) 2017-08-29 14:58:31 +02:00
Michael Goderbauer
5c5e4265a1 Fix command test (#11812) 2017-08-28 23:58:56 -07:00
Michael Goderbauer
76a1ab0269 Roll engine to 60bce44c9fdf20dbe5e6f7dd02e776b9ab0dd585 (#11805) 2017-08-28 17:34:33 -07:00
Michael Goderbauer
2a01097a23 Fix crash in debugDumpSemanticsTree when transform == null (#11807) 2017-08-28 17:16:42 -07:00
Michael Goderbauer
8ecf19d8a0 Semantic hit test order for Slivers (#11792)
* Semantic hit test order for Slivers

* ++

* fix double space

* refactoring

* fix test

* comment fix

* tests

* remove accidental debugDumpSemanticsTree

* review comments

* fix button
2017-08-28 15:49:16 -07:00
Chris Bracken
10e65a16f8 Minor whitespace formatting fix in build tests (#11802) 2017-08-28 15:46:45 -07:00
Ian Hickson
f235a2c104 RTL: Padding, Flex (#11709)
* Introduce a Directionality inherited widget which sets the ambient LTR vs RTL mode (defaulting to null, which means you cannot use directionality-influenced values).

* Make it possible to configure Padding (including Container.padding and Container.margin) using a directionality-agnostic EdgeInsets variant.

* Provide textDirection and verticalDirection controls on Row and Column to make them RTL-aware.

* Introduce a variant of FractionalOffset based on the EdgeInsets variant. Not yet actually used.

* Fix all the tests that depended on Row defaulting to LTR.
2017-08-28 12:50:24 -07:00
Ian Hickson
3dd1a05a8a Better debugPaintSize logic for clip renderers (#11725) 2017-08-28 12:33:23 -07:00
Chris Bracken
1ee9400130 Avoid rebuilding snapshots if no change to source (#11551) (#11793)
This change re-introduces skipping AOT snapshot builds if input sources
and outputs have not changed since the last snapshot build, assuming a
build for the same platform in the same build mode.

This reverts commit 3d5afb5a81052b7d55661549320d6d43f893f448.
It includes the following changes relative to the original:
  1. Include the entrypoint source in the checksums
  2. include the build mode in the checksums
  3. include the target platform in the checksums
2017-08-28 11:45:17 -07:00
Michael Goderbauer
f265301519 Doc updates for Semantics; always reset SemanticsNode (#11770)
* refactor to ensureAction + some related doc fixes

* Update docs for markNeedsSemanticsUpdate

* rewording

* rewording

* ensureAction test

* ensureAction test

* ensureAction test

* more tests

* refactor to allways reset node

* tiny fixes

* more test

* doc fixes

* one more test

* review comments
2017-08-25 17:21:46 -07:00
Chris Bracken
6f654c1168 Update flutter_tools IntelliJ project (#11790)
Adds excludes for new test added in
13dda7cf80642e170dd842771b274b756cdc4c8b (#11557)
2017-08-25 15:59:19 -07:00
Carlo Bernaschina
f3245d00b0 Roll Engine to f5371156d29b8cca3df05452f7e09f1314b1d9a1 (#11786) 2017-08-25 14:57:03 -07:00
Chris Bracken
fd54bd4caf Add version, build mode to the snapshot checksums (#11787)
This change ensures that snapshot build checksums used to avoid
duplicate builds are invalidated by a change to framework revision
(in case gen_snapshot is updated), as well as by build mode.

Currently, only FLX snapshotting uses checksums to avoid duplicate
builds. FLX snapshotting is always done with BuildMode.debug, so didn't
include build mode in the checksum file.
2017-08-25 14:32:01 -07:00
Jason Simmons
e960ba0b88 Remove unused Roboto fonts from the material font manifest (#11778) 2017-08-25 11:29:26 -07:00
Michael Goderbauer
c1bd6f87ae Fix paintBounds/semanticBounds of RenderSliver (#11781)
* Fix paintBounds/semanticsBounds of RenderSliver

* another test
2017-08-25 09:41:57 -07:00
Zachary Anderson
631eaa4563 Fix Fuchsia Hot Reload (#11783) 2017-08-25 09:16:24 -07:00
xster
ca80cdfc59 Accept down event in mono drag gesture velocity calculation (#11777) 2017-08-24 16:35:16 -07:00
xster
538a33ee3b update plugin underscore (#11779) 2017-08-24 15:20:19 -07:00
Michael Goderbauer
c9cefbf0be Properly update semantics when Material/Cupertino Sliders are disabled (#11776)
* Properly update semantics when Material/Cupertino Slider are disabled

* whitespace fix

* fix style
2017-08-24 12:54:34 -07:00
Mikkel Nygaard Ravn
0de87bab4a Test bugfix: specify JAVA_HOME env (#11773) 2017-08-24 12:48:41 +02:00
Mikkel Nygaard Ravn
79747f4947 Improve Gradle error output in Flutter commands (#11703) 2017-08-24 10:44:32 +02:00
Hans Muller
8c2c502257 Updated I18N API for Flutter (#11497) 2017-08-23 17:07:59 -07:00
xster
7676e5119e Engine roll (#11765) 2017-08-23 14:43:40 -07:00
Michael Thomsen
41378e2032 Break long line in flutter create help output (#11756) 2017-08-23 13:13:26 -07:00
Ian Hickson
ce035d09c6 Fix non-flexible Chip in a Row. (#11669) 2017-08-23 12:59:01 -07:00
Brenton Simpson
58163e0c39 Rename springConstant to stiffness (#11686)
`stiffness` is the name of a spring's `k` input on [iOS](https://developer.apple.com/documentation/quartzcore/caspringanimation), [Android](https://developer.android.com/topic/libraries/support-library/preview/spring-animation.html), and the [Web](bbc0f831e2/src/index.js (L11-L22)).  To ensure the API is familiar to and easily understood by developers coming from other platforms, Flutter should follow this convention as well.

This is a minimally-breaking change.  Across [all of GitHub](https://github.com/search?l=Dart&q=springConstant&type=Code&utf8=%E2%9C%93), there are only 2 uses of the `springConstant` API (in Mondrian).  Those can be easily changed to use this name.

Closes #11684
2017-08-23 12:58:33 -07:00
Michael Goderbauer
f969b777b5 a11y and scrolling with slivers (#11711)
* refactor to assembleSemanticNode

* ++

* cleanup

* fix test

* add note

* review comments

* review feedback

* import fix

* another import fix

* refactor to ensure tag

* tests, tests, tests

* analyzer fixes

* review comments
2017-08-23 12:36:32 -07:00
Chris Bracken
b4f6e56720 Include main entrypoint in FLX snapshot checksum (#11762)
During FLX snapshotting, changes to (or absence of) any of the following
should trigger re-snapshot:

  1. main() entrypoint source
  2. transitive closure of sources reachable from the entrypoint source
  3. the output snapshot
2017-08-23 12:10:52 -07:00
Jason Simmons
bb2554abcd Fix the continue-at flag in the curl command used to download the Dart SDK (#11757)
Fixes https://github.com/flutter/flutter/issues/11722
2017-08-23 11:28:19 -07:00
Chris Bracken
dc5d2937bb Suppress libmobilegestalt noise from iOS device logging (#11745)
This patch supports basic filtering of log lines from physical iOS
devices, similar to existing functionality for iOS simulator logging.

This patch also suppresses the following two log messages which are
emitted at app startup on iOS 10.3 devices:
  libMobileGestalt MobileGestaltSupport.m:153: pid 123 (Runner) does not have sandbox access for frZQaeyWLUvLjeuEK43hmg and IS NOT appropriately entitled
  libMobileGestalt MobileGestalt.c:550: no access to InverseDeviceID (see <rdar://problem/11744455>)
2017-08-23 10:50:07 -07:00
Ian Hickson
02bdb97b43 Update manual_tests to run on Android again (#11743) 2017-08-23 10:34:37 -07:00
Ian Hickson
bf47b34b60 Directionality widget (#11739) 2017-08-23 10:34:20 -07:00
Ian Hickson
9d4dd10f63 Remove a bunch of useless global configuration options. (#11726)
These properties had a high cost in the documentation because they're
all top-level properties, and there's really very little reason for
these values to be configurable in the first place.
2017-08-23 10:33:41 -07:00
Chris Bracken
1962b61b67 Roll engine to 0062701c7c10029e86394e2599047ae993f7f492 (#11746) 2017-08-23 09:31:37 -07:00
Jakob Andersen
5d0d6126a1 Add --template=<type> option to create command. (#11105)
Allows the user to specify the kind of project to create. The default is 'app'. Other choices are 'plugin' (the old '--plugin' behavior), and 'package'.

A Flutter 'package' is a Dart package that depends on Flutter, but does not contain native code.

Fixes #10377.
2017-08-23 13:29:31 +02:00
Mikkel Nygaard Ravn
32ab3dbee0 Support Xcode projects with no schemes (#11750) 2017-08-23 11:58:21 +02:00
Mikkel Nygaard Ravn
9496e6dfa7 Support for app flavors in flutter tooling, #11676 retake (#11734) 2017-08-23 10:55:35 +02:00
Jason Simmons
e843cb342d roll engine (#11740) 2017-08-22 17:11:34 -07:00
Jacob Richman
5066750063 Add comments to 3 methods that were missing comments. (#11737)
* Add comments to 3 methods that were missing comments.

Fix out of order (getter, private field, setter) tuple

* Code review fix.
2017-08-22 16:06:22 -07:00
Carlo Bernaschina
a8aff38811 Add log to understand flakiness of commands_test (#11720)
The flakiness of commands_test is generally visible via:

```
drive:stdout:   Expected: 'log: paint'
drive:stdout:     Actual: ''
drive:stdout:      Which: is different. Both strings start the same, but the actual value is missing the following trailing characters: log: paint ...
```

By returning the name of the test we will be able to understand if
another test is running by reading the `Actual` value
2017-08-22 09:54:51 -07:00
Mikkel Nygaard Ravn
7c3a45dc6e Revert "Support for app flavors in flutter tooling (#11676)" (#11729)
This reverts commit 8d07d3f652d687dfd80038371406fbe2942253a6.
2017-08-22 12:24:29 +02:00
Mikkel Nygaard Ravn
8d07d3f652 Support for app flavors in flutter tooling (#11676) 2017-08-22 10:38:23 +02:00
Devon Carew
f25e2f5213 Revert "fire service protocol events for frames (#11565)" (#11727)
This reverts commit 5f9acc4125ef74954493eb56feabd50be2817f68.
2017-08-22 01:06:48 -07:00
Devon Carew
4d0debd4c7 fix some call sites of printError (#11724)
* fix some call sites of printError

* review comments
2017-08-21 23:38:16 -07:00
Devon Carew
5f9acc4125 fire service protocol events for frames (#11565) 2017-08-21 22:12:19 -07:00
Jacob Richman
5462ddb917 Bare bones widget inspector support. (#10332)
Bare bones widget inspector support.

Toggle the widget inspector from the flutter tool by pressing 'i'.
When the widget inspector is select mode:
Pointer down to to inspect a widget.
Pointer click to finalize selection of a widget. You can now interact
with the application as you normally would but with the inspected widget
highlighted.
Click the inspect icon in bottom left corner of screen to reactivate
select mode.
2017-08-21 16:17:54 -07:00
Chris Bracken
9c04aa15b3 Fix a FormState documentation typo (#11712) 2017-08-21 15:54:02 -07:00