DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
30,593 Commits 882 Branches 1,069 Tags
Commit Graph

23316 Commits

Author SHA1 Message Date
Gray Mackall
8cce730f9b Fix name in description of 'create_cipd_packages.sh' (flutter/engine#44513) 
The description uses an old name.

This PR also partly exists to spread awareness that this script exists, for whenever we need to upload [android versions to CIPD](https://chrome-infra-packages.appspot.com/p/flutter/android/sdk/all/mac-arm64/+/).

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-08 21:49:48 +00:00
gaaclarke
025925411e [Impeller] started std::moving Commands instead of copying (flutter/engine#44508) 
Each Command is 440 B so copying them when adding them to the RenderPass adds up.  This change represents a 36% speedup in `TextContents::Render` when scrolling around on the main screen of the of the Flutter Gallery.

issue: https://github.com/flutter/flutter/issues/131787

## before
<img width="1217" alt="Screenshot 2023-08-08 at 1 11 30 PM" src="https://github.com/flutter/engine/assets/30870216/3545f9cd-b596-4a7c-bcf0-a20c7f7c40e8">

## after

<img width="1048" alt="Screenshot 2023-08-08 at 1 10 05 PM" src="https://github.com/flutter/engine/assets/30870216/3443ec70-5d4f-4022-b3e7-41b13c25cb00">

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-08 21:27:49 +00:00
skia-flutter-autoroll
a31c651ebb Roll Skia from 9fa8ebdfdbb8 to 68b80f663be6 (1 revision) (flutter/engine#44511) 
https://skia.googlesource.com/skia.git/+log/9fa8ebdfdbb8..68b80f663be6

2023-08-08 nicolettep@google.com Add some nullchecks to GrTriangulator

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-08 21:21:36 +00:00
LongCatIsLooong
bd6dcc68c9 Disable HTML renderer paragraph input width flooring (flutter/engine#44478) 
Hopefully the flooring will no longer be needed once the framework stops doing the rounding.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-08 21:07:53 +00:00
skia-flutter-autoroll
8be9a371ad Roll Skia from 5c8c7faf9131 to 9fa8ebdfdbb8 (2 revisions) (flutter/engine#44507) 
https://skia.googlesource.com/skia.git/+log/5c8c7faf9131..9fa8ebdfdbb8

2023-08-08 lovisolo@google.com CommandLineFlags::StringArray: Add method parseAndValidate().
2023-08-08 kjlubick@google.com Partial revert of "Remove SK_GL #ifdefs from GrBackendSurface"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-08 20:12:19 +00:00
skia-flutter-autoroll
f3b3e417fe Roll Skia from 6fa6fdd04783 to 5c8c7faf9131 (3 revisions) (flutter/engine#44506) 
https://skia.googlesource.com/skia.git/+log/6fa6fdd04783..5c8c7faf9131

2023-08-08 herb@google.com Bentley-Ottmann EventQueue
2023-08-08 thakis@chromium.org Fix an unreachable code diag
2023-08-08 lovisolo@google.com [bazel] Add serve-bazel-test-undeclared-outputs.sh utility script.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-08 19:24:21 +00:00
Matt2D
d669ddd4f4 Flutter iOS Interactive Keyboard: Handle Pointer Up (flutter/engine#44457) 
This PR address the movement aspect of the flutter interactive keyboard. It handles pointer up while a scroll view widget is visible, and the interactive behavior is chosen for keyboardDismissBehavior. This is a desired behavior of the keyboard that has not yet been implemented.
Design Document:
https://docs.google.com/document/d/1-T7_0mSkXzPaWxveeypIzzzAdyo-EEuP5V84161foL4/edit?pli=1

Issues Address:
https://github.com/flutter/flutter/issues/57609

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-08 19:09:44 +00:00
gaaclarke
77941b98d5 [Impeller] improved glyph hashing performance (flutter/engine#44502) 
This change makes the glyph hash 39% faster (66ms vs 107ms).  The glyph hash function occupies the most CPU time on the raster thread when scrolling around the main screen for the Flutter Gallery

## before

<img width="1101" alt="Screenshot 2023-08-08 at 10 53 06 AM" src="https://github.com/flutter/engine/assets/30870216/2332323e-80cd-4f39-9ec1-95cb5662be7b">

## after
<img width="1097" alt="Screenshot 2023-08-08 at 10 52 51 AM" src="https://github.com/flutter/engine/assets/30870216/13bbc07b-7f56-40e8-ada5-32de77ddf614">

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-08 18:44:21 +00:00
skia-flutter-autoroll
c5159af2df Roll Skia from 30c0319e7e42 to 6fa6fdd04783 (2 revisions) (flutter/engine#44503) 
https://skia.googlesource.com/skia.git/+log/30c0319e7e42..6fa6fdd04783

2023-08-08 kjlubick@google.com Move StrokeForGPUTest to ganesh test list
2023-08-08 bungeman@google.com [skunicode] Add temporary file for transition

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-08 18:38:37 +00:00
Caroline Liu
e493b1011e Remove GFX branches from Flutter engine (flutter/engine#44401) 
This change does the following:
- Refactors `engine.cc`/`.h` and `component_v2.cc`/`.h` to remove GFX ctors and callbacks.
- Removes `gfx_external_view_embedder`, `gfx_platform_view`, `gfx_session_connection`, their tests, and any supporting testing infrastructure (e.g. `fake_session`) from the build. This change does not delete the source files themselves in order to keep the change size smaller (as all these file deletions together are about another ~8K lines worth of deletions.) A separate follow up change will delete these files.

Related bug: fxbug.dev/64206
 2023-08-08 18:20:09 +00:00
Jason Simmons
2ae4942db0 Use the Clang unreachable code warning flag in the engine tree (flutter/engine#44458) 2023-08-08 17:40:03 +00:00
skia-flutter-autoroll
0e5a9ddf5f Roll Skia from 66ba512c613c to 30c0319e7e42 (3 revisions) (flutter/engine#44500) 
https://skia.googlesource.com/skia.git/+log/66ba512c613c..30c0319e7e42

2023-08-08 johnstiles@google.com Remove unused 'virtual' in GLSLCodeGenerator.
2023-08-08 johnstiles@google.com Reject sequence-expressions containing arrays.
2023-08-08 kjlubick@google.com Add Fontations Jobs

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-08 16:57:21 +00:00
Chris Bracken
e43adf1acd [macOS] Fix engine/binaryMessenger retain cycle (flutter/engine#44471) 
Previously, FlutterEngine.binaryMessenger returned the FlutterEngine
instance itself, which meant that channels/plugins could hold a strong
reference to the engine and thus cause a retain cycle, preventing the
engine from being deallocated.

We introduce FlutterBinaryMessengerRelay, which implements the
FlutterBinaryMessenger protocol, by delegating back to the engine, to
which it holds a weak reference, thus avoiding the retain cycle.

This also changes the FlutterBinaryMessengerRelay.parent property from
an assign property to a weak property since that code is compiled with
ARC enabled as of https://github.com/flutter/engine/pull/44395.

This patch also rearranges the headers to comply with our style guide:
related headers for this file, C headers, C++ headers, other Flutter
headers, in that order.

Fixes: https://github.com/flutter/flutter/issues/116445
 2023-08-08 09:26:28 -07:00
skia-flutter-autoroll
875ee57aa1 Roll Skia from f7162d33afb2 to 66ba512c613c (8 revisions) (flutter/engine#44497) 
https://skia.googlesource.com/skia.git/+log/f7162d33afb2..66ba512c613c

2023-08-08 kjlubick@google.com Move SkChromeRemoteGlyphCache.cpp to src/text/gpu
2023-08-08 johnstiles@google.com Revert "Use pointers to avoid static variable destruction."
2023-08-08 kjlubick@google.com Skip deleted test file
2023-08-08 kjlubick@google.com Add missing file to public.bzl
2023-08-08 johnstiles@google.com Disable MatrixScalarMath test on Mac ANGLE.
2023-08-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from c46d48f777b7 to cc5d2913cf83 (3 revisions)
2023-08-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 135a24fc3706 to f7d7be8d2ff0 (13 revisions)
2023-08-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 0e52994bf1b6 to 333a87d1ef8a (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-08 16:13:18 +00:00
Mouad Debbar
2b761a04f7 [web] Expose the benchmark callback through dart:ui_web (flutter/engine#44461) 
Required by https://github.com/flutter/flutter/pull/132087
Part of https://github.com/flutter/flutter/issues/130175
Part of https://github.com/flutter/flutter/issues/126831
 2023-08-08 16:09:14 +00:00
Zachary Anderson
90ee3f407f Excludes entity_pass.cc from clang-tidy due to timeouts (flutter/engine#44495) 
For https://github.com/flutter/flutter/issues/132129
 2023-08-08 15:33:48 +00:00
skia-flutter-autoroll
2bd0199443 Roll Fuchsia Linux SDK from 0Jd9VPJCX145RGnqr... to 9Pl8nd13UI8rrS3JD... (flutter/engine#44494) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-08 15:23:46 +00:00
Jason Simmons
0413e2710d Revert "[Impeller] DlCanvas implementation wrapping Aiks canvas" (flutter/engine#44466) 
This reverts commit 1785eb5cb8cba53da249614158065d1d53f8f863.

See https://github.com/flutter/flutter/issues/132071
 2023-08-07 23:59:47 +00:00
skia-flutter-autoroll
4417cf19fd Roll Skia from 5dd88a48f7e2 to b4a893827b2a (3 revisions) (flutter/engine#44470) 
https://skia.googlesource.com/skia.git/+log/5dd88a48f7e2..b4a893827b2a

2023-08-07 brianosman@google.com Only skip (BitmapProcState) Init_hsw when building for AVX2+
2023-08-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 33af718d939e to c46d48f777b7 (5 revisions)
2023-08-07 johnstiles@google.com Disable CommaExpressionsAllowInlining in WebGL2.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-07 23:18:53 +00:00
Mouad Debbar
dc0147d3d3 [web] Silence pub get when it's successful (flutter/engine#44445) 
In the spirit of keeping the happy path's output as clean as possible, let's hide the many lines printed by `pub get` even when it's successful.

If `pub get` fails, its output will be printed on the terminal.
 2023-08-07 22:38:03 +00:00
skia-flutter-autoroll
b8bb3206ae Roll Skia from d1ada6624536 to 5dd88a48f7e2 (8 revisions) (flutter/engine#44465) 
https://skia.googlesource.com/skia.git/+log/d1ada6624536..5dd88a48f7e2

2023-08-07 brianosman@google.com blit_row_color32 doesn't need to support separate src/dst pointers
2023-08-07 johnstiles@google.com Improve errors with ternary ops.
2023-08-07 lovisolo@google.com [bazel] //gm/gm.h: Add support for dynamically registered GMs.
2023-08-07 johnstiles@google.com Add WGSL polyfill for inverse intrinsic.
2023-08-07 brianosman@google.com Split out BlitMask opts into separate cpp files
2023-08-07 johnstiles@google.com Add WGSL support for matrix-op-scalar math.
2023-08-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from a8be3b12ad17 to be6bd0fc62ef
2023-08-07 drott@chromium.org [Fontations-backend] Build fontations-enabled viewer with GN

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-07 22:32:03 +00:00
Brandon DeRosier
e8e4f8c118 [Impeller] Flutter GPU: Add GpuContext. (flutter/engine#44359) 
Move the GpuContext to its new home. I added a `flutter_tester` test that just verifies an exception is gracefully thrown when Impeller isn't available.

In a later patch, I'll land a way to eagerly supply the Impeller context on the cpp side to enable testing through the playground (as mentioned in https://github.com/flutter/flutter/issues/127712).
 2023-08-07 19:41:57 +00:00
ftsui
0cc053b836 Fix use-after-free crash in glfw embedder (flutter/engine#44358) 
When setting up the paths to assets and ICU data, we were previously returning the underlying char* data in a temporary string returned by `std::filesystem::path::string()`. Since the return value of `string()` is never stored, there's no guarantee that the underlying data pointer is still valid later in the function. By storing the string in a local whose lifetime exceeds that of the running engine instance, we guarantee the string isn't freed until after the Flutter app terminates.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-07 19:11:24 +00:00
Yegor
fc753e1355 [web] remove leftover comments from semantics tester (flutter/engine#44350) 
Remove commented out debug code from `expectSemanticsTree`.
 2023-08-07 18:04:47 +00:00
skia-flutter-autoroll
357faa3756 Roll Skia from 77007f51bf81 to 9fbd7296de9a (4 revisions) (flutter/engine#44443) 
https://skia.googlesource.com/skia.git/+log/77007f51bf81..9fbd7296de9a

2023-08-07 johnstiles@google.com Use pointers to avoid static variable destruction.
2023-08-07 brianosman@google.com Remove SkAutoGraphics
2023-08-07 brianosman@google.com Move Init_BitmapProcState call back to SkGraphics
2023-08-07 johnstiles@google.com Remove unused 'skia_enable_skvm' GN argument.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jcgregorio@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-07 18:01:01 +00:00
skia-flutter-autoroll
1b46cf50e8 Roll Skia from f19578685d17 to 77007f51bf81 (1 revision) (flutter/engine#44440) 
https://skia.googlesource.com/skia.git/+log/f19578685d17..77007f51bf81

2023-08-07 johnstiles@google.com Remove SK_ENABLE_SKSL_IN_RASTER_PIPELINE.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jcgregorio@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-07 17:10:06 +00:00
skia-flutter-autoroll
6b26b6b0c9 Roll Skia from 359808ec2cb1 to f19578685d17 (1 revision) (flutter/engine#44439) 
https://skia.googlesource.com/skia.git/+log/359808ec2cb1..f19578685d17

2023-08-07 brianosman@google.com Remove SkGraphics::AllowJIT completely

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jcgregorio@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-07 16:04:52 +00:00
skia-flutter-autoroll
ebe68a8088 Roll Skia from e327eb094605 to 359808ec2cb1 (2 revisions) (flutter/engine#44438) 
https://skia.googlesource.com/skia.git/+log/e327eb094605..359808ec2cb1

2023-08-07 johnstiles@google.com Remove ES3 flag from new comma-expression test.
2023-08-07 johnstiles@google.com Remove GL backend bit from Layout.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jcgregorio@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-07 15:12:08 +00:00
Jason Simmons
75f91264d1 Do not log exceptions from JNI lookups of APIs that are known to be unavailable on older devices (flutter/engine#44357) 
These exceptions are benign but were being logged every time an app is launched on a device with an Android API level below 26.
 2023-08-07 14:35:05 +00:00
skia-flutter-autoroll
18f22098ec Roll Skia from f4047f002891 to 7a98630e0de9 (1 revision) (flutter/engine#44436) 
https://skia.googlesource.com/skia.git/+log/f4047f002891..7a98630e0de9

2023-08-07 johnstiles@google.com Add an EmptyExpression IR element to SkSL.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jcgregorio@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-07 13:41:21 +00:00
skia-flutter-autoroll
e35df5ab5f Roll Skia from 9c4cfcd16529 to b7a1f4fdedc1 (2 revisions) (flutter/engine#44430) 
https://skia.googlesource.com/skia.git/+log/9c4cfcd16529..b7a1f4fdedc1

2023-08-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 0e52994bf1b6 to c8d53e7227c9
2023-08-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from ed824b45206d to 0e52994bf1b6 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jcgregorio@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-07 06:25:22 +00:00
skia-flutter-autoroll
192512edc6 Roll Fuchsia Linux SDK from 3uzA1Z-yaMQE_Cz5f... to QazMbN_0ttbJpf36s... (flutter/engine#44418) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-05 10:00:20 +00:00
skia-flutter-autoroll
2296c8190e Roll Dart SDK from 8a3277696c52 to 0816d590a220 (1 revision) (flutter/engine#44415) 
https://dart.googlesource.com/sdk.git/+log/8a3277696c52..0816d590a220

2023-08-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-41.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-05 05:01:21 +00:00
skia-flutter-autoroll
80058f6880 Roll Skia from b2a0382bb587 to 275bcb6d874d (3 revisions) (flutter/engine#44413) 
https://skia.googlesource.com/skia.git/+log/b2a0382bb587..275bcb6d874d

2023-08-05 armansito@google.com [graphite][dawn] Add method to compile WGSL source
2023-08-05 armansito@google.com [dawn] Fix deprecated adapter discovery API warnings
2023-08-05 armansito@google.com [viewer] Add a backend radio button for Dawn (Graphite)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-05 02:17:17 +00:00
Ricardo Amador
73d2e86c71 Mark the ci.yaml roller task so it is not backfilled. (flutter/engine#44409) 
In order to avoid new tasks from not being scheduled we are not going to backfill the autoroller because it can sometimes play transactions out of order causing issues with tasks that are scheduled but not known.

*List which issues are fixed by this PR. You must list at least one issue.*
Part of https://github.com/flutter/flutter/issues/127063

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-05 01:35:49 +00:00
skia-flutter-autoroll
81e66283e2 Roll Skia from 7cf7e2da3557 to b2a0382bb587 (1 revision) (flutter/engine#44407) 
https://skia.googlesource.com/skia.git/+log/7cf7e2da3557..b2a0382bb587

2023-08-04 johnstiles@google.com Fix Layout::operator==.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-04 22:30:05 +00:00
Chris Bracken
fe643d0859 [Darwin] Move FlutterBinaryMessengerRelay to common (flutter/engine#44395) 
Migrates FlutterBinaryMessengerRelay to
//flutter/shell/platform/darwin/common so that it can be used in a
followup patch on macOS, to fix a memory leak due to a retain cycle.

Migrates the unit tests to be compatible with gtest, which is used by
the darwin/common unit tests.

Issue: https://github.com/flutter/flutter/issues/116445


## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I signed the [CLA].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-08-04 15:24:22 -07:00
skia-flutter-autoroll
d8f06731cc Roll Dart SDK from a0b59bac20fc to 8a3277696c52 (1 revision) (flutter/engine#44405) 
https://dart.googlesource.com/sdk.git/+log/a0b59bac20fc..8a3277696c52

2023-08-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-40.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-04 22:06:45 +00:00
skia-flutter-autoroll
f5b92ea5ab Roll Fuchsia Linux SDK from ZvUiUZL9vUp2LcvHG... to 3uzA1Z-yaMQE_Cz5f... (flutter/engine#44403) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-04 21:10:14 +00:00
skia-flutter-autoroll
3404f7f504 Roll Skia from 6dc76e862f90 to 7cf7e2da3557 (1 revision) (flutter/engine#44402) 
https://skia.googlesource.com/skia.git/+log/6dc76e862f90..7cf7e2da3557

2023-08-04 jvanverth@google.com [graphite] Set up fallback colortype in rescale.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-04 20:32:23 +00:00
Chris Bracken
540a6f106b [Darwin] Enable ARC in darwin/common unit tests (flutter/engine#44396) 
The end goal is for all Objective-C code to be compiled with ARC enabled. The common framework code is already compiled with ARC enabled; this enables it for the tests as well.

This is prework before migrating FlutterBinaryMessengerRelay to the common Darwin code.

Issue: https://github.com/flutter/flutter/issues/116445

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-04 19:59:06 +00:00
skia-flutter-autoroll
f99a0384c8 Roll Skia from 45c0a830d805 to 6dc76e862f90 (2 revisions) (flutter/engine#44399) 
https://skia.googlesource.com/skia.git/+log/45c0a830d805..6dc76e862f90

2023-08-04 brianosman@google.com Split out BitmapProcState opts into separate cpp files
2023-08-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 3a9e9b939d56 to a535b00c46c5 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-04 19:38:01 +00:00
skia-flutter-autoroll
ea88117b90 Roll Skia from 85938bb68e75 to 45c0a830d805 (3 revisions) (flutter/engine#44397) 
https://skia.googlesource.com/skia.git/+log/85938bb68e75..45c0a830d805

2023-08-04 johnstiles@google.com Replace cool texture/sampler suffixes with boring ones.
2023-08-04 johnstiles@google.com Add support for passing a sampler to a function.
2023-08-04 bungeman@google.com [skunicode] Add empty icu_bidi_srcs for staging

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-04 18:54:09 +00:00
Matt2D
24596f463d Flutter iOS Interactive Keyboard: Take Screenshot and Handle Pointer Movement (flutter/engine#43972) 
This PR address the movement aspect of the flutter interactive keyboard. It handles pointer movement while a scroll view widget is visible, and the interactive behavior is chosen for keyboardDismissBehavior. This is a desired behavior of the keyboard that has not yet been implemented. 
Design Document:
https://docs.google.com/document/d/1-T7_0mSkXzPaWxveeypIzzzAdyo-EEuP5V84161foL4/edit?pli=1

Issues Address:
https://github.com/flutter/flutter/issues/57609

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-04 18:25:09 +00:00
skia-flutter-autoroll
72b816d387 Roll Dart SDK from b3372378e487 to a0b59bac20fc (1 revision) (flutter/engine#44393) 
https://dart.googlesource.com/sdk.git/+log/b3372378e487..a0b59bac20fc

2023-08-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-39.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-04 18:03:46 +00:00
skia-flutter-autoroll
0a0add737c Roll Skia from 5eef2e2b94b4 to 85938bb68e75 (1 revision) (flutter/engine#44392) 
https://skia.googlesource.com/skia.git/+log/5eef2e2b94b4..85938bb68e75

2023-08-04 johnstiles@google.com Fix MSAN uninitialized-value error in fuzzer harness.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-04 17:52:17 +00:00
Dan Field
1785eb5cb8 [Impeller] DlCanvas implementation wrapping Aiks canvas (flutter/engine#44248) 
Fixes https://github.com/flutter/flutter/issues/130141

The primary goal of this patch is to move dispatching of `dart:ui` `Canvas` commands to the UI thread.

Before this patch, the architecture is something like:

## UI Thread
- `dart:ui` talks to `DisplayListBuilder`, a `DlCanvas` implementation.
- `DisplayListBuilder` does some clip/bounds tracking and creates a `DisplayList` object that is held by `dart:ui`'s `Picture` objects.
- `DisplayList`s are added to `DisplayListLayer`s in `flow`. 

## Raster Thread
- `flow` flattens the various operations into a single `DisplayList` via another `DisplayListBuilder`.
- A `DlOpReceiver`implementation converts that `DisplayList` into an `Aiks` `Canvas`/`Picture`.

After this patch, the architecture instead looks like:

## UI Thread

- No change for Skia.
- If Impeller, use a new `DlCanvasImplementation` that talks to `Aiks`'s `Canvas`.
- If Impeller, `dart:ui` Picture's now hold an `Aiks` `Picture`, which get shared into `AiksLayer`s in `flow`.

## Raster thread

- No change for Skia, but some light refactoring for places that assumed a `DisplayListBuilder` where they really just needed a `DlCanvas`.
- The `Aiks` `Picture`s are combined using new API on `DlCanvas` and still backed by `Aiks`.

These changes show significant improvement on raster times on Android and only very small regressions on UI times in local testing, see https://gist.github.com/dnfield/26528090194c9f5abdbac13cdcbf4f79 for old gallery transition perf numbers.

Many of the other changes in this patch are related to the following:

- Making `DlRTree` usable for Impeller.
  - It would be nice to have a version of DlRTree that speaks `impeller::Rect`.
- Creating the requisite classes to support `EmbeddedViews` so that Desktop works.

This patch does not remove the `impeller::DlDispatcher`, which now would only be used in tests.
 2023-08-04 17:35:14 +00:00
gaaclarke
e37f78d0bd [Impeller] Added a doc page to point out important impeller benchmarks (flutter/engine#44333) 
My main goal here was to get a more clear picture of how the Vulkan implementation is performing in relation to the OpenGLES implementation.  There is a lot of conventional wisdom about what benchmarks to look at that isn't documented anywhere.  As we come to rely on benchmarks daily this should be updated.

issue: https://github.com/flutter/flutter/issues/131784
issue: https://github.com/flutter/flutter/issues/131782

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-04 17:12:06 +00:00
skia-flutter-autoroll
0bdfde8e27 Roll Skia from c40343629a6b to 5eef2e2b94b4 (1 revision) (flutter/engine#44391) 
https://skia.googlesource.com/skia.git/+log/c40343629a6b..5eef2e2b94b4

2023-08-04 brianosman@google.com Only skip Init_hsw when building for AVX2+

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-04 17:06:16 +00:00
skia-flutter-autoroll
0b7e5c00e5 Roll Skia from 03874e298589 to c40343629a6b (4 revisions) (flutter/engine#44389) 
https://skia.googlesource.com/skia.git/+log/03874e298589..c40343629a6b

2023-08-04 kjlubick@google.com Move GrAHardwareBufferUtils to include/android and split GL/VK parts
2023-08-04 brianosman@google.com Remove unnecessary (misleading) SkUtils_opts.h include
2023-08-04 brianosman@google.com Revert "Reland "Roll vulkanmemoryallocator to latest""
2023-08-04 johnstiles@google.com Eliminate DSLStatement.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-04 15:56:42 +00:00